Rename monolithic upgrade for 3.0-RC

To account for 2.12.6 being the current flavor of 2.12.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

minor updates to release notes

* formatting fixes
* make capitalization of headings more consistent
* replace remaining references to "OPAC"

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Juvenile-to-adult script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: documenting copy locations

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up client sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding search config info to client admin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding some use cases to MARC Batch Edit

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: documenting RDA 264

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up client sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

LP#1720345: ensure egEditFmRecord's customFieldTemplates is optional

This patch ensures that the custom-field-templates attribute of
the eg-edit-fm-record directive is strictly optional, fixing a
regression for instances of that directive that don't need that
attribute.

To test
-------
[1] Apply the patch.
[2] Verify that the Server Administration | Copy Tag Types and
    and Local Administration | Copy Tags admin interfaces
    allow you to create and edit values.
[3] Verify that the Serials Administration | Prediction
    Pattern Templates interface continues to work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Update RELEASE_NOTES_3_0.adoc

minor spelling corrections in the Acknowledgment section

Docs: info about LP #1622364

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: root.adoc can now compile

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Adding information on using native browser functionality

The section on setting a home page seemed out of place in the Log in section.
I moved it to a new section that covers best practices for using the browser,
which also includes earlier documentation on using tabs and new documentation
on disabling popup blockers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: Update login chapter
Some things have changed in the web client since this documentation was
first created. Removing the note that workstation registration is not required
and updating the caution on what happens when exiting the browser.

Previously, workstation registration was part of installing the staff client,
but since we have nothing to install, I added it to the logging in section. I
also removed a xul client feature from the main root.adoc.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

bump up monolithic schema update script for RC

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: Make sure all relevant triggers are disabled for bib visibility update

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: Retain the ingest.disable_authority_full_rec internal flag if it was missing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: Baseline trigger definition consistency

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: make config.metabib_field.display_field have same default

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: ensure asset.copy_tag_copy_map has fake FK

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: make new FK constraint consistent

The constraint fieldset_fieldset_group_fkey will now
do 'ON DELETE CASCADE' regardless of whether the database
was created from scratch or upgraded.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: sync up two authority stored functions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: add authority reingest

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: adjust computation of bre visibility attribute vector

This patch moves the computation of the visiblity attribute vector
on biblio.record_entry to a separate transaction. Credit to Chris Sharp
for ideas on speeding up this part of the upgrade.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1719726: add 1077 to 3.0-rc1 schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718036 Webstaff about page transatable

Make the About page "What Is Evergreen" text I18n-friendly.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1718036: Adding more information to About page

Adding a small description of Evergreen along with links to the web site,
documentation and license on the About page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
+ Minor formatting repairs to remove an extraneous '"', give the "What
Is..." section its own column, and avoid wide lines.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1718036 Webstaff about page

Adds a simple About page showing the EG server version number, accessed
from the "hamburger" (log out) menu.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: adding release note entry for docs re-org

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: replacing OPAC with Public catalog

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: streamlining release notes for user buckets; adding trimmed content to the manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Adding more acknowledgements for web client contributions
Adding contributors who participated through LP and by doing early testing
for Equinox.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Web client release notes and acknowledgements

Adding a special section on the web client to the release notes, as well as
acknnowledgements for everyone who has contributed to the project.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1714026: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1714026 - Schema-qualify maintain_control_numbers function.

On older Evergreen installs, it's possible to have both an
evergreen.maintain_control_numbers function and a
public.maintain_control_numbers function.  Let's remove the
duplicate one and go ahead and assign it a schema to live in,
shall we?

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1622696: don't ask to credit card type

Due to bug 1474051, we're not storing it, so don't request it.

It should be noted that this patch series does /not/ add support
for using Stripe as a payment processor for staff-mediated payments,
but the web staff client opens the door to adding it later.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1622696 Webstaff credit card payment support

Support collecting credit card info for both EG-processed and
externally-processed credit card payments, consistent with the XUL
client.

Refactor the chain of events leading up to payment submission,
including verifying warning-level payment amounts, annotating payments,
and collecting credit card data so the user is able to perform any or
all of these steps and cleanly cancel at any point along the way.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1719694: Add missing column in baseline schema for batch patron edit

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1713764: fix 'Retrieve Patron' action from webstaff pull list

This patch fixes a regression wherein the Retrieve Patron action
didn't work on the pull list grid by ensuring that the user value
would get fleshed.

To test
-------
[1] Go to the pull list in the web staff client and attempt the
    'Retrieve Patron' action. Note that nothing happens.
[2] Apply the patch and repeat step 1; this time, a new window
    should be opened with the patron record.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1643927 Copy note captures initials; shows date

Fixes thinko in copy note staff initials tracking.  Offloads the
formatting of the copy note to egStrings.  Adds the workstation org unit
to the initials block a la the XUL client.

This does not add the create date to the initials block as with the XUL
client, because the create date is part of the note.  Instead, we now
display the note create date in the copy note display form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1622364 Avoid precat dialog submit on ISBN enter

Avoid submitting the precat copy checkout entry form when the Enter key
is pressed on the ISBN field.  Do this to allow scanners to enter ISBN
data without automatically submitting the form.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1717777: Ensure the en-US is always represented in the dropdown

The assumption of an array in the eval'd code was causing the forced
en_us tag to fail.  Here we push the default en_us into the list of
locales in a more structured way to ensure that failure doesn't happen.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: Add an entry for web staff client offline circ

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

More release note edits for 3.0

Minor copy editing for 3.0 release note.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

forward-port 2.12.5-2.12.6 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Forward-port 2.11.9 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1718549: Bump NodeJS version to v6.11.3

Latest LTS release for NodeJS is v6.11.3. Should update this periodically
depending on releases by that community.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718549: Use Nodejs source install for all distributions

Due to dependency issues and the need for newer NodeJS version, install
from source for all distributions, not just the ones without pre-packaged
apt sources.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718301: catch it when multiple connection attempts fail

Lovefield only allows a single connection at a time, and throws
an exception if a second attempt is made.  In the context of a
page app, wrapping the connection attempt in a promise takes
care of it, but for the test suite, the egLoveField service
gets completely reinitialized... but Lovefield itself still
thinks it's in the middle of connecting.

This patch catches the exception and allows the test suite to
pass, without otherwise affecting use in a real browser.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1717777: absorb all PO files for a locale

We assumed only one file per locale, but apache <Location>s because are not
independent WRT locale helpers in mod_perl, we need to load all files from
all <Location> directives for a given locale.

NOTE: there is a risk of translation collision, where the same key string in
two PO files have different translations, but in our context that is almost
surely a mistake.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1700635: enable eg-marc-editor for queued records in MARC Batch Import/Export

This enables the angular modal marc-editor to be called from
the vandelay dojo UI in the iFrame.

To test:

[1] In the web staff client, go to MARC Batch Import/Export and load
    some records in a Vandelay queue.
[2] Inspect the queue and choose View MARC.
[3] Click the Edit button, and verify that it brings up the
    web staff MARC editor.
[4] Make a change, then click Modify, then click Use Edits.
[5] Verify that the MARC view reflects the updated record.
[6] Go back to the queue. If the bib was /not/ imported into
    Evergreen, the bib attributes may change.
[7] Verify that steps 1-6 in the XUL client work (and that the XUL
    MARC editor is displayed).

Note that this patch doesn't ensure that the modal can save the
record and be dismissed via just a single click of the Modify button;
an issue was discovered with that that could not be resolved in time
for beta2.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Minor documentation adjustment for upgrade instructions

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1715503: make eg_db_config refuse to create DB if min Pg version not met

This patch ensures that eg_db_config --create-database will abort if
the Pg version is not at least 9.4. It also tweaks the version check
to (in principle) work for Pg 10.

This patch also removes some stuff related to support Pg versions
less than 9.4, most notably using contribs rather than extensions.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1715503: make upgrade script abort if not running min support version

This patch causes the monolithic upgrade script to fail if the
database its connecting to isn't running at least Pg 9.4.

To test
-------
[1] Verify that 2.12.5-3.0-beta1-upgrade-db.sql will abort
    if used in a Pg database < 9.4; verify that it will work
    if the Pg version is at least 9.4

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1715503: update install & upgrade doc to require Pg 9.4

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1718300: fold update into 2.12.5-3.0-beta schema update

This saves a step for building the beta2 release, as
2.12.5-3.0-beta1-upgrade-db.sql will be moved to
2.12.5-3.0-beta2-upgrade-db.sql.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718300: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718300: Fix serial.unit visibility at creation time

The new copy visibility trigger was not taking into account a particular
dataflow that is common to the serial checkin process.  This branch
addressed that case where the call number of a copy changes, requiring
an update of one row on the cache table.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718301 Offline db connections via promise

Refactors offline DB connection call to return a promise, resolved upon
successful connection, instead of polling for a successful connection
within the connect call.

Multiple calls to the main egLoveField connect function will result in
resolvers being linked to the same in-progress promise.

Check for connection errors via the database.connect() reject handler.

Avoid attempts to connect to the offline DB until egLoveField.connectOrGo()
is called the first time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: fixup asciidoc syntax for main install README

Signed-off-by: Ben Shum <ben@evergreener.net>

add acknowledgments dervied from Git history

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

move significant upgrade considerations to one section in release notes

Also cite 3.0.0 as minimum required version of OpenSRF

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: bump up minimum required OpenSRF version

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: mention Stretch support in upgrade doc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: Fix ld issues by renaming libraries.

We add the lib... prefix to all C library names as expected by most
linkers.  This necessitates changes to the opensrf.xml configuration
file.

Debian 9's ld also apparently requires that ldconfig be run again
after the Evergreen C libraries are installed, so we add that step to
the installation instructions as well.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: Add support for Debian 9 Stretch

  - Add new make target "debian-stretch"
  - Add PG 9.6 options
  - Add Stretch references to README

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 2.12.6 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.9 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1629078: Add missing strings in web client for i18n

Linda Jansova found a series of strings that were missing the localization
tagging indicated by the "l" function we use in tt2 code.

This patch adds them in preparation for the next PO template sync to grab
them to make them available for translation via Launchpad, etc.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1706124: minor tweaks

- change name of setting to better match local convention
- adjust whitespace

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1706124: Make include inactive patrons checkbox sticky

The state of the 'include inactive' checkbox on the patron search page will now
be remembered when users return to the page. Many thanks to Cesar Velez,
whose code for bug 1697754 inspired this patch!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs: cleaning up cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: fixing small mistake in cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1717715: Fix typo in webstaff serials

Eva Cerninakova noticed a typo in the web client during translation work.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1537233 Copy bucket handles mis-scans, improve focus

Show warning message to user when an unknown barcode is scanned in the
copy bucket pending list UI.  Also, after a barcode failure occurs, select
the barcode text (instead of clearing it) so it can be seen and easily
replaced, consistent with the item status UI.

After successful scan, clear and re-focus the barcode input box.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1712637 Patron edit hold pickup location repairs

1. Allow setting the hold pickup location independant of the home
   library.

2. Disable org units in the pickup lib selector that are not viable hold
   pickup locations (can_have_vols=f)

3. Consistent w/ the XUL client, allow a patron to be created without
   selecting a default pickup location.

To test:

[1] Register a new patron and confirm pickup location is initialy unset.
[2] Confirm pickup lib options are viable pickup locations.
[3] Apply a pickup location different from the home library and confirm
    the home library selector remains unchanged.
[4] Confirm saving the patron applies the expected pickup location value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs reorg: splitting action/triggers into command-line and staff-client manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding the MARC Templates documentation back

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: TPAC bib_source variable

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about purging patron data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: ebook api integrations from release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: moving SQL from circ manual to command line sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about TPAC microdata + linked data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Moving clark_kent to the command line manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Removing zip code setup from staff client admin

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up headings, other small fixes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding screenshot of uncataloged types editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about pre-cat and non-cat for sysadmins

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs reorg: splitting self-check documentation into appropriate manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1705068 - fix workstation already exists cancel btn freezes UI

The $scope.is_registering is used to enable/disable the Register btn
and was not being set back to false, when the user chose to cancel
using an existing WS name, and exiting the modal.

To test
-------
1. Register a workstation.
2. Switch to a different computer or Chrome profile.
3. Try to register the same workstation name. Warning dialog will pop
   up.
4. Click cancel.
5. See that the register button is now disabled and no actions on the
   form seem to reactivate it.
6. Apply the patch and repeat steps 2-4. This time, the register button
   should be active.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1713151: display owning OU in volcopy editor location selector

This patch causes the short name of the OU that owns a location
to be displayed after the location name in shelving location selectors
in the item attribute and copy template editors.

To test
-------
[1] Edit an item and verify that the shelving location selector
    displays the org unit shortname in parentheses after the location
    name.
[2] Verify that the location selector in the copy template portion
    also displays the OU short names.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1708951: fix tabbing in webstaff catalog app for Firefox

This patch works around an issue where Firefox appears to require
that the iframe for the embedded OPAC not have a null catalog_url
value. It also fixes an issue where navigating to the OPAC View tab
after retrieving the record with a different default view set would
cause it to jump back to that default view... the first time.

To test:

[1] In the web staff client, retrieve a bib record and set the default
    view to a tab other than 'OPAC View'.
[2] Retrieve another bib by TCN or ID. Note that although the default tab
    will briefly display, the page will jump over to the OPAC view and
    display an empty record.
[3] Apply the patch and repeat step 2. This time, it should display the
    record with the current default view.
[4] Select the 'OPAC View' tab and verify that it loads the record details
    page.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>