contrib/Conifer.git
12 years agoAsciidoc edit for My Lists documentation
Angela Kilsdonk [Fri, 7 Jun 2013 14:04:27 +0000 (10:04 -0400)]
Asciidoc edit for My Lists documentation

Change to asciidoc structure in opac/my_lists.txt

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoAcq: Be fuzzy about case when retrieving EDI documents
Lebbeous Fogle-Weekley [Mon, 15 Apr 2013 18:06:54 +0000 (14:06 -0400)]
Acq: Be fuzzy about case when retrieving EDI documents

The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
other things, try to avoid fetching the same EDI document multiple times
when many rows in acq.edi_account refer to the same host and login
credentials.

Since in practice most vendors seem to run FTP servers for EDI on
Windows, not UNIX, and pathnames are therefore case-insensitive, that
test for other occurrences ought also to be case-insensitive.

If I were to look at this as a purist, I could argue that vendor servers
might sometimes by run on UNIX, and that for some reason it is possible
that different vendor-to-buyer EDI documents (order responses or
invoices) could have pathnames that differ only in the case of some
characters.  But that seems wildly unlikely.  If anyone does take this
possibility seriously, perhaps acq.edi_account needs a Boolean column to
indicate the remote host's case [in]sensitivity.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoFedora RPM for bzip2 headers is bzip2-devel
Dan Scott [Thu, 6 Jun 2013 13:40:59 +0000 (09:40 -0400)]
Fedora RPM for bzip2 headers is bzip2-devel

There was an attempt to add the right RPM for the bzip2 headers in
Makefile.install, but that failed on Fedora 19. Swap in bzip2-devel
instead to correct that.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAsciidoc fix for documentation
Angela Kilsdonk [Thu, 6 Jun 2013 14:38:42 +0000 (10:38 -0400)]
Asciidoc fix for documentation

Fixed faulty asciidoc in docs/admin/lsa-library_settings_editor.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoLP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record
Simon Hieu Mai [Mon, 3 Jun 2013 21:45:08 +0000 (17:45 -0400)]
LP#1053074: Editimg MARC Fixed Fields jumps cursor to marc record

Put the cursor back to the current fixed field after reload
the MARC record table.

Signed-off-by: Simon Hieu Mai <hieu.mai@mnsu.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoLP1183340 selectivly apply editable funds sorting
Bill Erickson [Thu, 23 May 2013 13:11:25 +0000 (09:11 -0400)]
LP1183340 selectivly apply editable funds sorting

Avoid sorting editable funds to the front of the fund list when there
are no org units at which the user has the ADMIN_ACQ_FUND permission.
Otherwise, we are sorting on an empty 'IN' list in pcrud, which results
in an error.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoDocumentation for preset tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:13:13 +0000 (01:13 -0400)]
Documentation for preset tabs and auto login

Missed the actual documentation in the last commit for preset tabs and
auto login docs. Here it is.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
12 years agoPre-set tabs and auto login
Tracy Swaim [Sat, 1 Jun 2013 05:00:26 +0000 (01:00 -0400)]
Pre-set tabs and auto login

Adding staff client documentation for pre-set tabs and auto login.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
12 years agoAcquisitions Admin updates
Kathy Lussier [Sat, 25 May 2013 00:52:01 +0000 (20:52 -0400)]
Acquisitions Admin updates

Updates to the chapter on acquisitions administration, including 1) the
reintroduction of the Providers section, which appears to have dropped out
of the docs after 2.1 2) the new default # copies and improvements to
distributions formulas introduced in 2.4 and 3) minor copy editing.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
12 years agoDocumentation for Org Unit Hiding in TPAC
Angela Kilsdonk [Fri, 31 May 2013 19:09:11 +0000 (15:09 -0400)]
Documentation for Org Unit Hiding in TPAC

Added Org Unit Hiding in TPAC documentation to admin/lsa-library_settings_editor.txt.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoDocumentation for Call Numbers in My Lists
Angela Kilsdonk [Thu, 30 May 2013 15:12:40 +0000 (11:12 -0400)]
Documentation for Call Numbers in My Lists

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoLP1081576 - fix utf8 characters in searches using portal page
Ben Shum [Thu, 23 May 2013 20:32:49 +0000 (16:32 -0400)]
LP1081576 - fix utf8 characters in searches using portal page

Replace escape() with encodeURIComponent() on the portal page to allow utf8
characters to be passed more appropriately to the subsequent search in catalog.

Thanks Dan Scott for pointing this out.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
12 years agoDocumentation updates for acquisitions invoices
Kathy Lussier [Thu, 30 May 2013 17:01:38 +0000 (13:01 -0400)]
Documentation updates for acquisitions invoices

Updates to acquisitions invoices documentation, including new 2.4
features. Also moves up some 2.1 documentation that is still relevant.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
12 years agoLP1168186 - Add tag 111 and remove subfield 4 from author pool
Ben Shum [Sun, 14 Apr 2013 02:28:53 +0000 (22:28 -0400)]
LP1168186 - Add tag 111 and remove subfield 4 from author pool

Add meeting/conference main entry (111) to TPAC author pool.

Remove subfield 4 from the author data because the information contained
refers to relator and may not be helpful at this time.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
12 years agoAdd corporate author (110) to TPAC author pool
Dan Wells [Thu, 11 Apr 2013 23:54:12 +0000 (19:54 -0400)]
Add corporate author (110) to TPAC author pool

As requested in LP#1168186, here is a simple attempt to add corporate
authors to the author 'pool' in TPAC.

We may also want to consider adding 111 (meeting or conference as
main entry), but that isn't totally clear cut.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoDocumentation for Best Hold Selection Sort Order
Angela Kilsdonk [Wed, 29 May 2013 19:44:56 +0000 (15:44 -0400)]
Documentation for Best Hold Selection Sort Order

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoUpdated root
Angela Kilsdonk [Wed, 29 May 2013 19:40:19 +0000 (15:40 -0400)]
Updated root

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
12 years agoOrg Unit Proximity Adjustment documentation
akilsdonk [Wed, 29 May 2013 18:59:48 +0000 (14:59 -0400)]
Org Unit Proximity Adjustment documentation

Signed-off-by: akilsdonk <akilsdonk@esilibrary.com>
12 years agoLP1183357 Pass locale to bib search (tpac)
Bill Erickson [Thu, 23 May 2013 13:43:52 +0000 (09:43 -0400)]
LP1183357 Pass locale to bib search (tpac)

Pass the TPAC locale value, which is collected at each page load, to the
bib search API call.  This allows us to take advantage of language-based
relevance bumps.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoTPAC: Death date missing from authors in record details
Dan Scott [Fri, 10 May 2013 17:12:55 +0000 (13:12 -0400)]
TPAC: Death date missing from authors in record details

The trailing period prescribed by ISBD punctuation for x00 $d subfields
in certain circumstances confounds the regex that was expected the $d
subfield to match ^\s*\d{4}-\d{4}\s*$. As a result, death dates were
often being omitted from the record detail display. Relaxing the regex
to match against a trailing .* instead of \s* resolves the issue.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoFix Launchpad Bug 1183418.
Jason Stephenson [Thu, 23 May 2013 15:44:05 +0000 (11:44 -0400)]
Fix Launchpad Bug 1183418.

Clicking on an author with a dash or dates in the name on the search
results page comes up with 0 results. It looks like the dash is stripped
from the date and/or name.

Clicking on such a link from the record view actually works because
the dash is replaced with a space.

This branch changes table.tt2 to replace special characters in author
output with a space in the same way that authors.tt2 does.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoLP#1182360: typo fix
Galen Charlton [Tue, 21 May 2013 19:00:13 +0000 (15:00 -0400)]
LP#1182360: typo fix

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoDatabase upgrade script for 2.2.9
Lebbeous Fogle-Weekley [Thu, 16 May 2013 20:12:14 +0000 (16:12 -0400)]
Database upgrade script for 2.2.9

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
12 years ago2.3.6 -> 2.3.7 DB upgrade script
Bill Erickson [Thu, 16 May 2013 19:52:38 +0000 (15:52 -0400)]
2.3.6 -> 2.3.7 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoCorrect subfield format for authority lookup
Mike Rylander [Fri, 19 Apr 2013 20:14:13 +0000 (16:14 -0400)]
Correct subfield format for authority lookup

The Authority Control Set code expects the format of subfields
that it will be used to build a MARC.Field object to be of the
form: [[code,value],...]  This commit makes that true.

Additionally, dojo.filter over a list of lists can cause the
nested array set to be flattened.  So, instead, we loop directly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoRepair faulty MARC editor authority validation
Bill Erickson [Thu, 16 May 2013 13:11:50 +0000 (09:11 -0400)]
Repair faulty MARC editor authority validation

Repair how the JS inspects the results of
open-ils.search.authority.simple_heading.from_xml.batch.atomic, which is
used to look up matches for authority validation.  It returns a more
complex structure in the brave new world of authority control sets.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoApply all 2.2 upgrades prior to running 2.3.0 upgrade
Dan Scott [Tue, 29 Jan 2013 16:04:33 +0000 (11:04 -0500)]
Apply all 2.2 upgrades prior to running 2.3.0 upgrade

If users are expected to run all of the 2.2 upgrade scripts, then let's
make it easy for them. As PostgreSQL 9.1 does not include the \ir
"include relative path" command, we have to pause at the beginning of
the upgrade process to ensure that the user is running the script from
the right directory.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoLP#118066: fix searches that failed because punctuation was a token in query
Galen Charlton [Tue, 14 May 2013 19:33:54 +0000 (15:33 -0400)]
LP#118066: fix searches that failed because punctuation was a token in query

When building the text array literal to pass to evergreen.rel_bump,
make sure that tokens that get {search_}normalize{d} away
don't result in syntax errors.

With this patch, searches like the following will work again:

keyword:Take me to the river / Al Green and Mabon

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
12 years agoLP1179614 - fix Export All Records action
Ben Shum [Mon, 13 May 2013 18:19:06 +0000 (14:19 -0400)]
LP1179614 - fix Export All Records action

In the record buckets, the button for 'Export All Records' would work up
to the point where you chose where to save the file. After clicking where
to save, it would not show any saved files or prompts indicating it completed
the export process.

This fix changes the location of where to find the export tool and properly
exports the bibs as the file format selected.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoSerials: MFHD::get_compressed_holdings() can reach infinite loop
Lebbeous Fogle-Weekley [Mon, 6 May 2013 18:15:18 +0000 (14:15 -0400)]
Serials: MFHD::get_compressed_holdings() can reach infinite loop

Even controlled serials holdings involve the internal creation of MFHD
fields, upon which caculations are performed for such purposes as the
display of holdings summaries in the OPAC.

There are too many ways that incorrect MFHD (or MFHD that our code just
can't yet handle) can lead our MFHD routines to crash. We can't address
all these possibilities in a single bug fix. But we can avoid this
infinite loop.

A subroutine within open-ils.serial (_summarize_contents()) relies on
MFHD::get_compressed_holdings(). When the latter went into an infinite
loop the result would be an open-il.serial drone process consuming CPU
time indefinitely and, depending on the data that provoked the loop,
potentially writing repeating messages to stderr indefinitely.

End users will still see the item receiving fail in these cases, and be
obliged to work around the issue as before until more robust
holdings summarization code can be written, but at least the overall
condition of the running Evergreen system won't be affected, and there
will be better information in the error logs.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoSerials: Test method to identify holdings that lead to summarization bugs
Lebbeous Fogle-Weekley [Mon, 6 May 2013 18:13:13 +0000 (14:13 -0400)]
Serials: Test method to identify holdings that lead to summarization bugs

This adds a simple test method that allows testing of problem holdings.
See the next commit.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
12 years agoLP#1176206: improve deadlock handling in 2.3-2.4-supplemental.sh
Galen Charlton [Fri, 3 May 2013 21:20:21 +0000 (17:20 -0400)]
LP#1176206: improve deadlock handling in 2.3-2.4-supplemental.sh

- make sure that it doesn't attempt to create more than one
  index at a time for a given table
- if deadlocks occur (because of a PostgreSQL bug whose fix
  isn't slated for release until after April 2013), find
  and recreate the affected indexes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoExports are broken
Mark Cooper [Mon, 6 May 2013 19:37:32 +0000 (12:37 -0700)]
Exports are broken

Proposed fix for lp1175816, tested with 2.3.2 / 2.4.0.

Signed-off-by: Mark Cooper <markchristophercooper@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoAdd support for CAS intro in tpac for rel_2_4_mergery
Art Rhyno [Fri, 24 May 2013 15:24:53 +0000 (11:24 -0400)]
Add support for CAS intro in tpac for rel_2_4_mergery

These changes allow a CAS intro to be put in place before
a patron is sent off to the CAS service from the tpac. CAS
logins can be a jarring experience since the interface is
controlled by the validating organization.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMerge remote-tracking branch 'conifer/feature/tpac_show_details_config_2_4' into...
Dan Scott [Wed, 8 May 2013 14:51:00 +0000 (10:51 -0400)]
Merge remote-tracking branch 'conifer/feature/tpac_show_details_config_2_4' into rel_2_4_mergery

12 years agoTPAC: Make "Show more details" in results optional feature/tpac_show_details_config_2_4
Art Rhyno [Mon, 13 Aug 2012 21:22:17 +0000 (17:22 -0400)]
TPAC: Make "Show more details" in results optional

Academic sites typically handle a lot of electronic content and want to
bring most details about entries, such as availability, status, and
URLs, on a results screen to the front.

This adds a 'show_more_details.default' option in 'config.tt2' that can
have the values 'true', 'false' and 'hide'.  The 'true' and 'false'
values set the default for the button to more and less respectively, and
'hide' suppresses the button from showing at all.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMerge remote-tracking branch 'conifer/feature/ldap_osul_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:49:05 +0000 (10:49 -0400)]
Merge remote-tracking branch 'conifer/feature/ldap_osul_2_4' into rel_2_4_mergery

12 years agoAdd an ou_host_name parameter for TPAC login forms
Dan Scott [Thu, 30 Aug 2012 14:48:32 +0000 (10:48 -0400)]
Add an ou_host_name parameter for TPAC login forms

If set, and the incoming username does not already include an '@' symbol
(a very simple attempt to detect if we're already dealing with an email
address), then append '@' + the ou_host_name value to the username for
authentication purposes.

The rationale is that in a large consortium, you might want to enable
users to log in with short usernames (like 'fred'), but you also want to
avoid conflicts between short usernames at different organizational
units. Thus, create the users with the email equivalent of their
usernames, like 'fred@br1.example.com' and 'fred@br4.example.com', and
let the templates for the TPAC in br1 and br4 contain a hidden input
field to append the appropriate email hostname.

Truth be told, this is probably most appropriate for a large consortium
containing two or more academic institutions that hope to use LDAP
authentication rather than native authentication, and therefore have
LDAP CNs that map to email addresses of CN@hostname that can then be
mapped to actor.usr.usrname (and actor.usr.email, of course).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoVery rough LDAP authentication enablement for OSUL
Dan Scott [Mon, 27 Aug 2012 22:38:51 +0000 (18:38 -0400)]
Very rough LDAP authentication enablement for OSUL

Currently requires that the user enters their email address at the
username prompt; we then just use the local-part of the email address to
authenticate against the LDAP server.

In the VirtualHost sections of Apache, we can use SetEnv to force the
physical_loc to match the org unit ID(s) specified in opensrf.xml; for
example:

SetEnv physical_loc 103

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMerge remote-tracking branch 'conifer/feature/hold_slip_format_due_date' into rel_2_4...
Dan Scott [Wed, 8 May 2013 14:46:24 +0000 (10:46 -0400)]
Merge remote-tracking branch 'conifer/feature/hold_slip_format_due_date' into rel_2_4_mergery

12 years agoMerge remote-tracking branch 'conifer/feature/CAS_auth_dynamic_links_2_4' into rel_2_...
Dan Scott [Wed, 8 May 2013 14:46:13 +0000 (10:46 -0400)]
Merge remote-tracking branch 'conifer/feature/CAS_auth_dynamic_links_2_4' into rel_2_4_mergery

12 years agoMerge remote-tracking branch 'conifer/bugfix/recall_not_more_than_loan_2_4' into...
Dan Scott [Wed, 8 May 2013 14:45:58 +0000 (10:45 -0400)]
Merge remote-tracking branch 'conifer/bugfix/recall_not_more_than_loan_2_4' into rel_2_4_mergery

12 years agoMerge remote-tracking branch 'conifer/feature/callno_tpac_template_2_4' into rel_2_4_...
Dan Scott [Wed, 8 May 2013 14:45:44 +0000 (10:45 -0400)]
Merge remote-tracking branch 'conifer/feature/callno_tpac_template_2_4' into rel_2_4_mergery

12 years agoMerge branch 'feature/barcode_generator_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:44:46 +0000 (10:44 -0400)]
Merge branch 'feature/barcode_generator_2_4' into rel_2_4_mergery

12 years agoMerge remote-tracking branch 'conifer/feature/patron-privacy_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:44:36 +0000 (10:44 -0400)]
Merge remote-tracking branch 'conifer/feature/patron-privacy_2_4' into rel_2_4_mergery

12 years agoMerge branch 'feature/move_to_storage_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:44:27 +0000 (10:44 -0400)]
Merge branch 'feature/move_to_storage_2_4' into rel_2_4_mergery

12 years agoAdd production "moveto" options
Dan Scott [Wed, 8 May 2013 14:43:41 +0000 (10:43 -0400)]
Add production "moveto" options

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMove the moveto to the new moveto template place
Dan Scott [Mon, 1 Oct 2012 17:54:34 +0000 (13:54 -0400)]
Move the moveto to the new moveto template place

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd "Move to storage" quick UI for bulk location moves
Dan Scott [Mon, 30 May 2011 19:23:09 +0000 (15:23 -0400)]
Add "Move to storage" quick UI for bulk location moves

This simplistic interface accepts a barcode and immediately returns
some bibliographic information if the barcode was found - and the
item is moved immediately to the specified location. Goal was to
minimize clicking, this pretty much requires just scan scan scan.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoMerge remote-tracking branch 'conifer/feature/marctemplates_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:24:39 +0000 (10:24 -0400)]
Merge remote-tracking branch 'conifer/feature/marctemplates_2_4' into rel_2_4_mergery

12 years agoMerge remote-tracking branch 'conifer/feature/fts-polish-l_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:24:32 +0000 (10:24 -0400)]
Merge remote-tracking branch 'conifer/feature/fts-polish-l_2_4' into rel_2_4_mergery

12 years agoMerge branch 'feature/circ_scripts_2_4' into rel_2_4_mergery
Dan Scott [Wed, 8 May 2013 14:23:54 +0000 (10:23 -0400)]
Merge branch 'feature/circ_scripts_2_4' into rel_2_4_mergery

12 years agoMEDIACEN doesn't charge anything on AV-EQUIP items feature/circ_scripts_2_4
Dan Scott [Mon, 24 Sep 2012 18:03:18 +0000 (14:03 -0400)]
MEDIACEN doesn't charge anything on AV-EQUIP items

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd 3-day loan rule for AV-EQUIP for media centre
Dan Scott [Mon, 24 Sep 2012 14:36:28 +0000 (10:36 -0400)]
Add 3-day loan rule for AV-EQUIP for media centre

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoPrevent renew if item already is targeted for a hold
Dan Scott [Tue, 14 Feb 2012 15:46:24 +0000 (10:46 -0500)]
Prevent renew if item already is targeted for a hold

From http://biblio.laurentian.ca/tickets/conifer/wiki/devHolds
apparently I missed this in moving our customizations from SVN (or it
was only ever local?)

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoOSBO: Accidental copying of the "DVD VIDEO" rule
Dan Scott [Fri, 23 Sep 2011 20:40:38 +0000 (16:40 -0400)]
OSBO: Accidental copying of the "DVD VIDEO" rule

Meant to remove the "DVD" from the "DVD VIDEO" part of the circ modifier
the second time around.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoOSBO really did want $0.25/hour for all reserve periods
Dan Scott [Tue, 20 Sep 2011 17:01:32 +0000 (13:01 -0400)]
OSBO really did want $0.25/hour for all reserve periods

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd Reserve circ rules for Boreal
Dan Scott [Thu, 1 Sep 2011 19:01:39 +0000 (15:01 -0400)]
Add Reserve circ rules for Boreal

Still need some clarification on how these rules are to be applied, but
better to get the durations working right now and fix up the fines
later.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd LEDL MISC to the list of allowed circ modifiers for Leddy
Dan Scott [Mon, 15 Aug 2011 17:10:17 +0000 (13:10 -0400)]
Add LEDL MISC to the list of allowed circ modifiers for Leddy

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd ILL-BOOK to the list of allowed circ modifiers for Leddy
Dan Scott [Mon, 15 Aug 2011 17:08:55 +0000 (13:08 -0400)]
Add ILL-BOOK to the list of allowed circ modifiers for Leddy

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd LEDL MISC 1 year 0 renew rule
Dan Scott [Thu, 11 Aug 2011 13:42:30 +0000 (09:42 -0400)]
Add LEDL MISC 1 year 0 renew rule

This had been working in production, but apparently never got
checked into git?

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd Boreal circulation rules
Dan Scott [Thu, 21 Jul 2011 19:08:53 +0000 (15:08 -0400)]
Add Boreal circulation rules

Still need to add their limits based on user profile & item type

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd ILL-BOOK circ rule for OWA
Dan Scott [Mon, 20 Jun 2011 17:54:23 +0000 (13:54 -0400)]
Add ILL-BOOK circ rule for OWA

Per ticket #683:

Loan period of 3 weeks
NO RENEWALS

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTrack Conifer JavaScript circulation rules
Dan Scott [Mon, 30 May 2011 02:18:04 +0000 (22:18 -0400)]
Track Conifer JavaScript circulation rules

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoGeneric patron barcode generation (OpenSRF and DB) feature/barcode_generator_2_4
Dan Scott [Thu, 10 Jan 2013 19:17:33 +0000 (14:17 -0500)]
Generic patron barcode generation (OpenSRF and DB)

Laurentian University needed the ability to generate barcodes as part of
its LDAP integration work, and the first generation (so to speak) of the
was specific to LU - including hard-coded prefixes and database
functions that include the "lu" name.

This commit makes the functionality much more generic and thus more
likely to be able to be adopted by other institutions. The principle
components are:

Database functions:

evergreen.actor_generate_barcode([prefix TEXT]) - returns a 14-digit
  barcode from the evergreen.actor_barcode_seq sequence with a prefix of
  'AUTOBC' or the specific prefix of up to 6 characters. If the
  resulting barcode is all digits, then the 14th character will be a
  mod10 check digit; otherwise the 14th digit will be '0'.

evergreen.actor_update_barcode(usr_id INTEGER[, prefix TEXT]) -
  generates a new barcode for the specified user, with the optional
  barcode prefix.

evergreen.mod10(barcode TEXT) - given a barcode, generates a mod10
  check digit and returns the barcode with the appended check digit

OpenSRF method:

open-ils.actor.generate_patron_barcode([usr_id INT[, prefix TEXT]]) -
  generates a new barcode for the patron

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd and use a patron search that overrides opt-in invisibility
Dan Scott [Wed, 14 Sep 2011 20:02:14 +0000 (16:02 -0400)]
Add and use a patron search that overrides opt-in invisibility

Something like this is required for API calls that need to operate
against a number of libraries in a given instance that are using opt-in;
otherwise, attempts to search for users will fail and you may end up
creating near-duplicates etc.

The implementation adds an
open-ils.actor.search.patron.advanced.opt_in_override method to
open-ils.actor, which, if invoked, checks to see if the caller has the
OPT_IN_OVERRIDE permission. If so, then the crazy_search ignores the
normal opt-in limits and searches all pertinent users in the database.

As a global permission, OPT_IN_OVERRIDE is a blunt instrument. Others
might want to put together a more refined version that uses OU depths to
define boundaries.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/actor.pm

12 years agoRemove extraneous spaces from bib email template feature/callno_tpac_template_2_4
Dan Scott [Tue, 9 Oct 2012 16:21:10 +0000 (12:21 -0400)]
Remove extraneous spaces from bib email template

Various email servers refuse to send email that begins with blank lines,
so use TT's [%- and -%] to eat up whitespace. Also, remove the extra
linefeeds (_ "\n") as the linefeed is already generated by virtue of
being on its own line.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd line return to URL entry
Art Rhyno [Mon, 1 Oct 2012 02:58:52 +0000 (22:58 -0400)]
Add line return to URL entry

I missed this in the URL rendering but lines need a line return
for the e-mail option.

12 years agoAdd option for host value in URLs
Art Rhyno [Mon, 1 Oct 2012 02:50:09 +0000 (22:50 -0400)]
Add option for host value in URLs

The ability to link back to a bib record for print and e-mail displays
from tpac is very useful, esp. for e-mail where there is a good chance
that the mail system will make it an active link. It looks possible to
wire in environmental variables with the template toolkit but that's
probably as complicated as it is to modify the template directly.

12 years agoAdd call number and location info to TPAC e-mail and print option
Art Rhyno [Thu, 27 Sep 2012 02:34:48 +0000 (22:34 -0400)]
Add call number and location info to TPAC e-mail and print option

I haven't figured out how to get the hostname properly, I am guessing
it needs to be passed as a parameter somehow. I also need to test
URIs but this is a start.

12 years agoMake Date Addition for Hold Receipt Configurable on Client feature/hold_slip_format_due_date
Art Rhyno [Tue, 12 Feb 2013 16:25:08 +0000 (11:25 -0500)]
Make Date Addition for Hold Receipt Configurable on Client

As per Dan Scott's suggestion, this changes the print_win.js
function for formatting the holds date receipt to allow
the number of days to be specified with the "add_days" attribute.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
12 years agoHold Slip Formatting for Windsor
Art Rhyno [Wed, 30 Jan 2013 13:34:24 +0000 (08:34 -0500)]
Hold Slip Formatting for Windsor

The Leddy Library used some custom javascript for adding a due date
to the Hold Slip in a previous version of Evergreen. This uses the
far cleaner print_win.js setup to bring this back.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
12 years agoFix CAS to handle dynamic auth links feature/CAS_auth_dynamic_links_2_4
Art Rhyno [Fri, 8 Mar 2013 12:55:06 +0000 (07:55 -0500)]
Fix CAS to handle dynamic auth links

CAS uses a "service" URL to redirect a user back to where an application wants
them to go if authentication is passed. This works well for simple URLs but
becomes problematic for complex URLs, which can get mangled or, worse,
truncated. This doesn't seem to be unique to Windsor's implmentation of CAS.

I tried a few tricks to encode the URLs in strange ways to get the same
URL back from CAS, but I think a better approach is to stuff the URL into
a cookie, and invoke when the request comes back from CAS. Any other approach
seems to result in horrid URLs and there is always the chance that some
character will break the scheme.

One flaw in my approach is that if a TPAC user selects "email" or "place hold"
and invokes the logon screen, the cookie gets set for the "redirect" URL. If,
for some reason, a user decides to do another search and chooses to log in to
their account from a different screen, the CAS URL can be invoked. This
would only happen for CAS, and the cookie itself is only set for 10
minutes, so I don't think this is a major concession. I also try to
invalidate the cookie wherever it is possible to know that the authentication
has not been invoked.

The assumption is that there is a CAS link added to the login form (login/form.tt2),
for example:

 <a href="[% ctx.cas.url %]"
    class="opac-button opac-button-header" id="home_myopac_link_uwin">
    [% l('Log in to Your Account (UWind ID)') %]
 </a>

I had become so used to testing CAS by logging in first, that I totally missed
the links that support authentication at the time of need, e.g. the "email"
or "place hold" links that are displayed prior to authentication. Hopefully,
this branch will address what is probably a common scenario.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader.pm

12 years agoCheck to see if existing loan date is less than recall date bugfix/recall_not_more_than_loan_2_4
Art Rhyno [Sat, 22 Sep 2012 04:46:20 +0000 (00:46 -0400)]
Check to see if existing loan date is less than recall date

It seems possible that a recall can be issued that actually extends
the loan period for an item with semester or other generous loan
periods. This adds a check for the current loan period and uses it
if the calculated threshold date is later.

Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoRemove display of patron birthdate, internet access level, etc feature/patron-privacy_2_4
Dan Scott [Mon, 30 May 2011 17:14:29 +0000 (13:14 -0400)]
Remove display of patron birthdate, internet access level, etc

These fields in the staff client are either not applicable or
potentially privacy-invasive or both. If the data somehow does
get into the system, we don't want it to show up on the staff
client anyway - and we don't want annoying warnings about unset
dates of birth, etc.

This is the hardcore way of doing things, we really should make
it yet another configuration setting. Oh well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd Media Centre MARC template feature/marctemplates_2_4
Dan Scott [Tue, 26 Mar 2013 18:53:32 +0000 (14:53 -0400)]
Add Media Centre MARC template

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoFlag the UTF8 encoding for MARC templates
Dan Scott [Wed, 5 Sep 2012 15:46:28 +0000 (11:46 -0400)]
Flag the UTF8 encoding for MARC templates

The UTF8 encoding is flagged by LDR09 being 'a'. If this is not set, it
greatly confuses Evergreen, which tries to convert what it thinks are
MARC8 characters to UTF8 before saving the record.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd Conifer's custom MARC templates
Dan Scott [Mon, 30 May 2011 03:29:38 +0000 (23:29 -0400)]
Add Conifer's custom MARC templates

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoTreat a Polish l as an ASCII l in full-text search feature/fts-polish-l_2_4
Dan Scott [Mon, 30 May 2011 03:36:44 +0000 (23:36 -0400)]
Treat a Polish l as an ASCII l in full-text search

Is this code path even hit these days? Would have expected
naco_normalize to be poking around here if that was the case...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoRestore the "Local Administration" link to the splash page feature/admin_hours_2_4
Dan Scott [Tue, 1 May 2012 15:43:38 +0000 (11:43 -0400)]
Restore the "Local Administration" link to the splash page

From Local Admin we can get to Library Hours, and thence satisfaction.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoRobin's interface for managing library hours
Dan Scott [Tue, 1 May 2012 14:50:17 +0000 (10:50 -0400)]
Robin's interface for managing library hours

Signed-off-by: Dan Scott <dscott@laurentian.ca>
12 years agoAdd params support to show in opac function
Thomas Berezansky [Sun, 7 Oct 2012 15:58:37 +0000 (11:58 -0400)]
Add params support to show in opac function

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoLP#1175287: make sure tsearch2 is removed, regardless of its origin
Galen Charlton [Wed, 1 May 2013 20:33:39 +0000 (16:33 -0400)]
LP#1175287: make sure tsearch2 is removed, regardless of its origin

A sufficiently old Evergreen database might still have tsearch2
exist as an unpackaged contrib, so convert it to an extension first.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoadjust release notes references to refer to 2.4.0
Galen Charlton [Wed, 1 May 2013 21:35:30 +0000 (17:35 -0400)]
adjust release notes references to refer to 2.4.0

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoupdate upgrade instructions for 2.4.0 release
Galen Charlton [Wed, 1 May 2013 21:34:02 +0000 (17:34 -0400)]
update upgrade instructions for 2.4.0 release

- specify minimum supported PostgreSQL version as 9.1
- specify minimum supported OpenSRF version as 2.2.0
- update schema upgrade instructions and miscellaneous
  references to 2.3

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agorevisions to installation instructions
Galen Charlton [Wed, 1 May 2013 21:02:57 +0000 (17:02 -0400)]
revisions to installation instructions

- Remove references to PostgreSQL 9.0; 9.1 is recommended
  for Evergreen 2.4.
- Clarify that the latest version of OpenSRF now means 2.2
  or later.
- Increase chances that somebody following the instructions
  precisely doesn't run into a problem during the configure step.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoMake sure the "running" indicator goes away
Mike Rylander [Tue, 30 Apr 2013 15:26:00 +0000 (11:26 -0400)]
Make sure the "running" indicator goes away

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoAdd a $cache_timeout-based backstop for infinite loops
Mike Rylander [Fri, 26 Apr 2013 15:28:38 +0000 (11:28 -0400)]
Add a $cache_timeout-based backstop for infinite loops

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years ago"Queue Compression" -- let one do the work for all identical, concurrent searches
Mike Rylander [Fri, 26 Apr 2013 14:49:17 +0000 (10:49 -0400)]
"Queue Compression" -- let one do the work for all identical, concurrent searches

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
12 years agoLP#1174359: follow-up on dropping the reporter.classic_item_list view
Galen Charlton [Wed, 1 May 2013 19:01:30 +0000 (15:01 -0400)]
LP#1174359: follow-up on dropping the reporter.classic_item_list view

Add note for the benefit of any Evergreen admin who may
need to recreate that view.  Also, update the point schema
update script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoLP#1174359 Need to drop reporter.classic_item_list
Michael Peters [Mon, 29 Apr 2013 15:14:39 +0000 (11:14 -0400)]
LP#1174359 Need to drop reporter.classic_item_list

ERROR: cannot drop view metabib.full_rec because other objects depend on it
DETAIL: view reporter.classic_item_list depends on view metabib.full_rec
HINT: Use DROP ... CASCADE to drop the dependent objects too.

Beginning at line 55 of the upgrade script, several views and functions are dropped
so metabib.full_rec can be dropped. One of them is missing.

We need to drop reporter.classic_item_list as well, for the script to work.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
12 years agoImproved AC socket fix
Jason Stephenson [Wed, 1 May 2013 16:08:29 +0000 (12:08 -0400)]
Improved AC socket fix

This provides better coverage for socket shutdown needs, but intends
to fix the same issue as the previous commit.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoShutdown added content sockets to prevent hung connections.
Jason Stephenson [Tue, 30 Apr 2013 17:23:24 +0000 (13:23 -0400)]
Shutdown added content sockets to prevent hung connections.

We were getting several thousand sockets hanging around in a
CLOSE_WAIT state on our server.  The connections were from our
server and to our server.  Further investigation showed it to be
caused by the stage2 added content lookup not closing the request
sockets when it was done reading data.  This branch fixes that.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
12 years agoLP1076411 Return updated circ object from checkin
Bill Erickson [Fri, 29 Mar 2013 13:41:44 +0000 (09:41 -0400)]
LP1076411 Return updated circ object from checkin

Retrieve an updated copy of the circulation object to return to the
caller during checkin.  This ensures the data in the circ object, in
particular date fields, are consistent with the database.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoWhen adding errors from failed processing to acq.edi_message, set error_time
Lebbeous Fogle-Weekley [Wed, 3 Apr 2013 19:31:09 +0000 (15:31 -0400)]
When adding errors from failed processing to acq.edi_message, set error_time

This has obvious benefits in facilitating log analysis after a problem.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoAdd accepting_usr to IDL to fix reporter field
Remington Steed [Thu, 14 Mar 2013 18:37:17 +0000 (14:37 -0400)]
Add accepting_usr to IDL to fix reporter field

In the reporter interface, the view 'Payments: Brick-and-mortar' is
missing the 'Accepting User' field, which is present in the similar view
'Payments: Desk'. This field is already present in the database view and
is simply missing from the IDL.  Since it is needed for certain kinds of
reports, this commit adds the missing IDL fields. It also adds the
missing 'reporter:datatype' to an existing instance of the IDL field.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoLP1170861 Remove unused lineitem alert field
Bill Erickson [Tue, 23 Apr 2013 15:47:37 +0000 (11:47 -0400)]
LP1170861 Remove unused lineitem alert field

Remove extraneous field from the IDL field list for acq lineitem alerts.
The extra field prevented new alerts from getting saved.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoLP1104823 - OPAC search results "Limit to available items" toggles
Kyle Tomita [Tue, 9 Apr 2013 20:51:14 +0000 (13:51 -0700)]
LP1104823 - OPAC search results "Limit to available items" toggles
off "Show more details"

Added a hidden input to the form when "Show more details" is selected
so that when the form is reloaded, "Show more details" will be still
selected.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoLP#1172893: fix query for retrieving available holds
Bill Erickson [Thu, 25 Apr 2013 15:54:40 +0000 (11:54 -0400)]
LP#1172893: fix query for retrieving available holds

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
12 years agoAdd 2.4 release notes for Novelist Select changes.
Jason Stephenson [Tue, 23 Apr 2013 14:39:55 +0000 (10:39 -0400)]
Add 2.4 release notes for Novelist Select changes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>