senator [Mon, 15 Nov 2010 18:28:25 +0000 (18:28 +0000)]
Serials: two little things to make alt serials control interfaces less painful
to use.
The copy template editor now gives dropdowns for fine level and loan duration.
This is particularly useful since at receive time, if you're trying to create
units, you can't do it with null values in those fields.
The caption and pattern pane of the subscription details interface now sets the
active checkbox to checked by default when creating new caption and patterns.
This helps prevent user confusion if you create a caption/pattern and move on
to the issuances tab and find that you can't apply the caption/pattern that
you just created because you didn't make it "active."
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18745
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 15 Nov 2010 17:01:07 +0000 (17:01 +0000)]
make sure dojo.cookie is loaded before use; removed unnecessary import of dojoData
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18740
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 15 Nov 2010 15:15:15 +0000 (15:15 +0000)]
Reverting and extending r18472 to correct implementation thinko
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18734
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 15 Nov 2010 05:23:56 +0000 (05:23 +0000)]
Prevent creation of authority records that are truncated by one letter
The summarizeField() function grabbed the values of the XUL elements,
which were set by the keypress event listeners on the XUL elements.
However, the keypress event listener seems to capture the value of
the XUL element before the value of the new key is appended to the
existing value in a textbox - so, when you typed a new subfield, then
right-clicked to create an authority, the value that was captured was
missing the final character.
Adding the "input" event to the registered listeners captures the
actual value for creating an authority and solves the problem. It
might be possible to remove the keypress event listeners, but for
now we'll take the cautious route.
Address Launchpad bug 669445
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18731
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 15 Nov 2010 04:50:22 +0000 (04:50 +0000)]
Fix negative paging issue in open-ils.supercat.authority.author.startwith
When paging backwards through authority lists, we were skipping the
first page of results. By reducing the offset by the value of one
page, we restore the expected order.
The same problem might affect other paging interfaces: to be determined.
Closes Launchpad bug 669247
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18728
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 15 Nov 2010 01:45:11 +0000 (01:45 +0000)]
Do not cache the authority context menu
Caching would be great, except when you add an authority in the
flow and you expect to see it the next time you right-click
on the authority that you just added.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18727
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sun, 14 Nov 2010 03:23:11 +0000 (03:23 +0000)]
Merge translations from Launchpad
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18726
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 12 Nov 2010 20:52:08 +0000 (20:52 +0000)]
in some scenarios, the 'mous' class may not have loaded yet. pre-load the class in myopac init
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18723
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 12 Nov 2010 20:39:09 +0000 (20:39 +0000)]
Cache the language set (per locale) in a cookie
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18719
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 12 Nov 2010 20:37:37 +0000 (20:37 +0000)]
Trim the set of classes and fields pulled in by Searcher; Cache the cmc data (cmf is too big)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18718
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 12 Nov 2010 19:43:27 +0000 (19:43 +0000)]
ensure that we only fetch this setting once per page
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18715
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 12 Nov 2010 18:36:19 +0000 (18:36 +0000)]
read XSL file and path from opensrf.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18714
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 12 Nov 2010 13:55:58 +0000 (13:55 +0000)]
Server-generated IDL JS
The goal is to reduce use of pre-onload XHR, which is known to cause
problems (dreaded white-screen-of-death) in firefox/xulrunner. Change
allows opac, staff client, and embedded browser interfaces to load
a pre-formatted JS object instead of IDL XML via XHR. In addition to
dropping the XHR, clients no longer parse the XML, which should reduce
page render time. Finally, in the staff interfaces, the full IDL is
once again loaded, so there is no need to specifiy per-page classes.
Per-page classes are still supported and used in the OPAC to reduce the
up-front load time.
Change requires an update to the Evergreen Apache config. See -r18700.
Part of this change included condensing fieldmapper.hash and
fielmapper.dojoData content into fieldmapper.Fieldmapper to avoid
circular dependencies, which was causing problems with IE. Will
eventually want to deprecate .hash and .dojoData, but for now they still
function as before.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18712
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 19:03:58 +0000 (19:03 +0000)]
added permacrud chunk to IDL JS; fixed datatype copy/paste-o
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18711
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 11 Nov 2010 17:41:13 +0000 (17:41 +0000)]
patch from bshum to bring his Search Catalog button in the button bar inline with tsbere's r18431 for new tab vs current tab functionality with the button bar
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18710
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 11 Nov 2010 16:55:52 +0000 (16:55 +0000)]
Avoid munging 035 when a new record is created
If there is no 003 in the record when it is created, then we will not attempt
to generate a 035. If the incoming record contains a 001 and 003, then we will
create a 035.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18707
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 11 Nov 2010 16:50:10 +0000 (16:50 +0000)]
Do not supply a default value for 003 in new authority records
With cat.maintain_control_numbers enabled by default, we can trust
the database trigger to create the appropriate 003 for us - and by
not supplying a 003 in the new record, we won't create a spurious
035 for a brand new record.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18706
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 16:03:09 +0000 (16:03 +0000)]
real fields start at position 0; isnew/changed/deleted are shoved into the end
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18705
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 11 Nov 2010 15:50:36 +0000 (15:50 +0000)]
Use a more generic defaultValue template for datatype defaulting; Apply said to label for class and field
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18704
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 15:39:59 +0000 (15:39 +0000)]
wraps tips appendChild in try/catch to prevent occaisonal exeptions.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18702
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 15:38:37 +0000 (15:38 +0000)]
retab w/ spaces for copy/paste tabs
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18701
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 15:37:04 +0000 (15:37 +0000)]
mod_perl handler for idl2js transform w/ configs
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18700
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 15:31:24 +0000 (15:31 +0000)]
repaired field name iteration thinko. reduce calls to Array.length, mainly for poor ol' IE's sake.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18699
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 11 Nov 2010 14:46:03 +0000 (14:46 +0000)]
Add key, class and reltype to link fields; Provide default datatype of "text"; Add isnew, ischanged and isdeleted inline
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18698
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 11 Nov 2010 13:35:37 +0000 (13:35 +0000)]
XSL for creating a JS representation of the IDL XML. sample usage: xsltproc --stringparam class_list acn,bre fm_IDL2js.xsl fm_IDL.xml.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18697
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 11 Nov 2010 03:49:31 +0000 (03:49 +0000)]
Update the edit dates for authority and MFHD records when they are edited
Addresses the oversight in the original implementation that missed this;
important if we're going to differentiate between creating and editing
a record for triggers.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18695
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 10 Nov 2010 22:26:42 +0000 (22:26 +0000)]
Enable "maintain control numbers" and "record ID as TCN" behavior by default
Per http://ur1.ca/2bgc4, this behavior hews more closely to the MARC21
specification. Note, however, that duplicate bib detection in the
"Import via Z39.50" interface will be somewhat affected; a more
trustworthy workaround is to include the "Local catalog" in Z39.50 searches to
determine if a matching record already exists in the database.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18693
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 10 Nov 2010 21:51:01 +0000 (21:51 +0000)]
Serials: patch from Dan Wells to address Launchpad bug #670734
Previously, a dialog box to select an org unit for the creation of legacy
MFHD records relied on a feature (window.opener) that has been
removed in newer versions of XULRunner.
This patch has that dialog box use a different, safer approach to accomplish
its task.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18691
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 10 Nov 2010 21:29:51 +0000 (21:29 +0000)]
Booking: fix bug reported by Robert Soulliere wherein the items associated
with picked-up reservations didn't actually get their status set to 'checked
out' like they should have.
Robert reported this bug on Launchpad (#672748) and provided a patch, but
there were some neighboring bugs in the circulation logic anyway, so they've
all been fixed together.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18688
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 10 Nov 2010 20:51:23 +0000 (20:51 +0000)]
replace Cookie.js/cookieManager with dojo.cookie. Some things to watch out for as we review this changeset:
In Cookie.js, a -1 passed as the expires parameter indicated a session cookie. We could also specify such things as "+1y" or a specific date. With dojo.cookie, an expires value of -1 deletes a cookie. Not specifying an expires option will create a session cookie. We can enter a date or a number days from today. For the case in the code where we had "+1y", I supplied a value of 365.
In the previous code, we used empty strings for a lot of cookie deletion. The canonical dojo example has us using null (with an expires of -1). There were also some cases where it seemed obvious that we were deleting cookies, but were at the same passing an actual value (see base.js). I changed these to nulls.
In opac_utils.js, grabFleshedUser(), I fixed a dead code path where a cookie deletion attempt came after a return statement.
I ran through the opac within and outside of the staff client, tried all of the acquisition UI's from the Acq menu, and most of the interfaces under Admin, and didn't find any auth cookie errors.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18687
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 10 Nov 2010 19:53:37 +0000 (19:53 +0000)]
Improved permission checking speed for PCRUD mode.
When there are more than some number of rows (5, by default) we use usr_has_perm_at_all to get the list of locations and cache them. This cache is flushed per-session.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18686
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 10 Nov 2010 17:54:34 +0000 (17:54 +0000)]
Merge serials-integration branch, incorporating new work from Dan Wells.
Specifically, this contains changesets 18670, 18669, 18379, and 18373.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18685
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 10 Nov 2010 16:26:23 +0000 (16:26 +0000)]
ddoouubblleedd line ... thought I squashed that
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18684
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 10 Nov 2010 14:52:13 +0000 (14:52 +0000)]
Move the magic-bib update to the top of the file, avoiding triggers that care about XML namespaces
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18683
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 10 Nov 2010 13:18:29 +0000 (13:18 +0000)]
do not use TRUNCATE when refreshing reporter.materialized_simple_record
Previous behavior would break Slony replication after doing a
bib load. Since a deletion is slower than a truncate, if you're
not using Slony replication, you may prefer to truncate rmsr
prior to calling reporter.enable_materialized_simple_record_trigger.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18677
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 9 Nov 2010 20:34:36 +0000 (20:34 +0000)]
remove the last of DP_DateExtensions. We should probably move the format options for dojo.date.locale.format to some constants for easier skinning
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18675
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 8 Nov 2010 22:05:50 +0000 (22:05 +0000)]
dynamically loaded classes also need access to toHash
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18673
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 21:43:55 +0000 (21:43 +0000)]
removing original typo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18672
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 21:37:42 +0000 (21:37 +0000)]
Allow forced loading of the whole IDL with: fieldmapper.IDL.load(["*"]);
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18668
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 8 Nov 2010 21:26:26 +0000 (21:26 +0000)]
repaired typo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18667
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 8 Nov 2010 21:21:31 +0000 (21:21 +0000)]
Add the OpenURL resolver caching service as an optional component
Currently limited to supporting the Ex Libris SFX OpenURL resolver,
this caches the results of looking up full-text availability of
resources by ISBN or ISSN.
For an example of incorporating this service into your OPAC, see
http://svn.open-ils.org/trac/ILS-Contrib/browser/conifer/branches/rel_1_6_1/web/opac/skin/lul/xml/result/result_table.xml#L102
for returning the full-text availability of a given resource by ISSN.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18666
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 21:18:40 +0000 (21:18 +0000)]
teach vivicateClass to set up dojoData APIs for classes loaded by fieldmapper.IDL.load() when appropriate
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18665
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 21:17:45 +0000 (21:17 +0000)]
make sure classes are /always/ loaded from the server
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18664
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Mon, 8 Nov 2010 20:44:06 +0000 (20:44 +0000)]
Acq: in acq search, avoid trying to create a dropdown from every bib ID in
the system, providing a normal text input field instead (or search by file
of terms).
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18662
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 19:03:38 +0000 (19:03 +0000)]
More fixing related to r18657
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18660
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 8 Nov 2010 18:46:21 +0000 (18:46 +0000)]
syntax
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18657
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 16:34:11 +0000 (16:34 +0000)]
keep trunk version of the 2.0 upgrade script in sync ... for now
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18656
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 8 Nov 2010 16:22:59 +0000 (16:22 +0000)]
Teach vandelay.replace_field to be a little smarter by allowing simple cases of both replacing and regexp-testing the same subfield
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18652
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 8 Nov 2010 16:21:15 +0000 (16:21 +0000)]
holds retrieval API call sorting and cleanup; sort non-cancelled holds by ready-for pickup, then active, then suspended; use json_query to fetch IDs first, so id_list calls can avoid fetching the full hold objects in the ML. sort fleshed transit by send time to pick up the latest transit
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18650
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 8 Nov 2010 02:57:04 +0000 (02:57 +0000)]
Further Fedora prereq installer tweaks
* Install the Perl DBD::Pg module
* Force the CPAN modules, as Business::OnlinePayment::AuthorizeNet
still suffers from an install-crippling bug
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18648
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 8 Nov 2010 01:29:26 +0000 (01:29 +0000)]
Add UUID::Tiny to Fedora prerequisites
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18646
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 8 Nov 2010 00:34:00 +0000 (00:34 +0000)]
Improve Fedora prerequisite installer
* Explicitly install wget, which isn't installed in a minimal install
* Hack JavaScript-SpiderMonkey Makefile.PL for 32-bit Fedora
* Provide a fedora14 target
* Change "fedora-13" to "fedora13" to match OpenSRF prereq installer
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18644
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Fri, 5 Nov 2010 21:39:07 +0000 (21:39 +0000)]
Revert r18608, which was ill-conceived anyway (you can use any table as a
source in reporter, I just didn't see how at first)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18643
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 18:58:35 +0000 (18:58 +0000)]
#671213: remove extraneous insert from upgrade script
Somebody upgrading from 1.6.1 should already have this.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18639
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 17:56:01 +0000 (17:56 +0000)]
switch to authoritative methods for various acq retrievals
Avoid race condition when using Slony replication
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18637
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 17:53:46 +0000 (17:53 +0000)]
missed database update from password reset fix
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18635
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 17:52:28 +0000 (17:52 +0000)]
undo premature commit
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18634
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 17:50:28 +0000 (17:50 +0000)]
missed database update script
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18633
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 5 Nov 2010 17:50:05 +0000 (17:50 +0000)]
Keep the hierarchy in line for O:A:S:Publisher::action.pm
Oddly enough, this didn't seem to affect hold-targeting functionality, but
testing was focused on placing a hold via the OPAC, and there's potential
for other things to go amiss.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18632
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 5 Nov 2010 17:35:38 +0000 (17:35 +0000)]
Initial support for recall of items triggered by placing a hold
In academic libraries, it is common for groups like faculty and graduate
students to have extended loan periods (for example, 120 days), while
others have more common loan periods such as 3 weeks. In these environments,
it is desirable to have a hold placed on an item that has been loaned out
for an extended period to trigger a "recall": truncating the loan period,
setting available renewals to 0, optionally changing the fines associated
with overdues for the new due date, and notifying the current patron of
the recall.
New actor.org_unit_setting entries and hold targeting logic enable libraries to
control whether a hold will trigger a recall of a circulating item as follows:
* "Recalls: Circulation duration that triggers a recall" (recall threshold)
is specified as an interval (for example, "21 days"); any items with a
loan duration of less that this interval will not be considered for a
recall
* "Recalls: Truncated loan period" (return interval) is specified as an
interval (for example, "7 days"), such that the user who currently
has the item checked out will get the greater of either the recall
threshold, or the return interval.
* "Recalls: An array of fine amount, fine interval, and maximum fine"
is an optional setting that applied the new fine rules to the current
circulation period.
When a hold is placed and no available copies are found by the hold targeter,
the recall logic checks to see if the recall threshold and return interval
settings are set; if so, then the hold targeter checks the currently
checked-out copies to determine if any of the currently circulating items at
the designated pickup library have a loan duration longer than the recall
threshold. If so, then the eligible item with the nearest due date will be
recalled.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18630
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 17:06:08 +0000 (17:06 +0000)]
remove aupr.request_time fix from 1.6.1-2.0 upgrade
Fix also in 1.6.1.3
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18626
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Fri, 5 Nov 2010 17:02:35 +0000 (17:02 +0000)]
Address https://bugs.launchpad.net/evergreen/2.0/+bug/670734
Code called by the xul menuitem's oncommand referred to a constant that
didn't exist, but the intention was clear enough, so this should fix it.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18622
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 5 Nov 2010 16:45:45 +0000 (16:45 +0000)]
fix user password reset request time column def
Needs to be a timestamp with time zone; fixes a bug
where it was interpreted as a UTC time, throwing off
the calculation of the expiration of the password reset
request.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18620
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 5 Nov 2010 16:05:58 +0000 (16:05 +0000)]
remove some extra rollbacks, and catch the failure of others where they may or may not be needed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18615
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 5 Nov 2010 13:22:15 +0000 (13:22 +0000)]
Patch from Benjamin Shum for the staff client button bar. Thanks!
---
In our consortium, we have the Button Bar for our Evergreen staff
clients enabled all the time. As a result, we have had lots of feedback
from users that there is a need to include a "Search Catalog" option on
the Button Bar.
This is our first attempt at writing something against trunk and
submitting it as a minor patch. Melissa Lefebvre created the icon for
the button by adapting existing icon sets. I set out to create the
requisite .diff file against a recent copy of trunk. I was unsure of
how to apply our changes to other locales' lang.dtd files, the one I
found most immediately was for en-US (our default).
If the community approves, we would like to see this become part of
future releases of Evergreen 1.6 and 2.0.
Thank you for your consideration.
-- Ben
--
Benjamin Shum
Open Source Software Coordinator
Bibliomation, Inc.
32 Crest Road
Middlebury, CT 06762
203-577-4070, ext. 113
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18609
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Thu, 4 Nov 2010 22:15:10 +0000 (22:15 +0000)]
Quick IDL change to enable limited use of reporter against booking. Could
get more attention later.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18608
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Thu, 4 Nov 2010 21:19:12 +0000 (21:19 +0000)]
Net::uFTP isn't giving us needed functionality
Since the OpenILS::Utils::RemoteAccount already uses Net::SSH2 directly
(Net::uFTP was supposed to be an abstraction over SSH /and/ FTP), just use
Net::FTP (installed by default with perl on most systems) for FTP
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18606
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 4 Nov 2010 21:15:52 +0000 (21:15 +0000)]
cut down on reloading of IDL classes
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18603
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 4 Nov 2010 15:04:42 +0000 (15:04 +0000)]
more opac login form tweaks. This should work in Firefox for button submission or enter press submission
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18602
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 4 Nov 2010 01:03:42 +0000 (01:03 +0000)]
add TT helper to squeeze strings into the UNOB straitjacket
The force_jedi_unob helper strips non-ASCII characters from
template output but does so nicely by converting the string
to NFD first. This is meant to be used by EDI templates, although
could be useful for A/T output that goes to receipt
printers that cannot print diacritics.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18598
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 3 Nov 2010 20:30:36 +0000 (20:30 +0000)]
blimey
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18596
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 3 Nov 2010 20:29:45 +0000 (20:29 +0000)]
add the Batch Bib Update module to startup.pl
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18593
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 3 Nov 2010 19:56:43 +0000 (19:56 +0000)]
flip sense of spending limit check
Testing showed users expecting that the limit would
be based on amount spent, not the amount available
to send.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18591
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Wed, 3 Nov 2010 14:46:24 +0000 (14:46 +0000)]
Acq: Don't forget invoice items (extra charges, not purchases) when totaling
debits for voucher
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18589
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 2 Nov 2010 16:43:33 +0000 (16:43 +0000)]
Surely this was meant to go here :-)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18585
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 2 Nov 2010 16:27:23 +0000 (16:27 +0000)]
Show money spent from each fund in an invoice voucher/print-out
In the (near) future, we really ought to use a library like Money::Currency
and refactor any Acq code that uses floating-point math. It's conceivable
that numeric type fields in the acq schema need reviewed (should some of them be
something like numeric(8,2) ?)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18583
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 2 Nov 2010 16:23:13 +0000 (16:23 +0000)]
Patch from Steve Callender to address a booking-related collection agency reporting problem
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18580
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 2 Nov 2010 15:50:13 +0000 (15:50 +0000)]
add definition for UPC line item attribute
Useful for providers of audiovisual material that
don't have ISBNs.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18578
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 2 Nov 2010 13:05:07 +0000 (13:05 +0000)]
enable authoritative versions of various acq retrieval functions
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18576
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 2 Nov 2010 13:02:10 +0000 (13:02 +0000)]
don't break up title and author when ingesting acquisitions MARC
Note that this can be done more cleanly once oils_xpath groks
XPATH 2.0 functions, in particular string-join.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18574
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 2 Nov 2010 03:00:57 +0000 (03:00 +0000)]
AutoFieldWidget linked class autoloaders, etc.
* leave linked selector disabled until entries are fetched;
* added support for applying default linked class object loaders;
* added default loader for acq providers, since large sets of
providers can take an excessive amount of time w/ direct pcrud call.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18572
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 2 Nov 2010 03:00:56 +0000 (03:00 +0000)]
ML provider retrieval enhancements
* avoid grabbing inactive providers
* order providers by code
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18571
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 2 Nov 2010 02:55:21 +0000 (02:55 +0000)]
in SIP patron retrieval, only fetch non-archived penalties and penalties
that that matter (fines, overdues, blocking penalties). pair down the
penalty comparisons to avoid fleshing the penalty type, potentially
numerous times for a given type, by using the constant identifiers.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18569
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 2 Nov 2010 02:46:51 +0000 (02:46 +0000)]
Enable merge of authority records to do the right thing
The target and source authority record was flipped, causing
the update to fail. In reconsidering this function, it is not
necessary to change the contents of the source authority record
just to propagate the content of the target authority record
to any linked bibliographic records.
Instead, take the approach of updating the ID of the controlled
field in the bib record, then temporarily set "reingest on same
MARC" to TRUE and update the target authority record by setting
deleted = FALSE (which propagates the "changes" to the linked
bib records), then set "reingest on same MARC" flag back to its
original value.
This has the bonus of actually working.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18567
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 1 Nov 2010 23:22:53 +0000 (23:22 +0000)]
yet another replication race condition fix
Fixes problems that can occur when creating a lineitem
from an existing bib in the catalog; adds an authoritative
version of open-ils.acq.lineitem.retrieve.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18565
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 1 Nov 2010 21:22:06 +0000 (21:22 +0000)]
more compatability tweaks for login form. Each browser has its own heuristics for saving credentials
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18564
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 20:52:45 +0000 (20:52 +0000)]
Make vandelay.add_field smarter about applying add rules when no target field exists before hand
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18561
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 1 Nov 2010 20:41:14 +0000 (20:41 +0000)]
Replace hard-coded '(CONS)' for MARC control number identifier in authority records
We created an actor.org_unit_setting, 'cat.marc_control_number_identifier', for
specifying the preferred MARC control number identifier, but when we create a
new authority record from the MARC editor, the hardcoded value of 'CONS' is being
used.
This teaches the staff client how to pull the appropriate value from the AOUS
when invoking the MARC Editor.
Resolves https://bugs.launchpad.net/evergreen/+bug/669245
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18559
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 1 Nov 2010 19:44:16 +0000 (19:44 +0000)]
Ensure that changes to authority records propagate to linked bibliographic records
Per https://bugs.launchpad.net/evergreen/+bug/669596, updated authority records
weren't being reflected in bibliographic records with fields that link to those
authority records. We were missing the call to authority.propaagate_changes()
withing the ingest trigger on authority.record_entry.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18557
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 18:37:36 +0000 (18:37 +0000)]
we should not restrict to the top org only, get all counts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18555
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 18:16:56 +0000 (18:16 +0000)]
there is no atomic version, of course ... it is all atomic all the time
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18553
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 17:32:15 +0000 (17:32 +0000)]
keep 1.6.1-2.0 upgrade script in sync
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18552
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 17:30:30 +0000 (17:30 +0000)]
version number missed in previous update
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18550
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 17:18:56 +0000 (17:18 +0000)]
Improve hold permit testing
* Discard matchpoints where the OU in a particular slot is not ancestor-or-self of the target object's value
* Discard matchpoints where strict_ou_match is true and the OU is not strictly matched
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18549
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 1 Nov 2010 17:13:42 +0000 (17:13 +0000)]
this wraps the input elements used for opac login in an actual form element, with the goal of allowing browsers to save credentials for the site. So far this appears to work for Firefox 3.6.12, but not for Chrome 7.0.517.41, Opera 10.63, nor Safari 5.0.2. IE 8.0.6001.18702 will prompt for saving credentials, but won't actually populate the form on a revisit. Some of this may be due to me using an invalid/expired SSL-cert on my dev box, but I suspect it's really because another page is not being loaded after form submission. Any ideas/suggestions?
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18548
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 1 Nov 2010 16:14:11 +0000 (16:14 +0000)]
syntax
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18545
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 1 Nov 2010 15:39:39 +0000 (15:39 +0000)]
let libraries allow funds to be overcommitted
The check constraints on the balance warning and
stop limits were too strict - a library can validly
choose to permit a fund to have a commitment greater
than 100% of its allocation
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18543
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 1 Nov 2010 14:50:53 +0000 (14:50 +0000)]
add copy counts to the holdings xml format -- one more step toward freeing ourselves from MVRs
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18542
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 29 Oct 2010 01:25:01 +0000 (01:25 +0000)]
adjust quoting of phrase searches
This has three main effects:
* This formalizes the current behavior where a
phrase search like
title:"^Harry Potter"
acts as a left-anchored search and
title:"Harry Potter$"
acts as a right-anchored search.
In particular, this can be useful for constructing
searches of bibliographic call numbers.
* Other regex metacharacters in phrase searches are
now escaped.
* Phrase searches like "C++" will no longer crash; in fact,
this makes a phrase search currently the only way to
accurately retrieve all C++ titles with the usual
normalization rules
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18540
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Fri, 29 Oct 2010 00:06:02 +0000 (00:06 +0000)]
loosen cross-check of line item ID when processing incoming EDI messages
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18538
dcc99617-32d9-48b4-a31d-
7c20da2025e4