webstaff: Resolve after saving

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Fixed field editor!

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: New directive for FF editing

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Fetch FF pos map and value map, per record type

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Make Date of Birth label red if DOB is emtpy

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Add Profile to the column list on patron search results

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Remove unnecessary dropdown-toggle attr

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Close other context menus before showing this one

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: indicator value lists now use "description" to, well, label descriptions

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: use contextItemGenerator instead of contextItemContainer

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Typo (missing space)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Tooltips for holdable/visible on status and location in item summary

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: MARC editor - AngularJS egTagTable service

This also adds context menus for tags, subfield codes, and indicator
values

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Do not change the tab on iframe changes when using the summary bar buttons

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Use ng-show instead of ng-if to avoid an extra scope injection

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Toward dirty data flag and better prev/next/start/end buttons

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Add buttons to call appropriate opac functions from the record summary bar

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Allow UIs wrapping the opac to call functions in the opac iframe

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Allow the iframe code to pass a handle to the iframe out to the parent scope

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Respect items-out tally settings

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: give the Holds Shelf a template and print button

Also expose both that and the Pull List in the workstation print
interface

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: MARC editor - add support for a context menu item generator function

... on the scope (ContextItemGenerator), and pull ContextItemContainer
from the parent scope

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Move the MARC namespace to MARC21

This will allow someone can make a more generic superclass one day,
e.g., if UNIMARC support were to be added.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Use menu grouping on holds-for-this-record grid

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Teach autogrid about grouping Actions menu options

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: add actions to various grids

* show holds
* show patrons
* show recent circs
* show triggered events

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Allow Record Summary to collapse (and remember the choice)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Add authority control sets support to the MARC namespace.

Some TTS support will be required for Angular use.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Allow hotkeys to work in form elements

We may need to use the underlying Mousetrap library directly, however

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Add F1 hotkey (checkout)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: use preventDefault() on navbar hotkeys

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: wire the date filter into the payments grid in billing xact history

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Apply date filter range on command in billing xact history

Adds an Apply button for apply changes to the date filter to the grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Grid supports automatic refresh with query change

Adds a new gridControls function watchQuery(), which returns the
contents of the grid query.  When the contents change, the grid
automatically redraws.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: Set refresh function so Actions trigger refresh

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

webstaff: internalize jquery

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1442815: release notes for SKOS URIs for coded values

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1442815: add RDA Content Type, Media Type, and Carrier Type attributes to seed data

Note that a record attribute reingest is required for the
attributes to be available for search purposes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1442815: teach record attributes about SKOS

Add columns to the database for storing URIs of SKOS
vocabularies and concepts.  In particular:

- add a vocabulary column to config.record_attr_definition
  to store the URI of the published vocabulary associated
  with the record attribute
- add a concept_uri column to config.coded_value_map

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1442796: make XPath-based record attribute definitions work

Record attribue definitions that use XPath to extract their values
could break ingest; this patch fixes that.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1427287: release notes for the MARC tag-table service

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1427287: update fm_IDL.xml add ADMIN_TAG_TABLE permission

A question: should cataloging administrators get
system-level ADMIN_TAG_TABLE by default?

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1427287: tag table seed data for MARC 21

This was converted from marcedit-tooltips.xml
using the marc_tooltips_to_sql script introduced in the
previous commit.  As a consequence, the tag table
data is somewhat out of date; this will be addressed
later.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1427287: script to migrate MARC tooltips data file

marc_tooltips_to_sql is a script that converts an
Evergreen MARC tooltips file to a set of SQL statements
for seeding config.marc_field, config.marc_subfield,
config.record_attr_definition, and config.coded_value_map
with tag table data.

Example usage:

marc_tooltips_to_sql --input Open-ILS/xul/staff_client/server/locale/en-US/marcedit-tooltips.xml \
                     --output /tmp/bibs.sql --type biblio

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1427287: MARC tag-table service

This patch teaches the Evergreen database how to store
information about MARC fields, subfields, and values that
can be associated with subfields.  The initial application
of the tag-table service is supplying the webstaff MARC editor
with data for context menus for selecting valid tag, indicator
value, subfield code, and subfield values.

A record attribute's coded value map can be associated with a
MARC subfield and returned by the tag-table service.  This is for
supporting the use of controlled vocabularies for subfield values in
the MARC editor.

Database schema
---------------
Tables:

* config.marc_format:   list of MARC formats; at present, however,
                        only MARC21 is supported
* config.marc_field:    list of fields recognized by the Evergreen
                        database.
* config.marc_subfield: list of subfields recognized by Evergreen

Views:

* config.marc_field_for_ou
* config.marc_subfield_for_ou

These two views assist in the process of determining the set of
MARC fields and subfields are meant to be in force at a particular
OU.  These are generally not meant to be queried directly, in
favor of the config.ou_marc_{sub}fields() functions.

Functions:

* config.ou_marc_fields(marc_format, marc_record_type, ou)
* config.ou_marc_subfields(marc_format, marc_record_type, ou)

These functions return the authoritative set of fields or
subfields in force at a given OU.

OpenSRF methods
---------------
This patch adds methods to open-ils.cat for
retrieving either the entire tag table or just the list
of MARC fields, either from the stock MARC format
seed definition or as potentially customized for the user's
workstation OU:

open-ils.cat.tag_table.all.retrieve.stock
open-ils.cat.tag_table.all.retrieve.local
open-ils.cat.tag_table.field_list.retrieve.stock
open-ils.cat.tag_table.field_list.retrieve.local

To use these methods, the user must have UPDATE_MARC permission.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP 1479110: Stamping Upgrade Script for Negative Balance Settings

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

lp1479110 Provide more clarity for negative balance settings

Update the descriptions for the negative balance settings so that users know how to use prohibit and interval settings in conjunction with each other.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1312309 JSPAC removal release notes

Add release notes for removal of the deprecated JSPAC interface.

Signed-off-by: Jeff Godin <jgodin@tadl.org>

LP#1312297 Legacy selfcheck removal release notes

Release notes for the removal of the legacy selfcheck interface.

Signed-off-by: Jeff Godin <jgodin@tadl.org>

LP#1312309: Initial changes to web Makefile to avoid copying JSPAC files

In Open-ILS/web/Makefile.am, we were copying in some files for JSPAC.
Because we're in the process of removing these files, this broke the
installation process for make install step of the README.

Remove the loop for now, probably more cleanup required here.

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: Remove unused images added by craftsman

Remove all unused images that were added by the craftsman JSPAC
skin.

The following images were added by craftsman but are now in use
elsewhere, and are not removed by this commit:

Open-ILS/web/opac/images/advancedsearch-icon.png
Open-ILS/web/opac/images/book-icon.png
Open-ILS/web/opac/images/progressbar_green-old.gif
Open-ILS/web/opac/images/small-rss.gif

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: remove unused images

Removing unused images. The orgtree images exist elsewhere, and the
tor images exist elsewhere also (and have been updated).

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: JSPAC remove javascript, combined.js, etc.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: JSPAC remove more css

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: JSPAC first pass at removing xml and js files

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: JSPAC: remove index.xml from apache example configs and examples in documentation

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: remove dtree.js -- unused for a while now

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312309: Remove old bbags.xml interface, apache config

Remove the XML and Javascript for the old JSPAC book bags / bbags / list
display.

Also, remove <Location> block in Apache example configs for /opac/extras, as
the only things requiring it were the (now removed) legacy self checkout
interface, and this bbags interface.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1312297 remove selfcheck.xml legacy selfcheck

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1440114 Stamping upgrade for Blanket PO

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1440114 PO stays open with active blanket charges

When marking the final lineitem on a PO as received, a PO will remain
open (on-order) if blanket charges which are still encumbered link to
the PO.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 invoice item type prorate/blanket warning

Warn the user that only one of 'prorate' or 'blanket' may be selected
when creating/editing an invoice item type.  When this happens, the save
operation is aborted and the user is returned to the edit dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Blanket order pgtap tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Blanket order release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Blanket PO finalize from PO view

Adds new "Finalize Blanket Order" button to purchase page for PO's that
are activated and have at least on blanket charge.  Finalizing the PO
disencumbers all blanket charges and marks the PO as complete.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Blanket order PO "finalize"

When invoicing a PO that has at least one blanket charge, a new option is
present which allows staff to indicate that an invoice is the final invoice
for the PO.  Finalizing a PO results in the following:

1. Encumbrances for all blanket charges on the PO are dropped to $0.
   This is done by setting the amount paid in the original fund_debit
   (linked the blanket po_item) to $0.

2. If no pending lineitems exist on the PO, the PO is marked as received.
   If there are pending lineitems, the state is left untouched.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Direct charge blanket orders

Support "blanket" (long-lived, multi-invoice) orders via a new "blanket"
boolean on invoice item types.  Blanket charges can be invoiced multiple
times by creating a new fund_debit for each invoice item linked to a
blanket po_item.

This change also adds the amounts paid over time for blanket charges to
the Amount Paid summary information for purchase orders containing the
charges.

Adds a new Invoice Item Type of "Blanket Order".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1440114 Remove inv_item via po_item from invoice

Allow invoice_items which were descended from po_item's (direct charges)
to be removed from invoices.  Prior to this, a JS exception prevented
removal of these items.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1379815: Stamping upgrade scripts for vandelay stat cat import

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Better error handling

This commit adds more thorough error checking and handling for the stat
cat import feature, including adding two custom import error codes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Add release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Add pgTAP test

This commit adds a pgTAP test which ensures that imported items are
being successfully added to the 'import_item' table. The test confirms
that the correct number of items have stat cat data in the table. The
test also ensures that the new xpath function works properly, simply by
using it.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Add code to assign stat cats on Vandelay imported items

This commit adds columns to the Holdings Import Profile table
(vandelay.import_item_attr_definition) and to vandelay.import_item, adds
the corresponding fields to the IDL, modifies the database functions
which import the data (ingest_bib_items() and ingest_items()) and adds
code that parses the imported stat cat data (of the form
CAT 1|VALUE 1||CAT 2|VALUE 2) and applies it to the appropriate
overlayed copy.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Add missing behavior to update_copy_stat_entries

The current function doesn't provide the level of control we need, even
with the 'delete_stats' flag set to zero. This commit adds a new
'add_or_update_only' option which preserves existing stat cat entry maps
for any stat cat not represented on the incoming copy object, and
updates values when appropriate.

This commit also updates the function comment for better clarity.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1379815 Fetch tag data as a table using tag/xpath combo

New function: oils_xpath_tag_to_table()

This function is adapted from oils_xpath_table() with the goal of being
more targeted and simpler to use.

The main issue with oils_xpath_table() is that it relies on peer
UNNEST() functions, and that leads to unexpected behavior whenever the
xpath arguments result in uneven or "gapped" selections.  In the first
type of case, the resulting table includes rows representing the least
common multiple of the underlying xpath selections.  In the second
type, though the xpaths may sometimes return the same number of values,
those values are not correlated except by order in the marc, which does
not account for the real possibility of null values in the set.

Crude Example:

999 $d ABC $e 123
999 $d DEF
999 $d GHI
999 $e 456

We need a table representing subfields 'd' and 'e' of the '999' fields,
so we might try an xpath like:

//*[@tag="999"]/*[@code="d"]|//*[@tag="999"]/*[@code="e"]

We want:

 d  |  e
---------
ABC | 123
DEF |
GHI |
    | 456

but we get:

 d  |  e
---------
ABC | 123
DEF | 456
GHI | 123
ABC | 456
DEF | 123
GHI | 456

This example illustrates both negative behaviors (non-correlated fields
and least-common-multiple row multiplication).

The new method, while internally quite similar, has a different
signature, with the most significant change being a 'tag' argument
which serves as a common base element for the xpaths (now an array
rather than a pipe-delimited string).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1406370 Set Search Preferences Ordered by Name

Set search preferences is currently ordered by shortname in
Admin > Workstation Administration > Set Search Preferences.
This patch adds functionality that orders each org unit and
its children in alphabetical order by name, rather than by
shortname.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1476370 Selfcheck warning template cleanup

Remove a duplicated chunk of template code which was inadverently added
while working on LP1476370 -- logout warning dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1444514: Have amnesty mode override backdate for voiding

Otherwise you get amnesty notes on just backdate voiding.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1437292: Order Bucket Names Alphabetically

Prefer alpha ordering to database ordering for bucket names.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Documentation typo fixes
 - Corrected effect to affect
 - Removed double the
 - Spelling correction Preceeded to Preceded
 - Corrected Spelling error self serve to self-serve
 - Small typo in staff client receipt template - hold slip 2 docs.

Matt's first commit to evergreen docs!

Signed-off-by: Matt Berowski <berowskim@larl.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>

LP#1463590 Loosen read access to distribution formulas

Make it possible for ACQ staff that have the CREATE_PURCHASE_ORDER
permission to view distribution formulas (via PCRUD) , making it
possible to use them from the PO batch update operation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1438252 SIP honor floating copy checkin location

Report the new value for a copy's circ_lib when it's a floating copy
whose circ_lib is modified during checkin.

This affects the AQ field of the SIP checkin (10) message.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP1431541: SRU UTF8 encoding issues

The SuperCat SRU service was encoding MARCXML using an encode_utf8()
call that ended up corrupting non-ASCII characters. In addition, the
HTTP header charset was not being set, meaning that the return header
would default to ISO-8859-1.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1419172: Stamping upgrade script for optimizing full circ count

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1419172 Optimize full_circ_count view to avoid seq scans

As reported by Chris Sharp:

"The reporter.classic_item_list view was modified in bug 1208572 to use
extend_reporter.full_circ_count to provide the use count for each item.
Unfortunately, this change was found to be the cause of consistently
long-running (2+ hours) reports queries in PINES as its query plan on
our PostgreSQL 9.3 server was resulting in sequential scans of both the
circulation and aged_circulation tables."

This commit restructures the view to avoid JOINs, and is in production
at PINES with noted improvement.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1481036 Ignore future backdates live test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1481036 Ignore future backdates (part 2).

Ensure that future backdates are successully ignored in the checkin API.
The logic was in place to do this, but it failed to clear the values,
resulting in using the future backdate anyway.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1204671: Stamping upgrade script for fund tag propagation

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1204671  Allow fund tags to remain attached to new fund during end-of-year propagation
or rollower.

Signed-off-by: Dan Pearl dpearl@cwmars.org
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1450561: Stamping upgrade script for library settings editor history limits

Signed-off-by: Ben Shum <bshum@biblio.org>

LP 1450561: Restore org. unit settings history limit function and trigger

The evergreen.limit_oustl function and the limit_log_oustl trigger on
config.org_unit_setting_type_log were missed in the upgrade scripts
when these were added to the base schema.  This commit adds them and a
pgtap test to check that they exist after.

This commit also alters the body of the limit_oustl function to take into
account of the org unit when deleting entries from the log table.  This
change allows multiple consortium members to have their own five history
entries.  The original code only kept the last five entries of any given
setting across the whole installation.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1112723: stamping upgrade script for unapi copy visibility

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1112723 Consider copy-level opac_visible flag when ranking

The current unAPI calls consider opac_visibility of the status,
but not the copy itself. If you have a record with copies set to
opac_visible = false, you might see few or no copies in the OPAC
results list, as these invisible copies may be the first five
returned, and they then crowd out the visible copies.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1478997 Items out display sort overdues to top (webstaff)

Sort overdue items to the top of the patron items out display in the
webstaff client, consistent with pre-2.5 behavior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1478997 Items out display sort overdues to top

Sort overdue items to the top of the patron items out display in the XUL
client, consistent with pre-2.5 behavior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

lp1481844 Change Available Copies Display

The Show link in the available copies area of the record summary will now
display for any org unit that owns a copy of the title, even if those copies
are unavailable. This commit also changes the language in the display to read
"x of y copies available at z library."

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

lp1486252 Change label for acq admin menu

Now that the acq admin menus have move outside of the Server Admin menu, it
should be called "Acquisitions Administration" to be consistent with other
options in this area.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1482400: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1482400: UT for OpenILS::Application::Acq::BatchManager changes

This patch adds tests for the changes to how ::BatchManager()
calculates the request response freqency throttle.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1482400: when activating a PO, provide better progress updates

This patch improves how progress is reported during the activation
of a purchase order that has a large number of assets (bibs and
copies) to create.  Specifically, it:

[1] Shows a progress bar during the asset creation phase.
[2] Calculates a linear throttle for updating the record counts
    widget. The value is based on the maximum number of bibs and
    items that could be created during the activation, divided by 20
    (which is an empirically derived number of streaming responses
    that can be sent back before the XUL client starts having
    difficulty).
[3] During the asset-creation phase, the number of records created is
    displayed above the progress bar.
[4] Adds a title to the progress bar that's displayed during the
    second phase of order activation.

To test, after applying the patch:

[1] Create a purchase order that has a large number of
    brief bibs and copies to create during activation.  For
    example, 30 line items and 60 copies.
[2] Activate the purchase order.  You should see the following
    after entering the record import queue and submitting:

    (a) Progress dialog whose title is "Creating bib, call number,
        and copy records.."
    (b) The progress dialog displays and updates text above the
        progress bar indicating how many records it has processed,
        e.g., "Bib Records Merged/Import: 25"
    (b) The record update counts should be updated at a regular
        frequency.
    (c) When the asset creation phase is done, the progress bar's
        title should change to "Activating purchase order..."

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>