LP#1904244: Angular currency and exchange rates interface

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: Angular distribution formulas interface

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: Angular EDI attr sets interface

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1406424: display total of rolled over encumbrances during FPC

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: Angular funds interface

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: schema: add two indexes

These two indexes support retrieving transactions that account
for a given fund debit.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: schema: make fund.code NOT NULL

Any funds whose code was null will have it set to "FUND-WITH-ID-$id"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: change automatically-generated fund allocation notes for transfers

The automatically-generated note for fund allocations created during a fund
transfer is now:

Now Transfer {to,from} FUND_CODE (YEAR) (FUND_ORG_UNIT_SHORTNAME)

Previously, the note had the fund ID rather than the more
descriptive combination of code, year, and owner.

No attempt is made to retroactively adjust previous transfer allocation
nodes.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: format: switch from CurrencyPipe to DecimalPipe

CurrencyPipe has no easy way of displaying the monetary amount
without a currency symbol, which means that currency amounts
display with a dollar sign -- which isn't a univeral assumption
for Evergreen.

Future work is indicated to (a) teach Evergreen a global flag
or a library setting for the system's base currency and (b) let
the format service be passed a currency code. Once both are in place,
CurrencyPipe can be restored.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: item-location-select: include ancestors

Specifically, when using permFilter, include locations at ancestors of
permitted OUs.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: AdminPageComponent: move onRowActivate subscription to markup

This allows extenders of this interface to set their own non-default
handlers.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: combobox: add idlBaseQuery input

This option allows to caller to tack on additional conditions to the
auto-generated data source, e.g., to restrict a selector to only
"active" values.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: combobox: asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries
in async mode, but fail to open the drop-down.

This includes code originally written by Bill Erickson with
additions by Galen Charlton to insure that static data sources
would continue to work.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: combobox: add a 'mandatory' attribute

This is a synonym of the 'required' attribute, as overloading
the HTML5 required attribute can lead the colored left border
indicated the state of the widget extending to the container
of the combobox.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: combobox: include org unit in label for funds

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: fm-editor: add min/max field options

This currently apply to 'int' type fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: fm-editor: prevent all-blank input

Text inputs no longer accept input that's entirely whitespace.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: fm-editor: add a linkedSearchConditions field option

This option allows the caller to specify conditions to add
when retrieving values for a linked field, e.g., to specify
that only active values should be fetched.

Example usage:

[fieldOptions]="{fund:{linkedSearchConditions:{'active':'t'}}}"

If the underlying record has a value set for the linked field, that
value will be included when preloadLinkedValues and the value
doesn't otherwise meet the search conditions.

This patch also sorts the values if preloadLinkedValues is used.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: fm-edit: teach how to format selectors when wiring up comoboxes

Matches similar functionality in combobox.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: eg-grid: define style for negative money values

This adds a negative-money-amount class when displaying money
fields whose value is less than zero.

Currently all that the class does is color the text red.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: teach grid columns how to start with a filter set

This adds initialFilterOperator and initialFilterValue inputs
to eg-grid-column to specify that the data set should start off
with a column filter set.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: add various IDL links from fund debits

This patch also adds acqlid (line item details) to PCRUD.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: update various IDL labels for acq columns

* Claiming and fund tables: "Org Unit" or "Org" to "Owner"
* "Claim Policy ID" to "Claim Policy" for links to claim
  policies
* "Fund ID" to "Fund" for links to funds
* Fund allocation and fund debit times

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: add edi_accounts virtual field to EDI attribute sets

This facilitates retrieving the list of EDI accounts that use
a given attribute set.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: add acqftr (fund transfers) to pcrud control

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: mark various fund columns as required in the IDL

In particular:

* Fund: org unit, name, year, currency, code
* Fund allocation: linked fund, linked funding source, amount,
                   allocating user
* Fund tag: owner, name
* Funding source: name, owner, currency, code
* Funding source credit: linked funding source, amount

As a consequence of this change, various recording editing interfaces
will now require that input be supplied for these fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1904244: consolidate claiming administration into single page

This patch consolidates the following acquisitions administration
interfaces into a single tabbed page for managing claiming
policies:

- Claim Policies
- Claim Policy Actions
- Claim Types
- Claim Event Types

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1934184 Vandelay Delete Queue action repair

Fixes the Queue Details page Delete Queue link.  Before it did nothing,
now it prompts the user to confirm deletion followed by deleting the
queue (when confirmed).

To test, go to Cataloging => MARC Batch Import/Export => Inspect Queue
=> Double-click a queue => Click Delete Queue (under Queue Actions) and
confirm that the confirmation dialog appears and deletion works.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1919483: Fix the queries for secondary admin pages

To test, go to the following screens, and make sure that their
secondary admin pages don't show errors and filter properly.

* Authority Control Set
* Authority Thesaurus
* Course list
* Hard due dates
* MARC import remove fields
* MARC Search/Facet fields
* Z39.50 servers

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Christine Burns <christine.burns@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1450519: remove unauthorized access to library setting history

This patch changes the current Library Settings editor so that
it doesn't display the setting history for a setting that the user
doesn't have the underlying view permission for. It also removes
the coustl IDL class [config.org_unit_setting_type_log] from PCRUD.

Access to the setting history is now done through a new method,
open-ils.actor.org_unit.settings.history.visible.retrieve, which
accepts an authtoken and a setting name. If the user has the
relevant view permission, setting history entries at all of the
OUs that they have the permission at are returned. If the user
lacks the permission, an empty array is returned. If the setting
has no permission associated with it, all history entries for
the setting are returned. The user must have at least STAFF_LOGIN
to retrieve any entries at all.

To test
-------
[1] As an administrator, make some changes to the values of
    a privileged library setting (such as one of the credit card
    ones) and an unprivileged one (e.g., lib.info_url).
[2] Log in as a staff user without administration privileges
    and go to the library settings editor. Note that while the
    current value of privileged settings are not displayed, clicking
    on the history link displays the full history of the setting.
[3] Apply the patch and repeat step 2.
[4] This time, history for the privileged setting is not displayed,
    while history for an unprivileged setting continues to be
    available.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1931167: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1931167: Missing YAOUS for DYM

The baseline schema did not get updated to include the
opac.did_you_mean.max_suggestions YAOUS, so fresh, rather than upgraded,
Evergreen installs will be missing it.

This commit adds it to the baseline and provides an upgrade script to
give the setting to impacted instances.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Erica Rohlfs <erica.rohlfs@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Lp 1936662: Add CPAN Module Prerequisites for Debian and Ubuntu

This commit adds the missing CPAN module prerequisites for the "did
you mean" feature to the PostgreSQL server Makefile targets for Debian
Jessie, Stretch, Buster and Ubuntu Bionic.

They were added to the Makefile target for Ubuntu Focal but were
apparently overlooked in the other distros.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1937299: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1937299: Collections Exempt User Setting Repair

The collections exempt user setting was never added to the seed data
meaning that depending on the age of your database it may or may not
be there. Additionally, correct the label for this setting in the
user editor.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1815968 - Self Check Audio Alerts

The method of playing audio alerts seems to not be working in modern browsers.

It seemed to work in firefox V40, but no longer in V68.

Adding the autoplay element and then immediately removing it prevents the audio
from playing.  I've also noticed in the past that the audio had been cut off
before the file was fully played.

Using the .play() method does seem to work in newer versions of Firefox
and Chrome.  Tested with Chrome V90 and Firefox V78.10.1esr.

Testing Plan:

1. Enable Self Check Audio Alerts Library Setting.
2. See the docs for setting up the default audio alerts.
https://docs.evergreen-ils.org/reorg/3.1/command_line_admin/_self_check_interface.html
3. Launch self check interface, create a workstation and try to trigger an alert.
https://eg-server.you.com/eg/circ/selfcheck/main
4. entering a fake barcode will trigger an alert which should not be audible.

Apply the fix:

1. Launch self check interface, and reload/clear cache.
2. Enter a fake barcode to trigger an audio alert.
3. The audio alert should now be audible.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Erica Rohlfs <erica.rohlfs@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1264746: add a release notes line

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1264746 return boolean, not promise

Change check_email_different to return a boolean instead of a
promise. Thanks, berick!

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1264746 Add "email password reset" to user editor

Add a button for "Send Password Reset Link" to the user editor.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904788 Browse navigation release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1904788 Staff catalog browse results paging

Adds the ability to step through browse headings directly from the
heading record list page without having to return to the original browse
search

To test:

1. Navigate to the staff catalog and perform a Browse search.

2. Click on one of the headings and you'll be taken to the page which
lists the bib records that use the selected heading.

3. Click the Previous Heading / Next Heading buttons to step through the
headings and view the linked bib records.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1894005: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1894005 Stripe payment intents, live test

Sponsored-by: CW MARS
Sponsored-by: NOBLE
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1894005 Stripe payment intents, release notes

Sponsored-by: CW MARS
Sponsored-by: NOBLE
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1894005 Stripe payment intents

===== Credit card payments using Stripe now implimented with PaymentIntents instead of Charges =====

This changes the Stripe code in the OPAC to use their PaymentIntents and confirmCreditCard API,
which is recommended over their Charges API.  Credit card charges are no longer finalized
(captured/confirmed) on Evergreen's backend, though the backend does check whether a payment was
made successfully before recording it.

Sponsored-by: CW MARS
Sponsored-by: NOBLE
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: small follow-up to remove an extra plus sign

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

DOCS:Shelving Locations, Added images and updated directions

Added images and updated information on Shelving locations. Included information on Hold_Verify
Adding additional information in to the shelving locations.
Added Index terms.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP1776977: Update lsa-address_alert.adoc and add images

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Update lsa-address_alert.adoc

https://bugs.launchpad.net/evergreen/+bug/1776977

The new address alert table is rearranged to match the web client.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP1908612 Bootstrap Opac - Limit to Available

Adds the 'Show All Copies' and 'Show Only Available Copies' to the Bootstrap
Opac's copy screen.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: Update apache_rewrite_tricks.adoc to further address LP1837753

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: update glossary.adoc to add TLD definition per LP1837753

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP1718782: follow up to fix failing test

LP1718782 added a missing fixed field, but failed to also add it to
the expected data in this pgtap test.  This commit updates the
expected data to also include a SRCE fixed field.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1718782: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1718782: Add the Srce fixed field to the Angular MARC editor

To test:

1) Without using private browsing, open up a bibliographic record in
the Angular catalog MARC editor.
2) Notice that there is a gap between the ELvl and Audn fixed fields.
3) Apply this patch.
4) Open up the same bibliographic record, this time using private
   browsing (since the Angular MARC editor caches fixed field values).
5) Notice that the Srce fixed field is available between the ELvl and
   Audn fixed fields.
6) Notice that you can right click inside the fixed field to get a list
   of three possible values.
7) Repeat the test with different record types (e.g. BKS, SCO, VIS)

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1913807 Staff catalog shows preferred lib holdings counts

Always show holdings counts for the preferred library (when set) even
when the library is not directly in the search scope.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1910808 Staff catalog show call number

In the search results page, show the first call number for each record
(sorting by label sortkey) that is owned either by the user's preferred
library or the search library.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1857060: Tests for ISBNs with 979 prefix

Also includes a slight tweak to the Amazon AddedContent code to avoid
attempting to convert 979 ISBNs to ISBN-10s (which is not possible).

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1910891: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1910891: Add new booking perms to appropriate groups

Steps to test:

1) Without this patch, create a reservation for a BR1 resource at BR1.
2) Log in as a circulator at BR1.
3) Go to Booking > Manage Reservations.  Note that you can't see your reservation.
4) Run this upgrade script.
5) Repeat steps 2-3.  Notice that you can now see the reservation.
6) Wipe your database and re-install it with the additions to the seed data
in this commit.  Repeat steps 1-3 and notice that you can see the reservation
as expected.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895737: Add Curbside Appointments to Bootstrap OPAC

Add support for requesting / editing / canceling curbside
appointments to the bootstrap opac.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1908722: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1908722: add electronic resource links

This patch adds electronic resource links to the Show More Details
view in the Angular staff catalog, above the table of items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1908722 Staff catalog Show More Details

Adds a "Show More Details" (and "Show Fewer Details") buttons to the
Angualr staff catalog.  Similar to the TPAC, activating the button means
more holdings details are displayed in the search results page.

Adds a new workstation setting type called
'eg.staff.catalog.results.show_more'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1844169: add release note entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: (follow-up) add navigation

This patch adds a link back to the list of Search Filter Groups
from the page for editing a single group.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: (follow-up) add validation to entry form

The Search Filter Group Entries modal now enforces
required fields client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: Compare query position against string

Compare queryPosition against '0' rather than int 0, avoiding Angular
issues during build process

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1844169: port Search Filter Groups admin interface to Angular

Port search filter groups admin from DOJO UI to Angular. Each search
filter group has its own edit page, from which you can edit search
filter group entries.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1362743 One modal at a time during batch checkin

Modify batch checkins so that only one modal pops up at a time.
When each one is dismissed the next one will appear.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1913221: Don't display blank course section number in OPAC

To test:

1) Use the Library Settings Editor to turn on the Course Materials
   Module.
2) In Local administration, go to the course reserves list.
3) Add several courses, some with section numbers, others without.
4) In the OPAC, use the Course Search function to search for the courses
   you just added.
5) Notice that the search results page has a place for section numbers,
   whether or not the course has one.
6) Click into some of the courses.  Notice that the course page also
   includes a place for section numbers, whether or not the course has
   one.
7) Apply this patch.
8) Repeat steps 4-6.  Notice that the blank "section number" areas no
   longer appear.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1920210: add auditor tables for acq.fund_debit

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1907296: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1907296 Missing Workstation setting for staff cat item table

Adds the ws setting type eg.grid.catalog.record.copies to allow users to
save grid preferences for the angular catalog item table.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1928005 Bootstrap Opac: Current charges not aligned on mobile.

This patch removes the classes from the charges table that presents the table in a vertical format.
It wraps the table in a <div> that uses the table-responsive class.

To test add some charges to a patron record.
Bring that patron's account up in the opac and view the charges table in the smallest browser size
possible.
Notice that the table switches to a vertical format and the column names are mis-aligned.

Apply the patch.

View the table again.  The table should now be horizontal with all of the columns correct.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929136: (follow-up) reduce bounce time to 500ms

During testing, 500ms was enough to avoid excessive
PCRUD calls while still keeping the interface's display
of duplicate or missing barcode warnings responsive.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1929136: delay barcode lookup on change in holdings editor

In the Holdings Editor, any change to the barcode field results in an
immediate API call.  Thus, if you type the barcode "123456789", you
would get 9 separate calls: 1, 12, 123, 1234, 12345 ...

This commit adds a 1000ms delay to avoid excessive pcrud calls when
typing a barcode.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: updates to library settings; filename fixes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Forward port the 3.6.3 to 3.6.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.5.4 to 3.5.5 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.5.3 to 3.5.4 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward-port 3.7.1 version upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.7.1 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: 3.6 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Release notes for 3.5.5

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1930933: fix issue with over-escaping in search results title attributes

This patch fixes an issue where a record with a title containing the
word "hidden" can have its title, ironically enough, not show up
on public catalog search results.

To test
-------
[1] Create an OPAC-visible record whose 245 is something like:

    =245 04$aThe hidden one <script>alert('title!')</script>

[2] Search for the record in both the TPAC and Bootstrap skin. Note
    that the title isn't displayed.
[3] Apply the patch and repeat step 2. This time, the full title
    should be displayed.
[4] Verify that the OPAC does not display an alert box.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP1910145 Angular Hold Detail Notes & Notifications

The hold detail view now displays hold notes and hold notification
records.  Notes and Notifications may be created by staff.  Notes may be
deleted by staff.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1887876 Checkout catalog doesn't load workstation prefs

The catalog under the Holds tab in the Checkout interface
doesn't load the default search or preferred library if
you haven't visited the main catalog page earlier in the
session.

This branch sets these settings as cookies in the
AngularJS wrapper for the catalog embedded in the Checkout
interface under the Holds tab.

Test:
1. Close browser, open browser, log into Evergreen
2. Admin->Workstation set search & preferred library
3. Open a patron record -> Holds tab -> Place Holds
4. Search for an item owned by your preferred library
5. Note the library's copies aren't separately indicated
6. Apply patch and repeat steps 1-5
7. Note the library's copies are separately indicated

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1930088 Angular catalog: metarecord search returns no results

This adds a missing param to a call to get_one_record_summary
that's necessary after commit c07ce8.

To test, perform a search using the Group Formats/Editions checkbox
and you should see results.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1895738: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1895738 need eg.orgselect.hopeless.wide_holds

This fixes the following:

ERROR Error: Uncaught (in promise): No user or workstation setting type exists for: "eg.orgselect.hopeless.wide_holds".
Create a ws/user setting type or use setLocalItem() to store the value locally.

However, it exposes a different (harmless?) error within the /eg2 holds grid:

ERROR Error: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value for 'ng-untouched': 'true'. Current value: 'false'.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1901893: (follow-up) add cellTextGenerator

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1901893 Bucket column link tweak

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1901893 Carousel bucket should be linked from grid

Re-formats the bucket column content as a link that opens the
carousel's associated bucket in a new tab.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778955: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1778955: fixing upgrade script, removing duplicate function definition

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>