Evergreen.git
7 years agoLP#1251394 Display Fields DB schema continued
Bill Erickson [Thu, 14 Nov 2013 19:15:28 +0000 (14:15 -0500)]
LP#1251394 Display Fields DB schema continued

* Schema chnange continued
* mde IDL entry
* flat display IDL view
* IDL links from bre to mde/mfde

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1251394 Add display_field column to config.metabib_field
Dan Scott [Mon, 27 Jun 2011 20:53:55 +0000 (16:53 -0400)]
LP#1251394 Add display_field column to config.metabib_field

The idea is to pull the XPath definitions and i18nized labels for
config.metabib_field entries into other contexts, to avoid duplicate /
conflicting defintions in different layers of the code. If display_field
is TRUE, then it is a signal that it could be usefully exposed to users.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1599894 - OPAC disable Add to MyList when doing metabib search
Cesar Velez [Fri, 11 Aug 2017 21:52:13 +0000 (17:52 -0400)]
LP#1599894 - OPAC disable Add to MyList when doing metabib search

Since adding a result to MyList yields to a random title
(due to bad id) being added to temp. lists, disable MyList if
metabib search is on, i.e "Group formats and editions"
checkbox is checked.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/opac/parts/result/table.tt2

7 years agoLP#1673870: release notes for ebook transactions
Jeff Davis [Fri, 1 Sep 2017 17:36:26 +0000 (10:36 -0700)]
LP#1673870: release notes for ebook transactions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: avoid e-session cookie weirdness
Galen Charlton [Thu, 31 Aug 2017 16:59:40 +0000 (12:59 -0400)]
LP#1673870: avoid e-session cookie weirdness

This patch is a bit of hackery to work around an intermittent
(but frequent) situation where the vendor session cookie got
cleared right before invoking the cancel hold method, leading
to its failure.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: some tidying up of JavaScript
Galen Charlton [Thu, 31 Aug 2017 16:17:12 +0000 (12:17 -0400)]
LP#1673870: some tidying up of JavaScript

- test for ebook_spinner div before attempting to set a class
- eject a couple Perlisms

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: add support for cache-busting
Galen Charlton [Thu, 31 Aug 2017 15:49:08 +0000 (11:49 -0400)]
LP#1673870: add support for cache-busting

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: fix OneClickdigital handler to reflect how their API actually works,...
Jeff Davis [Wed, 16 Aug 2017 18:30:54 +0000 (11:30 -0700)]
LP#1673870: fix OneClickdigital handler to reflect how their API actually works, documentation notwithstanding

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: display ebook availability when detailed holdings info is unavailable
Jeff Davis [Mon, 14 Aug 2017 21:03:59 +0000 (14:03 -0700)]
LP#1673870: display ebook availability when detailed holdings info is unavailable

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: indicate suspended holds for OverDrive
Jeff Davis [Wed, 12 Jul 2017 19:35:43 +0000 (12:35 -0700)]
LP#1673870: indicate suspended holds for OverDrive

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: move ebook availability JS to standard location
Jeff Davis [Tue, 11 Jul 2017 22:45:48 +0000 (15:45 -0700)]
LP#1673870: move ebook availability JS to standard location

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: show spinner in My Account while loading from ebook API
Jeff Davis [Fri, 18 Aug 2017 20:35:09 +0000 (13:35 -0700)]
LP#1673870: show spinner in My Account while loading from ebook API

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Handle OverDrive ebook checkout and download
Jeff Davis [Tue, 4 Jul 2017 23:20:11 +0000 (16:20 -0700)]
LP#1673870: Handle OverDrive ebook checkout and download

The workflow for checking out and downloading a title via the OverDrive
API is relatively complex:

1. Check out a title.

2. Lock in a specific format for the checked-out title.  Once you lock
in a format, you can only download the title in that format -- except
that the browser-based OverDrive Read and OverDrive Listen formats are
always available (if supported for that title), even if you've locked in
another format.

3. Request a link for downloading the title in the specified format.
Download links are dynamically generated and only work for 60 seconds
from the time of your request.

To simplify the process, we require the user to lock in a format during
checkout.  Then, when the user clicks the Download button, we request a
download link; OverDrive responds with a URL, and we immediately
redirect the current browser tab/window to that URL.

A new API call, open-ils.ebook_api.title.get_download_link, has been
added for requesting the download link.  Since API calls are not
vendor-specific, we also add support for the new method in the test
module, complete with unit test.

Supplementary fixes:

- show spinner in My Account while loading from ebook API
- ensure session ID is available to ebook object during transactions
- fix display of ebook formats

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: fix bug that prevented more than one ebook transaction from appearing...
Jeff Davis [Wed, 28 Jun 2017 20:49:37 +0000 (13:49 -0700)]
LP#1673870: fix bug that prevented more than one ebook transaction from appearing in list in My Account

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Support placing and canceling OverDrive holds
Jeff Davis [Wed, 28 Jun 2017 20:36:24 +0000 (13:36 -0700)]
LP#1673870: Support placing and canceling OverDrive holds

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Use separate templates for ebook checkouts and holds
Jeff Davis [Mon, 26 Jun 2017 23:23:54 +0000 (16:23 -0700)]
LP#1673870: Use separate templates for ebook checkouts and holds

Previously we used the same TT2 template for listing checkouts and
performing a checkout, and for listing holds and placing a hold.  This
leads to problems; in particular, URL parameters required for checkout
and hold actions were "sticky," so viewing your holds after placing a
hold would show the "Place Hold" UI instead of a list of holds.  This
commit introduces separate templates for ebook actions as a workaround.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: remove separate JS function for ready-only holds
Jeff Davis [Fri, 14 Jul 2017 18:56:54 +0000 (11:56 -0700)]
LP#1673870: remove separate JS function for ready-only holds

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Add ebook API cancel hold functionality to OPAC
Jeff Davis [Fri, 23 Jun 2017 22:57:49 +0000 (15:57 -0700)]
LP#1673870: Add ebook API cancel hold functionality to OPAC

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Link ebook transaction objects to vendor in JS
Jeff Davis [Fri, 23 Jun 2017 20:43:03 +0000 (13:43 -0700)]
LP#1673870: Link ebook transaction objects to vendor in JS

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Add ebook transaction links to search results and record details
Jeff Davis [Wed, 21 Jun 2017 19:05:11 +0000 (12:05 -0700)]
LP#1673870: Add ebook transaction links to search results and record details

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Add ebook API place hold functionality to OPAC
Jeff Davis [Wed, 22 Mar 2017 20:00:47 +0000 (13:00 -0700)]
LP#1673870: Add ebook API place hold functionality to OPAC

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Checkout/renew/checkin methods for OverDrive API
Jeff Davis [Tue, 21 Mar 2017 22:32:48 +0000 (15:32 -0700)]
LP#1673870: Checkout/renew/checkin methods for OverDrive API

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Add ebook API checkout functionality to OPAC
Jeff Davis [Fri, 17 Mar 2017 22:22:32 +0000 (15:22 -0700)]
LP#1673870: Add ebook API checkout functionality to OPAC

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: Add basic ebook API title lookup
Jeff Davis [Fri, 17 Mar 2017 20:04:09 +0000 (13:04 -0700)]
LP#1673870: Add basic ebook API title lookup

Adds an API method to obtain the title and author (and, eventually,
cover image URL) for a given ebook via the open-ils.ebook_api service.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1673870: process ebook variable in misc_util.tt2
Jeff Davis [Fri, 14 Jul 2017 18:48:49 +0000 (11:48 -0700)]
LP#1673870: process ebook variable in misc_util.tt2

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1638299: Stamping upgrade scripts for authority infrastructure work
Kathy Lussier [Fri, 1 Sep 2017 20:05:08 +0000 (16:05 -0400)]
LP#1638299: Stamping upgrade scripts for authority infrastructure work

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: Fix label for narrower terms
Kathy Lussier [Fri, 1 Sep 2017 19:48:27 +0000 (15:48 -0400)]
LP#1638299: Fix label for narrower terms

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: fix typo
Galen Charlton [Fri, 1 Sep 2017 19:01:29 +0000 (15:01 -0400)]
LP#1638299: fix typo

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: rename schema update scripts to clarify their proper order
Galen Charlton [Fri, 1 Sep 2017 02:42:41 +0000 (22:42 -0400)]
LP#1638299: rename schema update scripts to clarify their proper order

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: add release notes
Galen Charlton [Fri, 1 Sep 2017 02:37:01 +0000 (22:37 -0400)]
LP#1638299: add release notes

Also, here is a basic testing plan:

- Upon applying the patch, verify that browse in the public
  catalog uses See, broader or narrower term, and see also
  as labels.
- Verify that scope notes now only display under the main
  heading in the browse list.
- Verify that turning off the Display related headings (see-also) in browse
  global flag disables display of see-also (related headings)
  in the public headings browse. Note that it may be necessary to
  clear memcached caching of cgf.
- Verify that see references are consistently shown.
- Verify that Server Administration | Authority Headings Fields works
- Verify that Server Administration | Thesauri now includes fields for
  short code and URI.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: add new authority.thesaurus columns to IDL
Galen Charlton [Fri, 1 Sep 2017 02:30:02 +0000 (22:30 -0400)]
LP#1638299: add new authority.thesaurus columns to IDL

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: fix display of joiners for related and variant headings
Galen Charlton [Fri, 1 Sep 2017 02:12:48 +0000 (22:12 -0400)]
LP#1638299: fix display of joiners for related and variant headings

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: reify schema and seed data for new databases
Galen Charlton [Thu, 31 Aug 2017 22:30:14 +0000 (18:30 -0400)]
LP#1638299: reify schema and seed data for new databases

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: adjust staff-side authority browse
Galen Charlton [Thu, 31 Aug 2017 21:22:36 +0000 (17:22 -0400)]
LP#1638299: adjust staff-side authority browse

Now that the primary key of the authority.thesarus table
has changed from the single-character code to the LC-assigned
authority code, a bit of additional translation is required.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: improve display of related headings in browse
Galen Charlton [Thu, 27 Jul 2017 22:31:47 +0000 (22:31 +0000)]
LP#1638299: improve display of related headings in browse

This patch adds a new global flag to control whether see
alsos are displayed at all; it also allows better labels based
on the heading purpose.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: improve display of scope notes in headings browse
Galen Charlton [Thu, 27 Jul 2017 20:51:25 +0000 (20:51 +0000)]
LP#1638299: improve display of scope notes in headings browse

Scope notes are now displayed only under uses of a heading as a main
heading.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1358392: use ahf to determine whether headings fields are variant
Galen Charlton [Thu, 31 Aug 2017 20:26:27 +0000 (16:26 -0400)]
LP#1358392: use ahf to determine whether headings fields are variant

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1358392: See references not always displaying on browse search
Srey Seng [Fri, 5 Sep 2014 21:28:07 +0000 (14:28 -0700)]
LP#1358392: See references not always displaying on browse search

When browsing for an unauthorized heading, See references are not always
displaying on browse search. Those that do display surface due to the
existence of cross-reference(s).

Desired behaviour is that unauthorized headings should also surface in browse
results, even without the existence of cross-reference(s), as long as the
authority record containing the unauthorized heading controls at least one bib.
There are many authority records that do not have cross-references but do contain
unauthorized headings, so browse results that would otherwise be hidden would now
be exposed.

This fix adds an additional logic to check if the browse term is an
unauthorized term and if so, perform a slightly modified procedure
but otherwise, perform the usual procedure so as not to break any existing
functionality.

Signed-off-by: Srey Seng <sreyseng@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/030.schema.metabib.sql

Rebased to account for eliminated staged search work.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: add list of thesauruses
Mike Rylander [Tue, 7 Feb 2017 21:40:47 +0000 (16:40 -0500)]
LP#1638299: add list of thesauruses

This patch gets a full list of subject thesuaruses from LC
and uses them in control set mapping.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

7 years agoLP#1638299: improve extraction of headings from authority records
Galen Charlton [Fri, 6 Jan 2017 22:43:34 +0000 (17:43 -0500)]
LP#1638299: improve extraction of headings from authority records

This patch sets up configuration tables, seed data,
and functions for extracting headings from authority records based on
(usually) the MARCXML to MADS XSLT.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: sample LC and MeSH authority records
Galen Charlton [Fri, 6 Jan 2017 19:49:16 +0000 (14:49 -0500)]
LP#1638299: sample LC and MeSH authority records

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1638299: MADS 2.1 stylesheet
Mike Rylander [Tue, 6 Dec 2016 21:49:15 +0000 (16:49 -0500)]
LP#1638299: MADS 2.1 stylesheet

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP#1710991: Do not translate username and workstation in webclient navbar
Ben Shum [Tue, 15 Aug 2017 22:43:09 +0000 (18:43 -0400)]
LP#1710991: Do not translate username and workstation in webclient navbar

In the web client's navbar, do not translate username and workstation. This
causes errors with rendering the menus if other locales translate the
variables.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1582354: put release notes entry in proper directory and fix typo
Galen Charlton [Fri, 1 Sep 2017 19:24:29 +0000 (15:24 -0400)]
LP#1582354: put release notes entry in proper directory and fix typo

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1688398: add release notes
Galen Charlton [Fri, 1 Sep 2017 19:23:38 +0000 (15:23 -0400)]
LP#1688398: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1688398: some tidying
Galen Charlton [Fri, 1 Sep 2017 18:35:52 +0000 (14:35 -0400)]
LP#1688398: some tidying

- add a target for the View Charges button
- remove some comments

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1688398 - fix hardcoded logo url in payment email trigger template
Cesar Velez [Wed, 30 Aug 2017 21:14:05 +0000 (17:14 -0400)]
LP#1688398 - fix hardcoded logo url in payment email trigger template

Remove hardcoded logo so this can go out for 3.0

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1688398: revamp public catalog bill payment page
Suzanne Paterno [Thu, 10 Aug 2017 17:15:39 +0000 (13:15 -0400)]
LP#1688398: revamp public catalog bill payment page

- Changed table layout of the credit card charges on the Account screen.
  Moved checkbox to left of screen, added a column for Billing Type.
- Add button to Pay Selected vs All Charges.
- Include image of credit cards accepted (need to update with one with
  AmEx)
- Reformatted page for inputting credit card
- Updated confirmation screen to bold amount, and list the titles as
  the ones the user is paying for.
- Changed Print reciept template in seed data to look more readable and
  like other itemized reciepts.

Signed-off-by: Suzanne Paterno <paterno@noblenet.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1688398: change wording on OPAC bill payment pages
Suzanne Paterno [Thu, 10 Aug 2017 15:38:53 +0000 (11:38 -0400)]
LP#1688398: change wording on OPAC bill payment pages

On the credit card screens replaced the word "Fines" with "Charges"
since not all charges are fines. Can be cost of replacement materials,
as well as other non-circulation fees.

Signed-off-by: Suzanne Paterno <paterno@noblenet.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoStamp upgrade scripts for native EDI support
Mike Rylander [Fri, 1 Sep 2017 17:26:05 +0000 (13:26 -0400)]
Stamp upgrade scripts for native EDI support

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 EDI attribute set clone operation
Bill Erickson [Wed, 23 Aug 2017 17:07:33 +0000 (13:07 -0400)]
LP#1373690 EDI attribute set clone operation

Support cloning existing attribute sets via a new 'Clone "<existing set
name>"' action in the EDI attr set editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690: add USE_ID_FOR_OWNING_LIB EDI attribute
Galen Charlton [Tue, 22 Aug 2017 20:13:54 +0000 (16:13 -0400)]
LP#1373690: add USE_ID_FOR_OWNING_LIB EDI attribute

This attribute specifies that the copy owning library
should have its ID emitted rather than its shortname, which can
be used for Baker & Taylor, which imposes a five-character limit
on certain fields. This takes effect only when the INCLUDE_OWNING_LIB
EDI attribute is also in effect.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690: fix typos
Galen Charlton [Tue, 22 Aug 2017 20:03:24 +0000 (16:03 -0400)]
LP#1373690: fix typos

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690: normalize IMD values better
Galen Charlton [Tue, 22 Aug 2017 20:00:47 +0000 (16:00 -0400)]
LP#1373690: normalize IMD values better

The EDItEUR book ORDERS message allows two 35-character
item description data elements in IMD segments; this patch
accounts for that. It also, for IMD fields, uses the EDIFACT
release character to escape certain characters, better matching
how the Ruby EDI translator did it.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 EDI 'use_attrs' configuration option
Bill Erickson [Fri, 18 Aug 2017 15:51:39 +0000 (11:51 -0400)]
LP#1373690 EDI 'use_attrs' configuration option

Adds a new configuration option for EDI accounts specifying wether
purchase orders delivered via a given account should be constructed
using the new EDI Attributes in lieu of the traditional JEDI A/T
template.

The PurchaseOrderEDIRequired A/T validator now bypasses orders with
use_attrs=true accounts.  The new edi_order_pusher.pl script only
process providers whose default EDI accounts have use_attrs=true (except
when a specific PO ID is provided).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 Midwest Library Service EDI attrs
Bill Erickson [Thu, 22 Jun 2017 18:49:14 +0000 (14:49 -0400)]
LP#1373690 Midwest Library Service EDI attrs

Adds a new default collection of EDI attributes for Midwest Library
Service.  This includes 2 new attributes to support their EDI format:

1. BUYER_ID_ONLY_VENDCODE -- similar to BUYER_ID_INCLUDE_VENDCODE,
   except the buyer SAN is excluded from the NAD+BY segement.

2. INCLUDE_EMPTY_IMD_VALUES -- Render IMD+ fields (title, author,
   edition, etc.) as if they contain values even when they don't.  Empty
   values are included as single-space strings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 EDI attributes release notes
Bill Erickson [Thu, 3 Nov 2016 15:19:36 +0000 (11:19 -0400)]
LP#1373690 EDI attributes release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 EDI attribute sets admin UI
Bill Erickson [Wed, 8 Mar 2017 17:47:55 +0000 (12:47 -0500)]
LP#1373690 EDI attribute sets admin UI

1. Create new attribute sets
2. Rename attribute Sets.
3. Enable / Disable attributes for each attributes set.

Found under Admin -> Acquisitions -> EDI Attribute Sets.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 EDI ORDERS generator script
Bill Erickson [Fri, 27 May 2016 19:46:27 +0000 (15:46 -0400)]
LP#1373690 EDI ORDERS generator script

Adds a new edi_order_pusher.pl script for generating EDI ORDERS from
purchase orders via EDIWriter.pm.  This is a replacement for
edi_pusher.pl, but edi_pusher.pl remains for backwards compat.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1373690 Attribute-based EDI generator
Bill Erickson [Wed, 25 May 2016 21:40:17 +0000 (17:40 -0400)]
LP#1373690 Attribute-based EDI generator

New Perl module Utils::EDIWriter for buliding EDI ORDERS messages.

Vendor-specific toggles live in new database tables (acq.edi_attr,
acq.edi_attr_set, acq.edi_attr_set_map).

The combination of these 2 replaces the current JEDI Action/Trigger
template with toggle embedded in the template.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1710949: add tests for blocking after failed attempts
Galen Charlton [Fri, 1 Sep 2017 16:31:41 +0000 (12:31 -0400)]
LP#1710949: add tests for blocking after failed attempts

Enhance the live tests to verify that attempts to log in
get blocked after too many failed ones; this assumes
a stock value for block_count.

General testing plan:

[1] Use srfsh to test, e.g.,

srfsh# request open-ils.auth open-ils.auth.login {"identifier":"99999389406","password":"12345","type":"opac","org":1}

[2] Try various scenarios:

    - wrong password
    - type = staff but user doesn't have STAFF_LOGIN
    - repeated failed attempts
    - barcode is inactive
    - using "identifier" in conjunction with opac.barcode_regex set
    - using "username" or "barcode"
    - supplying a workstation name that exists
    - ... or does not
    - user is inactive
    - user is marked barrred

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1710949 Release notes for auth.login
Bill Erickson [Wed, 16 Aug 2017 14:55:26 +0000 (10:55 -0400)]
LP#1710949 Release notes for auth.login

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1710949 Redact open-ils.auth.login params
Bill Erickson [Tue, 15 Aug 2017 21:45:19 +0000 (17:45 -0400)]
LP#1710949 Redact open-ils.auth.login params

Add open-ils.auth.login to the list of API calls whose parameters should
not be logged.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1710949 auth.login Perl live test script
Bill Erickson [Tue, 15 Aug 2017 19:21:01 +0000 (15:21 -0400)]
LP#1710949 auth.login Perl live test script

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1710949 open-ils.auth.login API
Bill Erickson [Tue, 15 Aug 2017 17:13:03 +0000 (13:13 -0400)]
LP#1710949 open-ils.auth.login API

Adds a new open-ils.auth API call 'open-ils.auth.login' which performs
the combined steps of open-ils.auth.authenticate.init and
open-ils.auth.authenticate.complete so the caller only need call one API
to login.

API params are consistent with open-ils.auth.authenticate.complete with
2 notable excpetions.  The API uses the bare password instead of the
hashed password, so the caller also need not perform the extra hashing
steps.  Also, no 'nonce' parameter is used as it's no longer needed,
because there is no intermediate authentication cache object as with
.init.

Response data is consistent with open-ils.auth.authenticate.complete.

Example:

srfsh# request open-ils.auth open-ils.auth.login {"username":"admin","password":"fakepassword"}

Other changes in the new code:

1. Using the generic "identifier" parameter in combination with the
   "org" parameter allows the API to reliably determine if a value
   is a username or barcode.

2. Once a caller has reached the configured maximum number of login
   failures, no further attempts to track failures occurs, based on the
   idea that no additional cpu/network cycles should be used on a lost
   cause.

3. A failure count object is only added to memcache when failures
   occur, unlike open-ils.auth.authenticate.init which creates a
   failure tracking object for every login.

4. The code avoids use of the jsonParseFmt() and va_list_to_string()
   functions as these functions require extra data cleansing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1708291: tweak to subscription selector
Galen Charlton [Tue, 29 Aug 2017 20:11:13 +0000 (16:11 -0400)]
LP#1708291: tweak to subscription selector

When entering the Manage Predictions or Manage Issues tab
and only one subscription is present in the current OU
scope, automatically select it rather than making the operator
have to select it manually.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: remove initials field for serial notes
Jason Etheridge [Fri, 4 Aug 2017 17:51:36 +0000 (13:51 -0400)]
LP#1708291: remove initials field for serial notes

This was a carry-over from the copy notes modal that doesn't
apply to serial notes.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: add release notes
Galen Charlton [Fri, 4 Aug 2017 18:02:59 +0000 (14:02 -0400)]
LP#1708291: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: web staff client serials module
Galen Charlton [Thu, 13 Apr 2017 16:03:52 +0000 (12:03 -0400)]
LP#1708291: web staff client serials module

This patch adds a serials module to the web staff client, implementing
a unified serials interface allowing for the following actions supported
by the XUL staff client:

- creating subscriptions, distributions, and streams
- creating and editing prediction patterns
- receiving serial issues, with or without barcodes (units)
- batch and quick receiving

This module also implements some new features, including

- the ability to save prediction pattern codes as templates
  that can be shared and reused within an Evergreen database
- a more streamlined interface for managing subscriptions,
  distributions, and streams
- it is no longer necessary to create a starting issue in
  order to predict a run of issues; the dialog box for
  generating a set of predicted issues now lets you specify
  the starting point directly.
- the ability to more directly edit MFHDs

The new serials interfaces can be accessed from the record
details page via a Serials drop-down button that links to
a subscription management page, a quick-receive action, and
a MFHD management page. There is also a new Serials Administration
page where prediction pattern and serial copy templates can
be managed.

To test
-------
* Create, edit, and delete subscriptions, distribution streams,
  and routing lists.
* Use the prediction pattern wizard to create patterns.
* Save prediction pattern templates and use them to apply
  a pattern to new subscriptions.
* Verify that sets of issues can be predicted and received.
* Create and apply serial copy templates and verify that
  they are applied when receiving barcoded issues.

This patch represents a group coding effort by Galen Charlton,
Jason Etheridge, and Mike Rylander.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql
Open-ILS/web/js/ui/default/staff/cat/catalog/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: introduce egI18N
Galen Charlton [Thu, 29 Jun 2017 21:09:54 +0000 (17:09 -0400)]
LP#1708291: introduce egI18N

egI18N is a module that will serve as a grab-bag of functions
related to I18N and L10N. The initial function it provides
takes a acpl IDL object and returns a formatted name qualified
by the org unit, with the underlying template accessible
to the translation subsystem.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/base_js.tt2
Open-ILS/web/js/ui/default/staff/Gruntfile.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: teach egBasicComboBox and egDatePicker to accept focusMe
Galen Charlton [Thu, 6 Jul 2017 21:14:15 +0000 (17:14 -0400)]
LP#1708291: teach egBasicComboBox and egDatePicker to accept focusMe

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/web/js/ui/default/staff/services/ui.js

Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1152753: make it possible for serial units to be added to copy buckets
Mike Rylander [Mon, 24 Apr 2017 16:40:37 +0000 (12:40 -0400)]
LP#1152753: make it possible for serial units to be added to copy buckets

This patch replaces the baseline asset.copy.id fkey constraints with ones
that understand inheritance, and change all existing contstraints to do the
same via upgrade script.

To test
-------
Create some serial units and verify that they can be added to a copy
bucket.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: add an egHelpPopover directive
Galen Charlton [Tue, 20 Jun 2017 22:10:46 +0000 (18:10 -0400)]
LP#1708291: add an egHelpPopover directive

This directive allows adding help text accessible by clicking
on a question mark icon.  Example usage:

<eg-help-popover help-text="Use the Force, Leia!">

to create simple popover or

<eg-help-popover help-text="Learn MARC21"
                 help-link="https://www.loc.gov/marc"
>

to have the help text hyperlinked.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: add a join filter for angular templates
Jason Etheridge [Tue, 30 May 2017 15:51:51 +0000 (11:51 -0400)]
LP#1708291: add a join filter for angular templates

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: teach egEmbedFrame about an afterload function
Mike Rylander [Thu, 25 May 2017 00:37:17 +0000 (20:37 -0400)]
LP#1708291: teach egEmbedFrame about an afterload function

The 'afterload' attribute added by this patch allows specifying
the name of a function (to be supplied by the embedded content)
to run after the frame has been loaded.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: add API for safe deleting various serial records
Jason Etheridge [Mon, 22 May 2017 21:28:17 +0000 (17:28 -0400)]
LP#1708291: add API for safe deleting various serial records

This adds routines for safely deleting subscriptions,
distributions and streams.

open-ils.serial.subscription.safe_delete
open-ils.serial.distribution.safe_delete
open-ils.serial.stream.safe_delete
open-ils.serial.subscription.safe_delete.dry_run
open-ils.serial.distribution.safe_delete.dry_run
open-ils.serial.stream.safe_delete.dry_run

Won't delete if there are attached serial.item records with a status other
than Expected, or if there are any attached non-deleted serial.unit
records.

The dry_run variants behave exactly the same except they don't actually
delete anything.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: teach MARC editor that it can edit MFHDs/SREs
Galen Charlton [Tue, 23 May 2017 21:59:18 +0000 (17:59 -0400)]
LP#1708291: teach MARC editor that it can edit MFHDs/SREs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: teach egGrid to always show checkbox menu items
Mike Rylander [Thu, 18 May 2017 23:24:45 +0000 (19:24 -0400)]
LP#1708291: teach egGrid to always show checkbox menu items

This patch also tweaks some styles.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: improvements to egEditFmRecord
Galen Charlton [Wed, 10 May 2017 21:36:44 +0000 (17:36 -0400)]
LP#1708291: improvements to egEditFmRecord

egEditFmRecord now knows how to specify that a custom Angular template
be used to supply the input widget for a given field; the initial use
of this will be allowing the prediction pattern template editor to be
used to set the pattern in a pattern template. The customFieldTemplates
attribute is used for this purpose.

This patch also teaches egEditFmRecord when to allow an org unit
selector to default to the workstation OU. The orgDefaultAllowed
attribute is used for this purpose.

Finally, a fixes a bug that ensures that the Save button is active
only when the entire form is valid.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: add a egShareDepthSelector directive
Galen Charlton [Tue, 9 May 2017 18:56:04 +0000 (14:56 -0400)]
LP#1708291: add a egShareDepthSelector directive

This directive implements a selector for OU-sharing depths; depths
and names come from the actor.org_unit_type table. If there are
multiple types defined for a given depth, the display value in
the selector is the concatenation of their names.

The initial use of this directive is for specifying how broadly
prediction pattern templates should be seen.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1708291: teach egIDL a new fieldmapper object representation
Galen Charlton [Fri, 21 Apr 2017 16:05:45 +0000 (12:05 -0400)]
LP#1708291: teach egIDL a new fieldmapper object representation

This patch teaches egIDL how to represent fieldmapper objects
as objects with attributes rather than getter/setters. This
allows FM objects to be more easily bound to common to Angular
input widgets, avoiding the verbosity of getterSetter ng-options
and the fact that some widgets like uib-datepicker-popup don't
support getterSetter in the first place.

Usage is:

  hash = obj.toTypedHash()

and

  obj = new egCore.idl.fromTypedHash(hash);

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1682609: upgrade to angular-ui-bootstrap 1.3.3
Galen Charlton [Thu, 13 Apr 2017 19:33:06 +0000 (15:33 -0400)]
LP#1682609: upgrade to angular-ui-bootstrap 1.3.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
7 years agoLP#1709521 Apply recent patrons from checkout
Bill Erickson [Fri, 1 Sep 2017 01:14:32 +0000 (21:14 -0400)]
LP#1709521 Apply recent patrons from checkout

Load the max recent patrons setting directly in the patron service
instead of requring the calling UI to apply it.  This fixes an issue
where recent patrons are not set from the checkout-by-barcode
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoLP1655158 Patron Search by Date of Birth
blake [Thu, 31 Aug 2017 20:33:17 +0000 (20:33 +0000)]
LP1655158 Patron Search by Date of Birth

Adds three UI boxes to the WBSC "Show Extra" patron search. One for the year, month and day.
The javascript on the page is altered to deliver group "4" to the backend. Local javascript
strips out non-numeric user entered data. The backend is updated to handle the new group.
SQL is genereated using the DATE_PART postgres function.

1. Open the web based staff client and browse to the patron search UI.
2. Click the show more down arrow button. Notice the lack of birth date field.
3. Apply the patch, repeat step one. Notice the addition of birth date boxes.
4. Type 1975 into the birth year box and press enter. Notice search results.
5. Try searching for partial names and partial birthdates.
6. Try entering non-numeric data into the birth date boxes.
7. Try searching for patrons without including the dob. Try with only the dob. Try a mix.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoLP#1695029 Patron reg. supports bool opt-in defaults
Bill Erickson [Fri, 21 Jul 2017 18:50:17 +0000 (14:50 -0400)]
LP#1695029 Patron reg. supports bool opt-in defaults

Support default values for boolean user opt-in settings during patron
registration.  A default value of True, true, T, or t (or really
anything starting with a 't') is treated as true.  Any other value
(including null) means false.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agoLP#1695029-Webstaff Fix Patron Registration page never loading
Cesar Velez [Tue, 27 Jun 2017 19:06:48 +0000 (15:06 -0400)]
LP#1695029-Webstaff Fix Patron Registration page never loading

It looks like there was a variable mistype causing the page
to not load, but the setting that the lp bug mentions wasn't being
properly bound and needed to be wrapped to a boolean.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agolp1709521 stamping schema upgrade
Jason Etheridge [Thu, 31 Aug 2017 03:48:24 +0000 (23:48 -0400)]
lp1709521 stamping schema upgrade

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agoLP#1709521: Tweak description for new OU setting
Kathy Lussier [Tue, 29 Aug 2017 14:29:16 +0000 (10:29 -0400)]
LP#1709521: Tweak description for new OU setting

Update the description for the new Number of Retrievable Recent Patrons OU
Setting to identify the default value if left unset.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agoLP#1709521 Release notes for show recent patrons
Bill Erickson [Sat, 12 Aug 2017 15:52:26 +0000 (11:52 -0400)]
LP#1709521 Release notes for show recent patrons

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agoLP#1709521 Webstaff show recent patrons
Bill Erickson [Sat, 12 Aug 2017 15:52:40 +0000 (11:52 -0400)]
LP#1709521 Webstaff show recent patrons

Adds a new library setting 'ui.staff.max_recent_patrons' which
specifices the number of recently accessed patrons staff may quickly
refetch from the browser client interface.  If no value is set, it
defaults to 1 for backwards compatibility.

If the value is 0 or less, no recent patrons may be retrieved and the
'Retrieve Last Patron' action is hidden.  If the value is > 1 a new
'Retrieve Recent Patrons' menu item appears.  When clicked, the list
of recent patrons is displayed in the patron search interface, most
recently accessed patrons sorted to the top.

For privacy, the recent patrons list expires from the browser when the
authenticion token expires.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
7 years agoLP#1683575 - Webstaff fix silent fail of bad barcodes in ItemStatus
Cesar Velez [Wed, 16 Aug 2017 21:39:30 +0000 (17:39 -0400)]
LP#1683575 - Webstaff fix silent fail of bad barcodes in ItemStatus

This address the current issue in master, that causes bad barcodes
to fail silently.

To test
-------
[1] In the web staff client, go to Item Status and enter an item
    barcode that is not present in the database. Note that no
    warning message displayed.
[2] Apply the patch and repeat step 1. This tie, an 'Item Not Found'
    message is displayed.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
7 years agoLP#1642086: Relase note for jQuery support
Mike Rylander [Wed, 30 Aug 2017 21:03:31 +0000 (17:03 -0400)]
LP#1642086: Relase note for jQuery support

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1642086: Adjust offline resources for jquery support
Mike Rylander [Wed, 30 Aug 2017 20:54:59 +0000 (16:54 -0400)]
LP#1642086: Adjust offline resources for jquery support

Offline needs to know about all the resources and their correct locations.
Since we're moving jquery.min.js, tell it about that.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1642086 TPAC Jquery path repair, .gitignore, karma
Bill Erickson [Wed, 30 Aug 2017 15:53:40 +0000 (11:53 -0400)]
LP#1642086 TPAC Jquery path repair, .gitignore, karma

* Repair JS path in TPAC jquery import.

* Tell git to ignore Open-ILS/web/js/ui/default/common/build/ since it
  only contains generated files.

* Add jquery to Karma unit test dependencies.  This is not strictly
  required, since angular includes a slim jquery shim, but having the
  unit tests load the same base JS as the UI is probably best.
  Confirmed tests still pass.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
7 years agoLP#1642086: Smallest possible JQuery patch that could work...
Mike Rylander [Tue, 15 Aug 2017 16:51:16 +0000 (12:51 -0400)]
LP#1642086: Smallest possible JQuery patch that could work...

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
7 years agoThe ngToast maintainers decided to trick us with a new directory name. Thanks.
Mike Rylander [Tue, 29 Aug 2017 19:03:51 +0000 (15:03 -0400)]
The ngToast maintainers decided to trick us with a new directory name. Thanks.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoFix the "404 asset" test
Mike Rylander [Tue, 29 Aug 2017 18:42:03 +0000 (14:42 -0400)]
Fix the "404 asset" test

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoReorder the tabs and adjust the default based on logged-in-ness
Mike Rylander [Tue, 29 Aug 2017 18:15:06 +0000 (14:15 -0400)]
Reorder the tabs and adjust the default based on logged-in-ness

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoRemove confusing "session" tab from the offline menu entry -- the code will figure...
Mike Rylander [Tue, 29 Aug 2017 18:14:34 +0000 (14:14 -0400)]
Remove confusing "session" tab from the offline menu entry -- the code will figure out the correct default tab

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
7 years agoAdd moment.js to the offline asset list
Mike Rylander [Tue, 29 Aug 2017 18:13:48 +0000 (14:13 -0400)]
Add moment.js to the offline asset list

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>