update upgrade instructions for 2.4.0 release

- specify minimum supported PostgreSQL version as 9.1
- specify minimum supported OpenSRF version as 2.2.0
- update schema upgrade instructions and miscellaneous
  references to 2.3

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

revisions to installation instructions

- Remove references to PostgreSQL 9.0; 9.1 is recommended
  for Evergreen 2.4.
- Clarify that the latest version of OpenSRF now means 2.2
  or later.
- Increase chances that somebody following the instructions
  precisely doesn't run into a problem during the configure step.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make sure the "running" indicator goes away

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add a $cache_timeout-based backstop for infinite loops

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

"Queue Compression" -- let one do the work for all identical, concurrent searches

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

LP#1174359: follow-up on dropping the reporter.classic_item_list view

Add note for the benefit of any Evergreen admin who may
need to recreate that view.  Also, update the point schema
update script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1174359 Need to drop reporter.classic_item_list

ERROR: cannot drop view metabib.full_rec because other objects depend on it
DETAIL: view reporter.classic_item_list depends on view metabib.full_rec
HINT: Use DROP ... CASCADE to drop the dependent objects too.

Beginning at line 55 of the upgrade script, several views and functions are dropped
so metabib.full_rec can be dropped. One of them is missing.

We need to drop reporter.classic_item_list as well, for the script to work.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Improved AC socket fix

This provides better coverage for socket shutdown needs, but intends
to fix the same issue as the previous commit.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Shutdown added content sockets to prevent hung connections.

We were getting several thousand sockets hanging around in a
CLOSE_WAIT state on our server.  The connections were from our
server and to our server.  Further investigation showed it to be
caused by the stage2 added content lookup not closing the request
sockets when it was done reading data.  This branch fixes that.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1076411 Return updated circ object from checkin

Retrieve an updated copy of the circulation object to return to the
caller during checkin.  This ensures the data in the circ object, in
particular date fields, are consistent with the database.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

When adding errors from failed processing to acq.edi_message, set error_time

This has obvious benefits in facilitating log analysis after a problem.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add accepting_usr to IDL to fix reporter field

In the reporter interface, the view 'Payments: Brick-and-mortar' is
missing the 'Accepting User' field, which is present in the similar view
'Payments: Desk'. This field is already present in the database view and
is simply missing from the IDL.  Since it is needed for certain kinds of
reports, this commit adds the missing IDL fields. It also adds the
missing 'reporter:datatype' to an existing instance of the IDL field.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP1170861 Remove unused lineitem alert field

Remove extraneous field from the IDL field list for acq lineitem alerts.
The extra field prevented new alerts from getting saved.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP1104823 - OPAC search results "Limit to available items" toggles
off "Show more details"

Added a hidden input to the form when "Show more details" is selected
so that when the form is reloaded, "Show more details" will be still
selected.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1172893: fix query for retrieving available holds

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add 2.4 release notes for Novelist Select changes.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Adding 2.3-2.4RC upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unbreak make install for apache config files

The new install process installs the Apache sample configs into the
DOCDIR for Evergreen, with the expectation that packagers will pick up
the examples from the doc directory and that users will eventually be
expected to copy them from there, rather than from the source tree.

However, currently the Apache 2.2 and 2.4 sample configs have the same
names, and that causes a conflict at "make install" time. Kudos to Jason
Stephenson for catching this. The temporary solution is to rename the
Apache 2.4 files to avoid the conflict; longer term, we need to teach
make install to only make & install the files that are pertinent to the
environment on which it was built (either Apache 2.2, or Apache 2.4).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Updating PO files from LaunchPad

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix version number in 0793.data.best-hold-order-traditional-approx.sql

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add missing [% in prefs_settings.tt2.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1162907: install RPC::XML as Evergreen dependency

RPC::XML used to be installed as part of installing
the OpenSRF deps, but since OpenSRF itself doesn't
use it, this belongs in Evergreen.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repair too-timid hold targeter (it misses copies at other org units)

The patch to address bug 1162989 overreached.  Whereas before that
patch, the hold targeter was wont to target copies with unholdable
statuses, after the patch the hold targeter got the statuses right but
undesirably filtered out copies whose circ_lib doesn't match the hold
pickup lib.  This again probably stems from the differences between
FulfILLment's hold targeter and Evergreen's in the context of merging
the calculated proximity code.

This patch should resolve the issue.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping best-hold-order update script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix various Traditional and holds-go-home best-hold sort orders

Use copy's call number's owning_lib instead of copy's circ_lib

    Should compare checkin lib to copy's (call number's) owning_lib, not
    hold request lib.

    You might think the comparison should be to acp.circ_lib, but that
    doesn't work with floating copies (for non-floaters, acp.circ_lib
    should be equal to acp.call_number.owning_lib).

approx is a more correct first determinant to give the behavior sites
are used to.

    hprox can cause copies to be too eager to go home when
    there are holds with that copy's circ lib as its request lib (if that's
    what you want, then you do pick or create a sort-order with hprox near
    the top).

Address a problem in the copy_has_not_been_home CTE.
    This expression was always meant to provide a TRUE or FALSE value as its
    lone result, but would return NULL in cases where copies had no transit
    history.

Use pickup_lib, not request_lib, as the determinant of
    nearness-to-home.  request_lib was used with the thinking that an item's
    "owning" patrons should have their wishes favored at holds-go-home time,
    even if where they wanted to send the copy was not actually home, but
    that's neither necessarily desired nor very intuitive.

Clear up holds-go-home logic with better code AND add TechRef
documentation with diagram in attempt to be as clear as possible.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Confirm URL_VERIFY_UPDATE_SETTINGS permission code is fixed

Jeff Davis spotted, and fixed, a problem with upgrade script 0754. If
someone has already applied that, this will address.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use correct perm code in upgrade scripts for SQL update 0754

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge changes to Apache 2.4 example config files

Not only do we need the JSPAC->TPAC changes that went into the base
Apache example configs, we should also move to generating these files
instead of having hardcoded values. Longer term, we should probably just
generate the right example configs from one common base until Apache 2.2
is dead and gone, but this improves the Apache 2.4 experience greatly.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade for #deleted search modifier (and friends) fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

QP: Repair edit_date, create_date, and bib_source filters

And also make records undeletable, where reingestion at undelete time
formerly balked in this manner:

> ERROR: duplicate key value violates unique constraint
> "record_attr_pkey" DETAIL: Key (id)=(1) already exists. CONTEXT: SQL
> statement "INSERT INTO metabib.record_attr (id, attrs) VALUES (NEW.id,
> new_attrs)" PL/pgSQL function "indexing_ingest_or_delete" line 129 at
> SQL statement

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

QP: Limit to deleted records for #deleted modifier at this level

Down in the DB's query_parser_fts procedure, we also know whether we're
in a deleted_search, and in those cases we skip all visibility and
similar testing accordingly.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Bring back #deleted modifier post-revive-qp-fts

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC schema.org: Add Organization types for contributors

Given a 110 / 710 field, when generating the record details for authors
and contributors we can declare an http://schema.org/Organization
itemtype rather than just jamming the name under the "contributor"
property. This is more in accordance with schema.org directions.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: Fix schema.org name / dates for authors

Per http://schema.org/Person, the birth date and death date are not
supposed to be part of the name of a Person. We can separate these out
correctly based on subfield d for 100 fields.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix schema.org mapping for MusicAlbum, add Map

We had set LDR[06] = j to MusicRecording, but that is really meant for
individual songs. Use MusicAlbum instead, and per
http://schema.org/MusicAlbum, use a new MusicGroup itemtype with a
'byArtist' property for the primary artist rather than the generic
'accountablePerson'.

Also map LDR[06] = e to Map, because that seems like a safe bet.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for optional combined search by class

Signed-off-by: Ben Shum <bshum@biblio.org>

Allow combined search to be optional per class

Relevance is thrown off for, in paticular, the keyword class when combined
search is used.  This is because the effect of an opaque blob of data, such
as the keyword|keyword index definition, is to applify the inclusion of spurious
(to the user) data in matching attempts.

This commit adds the ability to specify, per class, whether combined FTS should
be used, and turns this on for only the subject class by default.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Acq: re-use more code for two ways of creating invoices (EDI and manual)

This solves two problems.

 1) With EDI invoices, we had been failing to disencumber fund debits
    related to the invoiced lineitems, although that worked for manual
    invoices.
 2) With manual invoices, we would not automatically uncancel copies
    when the user decided to invoice them despite their canceled status.
    This was already working in EDI invoices though.  This is especially
    important since our schema lumps "backordered" in with "canceled,"
    and in theory backordered things do show up eventually.

There were earlier version of this commit out there with bugs that
prevented the EDI workflow from working correctly (the manual invoice
flow worked and still should).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Approximate number of search results

The number of results listed on the search results page is often an
estimate when working with a large set. Let's add the word "about" to
reflect the fact that it is indeed an estimate.

At the same time, I moved the <strong> tags out of the code, adding a CSS
class in its place, moved the HTML tags out of the translatable
string (as recommended by Pasi Kallinen), and fixed a typo in the
stylesheet.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor change to chrome/content/util/list.js.

Change the initializer of this.count_for_display from 0 to 1 in
order to match the counting of other lists in the client and to
provide something that staff are likely to prefer.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Fixed bug in staff client offline mode.

https://bugs.launchpad.net/evergreen/+bug/1089657

In list.js at start you create obj.columns for lineno, but later
you don`t process this value so it`s return default render
function.  This code repairs this.

Signed-off-by: Dmitry Nechai <nechai.dmitry@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Prevent compiler warning about unused numtype var

There was a dangling variable left around that was making noise in the
compiler. Credit to Jeff Godin for the heads-up.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Address SQL injection vulnerability in SQL ORM layer

If the user-supplied value and the db column are both numbers
(jsonObject->type == JSON_NUMBER, get_primitive(field) == "number") then
don't quote. Otherwise, quote.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

2.2.7-2.2.8 database upgrade script

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.5 -> 2.3.6 SQL upgrade

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamping upgrade script for reinstate tsconfigs.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Reinstate required TEXT SEARCH CONFIGURATION data

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Address hash/list thinko; Ensure initialization

Two cascading defects were identified after being reported by users. The
first, which was only a potential issue, was an apparent lack of mod_perl
initialization for the item-age record feed.  While not the direct cause
of the error message, a lack of initialization here would manifest in the
same way.  So, we check that initialization.

Feed-generating callbacks were not being constructed properly due to a
simple thinko in the construction of the default record format list provided
by the SuperCat backend.  We need a list of two hashes, not a hash of two
keys.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

TPAC bucket item retrieval operates in streaming mode

TPAC bucket item retreive fleshes bib records with large blobs of MARC
data.  When a bucket contains a few thousand items, the size of the
data passed around in atomic retreival mode will exceed the typical jabber
max stanza size and result in a failure.  Retrieve the records in
streaming mode instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPAC: Render record titles and authors consistently

Yamil Suarez noticed that the titles and authors in the call number
browse results page were presented differently than the regular search
results. This change removes some of the hard-coded <em> tags and "bold"
classes, in favour of new "record_author" and "record_title" CSS
classes. Now sites can simply change the CSS in one place to keep things
consistent between the two search results pages.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Use inline-block for opac-multiline-button style

Follow up for LP1102934 which introduced CSS for opac-multiline-button.

The button appeared noticeably larger if using the english text for
"FAQs" on the login help button. Using inline-block for the style shrinks
it to fit more appropriately based on actual amount of text instead of
leaving it an unusually large looking button.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

TPAC Turn dashes into space in subject search links for better matching

Thanks to Dan Wells for finding a bug and fixing it for demonstration
purposes.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Add summary creation to embedded alt dist editor

In the Serial Control View, summaries are created automatically with
a new distribution. To avoid unhappy surprises, the embedded version
of the alt distribution editor should do the same.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Ignore canceled holds during alt-queue generation

When zero potential copies exist for a hold, the hold queue stats code
determines the size and shape of the queue by finding and sorting holds
that have the same type and target.  This patch forces the code to
ignore canceled holds when looking for similarly-shaped holds.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Remove a search change and add an invoicing note

With lp1161601, we lost one of the new features from the qp work. Also, we
missed one new feature with invoices.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Release Note Additions

We should probably add the removal of JSPAC to the Release Notes. Also
added the following new features that were missing from the original
notes.

- Options to hide some user preferences from TPAC
- New fields for acq distribution formulas
- Public copy notes
- Direct access to item attribute editor
- Setting staff client search preferences

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

More typo fixing

Change CVS to CSV as noticed by Remington Steed.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor edit

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Minor edits to release notes and addition of new permissions

There are some new permissions that didn't get added to the original
release notes. Also, some minor edits.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix some typos in the 2.4 release notes

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Update for 2.4 beta1 release notes

- Move more release notes into 2.4 notes.
- Move notify_csv.txt into TechRef directory.
- Include entry for Linkchecker in 2.4 notes.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial cut of 2.4 release notes.

Basically, the contents of RELEASE_NOTES_NEXT organized into
RELEASE_NOTES_2_4.txt and removed from RELEASE_NOTE_NEXT.

Move copy of alternate_graphic_fields to TechRef.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Release note template

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Updated README to reflect the future

Signed-off-by: Mike Rylander <mrylander@gmail.com>

proto-script for release note generation

Signed-off-by: Mike Rylander <mrylander@gmail.com>

release notes FS structure

Signed-off-by: Mike Rylander <mrylander@gmail.com>

stamping upgrade for field 264 reporter view

Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1071505 - Add 264 RDA tag to reporter views

Some reports draw from reporter.materialized_simple_record table and these
were not made aware of the new 264 tag which contains publisher related
information.

Change the view for reporter.old_super_simple_record, which feeds into the
other reporter table.

The included upgrade SQL will update this view and then update the table using
the new view.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Populate variable needed for batch item receive

In the integrated alt editor, we load the sub. grid differently, so
'sub' was not being populated.  Since we should only ever have one
subscription showing at a time (in this view), we can simply assign
the item to 'sub' as it is received.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Small fixes for alt sub editor integration

This commit applies some polish to the alt sub editor integration:

 - Prevent spinner from displaying continuously when adding a
   subscription
 - Hide the editor when changing subscriptions to limit confusion
   about what is loaded
 - Dynamically add a node to the tree view when adding a subscription
 - Make sure the 'View/Edit' tab gets populated when backing out of
   the stream or item view
 - Apply some default link styles

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Bash script to be used after the main 2.3-2.4 db upgrade

This script, originally offered by Thomas Berezansky and tested by others,
and augmented by me to include more parallizable SQL, will reduce the
time spent upgrading a large Evergreen 2.3 database to 2.4 by several hours.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repair an issue in search filter group UI about filtering on owner OU

What was intended to be a filter against filter groups' owner field was
instead turned into a filter on filter group ID.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

QP copy location group filter repair

Remove reference to nonexistent location group filter callback function.
Copy locations for filters are loaded inline.  No callback needed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Documentation: Add link checker documentation.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Update LP1159768 - Client: Holds Client Controls Confusing

The new string "Are you sure you want to cancel the hold(s)?"
has been added as the following variable,
staff.hold_list.cancel_hold_dialog.confirmation.

The string also needs to be translated to all supported languages.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP1159768 - Client: Holds Client Controls Confusing

The buttons were updated per Jason's suggestions to "No" and "Yes" with
a question added, "Are you sure you want to cancel the hold(s)?"

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP1159768 - Client: Holds Client Controls Confusing

Changed the language from "Cancel" to "Cancel Action" and
"Apply" to "Apply Cancellation".  These need to be translated
to other supported languages.

Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

stamping upgrade script for authority validation fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Avoid problems when auth recs are missing the 901c

Fixed the authority.normalize_heading function to better handle
INT's when there is no 901 present. Now we look for the best-fit
control set instead of throwing a db-level error.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Best hold selection: fix a checkin-busting bug affecting Holds-go-home

Several subselects within SQL auxiliary queries can possibly return
multiple rows in situations where outer code requires that they return
only one or zero rows.

When you're using a best-hold order that includes htime or shtime, (such
as those with Holds-go-home) and if there are mutiple circs or transits
related to the copy in hand with certain characteristics, you can
trigger this bug.  The end user at the staff client gets one of those
nasty "Network error" dialogs, and the error in the SQL logs is:

> ERROR:  more than one row returned by a subquery used as an expression

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix bug in hold targeter introduced with Calculated Proximity Adjustments

The Calculated Proximity Adjustments feature introduced a bug in the
hold targeter where holds would not discount those copies from the
potentials list that aren't in either the Available or Reshelving
status.

This commit should restore the earlier, correct behavior.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for revive-qp-fts (LP 1161601).

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Upgrade script to bring back the stored proc

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Revert "Remove search.query_parser_fts from schema"

This reverts commit ab9fb958e387a20cfe9fafb6035fb72bc5f1fb3f.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Revert "Remove dependence on search.query_parser_fts proc"

This reverts commit 6d8872cf120caf67ad6f65995b2c5155fa5ab652.

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP 1126545 repair staff 'return to results' tpac link

Strip the extra "/" from the URL created by the "return to results"
button in the staff client TPAC view.  Havin the extra "/" in place
prevents the next/previous links from functioning.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Allow access to public hold notes via hold "blob"

If a hold note is marked as "public", it seems reasonable that it
should be visible to anyone who can see that hold, regardless of
who created the note.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

Fix reversed logic for hold "blob" notes

Hold notes (at least at the data level) allow for both staff and
"private" notes to be attached. This code intended to show "private"
notes to the hold owner and staff notes to staff, but had the logic
reversed.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>

tpac : honor page locale in record detail copy grid

The query used to load the record detail copy grid now uses the same
locale value set as the default for all cstore-editor calls.  This
solves the issue where copy location names, statuses, etc. are not
properly translated.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for aoupa constraint fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Org unit prox adjustment tweaks

1) UI change - pre-select highest OU where user can edit

There's a dropdown in the org unit proximity adjustment interface that
affects the scope of what you can see in the table below.  Before, that
dropdown would be set to the user's home UO (say, BR1 in the example org
tree).  But you might have the permission to make changes everywhere, so
you add a proximity adjustment that affects BR3 in some way.  As soon as
you'd refresh the interface, your new proximity adjustment would not be
visible, because your scope selector would default to BR1.

So now the dropdown defaults to the first context where you have the
permission, which in all but eccentric setups should be the highest OU
(and therefore broadest scope) where you have the permission.

This could also improve other interfaces in the future.  Anything that
invokes openils.User.buildPermOrgSelector() can pass -1 as the third
parameter to get the new behavior.

2) Change UNIQUE index at DB layer.

This prevents the creation of rows that would give the hold targeter
conflicting directives.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Undo holding lib to SRE linkage (alt dist editor)

Since the legacy record dropdown piggy-backs on the OPAC display, it
doesn't work in the alt interface (which has no clear OPAC context).

Worse, this leads to a Javascript error on the first editor load for
the distribution list, preventing subsequent editors.

A better fix will require more consideration, but for now, let's
revert to the unformatted display used in 2.3.

Also, this commit removes an unnecessary conditional (it was always
true).

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

More authority fixed-field cleanup

Even with the efforts by many to add and harmonize the authority fixed-field
setup, and maintain functionality, there were some missing bits.  This commit
should take care of those by realigning the remaining field names and allwowing
those fields to be saved properly.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

MARC strip fields for Acquisitions

Added MARC strip field group selector to acquisitions upload interface
in the same manner as the group selector for non-acq Vandelay

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1160343: remove unused open-ils.circ settings

The circ_modifier and billing_types lists in the
open-ils.circ section of opensrf.xml are no longer
used.  This commit removes them from the opensrf.xml
example config.  It also removes the method
open-ils.circ.billing_type.retrieve.all, which has
not be used by any other code once in-DB billing types
were introduced.

Any external clients that used the method that was
removed should instead use
open-ils.circ.billing_type.ranged.retrieve.all.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP 1150458 DB upgrade stamping

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Changed the way authority tags were being pulled to specifically use an aggregate array.

There appears to have been a change in postgres at some point between 9.0 and 9.1
to the aggregate method. Because of this, postgres was not returning the proper
results when pulling tags for authorities. This change will force postgres to do
a proper aggregate array call and return the correct results.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

DB upgrade script for 2.2.7

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

2.3.4 -> 2.3.5 DB upgrade script

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Placeholder DB upgrade for 2.3.4

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>