Galen Charlton [Thu, 27 Apr 2023 17:57:14 +0000 (17:57 +0000)]
LP#
1997485: (follow-up) fixes to the authority suggestions updates
* Fix a long-standing issue where a stored procedure used in
search suggestion dictionary generation was not included in
baseline.
* Fix an error in direct reingest query.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 27 Apr 2023 17:54:45 +0000 (17:54 +0000)]
LP#
1997485: (follow-up) fix propagation of settings
Ensures if the search suggestions library settings have not been
set, that the attempt to copy them over to the search classes
will not display error messages.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 27 Apr 2023 17:52:10 +0000 (17:52 +0000)]
LP#
1997485: (follow-up) update release notes
* Reflect change to how authority-derived suggestions
are generated.
* Advise Evergreen administrator to review the search
class settings.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Wed, 26 Apr 2023 17:53:45 +0000 (13:53 -0400)]
LP#
1997485: Include authority headings in symspell dict
This patch adjusts the generation of search suggestions
based on authority headings by:
* Including all indexed authority headings (1XX, 4XX, and 5XX) from
authority records for author, title, and subject headings in the
search suggestion dictionary.
* As a consequence, suggestions can be based entirely on headings
found in authority 4XX and 5XX fields without those headings
also needing to be directly in at least one bibliographic record.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Thu, 12 Jan 2023 17:35:06 +0000 (12:35 -0500)]
LP#
1997485: Release notes for multi-term Did You Mean
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Fri, 31 Mar 2023 19:01:28 +0000 (15:01 -0400)]
LP#
1997485: Reify baseline schema
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Fri, 11 Nov 2022 19:39:24 +0000 (14:39 -0500)]
LP#
1997485: Multi-term Did You Mean
Expanding on the previous single-class, single-term search suggestion
development, this feature provides suggestions for single-class searches
with multiple terms.
* The Library Settings that were previously used to control the global
behavior of search suggestions have been moved to search class
configuration fields. This was done because the data in each search
class benefits from different setting values.
* If a patron's search brings back a suggestion that matches an authority
variant heading, the system will provide the main heading as a suggestion
as well, along with spelling-corrected suggestions.
* Quoated phrases in user input require strict term order and adjacency
for the phrase portion of the suggestion generated for the phrase(s),
whereas unquoted input (or the portion that is not quoted) does not.
MARC Search/Facet Class (config.metabib_class) field additions:
* variant_authority_suggestion Whether this class should attempt variant authority suggestions based on search-class/browse-axis mapping
* symspell_transfer_case Whether suggestions should retain user-supplied letter case
* symspell_skip_correct Only supply suggestions to misspelled words
* symspell_suggestion_verbosity Setting that controls the amount of effort, and therefore time, spent on suggestion generation
* max_phrase_edit_distance Maximum average per-word edit distance when evaluating suggestions
* suggestion_word_option_count Maximum alternate suggestions per word
* max_suggestions Maximum suggstions to present
* low_result_threshold Maximum hit count beyond which suggestions are not provided
* min_suggestion_use_threshold Minimum number of times a suggestion must exist in the corpus
* pg_trgm_weight Weight of the trigram similarity metric; 0 avoids calculation costs
* soundex_weight Weight of the soundex similarity metric; 0 avoids calculation costs
* keyboard_distance_weight Weight of the keyboard distance similarity metric; 0 avoids calculation costs
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 27 Apr 2023 11:28:07 +0000 (11:28 +0000)]
LP#
2000482: add a brief release notes entry
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 27 Apr 2023 11:23:04 +0000 (11:23 +0000)]
LP#
2000482: (follow-up) couple more layout tweaks
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 27 Apr 2023 10:55:52 +0000 (10:55 +0000)]
LP#
2000482: (follow-up) update Angular cheat sheet
... since `ng build --prod` no longer works.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Tue, 25 Apr 2023 13:23:30 +0000 (06:23 -0700)]
LP2000482: Get tests passing
* Update karma config
* Update Patron Barcode Validator directive due to a breaking change in rxjs single()
* Update test assertion to match new ar-JO localization
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Tue, 25 Apr 2023 13:00:11 +0000 (06:00 -0700)]
LP2000482: update tsconfig options to satisfy compiler warning
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Bill Erickson [Fri, 14 Apr 2023 16:11:01 +0000 (16:11 +0000)]
LP2000482 Bootstrap 5 continued
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Bill Erickson [Mon, 26 Dec 2022 17:06:09 +0000 (12:06 -0500)]
LP2000482 Angular 15 and Bootstrap 5 upgrade
Includes numerous markup and CSS adjustments to cope with Bootstrap 5.
This patch is a squash of patches authored by Bill Erickson
and Stephanie Leary.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 30 Mar 2023 18:11:26 +0000 (14:11 -0400)]
LP#
1791791: remove a regression regression on bug
1923225
This was introduced on the Bootstrap side by the patch for
bug
1955403.
To test:
[0] This applies to the Bootstrap OPAC skin.
[1] Perform a search on ISBN.
[2] Note that on the record page, the ISBN (under more details)
is not properly highlighted.
[3] Apply the patch and repeat step 1. This time, the ISBN
should be highlighted.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 30 Mar 2023 18:06:35 +0000 (14:06 -0400)]
LP#
1791791: prevent regression on bug
1923225
Ensures that when doing an ISBN search, the ISBN on the record
page is properly highlighted.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Garry Collum [Sun, 19 Dec 2021 01:31:22 +0000 (20:31 -0500)]
LP1791791: Google book previews not displaying from a bib linked from a search.
The javascript that queries Google Books Preview looks for ISBN(s) wrapped in
a rdetail_value class. There was a line of code in which the isbn variable
was not enclosed in this class. This patch just wraps that stray variable
into a <span> with the class.
To test:
0. Use the TPAC skin - this bug does not affect the Bootstrap skin
1. Perform a keyword search for an bib that should have a google book's link.
As of March 2023, ISBN
9780786496570 has previews enabled.
2. Go to the bib display and notice that there is no link.
3. Remove the ';query=something' text from the url and notice that the
google book information displays.
4. Apply the patch.
5. Perform the same search. The google book information should now display.
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 9 Sep 2022 16:55:22 +0000 (12:55 -0400)]
LP#
1863387: multi-select now allows filtering shelving locations by owner
The Angular multi-select component now has a special case for
shelving locations: when the IDL class of "acpl" is selected,
rather than just displaying a combobox, the item-location-select
component followed by an org selector is displayed and checkbox.
The org selector defaults to workstation OU and is used to restrict
the list of shelving locations displayed in the shelving location
combobox to the context org unit and its ancestors. If the checkbox
is also selected, descendants of the context OU are included as well.
The effect of this is to allow large consortial to more efficiently
select the shelving locations to be used by a carousel.
To test
-------
[1] Apply the patch.
[2] Create or edit carousel definitions. Verify that the widget
for the carousel's shelving locations now displays both a
combobox for the location selector as well as one for the
location owning library. Further verify that when the OU
selector for the owning library is changed, that the list
of available shelving locations reflects the locations available
at the ancestors of the filter OU. Also verify that the
"Include descendants?" checkbox updates the list of available
locations as well.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
fix
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Britta Dorsey [Wed, 26 Apr 2023 15:58:14 +0000 (11:58 -0400)]
Docs: updates to record buckets
Signed-off-by: Britta Dorsey <bdorsey@library.in.gov>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Andrea Buntz Neiman [Wed, 26 Apr 2023 15:33:49 +0000 (11:33 -0400)]
Docs: adding Angular Staff View docs for 3.11
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Galen Charlton [Wed, 19 Apr 2023 14:05:13 +0000 (10:05 -0400)]
LP#
1970946: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Mon, 9 Jan 2023 19:46:53 +0000 (13:46 -0600)]
LP1970946 Adjust color contrast in result highlights
Lowers the contrast on search result match highlights in the staff
catalog, and changes the highlight tag from <b> (PostgreSQL's default),
to <mark> (new in HTML5).
As an additional consequence, the color contrast for highlighted
search terms in the Bootstrap OPAC (using default styles) improves
from 4.38 to 17.12.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Thu, 9 Mar 2023 16:08:40 +0000 (16:08 +0000)]
LP2009865 Revised search result headings & source order
Revises the hierarchy of headings in the search results. In combination
with the H1 provided in in bug #
1994711, the result is now:
h1. Staff Catalog
h2. Search Results (N)
(repeat for each result:)
h3. [Title] [Author]
h2. Facets
(repeat for each facet box:)
h3. [Facet title]
The source order of the results list and facet sidebar have been
swapped. The facets still appear on the left visually, but now fall
after the results in the document.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Mon, 17 Apr 2023 20:24:36 +0000 (20:24 +0000)]
LP1994711 Restore <eg-title> to staff banner
Restores <eg-title> to staff-banner.component.html for pages that don't
have their titles set by any other method.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Fri, 14 Apr 2023 19:27:26 +0000 (19:27 +0000)]
LP1994711 Semantic H1 headings for page titles
Patch alters the markup within <eg-staff-banner> to include H1 headings
for page titles.
The patch also includes a new CSS file for the course page component,
which appears to be the only component taking advantage of the custom
classes and icons for page titles. I've made archived course titles gray
and italicized.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Wed, 19 Apr 2023 02:31:13 +0000 (19:31 -0700)]
LP1929593 stamp upgrade script
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jane Sandberg [Wed, 19 Apr 2023 02:26:30 +0000 (19:26 -0700)]
LP1929593 (follow-up) address make livecheck warning
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jason Etheridge [Tue, 24 Jan 2023 13:29:33 +0000 (08:29 -0500)]
LP1929593 UPDATE_COPY_BARCODE permission
This adds the permission UPDATE_COPY_BARCODE and a new API call,
open-ils.cat.update_copy_barcode
which explicitly tests for both UPDATE_COPY_BARCODE and UPDATE_COPY,
with either being sufficient for allowing a barcode change. Existing
Replace Barcode UI's in both Angular and AngularJS have been modified
to use this API call instead of the pcrud service. One side-effect of
this has been better surfacing of errors, as errors in pcrud were
uncaught and bypassing the normal error handling. This addresses
LP1951469.
The upgrade script gives any permission groups that already have the
UPDATE_COPY permission the new UPDATE_COPY_BARCODE permission at the
same depth, though it's technically not needed.
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Jeff Davis [Tue, 15 Nov 2022 23:11:49 +0000 (15:11 -0800)]
LP#
1996651: treat empty string as null for preferred name/alias in wide_hold_data
This prevents the patron name from appearing blank in the hold shelf
"User Display Name" or "User Alias or Display Name" columns when the
alias or preferred name fields are empty strings.
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Stephanie Leary [Fri, 14 Apr 2023 21:28:15 +0000 (21:28 +0000)]
LP2016337 Refresh grids in booking return tabs
Loads missing tab contents in booking return by patron screens.
Co-authored-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Stephanie Leary [Fri, 14 Apr 2023 21:43:02 +0000 (21:43 +0000)]
LP2016341 Fix duplicate ID in staff catalog record
Gives the actions button area a different ID than the navigation.
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Garry Collum [Fri, 13 Aug 2021 17:41:02 +0000 (13:41 -0400)]
LP1889916 SMS Carrier does not include region in borrower edit screen
Displays the region next to the carrier name and in the borrower edit and
create screens. Also sorts the carrier names alphabetically.
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Tue, 4 Apr 2023 15:10:21 +0000 (11:10 -0400)]
LP#
1716479: (follow-up) fix handling of onSave callbacks for AngularJS MARC edit
This patch fixes an issue that has been present for a while but
clarified by Beth Wills in the course of testing the base patch
for this bug.
Specifically, the routine to process onSave callbacks was
not bound to the scope properly, meaning that the wrong onSave
callbacks could be run when dealing with mutiple active
egMarcEditRecords.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Thu, 29 Aug 2019 01:09:35 +0000 (18:09 -0700)]
LP1716479: Make sure authority linker works in embedded MARC editors
1) Perform a z39.50 search
2) Select a record
3) Click Edit then Import
4) Click on the link next to any authorizable field.
5) You will see a mysteriously data-free heading: {{bibField.tag}} {{bibField.ind1}}{{bibField.ind2}}
6) Clicking on the "Immediately" and "Create and edit" buttons doesn't work.
7) Apply this patch and repeat steps 1-6.
8) Note that the heading is now correct, and the buttons work.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Mon, 3 Apr 2023 16:40:46 +0000 (12:40 -0400)]
Docs: More README Cleanup
Fix "Installing PostgreSQL server packages" heading. It was showing
up as a list entry.
Drop the text about installing additional packages for the database,
since there are none to install at this time. (We could replace that
with a subsection on the packages required for a standalong databse
server without all of Evergreen installed on it.)
Add a "Create the Evergreen PostgreSQL user" heading above the
instructions to creat the evergreen user in the database.
Co-authored-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Jason Stephenson [Mon, 3 Apr 2023 15:52:08 +0000 (11:52 -0400)]
Docs: Remove extraneous blank line from README introduced by LP1947728
When processing the README with asciidoc the following message appears:
asciidoc: WARNING: README: line 82: list item index: expected 1 got 3
This is caused by a blank line on line 74 introduced in the
removal of the Debian Stretch prerequisites.
Co-authored-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Galen Charlton [Fri, 31 Mar 2023 18:01:02 +0000 (14:01 -0400)]
docs: (follow-up) tweak OpenAthens doc
- fix a warning for a NOTE block
- link to the navigation
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
spmorrison [Thu, 16 Mar 2023 17:35:42 +0000 (13:35 -0400)]
Add files via upload
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
spmorrison [Thu, 16 Mar 2023 17:31:28 +0000 (13:31 -0400)]
Docs: Configuring sign-on to OpenAthens
Adding new page for OpenAthens configuration. Used documentation from 3.10 release notes, with the addition of a couple screenshots.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Fri, 10 Feb 2023 15:06:03 +0000 (10:06 -0500)]
LP1970476: Restore Localization Function Wrapper
The previous commit removed the l() function wrapper from two bits of
text when it probably should not have. This commiet restores it.
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Terran McCanna [Wed, 19 Oct 2022 14:54:19 +0000 (10:54 -0400)]
LP1970476 Where filter in Bootstrap Catalog Produces Unwanted Results
Prior to this change, the Advanced Search page split the library selector
and the "Where" scope selector into two separate dropdown lists that
produced unexpected results when both were used.
This change uses the same approach as the combined dropdown on the Basic
search page instead.
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Thu, 14 Apr 2022 15:51:30 +0000 (11:51 -0400)]
LP1965797: Add Acq Lineitem Detail Audit Table
Add SQL to create an audit table for acq.lineitem_detail in the base
schema creation.
The table is not added during a database upgrade. The release notes
include instructions on creating the new table.
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 31 Mar 2023 14:10:55 +0000 (10:10 -0400)]
LP#
1981774: (follow-up) fix a straggling "opac-button"
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jeff Davis [Fri, 15 Jul 2022 22:28:24 +0000 (15:28 -0700)]
LP#
1981774: use Bootstrap CSS classes for buttons instead of opac-button
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jeff Davis [Fri, 15 Jul 2022 22:32:28 +0000 (15:32 -0700)]
LP#
1981774: fix button CSS on curbside in Bootstrap OPAC
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 31 Mar 2023 13:43:53 +0000 (09:43 -0400)]
LP#
1752334: (follow-up) adjust to allow "0" as a note
Also ignore the additional note parameter if all it has
are zero or more whitespace characters.
It's unlikely that a client would want to set the additional
note to "0", but it's nonetheless a good idea to distinguish
between difference versions of Perl's false value.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Josh Stompro [Thu, 28 Feb 2019 16:41:01 +0000 (10:41 -0600)]
LP#
1752334 - BadContact, use additional note if provided.
If an additional note is provided when marking a contact invalid,
then that note should be appended to the penalty note field.
This change adds that functionality. This doesn't change the results
for staff that are using the invalidate buttons in the client, since
there isn't a chance to add an additional note from that interface.
But if someone is calling open-ils.actor.invalidate.email via some other
method, then you can specify the additional note.
I would like to be able to add extra notes when automatically processing
bounced emails, to give staff a clue as to why the email failed. Such as
"<email> Account over quota for past 3 weeks, ask patron to check their account."
Includes a new perl live test to check the new behavior, along with all
the open-ils.actor.invalidate.* call options.
Testing plan:
Before fix.
1. Choose a patron with an email address and note their patron id number.
2. Run an srfsh shell.
3. Login to get an auth token 'login username password'
4. Run the invalidate email command to mark the users email invalid, including
an addition note value.
srfsh# request open-ils.actor open-ils.actor.invalidate.email "<authtoken>" "<patronid>" "Testing Additional Note"
5. Take a look at the patron account and see that the penalty message only
includes a copy of the email address that was marked invalid.
After fix.
1. Restart the opensrf actor service if needed to re-read the changed perl module.
osrf_control -l --service open-ils.actor --restart
2. Remove the penalty and re-add email address to test patron's account.
3. Run an srfsh shell.
4. Login to get an auth token 'login username password'
5. Run the invalidate email command to mark the users email invalid,
including an addition note value.
srfsh# request open-ils.actor open-ils.actor.invalidate.email "<authtoken>" "<patronid>" "Testing Additional Note"
6. Take a look at the patron account and see that the penalty message note
now includes the additional note.
Run the live test at Evergreen/Open-ILS/src/perlmods/live_t
perl ./36-lp1752334-badcontact.t
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jane Sandberg [Thu, 21 Jul 2022 00:00:24 +0000 (20:00 -0400)]
LP1879517: Surveys shouldn't end before they begin
To test:
1. Go to Admin > Local > Surveys.
2. Create a new survey.
3. Attempt to create a survey where the end date
comes before the start date. Without this patch, you will get
no notice that this is invalid, and you can save the invalid
record.
4. Edit an existing survey.
5. Repeat step 3 while editing the existing survey.
6. Apply the patch.
7. Repeat steps 1-5. Note that you now get a notice and
cannot save if the end date is before the start date.
This commit generalizes a validator already present in the booking
module, and corrects several small bugs related to the datetime-select
component.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Galen Charlton [Thu, 30 Mar 2023 14:15:24 +0000 (10:15 -0400)]
LP#
1990968: add release notes
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Thu, 1 Dec 2022 16:00:38 +0000 (11:00 -0500)]
LP1990968: Move Strict Barcode Checkbox in Angular Staff Client
Move the Strict Barcode Checkbox to the right of the barcode input
from the bottom of the page for the Checkout, Checkin, and Renew
interfaces.
This change differs from that for AngularJS as the latter moves the
checkbox to below the barcode input.
Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
Signed-off-by: Elizabeth Thomsen <et@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Scott Angel [Wed, 30 Nov 2022 15:20:43 +0000 (09:20 -0600)]
LP#
1990968: Move strict barcode checkbox
Moved the 'Strict Barcode' checkbox next to the item barcode input box
for a more streamlined and workflow page layout. This affected three
Evergreen interfaces: Patron checkout, Item Renew, Item Checkin
Signed-off-by: Scott Angel <scottangel@mobiusconsortium.org>
Signed-off-by: Jason Stephenson <jstephenson@cwmars.org>
Signed-off-by: Elizabeth Thomsen <et@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Wed, 29 Mar 2023 15:44:37 +0000 (11:44 -0400)]
LP#
2007073: add release notes
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Wed, 29 Mar 2023 15:33:38 +0000 (11:33 -0400)]
LP#
2007073: stamp DB update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Dan Briem [Fri, 17 Feb 2023 17:36:15 +0000 (12:36 -0500)]
LP#
2007073 Staff Should Only Select Manual Hold Cancel Causes
Adds a field to action.hold_request_cancel_cause to indicate
if they are manual cancel causes.
Filters on this field in cancel hold dialogs to only display
manual cancel causes.
Adds two new cancel causes, Patron via email and Patron via SMS.
Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
blake [Tue, 15 Mar 2022 16:48:12 +0000 (11:48 -0500)]
LP#
1964986: encourage distinct results when querying the ahopl IDL source
This patch addresses a now-theoretical issue where a direct PCRUD
query of ahopl could return duplicate rows in cases where the patron
linked to the hold request has multiple penalties attached.
The significance of this change is likely minor nowadays, as ahopl
was directly used by Evergreen only by the Dojo and AngularJS hold
pull lists, and as of 3.8 the Evergreen Angular pull list uses a
different approach for querying the pull list. However, until such
time as ahopl is deprecated and removed, this change may help
local integrations.
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Gina Monti [Tue, 22 Nov 2022 19:16:19 +0000 (14:16 -0500)]
LP#
19801356 Making 'username' consistent in the OPAC
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Galen Charlton [Tue, 28 Mar 2023 14:52:06 +0000 (10:52 -0400)]
LP#
1959010: (follow-up) break up long lines in release notes
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Etheridge [Wed, 4 Jan 2023 13:59:47 +0000 (08:59 -0500)]
lp1959010 release notes
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Wed, 23 Nov 2022 16:41:16 +0000 (11:41 -0500)]
lp1959010 have the staff display component check search context for the active search OU
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Etheridge [Thu, 10 Nov 2022 21:01:23 +0000 (16:01 -0500)]
lp1959010 toward Staff View tab
* link searches for listed genres
* s/Abstract:/Summary:/
* link to View all Formats and Editions
* remove border from staff view
* tweaking what goes where
* add metabib record count next to View all Formats and Editions link
* remove links for what boils down to marc 508 and 511
* made the count off-by-one trying to not make it off-by-one :)
* remove the creator field
* keep just Subject:
* remove the Record is or is not holdable information as it doesn't present the whole truth
* refresh interface on tab change
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Stephanie Leary [Wed, 9 Nov 2022 21:01:43 +0000 (15:01 -0600)]
lp1959010 CSS and layout tweaks
* More layout and CSS tweaking
* list style fix
* left margin fix
* UL margin fix
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Etheridge [Mon, 3 Oct 2022 04:12:02 +0000 (00:12 -0400)]
lp1959010 toward Staff View tab
* make our Staff View tab with the new BibStaffView widget
* seed our BibStaffView with BibSummary
* first attempt at changing some identifiers with our seed code
* experimenting with layout and stripping courses functionality
* simplifying the layout for now and adding display fields
* moar data
* layout tweaks and propagate metabib attributes for Formats and Editions
* don't cross the streams with metabib related
* field names for the record and metabib variants of the catalog_summary call. This would otherwise break some links in search results involving bibs with metarecords.
* hyperlinks for the formats and editions in the catalog staff view
* fix catalog_summary vs catalog_summary.staff bug
* searchOrg depth was being passed where a boolean was expected
* This seems like a failure of TypeScript to detect.. type. What was going on here?
* layout and css tweaking
* fixing toc and relocating it and some other fields to column 1
* label fix
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 19:53:31 +0000 (15:53 -0400)]
LP#
1972738: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 19:52:18 +0000 (15:52 -0400)]
LP#
1972738: add an ANALYZE after the index gets created
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jason Stephenson [Tue, 10 May 2022 15:07:25 +0000 (11:07 -0400)]
LP1972738: Add index on hopeless date
Add an index on action.hold_request hopeless_date column to speed up
hopeless holds processing.
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Chris Sharp [Wed, 8 Mar 2023 16:25:01 +0000 (11:25 -0500)]
LP#
1369345: de-duplicate ILS events and clean up whitespace
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 15:51:37 +0000 (11:51 -0400)]
remove release notes entries made moot by security point releases
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 15:46:58 +0000 (11:46 -0400)]
forward-port 3.10 upgrade scripts
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 15:46:18 +0000 (11:46 -0400)]
forward-port version upgrade scripts
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Mon, 27 Mar 2023 15:43:49 +0000 (11:43 -0400)]
fix title of the 3.10 release notes document
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Michele Morgan [Fri, 24 Mar 2023 17:01:35 +0000 (13:01 -0400)]
Docs: 3.10.1 release notes - edited
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Michele Morgan [Fri, 24 Mar 2023 17:00:00 +0000 (13:00 -0400)]
Docs: 3.9.2 release notes - edited
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 24 Mar 2023 17:42:39 +0000 (13:42 -0400)]
update 3.8.3 release notes to include security fix information
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 24 Mar 2023 17:41:24 +0000 (13:41 -0400)]
update 3.9.2 release notes to include security fix information
Also fixes a typo
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Fri, 24 Mar 2023 17:39:53 +0000 (13:39 -0400)]
update 3.10.1 release notes to include security fix
Also fixes a typo.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Andrea Buntz Neiman [Thu, 23 Mar 2023 22:38:13 +0000 (18:38 -0400)]
Docs: 3.10.1 release notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Andrea Buntz Neiman [Thu, 23 Mar 2023 21:18:12 +0000 (17:18 -0400)]
Docs: 3.9.2 release notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Andrea Buntz Neiman [Thu, 23 Mar 2023 19:11:35 +0000 (15:11 -0400)]
Docs: 3.8.3 release notes
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 23 Mar 2023 21:22:54 +0000 (17:22 -0400)]
LP#
1361782: (follow-up) fix the default search limit in seed data
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Galen Charlton [Thu, 23 Mar 2023 19:11:49 +0000 (15:11 -0400)]
LP#
1361782: stamp DB update
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Tue, 21 Feb 2023 20:36:46 +0000 (15:36 -0500)]
DoS protection release notes
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Tue, 22 Nov 2022 21:38:03 +0000 (16:38 -0500)]
LP#
1361782: Add DoS protection
This commit adds two types of simple DoS protection:
* Limit concurrent search requests per client IP address, regardless of
the searches being performed. This helps address issues of accidental
spamming from a malfunctioning OPAC workstation, or crawlers of various
types. The limit is controlled by a global flag called
"opac.max_concurrent_search.ip".
* Limit the global concurrent search requests for the same query. This
helps address both simple and distributed DoS that send the same search
request over and over. The limit is controlled by a global flag called
"opac.max_concurrent_search.query", and defaults to 20.
When the limit is exceeded in either case the client receives an HTTP
429 "Too many requests" response from the web server, and the connection
is ended.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Tue, 21 Feb 2023 21:53:53 +0000 (16:53 -0500)]
qtype CGI param protection release notes
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Mike Rylander [Thu, 17 Nov 2022 22:11:38 +0000 (17:11 -0500)]
LP#
1811685: qtype CGI parameter checking
With this commit we throw away searches with invalid qtype value based
on configured classes and aliases. Invalid qtype values have been seen
in the wild as part of attempted (but failed) SQL injection attacks, so
we will tighten up what we accept.
As an additional (unrelated) bonus, this commit also avoids prepending
the search class on basic search when the class (from qytpe) is not
exactly "keyword".
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Jessica Woolford [Fri, 9 Dec 2022 15:54:43 +0000 (10:54 -0500)]
LP #
1965447: adjust scoping of item tags Angular Holdings Editor
Scopes to the org unit and ancestors of the signed-in
user's workstation when adding a new item tag.
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Josh Stompro [Fri, 17 Mar 2023 19:14:43 +0000 (14:14 -0500)]
LP#
2012105 - Comment typo in AddedContent.pm
Small tiny comment typo HTPP istead of HTTP
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Michele Morgan [Fri, 17 Mar 2023 13:06:31 +0000 (09:06 -0400)]
LP#
2002435 release note
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Fri, 3 Feb 2023 00:15:32 +0000 (16:15 -0800)]
LP2002435: Add optional undelete action to basic admin page
By default, this undelete action is only enabled on the shelving
location editor.
Also, only show admin page delete button if everything
selected is deleteable
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Jane Sandberg [Wed, 11 Jan 2023 03:17:18 +0000 (19:17 -0800)]
LP2002435: Don't allow shelving location fm-editor to change delete flag
To test:
1. Go to the Local Admin > Shelving Locations Editor screen
2. Select a location and edit it.
3. Note that with this patch in place, the Delete checkbox
is no longer editable.
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
spmorrison [Wed, 8 Mar 2023 19:59:21 +0000 (14:59 -0500)]
Docs: Update describing_your_organization.adoc
Updated the Create and edit Organization Unit Types section as well as the Organization Units sections to update text and add screenshots. Also added instructions for hours of operation notes (released in 3.10).
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Gina Monti [Tue, 14 Feb 2023 15:49:32 +0000 (10:49 -0500)]
Updating best practices for web browser to include turning off Google Translate
For the DIG revamp project. No LP.
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Andrea Buntz Neiman [Wed, 8 Mar 2023 21:33:42 +0000 (16:33 -0500)]
Docs: removing XUL reference from web staff client intro page
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Jane Sandberg [Tue, 20 Sep 2022 13:40:03 +0000 (06:40 -0700)]
Docs: LP1863921 max-old-space-size param when building angular
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Jason Boyer [Sun, 5 Mar 2023 21:38:53 +0000 (16:38 -0500)]
Sync upgrade_log
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Jason Boyer [Sun, 5 Mar 2023 21:17:49 +0000 (16:17 -0500)]
LP1441750: Stamp Upgrade Script
Also update unapi.mmr and actor.usr_merge to account for drift.
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Jason Stephenson [Fri, 8 Mar 2019 14:30:41 +0000 (09:30 -0500)]
LP#
1441750: use string_agg (again and again)
Update the upgrade/fix for name keyword moving in the actor.usr_merge
function.
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Ben Shum [Wed, 2 May 2018 22:31:08 +0000 (17:31 -0500)]
LP#
1441750: use string_agg (again)
Some older style ARRAY_TO_STRING(ARRAY_AGG()) should be replaced to
use the native STRING_AGG() that comes with PG 9+. This should improve
performance for these functions.
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Mike Rylander [Thu, 1 Dec 2022 19:41:34 +0000 (14:41 -0500)]
LP#
1996908: Expand support for eg.auth.token to other legacy mod_perl handlers (but not the OPAC)
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Galen Charlton [Thu, 17 Nov 2022 15:09:39 +0000 (10:09 -0500)]
LP#
1996908: allow OpenILS::WWW::Proxy::Authen to check eg.auth.token
This patch allows the authentication handler to accept the
'eg.auth.token' cookie coming from the staff client if a 'ses' parameter
or 'ses' cookie has not been set. This allows resources gated by
this handler to be accessed by a staff member who has logged
into the staff client without requiring an additional login.
To test
-------
[1] Create a report and note the URL of one of its
outputs.
[2] In a completely fresh browser session, log into the
staff client, then directly load the reporter output.
You will be prompted to log in again because the 'ses'
cookie was not set.
[3] Apply the patch and repeat step 2. This time, the reporter
output should be directly retrieved.
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Mike Risher [Tue, 12 Jan 2021 20:46:55 +0000 (20:46 +0000)]
LP1625192 Filtering Grid refreshes to 1st Page
Modify the old DOJO grid so that when you filter the grid it resets
to the first page.
Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
projects / Evergreen.git / log