working/Evergreen.git
3 years agoLP1904036 events and overrides
Bill Erickson [Mon, 1 Mar 2021 17:19:45 +0000 (12:19 -0500)]
LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Renew with due date
Bill Erickson [Mon, 1 Mar 2021 16:19:07 +0000 (11:19 -0500)]
LP1904036 Renew with due date

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Renew all; initial events override dialog
Bill Erickson [Fri, 26 Feb 2021 23:17:06 +0000 (18:17 -0500)]
LP1904036 Renew all; initial events override dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Renew; Batch Checkout/Renew; shared circ components
Bill Erickson [Fri, 26 Feb 2021 22:04:40 +0000 (17:04 -0500)]
LP1904036 Renew; Batch Checkout/Renew; shared circ components

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Claims never checked out
Bill Erickson [Fri, 26 Feb 2021 21:16:07 +0000 (16:16 -0500)]
LP1904036 Claims never checked out

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Claims returned
Bill Erickson [Fri, 26 Feb 2021 20:59:34 +0000 (15:59 -0500)]
LP1904036 Claims returned

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Claims returned; circ notices
Bill Erickson [Fri, 26 Feb 2021 16:53:11 +0000 (11:53 -0500)]
LP1904036 Claims returned; circ notices

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron alerts page continued
Bill Erickson [Thu, 25 Feb 2021 22:59:58 +0000 (17:59 -0500)]
LP1904036 Patron alerts page continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron alerts page; resolver service
Bill Erickson [Thu, 25 Feb 2021 22:26:08 +0000 (17:26 -0500)]
LP1904036 Patron alerts page; resolver service

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Move precat dialog to shared circ service
Bill Erickson [Thu, 25 Feb 2021 17:32:42 +0000 (12:32 -0500)]
LP1904036 Move precat dialog to shared circ service

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron noncat count display
Bill Erickson [Thu, 25 Feb 2021 17:24:54 +0000 (12:24 -0500)]
LP1904036 Patron noncat count display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Mark items lost
Bill Erickson [Thu, 25 Feb 2021 17:10:56 +0000 (12:10 -0500)]
LP1904036 Mark items lost

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Mark missing; initial checkin api
Bill Erickson [Tue, 23 Feb 2021 23:10:10 +0000 (18:10 -0500)]
LP1904036 Mark missing; initial checkin api

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Mark damaged; canceled holds display repair
Bill Erickson [Tue, 23 Feb 2021 21:24:24 +0000 (16:24 -0500)]
LP1904036 Mark damaged; canceled holds display repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Edit due date; styling overdues
Bill Erickson [Tue, 23 Feb 2021 16:54:28 +0000 (11:54 -0500)]
LP1904036 Edit due date; styling overdues

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron items out: printing
Bill Erickson [Mon, 22 Feb 2021 22:53:41 +0000 (17:53 -0500)]
LP1904036 Patron items out: printing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron items out grid; shared circ grid; noncats
Bill Erickson [Mon, 22 Feb 2021 21:19:54 +0000 (16:19 -0500)]
LP1904036 Patron items out grid; shared circ grid; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Noncat batch retrieval API
Bill Erickson [Mon, 22 Feb 2021 21:19:41 +0000 (16:19 -0500)]
LP1904036 Noncat batch retrieval API

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron items out grid; shared circ grid
Bill Erickson [Fri, 19 Feb 2021 21:21:07 +0000 (16:21 -0500)]
LP1904036 Patron items out grid; shared circ grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Angular login now handles routeTo
Bill Erickson [Thu, 18 Feb 2021 17:05:37 +0000 (12:05 -0500)]
LP1904036 Angular login now handles routeTo

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Barcode completion continued
Bill Erickson [Thu, 18 Feb 2021 16:18:40 +0000 (11:18 -0500)]
LP1904036 Barcode completion continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Barcode completion dialog
Bill Erickson [Wed, 17 Feb 2021 21:26:57 +0000 (16:26 -0500)]
LP1904036 Barcode completion dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 checkout continued; grid actions
Bill Erickson [Tue, 16 Feb 2021 18:52:14 +0000 (13:52 -0500)]
LP1904036 checkout continued; grid actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 precat checkouts
Bill Erickson [Mon, 8 Feb 2021 21:41:55 +0000 (16:41 -0500)]
LP1904036 precat checkouts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 precat dialog
Bill Erickson [Mon, 8 Feb 2021 18:15:08 +0000 (13:15 -0500)]
LP1904036 precat dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Prompt dialog focus input followup
Bill Erickson [Mon, 8 Feb 2021 15:12:52 +0000 (10:12 -0500)]
LP1904036 Prompt dialog focus input followup

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Prompt dialog focus input; submit on enter
Bill Erickson [Sun, 7 Feb 2021 19:20:40 +0000 (14:20 -0500)]
LP1904036 Prompt dialog focus input; submit on enter

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron ui checkout tab
Bill Erickson [Fri, 5 Feb 2021 22:57:42 +0000 (17:57 -0500)]
LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron ui checkout tab
Bill Erickson [Fri, 5 Feb 2021 21:44:55 +0000 (16:44 -0500)]
LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron ui checkout tab
Bill Erickson [Fri, 5 Feb 2021 21:26:03 +0000 (16:26 -0500)]
LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron ui checkout tab; noncats
Bill Erickson [Fri, 5 Feb 2021 19:58:55 +0000 (14:58 -0500)]
LP1904036 Patron ui checkout tab; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Prompt dialog gets input type and min/max
Bill Erickson [Fri, 5 Feb 2021 19:58:33 +0000 (14:58 -0500)]
LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron UI lint repairs; sanity checks
Bill Erickson [Thu, 12 Nov 2020 16:36:52 +0000 (11:36 -0500)]
LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron UI; search persistence
Bill Erickson [Fri, 28 Aug 2020 14:41:44 +0000 (10:41 -0400)]
LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron UI; canceled holds
Bill Erickson [Wed, 26 Aug 2020 14:40:48 +0000 (10:40 -0400)]
LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 patron Ui holds tabs
Bill Erickson [Fri, 21 Aug 2020 21:53:58 +0000 (17:53 -0400)]
LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 patron UI noncat/holds summary
Bill Erickson [Fri, 21 Aug 2020 21:02:10 +0000 (17:02 -0400)]
LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 patron expire check
Bill Erickson [Tue, 18 Aug 2020 14:48:12 +0000 (10:48 -0400)]
LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Angular Patron UI initial structures
Bill Erickson [Wed, 12 Aug 2020 16:50:59 +0000 (12:50 -0400)]
LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Grid rowSelectionChange Output
Bill Erickson [Thu, 13 Aug 2020 15:44:34 +0000 (11:44 -0400)]
LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron search form improvements
Bill Erickson [Wed, 12 Aug 2020 22:18:07 +0000 (18:18 -0400)]
LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1904036 Patron sesarch form improvements
Bill Erickson [Wed, 12 Aug 2020 16:50:48 +0000 (12:50 -0400)]
LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1958573 PMC messages created by action triggers not patron-visible
Terran McCanna [Thu, 20 Jan 2022 19:42:33 +0000 (14:42 -0500)]
LP1958573 PMC messages created by action triggers not patron-visible

This adds a missing patron-visibility flag to messages created for
the patron message center by notification action triggers (when
using grouped events).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoStaff banner added to the staff portal local administration page.
Shula Link [Mon, 27 Jun 2022 13:26:38 +0000 (09:26 -0400)]
Staff banner added to the staff portal local administration page.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1956790 Support applying item alerts via templates
Bill Erickson [Fri, 8 Jul 2022 15:17:51 +0000 (11:17 -0400)]
LP1956790 Support applying item alerts via templates

Fixes an issue where item alerts contained within copy templates failed
to apply when using the new Angular holdings editor.

Testing note: if you add an item alert by applying a template, it currently
will not be displayed in the item alerts dialog until you save the item.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: add release notes entry
Galen Charlton [Tue, 12 Jul 2022 13:38:21 +0000 (09:38 -0400)]
LP#1980257: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: (follow-up) add balance owed to the pending grid as well
Galen Charlton [Tue, 12 Jul 2022 13:36:13 +0000 (09:36 -0400)]
LP#1980257: (follow-up) add balance owed to the pending grid as well

Doing this maintains symmetry between the user bucket grid
and the pending user grid and supports workflows where a staff
member may wish to check the patron balance before adding a
user to a bucket.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1980257: Patron bucket money summary
Bill Erickson [Wed, 29 Jun 2022 18:44:12 +0000 (14:44 -0400)]
LP#1980257: Patron bucket money summary

This patch adds the patron's balance owed as a column
in the user bucket grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1975879 Holdings editor allows owning lib changed user/gmcharlt/lp1975879_signoff
Bill Erickson [Fri, 8 Jul 2022 20:19:44 +0000 (16:19 -0400)]
LP1975879 Holdings editor allows owning lib changed

A new edit (pencil) icon appears to the left of the first call number
field in the 'holdings' tab of the copy edit.  When clicked, the user has
a chance to enter a new org unit value to act as the owning lib of the
affected call number.

If the "Change Circ Lib When Owning Lib Changes" preference is set, then
any copies linked to the affected call number within the current edit
session will have their circ libs updated to match the new owning lib of
the call number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1981095: fix deletion of item tags in Angular item attributes editor
Galen Charlton [Fri, 8 Jul 2022 16:46:40 +0000 (12:46 -0400)]
LP#1981095: fix deletion of item tags in Angular item attributes editor

This patch fixes several bugs that prevent item tags from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that tags can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Tags for a single
    selected item.
[5] Verify that tags can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item tag. Verify that tags can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Tags for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1959716 Follow up to allow managing/deleting in-place copies
Bill Erickson [Fri, 8 Jul 2022 20:43:42 +0000 (16:43 -0400)]
LP1959716 Follow up to allow managing/deleting in-place copies

Fixes a thinko which prevented management / deletion of existing copies
in the copy editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1955065 Item note dialog close value repairs
Bill Erickson [Fri, 8 Jul 2022 19:10:51 +0000 (15:10 -0400)]
LP1955065 Item note dialog close value repairs

Handle cases where the copy note dialog is closed via Cancel actions and
emits no data.

Also be sure the dialog emits consistently shaped data when it does emit
data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1955065: fix deletion of item notes in Angular item attributes editor
Galen Charlton [Fri, 8 Jul 2022 16:03:35 +0000 (12:03 -0400)]
LP#1955065: fix deletion of item notes in Angular item attributes editor

This patch fixes several bugs that prevent item notes from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that notes can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Notes for a single
    selected item.
[5] Verify that notes can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item note. Verify that notes can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Notes for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1965448 Holdings edit enforce required stat cats
Bill Erickson [Thu, 7 Jul 2022 20:28:36 +0000 (16:28 -0400)]
LP1965448 Holdings edit enforce required stat cats

Required copy stat cats require a value when creating or editing
copies.

Switching between tabs in the copy editor no longer alert the user when
a change is pending, since it may be necessary to hop between tabs to
resolve issues.  Pending changes alerts will still appear when leaving
the page if needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1959716: (follow-up) extend fix to item tags
Galen Charlton [Fri, 8 Jul 2022 17:04:55 +0000 (13:04 -0400)]
LP#1959716: (follow-up) extend fix to item tags

To test this patch series:

[1] Set the Angular holdings and item attributes editor to
    unified mode.
[2] Create a new call number and item. Note that the buttons
    to create item tags, item alerts, and item notes do not work.
[3] Apply the patch and repeat step 2.
[4] This time, adding tags, alerts, and notes in the course of
    creating a new item should work.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1959716 Volcopy Add Notes/Alert to New Copies
Bill Erickson [Fri, 8 Jul 2022 14:16:17 +0000 (10:16 -0400)]
LP1959716 Volcopy Add Notes/Alert to New Copies

Fixes an issue where creating new copy alerts / notes failed for brand
new copies.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1976557: (follow-up) fix lint
Galen Charlton [Fri, 8 Jul 2022 15:15:16 +0000 (11:15 -0400)]
LP1976557: (follow-up) fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1976557: No Holdings View For the Pre-cat Bib
Jason Boyer [Wed, 1 Jun 2022 20:30:01 +0000 (16:30 -0400)]
LP1976557: No Holdings View For the Pre-cat Bib

Don't waste the time or resources to load every pre-cat in the system when
there isn't much you can do with them anyway.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP#1978839 Holds Pull List - Library Shortnames
Dan Briem [Fri, 17 Jun 2022 14:19:59 +0000 (10:19 -0400)]
LP#1978839 Holds Pull List - Library Shortnames

Display shortnames instead of IDs for the Requesting Library
and Selection Library columns in the Pull List grid in the
staff client.

Test:
1. Circulation->Pull List for Hold Requests
2. Select OU with holds to pull or place an item hold on an
   available item and select the owning OU
3. Add the Requesting Library and Selection Library columns
   (note IDs are displayed)
5. Apply patch, rebuild Angular, rebuild Perl
6. Refresh and re-add columns (note shortnames are displayed)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agolp1978049: add ng lint to github actions
Jane Sandberg [Thu, 9 Jun 2022 03:56:33 +0000 (20:56 -0700)]
lp1978049: add ng lint to github actions

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1951642 Self-registration DOB autopopulating date
Garry Collum [Tue, 28 Jun 2022 11:59:21 +0000 (11:59 +0000)]
LP1951642 Self-registration DOB autopopulating date

This removes the autopopulation of the dob date in the OPAC's
self-registration page. Note that the issue applies only to
the Bootstrap OPAC, not TPAC.

To test:

1. In library settings turn on "Allow Patron Self-Registration" and "Show dob
field in patron registration". "Require dob field on patron registration"
can also be turned on to test that option.

2. Go to the "Request Library Card" page of the opac and notice that the
dob field is populated with today's date.

3. Apply the patch.

4. Check the dob field again and notice that it is no longer autopopulated.

5. Create a few registrations with dob dates and with no dob dates to confirm
that the field works.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1950166 TPac: Self-registration form won't submit with blank DOB
Garry Collum [Tue, 9 Nov 2021 16:09:48 +0000 (11:09 -0500)]
LP1950166 TPac: Self-registration form won't submit with blank DOB

Adds a check for a blank value in the DOB validation script. Note
that the issue is present in TPAC, not the Bootsstrap OPAC.

To test:
1. Confirm "Require dob field on patron registration" is not set or set to False.
2. Confirm "Show dob field on patron registration" is true.
3. Confirm "Allow Patron Self-Registration" is set to true.
4. Try to register a patron in the TPAC with DOB blank.
5. Apply patch.
6. Try to register a patron in the TPAC with the DOB blank.
7. Try to register a patron with Invalid DOB input.
8. Try to register a patron with valid DOB input.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1950514: TPac hold groups table displays incorrect column names on small screens.
Garry Collum [Wed, 10 Nov 2021 19:44:16 +0000 (14:44 -0500)]
LP1950514: TPac hold groups table displays incorrect column names on small screens.

This fixes the incorrect display of column names in the hold groups table
in the tpac. Previously the table would display names for the hold history
table.

To test:
1. create an opac visible hold group and assign a patron to the group.
2. login to the TPac as the patron assigned to the group.
3. view hold groups and make the browser screen as small as possible.
4. notice on the smallest screen the headers for the table are incorrect.
5. apply the patch and view the headers.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942647: (follow-up) fix lint
Galen Charlton [Wed, 29 Jun 2022 18:56:12 +0000 (14:56 -0400)]
LP#1942647: (follow-up) fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table
Galen Charlton [Thu, 28 Apr 2022 00:42:05 +0000 (20:42 -0400)]
LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table

This patch ensures that Angular FM record editor dialogs do
not attempt to fetch all rows from target table when constructing
a combobox for a linked field.

In particular, it makes the following changes:

* If a custom template for a field is supplied, use that by
  default rather than _also_ creating a data source for
  a combobox.
* Rather than creating its own data source for a linked field,
  the FM record editor now uses the IDL mode of eg-combobox. By doing
  this, we use eg-combobox's default data source, which limits
  record retrievals to 100 rows max. Also, empty-click is now
  enabled by default.
* When attempting to identify a selector for an IDL class, if
  the class doesn't define a selector and doesn't have a field named
  'name', but its primary key is a text field, use the primary
  key as the selector.

To test
-------
[1] Create a few thousand empty bib record buckets in your test database.
[2] Edit a carousel under Local Administration; note that it can
    take some time for the dialog to load.
[3] Apply the patch and repeat step 2. This time, the carousel edit modal
    should open instantly.
[4] Test various Angular record editor modals to confirm that they behave
    as expected. For example:

    * The allocate to fund dialog in Fund Administration, in particular
      to verify that only active funds show up.
    * The assign user to course modal, to verify that searching is done
      by course number, not name.
    * Filter Dialog Set editor under /eg2/en-US/staff/admin/local/config/filter_dialog_filter_set
      to verify that the drop down for the creator doesn't fetch
      all patrons. (Note that this is an artificial example).

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
3 years agoLP#1945385: use eg-admin-page for circ limit sets admin UI
Jeff Davis [Thu, 19 May 2022 23:32:38 +0000 (16:32 -0700)]
LP#1945385: use eg-admin-page for circ limit sets admin UI

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoLP#1932203: serialize requests on Edit Due Date in Items Out tab
Jeff Davis [Thu, 21 Apr 2022 17:48:15 +0000 (10:48 -0700)]
LP#1932203: serialize requests on Edit Due Date in Items Out tab

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agolp1942647 Provide Warning when deleting Term linked to Courses
Kyle Huckins [Tue, 15 Mar 2022 02:20:40 +0000 (02:20 +0000)]
lp1942647 Provide Warning when deleting Term linked to Courses

- Separates out Course Term Grid to its own component
- Adds retrieval service function for Course/Term Maps based on Term ID
- Displays Confirmation dialog when deleting terms on the term grid if term is mapped to a course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/share/course.service.ts

Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoDocs: fix display error
Andrea Buntz Neiman [Fri, 17 Jun 2022 17:09:38 +0000 (13:09 -0400)]
Docs: fix display error

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoHold Management page update
gmontimantis [Thu, 10 Mar 2022 19:21:27 +0000 (14:21 -0500)]
Hold Management page update

Boopac screenshots

OPAC update

Boopac screenshots for hold notifications

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1950345-Format the Current Hold Groups table in bootstrap opac
Garry Collum [Wed, 10 Nov 2021 19:01:44 +0000 (14:01 -0500)]
LP1950345-Format the Current Hold Groups table in bootstrap opac

This patch styles the Current Hold Groups table in bootstrap to be consistent
with other tables in the bootstrap catalog.  It fixes overlappling text
in cells.  It also fixes the column headings for small screens.  Previously
the headings on small screens were pulling from the css rules for the
holds history table.

To test:
1. create a couple of hold groups and add a patron to each group.  Make the
groups opac visible.
2. login to the opac as the patron to view the holds groups to which the
patron belongs.  Notice the table style with not margins or padding.
3. make your browser as small as possible to see the incorrect headings.
4. apply the patch.
5. repeat 2 and 3 to view the fix.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP#1930617: reduce parallel requests initiated by AngularJS holdings editor
Galen Charlton [Mon, 23 May 2022 23:06:48 +0000 (19:06 -0400)]
LP#1930617: reduce parallel requests initiated by AngularJS holdings editor

This patch decreases the number of parallel requests spawned by the
AngularJS holdings editor. This can reduce load on open-ils.pcrud when
the editor is used to handle a large number of items in one batch.

This patch takes the following approaches:

- the fetching of call number affixes now only makes one request
  per relevant org unit
- item alerts are now retrieved via fleshing when the batch of items
  is requested (as opposed to doing a PCRUD request for each copy)
- fetching monograph parts is now done serially

To test
-------
[1] Apply the patch.
[2] Create a bucket with a few hundred items and edit all of them
    in the AngularJS holdings editor (which is what you get when
    you edit items from the bucket interface).
[3] Verify that the editing loads itself without causing errors
    or PCRUD drone spikes.
[4] Verify that item alerts and monograph parts are loaded
[5] Verify that the call number prefix and suffix drop-downs
    are correctly populated.
[6] Verify that copy alerts can be attached to newly-created items
    and saved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
3 years agoDocs: Alternate Notice Templates documentation
Andrea Buntz Neiman [Tue, 31 May 2022 20:39:36 +0000 (16:39 -0400)]
Docs: Alternate Notice Templates documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: Cover Image Upload documentation
Andrea Buntz Neiman [Tue, 31 May 2022 15:49:04 +0000 (11:49 -0400)]
Docs: Cover Image Upload documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoLP#1974195: fix memory leak when performing fleshed Fieldmapper search
Galen Charlton [Thu, 19 May 2022 14:00:48 +0000 (10:00 -0400)]
LP#1974195: fix memory leak when performing fleshed Fieldmapper search

This patch fixes a memory leak that occurs when performing
a fleshed search of an IDL class via open-ils.cstore, open-ils.pcrud,
or open-ils.rstore. It removes a debug-level log entry that didn't
free a temporary string.

To test
-------
[1] Perform a PCRUD search that includes fleshing and retrieves
    a large responses. One example is a search on bre that fleshes
    call numbers and copies and returns a few hundred bibs.
[2] Observe that the PCRUD drone that serviced the request has
    increased its memory usage significantly.
[3] Apply the patch and repeat step 1. This time, the drone's memory
    usage should not (persistently) increase as much.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoDocs: correction to Staff Portal Page docs
Andrea Buntz Neiman [Tue, 31 May 2022 14:18:03 +0000 (10:18 -0400)]
Docs: correction to Staff Portal Page docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: Staff Portal Page documentation
Andrea Buntz Neiman [Thu, 26 May 2022 21:10:15 +0000 (17:10 -0400)]
Docs: Staff Portal Page documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agofix typo in 3.8.1 release notes
Galen Charlton [Mon, 23 May 2022 15:52:31 +0000 (11:52 -0400)]
fix typo in 3.8.1 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoForward Port 3.8.1 Upgrade Script
Jason Boyer [Sat, 21 May 2022 00:21:08 +0000 (20:21 -0400)]
Forward Port 3.8.1 Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoForward Port 3.7.3 Upgrade Script
Jason Boyer [Fri, 20 May 2022 21:36:31 +0000 (17:36 -0400)]
Forward Port 3.7.3 Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoUpdate 3.8 Point Release Notes
Jason Boyer [Fri, 20 May 2022 19:55:02 +0000 (15:55 -0400)]
Update 3.8 Point Release Notes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoUpdate 3.7 Point Release Notes
Jason Boyer [Fri, 20 May 2022 19:54:51 +0000 (15:54 -0400)]
Update 3.7 Point Release Notes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoDocs: 3.8.1 Release Notes
Andrea Buntz Neiman [Fri, 20 May 2022 18:55:36 +0000 (14:55 -0400)]
Docs: 3.8.1 Release Notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoDocs: 3.7.3 Release Notes
Andrea Buntz Neiman [Fri, 20 May 2022 18:46:55 +0000 (14:46 -0400)]
Docs: 3.7.3 Release Notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
3 years agoLP#1857910: (follow-up) fix styling of mandatory class and field comboboxes
Galen Charlton [Fri, 20 May 2022 15:07:14 +0000 (11:07 -0400)]
LP#1857910: (follow-up) fix styling of mandatory class and field comboboxes

This patch uses the 'mandatory' synonym of 'required' in the custom comboboxes
for the IDL class and field.

There remains an issue: the fact that those fields are mandatory does
not propagate to the overall form validation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1857910: (follow-up) enhance IDL for field doc
Galen Charlton [Fri, 20 May 2022 14:27:04 +0000 (10:27 -0400)]
LP#1857910: (follow-up) enhance IDL for field doc

This patch adds human-readable labels to the IDL for
field doc. It also marks required fields in the IDL, removing
the need for the Angular code to explicitly specify
the set of required fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1857910: (follow-up) stamp DB update
Galen Charlton [Fri, 20 May 2022 14:15:45 +0000 (10:15 -0400)]
LP#1857910: (follow-up) stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1857910: (follow-up) clean up lint
Galen Charlton [Fri, 20 May 2022 14:12:48 +0000 (10:12 -0400)]
LP#1857910: (follow-up) clean up lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1857910 release note blurb for field doc port
Jason Etheridge [Thu, 7 Apr 2022 16:15:18 +0000 (12:15 -0400)]
LP1857910 release note blurb for field doc port

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1857910 add org family selector to field doc UI
Jason Etheridge [Thu, 7 Apr 2022 16:06:17 +0000 (12:06 -0400)]
LP1857910 add org family selector to field doc UI

If we want this to default to workstation org or something, we can do that, though I was having trouble
getting that to work.  Right now it'll include all orgs in its default unselected state.  I'm also not
sure about i18n-labelText and whether that works with eg-org-family-select.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1857910 make field doc grid sortable/pageable
Jason Etheridge [Wed, 6 Apr 2022 21:04:16 +0000 (17:04 -0400)]
LP1857910 make field doc grid sortable/pageable

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1857910 ws setting type for field doc grid
Jason Etheridge [Wed, 6 Apr 2022 19:15:58 +0000 (15:15 -0400)]
LP1857910 ws setting type for field doc grid

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP1857910 Field doc UI Angular 10 updates
Bill Erickson [Mon, 17 Aug 2020 21:29:50 +0000 (17:29 -0400)]
LP1857910 Field doc UI Angular 10 updates

Modify the lazy loader to use the new Ang10 style loading syntax.

Avoid using template variables as output variables for other components,
since template variables (those declared with let-foo="bar" in
<ng-template/>) are read-only, possibly as of Ang 10, so the page was
not loading at first.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agolp1857910 Field Documentation Port
Kyle Huckins [Wed, 8 Jan 2020 18:04:11 +0000 (18:04 +0000)]
lp1857910 Field Documentation Port

- Port grid UI allowing the creation and editing of Field
Documentation from DOJO to Angular

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/routing.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1946531: (follow-up) show progress bar when adding users to bucket
Galen Charlton [Thu, 19 May 2022 21:25:52 +0000 (17:25 -0400)]
LP#1946531: (follow-up) show progress bar when adding users to bucket

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1946531: use batch method to add users to bucket via User Buckets UI
Jeff Davis [Wed, 11 May 2022 22:55:21 +0000 (15:55 -0700)]
LP#1946531: use batch method to add users to bucket via User Buckets UI

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agolp1950507 Providers Admin Screenreader form fix
Kyle Huckins [Wed, 15 Dec 2021 17:43:42 +0000 (17:43 +0000)]
lp1950507 Providers Admin Screenreader form fix

- Move Search and Reset Form buttons to bottom of form when expanded.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
3 years agoLP#1968082: (follow-up) show progress bar when adding/removing items from bucket
Galen Charlton [Thu, 19 May 2022 18:12:20 +0000 (14:12 -0400)]
LP#1968082: (follow-up) show progress bar when adding/removing items from bucket

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1968082: (follow-up) tidy up whitespace
Galen Charlton [Thu, 19 May 2022 17:52:14 +0000 (13:52 -0400)]
LP#1968082: (follow-up) tidy up whitespace

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1968082: Use the batch API call to add and remove items from item buckets.
Jessica Woolford [Thu, 7 Apr 2022 19:15:55 +0000 (15:15 -0400)]
LP#1968082: Use the batch API call to add and remove items from item buckets.

In particular, when adding/removing items while on the item
bucket interface itself.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>