senator [Thu, 10 Jun 2010 15:34:34 +0000 (15:34 +0000)]
Hold requests in the middle layer now bubble up more specific information to
the caller in the event of failure.
The caller can find an ilsevent in the response received from calling
open-ils.circ.title_hold.is_possible, and this event will have a fail_part
attribute in its payload that can be mapped either to a) the new entities
in opac.dtd or b) values of the name column of the database table
config.standing_penalty, depending on why a hold request failed.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16651
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 10 Jun 2010 14:53:38 +0000 (14:53 +0000)]
thinko on how ou settings are returned from open-ils.actor.ou_setting.ancestor_default; also, cache max_loops per pickup lib for the duration of the targetting run
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16650
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 10 Jun 2010 14:35:01 +0000 (14:35 +0000)]
Fix a pcrud bug. Create method wasn't working because we were
foolishly trying to fetch the record that hadn't been created
yet, in order to test its ownership.
M Open-ILS/src/c-apps/oils_sql.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16649
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 10 Jun 2010 14:29:38 +0000 (14:29 +0000)]
make sure we are not trying to use a "modern" class::dbi
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16648
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 10 Jun 2010 13:55:47 +0000 (13:55 +0000)]
logic thinko causing us to never use the restricted set of copies for this hold targeting round, and instead use all good copies, when in max_loop mode
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16647
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 10 Jun 2010 13:18:23 +0000 (13:18 +0000)]
drop copy transparency tables
These tables were never used.
Signed-of-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16646
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 10 Jun 2010 00:58:06 +0000 (00:58 +0000)]
thinko
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16645
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 21:44:00 +0000 (21:44 +0000)]
Some python code is non-executable (script_x_check updated)
This corrects an overreach on the earlier patch.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16644
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 21:43:59 +0000 (21:43 +0000)]
</link> is not valid HTML
Although the DTD *may* specify xhtml, since in practice we are serving
with Content-Type: text/html and
<meta http-equiv="Content-Type" content="text/html;charset=utf-8" />
we should avoid tags that are illegal in html.
These errors are reported in chrome as:
"Unmatched </link> encountered. Ignoring tag."
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16643
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 21:43:58 +0000 (21:43 +0000)]
EDI Translator (relocated and combined)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16642
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 9 Jun 2010 21:39:12 +0000 (21:39 +0000)]
Rewrote the implementation of the open-ils.qstore.columns method.
The old implementation examined the SELECT clause(s) as encoded
in the query.select_item and query.expression tables. The new
implementation performs a dummy query, and then returns the
field names from the database result.
Advantages of the new implementation:
1. It doesn't get confused by wild cards in the SELECT clause.
2. It provides a field name for every column, including those
which are function calls, subqueries, or other expressions.
(Of course these names may not be very revealing, such as
"?column?".)
Disadvantages:
1. The resulting field names are not qualified by table name.
2. Additional overhead due to the additional database call.
M Open-ILS/src/c-apps/oils_storedq.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16641
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 9 Jun 2010 20:15:18 +0000 (20:15 +0000)]
typo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16640
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 9 Jun 2010 20:06:25 +0000 (20:06 +0000)]
In the patron editor, ensure that the Verify Password field matches the Password field to validate
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16639
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 19:10:52 +0000 (19:10 +0000)]
Bugfix cleanup of stray tags
<strong> had mismatched nesting and </img> was completely orphaned.
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16638
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 19:10:50 +0000 (19:10 +0000)]
type is a required attributed for script and style tags.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16637
dcc99617-32d9-48b4-a31d-
7c20da2025e4
atz [Wed, 9 Jun 2010 19:10:47 +0000 (19:10 +0000)]
Executable scripts
These were all found by ./build/tools/script_x_check.sh
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16636
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 9 Jun 2010 18:55:03 +0000 (18:55 +0000)]
update GPL 2.0 text in the staff client license statement
Also fixed last reference to the FSF's old mailing address
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16635
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 9 Jun 2010 18:41:05 +0000 (18:41 +0000)]
updated license text with current GPL 2.0 text
NOTE: THIS IS NOT A SEMANTICALLY IMPORTANT CHANGE TO EVERGREEN'S LICENSE.
Updated LICENSE.txt by pulling the current GPL 2.0 text
directly from http://www.gnu.org/licenses/old-licenses/gpl-2.0.txt
The changes are purely textual, and consist solely of:
* updating the FSF's mailing address
* changing references to the "GNU Library General Public License"
to "GNU Lesser General Public License", per the FSF's current
(and long-standing) practice
* whitespace changes
REPEAT: THIS IS NOT A RELICENSING
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16634
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 9 Jun 2010 17:52:58 +0000 (17:52 +0000)]
wrong URL
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16633
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 9 Jun 2010 15:37:52 +0000 (15:37 +0000)]
fix references to ersatz "as_unimarc" method in MARC::Record
No such method exists in MARC::Record; MARC::Record->as_usmarc()
should be used instead; think of as_usmarc() as if it were
named as_iso2709_blob().
As general note, UNIMARC support in Evergreen is currently
rather theoretical at this point.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16632
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 9 Jun 2010 15:32:02 +0000 (15:32 +0000)]
no includes in fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16631
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 9 Jun 2010 15:26:31 +0000 (15:26 +0000)]
explicitly allow SSI for these locations. Important for Apache on Redhat, etc.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16630
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 9 Jun 2010 04:57:10 +0000 (04:57 +0000)]
Recognize new "required" and "validate" attributes for <field> element.
M Open-ILS/src/c-apps/idlval.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16629
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 8 Jun 2010 21:01:27 +0000 (21:01 +0000)]
1. Support function calls in the FROM clause.
2. Support wildcards in the SELECT clause.
WARNING: the presence of a wildcard in the SELECT clause
is likely to disrupt a GROUP BY by renumbering the columns.
Also: the "columns" method currently cannot return the
names of the columns into which a wild card is expanded.
M Open-ILS/include/openils/oils_buildq.h
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16628
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 8 Jun 2010 16:14:31 +0000 (16:14 +0000)]
protect against empty results from bib searches caused by
search timeouts. This allows the API call to log the error
and return reasonable results
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16625
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 8 Jun 2010 15:26:24 +0000 (15:26 +0000)]
Split the ingest trigger logic into bits, simplifying optimization and configuration
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16624
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 8 Jun 2010 13:46:33 +0000 (13:46 +0000)]
Patch from Galen Charlton:
[This] patch adds a new XSL transform for indexing purpose that converts MARC21 880 fields (which are used for alternate graphic representations, i.e., vernacular representations of foreign language strings) to the base tags.
For example, if a MARC record for a Chinese book has
245.00 $6 880-01 $a Ba shi san nian duan pian xiao shuo xuan
880.00 $6 245-01/$1 $a\u516b\u5341\u4e09\u5e74\u77ed\u7bc7\u5c0f\u8aaa\u9078
this stylesheet will transform it to the equivalent of
245.00 $6 880-01 $a Ba shi san nian duan pian xiao shuo xuan
245.00 $6 245-01/$1 $a\u516b\u5341\u4e09\u5e74\u77ed\u7bc7\u5c0f\u8aaa\u9078
This allows an indexing XPath like //marc:datafield[@tag='245']/marc:subfield[@code='a'] to bring in both the vernacular and transliterated versions of the 245$a.
[ED: pretend the \u-encoded unicode are real characters ... curse you, Chrome, for not giving me the raw string!]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16623
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 7 Jun 2010 21:28:59 +0000 (21:28 +0000)]
config.metabib_field_index_norm_map params must be valid json; see also upgrade 0271
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16622
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 7 Jun 2010 20:03:33 +0000 (20:03 +0000)]
doh, too quick on the commit. :) fix the dupe-barcode test
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16621
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 7 Jun 2010 20:00:13 +0000 (20:00 +0000)]
re-adds the duplicate-barcode check that was lost with the new patron editor. TODO: disable the save buttons when there are form errors
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16620
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 7 Jun 2010 19:31:05 +0000 (19:31 +0000)]
Add the left_operand column to the query.expr_xbet view
(correcting an oversight).
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/008.schema.query.sql
A Open-ILS/src/sql/Pg/upgrade/0298.schema.xbet-left-operand.sql
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16619
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 7 Jun 2010 18:41:21 +0000 (18:41 +0000)]
1. Add table: serial.caption_and_pattern
2. In serial.record entry: make "marc" row nullable.
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0297.schema.serial-caption-and-pattern.sql
M Open-ILS/src/sql/Pg/210.schema.serials.sql
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16618
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 7 Jun 2010 18:14:46 +0000 (18:14 +0000)]
Patch from Galen Charlton:
Add foreign key to require that each row in metabib_field has a corresponding XML format.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16617
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 7 Jun 2010 17:55:13 +0000 (17:55 +0000)]
I'm not a fan of I18N-effort on debug output meant for developers. In this case, the wrong preferences file was being referenced, causing an error
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16616
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 7 Jun 2010 16:53:55 +0000 (16:53 +0000)]
Patch from Galen Charlton:
Fix glitch in definition of the new default identifier indexes that would cause bib ingest to fail. Note that this affected only newly-created databases; the upgrade script for 0265 is correct.
Thanks to Lee Dickens for running into this bug.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16615
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 7 Jun 2010 16:10:48 +0000 (16:10 +0000)]
Patch from Galen Charlton: The attached patch adds triggers on biblio.record_entry and authority.record_entry to prevent the insertion or update of MARCXML that is not well-formed. Since the various consumers of bre.marc and are.marc tend not to handle invalid XML all that well, these triggers serve as a (very basic) data integrity check. libmail.georgialibraries.org/pipermail/open-ils-dev/2010-June/006116.html
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16614
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 7 Jun 2010 13:52:29 +0000 (13:52 +0000)]
Added a new login type "persist", as a peer of "opac", "staff", and "temp".
It is intended for sessions that may stay open for days or weeks at a time
even in the absence of activity. The default timeout interval is defined
as two weeks in opensrf.xml, and may be overridden by the org unit
setting "auth.persistent_login_interval".
Timeout resets work a little differently for persistent logins. They
have no effect unless the session is within ten minutes of expiring. When
they do take effect, they reset the timeout to ten minutes, rather than to
the full length of the original timeout. That way we can avoid rudely
interrupting an active session without extending it excessively.
The ten minute reset interval for persistent timeouts is currently
hard-coded. With some further work it could be made configurable.
The timeout resets for the older login types still work the way they
always have.
------------
In order to make it easier to specify long timeout intervals, the
auth server now accepts PostgreSQL-style interval strings, such as
"15 minutes" or "2 weeks". Such strings work for any of the login
types, and they work either in opensrf.xml or in the org unit setting
values.
If the timeout setting (in either context) is all digits, then it will
be interpreted as an integral number of seconds, as it has been in the
past. So existing settings will almost certainly continue to work
without change.
The exception -- an unlikely one -- is if the existing setting carries
a leading plus sign. Under the old regime, a leading plus sign was
simply superfluous, and had no effect. With the new version, a
leading plus sign means that the following number is to be treated as
a number of hours, rather than a number of seconds (just because
that's what PostgreSQL does with it).
Hence in the unlikely event that existing settings use a leading
plus sign, this change will make those timeouts 3600 times as long
as they should be.
If the timeout interval is expressed as anything other than a string
of all digits (possibly with leading and/or trailing white space), we
make a database call to get PostgreSQL to interpret it for us. So the
convenience of using interval strings comes at the price of some
additional overhead.
--------------
Besides applying the changes to the C code, it will be necessary to
update the opensrf.xml file in order to define a default timeout
interval for the new login type.
M Open-ILS/include/openils/oils_constants.h
M Open-ILS/src/c-apps/oils_auth.c
M Open-ILS/examples/opensrf.xml.example
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16612
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 06:19:33 +0000 (06:19 +0000)]
Update a complete set of PO files in trunk
For all languages that have submitted any significant amount of translation,
commit PO files for every available POT or PO file (including our many new Dojo
I18N resource bundles)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16611
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 06:02:03 +0000 (06:02 +0000)]
Get the Makefile up to date with all of our new Dojo resource files
At some point, this Makefile has to become smarter, because there's a
whole lot of error-prone copying and pasting going on right now.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16610
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:57:06 +0000 (05:57 +0000)]
Stab at matching up reservation.js with the pluralized, JSON-compliant Dojo NLS file
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16609
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:45:26 +0000 (05:45 +0000)]
Make booking reservation Dojo NLS file JSON-compliant
You can't use string concatentation based on the plurality of arguments
to create a translatable string. Solution: create a singular and a plural
version of the string, and use the logic in the program itself to pass in
the substitution variable to the correct respective string.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16608
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:38:08 +0000 (05:38 +0000)]
Smarter error handling in Dojo i18n script
Identify the troublesome file before allowing the traceback
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16607
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:36:47 +0000 (05:36 +0000)]
More cleanup of Dojo JSON files
* Double-quote all strings - no single-quoting or barewords
* Don't escape dollar signs
* JSON doesn't allow expressions like string continuations ("" + "")
reservations.js has some remaining issues, looks like functions were
defined for what should be simple string substitutions. dojo.string.substitute()
will solve this problem, I believe, with ${0}, ${1}, etc tokens for substitution
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16606
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:15:52 +0000 (05:15 +0000)]
In Dojo i18n script: create output directories if they don't exist
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16605
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 05:00:16 +0000 (05:00 +0000)]
Fix up acq Dojo NLS file to be strictly JSON compliant
simplejson chokes on non-compliant JSON:
* Strings must be delimited in double-quotes
* Joining strings with + is not allowed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16604
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 7 Jun 2010 03:48:07 +0000 (03:48 +0000)]
Commit updates from Launchpad translation
Bringing all of the translated files up to date with what is in Launchpad.
Next steps: generate all of the updates from trunk and add all the new files
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16603
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Sun, 6 Jun 2010 01:54:31 +0000 (01:54 +0000)]
New function oilsUtilsIntervalToSeconds() to translate a string into a
number representing the number of seconds in an interval of time.
Simple integers are converted directly. Anything else is passed to
PostgreSQL to be translated as an interval string.
M Open-ILS/include/openils/oils_utils.h
M Open-ILS/src/c-apps/oils_utils.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16602
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 4 Jun 2010 21:36:03 +0000 (21:36 +0000)]
Email/print methods for printing A/T templated bib information
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16601
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:27 +0000 (20:53 +0000)]
Bugfixes: undef handling and legacy script support setting.
The legacy setting was a major bug. It was not possible to disable legacy scripts
except by *removing* the setting. That is, if you set it to 'false',
we failed to interpret that here in SIP to mean FALSE. Instead we
looked at it as a non-zero-length string and therefore TRUE!
This patch also prevents warnings from unitialized values (undef concatenation), like:
Use of uninitialized value in concatenation (.) or string at /openils/lib/perl5/OpenILS/SIP/Patron.pm line 110.
Added a little formatting and whitespace cleanup to address display along w/ undef handling.
Corrected an error screen message also.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16600
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:25 +0000 (20:53 +0000)]
Checkin overhual for extensions, including item, patron and checkin underpinnings.
Extensions fields added to AUTOLOADable content.
Also fix checkin logic to check for NO_CHANGE and SUCCESS at necessary moments.
Update new code to match berick's #16544.
Add AUTOLOAD to Item and provide a slot to store the raw EG hold object.
Store the hold data down on the item (not the Checkin transaction level).
Allow SIP Patron lookup by usr ID (not barcode).
This is important because we need supplemental data when we find holds info at checkin.
The change is backwards compatible (w/ just 1 arg it will still be treated as a barcode).
Propagate $inst_id down into checkout core, needed for hold routing logic.
Remove old accessor methods, also make some of the settings checks more flexible w/ regex.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16599
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:24 +0000 (20:53 +0000)]
Experimental implementation: renewal, block, enable.
Add sip_renewal (not implemented), correct log message w/ join
Patron block message and patron enable
This adds code for enable, still experimental. It also adds the
client's block message to the patron alert, bracketed by <sip> tags.
The tags are necessary because enable has to be able to regexp out
the block alert message (including user-specified variable text).
Remove unused vars.
Whitespace cleanup and extra feedback data.
Return object on failure, not just 0
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16598
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:23 +0000 (20:53 +0000)]
Lots of cleanup, logging improvements, and comments.
One arrayref accessor updated to recommended style
Removed unused dependency.
Removed never-possible return statement.
Trying to use an arrayref in the log message results in a string like "ARRAY(0x2541870)".
I added a prebuilt string representation of the array for use in those messages.
More whitespace cleanup.
More flexible to_bool, extra comments;
Also added institution_id method.
Note: OpenILS::Event->new returns a hash, not a true object.
script_x_check.sh is executable.
Irony: this script could have been used to detect itself.
Typo in Cronscript POD.
Signed-off-by: Joe Atzberger <atz@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16597
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 20:53:22 +0000 (20:53 +0000)]
Basic check for missing DB upgrades
Run this after a update_db.sh failure to see what failed.
Or run in before update_db.sh to make sure you are ready to apply
new updates.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16596
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 4 Jun 2010 19:00:55 +0000 (19:00 +0000)]
Add two little utility functions to convert from intervals to seconds.
M Open-ILS/src/sql/Pg/999.functions.global.sql
M Open-ILS/src/sql/Pg/002.schema.config.sql
A Open-ILS/src/sql/Pg/upgrade/0293.function.interval-to-seconds.sql
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16594
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 4 Jun 2010 15:07:13 +0000 (15:07 +0000)]
thinko (unquoted string literal); be more explicity about circ lib comparisons
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16593
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Jun 2010 13:28:37 +0000 (13:28 +0000)]
added granularity and user_data options to create_events_for_hook wrapper
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16590
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 4 Jun 2010 03:54:14 +0000 (03:54 +0000)]
Improve circ transaction performance by indexing NULL circs (Launchpad 587031)
Creating a unique index on target_copy in the action.circulation table where
the checkin_time is NULL will increase the speed of circ transactions,
particularly on systems with a lot of traffic. The uniqueness also
ensures that a given item will not be able to be checked out multiple times
concurrently.
Thanks to James Fournie from BC Sitka for suggesting the index in Launchpad
bug 587031!
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16589
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 4 Jun 2010 03:29:03 +0000 (03:29 +0000)]
Improve database performance for partial indexes on boolean columns (bug 587028 in Launchpad)
PostgreSQL 8.3/8.4 treats "IS FALSE" and "= FALSE" expressions differently,
which can have a significant impact on database performance if an index is
created with one and a query uses the other. This patch addresses all existing
partial indexes on boolean columns to enable the query planner to use an index
scan whether the query uses either expression.
Thanks to James Fournie of BC Sitka for noticing the problem with the index
on asset.copy and opening bug 587028 in Launchpad with the suggested fix!
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16588
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 3 Jun 2010 20:02:39 +0000 (20:02 +0000)]
Various tweaks:
1. When resetting the timeout for a session: if the session object
carries an endtime, and the expiration time is within a designated
interval, extend the expiration time a bit instead of reapplying the
entire original timeout from the current time.
This feature is unreachable at the moment because it is designed for
persistent sessions, which aren't otherwise implemented yet. The
purpose is to avoid rudely terminating an active session, but without
extending it too much.
2. Whenever possible, use integral types instead of doubles.
3. Instead of calling osrfCacheSetExpire(), call osrfCachePutObject()
directly, which does the same thing with less overhead.
4. Tinkered with white space and comments here and there.
M Open-ILS/src/c-apps/oils_auth.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16586
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 19:56:53 +0000 (19:56 +0000)]
implemented a simple mechanism to allow for linking to record detail pages by ISBN. If no record ID is present in the URL and the URL has a search type of isbn and an isbn value, do an ISBN lookup and display the first record we get back from the search.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16585
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 19:33:11 +0000 (19:33 +0000)]
org unit setting for requiring a matching email for password reset requests (no UI support yet)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16584
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 17:30:48 +0000 (17:30 +0000)]
display first name instead of usrname in self-check display as a security/obscurity compromise
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16583
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 3 Jun 2010 17:30:47 +0000 (17:30 +0000)]
prevent warnings that occur when the event type is not defined
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16582
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 3 Jun 2010 14:56:08 +0000 (14:56 +0000)]
documentation cut-n-pasto ... authority records are not org-scoped
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16580
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 3 Jun 2010 14:35:03 +0000 (14:35 +0000)]
add authority browsing framework to backend supercat app
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16579
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:18 +0000 (10:31 +0000)]
templates and methods for generating payment receipts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16578
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:17 +0000 (10:31 +0000)]
fix some id collisions and make use of properties instead of attributes for textboxes
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16577
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 10:31:16 +0000 (10:31 +0000)]
faster Library Settings UI and progress dialog
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16576
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 05:28:25 +0000 (05:28 +0000)]
more due date convenience options for offline mode, courtesy of Michael Peters, Indiana State Library
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16574
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Jun 2010 05:28:24 +0000 (05:28 +0000)]
util.list gets used in offline mode, so don't assume that we have fetched org unit settings
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16573
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 04:25:51 +0000 (04:25 +0000)]
Don't hardcode our password forms to en-US
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16572
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 04:05:39 +0000 (04:05 +0000)]
Apache2::Const::DECLINED leads to ugly error dialogues. I'm OK, you're OK.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16571
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 03:39:16 +0000 (03:39 +0000)]
< is not >; get our time-to-live threshold comparison correct
Also add a useful log entry to differentiate this not-active-request reason from the others
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16570
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 03:15:38 +0000 (03:15 +0000)]
Setting apache->status() caused 500 server errors for password reset requests
Don't do that.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16569
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 3 Jun 2010 02:52:10 +0000 (02:52 +0000)]
password reset URI needs a trailing slash, and this enables the aupr entry to be created, but:
* Server is now returning a 500 instead of 200, which causes an error dialogue
to be displayed instead of "success!" and JavaScript errors to cascade
* We don't want to hard-code the en-US locale; need to pull that from current locale
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16568
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 22:46:02 +0000 (22:46 +0000)]
s/perl/javascript/
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16567
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 22:39:16 +0000 (22:39 +0000)]
fix logic error that could result in partial list of available libs for workstation registration
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16566
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 2 Jun 2010 21:36:34 +0000 (21:36 +0000)]
Undouble these elements of password-reset that somehow doubled up during the forward-porting from rel_1_6
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16565
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 21:34:55 +0000 (21:34 +0000)]
some defensive programming
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16564
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Wed, 2 Jun 2010 19:24:14 +0000 (19:24 +0000)]
Replace most of the serial schema with a different set of tables. Only
the serial.record_entry table remains unscathed.
In addition: a new table asset.copy_template.
M Open-ILS/src/sql/Pg/002.schema.config.sql
M Open-ILS/src/sql/Pg/040.schema.asset.sql
A Open-ILS/src/sql/Pg/upgrade/0288.schema.serial-overhaul.sql
M Open-ILS/src/sql/Pg/210.schema.serials.sql
M Open-ILS/examples/fm_IDL.xml
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16563
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Jun 2010 18:46:24 +0000 (18:46 +0000)]
some more API documentation for these password reset request methods
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16562
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 18:02:06 +0000 (18:02 +0000)]
adding more non-auto Identifier specifiers
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16560
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 17:42:40 +0000 (17:42 +0000)]
use dojo.query instead of getElementsByTagName ... IE--
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16559
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 15:11:52 +0000 (15:11 +0000)]
add class/instance methods for checking required-ness and validity of an object field in JS FM implementation
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16557
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 14:55:23 +0000 (14:55 +0000)]
add class/instance methods for checking required-ness and validity of an object field in perl FM implementation; also fixing typo
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16556
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 14:38:58 +0000 (14:38 +0000)]
get rid of search.staged_fts() and supporting functions -- entirely replaced by search.query_parser_fts(); deprecating only, no upgrade script required
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16555
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 12:48:40 +0000 (12:48 +0000)]
made overly restrictive example validation regexp more generic -- just require at least one character, instead of all upper-case ASCII
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16554
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 2 Jun 2010 02:43:32 +0000 (02:43 +0000)]
add required IDL flag and validation regexp support
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16553
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 21:04:39 +0000 (21:04 +0000)]
Make in-db hold checking consistent with circulation when it comes to
returning events with fail_part set.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16552
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 20:35:21 +0000 (20:35 +0000)]
Move credit card processing ML code into the circ module, removing API method
for direct payment processing. (Using open-ils.circ.money.payment with auth
can invoke CC processing).
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16550
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 1 Jun 2010 19:19:08 +0000 (19:19 +0000)]
Forward port r16547 from rel_1_6_0: fix regression in date formatting for non-due dates
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16549
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 1 Jun 2010 19:02:19 +0000 (19:02 +0000)]
rid ourself of some namespace prefixes because IE is too braindead to understand them
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16546
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 17:38:21 +0000 (17:38 +0000)]
Remove accidentally committed OPAC CC payment test code.
Only the changes in payment.js and selfcheck.js were supposed to be commited
in 16542. The opac changes themselves were only a rough test and aren't
seaworthy.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16545
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Jun 2010 17:21:31 +0000 (17:21 +0000)]
in the SIP server plugin, don't connect and start a transaction by default with every cstore handle. only connect/begin when necessary. also, making use of new CStoreEditor::init() call for setting up the editor environment when initial load was done before the IDL was available.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16544
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 16:10:36 +0000 (16:10 +0000)]
In OPAC CC payment, fall back on alert()ing events if onPaymentSubmit undef
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16543
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Tue, 1 Jun 2010 15:59:25 +0000 (15:59 +0000)]
Incorporate CC payment interface into OPAC fines page (rough)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16542
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 1 Jun 2010 15:06:20 +0000 (15:06 +0000)]
Add support for GROUP BY.
M Open-ILS/include/openils/oils_buildq.h
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16541
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 1 Jun 2010 14:48:11 +0000 (14:48 +0000)]
add usr_setting_type of history.hold.retention_start for setting "opt-in" date of holds retention
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16540
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 1 Jun 2010 06:14:27 +0000 (06:14 +0000)]
substream for better performance with large datasets
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16539
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 31 May 2010 19:45:26 +0000 (19:45 +0000)]
Add support for BETWEEN conditions.
M Open-ILS/src/c-apps/oils_storedq.c
M Open-ILS/src/c-apps/buildSQL.c
git-svn-id: svn://svn.open-ils.org/ILS/trunk@16538
dcc99617-32d9-48b4-a31d-
7c20da2025e4