evergreen/bjwebb.git
14 years agoin SIP patron retrieval, only fetch non-archived penalties and penalties
erickson [Tue, 2 Nov 2010 02:55:21 +0000 (02:55 +0000)]
in SIP patron retrieval, only fetch non-archived penalties and penalties
that that matter (fines, overdues, blocking penalties).  pair down the
penalty comparisons to avoid fleshing the penalty type, potentially
numerous times for a given type, by using the constant identifiers.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18569 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnable merge of authority records to do the right thing
dbs [Tue, 2 Nov 2010 02:46:51 +0000 (02:46 +0000)]
Enable merge of authority records to do the right thing

The target and source authority record was flipped, causing
the update to fail. In reconsidering this function, it is not
necessary to change the contents of the source authority record
just to propagate the content of the target authority record
to any linked bibliographic records.

Instead, take the approach of updating the ID of the controlled
field in the bib record, then temporarily set "reingest on same
MARC" to TRUE and update the target authority record by setting
deleted = FALSE (which propagates the "changes" to the linked
bib records), then set "reingest on same MARC" flag back to its
original value.

This has the bonus of actually working.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18567 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoyet another replication race condition fix
gmc [Mon, 1 Nov 2010 23:22:53 +0000 (23:22 +0000)]
yet another replication race condition fix

Fixes problems that can occur when creating a lineitem
from an existing bib in the catalog; adds an authoritative
version of open-ils.acq.lineitem.retrieve.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18565 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomore compatability tweaks for login form. Each browser has its own heuristics for...
phasefx [Mon, 1 Nov 2010 21:22:06 +0000 (21:22 +0000)]
more compatability tweaks for login form.  Each browser has its own heuristics for saving credentials

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18564 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake vandelay.add_field smarter about applying add rules when no target field exists...
miker [Mon, 1 Nov 2010 20:52:45 +0000 (20:52 +0000)]
Make vandelay.add_field smarter about applying add rules when no target field exists before hand

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18561 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoReplace hard-coded '(CONS)' for MARC control number identifier in authority records
dbs [Mon, 1 Nov 2010 20:41:14 +0000 (20:41 +0000)]
Replace hard-coded '(CONS)' for MARC control number identifier in authority records

We created an actor.org_unit_setting, 'cat.marc_control_number_identifier', for
specifying the preferred MARC control number identifier, but when we create a
new authority record from the MARC editor, the hardcoded value of 'CONS' is being
used.

This teaches the staff client how to pull the appropriate value from the AOUS
when invoking the MARC Editor.

Resolves https://bugs.launchpad.net/evergreen/+bug/669245

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18559 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnsure that changes to authority records propagate to linked bibliographic records
dbs [Mon, 1 Nov 2010 19:44:16 +0000 (19:44 +0000)]
Ensure that changes to authority records propagate to linked bibliographic records

Per https://bugs.launchpad.net/evergreen/+bug/669596, updated authority records
weren't being reflected in bibliographic records with fields that link to those
authority records. We were missing the call to authority.propaagate_changes()
withing the ingest trigger on authority.record_entry.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18557 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agowe should not restrict to the top org only, get all counts
miker [Mon, 1 Nov 2010 18:37:36 +0000 (18:37 +0000)]
we should not restrict to the top org only, get all counts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18555 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agothere is no atomic version, of course ... it is all atomic all the time
miker [Mon, 1 Nov 2010 18:16:56 +0000 (18:16 +0000)]
there is no atomic version, of course ... it is all atomic all the time

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18553 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agokeep 1.6.1-2.0 upgrade script in sync
miker [Mon, 1 Nov 2010 17:32:15 +0000 (17:32 +0000)]
keep 1.6.1-2.0 upgrade script in sync

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18552 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoversion number missed in previous update
miker [Mon, 1 Nov 2010 17:30:30 +0000 (17:30 +0000)]
version number missed in previous update

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18550 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoImprove hold permit testing
miker [Mon, 1 Nov 2010 17:18:56 +0000 (17:18 +0000)]
Improve hold permit testing

 * Discard matchpoints where the OU in a particular slot is not ancestor-or-self of the target object's value
 * Discard matchpoints where strict_ou_match is true and the OU is not strictly matched

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18549 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agothis wraps the input elements used for opac login in an actual form element, with...
phasefx [Mon, 1 Nov 2010 17:13:42 +0000 (17:13 +0000)]
this wraps the input elements used for opac login in an actual form element, with the goal of allowing browsers to save credentials for the site.  So far this appears to work for Firefox 3.6.12, but not for Chrome 7.0.517.41, Opera 10.63, nor Safari 5.0.2.  IE 8.0.6001.18702 will prompt for saving credentials, but won't actually populate the form on a revisit.  Some of this may be due to me using an invalid/expired SSL-cert on my dev box, but I suspect it's really because another page is not being loaded after form submission.  Any ideas/suggestions?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18548 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosyntax
phasefx [Mon, 1 Nov 2010 16:14:11 +0000 (16:14 +0000)]
syntax

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18545 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agolet libraries allow funds to be overcommitted
gmc [Mon, 1 Nov 2010 15:39:39 +0000 (15:39 +0000)]
let libraries allow funds to be overcommitted

The check constraints on the balance warning and
stop limits were too strict - a library can validly
choose to permit a fund to have a commitment greater
than 100% of its allocation

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18543 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadd copy counts to the holdings xml format -- one more step toward freeing ourselves...
miker [Mon, 1 Nov 2010 14:50:53 +0000 (14:50 +0000)]
add copy counts to the holdings xml format -- one more step toward freeing ourselves from MVRs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18542 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadjust quoting of phrase searches
gmc [Fri, 29 Oct 2010 01:25:01 +0000 (01:25 +0000)]
adjust quoting of phrase searches

This has three main effects:

* This formalizes the current behavior where a
  phrase search like

  title:"^Harry Potter"

  acts as a left-anchored search and

  title:"Harry Potter$"

  acts as a right-anchored search.

In particular, this can be useful for constructing
searches of bibliographic call numbers.

* Other regex metacharacters in phrase searches are
  now escaped.

* Phrase searches like "C++" will no longer crash; in fact,
  this makes a phrase search currently the only way to
  accurately retrieve all C++ titles with the usual
  normalization rules

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18540 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoloosen cross-check of line item ID when processing incoming EDI messages
gmc [Fri, 29 Oct 2010 00:06:02 +0000 (00:06 +0000)]
loosen cross-check of line item ID when processing incoming EDI messages

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18538 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agowrap some EDI message retrievals in transactions
gmc [Thu, 28 Oct 2010 23:55:22 +0000 (23:55 +0000)]
wrap some EDI message retrievals in transactions

Avoid errors when operating under Slony.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18536 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoConfig UIs for hard due dates and their values
senator [Thu, 28 Oct 2010 22:43:48 +0000 (22:43 +0000)]
Config UIs for hard due dates and their values

Also, connect to the UI for circ policies

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18535 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPut a placeholder row into the checkin list to better handle the async checkin option...
phasefx [Thu, 28 Oct 2010 21:19:48 +0000 (21:19 +0000)]
Put a placeholder row into the checkin list to better handle the async checkin option (so that items show up in the same order in which they were scanned; it also feels more responsive).  This also forces us into a better way of handling errors: we keep the rows for such scans in the checkin list, but shove the error condition into the alert message field.  These rows can't be acted upon with the Actions for Selected Items menu.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18534 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocalling noop with no arguments (and not capturing the output) is, well, a no-op....
erickson [Thu, 28 Oct 2010 20:05:52 +0000 (20:05 +0000)]
calling noop with no arguments (and not capturing the output) is, well, a no-op.  set the value to true as originally intended

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18532 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAlternate Serial Control UI misc bugfixes, minor tweaks and improvements.
senator [Thu, 28 Oct 2010 18:14:06 +0000 (18:14 +0000)]
Alternate Serial Control UI misc bugfixes, minor tweaks and improvements.

Still fighting an autogrid that sometimes renders in an imcomplete, cut-off
sort of way in the distributions tab of the subscription details interface.

Add distribution count to summary tab.

The batch receive interface now prepopulates the circ mod, copy location, and
price fields based on each item's stream's distribution's copy template, when it
can.  When users had gone through the steps to create a copy template, it was
confusing not to see that work reflected in the batch receive interface.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18530 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agobring trunk's version of 1.6.1-2.0-upgrade-db.sql inline with rel_2_0
phasefx [Thu, 28 Oct 2010 17:28:50 +0000 (17:28 +0000)]
bring trunk's version of 1.6.1-2.0-upgrade-db.sql inline with rel_2_0

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18529 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocondensed SIP patron lookup by barcode into 1 cstore call; provided option for slimm...
erickson [Thu, 28 Oct 2010 15:13:30 +0000 (15:13 +0000)]
condensed SIP patron lookup by barcode into 1 cstore call;  provided option for slimmed-down user object fetching in the case of checkin, where all we really need is the barcode of the user on the circulation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18519 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoNormalize whitespace in O:A:Cat
dbs [Thu, 28 Oct 2010 15:08:00 +0000 (15:08 +0000)]
Normalize whitespace in O:A:Cat

There was a great mix of tabs and spaces in O:A:Cat, and as I just got bit
by that I thought I might as well make it consistent. Tried to keep all of
the var assignments lined up as well.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18517 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoEnsure call numbers are returned to the holdings editor in ascending sorted order
dbs [Thu, 28 Oct 2010 14:55:33 +0000 (14:55 +0000)]
Ensure call numbers are returned to the holdings editor in ascending sorted order

James Fournie in https://bugs.launchpad.net/evergreen/+bug/635121 reported
that call numbers were being displayed in the order that they had been
added to the database, rather than in sorted call number label order.
Although I have been unable to reproduce this problem on two different
test systems, the patch he provided for 1.6.1 (which fixes the problem on their
test system) shouldn't hurt other systems.

For sortkey-aware branches, I modified James' patch to take advantage of the
asset.call_number.label_sortkey column and the oils_text_as_bytea() function.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18516 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoIf we already know we're not using booking, skip a redundant and expensive
senator [Wed, 27 Oct 2010 21:20:53 +0000 (21:20 +0000)]
If we already know we're not using booking, skip a redundant and expensive
test for the possibility of capturing a hold. We're just going to try actually
doing it a little farther down.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18514 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoexperiment: asynchronous check-in via checkbox toggle. also removes call number...
phasefx [Wed, 27 Oct 2010 21:13:55 +0000 (21:13 +0000)]
experiment: asynchronous check-in via checkbox toggle.  also removes call number from column list for the time being (since it makes a synchronous network call)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18513 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomore micro-optimization of checkin code;
erickson [Wed, 27 Oct 2010 20:20:29 +0000 (20:20 +0000)]
more micro-optimization of checkin code;

also protect against undef var warning in info message;
removed unused sub

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18511 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoShould not be included in the 2.0 upgrade script -- trunk only (suggesting we should...
miker [Wed, 27 Oct 2010 20:10:18 +0000 (20:10 +0000)]
Should not be included in the 2.0 upgrade script -- trunk only (suggesting we should not have 1.6.1-2.0 in trunk)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18510 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove towards unnest (faster than explode_array); bring upgrade script up to speed
miker [Wed, 27 Oct 2010 20:05:19 +0000 (20:05 +0000)]
Move towards unnest (faster than explode_array); bring upgrade script up to speed

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18508 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agosince they typically repeat, cache the org and requestor objects in the permit loop...
erickson [Wed, 27 Oct 2010 19:18:52 +0000 (19:18 +0000)]
since they typically repeat, cache the org and requestor objects in the permit loop of the find-best-hold calculation

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18505 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBooking: make the circ module avoid booking code if the booking service isn't up
senator [Wed, 27 Oct 2010 19:06:08 +0000 (19:06 +0000)]
Booking: make the circ module avoid booking code if the booking service isn't up

Previously, it was not possible to turn the booking service off and have working
circ.  Now you should be able to turn it off if you don't need it.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18502 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAnd ... move the CIRC_CLAIMS_RETURNED event check back up
miker [Wed, 27 Oct 2010 18:29:22 +0000 (18:29 +0000)]
And ... move the CIRC_CLAIMS_RETURNED event check back up

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18501 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove generate_fines_finish even further down the do_checkin path
miker [Wed, 27 Oct 2010 18:21:10 +0000 (18:21 +0000)]
Move generate_fines_finish even further down the do_checkin path

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18500 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotruth in advertising. label change
phasefx [Wed, 27 Oct 2010 18:18:49 +0000 (18:18 +0000)]
truth in advertising.  label change

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18499 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoGive staff the ability to select a circ lib and user group and mark all associated...
phasefx [Wed, 27 Oct 2010 18:10:45 +0000 (18:10 +0000)]
Give staff the ability to select a circ lib and user group and mark all associated overdue circulations/items as Lost.  Admin->Local System Administration->Age Overdue Circs to Lost.  This may be used, for example, by academic libraries after the end of a semester.  Must remember to activate the template and to give it an editor param.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18498 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoremove unused settings and permission
gmc [Wed, 27 Oct 2010 16:51:15 +0000 (16:51 +0000)]
remove unused settings and permission

circ.holds.alert_if_local_avail and circ.holds.deny_if_local_avail
are redundant; circ.holds.hold_has_copy_at.{alert|block} are the
settings that will actually be used.  Also remove a related,
redundant permission.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18495 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSplit fine generation into call/gather parts; call early, gather late
miker [Wed, 27 Oct 2010 16:45:39 +0000 (16:45 +0000)]
Split fine generation into call/gather parts; call early, gather late

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18494 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoA tool for interning CSS @import declarations, stripping comments, and removing usele...
miker [Wed, 27 Oct 2010 16:42:46 +0000 (16:42 +0000)]
A tool for interning CSS @import declarations, stripping comments, and removing useless whitespace

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18493 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded grid autoHeight to distrib formula page to prevent the grid from consuming...
erickson [Wed, 27 Oct 2010 15:26:22 +0000 (15:26 +0000)]
added grid autoHeight to distrib formula page to prevent the grid from consuming the whole page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18491 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: Make the distribution formula UI page like it was supposed to
senator [Wed, 27 Oct 2010 14:52:36 +0000 (14:52 +0000)]
Acq: Make the distribution formula UI page like it was supposed to

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18489 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix glitch in escaping call number labels
gmc [Wed, 27 Oct 2010 12:06:22 +0000 (12:06 +0000)]
fix glitch in escaping call number labels

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18487 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoView Source option for embedded browser (click on the Debug link)
phasefx [Wed, 27 Oct 2010 05:10:39 +0000 (05:10 +0000)]
View Source option for embedded browser (click on the Debug link)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18485 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoCopy template editor was still glitchy on create. No more.
senator [Tue, 26 Oct 2010 22:11:19 +0000 (22:11 +0000)]
Copy template editor was still glitchy on create. No more.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18480 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMore reordering of JS. Helps for simple interfaces, not for complex ones. More work...
miker [Tue, 26 Oct 2010 20:11:59 +0000 (20:11 +0000)]
More reordering of JS. Helps for simple interfaces, not for complex ones. More work needed.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18479 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoallow openils.XUL to work (and report false for isXUL()) outside xulrunner/firefox
miker [Tue, 26 Oct 2010 20:04:01 +0000 (20:04 +0000)]
allow openils.XUL to work (and report false for isXUL()) outside xulrunner/firefox

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18478 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix NACO normalization of four letter modifier characters
gmc [Tue, 26 Oct 2010 19:35:38 +0000 (19:35 +0000)]
fix NACO normalization of four letter modifier characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18476 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomove the "I need a transaction" marker into the called method, removing 2 perl round...
miker [Tue, 26 Oct 2010 15:31:17 +0000 (15:31 +0000)]
move the "I need a transaction" marker into the called method, removing 2 perl round-trips to start the transaction and close it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18475 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoJS reordering to account for readyState event leakage from XHR to the main page
miker [Tue, 26 Oct 2010 14:52:25 +0000 (14:52 +0000)]
JS reordering to account for readyState event leakage from XHR to the main page

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18474 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoinclude more information in the debugging dump; correct the "back to index" link
miker [Tue, 26 Oct 2010 13:59:30 +0000 (13:59 +0000)]
include more information in the debugging dump; correct the "back to index" link

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18469 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFloating field in alternate item details UI
phasefx [Mon, 25 Oct 2010 19:15:49 +0000 (19:15 +0000)]
Floating field in alternate item details UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18467 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoquickly, before anyone notices ... minor speed enhancement (aka, thinko)
miker [Mon, 25 Oct 2010 18:31:20 +0000 (18:31 +0000)]
quickly, before anyone notices ... minor speed enhancement (aka, thinko)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18465 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoBring 1.6.1-2.0 upgrade script in line with reality
miker [Mon, 25 Oct 2010 18:21:40 +0000 (18:21 +0000)]
Bring 1.6.1-2.0 upgrade script in line with reality

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18463 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoIn 2.0+ we require PG 8.4+ which means we have WITH RECURSIVE support, so use that...
miker [Mon, 25 Oct 2010 18:01:25 +0000 (18:01 +0000)]
In 2.0+ we require PG 8.4+ which means we have WITH RECURSIVE support, so use that instead of tablefunc connect_by.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18462 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoDump some debugging output from clark; may later make this optional, but we usually...
miker [Mon, 25 Oct 2010 16:25:05 +0000 (16:25 +0000)]
Dump some debugging output from clark; may later make this optional, but we usually need it when looking for the cause of problems.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18457 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoImproved subject formatting on summary page, and better title bookmarking
dbs [Mon, 25 Oct 2010 15:15:49 +0000 (15:15 +0000)]
Improved subject formatting on summary page, and better title bookmarking

Apply a modified version of Ben Ostrowsky's patch from
https://bugs.launchpad.net/evergreen/+bug/627133 - the modifications include
using BT.textContent() to retrieve the text of the subfields, and
getAttribute() instead of dojo.attr() for IE support.

From the description of 627133:

Currently the BibTemplate code in rdetail/rdetail_summary.xml for display
of subject headings only includes the 650. It should be expanded to:

  * include all standard subject added entry fields (or more broadly, all 6XX)
  * exclude control subfields (those whose subfield label is a digit) from display
  * only using the double-dash separator before subfields $x, $y, $z, and $v.
    The display text of other subfields should be separated from one another only
    by a space.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18456 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofurther protection against dreaded opac bank page; wrap settimeout redetail bibtempla...
erickson [Fri, 22 Oct 2010 20:40:25 +0000 (20:40 +0000)]
further protection against dreaded opac bank page; wrap settimeout redetail bibtemplate loading in an onload to ensure it runs after dojo onload events

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18454 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUse standard JS syntax; var [...] seems to be a Spidermonkey extension
miker [Fri, 22 Oct 2010 19:26:04 +0000 (19:26 +0000)]
Use standard JS syntax; var [...] seems to be a Spidermonkey extension

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18452 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotypo in setTimeout spotted by dbs
miker [Fri, 22 Oct 2010 16:25:08 +0000 (16:25 +0000)]
typo in setTimeout spotted by dbs

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18450 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAcq: fix minor bug, sometimes view/place orders interface failed if you clicked
senator [Fri, 22 Oct 2010 16:23:55 +0000 (16:23 +0000)]
Acq: fix minor bug, sometimes view/place orders interface failed if you clicked
"Add to Selection List" for a new order

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18448 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMove dojo loading around to avoid the "white screen of death" in Firefox and xulrunne...
miker [Fri, 22 Oct 2010 16:19:49 +0000 (16:19 +0000)]
Move dojo loading around to avoid the "white screen of death" in Firefox and xulrunner (See: o.dojotoolkit.org/forum/dojo-foundation/general-discussion/firefox-3-fires-domcontentloaded-event-prematurely )

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18446 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSerials: in alt serial controls, subscription details, avoid cut-off autogrid
senator [Thu, 21 Oct 2010 19:33:09 +0000 (19:33 +0000)]
Serials: in alt serial controls, subscription details, avoid cut-off autogrid

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18442 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoilsevent is no longer a number, but a string. I knew that, but missed these tests
phasefx [Thu, 21 Oct 2010 16:08:50 +0000 (16:08 +0000)]
ilsevent is no longer a number, but a string.  I knew that, but missed these tests

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18440 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadding database update missed in previous commit
gmc [Thu, 21 Oct 2010 14:45:13 +0000 (14:45 +0000)]
adding database update missed in previous commit

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18435 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoimprove call number sorting
gmc [Thu, 21 Oct 2010 14:44:35 +0000 (14:44 +0000)]
improve call number sorting

oils_text_as_bytea now does uppercasing in addition
to converting strings to bytea, working around
the limitation that json_query can't stack transforms

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18434 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agouse a transaction when searching for the nearest hold request
gmc [Wed, 20 Oct 2010 21:47:34 +0000 (21:47 +0000)]
use a transaction when searching for the nearest hold request

Solves the following problem in a setup that uses Slony - if
multiple items that can fulfill the same hold are checked
in one after another, occassionally two items will end up
being put in transit for the same hold request.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18432 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPatch from tsbere for new tab versus current tab behavior with the button bar:
phasefx [Wed, 20 Oct 2010 21:10:51 +0000 (21:10 +0000)]
Patch from tsbere for new tab versus current tab behavior with the button bar:
---
The attached patch to trunk adds the ability to set an open-ils.toolbar.defaultnewtab preference to cause the toolbar buttons to open in a new tab instead of the current tab. Holding the "accel" key (default of ctrl on windows/linux and command on mac) will do the opposite.

I only applied this to the five commands currently in use on the toolbar for now. Any other commands added to the toolbar will need to have their command handlers in menu.js updated.

Thomas Berezansky
Merrimack Valley Library Consortium

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18431 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadded some time diagnostics to checkin process; more org unit caching; do less user...
erickson [Wed, 20 Oct 2010 20:44:58 +0000 (20:44 +0000)]
added some time diagnostics to checkin process;  more org unit caching; do less user fleshing on hold user during checkin (only card and name is needed)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18428 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoThese fields exist ... tell the IDL about them
miker [Wed, 20 Oct 2010 20:44:23 +0000 (20:44 +0000)]
These fields exist ... tell the IDL about them

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18427 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoadd start_date and end_date to scap serialization
miker [Wed, 20 Oct 2010 20:33:32 +0000 (20:33 +0000)]
add start_date and end_date to scap serialization

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18425 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agodon't allow inactive cards with web-selfcheck
phasefx [Wed, 20 Oct 2010 20:15:01 +0000 (20:15 +0000)]
don't allow inactive cards with web-selfcheck

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18423 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoRemove accidental duplicated line
senator [Wed, 20 Oct 2010 20:13:49 +0000 (20:13 +0000)]
Remove accidental duplicated line

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18421 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoFix a set of supercat bugs in handling records with subscriptions attached. The
senator [Wed, 20 Oct 2010 19:51:47 +0000 (19:51 +0000)]
Fix a set of supercat bugs in handling records with subscriptions attached. The
most noticeable manifestation was that you wouldn't see local call numbers in
the opac for any such record.

Credit to miker for help with the bug squashing and filling in missing pieces.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18419 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAction/trigger: restore the environment-flesher's ability to try reporter-store
senator [Wed, 20 Oct 2010 19:35:42 +0000 (19:35 +0000)]
Action/trigger: restore the environment-flesher's ability to try reporter-store
if cstore is not among the controllers on a needed class

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18416 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoreporter.materialized_simple_record isn't really /just/ for reporter, as it's
senator [Wed, 20 Oct 2010 17:32:55 +0000 (17:32 +0000)]
reporter.materialized_simple_record isn't really /just/ for reporter, as it's
linked to from bre

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18414 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago1.6.1-2.0 upgrade script needs to fall in line with reality, re 0442
miker [Wed, 20 Oct 2010 16:39:40 +0000 (16:39 +0000)]
1.6.1-2.0 upgrade script needs to fall in line with reality, re 0442

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18411 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoPrevent "Validate" from matching against deleted authority records
dbs [Wed, 20 Oct 2010 16:17:45 +0000 (16:17 +0000)]
Prevent "Validate" from matching against deleted authority records

2.0 introduces the ability to delete authority records. The routines in
OpenILS:Application:Storage:Publisher:authority check for matching values
of authority.full_rec without concern about whether the corresponding
entry in authority.record_entry has been deleted or not.

This change removes entries from authority.full_rec when an
authority.record_entry row is deleted, with the (possibly incorrect)
assumption that there won't be many cases where users will want to
search for deleted authority records and undelete them. If that
assumption turns out to be incorrect, then further changes can follow;
this change at least makes the current behaviour for user-visible
actions work as expected.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18409 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoAlt serials interface tweak
senator [Wed, 20 Oct 2010 15:59:55 +0000 (15:59 +0000)]
Alt serials interface tweak

Add a shortcut for the user to jump back from the streams interface to the
distributions tab of the subscription details interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18407 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoduring checkin, an item's hold may have a fleshed pickup_lib. added code to detect...
erickson [Wed, 20 Oct 2010 15:23:35 +0000 (15:23 +0000)]
during checkin, an item's hold may have a fleshed pickup_lib.  added code to detect and protect against treating a ref as an ID.  minor cleanup

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18402 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSummary: Patch from Thomas Berezansky providing an alternate implementation of Hard...
miker [Wed, 20 Oct 2010 13:23:09 +0000 (13:23 +0000)]
Summary: Patch from Thomas Berezansky providing an alternate implementation of Hard Due Dates.

Overview:
 * Moves hard due date configuration from the duration rule to the circ matrix
 * Implements backward-compatible API for circ scripts
 * Provides a stored procedure which updates hard due date values on demand

Further extension by Mike Rylander:
 * Provide a srfsh script and crontab.example entry to fire the stored procedure nightly
 * Expose stored procedure and add to the upgrade script

TODO: Create UIs for configuring hard due dates; integrate into version upgrade scripts

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18396 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoUse a transaction when clearing the expired circ history
miker [Wed, 20 Oct 2010 12:56:34 +0000 (12:56 +0000)]
Use a transaction when clearing the expired circ history

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18395 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoexpand the scope of BT on the result list page, allowing simpler slots
miker [Tue, 19 Oct 2010 20:37:10 +0000 (20:37 +0000)]
expand the scope of BT on the result list page, allowing simpler slots

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18392 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoupdate 1.6.1 to 2.0 upgrade script for 0441
gmc [Mon, 18 Oct 2010 23:02:23 +0000 (23:02 +0000)]
update 1.6.1 to 2.0 upgrade script for 0441

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18390 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix mapping of the crossed D character in naco_normalize
gmc [Mon, 18 Oct 2010 22:56:48 +0000 (22:56 +0000)]
fix mapping of the crossed D character in naco_normalize

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18388 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoMake editing of asset.copy_template a little more friendly (AutoGrid w/ pcrud
senator [Mon, 18 Oct 2010 21:53:44 +0000 (21:53 +0000)]
Make editing of asset.copy_template a little more friendly (AutoGrid w/ pcrud
can't deal with editor/creator fields for you).

Incidentally add createPaneOnSubmit and editPaneOnSubmit attributes to
AutoGrid that take a function name as their values, specifying an alternate
callback function to use instead of pcrud.create/update

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18386 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoSerials: add functionality meant for "Previous Issuance Copy Location" setting
senator [Mon, 18 Oct 2010 19:44:55 +0000 (19:44 +0000)]
Serials: add functionality meant for "Previous Issuance Copy Location" setting

Simply put, if you're receiving an item a branch for which the org-unit
setting "serial.prev_issuance_copy_location" has a value, the previously
received copy matching the same distribution and stream as the item you're
receiving now will be moved to that copy location specified in the org-unit
setting.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18384 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoProtect biblio.extract_located_uris() from a NULL uri_use value by using the href...
dbs [Mon, 18 Oct 2010 19:05:19 +0000 (19:05 +0000)]
Protect biblio.extract_located_uris() from a NULL uri_use value by using the href as a fallback

If an 856 field contained a subfield "9" but did not contain a subfield
"z", "2", or "n", then ingest of the MARC record would fail as it attempted
to retrieve an asset.uri row where uri_use = NULL - which was never true.

This change adds the subfield "u" to fall back to for the uri_use variable,
just like we do for the uri_label variable, and prevents ugly ingest errors
from getting thrown back at the client.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18382 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agostop sign page was incorrectly coming up for all penalties
phasefx [Mon, 18 Oct 2010 17:44:59 +0000 (17:44 +0000)]
stop sign page was incorrectly coming up for all penalties

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18380 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agomake Circulation -> Enter Offline Interface open a new window instead of a tab, like...
phasefx [Mon, 18 Oct 2010 16:18:40 +0000 (16:18 +0000)]
make Circulation -> Enter Offline Interface open a new window instead of a tab, like the button from the login window.  This works around a permission issue with loading the offline receipt templates

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18377 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agofix billing interface so that %title% and %barcode% work in bill_payment template
phasefx [Mon, 18 Oct 2010 15:35:50 +0000 (15:35 +0000)]
fix billing interface so that %title% and %barcode% work in bill_payment template

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18375 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agocorrect default bills_historical template to use %mbts_id% instead of %id%. Also...
phasefx [Mon, 18 Oct 2010 15:35:46 +0000 (15:35 +0000)]
correct default bills_historical template to use %mbts_id% instead of %id%.  Also add in %title%

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18374 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agogo ahead and use the new index if we need to
miker [Sat, 16 Oct 2010 15:38:21 +0000 (15:38 +0000)]
go ahead and use the new index if we need to

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18366 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoneed to update this index as well
miker [Sat, 16 Oct 2010 15:35:39 +0000 (15:35 +0000)]
need to update this index as well

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18365 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agouse a function to wrap up escaping of solidus and casting to bytea, propogate to...
miker [Sat, 16 Oct 2010 15:32:32 +0000 (15:32 +0000)]
use a function to wrap up escaping of solidus and casting to bytea, propogate to indexing and where/order_by

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18364 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agotweak expanding search field aliases
gmc [Fri, 15 Oct 2010 13:08:52 +0000 (13:08 +0000)]
tweak expanding search field aliases

Avoids a glitch that can occur if a search field alias
exists that happens to have the same name as a search field.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18353 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoIf an item is captured for a hold, but not in transit (i.e. on holds shelf), set...
erickson [Thu, 14 Oct 2010 22:17:21 +0000 (22:17 +0000)]
If an item is captured for a hold, but not in transit (i.e. on holds shelf), set the destination_location equal to the pickup library (i.e where it's supposedly on the shelf).  This is useful for autmated sorting so that the item will return to the branch whose shelf where it belongs.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18351 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years agoforce granularity-only when any granularity is specified
miker [Thu, 14 Oct 2010 20:17:00 +0000 (20:17 +0000)]
force granularity-only when any granularity is specified

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18349 dcc99617-32d9-48b4-a31d-7c20da2025e4

14 years ago"as" not "to" ... you pointed that out the first time, miker, what is your deal?
miker [Thu, 14 Oct 2010 20:04:05 +0000 (20:04 +0000)]
"as" not "to" ... you pointed that out the first time, miker, what is your deal?

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18343 dcc99617-32d9-48b4-a31d-7c20da2025e4