Add missing library logos

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES library system logos

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES customization - display library logo on library info page

Must be on top of rel_3_10_0_library_logo_field

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Customization - Add library logo field to Org Unit

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1929593 UPDATE_COPY_BARCODE permission

This adds the permission UPDATE_COPY_BARCODE and a new API call,

  open-ils.cat.update_copy_barcode

which explicitly tests for both UPDATE_COPY_BARCODE and UPDATE_COPY,
with either being sufficient for allowing a barcode change.  Existing
Replace Barcode UI's in both Angular and AngularJS have been modified
to use this API call instead of the pcrud service.  One side-effect of
this has been better surfacing of errors, as errors in pcrud were
uncaught and bypassing the normal error handling.  This addresses
LP1951469.

The upgrade script gives any permission groups that already have the
UPDATE_COPY permission the new UPDATE_COPY_BARCODE permission at the
same depth, though it's technically not needed.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>

PINEScustomization_LIsearchPOname

PO Name column in LI search goes directly to PO without LI fragment

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP#2007880: fix open-ils.actor.ou_setting.ancestor_default

This patch fixes a regression introduced by bug 2006749 that
prevented open-ils.actor.ou_setting.ancestor_default from retrieving
the value of a library setting that does not have a view permission
associated with it. It also fixes a similar issue with
open-ils.actor.org_unit.settings.history.retrieve.

To test
-------
[1] Use srfsh to retrieve the value of a library setting
    that does not have a view permission. E.g.,

    request open-ils.actor open-ils.actor.ou_setting.ancestor_default 4, "circ.grace.extend"

    Note that an error is returned.

[2] Apply the patch and repeat step 1. This time, the value of
    the setting should be returned.
[3] Verify that viewing the edit history of a setting in the
    Library Settings admin page works as expected.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2006749: Fix second call to ou_ancestor_setting_perm_check in AppUtils.pm

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#2006749: Fix call to ou_ancestor_setting_perm_check in AppUtils.pm

The $self and $e arguments are missing when the ou_ancestor_setting
subroutine calls ou_ancestor_setting_perm_check in AppUtils.

The $coust argument also need to be $coust->view_perm->code for the
allowed check in ou_ancestor_setting_perm_check.

This commit corrects the call to ou_ancestor_setting_perm_check.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES - Stripe warning message

Adds message to OPAC about paying in person if their online
payment does not work.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1369345: de-duplicate ILS events

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Revert "LP#1999944: fix bug that can break drawing the folder tree for reports"

This reverts commit c4302618ef36608916a61990a8841c1eee4d618a.

LP #1998494: Angular Holdings Editor: Cannot create empty call numbers

Returns support for adding empty call numbers when adding holdings.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Mary Llewelln <mllewell@biblio.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

typo fix

LP2006513 Angular login redirect repair

The routeTo parameter must contain an eg2-based path (/staff/splash)
and not a full path (/eg2/staff/splash) or URL.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1999944: fix bug that can break drawing the folder tree for reports

Specifically, skip drawfolders iteration if parent node cannot be
found and eport invalid parent folder in the browser console.

For example, if a user creates a template folder that is not shared
that has a child folder that _is_ shared, another user at the library
that the folder is shared with would see their report folders be
incompletely rendered.

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

PINEScustomization_LI_id_links

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP2003947 Add LID count to Acq Search

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Revert "attempt to stop warnings"

This reverts commit 2a1259be365ea6ccd0ac493df01e233952c53612.

attempt to stop warnings

LP#2004420: check that $note is defined before using it

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#2004420: remove debugging artifact causing WARN messages.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#2004420: check that $note is defined before using it

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

quiet the logs

more warn log quieting

quiet more useless warnings

quiet more unnecessary warn logs

more log fixes

Revert "more log warning fixes"

This reverts commit a6c0358f8a720b79e6810adfec04041585163508.

more warnlog fixes

more log warning fixes

more log quieting measures

quiet logs when authtoken doesn't exist

suggested change from berick for dealing with bad auth calls

Revert "attempted fix of null token perm calls"

This reverts commit 54738e6d27adf77f4868ba4d5b1f7f586a7781b0.

Revert "attempted fix of null token perm calls - small tweak"

This reverts commit d1c82bae2dfbf010992ca41963777b1148b50549.

PINEScustomization Change invoice PO link

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP2003946 LI ID in Search jumps to item detail page

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP2003973 Remove perm checks from acq copy-attrs

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Fix OpenAthens auth redirection to resource

LP#2003090 Angular Daily Cash Report Missing Print Capability

Administration->Local Administration->Cash Reports

Add a print button to the Desk and Staff User Payment grids to
print the org, date range, totals, and full list.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>

PINES - remove extraneous code for carousel bucket problem

This removes a bit of code that got into the PINES version that
is not in master.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1996818 Issues Placing Holds from the Patron Record

This clears the patron hold target cookie when navigating from
the staff/catalog route, when the window is closed, and when
holds are successfully placed.

This also changes the AngularJS patron interface to set the
same session cookie as the Angular interface.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>

attempted fix of null token perm calls - small tweak

attempted fix of null token perm calls

lp1988321 - attempt to cast integer to string

LP2002920 Batch updater not updating circ mod

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

PINES Preferred Name on Hold Shelf Slip

Fixes typo in previous customization

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

ECARD - Temp workaround for charges page bug

Commenting out a line that's causing problems on OPAC My Account
pages when the patron has charges - will need additional work to
figure out why.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

removing errant conflict artifact

quiet warn logs from stat cat warnings

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES - Copyright Warning on Cover Image Uploader Modal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1990306: avoid VIEW_USER perm lookup on egPatronApp startup when we have a null authtoken

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>

LP2002425 Add an owners limiter to acqpro idlQueryAnd

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

PINES - fix duplicated copy notes and tags in OPAC holdings view

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu - Temporarily hide renewal links until we are ready to roll out

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP2002337 Pre-Fetch All Holds Checkbox Appears Twice

Removes duplicate Pre-Fetch All Holds checkbox from the Angular
View Holds page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - Remove Simple Reports menu item from navbars

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1953181 Fix combobox div and funds spacing

Removes input-prepend that was causing other comboboxes to be shrunk, and moves the year selector closer to the Library dropdown so it's not floating out by itself.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Adding missing function

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>

LP # 1814966: No popup warning for invalid barcode

Adds a check for an invalid barcode if "Use Checkdigit" is selected.
Prevents saving if the check fails.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>

PINES - Tweaks to Carousel Display

Attempting to resolve a bug causing a long gap before a carousel
would restart. Also, adding a little padding under the title.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - fix merge issues with OPAC notification prefs page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1955079: Use Email::MIME for emailing records in the OPAC

Email::Simple was mangling the headers.  Let's use Email::MIME instead.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>

PINES Custom - Re-add Email links to OPAC

(Had previously removed due to bug LP#1955079)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Online Renewal - tweak expire date comparison

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1995418 Shelving location selector won't dropdown

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1953181 Adds optional LabelText to eg-combobox

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1953181 Acq funds year dropdown

Returns the fiscal year to a dropdown on the Funds screen, and removes the autofilter on the Year column.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

SQL: fix typo

SQL: fix columns mismatch

Online Account Renewal - skip over update perm map

The subroutine for updating the perm map was failing and does not
appear to be necessary for an update in any of my testing so far.

The failure appears to be caused by confusion between
permission.usr_perm_map and permission.perm_list, possibly due to
the way the tables are mapped.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Quipu Online Account Renewal - Fixes for Address Validation

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - fix opac copy table layout issue

Removes excess </td> leftover from a merge, clean up code spacing

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1996651: treat empty string as null for preferred name/alias in wide_hold_data

This prevents the patron name from appearing blank in the hold shelf
"User Display Name" or "User Alias or Display Name" columns when the
alias or preferred name fields are empty strings.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>

PINES merge fix for record details page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Carousel Title Link Tweak

This corrects a problem where relative depth wasn't always working.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - replace Evergreen logo with PINES logo on staff client portal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1915440 Clear Hopeless Date on Capture

Clear the hold hopeless date when a copy is captured for the hold.

One way to make this happen for testing:

. Configure the Missing copy status as holdable=true hopeless_prone=true
. Place hold with only 1 viable copy.
. Mark said copy as missing -- this stamps a hopeless_date on the hold.
. Check the copy in.  This results in a capture + hopeless hold.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

PINES - Remove link to illustrator web site

Site no longer exists.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES - Reports interface - add class and docs links

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

SQL: add erenew changes

LP1991801 Reload page on same navigation

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

SQL: add more items to update

SQL: enable global flag for expired staff login:wq

SQL: add post-upgrade script

LP1999410 Move LI loading progress bar

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1991801 Refresh PO after activation

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1999544 Also fixes fund dropdown in PO charges

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LPXXXX Potential fix for funds dropdown upgrade bug

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

PINES customization - LMOR required fields

Updates the requiredness of fields on the Load MARC Order Records Angular page

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

Quipu Online Account Renewal - Squashed

Online Renewal - Start of working branch

- Creates placeholders for new English & Spanish pages
- Adds ability for those pages to load
- Create div on My Account main page & prefs page to hold renewal message or button
- Adds code to check whether or not patron is eligible to renew online or not:
* patron has not already had one temporary renewal
* patron account is still active
* patron account expiration date is no more than 30 days in the future
* patron account is not barred
* patron account does not have a staff-added blocking alert
* patron does not owe any fines
* patron is not in collections (even if patron pays fines, staff still need
to remove collections note)
* patron is in one of these perm groups: Patron (2), Friend (14), GLS (56),
Homebound (53), Trustee (22), Quipu (64), Digital Only (60)
* patron has a valid billing address
* patron has a valid day phone

NOTE: New standing penalty needs to be created called PATRON_TEMP_RENEWAL.
It should display a staff alert and have the label "Patron was given a 30-day temporary account renewal. Please archive this message after the account is fully renewed." It should not create any type of block on its own. The ID of
the new standing penalty needs to be updated in the Account.pm file.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add standing penalty

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal: Flesh out patron info in API

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Create new API instead of piggybacking on vital_stats

New api: open-ils.actor.user.opac.renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Create page to hold embedded form

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - First stab at adding erenew to Ecard.pm

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
even further typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
even FURTHER typo fix

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
declare the variable, and update it if needed

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
declare the variable once, then update the values

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Online Renewal - Remove old subroutines we don't use

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add page routing to EGCatLoader

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Retrieve patron then update fields to push back

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Exceptions for temp renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Fix msg declaration error

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Get URL path in a different way

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - fix typos

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Progress on writing quipu into to db

Still to do:
* Actor.pm - failing on standing penalties line 597
* sub update_addresses - creating separate addresses works if mailing & billing are different,
   but it is not checking the right checkbox
* writing new home ou is failing on terran-test, but should work on pines data
* after update, opac page doesn't refresh
* if this is a temporary (30 day) renewal, need to pass message to quipu telling patron to come to the library
* if temp renewal, need to add alert to patron account to inform staff to get proof of identity to do full renewal
* need to test voter registration survey on pines test server since I don't have that on my test server

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Show Updated Expire Date

Without this, the page loads the initial patron expiration date
and continues to show the button to renew the account.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Document which patron groups are eligible in code

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Now saving and responding okay

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
add column to permission.grp_tree to account for e-renew

Online Renewal - tweak SQL

- Parentheses on first SQL generated error.
- Set erenew default to FALSE instead of TRUE.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - See & update permission group setting through staff client

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Tweak new standing penalty

The ID of the standing penalty has to be under 100 to prevent
staff from manually adding it to patron accounts through the
client interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add Standing Penalty when Temp Renewal

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Use standing penalty names instead of IDs

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - add temp renewal flag to quipu response

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Remove perm group ID references

Look up permission groups by name or by e-renewal eligibility flag
instead of by specific permission group ID.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Got surveys working

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Progress on updating addresses

(still issues with checkmarks when changing from 1 to 2
addresses or from 2 to 1 address)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Got address changes to save in the right way

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - add date to quipu name keyword entry

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Add check for valid mailing address

Only allow renewal option if neither mailing nor billing
addresses have been marked invalid.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Cleanup

- Get rid of subroutine I didn't end up using
- Make sure a user is logged in before showing the renewal form.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Online Renewal - Prevent user from re-submitting renewal after complete

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1999270_boldPaid

Bolds the Paid indicator on line items

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1999268 PO Link to invoice should not retrieve closed invoices

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

OPAC My Lists Fix for PINES

This should clobber the old PINES customizations, apply the newer
version of the page, and re-apply a few PINES customizations.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES OPAC - Fix double heading on Current Charges page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1971745: work around issue that can cause large hold shelf lists to fail

This patch addresses an issue where hold shelf lists with
more than ~350 rows can fail to be retrieved. It works by
making the open-ils.circ.hold.wide_hash.stream method fetch
the holds from an open-ils.storage method in one fell swoop,
rather than both streaming the list from open-ils.storage and
streaming it back to the client that invoked the open-ils.circ
method.

I suspect that this is working around a subtle OpenSRF bug when
bidirectional streaming is in play, but I'm not positive.

To test
-------
[1] Set up an environment with hundreds or thousands of holds on
    a shelf at an OU.
[2] Attempt to display the holds shelf list.
[3] It may fail; if it doesn't, try with even larger number of holds
    or by setting up a test system that has ejabberd s2s going on
    to service requests.
[4] Apply the patch and repeat step 2. This time, the holds shelf
    list should be consistently retrieved. There will also be a
    user-visible change: the spinner on the AngularJS holds shelf page
    will pause for a few seconds, then start advancing.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>

add missing END tag to lists.tt2

PINES - replace missing div in patron summary bar

This line was inadvertently removed in a prior customization.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Local Admin Page - update links to Angular interfaces

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>