Galen Charlton [Tue, 15 Sep 2020 16:10:02 +0000 (12:10 -0400)]
LP#
1811710: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 3 Jan 2020 19:28:15 +0000 (14:28 -0500)]
LP#
1811710: (follow-up) fix lint issues
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Tue, 10 Sep 2019 20:29:19 +0000 (16:29 -0400)]
lp1811710: automated tests
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Fri, 16 Aug 2019 14:49:20 +0000 (10:49 -0400)]
lp1811710: hopeless holds release notes
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Sun, 30 Jun 2019 00:53:15 +0000 (20:53 -0400)]
lp1811710: minor fixes to other code
outside of the holds grid and the Hopeless Holds interface
* Retargetd vs Retargeted typo
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Tue, 11 Jun 2019 16:24:56 +0000 (12:24 -0400)]
lp1811710: hide Pre-Fetch for now
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Fri, 7 Jun 2019 14:30:53 +0000 (10:30 -0400)]
lp1811710: minor tweaks to the eg2 holds grid
column label fixes and let some actions work with multiple rows
fix for item barcode link
prevent certain actions from spawning broken interfaces
disable Title Hold Transfer if non-title holds are selected
render hold status
return the sms carrier name instead of the id in the wide_holds API
(we may want to back this one out and do it differently)
show time component for timestamp columns
fixed live summaries for various hold actions intended for large batches
remove mvr.* from eg2 holds grid; not doing anything
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Tue, 4 Jun 2019 16:12:54 +0000 (12:12 -0400)]
lp1811710: toward hopeless data
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Fri, 10 May 2019 06:52:01 +0000 (02:52 -0400)]
lp1811710: toward hopeless UI
dedicated interface and grid tweaks
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Etheridge [Wed, 17 Apr 2019 12:29:53 +0000 (08:29 -0400)]
lp1811710: toward hopeless holds, backend and existing UI's
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Jason Boyer [Tue, 15 Sep 2020 11:49:36 +0000 (07:49 -0400)]
LP#
1849212: oils_i18n_gettext fixup
Each call to oils_i18n_gettext should have a unique id per class,
this patch adjusts the call for acmr so translations (and tests)
will work correctly.
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:21:55 +0000 (21:21 -0400)]
LP#
1849212: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:18:26 +0000 (21:18 -0400)]
LP#
1849212: (follow-up) numerous fixes to open-ils.courses.detach_material
This patch ensures that when an item is taken off of reserve, any
previous item and call number values are correctly restored.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:16:30 +0000 (21:16 -0400)]
LP#
1849212: (follow-up) avoid open-ils.courses drone starvation
In particular, ensure that open-ils.courses.course_materials.retrieve.atomic
will return.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:15:03 +0000 (21:15 -0400)]
LP#
1849212: (follow-up) fix adding an item to a course with alt call number
open-ils.cat.call_number.find_or_create expects an integer to identify
the owning library, not a fieldmapper object.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:14:05 +0000 (21:14 -0400)]
LP#
1849212: (follow-up) fixes to removing users from course
* correctly extract the IDs of the user mappings to remove
* update the grid upon completion of the deletions
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:13:31 +0000 (21:13 -0400)]
LP#
1849212: (follow-up) fix edit course user dialog
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 15 Sep 2020 01:12:24 +0000 (21:12 -0400)]
LP#
1849212: (follow-up) refresh grid upon removing course material
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 11 Sep 2020 19:49:10 +0000 (12:49 -0700)]
LP1849212: don't send empty courseId arrays to pcrud
Also removes some unneeded Import calls
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jason Boyer [Fri, 11 Sep 2020 16:43:20 +0000 (12:43 -0400)]
LP1849212: Correct upgrade script
Re-align permission ids and correct syntax errors in the course reserves upgrade script.
I'm not convinced the boolean_facet metabib class should exist simply to add "course reserves, Y/N?"
and in any case can not function as is because adding metabib field classes requires additional
field_entry tables which are missing from the seed data and upgrade script.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 7 Sep 2020 20:57:41 +0000 (13:57 -0700)]
LP1849212: Workstation ou should be the default owning library for course term
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 7 Sep 2020 20:56:45 +0000 (13:56 -0700)]
LP1849212: Clarify default values in MARC simplified editor
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Thu, 3 Sep 2020 16:00:18 +0000 (09:00 -0700)]
LP1849212: OPAC course browse, search, display improvements
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 2 Sep 2020 19:32:07 +0000 (12:32 -0700)]
LP1849212: lint
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 2 Sep 2020 19:03:31 +0000 (12:03 -0700)]
LP1849212: some fixes to seed data and upgrade script
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 2 Sep 2020 15:42:29 +0000 (08:42 -0700)]
LP1849212: Use terminology: Course Name, not Course Title
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 2 Sep 2020 04:24:08 +0000 (21:24 -0700)]
LP1849212: Use a set list of roles for course users
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Tue, 1 Sep 2020 16:19:35 +0000 (09:19 -0700)]
LP1849212: improve fleshing in course service
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Tue, 1 Sep 2020 16:07:24 +0000 (09:07 -0700)]
LP1849212: update loadChildren syntax
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 26 Aug 2020 22:51:32 +0000 (15:51 -0700)]
LP1849212: Improvements to the Simplified Marc Editor
* Templates can now set multiple subfields for the same field
* Templates can now set indicator values
* Editor now allows user to choose a MARC Form and Type
* Improvements to the course associate brief record interface
to use these improvements
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 26 Aug 2020 18:30:02 +0000 (11:30 -0700)]
LP1849212: Grid improvements
- Correcting some grid column labels
- Correcting ViewChild static flags, allowing grid refresh
- Also, remove the static: false flag, since it is no longer necessary
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 26 Aug 2020 18:22:22 +0000 (11:22 -0700)]
LP1849212: Consult physical_loc to determine if an ou is using course materials module
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sat, 15 Aug 2020 15:21:46 +0000 (08:21 -0700)]
LP
1849212: Add course term functionality
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sat, 15 Aug 2020 02:56:11 +0000 (19:56 -0700)]
LP1849212: allow call number change when course is at a system or consortium level
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 14 Aug 2020 23:55:02 +0000 (16:55 -0700)]
LP1849212: display course information in catalog for record-only acmcm entries
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 10 Aug 2020 03:52:10 +0000 (20:52 -0700)]
LP1849212: release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 10 Aug 2020 03:03:26 +0000 (20:03 -0700)]
LP1849212: Improvements to course materials admin UI
- Better order for acmc fm-editor
- Add original item attributes to the course materials list
- trim whitespace from barcodes
- accessible labels in the course page
- refactor course users
- fix incorrect paths in course materials grid columns
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Sun, 9 Aug 2020 20:53:40 +0000 (13:53 -0700)]
LP1849212: Make OPAC header links consistent
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 7 Aug 2020 13:44:48 +0000 (06:44 -0700)]
LP1849212: Use ngbNav instead of deprecated ngbTabset
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 24 Jul 2020 20:16:25 +0000 (13:16 -0700)]
LP1849212: Allow users to detach all types of materials from courses
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 24 Jul 2020 05:02:35 +0000 (22:02 -0700)]
LP1849212: Course browse and search can be called without locg param in URL
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 15 Jul 2020 07:45:59 +0000 (00:45 -0700)]
LP1849212: Users can attach brief bib records and e-resources to courses
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Mon, 20 Jul 2020 04:23:06 +0000 (21:23 -0700)]
LP1849212: add sample data for course materials module
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Thu, 23 Jul 2020 14:16:43 +0000 (07:16 -0700)]
LP1849212: add missing coust to seed values
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Tue, 11 Feb 2020 20:08:57 +0000 (20:08 +0000)]
lp1849212 Course Browse
- Add Course Browse UI
- Allow browsing courses by Course Number and Title
- Add YAOUS to allow/disallow browsing by Instructor.
- Minor code cleanup
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Fri, 17 Jan 2020 04:08:48 +0000 (20:08 -0800)]
LP1859728: Course edit page fm-editor should have the update mode
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Wed, 15 Jan 2020 02:52:44 +0000 (18:52 -0800)]
LP1859728: Add missing column to course materials user table
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Tue, 14 Jan 2020 23:13:39 +0000 (15:13 -0800)]
LP1849212: Commas missing from data seed values
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Tue, 10 Dec 2019 19:03:17 +0000 (19:03 +0000)]
LP1849212: Angular Course Page improvements, OPAC course search
- Apply Course Users functionality to Angular Course Page
Admin UI.
- Condense Course User functionality into its own component,
usable as a dialog and inline.
- Condense Course Material functionality into its own component,
usable as a dialog and inline.
- Add Return to Course List button
- Move Archive Course button above tabs
- Allow Editing of Course Users and Materials
- Set datatype of is_public on Course User to 'bool' from 'boolean'
- Relabel is_public on Course User to "OPAC Viewable?"
- Undo removal of fm-editor in Course List
- Users with the MANAGE_RESERVES permission who are opted
into the course module can view a new Course Info tab on
the item record.
- Course Info tab displays a list of all courses(with link
to the Admin Course Page) item is associated with, and a
list of all instructors associated with those courses.
- Improvements to open-ils.circ.course_users.retrieve.
- Improve visuals when logged in as administrator.
- Implement Course Search OPAC page, based on Advanced Catalog
Search
- Edit Searchbar to include entry for Course Search
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Zavier Banks [Mon, 9 Dec 2019 16:52:39 +0000 (16:52 +0000)]
LP1849212 Associtate and Disassociate Course With Instructors
Creating a component that associates and disassociates instructors with
courses using the course list.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Mon, 9 Dec 2019 18:53:03 +0000 (18:53 +0000)]
lp1849212: OPAC course material circulation modifier
- View Circulation Modifier column on Course Materials
while in OPAC record view.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Changes to be committed:
modified: Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
modified: Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Fri, 6 Dec 2019 07:17:53 +0000 (07:17 +0000)]
lp1849212: Course Admin Page and OPAC improvements
- Double-clicking on a course in the Course Reserves List will
up a dedicated admin page for an individual course, featuring
tabs for Editing and managing Course Materials.
- Add bannerStyle and bannerIcon parameters to
eg-staff-banner to improve eg-staff-banner
accessability
- Improve UX of Course Page
- Properly disable inputs and buttons when course
is already archived.
- Change links in Angular Catalog to navigate the user to the
Admin Course Page.
- Prevent users from associating duplicate items to a
course.
- Remove unnecessary artifact from course page html
- Implement Course column to view Course Numbers of classes associated
with individual copies.
- Add a record column to course_module_course_materials
to improve efficiency of API and service methods.
- Add previous circ_modifier adjustments to upgrade script
- Provide Associated Course names and numbers on
OPAC Catalog search results.
- Fixed typo for User Role field, now matcheing DB column, usr_role
- Added boolean "is_public" to differentiate between a role that
should be viewable by anyone on the OPAC.
- Perl Module and Course Page displaying name and course
number of course, as well as names/roles of publicly viewable
members, course details, and a table of all materials associated
with the course.
- URL listed as eg/opac/course/[COURSE_ID]
- Ensure Shelving Location input checkbox
ticks when selecting a value.
- Ensure temporary value inputs are not
cleared when entering a new item.
- Fully select contents of Barcode input
field when selected.
- Clear bBarcode input upon hitting enter.
- Add a new tab for managing Users associated with
the course, in preparation for the User Dialog code.
- Remove excess whitespace on OPAC course page.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Mon, 25 Nov 2019 22:06:04 +0000 (22:06 +0000)]
lp1849212 Angular Catalog Course integration
- Add a column retrieving the names of courses linked to materials
when opted into the Course Reserves functionality.
- Expand the bib record summary when opted in to display all courses
associated with an item.
- Display associated courses on Search Results UI
- Move bulk of Associate Item funcitonality into Course Service
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Mon, 25 Nov 2019 20:46:53 +0000 (20:46 +0000)]
lp1849212 - Move Course Service to staff/share directory
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Changes to be committed:
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course.service.ts -> Open-ILS/src/eg2/src/app/staff/share/course.service.ts
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Mon, 25 Nov 2019 18:46:59 +0000 (18:46 +0000)]
lp1849212 Move Course Reserves to Local Admin
- Move the Course Reserves admin UI to Local Admin
instead of Server Admin
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
modified: Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.html -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-associate-material.component.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-reserves.module.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course.service.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course.service.ts
renamed: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/routing.module.ts -> Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
modified: Open-ILS/src/eg2/src/app/staff/admin/server/admin-server-splash.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/routing.module.ts
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Thu, 5 Dec 2019 20:51:34 +0000 (12:51 -0800)]
LP1849212: Fix installation issue with circ mod foreign key
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Wed, 20 Nov 2019 22:30:06 +0000 (22:30 +0000)]
lp1849212: Archive Courses
- Implement functionality to archive a course via the
admin course reserves list UI.
- Disassociate all items from a course and reinstate
their original fields if temporary fields were applied,
upon course archival.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Changes to be committed:
modified: Open-ILS/examples/fm_IDL.xml
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.html
modified: Open-ILS/src/eg2/src/app/staff/admin/server/course-reserves/course-list.component.ts
modified: Open-ILS/src/sql/Pg/040.schema.asset.sql
modified: Open-ILS/src/sql/Pg/upgrade/XXXX.schema.course-materials-module.sql
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Thu, 7 Nov 2019 18:38:04 +0000 (18:38 +0000)]
LP1849212: tidying up course reserves UIs
- Remove RowFlair and ClassCallback from Course Reserves
Grid.
- Implement dialog to view course materials associated with
a particular course in the course list admin UI.
- Implement actions to associate and disassociate materials with
a specific course.
- Optionally apply temporary Call Number, Circ Modifier, Item
Status, and Shelving Location when associating an item with a
course.
- Reapply original values of the above-mentioned fields when
disassociating an item from a course.
- Move disassociation code into Course Service.
- Automatically disassociate items and return them
to their original state when deleting a course.
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Zavier Banks [Thu, 24 Oct 2019 18:26:40 +0000 (18:26 +0000)]
LP#
1849212 Course List Ui
Added a grid component that displays the available data, specified
by the class, while also modifying the routing, so the admin splash
page links to the created component.
Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Kyle Huckins [Fri, 18 Oct 2019 18:05:57 +0000 (18:05 +0000)]
LP1849212: Course Reserves database and IDL
- Create MANAGE_RESERVES permission.
- Create IDL Object for Courses.
- Create table within asset schema for Courses, containing an id,
a name, a course number, a section number, and an owning library.
- Add IDL Class and asset table to map actor.usr and
asset.course_module_course, along with an optional
string value for the user's role in the course. If
desired, this can later be fleshed out into a separate
course role table.
- Create IDL Class & Table for Course Materials
- Create IDL Class & Table for Non-Cataloged Course Materials
- YAOUS introduced to allow opting into the Course Materials
module functionality.
- Change instances of non-cat-course_materials to non_cat_course_materials
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Mon, 14 Sep 2020 16:38:54 +0000 (12:38 -0400)]
LP#
1887196: add release notes
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Thu, 20 Aug 2020 17:55:37 +0000 (10:55 -0700)]
LP#
1887196: RemoteAuth get_patron_info should flesh home_ou
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Thu, 20 Aug 2020 17:54:34 +0000 (10:54 -0700)]
LP#
1887196: fix PatronAPI dump
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Sat, 21 Dec 2019 00:28:55 +0000 (16:28 -0800)]
LP#
1887196: RemoteAuth PatronAPI authentication
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jeff Davis [Fri, 20 Dec 2019 23:15:43 +0000 (15:15 -0800)]
LP#
1887196: RemoteAuth: add method to retrieve detailed patron info
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Mon, 14 Sep 2020 14:56:08 +0000 (10:56 -0400)]
Revert "LP1895395: Use Angular AOT compiler for ng build"
This reverts commit
2d973ca7a71409e68d567510fe764fa35d9bd799.
Jane Sandberg [Sat, 12 Sep 2020 15:22:54 +0000 (08:22 -0700)]
LP1895395: Use Angular AOT compiler for ng build
As of angular 9, the angular documentation recommends using the AOT
compiler for ng build: https://angular.io/guide/ivy
This would provide a bit more consistency for developers (since some
errors only display in AOT, others only display in JIT, and we want to
make sure that the AOT in particular is error-free so that builds don't
break).
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Mon, 14 Sep 2020 13:46:43 +0000 (09:46 -0400)]
LP#
1749475: stamp schema update
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Michele Morgan [Sun, 13 Sep 2020 03:08:32 +0000 (23:08 -0400)]
LP#
1749475: Signed off and fixed syntax error in upgrade script.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Mike Rylander [Tue, 25 Aug 2020 19:25:08 +0000 (15:25 -0400)]
LP#
1749475: Safer upgrade script
This modifies the database upgrade script to avoid overwriting the
existing templates if they have been differ from the default supplied
in the most recent seed data.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Michele Morgan [Tue, 25 Aug 2020 13:33:09 +0000 (09:33 -0400)]
LP#
1749475 Remove extra whitespace from email trigger template
Removes extra line breaks from email template output.
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Michele Morgan [Mon, 24 Aug 2020 20:34:41 +0000 (16:34 -0400)]
LP#
1749475 Alter admin page field names for clarity
To clarify for users of the admin pages, change the following labels:
Trigger Event Definition Group Configuration:
- change 'Definition ID' to 'Group ID'
Trigger Event Definition Group Member Configuration:
- change 'Definition ID' to 'ID'
- change 'Definition' to 'Event Definition'
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 3 Jan 2020 22:05:57 +0000 (17:05 -0500)]
LP#
1749475: add release notes
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Fri, 3 Jan 2020 21:52:17 +0000 (16:52 -0500)]
LP#
1749475: (follow-up) fix SendEmail's preview check
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Galen Charlton [Fri, 3 Jan 2020 20:40:46 +0000 (15:40 -0500)]
LP#
1749475: (follow-up) move admin interfaces from Local to Server
The spec called for the Event Definition Groups and Event Definition
Group Members admin interfaces to be put under Local Administration,
but the Angular local admin interfaces didn't exist when the feature
was originally submitted.
This patch also fixes "defintion" typos.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 15:50:07 +0000 (10:50 -0500)]
LP#
1749475 Make context variable more explicit
We are dealing in this area with two potential contexts: the context
of the holdings, and the context of the event to process the request.
Let's be a little more explicit by using $event_context_org rather than
$context_org for the second, and $holdings_context_org for the first.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 15:47:25 +0000 (10:47 -0500)]
LP#
1749475 Improve API variable handling
Because we are using positional arguments, but the position is off by
one due to the previous API, these arguments were difficult to assign
cleanly. This is an attempt to make it a little more legible, though
ultimately, we should strongly consider an options hash for the new
additions.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 16:08:33 +0000 (11:08 -0500)]
LP#
1749475 Improve error handling in send_event_email_output
This code was borrowed from a few other places, so it still had the
$stat variable, but wasn't doing anything with it. We might as well
go a step further and borrow the error handling that variable is there
for.
Ultimately, email handling should probably moved out to a utility
function rather than spread about.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 17:04:38 +0000 (12:04 -0500)]
LP#
1749475 Fix template typos
The word "previewing" needed correction in both preview templates.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 16:31:20 +0000 (11:31 -0500)]
LP#
1749475 Protect against missing pubdate in biblio sort
The lack of date1 data in some records was causing this code to crash,
as an attempt was made to read textContent from nothingness. Similar
to the publisher code right above, let's protect against such cases.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Dan Wells [Thu, 21 Feb 2019 15:54:06 +0000 (10:54 -0500)]
LP#
1749475 Fix thinko in form argument for sort direction
This variable is for the sort direction, so should be 'sort_dir', not
'sort_by' (which is named, in this context 'sort').
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Mike Rylander [Thu, 1 Nov 2018 21:56:09 +0000 (17:56 -0400)]
LP#
1749475: OPAC email/print record improvements
This commit provides new functionality for controlling and delivering print
and email bibliographic record export options.
Staff will be able to adjust existing and create new print and email formats
using the Action/Trigger infrastructure and the new Event Definition Group
capability.
Patrons will be able to choose from one of several formats, as configured by
staff, in which to receive one or more bibliographic records. Print and email
preview is made available for individual records via the existing links on the
record detail page, and for lists of records via new entry points on both the
Basket (anonymous list) and My Lists interfaces.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Chris Burton [Fri, 11 Sep 2020 23:00:32 +0000 (19:00 -0400)]
LP1778972 Fixing a couple issues in merge
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Sat, 12 Sep 2020 16:03:54 +0000 (09:03 -0700)]
LP#
1778972: add small clarification to bootstrap opac release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Fri, 11 Sep 2020 21:21:58 +0000 (17:21 -0400)]
LP#
1778972: (follow-up) restore locale picker to the navbar
Previous patches had moved it to account preferences, and a copy
of the picker will remain there now, but Evergreen should not
require that a user log in or set their browser locale in order
to be able to pick among supported locales.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Fri, 11 Sep 2020 20:18:10 +0000 (16:18 -0400)]
LP#
1778972: make it possible to translate the Bootstrap OPAC
This patch adds src/templates-bootstrap/opac to the i18n system, checks
in an initial POT file for the Bootstrap OPAC, and provides an example
of how to enable locales in the Apache configuration.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 16:06:04 +0000 (12:06 -0400)]
LP#
1778972: (follow-up) excise a hard-coded link to a test server
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 16:01:13 +0000 (12:01 -0400)]
LP#
1778972: tweak release notes
The release notes now emphasize that the Bootstrap OPAC
should be considered experimental for 3.6.x.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
blake [Thu, 10 Sep 2020 15:03:56 +0000 (10:03 -0500)]
LP#
1778972 OPAC Redesign
Tweaked input checkboxes to be more in-line with the label text
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 15:46:00 +0000 (11:46 -0400)]
LP#
1778972: install templates-bootstrap by default
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 15:44:58 +0000 (11:44 -0400)]
LP#
1778972: install Bootstrap skin's JS and CSS dependencies using npm
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 15:37:40 +0000 (11:37 -0400)]
LP#
1778972: remove checked-in dependencies; we'll grab them via npm
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 14:29:57 +0000 (10:29 -0400)]
LP#
1778972: add a couple more aria-hidden
This implements part of Owen Leonard's previous patch that
couldn't readily survive some merge conflict resolution.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Galen Charlton [Thu, 10 Sep 2020 14:28:46 +0000 (10:28 -0400)]
LP#
1778972: convert DOS newlines in charges.tt2 to Unix
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Owen Leonard [Tue, 8 Sep 2020 16:29:58 +0000 (12:29 -0400)]
LP#
1778972: Tweaks and fixes to Bootstrap 4 template
- Add "aria-hidden" to Font Awesome icons as recommended by Font Awesome for accessibility.
- Minor changes to the color scheme.
- Some adjustments to the way alignment is defined: Bootstrap 4 classes like "text-center"
can be an impediment to customization because they use "!important." I've removed many
instances of such classes in favor of putting alignment in CSS.
- Ajustments to responsive behavior. I've made some changes to grid class definitions
to improve flexibility of layouts at various browser widths.
- Whitespace and other typo corrections. I've worked to remove trailing whitespace and
replace tabs with spaces.
Signed-of-by: Owen Leonard <zivot@zivotdesign.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Chris Burton [Fri, 17 Jul 2020 00:52:42 +0000 (20:52 -0400)]
LP1778972 A slew of updates
Including fixes to ensure pages are valid and an entire reimagining of
the My Account interface
Also brings everything up to a more visible area and adds FontAwesome5
Iconography
Bookbag Action Fix and minor other misc
Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Chris Burton [Fri, 17 Jul 2020 00:38:12 +0000 (20:38 -0400)]
LP#
1778972: Localizing dependencies
Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Tue, 30 Jun 2020 00:41:45 +0000 (17:41 -0700)]
LP#
1778972: (follow-up) use OILSWebTemplatePath to enable/disable the bootstrap OPAC
This commit also renames the directory that contains the bootstrap-based OPAC. With
the OILSWebTemplatePath, several redundant files also can be safely removed.
Adds a release notes entry describing how to enable this OPAC in eg_vhosts.conf.
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Mon, 29 Jun 2020 20:32:20 +0000 (16:32 -0400)]
LP#
1778972: (follow-up) remove a NFPL-specific template
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Chris Burton [Mon, 29 Jun 2020 14:51:51 +0000 (10:51 -0400)]
LP#
1778972: OPAC Redesign
To test
-------
Rename opac to opac-old and opac-new to opac, replacing the framework
while keeping the old one as backup.
Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Ruth Frasur <rfrasur@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>