evergreen/pines.git
5 years agoLP1830923 Marc edit in-place additions
Bill Erickson [Thu, 17 Oct 2019 21:57:10 +0000 (17:57 -0400)]
LP1830923 Marc edit in-place additions

Improve Angular MARC editor for in-place editing.

* Make inPlaceMode a proper @Input.
* Allow the caller to pass in the bib source
* The recordSaved event now reports both the MARC XML and the currently
  selected bib source.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1830923 Combobox LP1844812 regression fix
Bill Erickson [Thu, 17 Oct 2019 21:44:40 +0000 (17:44 -0400)]
LP1830923 Combobox LP1844812 regression fix

Allow a combobox to start with an empty array that is later filled by
the caller.  This was broken due to changes which prevented the combobox
from seeing an empty/stub array as being different from its
initialization array, thus ignoring empty array as a duplicate.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoDocs: corrected image file reference in carousels.adoc
Andrea Buntz Neiman [Fri, 6 Dec 2019 14:50:10 +0000 (09:50 -0500)]
Docs: corrected image file reference in carousels.adoc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoDocs: follow up commit to fix include error
Andrea Buntz Neiman [Thu, 5 Dec 2019 21:07:20 +0000 (16:07 -0500)]
Docs: follow up commit to fix include error

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoDocs: adding Carousels docs and screenshots
Felicia Beaudry [Thu, 5 Dec 2019 20:35:50 +0000 (15:35 -0500)]
Docs: adding Carousels docs and screenshots

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoLP1850955: Include changes to package-lock.json
Jason Boyer [Wed, 27 Nov 2019 13:42:27 +0000 (08:42 -0500)]
LP1850955: Include changes to package-lock.json

The package-lock.json file is necessarily changed
by dropping some dependencies. As long as we track
it, it may as well be updated.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1850955 Remove PhantomJS polyfills
Bill Erickson [Fri, 1 Nov 2019 16:22:33 +0000 (12:22 -0400)]
LP1850955 Remove PhantomJS polyfills

Remove additional polyfills that were required specifically for
PhantomJS, which we no longer use.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP1850955 Angular build targets modernized
Bill Erickson [Fri, 1 Nov 2019 16:18:00 +0000 (12:18 -0400)]
LP1850955 Angular build targets modernized

Apply a specific set of browsers to guide the Angular / Typescript
compilers toward a more modern set of default browsers.  This reduces
the amount of compilation and browser files required.

Bump the ES version used by Typescript from ES5 to ES6.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
5 years agoLP#1849208 - Add PostgreSQL 10 Makfile.install targets
Chris Sharp [Tue, 22 Oct 2019 13:21:22 +0000 (09:21 -0400)]
LP#1849208 - Add PostgreSQL 10 Makfile.install targets

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1607922: Receiving items on page 2 of search results
Jane Sandberg [Tue, 30 Jul 2019 20:54:10 +0000 (13:54 -0700)]
LP1607922: Receiving items on page 2 of search results

Previously, if a user selected a bunch of line items on two consecutive
pages of acq search results, and tried to receive items from the second
page, the operation would fail.

This issue was caused by Evergreen caching IDs of selected line items
from page 1, but not caching the data that went along with them.

To test:

1) Go to Acquisitions > General Search
2) In the Select Search Field dropdown, choose LI - State.
3) Set the state to on-order.
4) Click Search.
5) Click the check mark to select all results on the first page.
6) Click the Next button.
7) Click the check mark to select all results on the second page.
8) On the top --Actions-- menu, select Mark Selected Line Items as
Received.
9) Note that the interface does nothing, and that there is a TypeError
error message in the browser console.
10) Apply this commit.
11) Refresh your page completely and repeat steps 1-8.
12) Note that the items on the second page are received.  Since they no
longer meet the search criteria, Evergreen gives you the next page of
results.

For further testing, see similar test steps by John Yorio at
https://bugs.launchpad.net/evergreen/+bug/1607922.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1851831 Group perm editor null descriptions OK
Bill Erickson [Fri, 8 Nov 2019 15:37:21 +0000 (10:37 -0500)]
LP1851831 Group perm editor null descriptions OK

Avoid assuming a permission description value is non-NULL in the
permission group editor interfaces since values are not required in the
database.

Fixes: ERROR TypeError: "l.description(...) is null"

Similarly repair the permission list title attributes so they display
the permission code (instead of an empty string) for titles when no
description is available.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agolp1437103 Allow Receipts to Print when Suppressing Popups
Kyle Huckins [Fri, 5 Jul 2019 14:36:05 +0000 (14:36 +0000)]
lp1437103 Allow Receipts to Print when Suppressing Popups

- Move suppress_popup check further along and allow transit receipts
to properly print when popups suppressed.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agolp1437103 Suppress Popups on Patron Items Out Checkin
Kyle Huckins [Wed, 26 Jun 2019 15:36:09 +0000 (15:36 +0000)]
lp1437103 Suppress Popups on Patron Items Out Checkin

- Make Patron Items Out UI respect Suppress Popups setting.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/items_out.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agolp1437103 - Suppress Popups based on OU Setting
Kyle Huckins [Tue, 25 Jun 2019 16:47:04 +0000 (16:47 +0000)]
lp1437103 - Suppress Popups based on OU Setting

- Allow OU setting to suppress checkin popups to properly take effect.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/services/circ.js

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoForward-port 3.3.5 upgrade script
Dan Wells [Tue, 29 Oct 2019 19:39:46 +0000 (15:39 -0400)]
Forward-port 3.3.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoForward-port 3.2.10 upgrade script
Dan Wells [Tue, 29 Oct 2019 19:38:39 +0000 (15:38 -0400)]
Forward-port 3.2.10 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoForward-port 3.1.16 upgrade script
Dan Wells [Tue, 29 Oct 2019 19:37:17 +0000 (15:37 -0400)]
Forward-port 3.1.16 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
5 years agoForward port 3.2.8 to 3.2.9 db upgrade script
Jason Stephenson [Wed, 18 Sep 2019 23:16:50 +0000 (19:16 -0400)]
Forward port 3.2.8 to 3.2.9 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoForward port 3.1.14 to 3.1.15 db upgrade script
Jason Stephenson [Thu, 19 Sep 2019 12:46:12 +0000 (08:46 -0400)]
Forward port 3.1.14 to 3.1.15 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>
5 years agoDocs: LP1849137 follow-up: add release note
Jane Sandberg [Tue, 29 Oct 2019 19:37:28 +0000 (12:37 -0700)]
Docs: LP1849137 follow-up: add release note

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1849137 Patron View hide OPAC header
Bill Erickson [Tue, 29 Oct 2019 18:25:42 +0000 (14:25 -0400)]
LP1849137 Patron View hide OPAC header

Hide the TPAC header (nav links, My Account, etc.) when displaying the
embedded read-only record detail view in the staff catalog Patron View
tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1849137 Catalog Patron View loading icon
Bill Erickson [Tue, 29 Oct 2019 17:54:26 +0000 (13:54 -0400)]
LP1849137 Catalog Patron View loading icon

Display the usual loading circle icon while the embedded patron view
iframe is loading.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1849137 Catalog Patron View embedding improvements
Bill Erickson [Tue, 29 Oct 2019 16:00:25 +0000 (12:00 -0400)]
LP1849137 Catalog Patron View embedding improvements

Adds a readonly record detail view to the OPAC.  This is used by the
Angular catalog Patron View tab to present a version of the OPAC where
all links, buttons, and inputs are disabled.

Dynamically style the height of the embedded iframe to prevent nested
scroll bars in the Patron View.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1849137 Staff catalog Patron View tab
Bill Erickson [Mon, 21 Oct 2019 14:41:15 +0000 (10:41 -0400)]
LP1849137 Staff catalog Patron View tab

Adds a tab to the Angular staff catalog record detail page which
displays an embedded display of the patron OPAC view of the record
detail page.  This replaces the View In Catalog button.

The iframe is not linked or tied into the parent Angular app in any way.
It's just an iframe with a source.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agoLP1830973 Angular 8 org family test spec repair
Bill Erickson [Tue, 22 Oct 2019 17:52:56 +0000 (13:52 -0400)]
LP1830973 Angular 8 org family test spec repair

The test runner does not like that the test expectations are wrapped in
the fixture.whenStable promise.  It reports an error, since no
expectations occur in line with the test:

ERROR: 'Spec 'Component: OrgFamilySelect allows user to turn off
includeDescendants checkbox' has no expectations.'

As the whenStable checks do not appear to be necessary, simply removing
them resolves the issue and allows the tests to succeed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
5 years agoStamp upgrade script for LP 1849152
Jason Boyer [Wed, 23 Oct 2019 16:01:15 +0000 (12:01 -0400)]
Stamp upgrade script for LP 1849152

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
5 years agoloading custom css from library setting
Rogan Hamby [Mon, 21 Oct 2019 16:02:24 +0000 (12:02 -0400)]
loading custom css from library setting

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
5 years agoLP1845693: Test Angular(JS) with modern browsers
Jason Boyer [Tue, 22 Oct 2019 16:51:15 +0000 (12:51 -0400)]
LP1845693: Test Angular(JS) with modern browsers

Rather than using PhantomJS to test Angular(JS),
we can use all supported browsers for the web client.
Currently this is Firefox and Chrom(ium).

Because of the number of dependencies this also
requires that testing is removed from the standard
build instructions and only done in specific testing
environments or on developer machines.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1830973 Remove no longer needed navbar margin mods
Bill Erickson [Mon, 21 Oct 2019 17:38:46 +0000 (13:38 -0400)]
LP1830973 Remove no longer needed navbar margin mods

Angular 8 and dependency changes render some existing nav bar padding no
longer necessary.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1830973 Angular8 lint repair
Bill Erickson [Mon, 21 Oct 2019 17:25:42 +0000 (13:25 -0400)]
LP1830973 Angular8 lint repair

Avoid lint warning:

"In the class "NotBeforeMomentValidatorDirective", the directive input
property "egNotBeforeMoment" should not be renamed."

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1830973 Angular 8 updates
Bill Erickson [Mon, 21 Oct 2019 15:18:29 +0000 (11:18 -0400)]
LP1830973 Angular 8 updates

Update package.json versions and perform the angular 7 to angular 8
migration steps.

Update some configs to match supported options in newer versions of
typescript and tslint.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1830973 Angular reversioning script
Bill Erickson [Mon, 5 Aug 2019 21:58:41 +0000 (17:58 -0400)]
LP1830973 Angular reversioning script

Script for rebuilding the dependencies for the Angular app.  This is
useful both for major Angular upgrades or just for simply refreshing the
deps on the current version to ensure everything is up to date, but not
so up to date is breaks Angular compatibility.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1830973 Node install v12.6.0
Bill Erickson [Mon, 8 Jul 2019 16:28:17 +0000 (12:28 -0400)]
LP1830973 Node install v12.6.0

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1830973 Deps installer uses Angular 8
Bill Erickson [Mon, 8 Jul 2019 15:08:20 +0000 (11:08 -0400)]
LP1830973 Deps installer uses Angular 8

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1802952: stamp schema update
Galen Charlton [Mon, 21 Oct 2019 18:08:39 +0000 (14:08 -0400)]
LP#1802952: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1657171 - Adding upgrade script
Chris Sharp [Mon, 21 Oct 2019 13:44:27 +0000 (09:44 -0400)]
LP#1657171 - Adding upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1657171 - Normalize right and left single and double quotes
Michele Morgan [Fri, 12 Oct 2018 20:01:40 +0000 (16:01 -0400)]
LP#1657171 - Normalize right and left single and double quotes

Changes search_normalize and naco_normalize to replace right and left
leaning single quotes with U+0027, double quotes with U=0022

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP 985957 Prevent hold activation date being in the past
Suzanne Paterno [Tue, 6 Aug 2019 14:25:05 +0000 (10:25 -0400)]
LP 985957 Prevent hold activation date being in the past

Created a new JS function isValidDate. Checks that the date is in the future, is a valid date within the month/year given. Also makes sure the date is in the proper format D/m/Y.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
5 years agoLP#1778606 Web Client - Place Hold Requires Two Clicks on Submit
Dan Briem [Fri, 4 Oct 2019 14:57:06 +0000 (10:57 -0400)]
LP#1778606 Web Client - Place Hold Requires Two Clicks on Submit

Issue: the barcode lookup runs on the input's onchange, onkeypress (Enter), &
disables the submit button until the patron loads. So, if you type a barcode,
click enter, click the submit button, mousedown fires, if focus was still the
barcode input, its onchange fires, the lookup runs again, the submit button
disables, prevents button mouseup from firing, the click event is disrupted, &
the form doesn't submit. Click again & it works.

Instead of onchange & onkeypress this branch runs the lookup when there's a
500ms pause between onkeydowns. onpaste and enter still run the lookup
immediately. The patron search triggers the input's keydown instead of change.

To test:
1. Search for any holdable item in the catalog and click Place Hold
2. Type in an existing patron barcode and click Enter
3. Before tabbing or clicking off the barcode input, click the Submit button
4. Note it doesn't submit - click again and it submits
5. Apply patch
6. Repeat steps 1-3
7. Note it submits

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
5 years agoLP#1555791: add release notes entry
Galen Charlton [Fri, 18 Oct 2019 15:05:47 +0000 (11:05 -0400)]
LP#1555791: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1555791 - Hide Print List from checkout screen
Josh Stompro [Fri, 13 Sep 2019 20:02:36 +0000 (15:02 -0500)]
LP#1555791 - Hide Print List from checkout screen

Hide the print list button from the checkout screen so customers
don't learn to use that instead of logout.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoforward-port 3.3.3-3.4.0 schema update
Galen Charlton [Wed, 2 Oct 2019 21:28:11 +0000 (17:28 -0400)]
forward-port 3.3.3-3.4.0 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agolp1890498: Replace Item Barcode now warns about duplicate barcode
Mike Risher [Wed, 5 Aug 2020 21:34:12 +0000 (21:34 +0000)]
lp1890498: Replace Item Barcode now warns about duplicate barcode

Modify the Replace Item Barcode page so that it displays an error
message when trying to replace a barcode with a barcode already
in use.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1845241: Use the correct API call to Undelete a bib record
Jane Sandberg [Sun, 8 Mar 2020 14:58:09 +0000 (07:58 -0700)]
LP1845241: Use the correct API call to Undelete a bib record

To test:

1) Open up a delete-ready bibliographic record in the Web client
(no attached holdings, no located URI, no open orders attached, etc.)
2) Delete it.
3) Undelete it.  Note that the "Undelete" button briefly turns into a
"Delete" button before changing back to an "Undelete" button.  Note that
the bib record does not show up in search results within the Web client.
4) Apply this commit.
5) Now try undeleting the record again.  Notice that the "Delete" button
does not revert to an "Undelete" button.  Note also that the record is
once again showing up in search results (although you may have to be a
bit creative using search terms, due to search results caching).

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: blake <blake@mobiusconsortium.org>
5 years agoPINES Staff Client Splash Page Updates
Terran McCanna [Thu, 18 Jun 2020 17:58:31 +0000 (13:58 -0400)]
PINES Staff Client Splash Page Updates

Update MARC batch import/export link, update http to https.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoup the hard-coded value for the record query limit in record bucket UI
Chris Sharp [Thu, 18 Jun 2020 17:19:34 +0000 (13:19 -0400)]
up the hard-coded value for the record query limit in record bucket UI

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1848550 Cache org settings in IndexedDB (Angular)
Bill Erickson [Mon, 2 Dec 2019 17:26:22 +0000 (12:26 -0500)]
LP1848550 Cache org settings in IndexedDB (Angular)

Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.

Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1848550 / LP1835128 Redirect to AngJS splash page
Bill Erickson [Thu, 26 Dec 2019 17:17:55 +0000 (12:17 -0500)]
LP1848550 / LP1835128 Redirect to AngJS splash page

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1848550 Cache org settings in IndexedDB (Angular)
Bill Erickson [Mon, 2 Dec 2019 17:26:22 +0000 (12:26 -0500)]
LP1848550 Cache org settings in IndexedDB (Angular)

Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.

Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP1854850 Angular IndexedDB Shared Worker Communication
Bill Erickson [Mon, 2 Dec 2019 17:26:08 +0000 (12:26 -0500)]
LP1854850 Angular IndexedDB Shared Worker Communication

Implements the client side of the communication to the Evergreen
IndexedDB shared worker for Angular.

From this may be built caching mechanisms, offline transaction
handling, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoLP#1848550: client-side caching of org settings for AngularJS
Jeff Davis [Wed, 27 Nov 2019 00:12:37 +0000 (16:12 -0800)]
LP#1848550: client-side caching of org settings for AngularJS

The web client almost always does live lookups any time it needs to
check an org setting.  But these settings rarely change, so it would
make sense to cache them.  They're already cached using Lovefield in
order to support offline; this commit checks the cache first, and only
does a live lookup if the setting is uncached.

The settings cache is cleared on login to ensure stale values don't
stick around forever.  To refresh the cache, simply logout and then
login; cached values will be deleted and the latest values will be
retrieved from the server when they are needed.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agolp 1844365 patron edit page stat cat persisting old data
Mike Risher [Mon, 24 Feb 2020 23:05:25 +0000 (23:05 +0000)]
lp 1844365 patron edit page stat cat persisting old data

Fix the bug on the patron edit page where old stat cat data is
persisting when one does a new patron search and loads a patron
with no stat cats.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/app.js

5 years agouse old floating groups interface until new one is available - fix typo 2
Chris Sharp [Tue, 4 Feb 2020 17:11:33 +0000 (12:11 -0500)]
use old floating groups interface until new one is available - fix typo 2

5 years agouse old floating groups interface until new one is available - fix typo
Chris Sharp [Tue, 4 Feb 2020 17:08:10 +0000 (12:08 -0500)]
use old floating groups interface until new one is available - fix typo

5 years agouse old floating groups interface until new one is available
Chris Sharp [Tue, 4 Feb 2020 17:00:02 +0000 (12:00 -0500)]
use old floating groups interface until new one is available

5 years agoLP#1842297: Allow for login redirect with hostname
oajulianclementson [Fri, 31 Jan 2020 22:51:35 +0000 (22:51 +0000)]
LP#1842297: Allow for login redirect with hostname

5 years agoPINES Customization: Help Links on OPAC Login Page
Terran McCanna [Sun, 19 Jan 2020 16:35:10 +0000 (11:35 -0500)]
PINES Customization: Help Links on OPAC Login Page

Updated FAQ & Library Locator Links

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES Customization for My Account Holds List
Terran McCanna [Sun, 19 Jan 2020 16:44:51 +0000 (11:44 -0500)]
PINES Customization for My Account Holds List

Expand Notes column header to cover the Edit column as well as the
Notes column so it doesn't look unbalanced.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES Customization: Re-display Booking
Terran McCanna [Mon, 29 Jul 2019 19:33:48 +0000 (15:33 -0400)]
PINES Customization: Re-display Booking

Booking module was previously hidden from the main navigation menu
because PINES wasn't using it. Re-display it now so that it can
be used.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoadditions to post-upgrade script
Chris Sharp [Tue, 14 Jan 2020 18:10:48 +0000 (13:10 -0500)]
additions to post-upgrade script

5 years agoremoving hopeless holds changes from post-upgrade script
Chris Sharp [Tue, 14 Jan 2020 15:50:49 +0000 (10:50 -0500)]
removing hopeless holds changes from post-upgrade script

5 years agoPINES Customization for Carousels
Terran McCanna [Tue, 26 Nov 2019 15:51:50 +0000 (10:51 -0500)]
PINES Customization for Carousels

Added carousels in the 3.4.1 upgrade January 2020.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoLP1781274 Fix floating point issue preventing transactions from closing
Michele Morgan [Fri, 20 Dec 2019 21:00:08 +0000 (16:00 -0500)]
LP1781274 Fix floating point issue preventing transactions from closing

Limits pending payment amounts to 2 decimal places.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
5 years agoPINES Customization: Specific Due Date Box
Terran McCanna [Fri, 10 Jan 2020 16:01:57 +0000 (11:01 -0500)]
PINES Customization: Specific Due Date Box

This widens the specific due date box on the patron checkout
screen so that the full date is visible. This will probably
be fixed in master at some point, but fixing it locally
for the time being.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agofixing marc editing locally
Chris Sharp [Fri, 10 Jan 2020 16:08:57 +0000 (11:08 -0500)]
fixing marc editing locally

5 years agoadding openathens tasks to post-upgrade script
Chris Sharp [Fri, 10 Jan 2020 15:27:24 +0000 (10:27 -0500)]
adding openathens tasks to post-upgrade script

5 years agoremove old scripts, combine new features into post-upgrade script
Chris Sharp [Thu, 9 Jan 2020 21:46:19 +0000 (16:46 -0500)]
remove old scripts, combine new features into post-upgrade script

5 years agoremove unnecessary tasks
Chris Sharp [Thu, 9 Jan 2020 21:23:42 +0000 (16:23 -0500)]
remove unnecessary tasks

5 years agoadding ILL circulation modifier
Chris Sharp [Thu, 9 Jan 2020 16:47:33 +0000 (11:47 -0500)]
adding ILL circulation modifier

5 years agoLP#1842297: Fix - finds org parent reliably
oajulianclementson [Tue, 7 Jan 2020 17:14:17 +0000 (17:14 +0000)]
LP#1842297: Fix - finds org parent reliably

5 years agoLP#1842297: Implements patron sign-on to the OpenAthens service.
Julian Clementson [Tue, 1 Oct 2019 15:17:53 +0000 (16:17 +0100)]
LP#1842297: Implements patron sign-on to the OpenAthens service.

Allows global or local administrators to configure a connection to the
OpenAthens cloud-based single sign-on service. Allows patrons to connect
seamlessly to third party resources that use OpenAthens authentication.
For more detailed feature description visit
https://wiki.evergreen-ils.org/doku.php?id=dev%3Aproposal%3Aopenathens_integration

Signed-off-by: Julian Clementson <julian.clementson@openathens.net>
5 years agoLP1857350 Org selector sorts by display value
Bill Erickson [Thu, 26 Dec 2019 18:18:26 +0000 (13:18 -0500)]
LP1857350 Org selector sorts by display value

When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).

Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
5 years agoPINES Fix to custom holdings list
Terran McCanna [Thu, 26 Dec 2019 18:12:09 +0000 (13:12 -0500)]
PINES Fix to custom holdings list

Corrects system name not showing up on record detail screen in
holdings copy table. Also adds system name to the linked up library
info page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoLP#1843599: AngularJS MARC editor once again sets bib source
Galen Charlton [Fri, 20 Dec 2019 17:40:34 +0000 (12:40 -0500)]
LP#1843599: AngularJS MARC editor once again sets bib source

This patch fixes a regression introduced by the patch for bug 1693580
that prevent changes to the bib source from being made via the AngularJS
MARC editor.

To test
-------
[1] Apply the patch.
[2] Create a new bib record and save it with a non-empty source. Verify
    that the record sets the source as expected.
[3] Edit a bib record and change the source. Verify that the new source
    is retained when the record is saved.
[4] Edit an authority record and save it. Verify that it can be updated
    without error. (Note that authority records do not have sources in
    the same way that bib records do.)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoPINES Hide Print and Email Options on Lists
Terran McCanna [Thu, 26 Dec 2019 18:51:41 +0000 (13:51 -0500)]
PINES Hide Print and Email Options on Lists

The print & email options on lists in the OPAC are currently
broken (launchpad bug 1854986) - hide them until fixed.

Also includes a couple minor adjustments to spacing.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agolp1712644 Prevent check out due date in past
Katlyn Beck [Mon, 26 Nov 2018 21:23:48 +0000 (21:23 +0000)]
lp1712644 Prevent check out due date in past

- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/circ/patron/t_checkout.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/checkout.js
modified:   Open-ILS/web/js/ui/default/staff/services/ui.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES - indent popularity line on search results page
Terran McCanna [Mon, 30 Dec 2019 20:39:52 +0000 (15:39 -0500)]
PINES - indent popularity line on search results page

We recently enabled popularity ranking visibility in the OPAC,
but it isn't indented with the rest of the item info. This adds
the indent and un-does the bolding since it is distracting.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES Self-check Customization
Terran McCanna [Thu, 19 Dec 2019 19:25:53 +0000 (14:25 -0500)]
PINES Self-check Customization

New PINES logo and matching color scheme

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoCustomization of self-check interface so that username, password,
Terran McCanna [Thu, 17 Oct 2019 18:22:37 +0000 (14:22 -0400)]
Customization of self-check interface so that username, password,
and barcode text banners appear in different colors in an effort
to make it clearer to patrons that they are being asked for a
different type of information.

Note that that this also tweaks the password check because the old
format was different from current master and no longer working correctly.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES KPAC: New logo
Terran McCanna [Thu, 19 Dec 2019 19:57:20 +0000 (14:57 -0500)]
PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES logo and color scheme changes
Terran McCanna [Thu, 12 Dec 2019 22:32:45 +0000 (17:32 -0500)]
PINES logo and color scheme changes

For January 2020 upgrade

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoPINES Staff Client Logo Update
Terran McCanna [Mon, 9 Dec 2019 17:25:07 +0000 (12:25 -0500)]
PINES Staff Client Logo Update

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoAdd new PINES logo.
Chris Sharp [Mon, 9 Dec 2019 16:53:49 +0000 (11:53 -0500)]
Add new PINES logo.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder
Chris Sharp [Fri, 4 Oct 2019 18:31:22 +0000 (14:31 -0400)]
LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder

Let's give end users a break and forgive them when they mix
up the order of a date range.  BETWEEN SYMMETRIC allows users
to enter a date range in any order rather than strictly
enforcing "oldest date first" and returning an empty result
set.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1849334 - Protect precat volumes from accidental staff edits
Chris Sharp [Fri, 22 Nov 2019 20:18:57 +0000 (15:18 -0500)]
LP#1849334 - Protect precat volumes from accidental staff edits

It is possible to edit the precat volume (id = -1) in a batch
volume/copy edit in the webclient.  We assume that valid changeable
volumes have an id > 0, then allow changes.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoadding post-3.4 upgrade script
Chris Sharp [Fri, 22 Nov 2019 16:16:05 +0000 (11:16 -0500)]
adding post-3.4 upgrade script

5 years agoremoving legacy upgrade script
Chris Sharp [Fri, 22 Nov 2019 16:15:05 +0000 (11:15 -0500)]
removing legacy upgrade script

5 years agoLP#1822630: fix sanitizing CGI params on place_hold_result
Jeff Davis [Mon, 10 Jun 2019 16:53:44 +0000 (09:53 -0700)]
LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
(cherry picked from commit 019118895c94f5cc810b3f1fb95b2634a1c993b6)

5 years agoRevert "Temp fix for Broken Hold Links"
Chris Sharp [Fri, 8 Nov 2019 19:02:20 +0000 (14:02 -0500)]
Revert "Temp fix for Broken Hold Links"

This reverts commit d8722f1c7a5b76f965e59ffbf20342a4c48bbeb0.

5 years agoLP#1851524: fix adding a bucket when saving a new carousel
Galen Charlton [Wed, 6 Nov 2019 16:35:58 +0000 (11:35 -0500)]
LP#1851524: fix adding a bucket when saving a new carousel

This patch fixes a regression where saving a new carousel
would not result in its bucket being created due to the
post-save callback never getting invoked.

This patch does not fix any carousels that do not have
buckets due to this bug. Because such carousels will
not function anyway, they should be deleted and
recreated by the local admin.

To test
-------
[1] Create a new carousel in local adminstration. Open it
    in the edit modal again and note that no record bucket
    is linked to it.
[2] Apply the patch and repeat step 1. This time, the
    bucket should be created.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agodisable trigger USER, not ALL
Chris Sharp [Thu, 31 Oct 2019 17:53:06 +0000 (13:53 -0400)]
disable trigger USER, not ALL

5 years agoupdate 3.3-3.4 upgrade script with PINES customizations and speed improvements
Chris Sharp [Thu, 31 Oct 2019 17:50:07 +0000 (13:50 -0400)]
update 3.3-3.4 upgrade script with PINES customizations and speed improvements

5 years agoLP#1570072: add release notes
Galen Charlton [Thu, 8 Aug 2019 00:08:25 +0000 (20:08 -0400)]
LP#1570072: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1570072: update hold notification methods upon preference changes
Cesar Velez [Tue, 22 Jan 2019 17:16:54 +0000 (12:16 -0500)]
LP#1570072: update hold notification methods upon preference changes

This patch adds a feature where if a patron's hold notification
preferences are changed, they are given an opportunity to have
notfication methods for their pending hold requests updated to
reflect their new prefernces.

This feature affects both the public catalog My Account interface
and the staff patron registration form. In both cases, the user
is presented with a modal (staff-side) or interstitial page (public
catalog) asking them whether to update current hold requests.

Sponsored-by: MassLNC
Additional-work-by: Mike Rylander <mrylander@gmail.com>
Additional-work-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoupdate DB upgrade scripts to accommodate what we have already applied
Chris Sharp [Wed, 25 Sep 2019 11:38:50 +0000 (07:38 -0400)]
update DB upgrade scripts to accommodate what we have already applied

6 years agoRemove "In Receiving" status from magical status list
Chris Sharp [Tue, 20 Aug 2019 11:11:41 +0000 (07:11 -0400)]
Remove "In Receiving" status from magical status list

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
6 years agoAdding 'In Receiving' status to back-end functionality.
Chris Sharp [Fri, 2 Aug 2019 15:15:09 +0000 (11:15 -0400)]
Adding 'In Receiving' status to back-end functionality.

6 years agoKPAC Updates: Add E-Read Kids
Terran McCanna [Wed, 31 Jul 2019 20:46:45 +0000 (16:46 -0400)]
KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
6 years agoPINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED
Terran McCanna [Mon, 29 Jul 2019 14:37:41 +0000 (10:37 -0400)]
PINES Customization: Alter wording for COPY_CIRC_NOT_ALLOWED

Change wording of COPY_CIRC_NOT_ALLOWED message because the default
wording indicates that it is a problem with the copy, but it can
also be triggered when there is a problem with the user (such as when
a Digital Only user attempts to check out a physical item).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
6 years agoLP#1713138 EDI buyer codes from RFF+API
Bill Erickson [Fri, 25 Aug 2017 19:46:31 +0000 (15:46 -0400)]
LP#1713138 EDI buyer codes from RFF+API

Support extracting buyer code (AKE edi_account.vendcode) values directly
from the EDI RFF+API field.  This provides better matching to
edi_accounts based on vendcode values for inbound EDI messages.

The code will still fall back to extracting vendcodes appended to the SAN,
when no RFF+API is present.

Signed-off-by: Bill Erickson <berickxx@gmail.com>