evergreen/pines.git
5 years agoSelfcheck Cookie Path
Thomas Berezansky [Tue, 22 Dec 2015 18:11:47 +0000 (13:11 -0500)]
Selfcheck Cookie Path

Change base.xul/base.js to support a "cookie path" option to limit what paths
will use the login cookie, then tell the selfcheck interface to use it.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoAdditional changes to the self-check interface.
Terran McCanna [Mon, 21 Dec 2015 20:08:00 +0000 (15:08 -0500)]
Additional changes to the self-check interface.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoImages for new "no image available" functionality.
Terran McCanna [Mon, 21 Dec 2015 21:21:47 +0000 (16:21 -0500)]
Images for new "no image available" functionality.

Lines 94-104 in eg_vhost.conf need to be un-commented.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoThese are modifications to the Evergreen self-check interface to:
Terran McCanna [Thu, 17 Dec 2015 23:24:34 +0000 (18:24 -0500)]
These are modifications to the Evergreen self-check interface to:

1. Fix bugs with printing holds and fines.
2. Improve page layout overall, and with consideration for
   1024x768 resolution monitors that a lot of libraries use.
3. Hide hold status from view on holds table.
4. Hide buttons/fields from screen when user is not logged in.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/circ/selfcheck/banner.tt2

5 years agoChange links old library map to new interactive library locator map.
Terran McCanna [Thu, 10 Sep 2015 19:23:42 +0000 (15:23 -0400)]
Change links old library map to new interactive library locator map.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoEnabled Google Analytics for OPAC usage tracking.
Terran McCanna [Mon, 31 Aug 2015 18:53:12 +0000 (14:53 -0400)]
Enabled Google Analytics for OPAC usage tracking.

5 years agobranding the built-in selfcheck interface for PINES
Chris Sharp [Wed, 1 Apr 2015 17:16:03 +0000 (13:16 -0400)]
branding the built-in selfcheck interface for PINES

5 years agoMake users_of_interest test for defined actor.usr.card values
Michael Peters [Thu, 20 Nov 2014 22:41:44 +0000 (17:41 -0500)]
Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Collections.pm

5 years agoRemoving "Bib Call Number" from the advanced numeric search options.
Chris Sharp [Tue, 26 Nov 2013 16:35:43 +0000 (11:35 -0500)]
Removing "Bib Call Number" from the advanced numeric search options.

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

5 years agoAllowing unfillable hold placement in the staff client, not the OPAC
Chris Sharp [Fri, 22 Nov 2013 15:18:58 +0000 (10:18 -0500)]
Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

5 years agoKPAC squashed
Terran McCanna [Tue, 24 Sep 2013 18:51:21 +0000 (14:51 -0400)]
KPAC squashed

This combines multiple KPAC customizations into a single commit.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Updated dewey.tt2

PINES customization of KPAC - beta ready for testing

Removing "kpac-original" directory in order to keep a clean source directory.

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Testing modifications to navigation.

Further tweaks to search limits and modifications to book bag links.

Small changes to Search Limit names and Category names.

Correcting file path for PINES logo on KPAC.

PINES KPAC landing page doesn't include the Print button.

Temporarily hid Add to List functionality until it can be further developed.

Adding KPAC link to header and footer.

Modified style guide to emphasize call numbers in search results and item display.

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Corrected version of kpac.xml with properly nested preset searches

Added README and graphics template for use of KPAC graphics.

Conflicts:
Open-ILS/examples/kpac.xml

Added Nutrition subcategory under Early Learning category in KPAC.

Add GALILEO for Kids link to KPAC header.

Syncing kpac.xml with rel_2_5_1_kpac

Change to allow KPAC to display more than one format icon (like OPAC).

Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

Adds B4 Book Log icon and link to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Adds B4 Book Log icon to KPAC search results page and
KPAC item details page.

Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/record.tt2

Updated link to old library map to new library locator map in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Improvements to KPAC list display, especially adding
display of list annotations that were not shown.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/results.tt2

Removed added content from the KPAC for now since it doesn't
display properly. Possibly add back in later if we can get
the NoveList content to pull in right.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC changes in preparation for upgrade:

1. Biggest change was to move the library selector box to the main
search panel instead of on the side - had to modify quite a few files
in order to make this work and pass the values correctly.

2. Also changed the feature icons to use links instead of search terms
to allow more control over search limits and sorting and to see if
caching the searches would improve response speed.

3. A number of smaller UI changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC - Hold results not displaying item title and throwing log error

I believe the path comparison operator in the 'load' subroutine has
a flaw in logic caused by a path-naming problem. The path-matching
function recognizes the kpac/getit_results path as matching positively
for both the load_getit subroutine and the load_getit_results subroutine.

This patch reverses the order in which the matching occurs in an attempt
to resolve the conflict.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
I've redone all of the kpac category links so they no longer use
a link shortener. I also rearranged some of the links so that there
are more options on the home page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

Updates to KPAC Features (addition of TumbleBooks)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Since we only have bits and pieces of Spanish translations for our
customized KPAC right now, removing the parts that would display in
Spanish if Spanish has been selected in the OPAC. In the future when
all parts of the KPAC have been translated and graphic buttons have
been switched to text buttons that can be translated, we will then
need to go back in and re-add the language markup to allow the
translations to occur.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Config File: Feature Page Reset

Fresh version of kpac.xml file ready for upgrade to 3.0.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
KPAC Fix to broken image links

Removes cache info from image links in KPAC because
it was causing links on Dewey page to break.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Art and Features for SRP 2018

Signed-off-by: McCanna <tmccanna@georgialibraries.org>
PINES KPAC: Summer Reading 2019 Topics

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Update: Remove Tumblebooks Link

GALILEO canceled Tumblebooks, so removing link.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
KPAC Updates: Add E-Read Kids

Add new permanent KPAC icon for E-Read Kids, hide summer reading,
show back to school.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
PINES KPAC: New logo

Updates to incorporate new PINES logo.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoChanging the default hold message for when an item is age protected.
Chris Sharp [Fri, 14 Jun 2013 11:42:46 +0000 (07:42 -0400)]
Changing the default hold message for when an item is age protected.

5 years agoadding in gmcharlt's fix for trailing TCN spaces
Chris Sharp [Fri, 13 Jan 2012 22:26:14 +0000 (17:26 -0500)]
adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

5 years agoadding PINES help links
Chris Sharp [Wed, 20 Mar 2013 01:22:35 +0000 (21:22 -0400)]
adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

5 years agoupdating the username/password hints for the opac
Chris Sharp [Wed, 20 Mar 2013 01:19:04 +0000 (21:19 -0400)]
updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

5 years agoimproving the default hold message for range-protected items
Chris Sharp [Tue, 19 Mar 2013 17:41:49 +0000 (13:41 -0400)]
improving the default hold message for range-protected items

5 years agoEnabling the display of 856 field URLs for related resources
Chris Sharp [Tue, 19 Mar 2013 17:18:16 +0000 (13:18 -0400)]
Enabling the display of 856 field URLs for related resources

5 years agoPassword Length Helpers
Michael Peters [Wed, 13 Mar 2013 12:31:43 +0000 (08:31 -0400)]
Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
5 years agoremoving journal title and bib call number from query type selector dropdown
Chris Sharp [Wed, 6 Mar 2013 21:56:35 +0000 (16:56 -0500)]
removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

5 years agoremoving bib level advanced search filter
Chris Sharp [Wed, 6 Mar 2013 18:31:02 +0000 (13:31 -0500)]
removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

5 years agoPINES GALILEO TPAC link and auth redirector
Bill Erickson [Mon, 19 Aug 2013 13:27:58 +0000 (09:27 -0400)]
PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

5 years agoBumping version numbers and adding Changelog
Jason Boyer [Wed, 14 Oct 2020 12:04:32 +0000 (08:04 -0400)]
Bumping version numbers and adding Changelog

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoBumping Perl version string for 3.6.0
Jason Boyer [Wed, 14 Oct 2020 11:28:55 +0000 (07:28 -0400)]
Bumping Perl version string for 3.6.0

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoTranslation updates - po files
Jason Boyer [Wed, 14 Oct 2020 11:27:45 +0000 (07:27 -0400)]
Translation updates - po files

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoTranslation updates - newpot
Jason Boyer [Wed, 14 Oct 2020 11:22:54 +0000 (07:22 -0400)]
Translation updates - newpot

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agostamp version-upgrade script for 3.6.0
Galen Charlton [Tue, 13 Oct 2020 21:28:03 +0000 (17:28 -0400)]
stamp version-upgrade script for 3.6.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agostamp release notes for 3.6.0
Galen Charlton [Tue, 13 Oct 2020 21:27:13 +0000 (17:27 -0400)]
stamp release notes for 3.6.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoupdate Czech translation for Angular staff client
Galen Charlton [Wed, 7 Oct 2020 15:42:47 +0000 (11:42 -0400)]
update Czech translation for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoTranslation updates - newpot
Galen Charlton [Wed, 7 Oct 2020 15:38:57 +0000 (11:38 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agomove 3.6-beta2 update to 3.6-rc
Galen Charlton [Wed, 7 Oct 2020 15:37:22 +0000 (11:37 -0400)]
move 3.6-beta2 update to 3.6-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agostamp release notes for 3.6-beta2
Galen Charlton [Wed, 7 Oct 2020 15:36:32 +0000 (11:36 -0400)]
stamp release notes for 3.6-beta2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1895398: (follow-up) show outline when the login link has focus
Galen Charlton [Wed, 7 Oct 2020 15:24:24 +0000 (15:24 +0000)]
LP#1895398: (follow-up) show outline when the login link has focus

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1895398 Bootstrap OPAC Follow Up #2
Chris Burton [Fri, 25 Sep 2020 12:10:42 +0000 (08:10 -0400)]
LP1895398 Bootstrap OPAC Follow Up #2

1) Fix some whitespace issues
2) Move CSS for language pickuper to style.css.tt2

Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1895398 Bootstrap OPAC Follow Up #1
Chris Burton [Fri, 25 Sep 2020 11:59:47 +0000 (07:59 -0400)]
LP1895398 Bootstrap OPAC Follow Up #1

Includes following changes:

1) Login modal Aria-labelledby removed. The modal doesn’t have a label.
2) Due to a slight change in versioning, an issue occurred where another
attribute had to be added.
3) Added Buttons back to the middle.
4) Fixed button clicking issues on results and summary.
5) Print and email separated (Still needs
https://bugs.launchpad.net/evergreen/+bug/1895676 resolved)
6) Tabindex removed and now the cart navigation can be controlled by
keyboard
7) Data Toggle added to disabled elements on staff OPAC
8) Not sure what details are missing in the "More Details" section. I
did some old/new comparisons with the OPAC and some of the default books
found in the search and their information was matching up)
9)Tooltips changed to allow keyboard navigation and popups
10) Name was missing from the buttons, so it wasn’t passing actions
properly.
11) Move Language to footer as links. This will make it widely
accessible and noticable. Having a dropdown was not appealing and
removing the submit button would cause it to not be acceptable. I think
they call it a "jump box" because as soon as you make the selection it
redirects you, giving no chance to change it. It's not expected
behaviour from a dropdown.

Signed-off-by: Chris Burton <cburton@nflibrary.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: release notes: adding EOLI to the list of commissioning entities
Galen Charlton [Mon, 5 Oct 2020 21:55:01 +0000 (17:55 -0400)]
docs: release notes: adding EOLI to the list of commissioning entities

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: corrections to the 3.6 release notes
Lisa Carlucci [Mon, 5 Oct 2020 21:51:46 +0000 (17:51 -0400)]
docs: corrections to the 3.6 release notes

Signed-off-by: Lisa Carlucci <lisa@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoset Antora docs version for rel_3_6
Galen Charlton [Fri, 2 Oct 2020 21:22:38 +0000 (17:22 -0400)]
set Antora docs version for rel_3_6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1774008 Remove Hatch storage options
Bill Erickson [Wed, 5 Aug 2020 18:19:52 +0000 (14:19 -0400)]
LP1774008 Remove Hatch storage options

Remove option to store settings in Hatch from the AngJS Hatch admin
page.  Update some Hatch labels to remove the term 'Storage'.  Remove
deprecated JS code related to tracking this setting and the
long-deprecated offline file storage setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoTranslation updates - newpot
Galen Charlton [Wed, 30 Sep 2020 19:10:03 +0000 (15:10 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agomove 3.6-beta1 schema update to 3.6-beta2
Galen Charlton [Wed, 30 Sep 2020 19:08:04 +0000 (15:08 -0400)]
move 3.6-beta1 schema update to 3.6-beta2

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agostamp 3.6-beta2 release notes
Galen Charlton [Wed, 30 Sep 2020 19:07:09 +0000 (15:07 -0400)]
stamp 3.6-beta2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1896070: ensure that deatching course material doesn't delete non-temporary bibs
Galen Charlton [Thu, 17 Sep 2020 14:44:01 +0000 (10:44 -0400)]
LP#1896070: ensure that deatching course material doesn't delete non-temporary bibs

This patch fixes how the temporary_record field is checked; in Perl code,
non-NULL Boolean fields in Fieldmapper objects do /not/ evaluate as
Perl Boolean values; you have to use $U->is_true() or explictly
compare against 't' and 'f'.

This patch also tweaks live_t/31-courses.t so that it can be run
repeatedly.

To test
-------
[1] Run live_t/31-courses.t repeatedly; note that it will start failing
    the second time.
[2] Reset the database and apply the patch, then repeat step 1.
[3] This time, the test should work when run repeatedly.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
5 years agodocs: Curbside Pickup documentation
Angela Kilsdonk [Tue, 29 Sep 2020 21:01:45 +0000 (17:01 -0400)]
docs: Curbside Pickup documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: OPAC Email Print documentation
Angela Kilsdonk [Tue, 29 Sep 2020 20:57:23 +0000 (16:57 -0400)]
docs: OPAC Email Print documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: Acquisitions Providers documentation
Angela Kilsdonk [Tue, 29 Sep 2020 20:47:32 +0000 (16:47 -0400)]
docs: Acquisitions Providers documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: adding new image files for Hopeless Holds
Andrea Buntz Neiman [Tue, 29 Sep 2020 20:38:58 +0000 (16:38 -0400)]
docs: adding new image files for Hopeless Holds

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: updates to holds documentation
Felicia Beaudry [Tue, 29 Sep 2020 20:02:26 +0000 (16:02 -0400)]
docs: updates to holds documentation

Signed-off-by: Felicia Beaudry <felicia.beaudry@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: Angular Acq Sprint 0 Tools and Infrastructure
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:53:39 +0000 (15:53 -0400)]
docs: Angular Acq Sprint 0 Tools and Infrastructure

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: Acquisitions Search documentation
Angela Kilsdonk [Tue, 29 Sep 2020 19:27:01 +0000 (15:27 -0400)]
docs: Acquisitions Search documentation

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: updates to Best Hold Sort Selection Order
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:22:24 +0000 (15:22 -0400)]
docs: updates to Best Hold Sort Selection Order

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agodocs: adding credit card payment info
Andrea Buntz Neiman [Tue, 29 Sep 2020 19:17:49 +0000 (15:17 -0400)]
docs: adding credit card payment info

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1849212: (follow-up) Don't use group ids in upgrade scripts
Jason Boyer [Tue, 29 Sep 2020 14:32:48 +0000 (10:32 -0400)]
LP1849212: (follow-up) Don't use group ids in upgrade scripts

Previously if there was not a permission group with an id of 9
this upgrade script would fail. Changing the consatruction to
match the seed data allows the insert to benignly do nothing if
the group is missing. Also, the permission is made grantable.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoDocs: more 3.6 release notes updates
Andrea Buntz Neiman [Fri, 25 Sep 2020 19:27:01 +0000 (15:27 -0400)]
Docs: more 3.6 release notes updates

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoDocs: 3.6 release notes update
Andrea Buntz Neiman [Fri, 25 Sep 2020 18:44:09 +0000 (14:44 -0400)]
Docs: 3.6 release notes update

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
5 years agoLP1851882 Relase Notes (Angular catalog hold types)
Bill Erickson [Fri, 8 Nov 2019 22:09:03 +0000 (17:09 -0500)]
LP1851882 Relase Notes (Angular catalog hold types)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1851882 Angular catalog recall/force/part holds
Bill Erickson [Fri, 8 Nov 2019 22:02:48 +0000 (17:02 -0500)]
LP1851882 Angular catalog recall/force/part holds

Adds entry points for placing Recall, Force, and Part-level holds.

For any item-level hold type, the user now has the option to cycle
between Item, Recall, and Force hold types.  The selected type affects
the full batch of holds.

For title-level holds, the user now has the option to select a part as
the hold target for each hold in the list.  Part selection is optional.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoaccount for race condition in courses live test
Chris Sharp [Thu, 24 Sep 2020 23:46:51 +0000 (19:46 -0400)]
account for race condition in  courses live test

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1872867 Staff catalog filters use search labels
Bill Erickson [Thu, 30 Jul 2020 16:23:15 +0000 (12:23 -0400)]
LP1872867 Staff catalog filters use search labels

The Angular staff catalog now displays the search_label value for all of
the coded-value-map filters (search format, item type, etc.) when
available.  It falls back to the 'value' field when no search_label exists.

If a value is not opac_visible, the text "(Hidden)" is appended to the
label.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
5 years agoLP#1096209: Stamp upgrade script
Chris Sharp [Thu, 24 Sep 2020 17:41:20 +0000 (13:41 -0400)]
LP#1096209: Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1096209: add check_sms_notify parameter to all relevant event defs
Jeff Davis [Thu, 28 May 2020 16:17:11 +0000 (09:17 -0700)]
LP#1096209: add check_sms_notify parameter to all relevant event defs

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1776954 - Add release notes
Chris Sharp [Thu, 24 Sep 2020 17:18:39 +0000 (13:18 -0400)]
LP#1776954 - Add release notes

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1776954 Avoid empty string for tcn_source
Dan Scott [Thu, 14 Jun 2018 17:59:42 +0000 (13:59 -0400)]
LP#1776954 Avoid empty string for tcn_source

The tcn_source for some records is an empty string, instead of the database
default of 'AUTOGEN', because the Perl record import code avoids a Perl warning
in the logger info call by setting the value to an empty string if it can't
find any other source (e.g. OCLC number). Unfortunately, the empty string then
gets passed to the database, meaning that it satisfies the non-NULL constraint
and does not invoke the default value of 'AUTOGEN'.

The resulting MARCXML then contains an empty, self-closing 901 $b subfield
(<subfield code="b"/>) that causes an error for some other applications, such
as Zotero, which do not anticipate empty subfields.

The simple fix applied here is to follow the example for $source and $tcn of
not setting the value of the tcn_source field in the bib record object if the
corresponding variable evaluates to false (such as if it's an empty string).

To test: create a basic record in the MARC editor that includes minimal fields
(for example, a 100 and 245) so that it has no TCN source to extract. Check the
MARCXML served up by SuperCat ("curl
http://<hostname>/opac/extras/supercat/retrieve/marcxml-uris/record/<bib-id>").
Before this patch, it will have a self-closing 901 $b subfield. After applying
this patch and creating a new test record, the new test record will have a
901$b subfield with the value 'AUTOGEN'.

A site that has been running without this patch for a long time might want to
check how many bib records they have with an empty tcn_source:

SELECT COUNT(*) FROM biblio.record_entry WHERE deleted IS FALSE AND tcn_source = '';

Sites can fix the problem by issuing UPDATE statements to set the 901$b to a value
like 'AUTOGEN' or 'Unknown'. They should probably do it per-record, however, to
avoid locking the table in a huge commit.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1882828: Fix issues with displaying cataloged resources in Pull List
Jane Sandberg [Wed, 19 Aug 2020 23:22:43 +0000 (16:22 -0700)]
LP1882828: Fix issues with displaying cataloged resources in Pull List

I had mistakenly used switchMap, when I should have used mergeMap. This
led to erroneously canceled subscriptions, leaving rows out of the pull
list.

This commit also uses getRows, rather than manually setting the
GridDataSource's data.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1882825: (follow-up) include update number
Galen Charlton [Thu, 24 Sep 2020 15:59:02 +0000 (11:59 -0400)]
LP#1882825: (follow-up) include update number

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1835127: (follow-up) fixes to update script
Galen Charlton [Thu, 24 Sep 2020 15:58:08 +0000 (11:58 -0400)]
LP#1835127: (follow-up) fixes to update script

- include the version number stamp
- adjust the permission IDs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoRepair Permission Seed Data
Jason Boyer [Thu, 24 Sep 2020 12:03:33 +0000 (08:03 -0400)]
Repair Permission Seed Data

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoLP1882825 - Stamp upgrade script
Chris Sharp [Wed, 23 Sep 2020 20:47:33 +0000 (16:47 -0400)]
LP1882825 - Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1882825: Add setting for booking pull list grid
Jane Sandberg [Tue, 9 Jun 2020 20:51:24 +0000 (13:51 -0700)]
LP1882825: Add setting for booking pull list grid

Steps to test:
[1] Go to the Booking Pull List.
[2] Change the grid around and try to save.
[3] Note in your browser console an error message: "Error saving columns: No user or workstation setting type exists for eg.grid.booking.pull_list"
[4] Run the database migration included in this commit.
[5] Repeat steps 1-2.
[6] Note that no error message appears.
[7] Try exiting Evergreen and coming back (using the same workstation).  Note that your changes to the grid have stuck!

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1835127 - Stamp upgrade script
Chris Sharp [Wed, 23 Sep 2020 20:33:06 +0000 (16:33 -0400)]
LP#1835127 - Stamp upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1835127: scoped permissions for reservations
Jeff Davis [Wed, 6 May 2020 21:22:49 +0000 (14:22 -0700)]
LP#1835127: scoped permissions for reservations

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP#1361270 Self-registration doesn't retain org unit on refresh
Dan Briem [Tue, 25 Aug 2020 19:47:15 +0000 (15:47 -0400)]
LP#1361270 Self-registration doesn't retain org unit on refresh

This sets the self-registration form's org unit selector to the
the current org unit request parameter if it's set and self-
registration is allowed for that org unit. This will preopulate
the org selector on refresh or error instead of resetting to the
default context.

To test:
1. Administration->Local Administration->Library Settings Editor
   set Allow Patron Self-Registration to True (top context)
2. go to OPAC->Request Library Card (stock link is on bottom)
3. select a Home Library and click Submit Registration
4. note the Home Library select doesn't retain your selection
5. apply this fix and repeat steps
6. note the Home Library is retained

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
5 years agoLP1883126 Angular accesskey sort repair
Bill Erickson [Wed, 10 Jun 2020 15:46:39 +0000 (11:46 -0400)]
LP1883126 Angular accesskey sort repair

Fixes sorting issue in Angular egAccessKey directive to ensure that the
most recent additions are given highest priority and to ensure that
like keys (same action) are sorted next to each other in the control-h
help dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
5 years agoLP1896629 Angular catalog deleted record indicators
Bill Erickson [Mon, 1 Jun 2020 19:43:02 +0000 (15:43 -0400)]
LP1896629 Angular catalog deleted record indicators

Adds a (Deleted) record indictor to the bib summary component, which
appears in various Angular interfaces.

Also adds a (Deleted) to the catalog search results.  It sits where the
Place Hold button would normally go.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1885767: stamp DB update
Galen Charlton [Tue, 22 Sep 2020 14:26:51 +0000 (10:26 -0400)]
LP#1885767: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1885767 Staff catalog exclude electronic option
Bill Erickson [Fri, 28 Aug 2020 16:11:39 +0000 (12:11 -0400)]
LP1885767 Staff catalog exclude electronic option

Adds support for the 'Exclude Electronic Resources' checkbox in the
staff catalog, consistent with the TPAC option.

Adds a workstation setting, 'Staff Catalog "Exclude Electronic
Resources" Option' to control the behavior and an option to
toggle the preference in the staff catalog preferences page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1892111 Staff Catalog Digital Bookplates
Bill Erickson [Wed, 19 Aug 2020 14:54:35 +0000 (10:54 -0400)]
LP1892111 Staff Catalog Digital Bookplates

Support for digital bookplates searching in the staff catalog.

Note to testers, the org setting 'opac.search.enable_bookplate_search'
must be set to true and copy tags must be added and linked to copies.

Included in commit is a minor i18n tweak to address some complaints by
the Angular build.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1896081 Repair staff catalog filter expansion error
Bill Erickson [Thu, 17 Sep 2020 15:15:39 +0000 (11:15 -0400)]
LP1896081 Repair staff catalog filter expansion error

Simplifies an i18n structure that was leading to this error when
expanding the staff catalog filters section:

ERROR DOMException: Failed to execute 'appendChild' on
'Node': The new child element contains the parent.
    at EmulatedEncapsulationDomRenderer2.appendChild

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1896083 Staff catalog handles not-found barcodes
Bill Erickson [Thu, 17 Sep 2020 15:39:43 +0000 (11:39 -0400)]
LP1896083 Staff catalog handles not-found barcodes

Staff catalog => Numeric Search => Item Barcode

Display the standard 'No Maching Items Were Found' message when a
barcode search returns no results.

Prior to this patch, the search progress indicator would freeze as the
page failed to completely render on JS error.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP1896512 Angular retrieve record by ID/TCN
Bill Erickson [Mon, 21 Sep 2020 19:38:26 +0000 (15:38 -0400)]
LP1896512 Angular retrieve record by ID/TCN

Ports the retrieve records by ID/TCN to Angular.  Note this version of
the form confirms a record exists by both ID and TCN before directing
the user to the record detail page in the Angular staff catalog.

Updates the navigation bars to use the Angular port for each.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1788260: stamp schema update
Galen Charlton [Mon, 21 Sep 2020 15:51:09 +0000 (11:51 -0400)]
LP#1788260: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1788260 - Break out in-house-use non-cat circulations.
Chris Sharp [Tue, 21 Aug 2018 18:22:05 +0000 (14:22 -0400)]
LP#1788260 - Break out in-house-use non-cat circulations.

Previously, all non-cataloged circulations were grouped
together, causing problems for libraries who need to
exclude in-house circulations from circ counts.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agomake npm run export-strings happier
Galen Charlton [Thu, 17 Sep 2020 16:16:01 +0000 (12:16 -0400)]
make npm run export-strings happier

The UrlMatcher function used by the provider interface needs
to spelled slighly differently to avoid the AOT compiler
used by "npm run export-strings" from failing with the following error:

ERROR in Error during template compile of 'AcqProviderRoutingModule'
  Function expressions are not supported in decorators in 'ɵ0'
    'ɵ0' contains the error at app/staff/acq/provider/routing.module.ts(7,14)
      Consider changing the function expression into an exported function

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoRemove Extraneous Permissions from Course Reserves
Jason Boyer [Wed, 16 Sep 2020 17:03:20 +0000 (13:03 -0400)]
Remove Extraneous Permissions from Course Reserves

According to the release notes and seed data the MANAGE_RESERVES
permission is intended to be granted to the Circulation Administrator
group rather than Serials and System / Global Administrators.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoupdate schema update script for Curbside Pickup
Galen Charlton [Tue, 15 Sep 2020 20:41:20 +0000 (16:41 -0400)]
update schema update script for Curbside Pickup

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agofirst pass at consolidated schema update for 3.6-beta1
Galen Charlton [Tue, 15 Sep 2020 18:39:33 +0000 (14:39 -0400)]
first pass at consolidated schema update for 3.6-beta1

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoCorrect typo in seed data
Jason Boyer [Wed, 16 Sep 2020 18:22:15 +0000 (14:22 -0400)]
Correct typo in seed data

Rather than causing an error, forgetting a comma between 2 strings
concatenates them, and we don't have a permission called
VIEW_MERGE_PROFILEVIEW_REPORT_OUTPUT.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoTranslation updates - po file - 3.6
Galen Charlton [Wed, 16 Sep 2020 18:34:12 +0000 (14:34 -0400)]
Translation updates - po file - 3.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoTranslation updates - newpot for 3.6
Galen Charlton [Wed, 16 Sep 2020 18:28:21 +0000 (14:28 -0400)]
Translation updates - newpot for 3.6

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoadjusted release notes title to use -beta1 rather than -beta
Galen Charlton [Wed, 16 Sep 2020 18:10:41 +0000 (14:10 -0400)]
adjusted release notes title to use -beta1 rather than -beta

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agovarious changes to the 3.6 release notes
Michele Morgan [Wed, 16 Sep 2020 17:54:26 +0000 (13:54 -0400)]
various changes to the 3.6 release notes

Added notes for:

LP1818367
LP1841974
LP1880028
LP1884657

as well as typos and omissions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoupdate draft release notes for Curbside Pickup
Galen Charlton [Tue, 15 Sep 2020 20:43:19 +0000 (16:43 -0400)]
update draft release notes for Curbside Pickup

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agostart 3.6 release notes
Galen Charlton [Tue, 15 Sep 2020 18:17:27 +0000 (14:17 -0400)]
start 3.6 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoCorrect opensrf.xml.example
Jason Boyer [Wed, 16 Sep 2020 10:57:55 +0000 (06:57 -0400)]
Correct opensrf.xml.example

Add missing closing tag, include child process limits.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
5 years agoFix errors in live tests for courses
Jane Sandberg [Tue, 15 Sep 2020 23:34:55 +0000 (16:34 -0700)]
Fix errors in live tests for courses

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
5 years agofix some warnings reported by Launchpad's translation import
Galen Charlton [Tue, 15 Sep 2020 21:38:22 +0000 (17:38 -0400)]
fix some warnings reported by Launchpad's translation import

This patch fixes POT syntax errors in two cases and checks
in the results of xml2po for another. None of the files involved
(nowadays) are visible to users, so this patch is strictly
about keeping LP happy.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1811710: (follow-up) update loadChildren for hopeless holds
Galen Charlton [Tue, 15 Sep 2020 20:53:02 +0000 (16:53 -0400)]
LP#1811710: (follow-up) update loadChildren for hopeless holds

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1879983: stamp schema update
Galen Charlton [Tue, 15 Sep 2020 20:38:24 +0000 (16:38 -0400)]
LP#1879983: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1879983: Look at closings when getting times for a date
Mike Rylander [Mon, 24 Aug 2020 23:40:51 +0000 (19:40 -0400)]
LP#1879983: Look at closings when getting times for a date

This adds a check for library closings when getting the list of times to
offer for an appointment.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1879983: Create and protect a floor on appt granularity
Mike Rylander [Mon, 27 Jul 2020 18:10:14 +0000 (14:10 -0400)]
LP#1879983: Create and protect a floor on appt granularity

If bare numbers are entered, they are interpreted as a number of
seconds.  The most likely intent is minutes, so we force that unit.

Additionally, this commit sets a hard floor of 10 minutes on appointment
granularity.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
5 years agoLP#1879983: Restrict top-level curbside tab display
Mike Rylander [Mon, 29 Jun 2020 20:58:37 +0000 (16:58 -0400)]
LP#1879983: Restrict top-level curbside tab display

Refactor the code checking for curbside-available current-pickup
libraries so that it is checked for all of MyOPAC, allowing us to hide
the Curbside Pickup top-level tab when there are no holds ready at
curbside pickup enabled locations.  The tab will always be at the end of
the list if it is visible.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>