LP1895660: Course.pm

"my" variable $results masks earlier declaration in same scope

my $var should only be used once within a block.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Biblio.pm

Odd number of elements in anonymous hash

The type key is missing from some param descriptions,
leaving things uneven.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: SuperCat.pm

"my" variable $U masks earlier declaration in same scope

AppUtils is 'use'-ed and assigned to $U at the top of the file
and shared among the rest of the modules already.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1895660: Silence Perl Warnings

There are many perl warnings in make check and the day-to-day
logs when using Evergreen. This branch aims to address the
warnings and to make reviewing easier each file will be
individually committed with a small rationale for the changes
though it is assumed that this branch will be largely squashed
away if / when committed.

Booking.pm: Possible precedence issue with control flow operator
The precedence of 'or' is significantly lower than '||', so much so
that it can be less than the precedence for assignments.
Replace 'or' with '||' since they're equivalent in this case anyway,
and also add parens for flavor.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1917944k: (follow-up) fix ng lint issue

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1917944-Hold Pickup Library sometimes Empty

Checks to make sure that the opac.default_pickup_location in usr_setting
has a value.

To test.
1. The patron must have a opac.default_pickup_location set to ""
2. Place a hold for this patron.
3. Notice that the pickup location is blank.
4. Apply the patch.
5. The hold pickup location should now be filled with the patron's home library.

To re-create this in concerto you may have to tweak the usr_setting table.
1. Assign a default pickup location to a patron.
2. Find the id field for the above in the usr_setting table.
   select * from actor.usr_setting;
3. Update the setting.
   update actor.usr_setting set value = '""' where id = <the id number>;

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1925725 Relabel copy location filter to shelving location

Changes the labeling of the all copy locations filter to say "All Shelving Locations" instead, reflecting current practice.

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1926310 Record bucket batch edit destination

Record Bucket => Batch Edit now opens the new Angular MARC Batch Edit
interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527: (follow-up) add comment

Just in case there's a question in the future, make it clear
that the case where the context OU is the root OU is special.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1927527 Catalog: Root OU shelving locations do not display

When the top level org unit is selected in the staff catalog you
only have the option to search all shelving locations.

This allows you to filter on the root org unit's shelving
locations, which is the same behavior as the OPAC.

To test:
1. Make sure the top level org unit has shelving locations
   (Local Administration->Shelving Locations Editor)
2. In the staff catalog, select the top level org unit
3. Click the three dot icon next to the query text input
4. The root org unit's shelving location options display

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: fixing a typo

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Introduce documentation on how to contribute docs

This commit adds several screenshots and the basic outline on contributing
to the Evergreen documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1908440: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

lp1908440 editing the photo url in the staff client

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Seth Erickson <serickson@tds.lib.mn.us>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1892435 - Add Release Note

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

LP#1892435 Splash page catalog searches don't work with spaces

On older versions of Apache's mod_rewrite, splash page catalog
searches are escaped in JavaScript and escaped again during the
redirect to the Angular locale path, so searches with special
characters result in a search that's still encoded.

Test on Ubuntu 16.04.7, Apache 2.4.18, EG 3.6+. A splash page
catalog search for Harry Potter results in a search for
Harry%20Potter.

Add the NE (noescape) flag to the Angular locale path redirect
in /etc/apache2/eg_vhost.conf as indicated in this example file.
A splash page search for Harry Potter then works as expected.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

docs: Antora search index limit to master plus new switch

This provides a new option for generate_docs.p:

--antora-ui-repo-branch

where the user can optionally specify a branch on our UI repo for testing

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update version upgrade script for 3.7.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update version-upgrade script for 3.7-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: update target branches for Antora

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: fix a few asciidoc syntax errors

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Sort by Geographic Proximity

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Single Sign On

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Did You Mean SWSC

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Hold Groups

Signed-off-by: Felicia Beaudry <felicia.beaudry@equinoxinitiative.org>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Report Sources

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Library Groups

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1905091: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1905091 Supply environment for added print/email triggers

Ensures that OPAC print and email triggers added by upgrade script 1231
(lp 1749475) have appropriate environment.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1879769 Cannot Edit Carousels from Action Menu

The Edit Carousels action was appearing in the action menu and
right-click menu, but wasn't wired up. This adds in the missing
piece.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1917495 Angular Catalog: Hold status in View Holds is not saved

To test:
1. Go to a record in the Angular catalog
2. Click the View Holds tab
3. If status col is visible, remove status col, and save grid
4. Add status col and save grid.
5. Refresh page and note status field didn't stay visible
6. Apply patch, repeat steps 1-5, note Status stays visible

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1920815 Item edit link displayed for all users

The Angular catalog item table doesn't check UPDATE_COPY perm
before displaying an edit link. The back-end checks, so this is
a display issue only. This commit grabs a list of org Ids where
the user has UPDATE_COPY perm and checks the copy circ lib or
cn owning lib is in the list before displaying the edit link.

To test:
1. Search for a record with items you don't have perm to edit
2. Note the edit link shows on every item
3. Apply patch
4. Repeat steps 1-2
5. Note edit link displays if you have perm to edit

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: added script info to Carousels docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: correction to 3.7 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: a few typos in 3.7 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Translation updates - po files (3.7 beta)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: add upgrade instructions to release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: more tweaks to 3.7 release notes

- add an acknowledgment
- fix heading levels in the upgrade section

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: additional edits to the 3.7 release notes

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 3.6.3 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: 3.5.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

update Czech translations for Angular staff client

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1902965: removing nesting of accordion() calls

This was resulting in double-encoding of content notes, making the public
catalog display things like

<div class="content_field">...</div>

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on OPAC search results and record display, with accordion

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Conflicts:
Open-ILS/src/templates/opac/parts/record/contents.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: Fix search in Bootstrap OPAC

Filters and localization functions don't mix. Assign the html filtered
title to a temp var first.

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: change format type in XML transform to avoid XSS in SuperCat

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1902965: HTML filter on Bootstrap OPAC search results and record display

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

3.6.2 to 3.7-beta DB update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1896840: (follow-up) update script to include the DB rev

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: add new perms/settings/etc. to 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: add more acknowledgments to 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

docs: some edits to the 3.7 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

clear out old release notes stubs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

start 3.7 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1853006: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1853006 - Allow new strings to be translated

Allow newly added strings 'Show All Copies' and 'Show Only Available Copies' to be
translated.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1853006 TPAC: add limit to available option to item table

This patch adds a new control to the item table in
the TPAC public catalog only to specify that only items
that are available should be displayed.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Revert "LP1174498: Add a Payments by Billing Type Reporting View"

This reverts commit df4c2fa5d8645d7833b37683064cf69234f2dad4.

Revert "LP1174498: IDL changes for Payments by Billing Type"

This reverts commit c24fa37f34b03818689e0835e8c01c629b00fd99.

Revert "LP1174498: Add Release Note"

This reverts commit 6a01e002cf0440d8015a2c580d04280b179e1743.

Revert "LP#1174498: (follow-up) reformat release notes"

This reverts commit 56da49b19efff64a60b5833d4c67cf5ee7c85fef.

Revert "LP#1174498: stamp schema update"

This reverts commit 1e60ff5c23cd496e7f3069c71cb407959f9d9e1a.

LP1873322: Angular Admin Pages default to workstation OU

To test:

1) Apply this patch.
2) Log in using a workstation at a particular org unit.
3) Open some of the following admin pages:

Local Admin > Address Alerts
Local Admin > Carousels
Local Admin > Group Penalty Thresholds
Local Admin > Course Reserves List > Terms Tab
Server Admin > Billing Types
Server Admin > Call Number/Volume Suffixes
Server Admin > Copy Tags
Server Admin > Hard Due Date Configuration
Acquisitions Admin > Cancel Reason Configuration
Acquisitions Admin > Claim Policies
Booking Admin > Resource Types
Booking Admin > Resource Attribute Values

4) Verify that these pages automatically open to your
workstation's org unit.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1915323 Angular Staff Client Hamburger Menu Clipped Off Screen

Aligns navbar corner dropdown menu to the right to prevent it
from clipping off-screen.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1917804: only show MARC 500 data in the General Note field

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Stamping upgrade script

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1896840 Publisher display includes 264 tag

The stock Publisher display field now extracts data from 260 OR 264
tags, whichever has a value first.

Release notes included with upgrade instructions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1859513: In-house use link to item summary

Adds a link from the item's barcode in the in-house checkin screen to the item summary screen.

To test:
Type an item barcode into the In-House Use screen. Click on the barcode that displays in the item list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1424815: adjust release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Revert "LP#1424815: 'Read more' accordion in record view"

This reverts commit 9561b5736eadfa9325015676bc64e628d9f72be4.

Pushed by accident.

Revert "Revert "LP#705693: add release notes entry""

This reverts commit b3695a6fb79eca1c450bcc932734da71813f493e.

Pushed by accident.

Revert "LP#705693: add release notes entry"

This reverts commit dd61efc0e4b96627d5cc4ac96d472273e9da253f.

LP#1424815: 'Read more' accordion in record view

- Introduce custom accordion.JS to handle expand/truncation of
node information.
- Expansion/Truncation of individual nodes based on configurable
length.
- Refactor content.tt2 to properly display multiple notes with both
Read More and Highlighting features.
- Create accordion() macro in summary.tt2 to handle accordion-izing
a string when also supplied with a length, display field string,
and an optional highlighting boolean.
- Implementation of config.tt2 variables to handle enabling and length
requirements for truncation.
- Apply Read More to record Title as well as item details and graphics
text on record and search results.
- Teach Accordion functionality to understand blocks of HTML
- Add release notes for Read More functionality.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
modified:   Open-ILS/src/templates/opac/css/style.css.tt2
modified:   Open-ILS/src/templates/opac/i18n_strings.tt2
modified:   Open-ILS/src/templates/opac/parts/config.tt2
modified:   Open-ILS/src/templates/opac/parts/js.tt2
modified:   Open-ILS/src/templates/opac/parts/misc_util.tt2
modified:   Open-ILS/src/templates/opac/parts/record/authors.tt2
modified:   Open-ILS/src/templates/opac/parts/record/contents.tt2
modified:   Open-ILS/src/templates/opac/parts/record/summary.tt2
modified:   Open-ILS/src/templates/opac/parts/result/table.tt2
new file:   Open-ILS/web/js/ui/default/opac/accordion.js
new file:   docs/RELEASE_NOTES_NEXT/OPAC/read-more-feature.adoc

Signed-off-by: Ruth Fraser <rfrasur@gmail.com>
Signed-off-by: Michele <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#705693: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#705693 Check Number in Bill History

Adds the check number field to the Bill History payment grids
(hidden by default).

To test:
1. Bill patron and apply a check payment with a check number
2. Go to Bills->History->Payments and note check number is not
   an option (drop-down on top-right of grid shows the list)
3. Right-click the payment line->Full Details->Details and note
   check number is not an option on the bottom payments grid
4. Apply patch (may need to clear cache especially on Firefox)
5. Repeat steps 2-3 and note check number is an available option

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1174498: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1174498: (follow-up) reformat release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1174498: Add Release Note

Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1174498: IDL changes for Payments by Billing Type

Add the mmpbbt class to make use of the new view.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1174498: Add a Payments by Billing Type Reporting View

This is an updated version of the initial concept by Mike
Rylander with input from Jeff Godin. This view connects
payments to specific billings and allows reports to be
written to determine how accepted payments were distributed
by billing type.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxinitiative.org>
Signed-off-by: Katie Greenleaf Martin <bcl@blaircountylibraries.org>
Signed-off-by: Elizabeth Davis <edavis@albright.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1830960: update release notes to account for Bootstrap

Now that the Bootstrap skin is the default, this patch is
mostly of interest to current users of TPAC, including consortia
that may add new members before switching to the Bootstrap
skin.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1830960 adding more customizing options to opac colors, found issue in old patch plus added docs

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

adding more colors and style.css changes to make them usable to ease customizations

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lP#1863252: (follow-up) fix Angular lint

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: mention new settings in the release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: (follow-up) fix typos in release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: fix a couple minor thinkos in the upgrade

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: Did You Mean release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1893997: Did you mean? Single word, single class

This commit embodies the first stage of a larger search suggestion
project.  The bulk of the code is dedicated to providing an
implementation of the SymSpell[1] algorithm as the basis for very fast
word similarity testing for spelling suggestions as well as alternate
search suggestions.

The native in-memory algorithm specifies a hash table lookup using a
runtime-created dictionary.  As it is untenable to create and maintain a
separate in-memory data structure in the distributed environment that
OpenSRF provides, and adds significantly to the administrative complexity
of such a configuration, we instead maintain a dictionary in the
authoritative Postgres database used by Evergreen.  This dictionary is
based directly on indexed terms used for general search, and aims to
avoid zero-hit suggestions wherever possible while imposing as little
performance impact as can be managed.

In addition to the core SymSpell similarity metric, Damerau-Levenshtein
edit distance, we provide Soundex, Trigram, and QWERTY Keyboard
similarity measures.  The importance of these can be adjusted relative
to one another, or turned off individually.

Global term frequncey data is captured for each of the Evergreen search
classes and is used to help decide when to use specific terms, and which
terms to use as suggestions.

Suggestions are provide in the OPAC, including the staff-embedded OPAC
view, the KPAC, and the Angular catalog.

Later development will add the ability to perform mult-word and
phrase-oriented suggestions, to suggest searching requested terms in
other search classes, and provide local thesaurus values and exclusion
term lists.

[1] https://medium.com/@wolfgarbe/1000x-faster-spelling-correction-algorithm-2012-8701fcd87a5f

NOTE: This development adds two new Perl module dependencies, and will
therefore require a dependency update at upgrade time.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1907979: Fix Search by Instructor setting lookup in OPAC

Previously, the Search Courses screen in the OPAC relied on a locg
param in the URL to determine whether or not to display the "Search
by Instructor option", defaulting to location id 1 if no such param
exists.  However, we can also consult physical_loc and other settings
to get a more accurate idea of which library's setting we need here.

To test:
1) In the Library settings editor, set Course Materials Module Opt In
to true for BR1.
2) In the Library settings editor, set Search by Instructor to true
for BR1.
3) In eg.conf, add the line:
    SetEnv physical_loc 4
4) Restart httpd
5) Go to your OPAC.  Note that the OPAC is at the BR1 level, and that
course search and browse options are available.
6) Click Search courses.
7) Note that only two values are available in the qtype dropdown: Course
Name and Course Number.
8) Apply this patch.
9) Repeat steps 5-6.
10) Note that the screen now appropriately consults the value for the
"Search by Instructor" setting at the BR1 level, with an "Instructor"
value now available in the qtype dropdown.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1908616 Add email display to hold edit

Note: This is built atop the patch for LP1902265

This display's the current email address (or note if there
is no address) on the Edit Hold page of My Account in the
Bootstrap OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Revert the effects of both LP1687545 and LP1914116

Revert "LP1687545: Force TT CGI plugin to use ampersands in query strings"
and "LP1914116: Apply html filter to mkurl() output"
until a fix for LP1918470 is available.

Signed-off-by: Jason Boyer <JBoyer@EquinoxInitiative.org>

Minor mis-merge for geosort, missing comma in INSERT VALUES list addition.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1863252 Stamping DB Upgrade: Geosort

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1863252 Geosort - add dropped END tag

This adds back an END tag in the boostrap copy_table.tt2
that got lost.

Note that in order to fully test this in bootstrap, I had to
add the fix included here as well:
https://bugs.launchpad.net/evergreen/+bug/1916085

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>