Bill Erickson [Thu, 16 Aug 2012 19:40:58 +0000 (15:40 -0400)]
Sanity check cstore limit/offset param values
Certain cstore calls (direct / json_query) that support limit/offset
params called with a non-string / non-numeric value
e.g. { "limit": null }
result in a cstore segfault as it tries to call atoi(NULL) under the
covers. This patch prevents this by verifying that the limit/offset
values are actual strings or numbers (i.e. return a value from
jsonObjectGetString) and not JSON_NULL, etc.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sun, 19 Aug 2012 03:21:43 +0000 (23:21 -0400)]
Merge branch 'user/dbs/rel_2_3_mergery' of git.evergreen-ils.org:contrib/Conifer into rel_2_3_mergery_tpac
Dan Scott [Sun, 19 Aug 2012 03:18:33 +0000 (23:18 -0400)]
Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery_2
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Open-ILS/src/templates/opac/parts/js.tt2
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Fri, 17 Aug 2012 19:16:45 +0000 (15:16 -0400)]
TPAC: size_bigger, not size-bigger
Amusingly, TT2 attempts to treat "bigger" as a value to subtract from
"size". Cute. But we don't want the messages in the Apache log.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 30 Jul 2012 15:30:50 +0000 (11:30 -0400)]
TPAC: Autosuggest focus() throws a JS error
On page load, the Dojo autosuggest code tries to set focus to the
element with the ID "search_box" - which is fine, except when the page
does not have said ID. Therefore, test for the existence of the ID
before setting focus to it.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Thomas Berezansky [Fri, 17 Aug 2012 17:00:36 +0000 (13:00 -0400)]
Use XUL_REMOTE_BROWSER constant in reporter
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Sally Fortin [Fri, 17 Aug 2012 12:22:17 +0000 (08:22 -0400)]
Documentation: Add one paragraph to Auto Override Patron Hold Events.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Sally Fortin [Fri, 17 Aug 2012 12:16:05 +0000 (08:16 -0400)]
Documentation: add Auto Override Patron Hold Events documentation from ESI.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Dan Scott [Sat, 4 Aug 2012 14:26:25 +0000 (10:26 -0400)]
TPAC locale picker: use POST instead of GET
Users could (deliberately or not) change another's language
preferences by sharing links with the "set_eg_locale" GET param given
the locale picker's current behaviour. By switching to a POST param, we
prevent this result from accidentally occurring.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Thu, 16 Aug 2012 20:35:26 +0000 (16:35 -0400)]
Update fr-CA TPAC translation a bit
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 16 Aug 2012 20:04:37 +0000 (16:04 -0400)]
Boreal: Link from logo to College Boreal itself
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Lebbeous Fogle-Weekley [Thu, 16 Aug 2012 19:38:59 +0000 (15:38 -0400)]
Fix thinkos in EDI Invoicing
The lesson of the day is, test the code you actually commit, not just
the bits and pieces. Thanks to Bill Erickson on this.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 30 May 2011 03:29:38 +0000 (23:29 -0400)]
Add Conifer's custom MARC templates
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 30 May 2011 03:29:38 +0000 (23:29 -0400)]
Add Conifer's custom MARC templates
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 16 Aug 2012 19:20:14 +0000 (15:20 -0400)]
Boreal: Move to CSS overrides to be stylin'
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 16 Aug 2012 19:16:30 +0000 (15:16 -0400)]
Boreal: Update header/footer links
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Mike Rylander [Thu, 16 Aug 2012 19:11:29 +0000 (15:11 -0400)]
Stamping upgrade script for copy editor field hiding permission
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Thu, 16 Aug 2012 18:58:01 +0000 (14:58 -0400)]
Update permission name to match existing ones
To be consistent with our previous naming scheme for these.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Thu, 16 Aug 2012 17:45:23 +0000 (13:45 -0400)]
Provide permission for copy editor field hiding
We can adjust what fields are available in the copy editor in 2.2+, but that
requires the general UPDATE_ORG_SETTING permission. The YAOUS-specific
permission here allows more granular control, so that staff can be given the
ability to adjust only that one OU setting.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Mon, 16 Jul 2012 17:27:54 +0000 (13:27 -0400)]
Hide OPAC-invisible holdings from SRU/Z39.50
The basic_holdings Supercat method filtered out deleted call numbers and
copies, but didn't filter out copies based on the OPAC visibility status
of copy location / status / the copy itself. This has undesired results
when third-party services request copies via SRU or Z39.50 and expose
copies that should not be visible to the public.
We wrap all of the visibility and deletedness checks for a given copy up
into a subroutine so that we can avoid repeating ourselves in the
basic_holdings logic. Also, if we missed a test, we can add it in one
handy place :)
(Thanks to Galen Charlton for finding two missing tests: circ lib
visibility and owning lib visibility!)
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Mon, 13 Aug 2012 16:32:26 +0000 (12:32 -0400)]
TPAC: Centralize font size definitions
The TPAC CSS had a mix of absolute and proportional font size
definitions, making it impossible to define a single base size and have
the layout adjust appropriately, as well as making it difficult to tweak
sizes to, say, eliminate the distinction between 11px and 12px text.
Accordingly, create a separate TT2 file to define standard font sizes,
define one base font size, and then use proportional percentage-based
size definitions for a set of standard font sizes. This way, a site
could easily adjust the base font size to 15px and the rest of the
layout should automatically adjust, and/or revert to using absolute font
sizes for different categories if they prefer.
Note that I did simplify some of the categories of font sizes, as the
distinction between 111% and 110% was probably not evident to most
humans at most font sizes, and even the distinction between 120% and
125% would be 14.4px vs. 15px given a base size of 12px - which
different user agents could render differently anyway.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Sally Fortin [Thu, 16 Aug 2012 14:27:50 +0000 (10:27 -0400)]
Documentation: Add triggered events and holds management docs from ESI.
Content and images from http://www.esilibrary.com/esi/availableDocs.php.
Also fixed some formatting issues for previous committed documentation.
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Sally Fortin [Thu, 16 Aug 2012 13:25:16 +0000 (09:25 -0400)]
Documentation: Add sections to Local System Administration from ESI
Content and images from http://www.esilibrary.com/esi/availableDocs.php
Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>
Lebbeous Fogle-Weekley [Fri, 10 Aug 2012 22:14:23 +0000 (18:14 -0400)]
Simplified Hold Pull List: Fix broken filters
Only two filterable fields were available, and at least
one didn't even work.
Now we have a few more, and they seem to all work for me in testing.
This problem was reported to me by Thomas Berezansky.
While we're at it, also make sure the list of shelving locations in that
filter dropdown is sorted alphabetically. This was Kathy Lussier's
request.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Thomas Berezansky [Tue, 14 Aug 2012 17:31:27 +0000 (13:31 -0400)]
Join subqueries as OR'd groups in QueryParser
This makes filter_group_entry(1,2,3) build an OR'd set of the resulting
queries instead of just tacking them onto each other as ANDs.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Thomas Berezansky [Fri, 3 Aug 2012 15:34:05 +0000 (11:34 -0400)]
Expose ability to use filter groups in TPac
Via config options for basic and advanced search.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Thomas Berezansky [Fri, 10 Aug 2012 14:44:47 +0000 (10:44 -0400)]
Stage 2: Staff Client
Robustify the oils protocol:
1 - In the event of a problem URL, abort with about:blank.
This prevents a segfault!
2 - In the event of the TPac, or KPac, wrap the channel we return.
The wrapper helps with redirects, but if applied to XMLHttpRequests will
cause full breakage.
Without the wrapper redirects end up setting URLs to https://host/...
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Thomas Berezansky [Wed, 8 Aug 2012 00:15:24 +0000 (20:15 -0400)]
Stage 1: Perl
Attempt to ensure that we always write to oils://remote when needed.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 20:45:24 +0000 (16:45 -0400)]
Trying to update patron CSS color fails here, so don't try
After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
TypeError: patron.display is undefined.
We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
...penalties[i].standing_penalty().name is not a function.
Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 31 Jul 2012 19:35:21 +0000 (15:35 -0400)]
Check for filled hold on transit checkin
"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 10 Apr 2012 13:10:46 +0000 (09:10 -0400)]
SuperCat fixes - Child Init
Sometimes it seems that child_init has not run properly for supercat.
This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 20:45:24 +0000 (16:45 -0400)]
Trying to update patron CSS color fails here, so don't try
After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
TypeError: patron.display is undefined.
We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
...penalties[i].standing_penalty().name is not a function.
Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 31 Jul 2012 19:35:21 +0000 (15:35 -0400)]
Check for filled hold on transit checkin
"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 10 Apr 2012 13:10:46 +0000 (09:10 -0400)]
SuperCat fixes - Child Init
Sometimes it seems that child_init has not run properly for supercat.
This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Lebbeous Fogle-Weekley [Thu, 26 Jul 2012 20:45:24 +0000 (16:45 -0400)]
Trying to update patron CSS color fails here, so don't try
After modifying user standing penalties ("messages" in the staff client
patron interface), you could get this error message in an alert() dialog:
TypeError: patron.display is undefined.
We were apparently trying to use patron.util.set_patron_css() wrongly,
so the commented out changed verison of the call got farther, but stopped at
...penalties[i].standing_penalty().name is not a function.
Which probably has something to do with unfleshed data. Somebody can
get to the bottom of this if they want, but for now it's easier just not
to try to do this and make the alert() dialog go away.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 31 Jul 2012 19:35:21 +0000 (15:35 -0400)]
Check for filled hold on transit checkin
"Fill related hold" can grab a hold out from under a transit, so check for
filled holds in addition to canceled ones.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Thomas Berezansky [Tue, 10 Apr 2012 13:10:46 +0000 (09:10 -0400)]
SuperCat fixes - Child Init
Sometimes it seems that child_init has not run properly for supercat.
This attempts to fix that by checking for the global appsession objects. If
they are not there we run child_init. The function that does this is being
called from all handler entry functions.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sat, 4 Aug 2012 15:04:17 +0000 (11:04 -0400)]
Silence warnings in search results for holdable copies
Have not yet determined the exact reason the holdable copies size is not
defined in some instances in the search results only, but this commit
prevents warnings from being spewed by apache about undefined variables.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Sat, 4 Aug 2012 14:43:31 +0000 (10:43 -0400)]
TPAC: Silence two uninit variable warnings
These warnings were being thrown on every TPAC page request, slowly
filling the logs:
Use of uninitialized value $set_locale in string eq at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm line 159.
Use of uninitialized value in pattern match (m//) at
/usr/local/share/perl/5.10.1/OpenILS/WWW/EGCatLoader.pm line 250.
Banish them.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 13 Aug 2012 17:53:22 +0000 (13:53 -0400)]
TPAC: Give login boxes a border
For some reason, the boxes for the login form were stripped of
their default border style. Let the natural input box formatting for the
border shine through and give users an easier target when logging in.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Ben Shum [Mon, 6 Aug 2012 15:11:54 +0000 (11:11 -0400)]
TPAC - Fix footer on hold history page
The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.
Adding the ending tag repairs the display of the footer to match all
the other pages.
Credit to Melissa Lefebvre for noticing this discrepancy.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Mon, 6 Aug 2012 15:11:54 +0000 (11:11 -0400)]
TPAC - Fix footer on hold history page
The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.
Adding the ending tag repairs the display of the footer to match all
the other pages.
Credit to Melissa Lefebvre for noticing this discrepancy.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Mon, 6 Aug 2012 15:11:54 +0000 (11:11 -0400)]
TPAC - Fix footer on hold history page
The hold history page was missing an ending div tag to complete the
block which leads to the footer being generated incorrectly on that
page.
Adding the ending tag repairs the display of the footer to match all
the other pages.
Credit to Melissa Lefebvre for noticing this discrepancy.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Wed, 15 Aug 2012 15:42:27 +0000 (11:42 -0400)]
Turn on RefWorks for the windsor tpac skin
For now at least, RefWorks is the official citation manager for the
Leddy Library.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Melissa Lefebvre [Tue, 14 Aug 2012 16:58:18 +0000 (12:58 -0400)]
Change grammar for lost and missing failure messages
Update to the lost and missing failure wording to make it
gramatically correct. Removed the word "has" from both
messages.
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Melissa Lefebvre [Tue, 14 Aug 2012 16:58:18 +0000 (12:58 -0400)]
Change grammar for lost and missing failure messages
Update to the lost and missing failure wording to make it
gramatically correct. Removed the word "has" from both
messages.
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Melissa Lefebvre [Tue, 14 Aug 2012 16:58:18 +0000 (12:58 -0400)]
Change grammar for lost and missing failure messages
Update to the lost and missing failure wording to make it
gramatically correct. Removed the word "has" from both
messages.
Signed-off-by: Melissa Lefebvre <mlefebvre@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 13:16:23 +0000 (09:16 -0400)]
TPAC: Remove noise, misleading text from myopac/holds/circs/circ_history
There are many "class='hide_me'" elements that will never be displayed
and which are currently just extra bits to ship over the wire. Same for
the inline comments.
Also move most of the inline styles out to the stylesheet.
Also remove the explicit widths on the table cells; if the font size
changes or the translated text is wider than the table cells, then the
display will become comical.
Also remove explicit <br> tags from localized strings; given the
likelihood that font sizes and column widths will change, <br> tags
inside localized strings make very little sense.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 13:16:23 +0000 (09:16 -0400)]
TPAC: Remove noise, misleading text from myopac/holds/circs/circ_history
There are many "class='hide_me'" elements that will never be displayed
and which are currently just extra bits to ship over the wire. Same for
the inline comments.
Also move most of the inline styles out to the stylesheet.
Also remove the explicit widths on the table cells; if the font size
changes or the translated text is wider than the table cells, then the
display will become comical.
Also remove explicit <br> tags from localized strings; given the
likelihood that font sizes and column widths will change, <br> tags
inside localized strings make very little sense.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Conflicts:
Open-ILS/src/templates/opac/css/style.css.tt2
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Wed, 15 Aug 2012 11:48:47 +0000 (07:48 -0400)]
Add 'Show More Details' setting and increase font size
We definitely want the 'Show More Details' view by default and
a larger font will be appreciated by the staff.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Wed, 15 Aug 2012 15:17:13 +0000 (11:17 -0400)]
Merge branch 'user/dbs/rel_2_3_mergery' of git.evergreen-ils.org:contrib/Conifer into rel_2_3_mergery_tpac
Dan Scott [Wed, 15 Aug 2012 15:15:49 +0000 (11:15 -0400)]
Merge branch 'rel_2_3' of git.evergreen-ils.org:Evergreen into rel_2_3_mergery
Conflicts:
Open-ILS/src/templates/opac/parts/advanced/search.tt2
Open-ILS/src/templates/opac/parts/org_selector.tt2
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Thomas Berezansky [Tue, 14 Aug 2012 14:50:11 +0000 (10:50 -0400)]
Physical Location Fixes/Enhancements
Teach the physical location retrieval function about using an ENV var.
This allows a subdomain to force a specific physical location, say by adding
to their apache config:
SetEnv physical_loc 4
Rewriterules could also be used for more dynamic configuration.
Also, as a fix:
Have preferred library use the stored physical location instead of assuming
that CGI has the setting all the time.
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Dan Scott [Wed, 15 Aug 2012 11:29:38 +0000 (07:29 -0400)]
Apply refworks placement fix to Conifer skin
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 11:29:38 +0000 (07:29 -0400)]
Apply refworks placement fix to Conifer skin
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 11:18:53 +0000 (07:18 -0400)]
TPAC: Move "Export to RefWorks" into utility area
When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 11:25:14 +0000 (07:25 -0400)]
Fix
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 15 Aug 2012 11:18:53 +0000 (07:18 -0400)]
TPAC: Move "Export to RefWorks" into utility area
When the RefWorks functionality was being added to TPAC, the design and
layout were very much in flux. Now that the layout has been established
with utilities like "Place Hold" on the right hand side, move the
"Export to RefWorks" button into the same location.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Wed, 15 Aug 2012 01:39:23 +0000 (21:39 -0400)]
Bring skin in sync with Conifer layout
This moves the skin to a presentation layout rather than populating
the template files with potentially brittle logic. Thanks to Dan Scott
for pushing the logic into the base files.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Art Rhyno [Sun, 12 Aug 2012 20:55:49 +0000 (16:55 -0400)]
Include 'Reset Form/Another Search' fix and add detail default to results table
This brings the fixed results.tt2 template into the Windsor skin and extends
the 'show_more_details.default' setting to the table.tt2 template, which
falls through the cracks otherwise.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Wed, 15 Aug 2012 11:01:47 +0000 (07:01 -0400)]
OSUL: Turn on RefWorks export
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 14 Aug 2012 21:18:22 +0000 (17:18 -0400)]
TPAC: Hide inline call number in detailed results
There's no need to show the inline call number in the detailed results
view; it's redundant.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 14 Aug 2012 21:09:55 +0000 (17:09 -0400)]
TPAC: Display the ISSN in search results
Also, do not display URIs from the bib if we have OpenURL results.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 14 Aug 2012 21:18:22 +0000 (17:18 -0400)]
TPAC: Hide inline call number in detailed results
There's no need to show the inline call number in the detailed results
view; it's redundant.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 14 Aug 2012 21:09:55 +0000 (17:09 -0400)]
TPAC: Display the ISSN in search results
Also, do not display URIs from the bib if we have OpenURL results.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Tue, 14 Aug 2012 20:51:59 +0000 (16:51 -0400)]
Avoid top-level copy counts in TPAC
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Tue, 7 Aug 2012 17:48:31 +0000 (13:48 -0400)]
TPAC - fix pickup locations for edit holds
When a patron goes to edit a hold in TPAC, they have the option to
choose a different pickup location. Unfortunately, it looks like that
dropdown does not prevent them from selecting locations that aren't
normally allowed for pickups, such as system groups or consortium
itself.
This patch adds a check for 'can_have_vols_only' to the edit holds
screen.
Credit to Melissa Lefebvre for finally nailing down the source of
the issue.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Tue, 14 Aug 2012 20:51:59 +0000 (16:51 -0400)]
Avoid top-level copy counts in TPAC
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Bill Erickson [Fri, 10 Aug 2012 18:59:50 +0000 (14:59 -0400)]
Default to current fiscal year in ACQ order upload
* Adds a new API call to determine the current fiscal year for a given
org unit: open-ils.acq.org_unit.current_fiscal_year
* Use open-ils.acq.org_unit.current_fiscal_year to populate the correct
fiscal year in the ACQ order upload selector.
This addresses part 2 of LP
1031927
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 10 Aug 2012 18:59:29 +0000 (14:59 -0400)]
Enable pcrud access to fiscal year / fiscal calendar
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Bill Erickson [Fri, 10 Aug 2012 18:06:36 +0000 (14:06 -0400)]
Fiscal year selector in ACQ order record upload
* Support a 'fiscal_year' parameter to ACQ order record upload API.
* Adds a new "Fiscal Year" selector to the upload form to facilitate
uploading orders to different fiscal years.
This partially resolves LP
1031927 by allowing manual selection of the
correct fiscal year.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Art Rhyno [Tue, 14 Aug 2012 13:53:27 +0000 (09:53 -0400)]
TPAC: More "show details" entry points (result table)
This extends the 'show_more_details.default' setting to the table.tt2
template, which falls through the cracks otherwise.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Tue, 14 Aug 2012 13:53:27 +0000 (09:53 -0400)]
TPAC: More "show details" entry points (result table)
This extends the 'show_more_details.default' setting to the table.tt2
template, which falls through the cracks otherwise.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 23:24:59 +0000 (19:24 -0400)]
Fix logic for show details by default
If the CGI param was set, then the hidden input field was not created -
meaning that the next search would fail to show the details. Switching
the logic around sorts that out nicely.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 23:24:59 +0000 (19:24 -0400)]
Fix logic for show details by default
If the CGI param was set, then the hidden input field was not created -
meaning that the next search would fail to show the details. Switching
the logic around sorts that out nicely.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Ben Shum [Mon, 13 Aug 2012 22:08:53 +0000 (18:08 -0400)]
Change "Reset form" to "Clear Form"
As suggested by Thomas Berezansky in the comments on LP 994058, change
the button from "Reset form" to "Clear form" to be absolutely clear
that the button now removes all previous search variables.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Wed, 8 Aug 2012 19:08:24 +0000 (15:08 -0400)]
TPAC: Reset Form and New Search should clear queries
Currently, clicking "Another Search" in the search results page, or
"Reset Form" on the advanced search page, keeps the same query terms and
type around. Clear these parameters as expected; essentially, we keep
only the search location (loc or locg) in scope.
Note that we explicitly keep parameters around when someone is going
from a basic search to an advanced search, because the assumption is
that they want to refine their search further.
Also affected are the org_selector, because we want to pull the logic
for loc or locg out into a common area (the get_library block in
misc_util.tt2), and the style (input.opac-button elements now get styled
the same as a.opac-button elements, which makes it easier to intermingle
them on the same form).
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 13 Aug 2012 21:48:00 +0000 (17:48 -0400)]
Laurentian TPAC: use base font= 15px, show details
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 17:26:58 +0000 (13:26 -0400)]
Laurentian TPAC: one missing override
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 16:58:02 +0000 (12:58 -0400)]
Laurentian TPAC: And name the overrides stylesheet appropriately too
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 16:52:06 +0000 (12:52 -0400)]
Laurentian TPAC: delete copy of style.css.tt2
Now that we're overriding style.css.tt2, we don't need to include a
near-duplicate of the base stylesheet.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 16:48:24 +0000 (12:48 -0400)]
Laurentian TPAC: override style.css in a separate stylesheet
One more HTTP request, but much simpler tracking of HEAD stylesheet
chagnes.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Thu, 9 Aug 2012 17:24:59 +0000 (13:24 -0400)]
Add option to change default or suppress 'Show More Details' button
Conifer makes heavy use of Dan Scott's ResolverResolver service for
e-content and typically wants to bring most details about entries on a results
screen to the front. This adds a 'show_more_details.default' option
in 'config.tt2' that can have the values 'true', 'false' and 'hide'. The
'true' and 'false' values set the default for the button to more and
less respectively, and 'hide' suppresses the button from showing at all.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Thu, 9 Aug 2012 15:23:32 +0000 (11:23 -0400)]
Fix
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Thu, 9 Aug 2012 15:11:59 +0000 (11:11 -0400)]
Sync up the input.opac-button style with master
Pulled from the user/dbs/tpac_clear_search working branch, we need to
maintain the same style. Hey, aren't these supposed to cascade?
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Mon, 13 Aug 2012 22:47:05 +0000 (18:47 -0400)]
Fix up mergery
Art Rhyno [Tue, 7 Aug 2012 19:04:39 +0000 (15:04 -0400)]
Fix up directory mixup
I messed up this location big time, this now reflects what's in production.
Thanks Dan!
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Art Rhyno [Tue, 7 Aug 2012 16:50:57 +0000 (12:50 -0400)]
Add option for Show More Details default in TPAC
This minor change adds an option in config.tt2 to have
the "Show More Details" view invoked by default
in results pages.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add SJCG TPAC skin
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Robin Isard [Sun, 5 Aug 2012 01:16:45 +0000 (21:16 -0400)]
Fixed account login form.
Made a mistake with the login form (thought it was the home page for some reason. Restored it to it's glory, but removed help texts cause that's the fastest way to get the fix pushed.
Signed-off-by: Robin Isard <robin.isard@algomau.ca>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Art Rhyno [Sun, 5 Aug 2012 03:40:29 +0000 (23:40 -0400)]
tpac skin for Leddy Library
I suspect this will get furious changes but I tried to match
the university colours.
Signed-off-by: Art Rhyno <art632000@yahoo.ca>
Robin Isard [Sat, 4 Aug 2012 19:49:04 +0000 (15:49 -0400)]
Touch-up of Algoma tpac skin.
*changed the main logo on the homepate
*changed the header links to reflect new library website
*added footer links
*added config file based on lul's to enable OpenURL
Signed-off-by: Robin Isard <robin.isard@algomau.ca>
Dan Scott [Sat, 4 Aug 2012 15:35:53 +0000 (11:35 -0400)]
Fix cached_list_div width
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 4 Aug 2012 15:35:14 +0000 (11:35 -0400)]
Fix cached_list_div width
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 4 Aug 2012 15:34:36 +0000 (11:34 -0400)]
Fix cached_list_div width
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 4 Aug 2012 15:33:51 +0000 (11:33 -0400)]
Fix cached_list_div width
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Sat, 4 Aug 2012 15:32:24 +0000 (11:32 -0400)]
Fix cached_list_div width
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Robin Isard [Fri, 3 Aug 2012 19:59:57 +0000 (15:59 -0400)]
First pass at Algoma U tpac skin for rel_2.3
This was done in a hurry and simply handles the esential links, logos and branding.
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add TPAC UHearst colours, logos, and links
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Dan Scott [Fri, 3 Aug 2012 21:24:26 +0000 (17:24 -0400)]
Add NOSM TPAC skin: colours, logos, links
Signed-off-by: Dan Scott <dscott@laurentian.ca>