LP#1319964 "Summaries & More" displays improperly in TPAC

Somehow, a patch leaked in that set all of the "Summaries & More"
strings incorrectly.  This patch fixes the display of those
headings by restoring the proper string.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/templates/opac/parts/record/extras.tt2
build/i18n/po/tpac/cs-CZ.po
build/i18n/po/tpac/en-CA.po
build/i18n/po/tpac/en-GB.po
build/i18n/po/tpac/fi-FI.po
build/i18n/po/tpac/fr-CA.po
build/i18n/po/tpac/hy-AM.po
build/i18n/po/tpac/pt-BR.po

Change 'About PINES' link location

2.7.1 Issue Tracker Wish List requested that the About PINES
link point to http://pines.georgialibraries.org/about/ which
this commit implements.:

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/topnav_links.tt2

LP#1203734 copy circ counts include anon. circs

Circ counts displayed on "Show Last Few Circulations" (XUL) includes
active, anonymized, and legacy circulations (via cstore)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "Fixing LP#1203734 - "Show Last Few Circulations" interface not counting archived circulations."

This reverts commit 4978ead0608a0c45a7e0f0c77380d0548a80e1e1.

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/asset.pm

Add self-registration link to topnav links.

Syncing kpac.xml with rel_2_5_1_kpac

Removing 4th of July KPAC link

Conflicts:
Open-ILS/examples/kpac.xml

Add GALILEO for Kids link to KPAC header.

Display Thanksgiving icon in KPAC.

Conflicts:

Open-ILS/examples/kpac.xml

Added Back to School preset search category

Conflicts:
Open-ILS/examples/kpac.xml

Tweaked searches - ready to push to the public KPAC now (along with the graphics from the last commit)

Updated kpac.xml to feature 2014 Summer Reading Program topics.

2014 Summer Reading Program Graphics

Hiding unnecessary and unpopulated Chilifresh content and NoveList "loading" message.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/src/templates/opac/parts/record/awards.tt2

Forced Awards & Suggested Reads tab to always be open
in order to highlight NoveList Select content.

Updated KPAC to feature 4th of July instead of Easter.

Conflicts:
Open-ILS/examples/kpac.xml

Added Nutrition subcategory under Early Learning category in KPAC.

Swapped out St. Paddy's feature with Easter feature.

Conflicts:
Open-ILS/examples/kpac.xml

Modified kpac.xml to display Easter category

Added README and graphics template for use of KPAC graphics.

Conflicts:
Open-ILS/examples/kpac.xml

Corrected version of kpac.xml with properly nested preset searches

Swapped out Valentine's Day feature
for St. Patrick's Day feature in
KPAC configuration file.

This commit removes confirmation boxes popping up when a hyperlink is clicked

In PINES, we expect the behavior we've always had, so we revert the change.

Revert "Sort of in line with 949322 but not absolutely necessary"

This reverts commit e1a7501799119e0f305616af5bf97149d9bdf4c0.

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Adding Terran's kpac.xml to update topics for post MLK weekend.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Re-applied audience filter to restrict to juvenile audience types.

Modified style guide to emphasize call numbers in search results and item display.

Temporarily hid Add to List functionality until it can be further developed.

Bug fix to recognize user's default pickup library for holds when they are logged in.

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

Changed featured items for KPAC home page.

Adding KPAC link to header and footer.

PINES KPAC landing page doesn't include the Print button.

Correcting file path for PINES logo on KPAC.

Removing "Bib Call Number" from the advanced numeric search options.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

Small changes to Search Limit names and Category names.

Further tweaks to search limits and modifications to book bag links.

Testing modifications to navigation.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Typo in footer.tt2 causing a server error.

Removing "kpac-original" directory in order to keep a clean source directory.

PINES customization of KPAC - beta ready for testing

Updated dewey.tt2

Initial commit of PINES KPAC customizations.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Removing "You have permission to override some of the failed holds." OPAC message

PINES is not yet keeping a history of circ or holds

Conflicts:

Open-ILS/src/templates/opac/myopac/prefs_settings.tt2

Changing the default hold message for when an item is age protected.

PINES Survey Link - TPAC Edition

PINES does an online survey that runs for a week every Spring. These
changes create a red link to the survey above the search bar on the
OPAC home page.

Remove "Claims Never Checked Out" in Items Out summary

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

adding new macros to listed ones

Adding GPLS Helpdesk link to Staff Client portal page and correcting a small typo

Conflicts:

Open-ILS/web/opac/locale/en-US/lang.dtd

Conflicts:
Open-ILS/xul/staff_client/server/index.xhtml

re-adding STAFF_MIDDLENAME, PATRON_MIDDLENAME, PATRON_EXPIRE_DATE, and PATRON_EXPIRE_DATE_YMD to rel_2_3_4

Conflicts:

Open-ILS/xul/staff_client/chrome/content/util/print.js

Revert "Use my_asv here.. surveys pertinent to the workstation library.. in case survey usage ever takes off.  Should probably move some of this to the middle layer"

This reverts commit 54d45c37d91c78cffa00ca3ff0f6298261d548b2.

adding file that returns circ mod view to normal

adding mrpeters' awesome favicon

Changing default hold error messages.

Conflicts:
Open-ILS/src/templates/opac/parts/hold_error_messages.tt2

removing hold/circ history view for patrons until we can review policy concerns

Conflicts:

Open-ILS/src/templates/opac/myopac/holds.tt2

Conflicts:
Open-ILS/src/templates/opac/myopac/circs.tt2
Open-ILS/src/templates/opac/myopac/holds.tt2

adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Remove the hardcoded width of locg dropdown

The hard coded 12em width causes longer library names to be cut
off.  This removes that restriction.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

adding newly designed PINES logos

removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

adding footer and topnav links and logo

Conflicts:

Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/topnav_logo.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Bumping version numbers and adding Changelog

Signed-off-by: blake <blake@mobiusconsortium.org>

Updated server_upgrade.adoc to refelct 2.12.2

Signed-off-by: blake <blake@mobiusconsortium.org>

Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: blake <blake@mobiusconsortium.org>

bumping Perl version string for 2.12.2

Signed-off-by: blake <blake@mobiusconsortium.org>

Translation updates - po files

Signed-off-by: blake <blake@mobiusconsortium.org>

Translation updates - newpot

Signed-off-by: blake <blake@mobiusconsortium.org>

2.10.11-2.10.12 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 2.12.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1478128: Avoid XSS in public catalog

This patch escapes various GET param values by passing them through
the Template Toolkit html filter, including:

* in the locale picker
* in the searchbar
* in the login form

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 2.12.2 Maintenance release notes

Well, this turned out to be a busy maintenance release. Lots of bug fixes
are now outlined in the 2.12.2 release notes.

This commit also adds a missing new feature - LSE setting for default
status for received acq line items - to the 2.12.0 notes.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.5 maintenance release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1677902: Remove search formats from advanced search limiter block

The original behavior of the advanced search limiter block was to remove
search formats from the display because it is available for limiting in the
search bar. Other code broke this behavior, and I've now restored it by
adding the ignore search format code to the searchbar.tt2 file. It also fixes
a problem where the search format limiters were incorrectly displaying on the
low hits page.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1650410: include --days_back in synopsis and other tidying

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1650410: doc authority_control_fields.pl's --days_back flag

This patch updates the POD that in turn is displayed when
running authority_control_fields.pl -h

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1690468: fix Exclude Electronic Resources checkbox with advanced search limiters

When advanced search limiters are applied, you cannot successfully
uncheck the Exclude Electronic Resources checkbox.  When you uncheck it,
your current search is reloaded, but e-resources are still excluded
(and the box remains checked).

When you use the checkbox to exclude e-resources, the search form on the
results page contains a hidden input element:

<input type="hidden" name="fi:-search_format" value="electronic" />

This commit uses Javascript to remove that element from the search form
when the box is unchecked, before submitting the search.

Test plan:

[1] Enable the "Exclude Electronic Resources" checkbox in config.tt2.
[2] Do an advanced search, applying at least one search filter (e.g.
    Language = "English").
[3] On the search results page, check the Exclude Electronic Resources
    checkbox.  This repeats your search, excluding e-resources.
[4] Uncheck the Exclude Electronic Resources box.  Your search is
    repeated, but e-resources are still excluded and the box remains
    checked on your new results page.
[5] Apply this fix.
[6] Refresh the page or clear your browser cache, and try to uncheck the
    Exclude Electronic Resources box again.  This time, it should work:
    e-resources will no longer be excluded, and the box is unchecked
    when your new results page loads.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1610246: add upgrade note

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1610246 Classic Circulation View excluding circulations

The reporter.classic_current_circ view, which is available via
Open-ILS/src/sql/Pg/example.reporter-extension.sql, was excluding
circulations because it was assuming all users have a billing address
This branch corrects that with a LEFT JOIN.

No upgrade script will be included since these views are not assumed
to be installed by all Evergreen instances.  Please re-run the
example.reporter-extension.sql file to apply this change for your
instance.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1491875: avoid erroneous "unsaved data" popup during MARC record creation

Test plan
---------
[1] Navigate to Cataloging -> Create New MARC Record.
[2] Choose a template, click Load
[3] Enter data in a fixed field, for example, Date1
[4] Enter data in a MARC field such as 100
[5] Click Create Record:

    The "This tab may have unsaved data. ..." pop up will appear.
    Clicking OK will save the record and take the user to their default
    view of the record.
    Clicking Cancel will save the record and return the user to the MARC
    Edit screen.
    The behavior when clicking Cancel can lead to confusion as to
    whether the record has actually been saved.

[6] Apply the patch and repeats steps #1-#5.
[7] This time, no extraneous unsaved data warning should appear.

Note that this patch's kludge doesn't fix all possible instances
of the warning; see https://bugs.launchpad.net/evergreen/+bug/1491875/comments/6
for details.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
SIgned-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1677661 Hold targeter live test use API, etc.

Teach the hold targeter live tests to call the open-ils.hold.targeter
API instead of calling the now-defunct Utils::HoldTargeter batch
targeter function.  Apart from the loss of this function, calling the
API allows the live tests to exercise more of the targeting code.

Teach the live tests to test --soft-retarget-interval instead of the
deprecated --skip-viable option.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1677661 Targeter V2 remove unused batch API

Remove the unusued batch target() function from Utils::HoldTargeter to
avoid code duplication.  The same (but more resilient) batch targeting
construct exists in the open-ils.hold-targeter API.

Move API docs from Utils::HoldTargeter to the open-ils.hold-targeter API
docs for added visbility / findability.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1677661 Targeter V2 extras release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1677661 Hold Targeter V2 Repairs & Improvements

* Make the batch targeter more resilient to a single-hold failure.

* Additional batch targeter info logging.

* Set OSRF_LOG_CLIENT in hold_targeter_v2.pl for log tracing

* Removes the confusingly name --target-all option

* Adds a new --next-check-interval option for specifying when the
  targeter will next affect the currently processed holds, which may be
  different that now + retarget-interval in cases where the targeter is
  not constantly running.

* Replaces the --skip-viable option with a new --soft-retarget-interval
  option, allowing for time-based soft-targeting.

* Soft-targeting now updates hold_copy_maps for all affected holds, not
  just those requiring a full retarget.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1618949 Required patron stats format repairs

Fixes a broken div column class, which caused the patron stat cats to
stretch across the page.

Other div nesting/formatting fixes and additional inline code comments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1618949 Patron edit forces required stat cats

Display required stat cats as required form fields and prevent the
patron editor form from submitting when required stat cats do not have
values.

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1670242 Webstaff checkin transit holds addr fix

Gracefully handle cases where a checkin results in a transit to a branch
with no holds address.  Route dialog and print templates now display "We
do not have a holds address for this library. "

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Webstaff: hide behind-desk option when not supported

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>