Speed up holds history retrieval

Consistent w/ circ history retrieval, use the longer column 'transform'
stored proc invocation to limit retrieval to historical holds IDs
instead of entire objects, which are later fetched/fleshed anyway.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Faster T-pac circ history retrieval

* Take advantage of the new default sorting behavior of
action.usr_visible_circs to perform limit/offset within the DB instead
of fetching the whole circ history in the mod_perl code and sorting
through it.

* Also use the  more powerful/verbose column transform syntax for
calling stored procedures to retrieve only the historical circ IDs
instead of the full circ objects, since we are re-fetching fleshed circ
objects later in the code.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix title/author sort.  Use SVF 'titlesort'/'authorsort'

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Repaired qtype bug introduced w/ bool searching

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Speed up hold editing by only fetching hold to edit

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Repaired bug in t-pac org selector value propagation

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

Merge branch 'master' of git.evergreen-ils.org:Evergreen into template-toolkit-opac

Repaired seed data T-pac merge conflict

Signed-off-by: Bill Erickson <berick@esilibrary.com>

lp758945: make receipt template macros repeatable

Patch from Jason Boyer to allow macros to be used
more than once in a section; prior to this patch, only
the first occurrence was replaced with the substitation
value.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Update the README to include database installation instructions

A long time ago, the database server was installed by default.
Nowadays, installing the database server is a separate step
reserved for whatever machine you want to devote to PostgreSQL.
Not that you can't put it on the same machine as the rest of
Evergreen and OpenSRF...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Fixed typo in vandelay UI

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Stamped upgrade script for user/miker/replace_field_fix

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Have replace_field return input XML when no replace rule is provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'rec_attr_def_config_avoid_cxt_fetch'

Avoid xml_transform retrieval in record attr def editor

config.xml_transform stores large chunks of XML.  Fetching it angers
Ejabberd on my test system.  All we need is the name, so use the new
AutoFieldWidget.searchOptions param to do just that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add the new patron retrieval to the toolbar

Specifically, in the little list of things that shows up when you use the arrow next to patron search.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Label tweaks re: Database ID vs Record ID, etc.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Add "Retrieve patron via Database ID" menu entry

Add "Retrieve patron via Database ID" menu entry to top-level Search menu

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Allow advanced search bool selectors to size down

... to avoid unnecessary horizontal screen gobbling

Tested in Chrome, FF, and IE

Signed-off-by: Bill Erickson <berick@esilibrary.com>

calculate penalties when letting Mark Item Damaged add bills

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix oils_i18n_gettext id numbers

config.metabib_field ids 29/30 had 28 for translation id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Support for boolean operators in advanced search

Implements a new column with And/Or selectors.  Terms are grouped from
top to bottom in the UI as left to right in the compiled query.

A && B || C && D  => ((A && B) || C) && D

Signed-off-by: Bill Erickson <berick@esilibrary.com>

maketext filter must be registered as a dynamic filter to properly handle arguments

Signed-off-by: Bill Erickson <berick@esilibrary.com>

AutoFieldWidget support for augmenting pcrud search options

Adds a new searchOptions attribute to AutoFieldWidget for specifying
additional parameters to pcrud when retrieving linked objects.  The
initial use case is for supporting a "select" list to allow
AutoFieldWidget to retrieve only the display column of a linked object
and not the whole object.

Example:

 // fetch 'remote_field_name' on the remote objects instead of
 // fetching the entire object

 myGrid.overrideWidgetArgs.some_field = {searchOptions :
 {"select":{"some_hint":["remote_field_name"]}}};

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Remove KCLS mattype SQL seed data comment

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Bypass install_filter mem leak via direct insertion

See https://rt.cpan.org/Ticket/Display.html?id=46691

On the one hand we have a memory leak, on the other we have a bug caused
by the fix to the memory leak.  Bypass this altogether and insert the
filter manually into the template environment using Template's FILTER
configuration argument.  This has the added bonus of simplifying the
i18n filter code.

Since the filter is manually inserted, it's not necessary (and possibly
counter-productive) to USE the filter directly in the template.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

use isNaN here, since NaN == NaN => false

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Clean up OpenSRF::AppSession objects after use

These things need ->kill_me called on them after we're done using them.

(note to self: check to see if we can just add a DESTROY sub to that
package)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'template-toolkit-opac' of git://git.evergreen-ils.org/evergreen/equinox into template-toolkit-opac

Fix incorrect search advice on the no-results page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

advanced/cnbrowse label tweak

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Prevent undef warnings on org unit lookup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

cnbrowse tweaks

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Direct entry point into the call number browser

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

If there's no sort org unit, just fall back to the usual sorting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Don't build image tags for non-existing mattype icons

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Sort copies on record detail page with copies belonging to "sort org unit" first

"sort org unit" needs to eventually be an abstract concept that could
either refer to "orig_loc" or to "loc" or perhaps be skipped altogether,
depending on some future configuration.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix broken builds due to test that can't find its data

LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

item_barcode had broken the rest of numeric search

but now it's fixed

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Minor code cleanup of unused code; avoids Apache warning

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Avoid server-error on barcode search when barcode not found

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Make users confirm they really want to delete lineitems from POs...

... when they've already been ordered. There's really no reason to ever
make such a deletion this that I can think of, but I use a confirm()
instead of stricter measures in case I'm missing something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Stamped upgrade for user/dbs/oclcnumbers

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Prevent control numbers from duplicating

In maintain_control_numbers(), if you have more than one 001 or
003, and at least one is the correct one, you will end up
duplicating the correct number every time the record is saved.

For example, if the incoming record was record ID # 12345, and
the record contained:

001: 12345
001: ocm10202

... then after maintain_control_numbers() ran, the record would
contain:

001: 12345
001: 12345

Also, clean up some leftovers from the refactor I suggested in the
previous commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add an unwrapped upgrade script for OCLC-aware control numbers

The upgrade script creates the SCN and LCCN search indexes and
populates them using metabib.full_rec as a source; cheating, but
the normalized values will work for non-exact search purposes. Sites can
reingest all of their bibs if they want exact search to work.

Also, refactor maintain_control_numbers() using a suggestion by
Dan Wells to eliminate some duplicate code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Treat OCLC numbers specially in maintain_control_numbers

For some reason, many records that come with OCLC numbers in the 001
field are not populated with a 003 field. This resulted in the OCLC
number being thrown away entirely, rather than being moved into the 035,
as there was no corresponding control number identifier field.

However, given that we know that control numbers starting with "ocm" or
"ocn" are special OCLC numbers, we can generate the 035 accordingly even
in the absence of a 003. This update to maintain_control_numbers()
teaches it to do the right thing for OCLC numbers.

In addition, add an identifier search index so we can easily find
records by their system control numbers (035 $a subfields).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Add lccn field to the identifier search class"

This change will be absorbed when merging working/user/dbs/oclcnumbers,
which I will do pronto...

This reverts commit 94f69d21b6759dc43c151c7796dafee74083f62c.

Add lccn field to the identifier search class

Facilitates easily searching by LCCN (010 ‡a).

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

Redirector support for T-pac

Includes new Apache configuration option:

PerlSetVar OILSRedirectTpac "true"

"Original location" is tracked initially as a URL param (orig_loc), but
is ultimately absorbed into a cookie (eg_orig_loc) since the URL param
would otherwise have to be propagated to every page.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

You can now have multiple rows in your MARC Expert Search

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

MARC expert search working

This just needs the JS row cloning so you can search on multiple terms
at a time.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

It's ugly and hacky, but numeric search fully works (item barcode included)

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

SIP2 support for checkin local holds as transits

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Capture local holds as transits checkin modifier

Capture holds (not already on hold shelf) as transits instead.

Use cases may include:

New material being cataloged before it is "released". If captured normally
before release the shelf expire time would start ticking and notices would go
out.

Checking items in on a closed day. Can capture holds to avoid them being on a
pull list and set them aside to avoid "ready for pickup" notices and ticking
shelf expire clock.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Auto-retarget local holds on "new" copy checkin

When a new item is checked in local holds will be searched and re-targeted.

The search and retarget stops when a hold is found locally that the item can fill.

Already-captured holds will not be retargeted.

"New" is (currently) defined as "In progress" at checkin

Retarget occurs:
Only if the copy's circ library is the checkin library
Only if the checkin is an actual checkin (not a renewal)
Only if the checkin is capturing holds and transits

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Clear Shelf Expired Hold on Checkin

Only if modifier is set and at the pickup library.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

move query params into the constants to better support current opac and TT-opac

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

Metarecord list on results page

Added a new ?metarecord=<mrid> param to opac/results page to list
records associated with a given metarecord ID.  This is used as page 2
of the (pending) metarecord search process as well 'show in catalog'
for embedded staff client metarecord holds.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Numeric search mostly works (except for item barcode)

Expert search is next

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'template-toolkit-opac' of git.evergreen-ils.org:evergreen/equinox into template-toolkit-opac

minor I18N text wrapping

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Don't show users who are already logged in a login form; that's confusing

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Confirm CC payments with another page load, not confirm() popup

This does something gross. Your CC card number is rendered in a hidden
field on the last confirmation page.  At least it's all SSL only.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Show most up-to-date email address in update-email interface

plus cosmetic change to payment mini table

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

CC payment improvements:

Link from receipt after payment back to account summary.

Error reporting

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Better to tell the user something rather than nothing

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add missing INVALID_USER_XACT_ID event

Code introduced in c5d36d2a99e45b9a02d00a1e795b66a38c271b43 (SVN r17079)
can generate this event.  The description I gave it is meant to be
kind of user-oriented, since patrons might see it in the OPAC.  A
somewhat more informative description in available in the commit I named
above.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Remove ? icon by "Security Code" in payment form

It can go back in later if we want to make it actually do something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Give the patrons the opportunity to see and change their e-mail address...

... before they submit fine payments.  This way they have a better
chance of getting a receipt e-mailed to them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamped upgrade script for persistent_login_default_perm

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Add the PERSISTENT_LOGIN permission to the system, and ...

... make it belong to Users (which includes Staff and Patrons) by
default.

This doesn't mean that all logins are persistent (long-lived) by
default, it just means that users do have the permission to request a
long-lived auth session by default.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Persistent logins are more of a "stay logged in" feature than a "remember me"

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Load embedded OPAC via SSL by default, w/ override option

* url_prefix option for using/forcing SSL.
* oils.secure_opac preference for doing such with the embedded OPAC

--------

To use the preference, you may want to include something like this in server/skin/custom.js:

// Force non-SSL for the OPAC
try {
    netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");
    var prefs = Components.classes['@mozilla.org/preferences-service;1'].getService(Components.interfaces['nsIPrefBranch']);
    if (!prefs.prefHasUserValue('oils.secure_opac')) {
        prefs.setBoolPref('oils.secure_opac',false);
    }
} catch(E) {
    alert('Error in custom.js trying to set oils.secure_opac preference to false: ' + E + '\n');
}

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Links to return to payment history from receipt print/email pages

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Ubuntu Lucid needs MARC::Record from CPAN

As Ubuntu Lucid ships with MARC::Record 2.0.0, and Serials requires
2.0.1 or greater, we must install MARC::Record from CPAN or face failing
open-ils.search requests.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Select-all checkboxes for fine payment

In the process, had to change the checkbox/cgi param name of the misc
fees to xact_misc and tell the middle layer to lump xact together with
xact_misc.  Should test carefully.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Correctly populate certain columns in the patron Messages interface

When applying penalties, the csp's referenced by the ausp's are fleshed.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Stamped upgrade script for checkout_fills_related_hold_exact_match

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Unwrapped Upgrade Script

for Checkout Fills Related Hold modifications

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Checkout Fills Related Hold modifications

Two changes:

1 - Check hold_copy_map for related holds

This removes the "Title or Volume hold only" restriction, allowing any hold type to fill.
This check happens first whenever the option is enabled.

2 - Add new option for *only* checking hold_copy_map.

This allows for non-holdable copies to not fill Title or Volume holds on checkout.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Stamped upgrade script for uncheck_bills_and_unfocus_payment_box

Signed-off-by: Bill Erickson <berick@esilibrary.com>

GUI: Uncheck bills by default in the patron billing interface

Org unit setting and behavior.  Also defaults the focus to the Uncheck All
button instead of the Payment Received field in that interface.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Empty case for payment history

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Add support for Holds and Items counts in dynamic staff Record Summary

(use 'holds' and 'items' with your
oils.bib_brief.*.dynamic_grid_replacement.data customizations)

Also make the Bib Call # retrieval asynchronous and dependent on the field being
configured for display.  This branch has merged in (and depends on) the changes
from collab/phasefx/dynamic_bib_brief

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

LP#813151 Copy Location sort order in Advanced Search

This patch addresses the unintuitive copy location sort order in
Advanced Search when searching at a specific branch. Thanks to
Dan Wells for the code suggestion which changes the order in the listbox
to alphabetical sort by asset.copy_location.name.
Tested, and confirmed working in 2.0.4 test and production environments.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

YAOUS to limit OPAC payment history display to configured interval

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'acq-copies-li-summary-etc'

Lineitem copies page layout changes

Move the Distribution Formula selector above the batch editor widgets
mainly so the batch editor widgets sit closer to batch edit target copy
grid.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

NOVELIST/CHILIFRESH include statements missing a hash which was causing (none) errors.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Show LI summary in copies display page

Using the new, self-contained Lineitem.fetchAndRender, show a full LI
summary along the top of the LI copies edit page.

Includes some minor layout smoothing

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Merge branch 'xul_date_sort'

adjust legacy xul column definitions for dates/timestamps to ensure correct  sorting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>