Merge branch 'master' of git.evergreen-ils.org:Evergreen into kpac

Org Unit Custom Tree supports add directly after delete

When deleting a node from the custom tree, it's necessary to save the
tree store after the final call to store.deleteItem, or the delete
operation will not complete.  Without this, it's not possible to add a
remove org unit back into the custom tree without reloading the UI.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Org unit custom tree sort repairs

Repairs a problem with detecting and storing the sort order of sibling
nodes within custom trees.  The original problem was the result of
comparing parent nodes for non-siblings because of a depth-first tree
traversal.  Now we process siblings in level-order before processing
child nodes.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Bug 957453: Fix error in database seed data

The use of an explicit ID in creating a new
action_trigger.event_definition row was followed by the use of the
CURRVAL() function to grab the most recently issued value for
the action_trigger.event_defintion_id_seq sequence - which happened to
be 100, due to a previously issued SETVAL() on the sequence.

This resulted in references to non-existent event definitions and thus
an error in creating the stock database schema.

By using an explicit ID for the dependent row, we avoid this error.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

README: Clarify PostgreSQL 9.1 vs. 9.0 remote server docs

Break out the PostgreSQL 9.1 or later instructions into their own
subsection to clarify how the steps differ from PostgreSQL 9.0.

Signed-off-by: Dan Scott <dan@coffeecode.net>

TPAC: Show deleted record warning for deleted records

At the cost of an extra database query per record displayed, we can
properly activate the "This record has been deleted..." message. Prior
to this commit, the message was embedded on every page but hidden via
CSS - which isn't great for search engines or source-reading types.

Now we only include & display the message if it has, in fact, been
deleted.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Ben Shum <bshum@biblio.org>

Stamp tpac value maps upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Add "Simple" flag for selectors

This causes JSPac to ignore them and TPac to sort them above a divider.

Also fixes an issue where excessive escaping was being done on values. This
would break some values in the value map selectors.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Add i18n tag to coded value map value/description

Because the seed data assumes they are translated, so tell the IDL.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Coded Value Maps Opac Visible/Search Labels

Add two new fields to Coded Value Maps:

1 - Opac Visible, for "does this show up in opac limiter boxes"
2 - Search Label, for "what does this get called for those boxes"

Intended use cases include:

Re-labeling MARC fields without changing the base MARC information, say
because you don't expect patrons to understand "Projected Medium".

Hiding things that don't apply, say the vast majority of language limiters,
without needing to delete rows.

I also hooked it up in JSPac, because it was easy to do so.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

kpac : added content work

1. Consolidated added content apache configs under /eg
2. Added (untested) code to support LibraryThing reviews.
 -- It looks like we'll need to coordinate w/ LT to get it all hooked
 up.  More research pending.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : hold placement; more auth refresh repairs

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : wire up home search; auth timeout redirect fixes

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : initial login + place hold combined action

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : initial chilifresh integration

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : getit save to existing list

Signed-off-by: Bill Erickson <berick@esilibrary.com>

tpac: minor code formatting

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac: save to anon-list

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : config and template work

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : i18n, cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : rename files/paths for tpac consistency

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : holds, misc

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : initial holds; misc

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : copy table; record details

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : record details

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : trucking along

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : basic search box

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : breadcrumbs, paging, misc

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : templating; url-based searching

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : template-ifying

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : template-ifying

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : template-ifying

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : template-ifying

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : trucking along

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : infrastructure

Signed-off-by: Bill Erickson <berick@esilibrary.com>

kpac : config experiments

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fixed a slight misspelling, as noted in https://bugs.launchpad.net/evergreen/+bug/915564

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Merge branch 'master' of git://git.evergreen-ils.org/Evergreen

Merge remote branch 'working/user/dbwells/shared_siss_editor'

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix failure of 'My Selection Lists' interface

Addresses this bug: https://bugs.launchpad.net/evergreen/+bug/967824

Recent changes to the mechanism of unified search (for which 'My
Selection Lists' is a frontend) lacked code that respected
the new join structure for some use cases.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Serial Control: Use Dijit-based issuance editor"

This reverts commit 37b324f53adb4fb90fe17ada72d44fca1d606e9f.

This commit was regrettably merged without other commits from its
branch on which it depends.

Remove located URI scope notes from 2.2 Release Notes

The located URI scope change occurred in the 2.1 time frame, not in 2.2,
so remove from the Release Notes.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add ui.hide_copy_editor_fields to baseline seed data

Without it, the "Hide Fields" option in the copy editor will not
function.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Update 2.1-2.2 version upgrade script for beta1

Including missing chunks and missing commas.

Moved 0693 to the end, it may exist in some 2.1 installs.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Stamping upgrade script for "Org unit selective hiding and sorting in tpac library selector"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Custom Org Tree : Admin UI honors "activate" on new trees

Previously, activating a new tree would work, but the UI did not update
to reflect it.  Now the activate link correctly turns into a de-activate
link and vice versa.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPac: non-inherited org unit visibility : hide copy counts

Avoid showing copy counts for non-opac-visible org units in the search
results and record details page.  This is important when the
'opac.org_unit.non_inheritied_visibility' global flag is enabled, as org
units along the tree may be non-visible.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Custom Org Tree : Admin UI

New UI for managing custom org unit trees.  (Only OPAC is supported for
now).  Custom trees default to the same shape as the full org unit tree.
Staff can remove nodes and re-order nodes.  Staff can also replace
deleted nodes by dragging them from the reference tree on the left.

Admin -> Server Admin -> Custom Org Unit Trees

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Custom Org Tree : tpac

If configured and active, the tpac will now use the custom 'opac' tree
for the org unit selectors.  This will be true in both the public
catalog and the staff client catalog.  The staff client catalog will
continue to display hidden org units.

If the opac.org_unit.non_inheritied_visibility global flag is set, the
public catalog will display child nodes of hidden org units in the
custom tree.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Custom Org Tree : DB and IDL

Support for building custom org unit hierarchies for display purposes.
Initially, this is meant to support custom OPAC trees, but the design
leaves from for other types of trees.

The only restrictions to custom org trees is that no org unit appear
more once and that they in fact be tree-shaped.  Otherwise, any node
can be the parent/child of any other node, regardless of ou_type, etc.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repaired non-slim org unit fetching bug

Fixed an old thinko.  When fetching a full org unit object, set the
children org unit array value instead of clobbering the function.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPac: non-inherited org unit visibility

Adds support for displaying org units that are children of hidden org
units in the tpac org unit selector.  A new global flag was added to
control this behavior called "opac.org_unit.non_inheritied_visibility" /
"Org Units Do Not Inherit Visibility".

To avoid confusion / distorted org unit trees, children of hidden org
units are left-padded one less for each hidden parent org unit.  For
example, in the stock org tree, if Sys2 is opac_visible=false (and the
global flag is enabled), the tree in the tpac would appear like so:

Cons
- Sys 1
-- BR1
--- SL1
-- BR2
- BR3
- BR4

Similarly, if CONS was also hidden, the whole tree would be shifted left
by 1 pad depth.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Merge branch 'revert-lp954310'

Reverting commits from LP 954310, since the wrong branch was merged.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "TPac: non-inherited org unit visibility"

This reverts commit 1b7c563166d60ddee4a9c507f3eded07bc5e70c0.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Org unit sibling display sort order"

This reverts commit dee33cc9da90762dea9b9aa13190c65e80f07577.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Repaired non-slim org unit fetching bug"

This reverts commit 706f1e86f0b9e4b5423b1b355bd30db422316068.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Org unit sibling display sort order : admin UI"

This reverts commit 1108cfc0b3978dc0fd80566a2b654edcf6b99d55.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Revert "Stamping upgrade script for "Org unit selective hiding and sorting in tpac library selector""

This reverts commit a25aa4e66ce4080bac65cd702a1e51542d5bae7e.

Signed-off-by: Bill Erickson <berick@esilibrary.com>

remove some cruft

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

add context menu to xul list column headers

for multi-sort options.  Also fix ascending vs descending internally (since the
distinction is now exposed via labels)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

xul list secondary sorting

For xul-based lists in the staff client (interfaces with a grey background),
normal behavior is to sort the list when you left click a column header.

This is still the case, but now if you control+click a column header, it sets
up that column as a secondary sub-sort.  Control+clicking more columns will
set up subsequent sub-sorts.

Normal click a column header for primary sorting will clear out all previously
defined sub-sorts.  Control+clicking when a primary column has not yet been
normal clicked effectively does nothing.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

mitigate race conditions with ordinal line number column

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Acq - fix cloning of picklists so that all lineitems are cloned with a 'new' state
This prevents duplicated items on purchase orders when the picklists are cloned and
other wacky problems.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Org unit selective hiding and sorting in tpac library selector"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Org unit sibling display sort order : admin UI

Adds a new menu entry for Local Admin called "Library Sort Order", where
staff can configure via drag-n-drop the sibling display order for org
units in the opac.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Repaired non-slim org unit fetching bug

Fixed an old thinko.  When fetching a full org unit object, set the
children org unit array value instead of clobbering the function.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Org unit sibling display sort order

Adds a new "sibling_order" column to actor.org_unit which specifies the
order in which an org unit should be sorted as compared to its sibling
org units in org unit trees.

This commit adds the IDL/DB components.  It also updates the tpac and
the generic get_org_tree API.  (Note, a follow-up commit will be pushed
to remove some deprecated / reduntant org tree retrievals).

Note that the sibling_order values do not have to be unique within each
set of siblings.  The org unit name is still used as a tie-breaker sort,
so if the sort order is left unset (i.e. all values are 0), org units
will fall back to name-only sorting.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPac: non-inherited org unit visibility

Adds support for displaying org units that are children of hidden org
units in the tpac org unit selector.  A new global flag was added to
control this behavior called "opac.org_unit.non_inheritied_visibility" /
"Org Units Do Not Inherit Visibility".

To avoid confusion / distorted org unit trees, children of hidden org
units are left-padded one less for each hidden parent org unit.  For
example, in the stock org tree, if Sys2 is opac_visible=false (and the
global flag is enabled), the tree in the tpac would appear like so:

Cons
- Sys 1
-- BR1
--- SL1
-- BR2
- BR3
- BR4

Similarly, if CONS was also hidden, the whole tree would be shifted left
by 1 pad depth.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Serial Control: Use Dijit-based issuance editor

The serial control interfaces use editors derived from the XUL
copy editor, while the alternate control uses Dijit editors.  This
commit takes a small step toward unification by using the Dijit
issuance editor within the serial control interface, with the
following benefits:

1) Both controls will have a very similar editor look and feel
2) Takes advantage of custom holding code wizard widget
3) Future fixes and enhancements to the editors will apply easily
to both controls
4) Begin deprecating XUL serial editors

This commit doesn't yet rip out the old issuance editor code, as
that should wait until the transition is more complete.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping Stat Cat Enhancements upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: SQL upgrade statements

Add SQL upgrade statements:  new table stat_cat_entry_default,
new columns 'required' and 'allow_freetext' on actor.stat_cat,
and new permissions to create, delete default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Only show default entry for new patrons

Only display the default entry when registering new patrons.
Otherwise, display the saved value for the patron or nothing.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Rearrange stat cat editor screen

Rearrange the statistical categories editor interface to correctly
display the "Archived" radio buttons along side the other radio
buttons.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Fix values stored, then displayed in "Allow freetext" categories

In the patron registration screen:  the widget dijit.form.FilteringSelect
stores the option value, not the displayed value, unlike ComboBox; so store
the FilteringSelect displayedValue, then set the FilteringSelect displayedValue
with the value retrieved from the patron/stat_cat_entry map table.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Enforce stat_cat "allow_freetext" flag in patron registration screen

If a patron statistical category is flagged to disallow user-provided
entries, make the category form field a FilteringSelect box;  otherwise,
make it a ComboBox.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Enforce stat_cat "required" flag in patron registration screen

If a patron statistical category is flagged as required, make
the category form field a required field, and validate it before
submitting the form.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Modify stat cat editor HTML to manipulate patron stat cat default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Modify stat cat editor javascript to manipulate patron stat cat default entries.

Add functions, methods, variables to Statistical Categories Editor
javascript to manage patron stat cat default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add language entities for default stat cat entry labels.

Add label entities for setting a default entry;  rename staff.server.admin.stat_cat.edit_entry_name_submit
to staff.server.admin.stat_cat.edit_entry_submit.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add permissions for manipulating stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add Publisher actor methods for stat_cat_entry_default objects.

Add methods actor_stat_cat_entry_default and actor_stat_cat_entry_default_ancestor
to retrieve and populate stat_cat_entry_default objects.  Modify ranged_actor_stat_cat_entry
and fleshed_actor_stat_cat to also include default entry objects, if present.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add Pg DBI actor::stat_cat_entry_default table and sequence.

Add actor::stat_cat_entry_default->table and
actor::stat_cat_entry_default->sequence.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add CDBI package actor::stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Link CDBI actor::stat_cat_entry_default to parent entities.

Add relations between actor::stat_cat and actor::stat_cat_entry to actor::stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add OpenSRF CRUD methods for actor statistical category default entries.

Added methods to create, delete, update default entries for patron statistical
categories.  Modified create_stat_cat and create_stat_cat_entry to also create,
update stat_cat_entry_default objects if present in the request.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add OpenSRF methods for retrieving actor stat cat default entries.

Added the methods 'fetch_stat_cat_entry_default' and
'fetch_stat_cat_entry_default_by_stat_cat_and_org' for
fetching stat_cat_entry_default objects.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add event for ACTOR_STAT_CAT_ENTRY_DEFAULT_NOT_FOUND

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add stat_cat_entry_default IDL class

Add stat_cat_entry_default IDL class, and links to actor.stat_cat and
actor.stat_cat_entry

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add default entry table to database

Add actor.stat_cat_entry_default table to Pg database.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add 'allow free text' and 'required' flags

Add database entities, controller mappings, and HTML/Javascript
widgets to allow administrators to set and persist 'required'
and 'allow free text' boolean flags for patron statistical categories
in the Statistical Categories Editor.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Merge branch 'new_toolbar_icons'

Functional, but a bit mismatched with existing icons in my opinion

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

missing comma. tsbere++

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

FlattenerGrid (re)honors IDL column labels as default

Linking the GridColumnPicker to FlattenerGrid killed the ability for the
FlattenerGrid to fall back to the IDL column label when no label was
defined in the markup.  This change adds a reloadStructure operation to
GridColumnPicker.  FlattenerGrid uses this to pass the updated column
labels (and any other changes) to gridcolumnpicker, which then updates
the grid display to match.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for serials holdings display improvements

Signed-off-by: Mike Rylander <mrylander@gmail.com>

holding_type on serial.issuance not quite dead

The holding_type field was removed from the serial control editor
prematurely, and this missing data was a source of mild friction.
We'll put it back for now.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Simplify serial.materialized_holding_code

Attempting to materialize holding_type and ind1/ind2 for less than
perfect data causes problems.  Since we aren't actually using this
data, let's get rid of these fields.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Only load "new" serials display if we have data

If we try to load the "new" serials display template, but have no
data (for instance, if "Use fully compressed serial holdings" is
false), we get a server error.

Rather than wrap the whole template in an 'if', let's just not
load it.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: ROWS 1 not appropriate here.

I must have thrown this in as a misguided afterthought without testing
it.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: follow-up to serials holdings paging fix

Some how I didn't notice it before, but my last commit broke things.
This unbreaks them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>