LP#1743783 Web Client Bill Full Detail Display Issues

Fleshes out retrieved data to be able to display the billing
location for both circulation and grocery bills on the full
details page as well as the owning library for circulation bills.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1662535 Patron Bill Grid Columns

1) Adding missing columns, including:

- Call Number
- Owning Library
- Shelving Location
- Last Billing Note
- Last Billing Timestamp
- Last Payment Timestamp
- Last payment Note
- Last Payment Type

2) Corrected path for Type

3) Changed column name for Location to 'Billing Location'
and the former Billing Location to 'Grocery Billing Location' for clarity

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

Offline Interface: Display text for non-cataloged items

When a non-cataloged item is checked out, display preview
text instead of a blank barcode.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

PINES Customization: Alert when no hold notification options

Present an alert if no notification options are selected in
both the OPAC and web staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

enable ebook API for RBDigital

PINES Custom: Adjust top menu bar in OPAC for baskets

- Adjust spacing so that the basket doesn't go off the edge of the
menu bar.
- Add responsive code as well.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom Offline Checkout and Renew Receipts

- Correct due date to not show due time.
- Show 'Non-cataloged Item' text when there is no barcode.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

PINES Custom fix for Patron Self Registration Form DOB Validation

This moved away from master at some point. This patch brings it back
in line along with correcting a dob format checking error.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP#1726568: expose circ lib and owning lib fields to spine/pocket labels

This patch fleshes the item circulation library and owning library
fields so that spine/pocket labels can include the short name or
full name of the OU rather than just the ID.  As a consequence, the
following fields are now available for label templates:

* copy['call_number.owning_lib.id']
* copy['call_number.owning_lib.shortname']
* copy['call_number.owning_lib.name']
* copy['circ_lib.id']
* copy['circ_lib.shortname']
* copy['circ_lib.name']

If, for some reason, existing label templates intentionally use
copy['call_number.owning_lib'] or copy['circ_lib'] to include the numeric
ID of the OU on the label, they will need to be replaced with
copy['call_number.owning_lib.id'] or copy['circ_lib.id'] respectively.

To test
-------
[1] Apply the patch.
[2] Open the print labels window for an item and try including one
    or more of the new fields listed above; verify that the current
    value is displayed on the label preview.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: more file mode fixes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: update DB installation and upgrade scripts

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed holds issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed the logic display Download link for checkedout item even if they are not available

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Removed unwanted statement

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Resolved caching, holds, and checkout issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed a bug with checkouts and holds API call

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Added Library User Name and PIN element for registration

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issues related to caching, page refresh, and add libraryCard number to register api call

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issues related to Caching

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Enhanced application to support multilibrary and architected sessions for ebook

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed search and css issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Removed hard coded API_URL from code and add to the database

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Added Link to Wishlist Title, Fixed CSS issues, Changed Buttons on Holds, and other minor fixes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Added RBdigital links to social, changed registration failed text, minor css changes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issues with Sorting and added image assests

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Changed code to display RBdigital only when user home library is tied to RBdigital library

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Added blank target for hyperlinks

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Changed Registrationn Form output and various other changes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed Search issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Changed Registration form, added code in the backend to save email into evergreen if changed

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issue related with Advanced Search when navigating from PINES to RBDigital Tab

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: do not enable RBDigital service by default

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: tweak release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: add some release notes and installation instructions

Some text initially written by Jaswinder Singh <Jaswinder.Singh0011@gmail.com>.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: add some guards

Avoid crashes if the RBDigital API is not available or incorrect
tokens are configured.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: add global flag to control display of digital search tab

This patch introduces a new global flag, extras.enable_digital_resource_search_tab,
that controls whether the public catalog search tab for digital
resources is displayed. If that flag is not turned on, the tab
is not displayed and unnecessary RBDigital initialization code
is bypassed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: remove ebook_rl table, which is no longer used

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: added RBDigital search language

Signed-off-by: Jaswinder Singh <Jaswinder.Singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Added message at Login

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Changed the code to accommodate new Registration Response Structure

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: adjust how additional JS/CSS deps are brought in for master

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: sort out fm_IDL.xml changes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: schema updates

This includes tables used by the RBdigital integration, putting
them in a new schema called 'extra' that's meant to collect
Evergreen extensions and integrations that are optional but ship
with Evergreen.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: sort out seed data and upgrade for new RBdigital YAOUS

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: correct some copyright and license statements

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: remove extraneous changes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: don't enable integrated e-resource content in stock

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: clean up a couple uses of cache_key

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: file mode fixes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: remove extraneous file

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: fix typo

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed vendor tab issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Resolved multiple issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed multiple issues and add the ability to return an e-item

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Minor fixes

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issues with advanced search, Tab name, and wishlist

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed search and other issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Enhance the add to display wishlist on myopac page

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed the search issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Resolved multiple issues

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed issues dealing with search feature and new User

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Fixed download issue

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: Implementation of Checkout, Hold, and other enhancements

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1772680: enhancements to RBDigital integration

This feature allows searching of RBdigital resources from the Evergreen
catalog without needing to import and maintain bibliographic records for
the RBdigital resources.

The RBdigital search results will appear in the OPAC on a different tab -
a search in basic or advanced Evergreen search will carry over to the
RBdigital tab (along with filters when mapping is feasible) so that the
user can type in a search once and see both sets of results. The design
of the RBdigital tab will make use of the OPAC styling for consistency.

This feature is sponsored by Recorded Books (RBDigital) and
GPLS and was primary written by Jaswinder Singh with code contributions
and testing from the Equinox Open Library Initiative.

Signed-off-by: Jaswinder Singh <jaswinder.singh0011@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

adding new post-upgrade script

LP 1779467: Fix Error When Marking Item on Hold as Discard/Weed

Fix the following error when marking an on-hold item as Discard/Weed:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.18.2/OpenILS/Application/Circ.pm line 1393.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1779467: Fix typo in circ/renew/app.js.

Had copyies for copies in one location and this prevented marking an
item as Discard/Weed from working on the renew item interface.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1779467: Fix SyntaxError: missing ) after argument list

Missing parenthesis in Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
caused the titular error when searching the catalog.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1779467: Enhance Mark Items Functionality

A new option to "Mark Item as Discard/Weed" is added to many actions
menus in the staff client.  This command is connected to the back end
function open-ils.circ.mark_item_discard.

The back end functionality for the open-ils.circ.mark_item_* family of
functions is altered to provide more consistent behavior and to avoid
some strange situations that have come up in the past, such as items
with the Missing status having active transits or open circulations.

The code for "Mark Item as Damaged" and "Mark Item as Missing" are
altered to take advantage of the back end changes.  NB: These changes
do not affect the "Mark Item as Missing Pieces" function, as that is
handled by different back end code.

Perl live tests are added for the backend functionality changes to
test that certain conditions works.  Like most of our tests these
could be expanded to cover more potential situations.

See the release notes for more detail on changes in functionality.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1684202 - fix holdings grid refresh... bre_id array always be integers

For some strange reason the volcopy bchannel event data.records
would be an array of string integers or a array of ints depending
on whether you're adding or editing holdings. This addresses that
weirdness.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1684202 - fix bug the prevented automatic refresh

Turns out that Array.includes() does not do implicit type convertions
Typical javascript...

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1684202: Protect against missing features; Make feature more general

I've wrapped the BroadcastChannel code in a test derived from the auth version
of the same concept.  Also broadcasting the full set of record IDs and the
pre-update call number IDs for other interfaces that might be interested. The
channel name is also made more generic and made to follow the precedent from
the auth channel name.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

PINES Cust: Fix layout for Patron Edit Form

Readjustments to previous customizations that no longer work
properly with 3.2. Also added links to relevant documentation.

Signed-off-by: McCanna <tmccanna@georgialibraries.org>

PINES OPAC fix to My Lists

Removes incomplete IF statement that caused page not to load.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

remove post-upgrade script

PINES doesn't use LoC bib source

drop triggers first

create index only if not exists

LP#793802 Billing/payment purge improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#793802 Aged billings/payments release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#793802 Aged billings/payments PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#793802 Add money.all_[payments|billings] views

Similar to money.all_circulation_slim, add views to collect data from
both active and aged versions of the payment and billing tables.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#793802 Aged billings and payments

Creates tables money.aged_billing and money.aged_payment.  When a
circulation is aged, billings/payments linked to the circ are migrated
to the aged_* table.

Upgrade script includes a migration script for migrating existing
billings and payments.

Includes IDL entries for reporting and pcrud access just in case it's
needed.  Note the 'xact' column on these new tables links directly to
the aged circulation instead of the non-existent money.billable_xact.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Add fix for PG segfaults during reingest.

Also add inline docs.

LP#1764542 - Update older sites to MODS 3.3

MODS 3.3 support was introduced in March 2009, but this
change was never included in an upgrade script.  Older
sites on 3.1+ will need to apply this update to avoid scary
segmentation faults, and it should be harmless for newer
sites and desirable for those on 3.0 or older.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

fix eg version in post upgrade script

remove z3950 update for LoC

fix out-of-sync id sequence

drop reporter.copy_statistics_view for upgrade to work

LP#1672346 - Copy Statistics View

Certain third-party products such as collection development
management providers require copy statistics that are not
readily available in a single report.  This view adds those,
which will also benefit library staff reports generally.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

add pre-3.2-upgrade script

adding 3.1-3.2 upgrade script

move reingests to the end

LP#1772062: prevent copy template apply failure on null stat cats and non-null statcat filter

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

add iOS link to OPAC footer

LP#1738249: further fix to checkout workstation

Since accs.checkout_workstation contains the workstation associated
with the initial loan (and not any subsequent renewals), use that.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1738249 - Fix checkout_workstation display issue

Addresses the issue with checkout workstation, by
attaching as a object property to the flatCopy hash.
Also makes sure the pcrud call uses combcirc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1788260 - Break out in-house-use non-cat circulations.

Previously, all non-cataloged circulations were grouped
together, causing problems for libraries who need to
exclude in-house circulations from circ counts.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1785887 edi_order_pusher.pl sets message account

Apply the edi_message.account value when sending EDI order messages via
edi_order_pusher.pl.  This solves a problem where EDI ORDERS message
were not visible in the interface, because there was no way to complete
the permission check.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1743650: Bib vis testing needs different handling

For bib-level visibility testing, we can only use the source helper for
positive inclusion, and have to deal with LURIs on a case-by-case basis.
This is because, unlike the copy visibility cache, the LURI cache is pre-
composed in a single value for all LURIs on a record, not separate ones
for each.  This is fine, as we just need to find the effectively visible
org units and test for that subset of the relevant orgs. This commit provides
a sub to test for that, and handles LURI test composition at the perl
level rather than in the database.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>