working/Evergreen.git
2 years agoLP1929741 Apply default lineitem order identifers
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Bundle of ACQ bug fixes
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Delete action trumps ischanged for LID's
Bill Erickson [Fri, 11 Jun 2021 14:28:06 +0000 (10:28 -0400)]
LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Cache LI after order ident change
Bill Erickson [Wed, 9 Jun 2021 15:16:08 +0000 (11:16 -0400)]
LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Lineitem delete repairs
Bill Erickson [Mon, 3 May 2021 15:28:09 +0000 (11:28 -0400)]
LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 View/Place orders sorts newest to oldest
Bill Erickson [Tue, 20 Apr 2021 15:15:36 +0000 (11:15 -0400)]
LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Limit to active providers; skip empty name picklist
Bill Erickson [Thu, 8 Apr 2021 14:30:56 +0000 (10:30 -0400)]
LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 AnJS nav create po goes to new UI
Bill Erickson [Fri, 26 Feb 2021 16:11:19 +0000 (11:11 -0500)]
LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Improve catalog service sanity check
Bill Erickson [Tue, 27 Apr 2021 14:32:05 +0000 (10:32 -0400)]
LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Repair 'Create Invoice' link
Bill Erickson [Tue, 2 Feb 2021 18:41:47 +0000 (13:41 -0500)]
LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Zero-copy and no-assets PO activation
Bill Erickson [Mon, 1 Feb 2021 22:29:26 +0000 (17:29 -0500)]
LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Ensure PO items always display when present
Bill Erickson [Mon, 1 Feb 2021 21:16:07 +0000 (16:16 -0500)]
LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 View/Place Orders UI
Bill Erickson [Tue, 26 Jan 2021 18:26:35 +0000 (13:26 -0500)]
LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Display copy row number in copy edit grid
Bill Erickson [Wed, 20 Jan 2021 22:02:38 +0000 (17:02 -0500)]
LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 ACQ caching / batch editing improvements
Bill Erickson [Wed, 20 Jan 2021 20:49:55 +0000 (15:49 -0500)]
LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Combobox additional sanity checks on async/IDL values
Bill Erickson [Wed, 20 Jan 2021 20:47:03 +0000 (15:47 -0500)]
LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Sanity check distrib. formula values
Bill Erickson [Wed, 20 Jan 2021 19:14:36 +0000 (14:14 -0500)]
LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Angular Selection List / Po Seed Data
Bill Erickson [Fri, 15 Jan 2021 15:33:55 +0000 (10:33 -0500)]
LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 ACQ Selection List & PO Angluar Port
Bill Erickson [Thu, 8 Oct 2020 22:22:12 +0000 (18:22 -0400)]
LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Combobox idl auto query filter addition
Bill Erickson [Fri, 4 Dec 2020 20:39:33 +0000 (15:39 -0500)]
LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Combobox asyncSupportsEmptyTermClick fix
Bill Erickson [Fri, 4 Dec 2020 16:17:51 +0000 (11:17 -0500)]
LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1929741 Net service tidier request logging
Bill Erickson [Wed, 30 Dec 2020 16:43:50 +0000 (11:43 -0500)]
LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1991444: Cleanup Build Docs Artifacts in GitHub Actions
Jason Stephenson [Sat, 1 Oct 2022 13:20:35 +0000 (09:20 -0400)]
LP1991444: Cleanup Build Docs Artifacts in GitHub Actions

The Build Docs GitHub action leaves the built docs behind as
artifacts.  These artifacts currently use about 58MB apiece.  This can
quickly consume all of the available storage spacce (500MB) for
free-tier GitHub accounts.

This commit adds a retention-days setting of 2 so that build docs
artifacts should be removed after two days.

See also:

https://docs.github.com/en/actions/using-workflows/storing-workflow-data-as-artifacts#configuring-a-custom-artifact-retention-period

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1991395 Bootstrap opac: headers in advanced search screens not translated
Garry Collum [Fri, 30 Sep 2022 14:02:46 +0000 (14:02 +0000)]
LP1991395 Bootstrap opac: headers in advanced search screens not translated

Marks the headers in Advanced Search, Numeric Search and Expert Search
for translation.

Thank you, Eva Cerninakova for pointing them all out.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1989033: Allow x86_64 and arm64 to download node
Jane Sandberg [Wed, 14 Sep 2022 23:10:05 +0000 (16:10 -0700)]
LP1989033: Allow x86_64 and arm64 to download node

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1990018: Fix libdbi build
Jason Stephenson [Sun, 18 Sep 2022 13:38:40 +0000 (09:38 -0400)]
LP1990018: Fix libdbi build

Resolve issues with finding libdbi and libdbdpgsql on ARM64 by using better
autoconf hygiene:

 * Use PKG_CHECK_MODULES to find and set the dbi library flags.
 * Remove the "backup" code to find a manually installed libdbi.
   (This has not been needed for some time.)
 * Update Makefile.ams to use the dbi LDFLAGS properly.
 * Remove -ldbdpgsql from compile commands.
   (It is loaded dynamically.)

I tested it on a x86_64 VM with Ubuntu 22.04.  Most tests passed.  Only the
remot auth and cover uploader tests failed.  The latter have not passed for
some time, and I believe the former may have been affected by a recent
change unrelated to this commit.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP#1980867 follow-up: default to showing the traditional catalog, add release notes
Jane Sandberg [Fri, 30 Sep 2022 02:26:22 +0000 (19:26 -0700)]
LP#1980867 follow-up: default to showing the traditional catalog, add release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP#1980867: stamp upgrade script
Jane Sandberg [Fri, 30 Sep 2022 01:15:15 +0000 (18:15 -0700)]
LP#1980867: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP#1980867: optionally remove traditional catalog from staff client menu
Jeff Davis [Wed, 6 Jul 2022 19:10:41 +0000 (12:10 -0700)]
LP#1980867: optionally remove traditional catalog from staff client menu

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoDocs: add release notes for Patrons with Negative Balances angular port
Jane Sandberg [Fri, 30 Sep 2022 01:07:53 +0000 (18:07 -0700)]
Docs: add release notes for Patrons with Negative Balances angular port

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1981739: stamp upgrade script
Jane Sandberg [Fri, 30 Sep 2022 00:39:52 +0000 (17:39 -0700)]
LP1981739: stamp upgrade script

2 years agoLP1981739 Patrons Negative Balances Angular Port
Bill Erickson [Tue, 12 Jul 2022 17:08:50 +0000 (13:08 -0400)]
LP1981739 Patrons Negative Balances Angular Port

Port Admin => Local Admin => Patrons With Negative Balances to Angular.

Adds paging support to the API.

Adds support for display patrons whose home lib is a descendant of the
selected org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1953381 not-allowed pointer for inactive buttons
Stephanie Leary [Wed, 28 Sep 2022 21:54:49 +0000 (16:54 -0500)]
LP1953381 not-allowed pointer for inactive buttons

Adds a style to change the mouse pointer to the "no" symbol for disabled
buttons.

To test:
1. Apply patch.
2. Go to an item record in the staff catalog.
3. Mouse over the "Set Default View" button (disabled by default on the
   Item Table tab).
4. The pointer should change to the "no" symbol.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoAdd Release Note
Terran McCanna [Thu, 29 Sep 2022 20:03:43 +0000 (16:03 -0400)]
Add Release Note

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1901897 Carousel Date-Time
Terran McCanna [Tue, 23 Aug 2022 19:52:02 +0000 (15:52 -0400)]
LP1901897 Carousel Date-Time

This displays the Last Refresh Time in the carousel admin interface
as date-time instead of just date.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1909583 Bootstrap Opac: Cannot edit title and description
Garry Collum [Fri, 29 Jul 2022 22:03:18 +0000 (22:03 +0000)]
LP1909583 Bootstrap Opac: Cannot edit title and description

Fixes the editing of the title and description in the Bootstrap Opac lists.
Adds and Edit List button with a collapsible form.

To Test:
1. Create several lists in the Opac.
2. Notice you are unable to edti the title or description.
3. Apply the patch
4. Use the Edit List button to display an editable form for each individual
list.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1903767 - Bootstrap Opac: Make other formats and editions more visible.
Garry Collum [Fri, 22 Jul 2022 18:08:43 +0000 (18:08 +0000)]
LP1903767 - Bootstrap Opac: Make other formats and editions more visible.

This patch does the following:

1. Moves "Other Formats and Editions" below # of holds and available items.
2. Changes "Other Options" to "Other Formats and Editions" and makes the
header tage and <h2> tag consistent with other header tags.
3. Resizes <h2> tags.
4. Removes bullets and changes the margins of some of the table/list displays
under the <h2> headers.
5. Fixes the alignment of the button group that contains Place Hold.

For Testing:

1. Find a record that contains other formats and editions.  In concerto
record #71 contains other formats and editions.
2. Notice that you have to click the More Details button to view the Other
Formats.
3. Apply the patch.
4. Other Formats and Editions now appear under the Available Copies and
Holds heading.  You no longer have to push the More Details button.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP#1979099: Fix typo
Stephanie Leary [Mon, 19 Sep 2022 20:57:35 +0000 (15:57 -0500)]
LP#1979099: Fix typo

Fixing "hold Type" to "Hold Type" in hold details screen

Test plan:
1. Go to the staff interface, right click a hold to see hold details,
 observe that "hold Type" is not capitalized
2. Apply the patch
3. Refresh the staff interface hold details screen and observe that
 the "Hold Type" is properly capitalized

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1902272-Bootstrap opac needs to prompt on notification preference update
Garry Collum [Tue, 2 Aug 2022 19:35:39 +0000 (19:35 +0000)]
LP1902272-Bootstrap opac needs to prompt on notification preference update

Adds the prompting of updating holds when default notification preferences
are updated in the Bootstrap opac.

To Test:
1. Place a few holds for a patron.
2. Login to the opac and change some default notification methods.
3. The opac does not prompt to update the holds.
4. Apply the patch.
5. The patron should now be prompted to update holds when default
notification methods are changed.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1907974: throwError needs an argument
Jane Sandberg [Thu, 19 May 2022 20:13:25 +0000 (14:13 -0600)]
LP1907974: throwError needs an argument

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1907974: Updating call numbers in course module reflected in grid
Jane Sandberg [Thu, 11 Feb 2021 01:37:57 +0000 (17:37 -0800)]
LP1907974: Updating call numbers in course module reflected in grid

Also:
  * refactors the updateItem method for more idiomatic RxJS usage (e.g.
    no nested subscribes)
  * corrects some Boolean, String, and Number types to boolean, string,
    and number (to use the primitive types instead of objects, as
    recommended by the Typescript handbook:
    https://www.typescriptlang.org/docs/handbook/basic-types.html#about-number-string-boolean-symbol-and-object)

To test:

1) Go to Local Admin > Course List
2) Double click on a course
3) Go to the materials tab
4) Add an item by barcode, making sure to supply a temporary call
   number, and that the call number checkbox is checked.
5) Note that the grid on the right display's the item's old call number,
   not its new one.
6) Apply this patch.
7) Repeat step 4.  Note that the temporary call number is reflected in
   the grid now.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1970667 (follow-up): add OpenAthens dependencies
Jane Sandberg [Sun, 25 Sep 2022 03:55:39 +0000 (20:55 -0700)]
LP1970667 (follow-up): add OpenAthens dependencies

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1970667: Add Installation Support for Ubuntu 22.04 (Jammy Jellyfish)
Jason Stephenson [Thu, 16 Jun 2022 15:37:50 +0000 (11:37 -0400)]
LP1970667: Add Installation Support for Ubuntu 22.04 (Jammy Jellyfish)

Add prerequisite installation targets for Jammy Jellyfish:

 * ubuntu-jammy
 * ubuntu-jammy-developer
 * ubuntu-jammy-packager
 * ubuntu-jammy-translator

Update the README and server upgrade instructions for Ubuntu 22.04.

Remove or replace deprecated autoconf directives in configure.ac.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agolp1983129-Bootstrap Opac: Inconsistent wording in My Account
Garry Collum [Wed, 3 Aug 2022 18:00:02 +0000 (18:00 +0000)]
lp1983129-Bootstrap Opac: Inconsistent wording in My Account

Removes the word "Current" and "Currently" from the holds and items checked out
menus and pages in My Account, and fixes capitalization in the summary screen.

Also removes 'Current' from the menus and screens for E-items out, and E-items
on hold.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP#1939730 - Use original call number owning_lib when reverting items
Michele Morgan [Thu, 12 Aug 2021 18:09:41 +0000 (14:09 -0400)]
LP#1939730 - Use original call number owning_lib when reverting items

When removing items with edited call numbers from a course, find or
create the resulting call number using the original call number's
owning_lib rather than the course owner.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1842297: stamp upgrade script
Jane Sandberg [Fri, 23 Sep 2022 04:16:55 +0000 (21:16 -0700)]
LP1842297: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1842297: follow-up to use BasicAdminPageComponent for openathens screen
Jane Sandberg [Thu, 8 Sep 2022 03:01:24 +0000 (20:01 -0700)]
LP1842297: follow-up to use BasicAdminPageComponent for openathens screen

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP#1842297: Implements patron sign-on to the OpenAthens service.
oajulianclementson [Wed, 30 Mar 2022 11:51:59 +0000 (12:51 +0100)]
LP#1842297: Implements patron sign-on to the OpenAthens service.

For libraries who are OpenAthens customers, they can configure Evergreen to sign their patrons on to OpenAthens
either immediately when they sign on to Evergreen, or on demand when they select their library as their method
to sign on to OpenAthens-protected resources.

Signed-off-by: oajulianclementson <51331324+oajulianclementson@users.noreply.github.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP#1959048: add release notes
Galen Charlton [Fri, 9 Sep 2022 14:43:59 +0000 (10:43 -0400)]
LP#1959048: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1959048: manual ng lint fixes
Jane Sandberg [Thu, 8 Sep 2022 22:14:59 +0000 (15:14 -0700)]
LP1959048: manual ng lint fixes

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1959048: Run ng lint --fix
Jane Sandberg [Thu, 8 Sep 2022 20:21:04 +0000 (13:21 -0700)]
LP1959048: Run ng lint --fix

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1959048: run ng g @angular-eslint/schematics:convert-tslint-to-eslint
Jane Sandberg [Tue, 25 Jan 2022 21:23:55 +0000 (13:23 -0800)]
LP1959048: run ng g @angular-eslint/schematics:convert-tslint-to-eslint

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP#1957179: improve saving of templates in Angular holdings editor
Galen Charlton [Thu, 26 May 2022 15:11:59 +0000 (11:11 -0400)]
LP#1957179: improve saving of templates in Angular holdings editor

This patch makes the following improvements to the handling
of holding templates in the Angular holdings editor:

- templates are now saved to the cat.copy.templates user setting,
  matching the AngularJS holdings editor
- toast is displayed upon saving or deleting a template
- upon saving a completely new template, re-style it in the
  combobox so that it no longer has the new-and-freetext
  styling

To test
-------
[1] Apply the patch and open the Angular holdings editor.
[2] Verify that once a template is saved or deleted, that
    refreshing the Angular holdings editor will show the
    updated list of templates.
[3] Verify that toast is displayed upon saving or deleting
    a template.

Note that because of a quirk in how user settings are cached by
the web staff client, if you are testing in more than one browser
(but with the same user account), if you save a template in one
browser, you'll need to log out and back in with the second browser
to see the changes.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP#1980887: fixes cases where shelving location selector didn't work
Galen Charlton [Fri, 9 Sep 2022 21:44:46 +0000 (17:44 -0400)]
LP#1980887: fixes cases where shelving location selector didn't work

This patch fixes an issue where the Angular shelving location selection
component (eg-item-location-select) wouldn't work (in particular,
when its contextOrgIds wasn't set, as opposed to contextOrgId).

Coding note: TypeScript confounds the Perl programmer: an empty array
evaulates to true; .length needs to be checked instead.

To test
-------
[1] Apply the patch.
[2] Verify that the shelving location selector works in the following
    interfaces:

    - Acquisitions Administration -> Distribution Formuals
    - Course Materials (in the material form for a course)
    - Linked locations for Circulation Limit Sets

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoDocs: correction to Global Flags docs
Andrea Buntz Neiman [Wed, 14 Sep 2022 13:50:20 +0000 (09:50 -0400)]
Docs: correction to Global Flags docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
2 years agoLP#1989348: set default new record via route data
Julian Clementson [Mon, 12 Sep 2022 14:39:06 +0000 (15:39 +0100)]
LP#1989348: set default new record via route data

Allows us to set defaultNewRecord on BasicAdminPageComponent via route data

Signed-off-by: Julian Clementson <51331324+oajulianclementson@users.noreply.github.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP#1920268: properly align titles in Bootstrap search results, regardless of cover art
Jeff Davis [Mon, 25 Jul 2022 20:08:43 +0000 (13:08 -0700)]
LP#1920268: properly align titles in Bootstrap search results, regardless of cover art

The changes in this commit were proposed by Eva Cerninakova.

Co-authored-by: Eva Cerninakova <cerninakova@jabok.cz>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoDocs: adding Global Flags documentation
Erica Rohlfs [Tue, 13 Sep 2022 20:18:37 +0000 (16:18 -0400)]
Docs: adding Global Flags documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
2 years agoLP#1986725: restore portrait/landscape choice when printing from Angular
Galen Charlton [Fri, 9 Sep 2022 15:22:46 +0000 (11:22 -0400)]
LP#1986725: restore portrait/landscape choice when printing from Angular

This patch works around a default setting in Bootstrap 4 that specifies
A3 as the paper size for printing. Specifying any paper size like this
causes Chrome and Firefox to stop offering the users the option to
choose the paper orientation.

My testing suggests that specifying A3 as the default paper size also
resulted in the printed text using a smaller font size when printing
on US paper sizes. Some sort of scaling down from A3 to letter,
perhaps.

To test
-------
[1] Open the Angular Holds Pull List, select a branch that has items
    to pull, and click the Print Full List button. Observe that the
    browser print dialog does not offer an option to choose the
    orientation.
[2] As above, but for any Angular grid's Print Full Grid action.
[3] Apply the patch and repeat 1 and 2. This time, the browser print
    dialog should offer the option to select the orientation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP#1947045: add release notes entry
Galen Charlton [Fri, 9 Sep 2022 14:56:06 +0000 (10:56 -0400)]
LP#1947045: add release notes entry

Also do some tidying of other miscellaneous release notes
entries.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1947045 Shuffle claiming tabs
Tiffany Little [Thu, 14 Jul 2022 21:46:16 +0000 (17:46 -0400)]
LP1947045 Shuffle claiming tabs

Moves the Claim Types to the fourth tab

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1979080 Lengthy titles in a carousel should be truncated.
Garry Collum [Fri, 17 Jun 2022 17:39:36 +0000 (17:39 +0000)]
LP1979080 Lengthy titles in a carousel should be truncated.

Lengthy titles in a carousel push the content that is below the carousel
down sometimes resulting in odd displays.

This patch truncates lengthy titles to 4 lines ending with an ellipsis.

To test.

1. Create a couple of manual carousels and populate them with some bibs that
have lengthy titles.
2. Notice that there is odd spacing below the carousels.
3. Apply the patch.
4. The lengthy titles are now truncated and end with an ellipsis.  There
is now normal spacing below the carousels.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1532236 release notes
Jane Sandberg [Mon, 5 Sep 2022 17:08:05 +0000 (10:08 -0700)]
LP1532236 release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1532236 Evergreen should allow for HTML formatted action trigger emails
blake [Mon, 17 Feb 2020 15:10:17 +0000 (09:10 -0600)]
LP1532236 Evergreen should allow for HTML formatted action trigger emails

Simple fix for allowing the AT template to drive the email headers instead
of replacing the headers blindly. Kudos to tsbere for the unless idea.

Testing: setup an action trigger for SendEmail. Make sure your AT template includes
an email header (EG: Content-Type: text/html;charset=utf-8)
Setup a hold/circulation that meets the criteria of your action trigger. Check the
resuting email's headers to match what you had put into the template.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP#1976002: Include ancestors in item location filters
Mike Rylander [Fri, 27 May 2022 15:22:29 +0000 (11:22 -0400)]
LP#1976002: Include ancestors in item location filters

The item location selector should include locations from ancestor org
units regardless of the specific permission-limiting check it may be
asked to perform.  Item locations at ancestor org units are valid for
use on items in descendant locations.

This commit also makes the org filter list unique.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agolp1939994 Course Details Page Archive Workaround
Kyle Huckins [Tue, 15 Mar 2022 03:10:25 +0000 (03:10 +0000)]
lp1939994 Course Details Page Archive Workaround

- Course Page stores is_archived() locally, checking for either the current course being archived, or the locally stored variable.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-material.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-associate-users.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-page.component.ts

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoUpdating My Account
gmontimantis [Tue, 8 Feb 2022 16:01:09 +0000 (11:01 -0500)]
Updating My Account

Bootstrap updates

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
2 years agoLP1983020-Bootstrap opac: Electronic links pagination button.
Garry Collum [Fri, 5 Aug 2022 13:27:33 +0000 (13:27 +0000)]
LP1983020-Bootstrap opac: Electronic links pagination button.

Fixes the placement of the previous and next buttons in the Bootstrap Opac
when the record contains electronic links and physical items.

To Test:
1. To fully test a record with physical items, a record with electronic
links, and a record with both physical items and electronic links need
to be viewed in the opac.
2. On each of these records notice the placement of the previous
or next buttons.
3. Apply the patch.
4. View the 3 types of records after the patch is applied.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
2 years agoUpdate carousels.adoc
gmontimantis [Wed, 6 Apr 2022 17:22:37 +0000 (13:22 -0400)]
Update carousels.adoc

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoDocs: correct permission
Andrea Buntz Neiman [Mon, 13 Jun 2022 20:03:07 +0000 (16:03 -0400)]
Docs: correct permission

updated doc to cite the actual permission

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoDocs: Adding group penalty thresholds
Jennifer Pringle [Mon, 13 Jun 2022 20:29:56 +0000 (13:29 -0700)]
Docs: Adding group penalty thresholds

new page and screenshots for group penalty thresholds

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoDocs: Updating Authorities
Jennifer Pringle [Fri, 17 Jun 2022 20:04:05 +0000 (13:04 -0700)]
Docs: Updating Authorities

Authorities section text and screenshots updated.

Changes come from Jennifer Weston jennifer.weston@equinoxoli.org

Co-authored-by: Jennifer Weston <jennifer.weston@equinoxoli.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP#1771636: Add release notes entry
Michele Morgan [Wed, 10 Aug 2022 15:07:40 +0000 (11:07 -0400)]
LP#1771636: Add release notes entry

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1823225 Patron Penalty Refresh Action
Bill Erickson [Mon, 11 Jul 2022 18:06:44 +0000 (14:06 -0400)]
LP1823225 Patron Penalty Refresh Action

New menu entry added under the 'Other' menu for patrons.  It refreshes
the patron's penalties and reloads the patron to ensure all needed data
is refreshed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1910546: Stamping upgrade script
Michele Morgan [Mon, 1 Aug 2022 18:30:25 +0000 (14:30 -0400)]
LP1910546: Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1910546 Prevent Copy Location Delete With Active Copies
Bill Erickson [Tue, 19 Jul 2022 14:19:29 +0000 (10:19 -0400)]
LP1910546 Prevent Copy Location Delete With Active Copies

Raise a database exception when any attempt is made to marke a copy
location as deleted when the location contains non-deleted copies.

To Test:

1. Navigate to /eg2/staff/admin/local/asset/copy_location

2. Attempt to delete a copy location that is known to contain
   non-deleted copies.

3. Confirm an error message is displayed and the location is not marked
   as deleted.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1771636: Stamping upgrade script
Michele Morgan [Fri, 29 Jul 2022 20:22:24 +0000 (16:22 -0400)]
LP1771636: Stamping upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1771636 Org Select Combined Org Names Option
Bill Erickson [Mon, 3 Jan 2022 17:54:43 +0000 (12:54 -0500)]
LP1771636 Org Select Combined Org Names Option

Adds an option to the staff client workstation settings page for
"Include Full Library Names in Library Selector?".  When enabled, Angular org
unit selectors display the full branch in addition to the branch short
code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1978567: Teach fieldmapper.py about field groups
Jason Boyer [Thu, 28 Jul 2022 19:15:17 +0000 (15:15 -0400)]
LP1978567: Teach fieldmapper.py about field groups

Because the "group" tag in IDL field_groups was never added to
this file that helps with translations, Simple Reporter field groups
all have the same name when built for release.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
2 years agoLP1956986: follow-up to fix linter
Jane Sandberg [Wed, 27 Jul 2022 22:24:46 +0000 (15:24 -0700)]
LP1956986: follow-up to fix linter

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1956986 Holdings View display correct copy alerts count
Bill Erickson [Wed, 13 Jul 2022 15:56:13 +0000 (11:56 -0400)]
LP1956986 Holdings View display correct copy alerts count

Avoid counting ACK'ed copies as active copy alerts in the catalog
Holdings View, copy alert column.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
2 years agoLP1956986 Copy alerts consistently set ack_staff
Bill Erickson [Wed, 13 Jul 2022 15:51:57 +0000 (11:51 -0400)]
LP1956986 Copy alerts consistently set ack_staff

Moves the logic of when to apply a value for ack_staff into the copy
alerts dialog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
2 years agoLP#1956986: fix and refactor item alert handing in Angular editor
Galen Charlton [Mon, 11 Jul 2022 16:31:36 +0000 (12:31 -0400)]
LP#1956986: fix and refactor item alert handing in Angular editor

This patch changes the handling of item alerts in the Angular
Holdings View and Item Attributes editor to be more like how
item notes and item tags are handled.

In particular:

- The separate 'Add Item Alert' and 'Edit Item Alerts' context menu
  items in Holdings View are consolidated to a 'Add/Manage Item Alerts'
  action.
- Pending new alerts are displayed in separate area of the modal
- The 'Apply Changes' and 'Add New' buttons now work the same way as
  item notes and item tags

To test
-------
[1] Apply patch.
[2] Create a new item with one or more item alerts. Verify that they are
    properly saved.
[3] Edit an existing item and add, modify, and clear alerts. Verify that
    the changes are saved.
[4] From Holdings View, choose 'Add/Manage Item Alerts' with a single
    item selected. Verify that changes are saved.
[5] From Holdings View, choose 'Add/Manage Item Alerts' with multiple
    items selected. Verify that you are only given the option to add
    new alerts. Verify that new alerts are saved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
2 years agoLP#1978889: display alert type for existing item alerts
Galen Charlton [Mon, 11 Jul 2022 14:38:47 +0000 (10:38 -0400)]
LP#1978889: display alert type for existing item alerts

This patch ensures that the type of an item alert is
displayed when managing item alerts in the Angular item
attributes editor.

To test
-------
[1] Add an alert to an item.
[2] From the Angular Holdings View, chose 'Edit Item Alerts'
    for that item. Note that the combobox for the existing
    alert does not display a value.
[3] Open the item in the Item Attributes editor and click
    the Item Alerts button. Again, note that the alert type
    combobox does not display a value.
[4] Apply the patch and repeat steps 2 and 3. This time, the alert
    type should be displayed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
2 years agoLP1956627 Copy editor shows full org path of copy locations
Bill Erickson [Fri, 8 Jul 2022 21:46:40 +0000 (17:46 -0400)]
LP1956627 Copy editor shows full org path of copy locations

Copy location selector in the copy editor now includes locations from all
org units above, at, and below the workstation org unit.

Previously, copy locations at "lower" org units were not included.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Carol Witt <wittc@cwmars.org>
2 years agoLP1980692-Patron print option should be 'copies'
Garry Collum [Mon, 18 Jul 2022 19:11:01 +0000 (19:11 +0000)]
LP1980692-Patron print option should be 'copies'

When printing from the patron's bills page the option to select the number
of copies to print reads 'items'.  This changes the label to 'copies'.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
2 years agoLP1955838 Hatch Native Browser Printing Option
Bill Erickson [Mon, 27 Dec 2021 18:04:37 +0000 (13:04 -0500)]
LP1955838 Hatch Native Browser Printing Option

Adds a new printer option to the Hatch printer settings page called
"Browser Printer".  When selected for a print context, all print request
using that context are printed via window.print() instead of going
through Hatch for printing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
2 years agoLP1884950 Org service loads all ou types fix
Bill Erickson [Wed, 13 Jul 2022 14:09:33 +0000 (10:09 -0400)]
LP1884950 Org service loads all ou types fix

Recover an unintended line deletion.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP1884950 Org service loads all ou types
Bill Erickson [Wed, 6 Jul 2022 20:35:28 +0000 (16:35 -0400)]
LP1884950 Org service loads all ou types

Explicitly load all org unit types at page startup so that we fetch org
types that may not have an org unit attached.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoLP1884950 Org Unit Admin Scrolling
Bill Erickson [Wed, 6 Jul 2022 19:32:42 +0000 (15:32 -0400)]
LP1884950 Org Unit Admin Scrolling

Admin -> Server Admin -> Organizational Units now displays the tree of
org units in a vertical-scrollable div which occupies 80% of the
vertical window space.

Tree is opened to the first level of child nodes.  Deeper child nodes
are collapsed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
2 years agoForward 3.7.4 DB Upgrade Script
Jason Stephenson [Thu, 21 Jul 2022 15:50:32 +0000 (11:50 -0400)]
Forward 3.7.4 DB Upgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoDocs: 3.7.4 Release Notes
Jason Stephenson [Wed, 20 Jul 2022 12:57:55 +0000 (08:57 -0400)]
Docs: 3.7.4 Release Notes

Signed-off-by: Jason Stephenson <jason@sigio.com>
2 years agoLP1958573 PMC messages created by action triggers not patron-visible
Terran McCanna [Thu, 20 Jan 2022 19:42:33 +0000 (14:42 -0500)]
LP1958573 PMC messages created by action triggers not patron-visible

This adds a missing patron-visibility flag to messages created for
the patron message center by notification action triggers (when
using grouped events).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoStaff banner added to the staff portal local administration page.
Shula Link [Mon, 27 Jun 2022 13:26:38 +0000 (09:26 -0400)]
Staff banner added to the staff portal local administration page.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1956790 Support applying item alerts via templates
Bill Erickson [Fri, 8 Jul 2022 15:17:51 +0000 (11:17 -0400)]
LP1956790 Support applying item alerts via templates

Fixes an issue where item alerts contained within copy templates failed
to apply when using the new Angular holdings editor.

Testing note: if you add an item alert by applying a template, it currently
will not be displayed in the item alerts dialog until you save the item.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP#1980257: add release notes entry
Galen Charlton [Tue, 12 Jul 2022 13:38:21 +0000 (09:38 -0400)]
LP#1980257: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP#1980257: (follow-up) add balance owed to the pending grid as well
Galen Charlton [Tue, 12 Jul 2022 13:36:13 +0000 (09:36 -0400)]
LP#1980257: (follow-up) add balance owed to the pending grid as well

Doing this maintains symmetry between the user bucket grid
and the pending user grid and supports workflows where a staff
member may wish to check the patron balance before adding a
user to a bucket.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP#1980257: Patron bucket money summary
Bill Erickson [Wed, 29 Jun 2022 18:44:12 +0000 (14:44 -0400)]
LP#1980257: Patron bucket money summary

This patch adds the patron's balance owed as a column
in the user bucket grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP1975879 Holdings editor allows owning lib changed user/gmcharlt/lp1975879_signoff
Bill Erickson [Fri, 8 Jul 2022 20:19:44 +0000 (16:19 -0400)]
LP1975879 Holdings editor allows owning lib changed

A new edit (pencil) icon appears to the left of the first call number
field in the 'holdings' tab of the copy edit.  When clicked, the user has
a chance to enter a new org unit value to act as the owning lib of the
affected call number.

If the "Change Circ Lib When Owning Lib Changes" preference is set, then
any copies linked to the affected call number within the current edit
session will have their circ libs updated to match the new owning lib of
the call number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
2 years agoLP#1981095: fix deletion of item tags in Angular item attributes editor
Galen Charlton [Fri, 8 Jul 2022 16:46:40 +0000 (12:46 -0400)]
LP#1981095: fix deletion of item tags in Angular item attributes editor

This patch fixes several bugs that prevent item tags from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that tags can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Tags for a single
    selected item.
[5] Verify that tags can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item tag. Verify that tags can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Tags for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>