LP#1715503: update install & upgrade doc to require Pg 9.4

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1718300: fold update into 2.12.5-3.0-beta schema update

This saves a step for building the beta2 release, as
2.12.5-3.0-beta1-upgrade-db.sql will be moved to
2.12.5-3.0-beta2-upgrade-db.sql.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718300: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718300: Fix serial.unit visibility at creation time

The new copy visibility trigger was not taking into account a particular
dataflow that is common to the serial checkin process.  This branch
addressed that case where the call number of a copy changes, requiring
an update of one row on the cache table.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1718301 Offline db connections via promise

Refactors offline DB connection call to return a promise, resolved upon
successful connection, instead of polling for a successful connection
within the connect call.

Multiple calls to the main egLoveField connect function will result in
resolvers being linked to the same in-progress promise.

Check for connection errors via the database.connect() reject handler.

Avoid attempts to connect to the offline DB until egLoveField.connectOrGo()
is called the first time.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: fixup asciidoc syntax for main install README

Signed-off-by: Ben Shum <ben@evergreener.net>

add acknowledgments dervied from Git history

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

move significant upgrade considerations to one section in release notes

Also cite 3.0.0 as minimum required version of OpenSRF

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: bump up minimum required OpenSRF version

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: mention Stretch support in upgrade doc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: Fix ld issues by renaming libraries.

We add the lib... prefix to all C library names as expected by most
linkers.  This necessitates changes to the opensrf.xml configuration
file.

Debian 9's ld also apparently requires that ldconfig be run again
after the Evergreen C libraries are installed, so we add that step to
the installation instructions as well.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1708048: Add support for Debian 9 Stretch

  - Add new make target "debian-stretch"
  - Add PG 9.6 options
  - Add Stretch references to README

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: 2.12.6 Release Notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: 2.11.9 release notes

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1629078: Add missing strings in web client for i18n

Linda Jansova found a series of strings that were missing the localization
tagging indicated by the "l" function we use in tt2 code.

This patch adds them in preparation for the next PO template sync to grab
them to make them available for translation via Launchpad, etc.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1706124: minor tweaks

- change name of setting to better match local convention
- adjust whitespace

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1706124: Make include inactive patrons checkbox sticky

The state of the 'include inactive' checkbox on the patron search page will now
be remembered when users return to the page. Many thanks to Cesar Velez,
whose code for bug 1697754 inspired this patch!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs: cleaning up cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: fixing small mistake in cat manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1717715: Fix typo in webstaff serials

Eva Cerninakova noticed a typo in the web client during translation work.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1537233 Copy bucket handles mis-scans, improve focus

Show warning message to user when an unknown barcode is scanned in the
copy bucket pending list UI.  Also, after a barcode failure occurs, select
the barcode text (instead of clearing it) so it can be seen and easily
replaced, consistent with the item status UI.

After successful scan, clear and re-focus the barcode input box.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1712637 Patron edit hold pickup location repairs

1. Allow setting the hold pickup location independant of the home
   library.

2. Disable org units in the pickup lib selector that are not viable hold
   pickup locations (can_have_vols=f)

3. Consistent w/ the XUL client, allow a patron to be created without
   selecting a default pickup location.

To test:

[1] Register a new patron and confirm pickup location is initialy unset.
[2] Confirm pickup lib options are viable pickup locations.
[3] Apply a pickup location different from the home library and confirm
    the home library selector remains unchanged.
[4] Confirm saving the patron applies the expected pickup location value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs reorg: splitting action/triggers into command-line and staff-client manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding the MARC Templates documentation back

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: TPAC bib_source variable

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about purging patron data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: ebook api integrations from release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: moving SQL from circ manual to command line sysadmin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about TPAC microdata + linked data

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Moving clark_kent to the command line manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Removing zip code setup from staff client admin

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: cleaning up headings, other small fixes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding screenshot of uncataloged types editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding info about pre-cat and non-cat for sysadmins

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs reorg: splitting self-check documentation into appropriate manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1705068 - fix workstation already exists cancel btn freezes UI

The $scope.is_registering is used to enable/disable the Register btn
and was not being set back to false, when the user chose to cancel
using an existing WS name, and exiting the modal.

To test
-------
1. Register a workstation.
2. Switch to a different computer or Chrome profile.
3. Try to register the same workstation name. Warning dialog will pop
   up.
4. Click cancel.
5. See that the register button is now disabled and no actions on the
   form seem to reactivate it.
6. Apply the patch and repeat steps 2-4. This time, the register button
   should be active.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1713151: display owning OU in volcopy editor location selector

This patch causes the short name of the OU that owns a location
to be displayed after the location name in shelving location selectors
in the item attribute and copy template editors.

To test
-------
[1] Edit an item and verify that the shelving location selector
    displays the org unit shortname in parentheses after the location
    name.
[2] Verify that the location selector in the copy template portion
    also displays the OU short names.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Andrea Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1708951: fix tabbing in webstaff catalog app for Firefox

This patch works around an issue where Firefox appears to require
that the iframe for the embedded OPAC not have a null catalog_url
value. It also fixes an issue where navigating to the OPAC View tab
after retrieving the record with a different default view set would
cause it to jump back to that default view... the first time.

To test:

[1] In the web staff client, retrieve a bib record and set the default
    view to a tab other than 'OPAC View'.
[2] Retrieve another bib by TCN or ID. Note that although the default tab
    will briefly display, the page will jump over to the OPAC view and
    display an empty record.
[3] Apply the patch and repeat step 2. This time, it should display the
    record with the current default view.
[4] Select the 'OPAC View' tab and verify that it loads the record details
    page.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1697716 - Webstaff adds ability to display actor.usr.photo_url if present

This just adds a div row with an ng-if in the summary pane of patron view.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1716486: fix hotkeys

This fixes a regression on the hotkeys introduced by the offline
circulation module.

To test
-------
[1] Apply the patch and verify that hotkeys in the web staff client
    such as F1, F5, alt-s, and so forth work.
[2] Go to offline circulation and verify that select hotkeys such as
    F1 and F2 activate corresponding tabs in the offline circulation
    page.
[3] Repeat step 2 with the browser itself set to offline mode.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1716475: Add label for mobile carrier select menu

Replace the empty string with a label in the SMS carrier select menu due to
issues that arose when putting an empty string in the translation file. It
also is good usability.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

Docs reorg: adding OPAC chapter to all relevant manuals

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1713160: fix crash viewing circ history in public catalog

This patch fixes a crash when a patron views their circulation
history in the public catalog.

To test
-------
[1] Set up a patron record that retains circ history and make
    and returns some loans. Ensure that at least one of the
    loans is aged.
[2] Log into the public catalog as the test patron and riew the
    Check Out History page (/eg/opac/myopac/circ_history).
[3] Note that an internal server error is reported.
[4] Apply the patch, repeat step 2, and verify that the check out
    history is now displayed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs reorg: Adding a cataloging manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Correcting contents of staff client system administration

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Adding a new manual for system administration from the Web client

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Adding a manual about integrating Evergreen with other tools

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: cleanup syntax in the command line admin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: correcting title of OPAC manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: adding a serials manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: adding a manual for using the OPAC

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: Adding a manual for command line administrators

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: adding acquisitions manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs reorg: adding a circulation manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: adding to the patron myopac holds/circ history docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: making support scripts adoc formatting more consistent, adding marc stream importer docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: updates to My Lists in patron account docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: updates to Added Content instructions

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Clean up RELEASE_NOTES_NEXT

Now that these notes have been incorporated into a single file, remove
these temporary versions.

Also, add a few DONOTREMOVE files to new directories to preserve the
directories when empty.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Fix thinko in 3.0 release notes

'code' doesn't seem to be a recognized formatting keyword; change to
'source' instead.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Slightly rename release notes to follow existing convention

RELEASE_NOTES_3.0.adoc -> RELEASE_NOTES_3_0.adoc (underscore in number)

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: copy-editing 3.0 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

add organizations who sponsored develpoment written by Equinox

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

start work on 3.0 release notes

Generated from release note stubs; also includes note about
minimum PostgreSQL client and XUL deprecation.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Incorporate view update from LP#1714589

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Proposed 2.12.5-3.0 upgrade SQL

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP1714589: Use Explicit Definition for aacs

Spell out the expected fields in the expected order
for the aacs view because databases that have undergone
upgrades may drift when using * in a UNION.

Signed-off-by: <JBoyer@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Translation updates - po files

Signed-off-by: Ben Shum <ben@evergreener.net>

Translation updates - newpot

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1251394: fix typo in seed data caugh by t/24-sql-gettext-unique.t

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1714594: fix lp1629108_metarecord_constituent_result_reroute.pg

This patch accounts for the fact that the IDs returned in source_list
do not have a set order. It also no longer recreates unapi.mmr_mra()
within the test case, meaning that it can now serve as a true regression
test.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1714512: Patron Edit Barcode Validation

There are 2 barcode related regular expression OUS
but the web user editor is using the wrong one.
This branch corrects that.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Stamping upgrade scripts for Display Fields and Vandelay regression

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1152753: upgrade script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1152753: fix fake FK trigger on vandelay.import_item

Fixes a regression caught by live_t/0824.item_import_defaults.pg

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display fields release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Author display field xpath

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 More representative field cleanup

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display field CDBI thinko repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 egBibDisplay service examples

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display field schema sync'ing

Copy flat/compressed/wide display entry views into base schema.
Synchronize a few remaining seed data bits.

Replace references to 'topic_subject' in wide display views with the new
'creators' field.

Remove ZZZZ.UNDO testing SQL file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394: Seed data changes

Removing the topic_subject map, since it ends up with single terms rather than
the more useful "--"-separated full subjects.  Also added an "all creators"
mapping so that if the default "author" is empty for a record, the display
logic can do its best to find an appropriate value.

Gone, again, is the representative_field structure from the baseline (and from
my upgrade changes).

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394: Minor fixes

 * Fix function names in drop statements for upgrade
 * Adjust array concat syntax in plpgsql

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394: Reingest streamlining, schema realigning, rebasing

I've rebased this to master and undertake some work to allow streamlined
reingest of specific index definitions.  The API remains essentially backwards
compatable, but is reingest_metabib_field_entries() is extended to accept a
list of index definition IDs to which it should restrict its work.  If that
optional parameter is not passed, all index definitions are processed.

This has the benefit of skipping XML transformation for index definitions
which won't produce output useful to the requested reingest process, which
should provide a significant speed boost for some situations.

The upgrade schema has now been realigned with some missing bits from the
baseline, but the baseline may still be lacking some from the upgrade.

The data upgrade script has been made to use the existing index definitions
where they match the needs of the new ones, and to use the new reindexing
options.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Webstaff Display fields utility functions

Adds functions for translating bib record display field data into a
variety of useful formats and structures.  Some are best suited for
grids, others for lists of values, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Compressed and wide display entry VIEWs

flat_display_entry is one row per entry with all of the relevent info.
compressed_display_entry sits atop flat_display_entry and compresses the
values into JSON scalars and arrays depending on the 'multi' value.

Wide display entry is a tabular view of the well-known fields a la
reporter.simple_record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 display map perms; links; formatting

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 flat_display_entry gets 'field' col

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 config.display_field_map / flat json display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display fields schema rebase

Rebase modified SQL functions to match their current production verions,
plus changes required for this branch.

Specifically metabib.reingest_metabib_field_entries and
biblio.extract_metabib_field_entry

Remove duplicate config.metabib_representative_field_is_valid
function declaration from 002.schema.config.sql.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Fix DB order of operations

'representative_field' (and its check function) create circular
references between metabib_class and metabib_field.  The most
straightforward fix is to deal with those fields separate from the
initial table creation and field insertion.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display fields schema/IDL continued

* Upgrade SQL repairs
* make display fields field-safe
* Representative fields

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 un-squash repeated fields; some minor schema re-alignment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Display Fields DB schema continued

* Schema chnange continued
* mde IDL entry
* flat display IDL view
* IDL links from bre to mde/mfde

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1251394 Add display_field column to config.metabib_field

The idea is to pull the XPath definitions and i18nized labels for
config.metabib_field entries into other contexts, to avoid duplicate /
conflicting defintions in different layers of the code. If display_field
is TRUE, then it is a signal that it could be usefully exposed to users.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1599894 - OPAC disable Add to MyList when doing metabib search

Since adding a result to MyList yields to a random title
(due to bad id) being added to temp. lists, disable MyList if
metabib search is on, i.e "Group formats and editions"
checkbox is checked.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/opac/parts/result/table.tt2

LP#1673870: release notes for ebook transactions

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1673870: avoid e-session cookie weirdness

This patch is a bit of hackery to work around an intermittent
(but frequent) situation where the vendor session cookie got
cleared right before invoking the cancel hold method, leading
to its failure.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Bill Erickson <berickxx@gmail.com>