LP#626157 Ang2 experiments - copy query

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / nav

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / nav

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#626157 Ang2 experiments / base setups

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: Use new images for in-house use

The In-House Use docs previously had new web client screenshots, but a
recent commit accidentally reverted them to the old XUL client images.
This commit changes the references back to the new images.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Forward-port 2.12.8 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.0.2 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

release notes for Evergreen 2.12.8

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

3.0.2 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1178802: force ceiling dates to be end of day

This patch ensures that when a hard due date (or hard due date value)
is created or edited, the ceiling date is set to the end of that day.

This fixes a problem where a ceiling date would not be applied for
loans checked out earlier on the ceiling date itself.

This patch intentionally does not touch existing hard due date
values.  It also does not use the database or middle layer to coerce
the ceiling dates to end of day to leave upon the possiblity that
an Angular version of the hard due date editor will allow operators
to set both date and time. (Note that Dojo does not readily have a
combined date/time picker.)

To test
-------
[1] Apply the patch, then in the hard due date editor, verify that
    when creating a hard due date _value_, the date gets saved as
    ending at 23:59:59 in the local time zone.
[2] Similarly, verify that when editing an existing hard due date value,
    the date gets saved as ending at 23:59:59.
[3] Repeat steps 1 and 2, but this time for hard due dates.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1734737: Display originating template UI

Until the (planned for 3.1) ability to clone XUL-created reports in the web
staff client is completed, it would be useful to at least display to the user
the origin UI in which a template was created. This will allow staff to, for
the immediate term, decide which UI they should use to deal with a particular
template, re cloning etc.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: fix list item index in basic_holds.adoc

Signed-off-by: Ben Shum <ben@evergreener.net>

lp1705133 view holds patron info redaction

Removed extra or sensitive patron information from patron and record
hold grid

Signed-off-by: Alex Cautley <acautley@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/catalog/t_holds.tt2
modified:   Open-ILS/src/templates/staff/circ/patron/t_holds_list.tt2

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

2nd level of bullets requires '**'

The Asciidoc for this file had two levels of indentations for the
intended bulleted list, but bullet indentation levels are set by
the number of asterisks:

* = 1st level
** = 2nd level

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP1714390:Remove acp Editor Formatting Frustration

In bug 1713064 I added a directive to make it possible to use
a String as a Model in an Input tag with type Number. Unfortunately
there was also a formatting function in that branch that works well
sometimes but is far more frustrating than it is helpful for enough
workflows that it should be removed.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1734963: Teach copy template converter about older templates.

The XUL-to-web-client copy template converter created to fix
bug 1691269 needs a little help when the value stored is a
number rather than a string.

Thanks to Jeff Godin for troubleshooting help and Mike
Rylander for the suggested solution.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jeff Godin <jgodin@tadl.org>

Stamping upgrade script for xul-to-web copy template translation

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691269: (follow-up) fix whitespace to match local style

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691269: add unit test for convert_xul_templates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691269: include volume fields in converted copy templates

This patch insures that call number prefix, suffix, and classification
scheme from copy templates created in the XUL unified copy editor are
brought over to web staff copy templates.

Note that in order to successfully test the call number portion of
converted copy templates in the web staff client, the volume/copy editor
default "Allow Call Number attributes in Copy Templates" should be
turned on.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1691269: (follow-up) include new cust in seed data

Also s/Copier/Copy/.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1691269: Webstaff Copy Editor Templates

This branch will translate and transfer your XUL client templates
the first time you load the web client copy editor. From that point
on the two diverge with no further connection to each other.

This branch also allows your copy templates to travel with you
between browsers, machines, and so on, while still allowing users
that share a browser but not usernames to have their own templates.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP 1698176: Return undef with die event in Actor.pm _add_patron function.

If the CStoreEditor create_actor_user call fails in the _add_patron
helper function in OpenILS/Application/Actor.pm, the CStorEditor's
die_event is returned as a scalar value.  The caller expects a list
return with two values: the user object in index 0 and the event, if
any, in index 1.

Returning just the event causes the caller to use the event as if it
were the user object.  This leads to a different error message later
in the code: Can't call method "billing_address" on unblessed
reference at /path/to/perlib/OpenILS/Application/Actor.pm line 743.

This commit changes the return value in the event of a database insert
failure to be the two member list as expected by the caller with undef
in index 0 and the die_event in index 1.  This returns the proper
error message to the client.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>

LP#1671150 Document unaccented name index fix

Release notes for evergreen.unaccent_and_squash function (and
dependent indexes) fix.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1671150 Stamp database upgrade script.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1671150 fix unqualified unaccent call

Fix index creation failures when using pg_restore by qualifying the
unaccent() function call in evergreen.unaccent_and_squash()

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1708489: Adjust sample holds status

Changed the sample holds status to a status that would show up on a real-world holds
shelf.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1708489 Hold Shelf Print Template Additions

- Add Hold Status and Shelf Expiry Date to Hold Shelf Print
Template

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_hold_shelf_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/admin/workstation/app.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1708487: Update helper text in print template

Update the helper text for title and barcode for bills printer templates to
include xact.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1708487 Add Title and Barcode to Bill Print Templates

- Add additional documentation to Bills, Current; Bills, Payment; and Bills,
Historical print templates.
- Convert xacts to objects containing all required information for print
templates

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bill_payment.tt2
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bills_current.tt2
modified:   Open-ILS/src/templates/staff/share/print_templates/t_bills_historical.tt2
modified:   Open-ILS/web/js/ui/default/staff/circ/patron/bills.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: fix broken image reference

Fix broken image reference in copy tags documentation: file on disk
has lowercase png extension, reference in document was uppercase PNG
extension.

Signed-off-by: Jeff Godin <jgodin@tadl.org>

lp1646210 Call Number Affixes Waiting for Copy bugfix

-Checks for a volume in hold data, preventing broken grids in cases
where a hold is waiting for copy

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/web/js/ui/default/staff/circ/services/holds.js

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

Docs: updating SIP docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Set Per-OU Limits on Allowed Payment Amounts

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

Docs: search scope info

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: making tt2 docs more modular

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: Asciidoc fixes

Fixed capitalization for image file formats.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: small fixes to closed dates editor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1723498: fix display of count of duplicate patrons

This patch fixes an issue where the patron registration
form's alert for duplicate phone numbers did not display
the count of matching records. (This was caused by code
that was expecting a string to be passed by reference
when it's passed by value in JavaScript).

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1723498 Patron reg/edit dupe search repairs

Avoid clobbering duplicate patron search links by managing search URLs
individually by search type and displaying a search link per search
type.

This change includes an improvement over the XUL version in that a link
will be displayed per matching phone number so each can be searched,
instead of only searching the most recently entered phone number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1731496 Avoid PhantomJS BroadcastChannel failure

Avoid attempts to create BroadcastChannel objects in contexts where the
object does not exist.  Specifically, allow PhantomJS to run unit tesst
without dying on:

ReferenceError: Can't find variable: BroadcastChannel

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Docs: User Buckets

Documentation for user buckets.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Copy Tags/Digital Bookplates

Documentation for the copy tags feature.

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Docs: Patron Search to Place Hold

Patron search functionality while placing a hold in the staff client.  Docs written by Mary Jinglewski.

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Serials Module 3.0

Documentation for the Serials module in Evergreen 3.0

Signed-off-by: Angela Kilsdonk <akilsdonk@equinoxinitiative.org>

Docs: Re-adding the library settings for patron self-registration

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: incorporating offline circ docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1708488: adjust how patron financial summary is exposed to checkout receipts

This patch builds on the previous patch by grabbing the patron's
financial summary from the patron stats values. The "patron_money"
template value is no longer associated with a particular loan, meaning
that you can do things like this:

<span ng-if="patron_money.balance_owed">You owe the library ${{patron_money.balance_owed}}</span>

The additional values include

* patron_money.balance_owed - current balance
* patron_money.total_paid - payments made on outstanding fines/fees
* patron_money.total_owed - total of outstanding fines/fees

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>

LP#1708488 Checkout Print Template Balance Owed

Add Patron's money summary to Circulations in Checkout print template.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terra McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding introduction section to webclient offline docs

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1731281: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding offline circ webclient docs to circ manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1731281: Remove Deleted Items From acvac Table

The script that created the acvac table accidentally
included entries for deleted items which leads to confusion
when titles the library no longer owns are displayed as
available again, even though no copies appear on the record
detail page. This upgrade script removes any that are left
there.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1724223: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1724223: tweak upgrade script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1724223: Fix inherited FKEY triggers

When running these triggers on TG_OP=DELETE they
always fail and prevent the delete. Skipping the
triggers on DELETE allows things to continue as
usual.

To test
-------
Verify that after applying the patch that you can remove
notes and copy tags from copies and copies from buckets
and Vandely import queues.

Signed-off-by: Jason Boyer <JBoyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1724915 Webstaff auth timeout works w/ multiple tabs

Adds a new API parameter to open-ils.session.retrieve which allows the
session to be fetched without extending the auth session timeout.

Teach the browser client to use the new API.

Teach the browser client to notify all webstaff tabs when a logout event
has occurred, so every tab can immediately log out.

To test
-------
[0] Apply the patch.
[1] Log in the web staff client, then open a new window/tab
    and navigate to the web staff client.
[2] Log out of the web staff client in one window. Verify that
    the second window automatically refreshes and goes to the
    login page.
[3] Set a low staff idle timeout (optional).
[4] Repeat step 1, then wait for the timeout. Verify that the
    staff client is logged out in both windows.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1728677: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1728677 - Add survey data to concerto test dataset.

To more closely approximate a realistic test environment,
this branch adds data to the concerto test dataset.  Most users
are given a randomized response to a simple 3-question survey.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1717351: tweak release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Added Release Notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Web Client: Make Patron Email Clickable

The patch is twofold. First, "mailto" has been added to
$compileProvider.aHrefSanitizationWhitelist() throughout the project.
Second, the patron email in the patron summary has been wrapped in an
anchor with ng-href="mailto:{{patron().emaio()}}" to enable the desired
functionality.

Signed-off-by: Sam Link <slink@columbiacountyga.gov>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Improve warning format in ebook api section

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1527731: Allow specified join order

With this commit we now support user-defined join order in cstore and friends.
Previously, because the join structure of oils_sql beyond the specification of
a single table was only allowed to be represented as a JSON object, it was
subject to potential hash key reordering -- thanks, Perl.  By supporting an
intervening array layer, one can now specify the exact join order of the
tables in a join tree.

For example, given the following JSON object passing through a modern Perl 5
interpreter as a nested hash:

{select :   {acp:['id'],
             acn:['record'],
             acpl:['name']
            },
  from  :   {acp:
                {acn:{filter:{record:12345}},
                 acpl:null
                }
            }
}

the FROM clause of the query may end up as:

  FROM  acp
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)
        JOIN acpl ON (acp.location = acpl.id)

Or as:

  FROM  acp
        JOIN acpl ON (acp.location = acpl.id)
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)

In some situations, the join order will matter either to the semantics of the
query plan, or to its performance.  The following example of the newly
supported syntax illustrates how to specify join order:

{select :   {acp:['id'],
             acn:['record'],
             acpl:['name']
            },
  from  :   {acp:[
                {acn:{filter:{record:12345}}},
                 'acpl'
            ]}
}

And the only FROM clause the can be generated is:

  FROM  acp
        JOIN acn ON (acp.call_number = acn.id AND acn.record = 12345)
        JOIN acpl ON (acp.location = acpl.id)

Why is this important
---------------------
While Postgres' planner is very smart, a join tree with many tables may create
a plan search space that is simply too large to be tested effeciently.  In such
cases, Postgres will do its best to find a good plan for the query using its
GEQO algorithm.  Often, a DBA or developer has enough understanding of the
expected relative data sizes involved to give Postgres a leg up by specifying
a join order that improves the planner's chances of generating an optimal plan.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>