fix bug with creating new copy alert suppression rules

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add multi-select for setting copy alert type next status field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

adjust labelling

- The action buttons for acknowledging a temporary
  copy alert now use "Clear"
- Menu items for bringing up the copy alerts dialog
  now uniformly use "Manage Copy Alerts"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set default value of 'Renewing?' to false when creating alert type

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix fleshing set of next copy statuses

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

when renewing, filter out alerts where in_renew is false

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add add/acknowledge copy alert actions to holdings view menu

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix error made when rebasing

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

fix syntax error

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

update from $modal to $uibModal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: Show event name in the manage interface (useful for staff alerts)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webstaff: Make alert type selection sticky when an alert is saved

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fleshed call does not find "odd" circs, fetch directly; Disable auto-overrides on existing circ to allow alerts to show up

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

TODO: Verify that the resolution of the merge conflict doesn't
cause a regression on LP#1522635

Protect the status list from empty items

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add better page titles

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use ngInit and ngOptions so we can have a nullable Event field

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Array-ify next_status when sending back to client; Skip old-style status events when using new-style alert infrastructure.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix last commit... typo

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add dblclick handler for autoGrid

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Align terminology with the copy editor

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Further cleanup of location checks; remove "no" option from at_circ and at_owning

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add LONGOVERDUE to the state list

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add more seed data

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Adjust display of next-status labels in the copy alert popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Correct location test for at_circ and at_owning

Signed-off-by: Mike Rylander <mrylander@gmail.com>

tweak styling

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

improve init of next status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add 'add copy alert' action

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

add acknowledge alerts to renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

allow both CHECKIN and CHECKOUT alerts to fire during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

correctly test whether the alert_type fires during renewal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

no longer display the legacy copy alert message

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix styling of manage copy alert button in item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add new-style copy alerts to volcopy defaults selector

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

copy alert type editor can now create and update copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

make copy alert suppression editor feature-complete

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

set name as copy alert type selector field

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert suppression to splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start UI for managing copy alert suppression

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alerts to local admin splash page

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start on a config editor for config.copy_alert_types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

teach vol/copy editor how to deal with copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add copy alert ack/manage action to checkin, checkout, and item status

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2

implement setting next status upon checkin

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

display text for system-generated copy alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

return all potential next copy statuses, not just first

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

have a bit of visual separation between alerts

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

start work on egCopyAlertManagerDialog

This dialog is currently capable of:

- displaying copy alerts during checkin and checkout
- allowing the operator to acknowledge temporary alerts

TODO:

- allow display of all current alerts
- allow alerts to be added

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
Open-ILS/web/js/ui/default/staff/circ/services/circ.js

make egCore.pcrud.apply() work

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

some sample copy alert types

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

don't generate system copy alerts if copy state is normal

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

support the LOST_AND_PAID status added in LP#1198475

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix various thinkos and syntax errors to get the biz logic working

As of now, open-ils.circ.checkin is now starting to emit
custom copy alerts.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix some typos, syntax errors, and stray invisible characters

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

add typo/space fixes to baseline schema

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

biz logic for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Baseline IDL stuff for alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Initial schema for copy alerts

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Docs: Publish the 2.12 release notes

We've released 2.12, let's integrate the corresponding release
notes into the doc build.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: Use the 2.11 release notes

Update root.txt to point to the 2.11 release notes.

Signed-off-by: Robert Soulliere <robert.soulliere@mohawkcollege.ca>

Resolve a few doc build errors with images

* We need to match the case of images exactly on case-sensitive file systems
* Two dots in a file name confuses the simple-minded PDF build
* Comment out images that we don't actually have yet

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#1669868: fix regression that broke building staff client

Looks like AM_CONDITIONAL should not be in if blocks per
https://www.gnu.org/software/automake/manual/html_node/Usage-of-Conditionals.html

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

fix typo that broken generation of es-ES lang.dtd

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update server upgrade instructions for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update release notes for 2.12.0

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

2.11.3-2.12.0 schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1668720: remove browser console noise for OPAC

This patch fixes a case where JavaScript used in the OPAC
attempts to set the value of a #client_tz_id input on all
pages, even though only the login page has such an input.

To test:

[1] Load the OPAC homepage and open the JavaScript console/developer tools.
    Note that there's a "Cannot set property 'value' of null"
    error.
[2] Apply the patch and try again; this time there shouldn't
    be such an error.
[3] Open the login page, and verify, using developer tools,
    that the hidden client_tz_id input does have its value
    set to the client timezone.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP 1669868: Fix make check for all distros.

Chris Sharp found that make check was failing on Ubuntu 14.04 and 16.04.

I borrowed a few lines from the OpenSRF configure.ac and modified the
Open-ILS/src/c-apps/tests/Makefile.am to use a more autoconf-oriented
approach that won't lead to unnecessary checks in the install scripts.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1675025: Docs: mention that Vandelay can load MARCXML

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: README to include Debian for changing ownership of /var/lock/apache2

Minor tweak to also include Debian among distributions where it might
be necessary to change ownership of /var/lock/apache2 to opensrf user.
Previously this had been Ubuntu only issue, but has since been encountered
during new Debian installations.

Signed-off-by: Ben Shum <ben@evergreener.net>

Docs: replacing XUL booking module screenshots with browser client ones

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1673891: Fix untranslatable strings in metarecord sibling links

We had a couple of untrasnlatable strings in the new sibling link section
of the record summary page. This commit makes the strings translatable and
also rewords one of the strings, as recommended by Eva Cerninakova, to make
it easier to translate in other languages.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1670512 Apply focus/select model udpates via timeout

Avoid manually invoking scope.$apply() in the midst of an angular
$digest loop, since this is forbidden by angular.  Wrap the apply()'s in
a $timeout, so they occur after the currently running digest.

Fixes the focusMe, blurMe, and selectMe directives.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1638377: update release notes to mention --with-perlbase

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1638377: Allow perl to be installed in non-standard locations

Add --with-perlbase configure option to specify
an alternative location for installing the Perl modules. This
can be useful for setups that want to run the Perl modules
from a shared filesystem or environments that need to run
multiple versions of OpenSRF simultaneously.

Users of --with-perlbase are responsible for ensuring that
PERL5LIB is set appropriately.

To test
-------
[1] Use --with-perlbase during the configure step, e.g.,

    ./configure --with-perlbase /tmp/perl

[2] Run make; make check; sudo make install
[3] Verify that the Perl modules are installed under
    /tmp/perl.
[4] Make a change to a Perl source file, then
    go to src/perlmods, then run sudo ./Build install. Verify
    that it remembers the --with-perlbase directory
    and installs the updated module there.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update a couple references of 2.12-beta to 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update monolithic schema upgrade script for 2.12-rc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: add facet reingest to version-upgrade from 2.11.3

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: Tweak to release notes entry on reingest

Changes the Upgrade Notes in the release notes that a reingest of both browse
and facet indexes is required.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
docs/RELEASE_NOTES_2_12.adoc

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1671936: Provide reingest for 1006 upgrade script

We missed the reingest for upgrade script 1006. Adding it here.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Fix typo, add missing contributing organization

This commit fixes a small grammar mistake and adds a missing
organization to the Acknowledgements section.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Slight rewording of release notes

This commit slightly rewords the release notes entry about the new
translator make target.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Grammar tweaks to the 2.12 release notes

Many thanks to Andrea Neiman for catching these!

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Updates to Czech organizations

Making updates to Czech organizations listed in acknowledgements as recommended
by Eva Cerninakova.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: more 2.12 release notes updates

* additional formatting
* mention the two new services in the top-level upgrade
  section.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: more typo and formatting improvements for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: mark subfield labels in 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: replace "OPAC" jargon in release notes

... in favor of "public catalog". Please note that
I don't feel strongly about this change, and won't mind
if it gets reverted. I do feel more strongly about the
word "OPAC" slipping into patron-targeted documentation.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: typo fix for 2.12 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Translator acknowledgements and PostgreSQL support

Updates the release notes with acknowledgements for translators that changed
trasnlations strings for offically-supported languages since the last release.
Also adds PostgreSQL as a recommendation as per discussion at March 2017 dev
meeting and follow-up e-mail to the dev list.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Additions to 2.12 release notes

Adds organizations that commissioned development, contributors who have
contributed since the beta release, new notes for ebook integration, and
some some missed features.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1673059: Update passwd storage test

The passwd storage PgTAP test is failing because the user ids shifted when new
sample records were added to the actor.usr table in the Concerto dataset. This
branch changes the id in the test to point to the correct user.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1671112 Sample users and addresses with Unicode characters

Introducing to the line up of sample users, José Antonio Bautista
and Munenori Kawasaki (川﨑 宗則), hailing from 800 René-Lévesque Blvd W in
Montréal.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>

webstaff: Make Items Bookable and Book Item Now for Holdings View

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1586567 Always return Fund Years sorted descending

Currently, fund year selectors in Acq interfaces (at least Acq Admin ->
Funds, and Acq -> Load MARC Order Records) show the fund years in
database order. This commit adds a descending sort to the perl function
that retrieves fund years for those interfaces. It also removes the
unsuccessful attempt at sorting that was present in the dojo code.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP# 1668414: Stamping upgrade script for oneclickdigital base URI

Signed-off-by: Kathy Lussier <klussier@masslnc.org>