LP1844418 Tech note about enabling ES via new flag

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Merge remote-tracking branch 'origin/master' into collab/berick/lp1844418-elastic-ang8

Forward-port 3.4.1 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.3.5 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.2.10 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 3.1.16 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 3.2.8 to 3.2.9 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Forward port 3.1.14 to 3.1.15 db upgrade script

Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: LP1849137 follow-up: add release note

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1849137 Patron View hide OPAC header

Hide the TPAC header (nav links, My Account, etc.) when displaying the
embedded read-only record detail view in the staff catalog Patron View
tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1849137 Catalog Patron View loading icon

Display the usual loading circle icon while the embedded patron view
iframe is loading.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1849137 Catalog Patron View embedding improvements

Adds a readonly record detail view to the OPAC.  This is used by the
Angular catalog Patron View tab to present a version of the OPAC where
all links, buttons, and inputs are disabled.

Dynamically style the height of the embedded iframe to prevent nested
scroll bars in the Patron View.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1849137 Staff catalog Patron View tab

Adds a tab to the Angular staff catalog record detail page which
displays an embedded display of the patron OPAC view of the record
detail page.  This replaces the View In Catalog button.

The iframe is not linked or tied into the parent Angular app in any way.
It's just an iframe with a source.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1830973 Angular 8 org family test spec repair

The test runner does not like that the test expectations are wrapped in
the fixture.whenStable promise.  It reports an error, since no
expectations occur in line with the test:

ERROR: 'Spec 'Component: OrgFamilySelect allows user to turn off
includeDescendants checkbox' has no expectations.'

As the whenStable checks do not appear to be necessary, simply removing
them resolves the issue and allows the tests to succeed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

Translation updates - po files

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Translation updates - newpot

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Docs: Adding 3.4.1 release notes

The acknowledgements section was built entirely from the git log
"Signed-off-by" lines.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Add 3.3.5 point release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Add 3.2.10 point release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Add 3.1.16 point release notes

Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1846038 Remove extra grid refresh from configuration load

Bug LP#1790169 added the ability to save sorting configuration, but it
also added an additional grid refresh to the configuration load.  This
breaks grid loading.

The expected flow is for is to first load any existing configuration,
then do the first collect() for the grid.  This refresh() call adds
potentially a second collect() which may run earlier than it should,
and overall does not seem necessary.

To test:

(Make sure you are testing on current master or rel_3_3/3_4, or you
will (like me) hit related bugs which have been fixed.  Also, some
grids (especially circ) do not honor sort for other reasons, so avoid
those for now.)

1) Find a grid which has a typical get() process.  Suggestion would be
a basic auto grid, such as full bill details,
https://localhost/eg/staff/circ/patron/11/bill/43/details .
2) Set a sort value you can see, then *save* the configuration.
3) Before the patch, billing details grid doesn't load.  After patch,
grid loads and still honors the defined sort.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1849523 Angular catalog split record batches

The result page of the Angular catalog now fetches the record info in 2
batches.  The first batch is relatively small (currently 5 records) and
allows the results page to start rendering results earlier in the
display process.  The second batch of records, which includes all the
rest of the results, then drops in as they arrive.

Note the first batch of records will be the first 5 results from the
search so the second batch of results can simply be appended and avoid
page shuffling.

Includes thinko fix for batched holds retrieval.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Merge remote-tracking branch 'origin/master' into collab/berick/lp1844418-elastic-ang8

LP1849523 Ang cat holds batch retrieval

Angular catalog leverages the new batch versions of the bib / metabib
hold counts API to reduce the number of API calls needed per results
page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1849523 Batch hold count streaming API

Provides a batch, streaming version of:

open-ils.circ.bre.holds.count.batch
open-ils.circ.mmr.holds.count.batch

Response include the record ID and the count per record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Stamp upgrade script for LP 1849152

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

loading custom css from library setting

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1845693: (follow-up) clarify what CHROME_BIN should be set to

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1849506: Remove "Install latest LTS node from source" docs

We install specific versions of node using the -developer Makefile
targets; rely on that instead of potentially leading people astray with
the wrong version of node as time marches on.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1845693: Test Angular(JS) with modern browsers

Rather than using PhantomJS to test Angular(JS),
we can use all supported browsers for the web client.
Currently this is Firefox and Chrom(ium).

Because of the number of dependencies this also
requires that testing is removed from the standard
build instructions and only done in specific testing
environments or on developer machines.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1835620: Require some Storage submodules instead of use them

Switch from "use" to "require" for submodules in OpenILS::Application
::Storage::CDBI and OpenILS::Application::Storage::Driver::Pg.
Circular dependencies and other issues cause the following errors at
compile time for those modules:

Compilation failed in require at
/usr/local/share/perl/5.28.1/OpenILS/Application/Storage/CDBI.pm line
9.

Compilation failed in require at
/usr/local/share/perl/5.26.1/OpenILS/Application/Storage/Driver/Pg.pm
line 15.

Require loads the submodules at run time and does not attempt to
import any methods.  This is the behavior we want, eliminates the
above errors, and everything still works.

Add comments above the required modules explaining why require is
needed and not use.

Enable and reorder all of the tests in Open-ILS/src/perlmods/t/
09-OpenILS-Application-Storage-Driver.t.  Repairing the above issue
also repairs these tests.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1806783 Offline: Non-cataloged item receipt printing

When checkout out non-cataloged items in the offline interface,
the receipt will now print 'Non-cataloged item' and the number
of items rather than printing nothing.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1844418 Global flag to enable ES for bib-search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1849372 Close all open dialogs on Angular route change

On all angular route changes, force close any open dialogs, since it
makes little sense for them to persist across interfaces.

To test:

[1] Navigate to Server Administration
[2] Navigate to Age Hold Protection Rule Configuration
[3] Double-click a grid row to open an edit dialog
[4] Click browser back button to return to the Server Admin page
[5] Confirm edit dialog closes once the navigation is complete.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1844720: avoid hard-coded paths in Apache config

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP #1765434 Browser refresh closes purchase order

Adds a Refresh button to refresh the iframe in place.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1825403: Do not Include Tag Owner in Tag

Copy tags were accidentally having their owning
location shortname included in the tag values,
this patch allows the owner to be displayed but
not included in the value used.

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

stripdots and spacedots analyzers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add pubdate to suggested default set

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Metarecord constituants search uses ES

Signed-off-by: Bill Erickson <berickxx@gmail.com>

static or dynamic search props based on config

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more in-db field migration

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Move to in-db field configs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more dynamic repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

custom mapping continued; fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

extract metabib fields at populate time

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Consolidate bib search index builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Ignore inactive elastic nodes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

avoid indexing dupe data

This came up when some test records had links to multiple metarecords,
causing the data to double-up on the join to the MR table.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

custom mapping file repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Avoid passing non-indexed fields to save disk space

Signed-off-by: Bill Erickson <berickxx@gmail.com>

support custom index mappings from file

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Support metarecord indexing and searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Support metarecord indexing and searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Support metarecord indexing and searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Support bib record transcendance

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1840982 Replace troublesome catalog icons

Replace 'arrow_right' icon with 'keyboard_arrow_right' (ditto left) in
the Angular catalog holdings maintenance grid.  This resolves an issue
where the 'arrow_right' icon presents with excess padding, causing the
barcode / call number values to appear to be empty in the
'Location/Barcode' column of the holdings grid.

See also LP1830912 for icon padding issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

support query_string queries from keyword

Signed-off-by: Bill Erickson <berickxx@gmail.com>

pkey changes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

indexer batch size fixes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

remove bib field primary key, not necessarily unique

Signed-off-by: Bill Erickson <berickxx@gmail.com>

prevent dynamic mapping; avoid large raw keyword values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

inline init() to avoid cstore startup race condition

Signed-off-by: Bill Erickson <berickxx@gmail.com>

implement journal title search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Global flag is part of base context

Signed-off-by: Bill Erickson <berickxx@gmail.com>

exact/prefix leverage new field class indexes

No need to fetch the bib fields anymore, since we can use the new meta
indexes for term searches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Tech notes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Tech notes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Tech notes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Tech notes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Tech notes continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Elastic integration high-level tech notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Copy location filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

skip browse entry searches

Signed-off-by: Bill Erickson <berickxx@gmail.com>

search script improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

explicit facet field, facet repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

update sample queries for combo fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

create some query_string shortcuts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

leverage copy_to for grouped fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

fix deprecated imports / uses

Signed-off-by: Bill Erickson <berickxx@gmail.com>

query string runner

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Rename; add utf8 bits

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add more sample searches

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Make text index name more precise

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ISBN variations sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "eager global ordinals on facet fields"

This reverts commit 950f72d935218ef949b70eaee709c03551744a30.

remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eager global ordinals on facet fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

boost and score sorting repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Better defined node unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Identifier searches / isbn issn normalizers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

misc tidying and docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs, query clensing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

move away from mapper to pure client

Signed-off-by: Bill Erickson <berickxx@gmail.com>

exact/prefix searches continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic service continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder / marc search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder in action

Signed-off-by: Bill Erickson <berickxx@gmail.com>