old-git.evergreen-ils.org Git - evergreen/pines.git/log

LP#1533329: live tests for opt-in feature

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1533329: Selectively disallow opt-in based on patron's home library

Patrons from Library A can "opt in" to sharing their personal
information with Library B.  However, hitherto there has been no way for
Library A to prevent their patrons from being opted in at other
libraries.  This would be useful if, for example, Library A is a school
library and does not want other libraries in the consortium to have
access to student accounts.

This commit adds the ability to selectively disallow opt-in by home
library.  Specifically, it makes the following changes:

1. Adds an org setting (org.restrict_opt_to_depth) that governs opt-in
restrictions.  All org units within the home OU's section of the org
tree at or below depth X are within the patron's opt-in scope; opt-in is
disallowed at any library outside of that scope.  If the setting is not
enabled, the entire org tree is effectively within scope.  (None of this
should be confused with the opt boundary, which defines the point at
which patrons need to be opted in vs. just granting access without
opt-in.)

2. Modifies open-ils.actor.user.org_unit_opt_in.check so that it checks
that setting and determines if the current work OU is within the
patron's opt-in scope.  If opt-in is not permitted at this work OU,
an appropriate response is returned.

3. Handles the response in both staff clients.  If opt-in is disallowed,
staff will see an alert which says, "This patron's record is not
viewable at your library."

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1392396: stamp DB update

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1392396 - Release notes for New Patron Notice A/T.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1392396 - Changed the hook description to match the other
au hook entries.

Signed-off-by: Josh Stompro <stomproj@larl.org>

LP#1392396 - Renamed hook from "create" to "au.created" to make it
easier to tell that we are talking about "actor.user created date"

Signed-off-by: Josh Stompro <stomproj@larl.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1392396 - New patron welcome email action/trigger event def

This adds a new event definition to new installs for sending an email
to new users soon after their accounts are created.

An update script is also included to add this event to existing installs.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Conflicts:
Open-ILS/src/sql/Pg/950.data.seed-values.sql

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1371647: stamp DB upgrade

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1371647: tweak pinned IDs

Tweak an ID to avoid an overlap with the change
for LP#1519055.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP 1371647: Additional Fixed Fields and Values

Define all fixed fields for use in the MARC editor and
add acceptable values for context menues. Also define
composite coded values for special multi-position
single character fields.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1391282: Add Auto-Submitted: auto-generated header to included A/T email templates.

This patch updates various stock A/T definitions for
email notifications to add the following email header:

Auto-Submitted: auto-generated

This specifies to email clients that the message was
generated by a computer program and that no automatic
response is desired (particularly out-of-office/vacation
responses).

No upgrade script is provided; administrators who
wish to use this header for existing notices should
update them manually.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1375043: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1375043: Support for in-A/T telephony configuration

The AstCall reactor module creates a callfile for Asterisk, given a
template describing the message and an environment defining
necessary information for contacting the Asterisk server and scheduling
a call with it.

If you have only one SIP server, you can set it up like this in the
opensrf.xml configuration file:

    <telephony>
        
        <enabled>0</enabled>
        <driver>SIP</driver> 
        <channels> 
            
            <channel>Zap/1</channel>
            <channel>Zap/2</channel>
            <channel>IAX/user:secret@widgets.biz</channel>
        </channels>
        <host>localhost</host>
        <port>10080</port>
        <user>evergreen</user>
        <pw>evergreen</pw>
        
        
    </telephony>

To support more than one SIP server, say, per library, you can use
Action/Trigger parameters like these, which model the same information
as above:

    enabled = 0
    driver = "SIP"
    channels = ["Zap/1", "Zap/2", "IAX/user:secret@widgets.biz"]
    host = "localhost"
    port = "10080"
    user = "evergreen"
    pw = "evergreen"
    callfile_lines = ["MaxRetries: 3", "RetryTime: 60", "WaitTime: 30", "Archive: 1", "Extension: 10"]

Co-author credit goes to Steve Callender, who helped build this patch.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP #1466173 Selfcheck Hide UI Elements Until Patron Auth

Currently, there are visible elements on the lower portion of the
login screen that the patron cannot use until after authenticating.
This patch hides those elements except when the patron is authenticated.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1470957: stamp schema upgrade

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1470957: adjust a previous regression test

Now that there are normalizers set for pubdate,
008/Date1 = " " is now normalized to "0000".

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1470957: provide pgTAP test for expected pubdate normalization

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1470957: update upgrade script

This commit updates the upgrade script to account
for other changes to metabib.reingest_record_attributes()
that were made since the original patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1470957: Normalize date1 (pubdate sorter) to null when not numeric

We supply a normalizer function for making sure date-ish values are
always numeric (several, in fact) but we don't enable them by default
for appropriate fields.  This does that.

Additionally, we allow NULL sorters so that the reingest of a "broken"
record will get fixed.

We avoid the need for a reingest to cover the sorter issue by removing
non-numeric pubdate sorters.

To test
-------
[1] Identify some records where the Date1 value in the 008 field
    is '||||'.
[2] Perform a catalog search that includes some of those records
    and sort by publication date newest to oldest. Note that
    the |||| records sort at the top.
[3] Apply the patch and perform the schema update.
[4] Perform the search again (possibly clearing the search
    results cache first).  This time, the |||| records should
    sort near the end.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1492793: add release notes

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1492793: teach Clark Kent to set the Pg app name

Clark Kent can now also use the application_name
setting in the relevant sections of opensrf.xml to
set the Pg application name.

To test:

[1] Apply the patch, restarting opensrf.settings, and
    start Clark.
[2] Run a report that will take at least a minute to
    finish. While it is running, query the pg_stat_activity
    table. There should be at least one row where the
    application_name column is set to 'Clark Kent (reports)'.
[3] Note that since the master Clark process opens a database
    connection, checks whether there are any reports to run,
    then immediately closes the connection, it's unlikely that
    you'll catch a 'Clark Kent (state)' connection when
    querying pg_stat_activity.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP1492793: Support Application Name Postgres Option

If app_settings/database/application_name is defined,
connections by that service will have the application_name
postgres option set, allowing log analyzers to associate
queries and services.

To test:

[1] Apply the patch and restart OpenSRF services.
[2] Query the pg_stat_activity table in the PostgreSQL
    database; the application_name column should now
    be populated with values like 'open-ils.cstore'
    or 'open-ils.storage' that indicate which Evergreen
    service holds the database connection.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1516757: add Perl test case

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1516757: ensure that SIP2 returns DOB correctly

Parse dates of birth using the local timezone to ensure that the date in
the database will match what is sent to SIP clients.  Otherwise, the
date will be parsed as UTC and may result in the DoB value being offset
by one day in the SIP response.

To test
-------
[1] Fire up a SIP client of some sort and retrieve a patron record;
    verify that the patron's date of birth is correct, and not
    offset by one day.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1516022: new reporting source for hold/copy ratios

Fixed the link field name so it matches the new field name for the
Pickup Library, pickup_lib_or_desc.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1516022: add release note

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1516022: new reporting source for hold/copy ratios

This patch adds a new reporting source, "Hold/Copy Ratio per Bib
and Pickup Library (and Descendants)", that, for each bib
that has a hold request on it or any of its components,
calculates the following:

- active holds at each OU (including the OU's descendants)
- holdable copies at each OU (and its descendants)
- the ratio of the above two counts
- counts and ratio across the entire consortium

This work was sponsored by the Pennsylvania Integrated Library
System (PaILS).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1531976: fix bringing up Mesage Center and Triggered Events

This patch fixes a bug in the XUL staff client where
using Other -> Triggered Events from the patron page,
then Other -> Message Center, only brings up the Triggered
Events page in both cases (and vice versa).

This patch works by preventing the deck code from thinking they are
the same page, despite both using the browser wrapper as their base URL.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1519911: upgrade script to fix self-checkout receipt A/T template

This patch adds an update to fix the "lb_addr.post_code" typo
in the stock A/T event definition for self-checkout receipts.
This update changes the definition *only* if it has not
been customized by the user, and it does not attempt to
fix any copies of that definition.

To test
-------
[1] Upon applying the update, generate a receipt from the
web-based self-check interface. The library's postal
code (if set) should now display in the receipt.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1519911: fix typos in some seed A/T tempaltes

This corrects typos in the seed data for these action trigger templates:

- Self-Checkout Receipt
- Hold Cancelled (No Target) Email Notification
- Hold Cancelled (No Target) User Message

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1544723: i18n - Add webstaff to update_pofiles

Add webstaff po file to the update_pofiles script so that future syncs
from the Launchpad bzr will update the webstaff po files.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1545226 - Fix MARC Batch Editor status screen.

This patch does the following:

  - The html table was broken, fixed the markup.
  - Added some styling to the table.
  - Added a row with total records info.
  - Fixed the progress bar popup; it now displays
    percentage completion and has a title so it is
    wide enough to do so
  - Added color to failed row (red), and to completion text (green).

To test:

[1] In the staff interface (both XUL and web), perform
    a MARC Batch Edit on a bucket that contains at least
    a few bib records.
[2] Verify that the progress dialog now displays the
    percentage completion of the batch edit; verify
    that there is now a row displaying the total number
    of records.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1548147: add release notes

Also, here is a test plan for the future:

[1] Using MARC Batch Import/Export, load a file
    of MARC records into a queue (arranging the matching
    criteria so that at least a few of the records
    aren't automatically imported into the catalog).
[2] Inspect the queue, and click on the "Export Non-Imported
    Records link", then save the resulting file.
[3] Verify that the file contains, in MARC format, the set
    of records that were not imported into the catalog.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1548147: set export format to MARC

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1548147 Quick Export Feature for Vandelay Queues

When we import records into Vandelay, sometimes some of the records
are not what we expected, so they get rejected. These records often
need to be loaded using a different set of options, so this link makes
it convenient to get a new file of just the rejects.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1507845 SEO home.tt2 template repair

Ensure all TT code lives within the [% ... %] blocks. This fixes an
issue where TT code "ctx.metalinks.push('');" was appearing in the
catalog as bare text.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1312699 Circ history clear-all repair

Repairs circ ID filter to allow all items in circ history to clear when
patrons disable circulation history.

open-ils.cstore will fail on {in => undef} queries.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1507845: Improve search engine optimization

Back in bug # 1414033 , we added rel="nofollow" attributes to many of the links
that led to search results or call number browsing. This was the right idea,
but a bit overzealous as it turns out. We actually want search engines to
follow those links; we just don't want search engines to index them.

Therefore, we can tweak the <meta> tag in the results and browse page headers
to say "follow,noindex", and remove many of the inline rel="nofollow"
attributes from the other pages.

In addition, add a rel="canonical" link to the catalogue home page.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <ben@evergreener.net>
Conflicts:
Open-ILS/src/templates/opac/parts/record/subjects.tt2

LP#1312699: Minor modifications to patron checkout history deletions

Minor modifications to make patron checkout history deletions work with
the new table. open-ils.actor.history.circ.clear
extended to take an optional list of circ_ids, to limit what's deleted
from the history.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1312699: Whitespace cleanup.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1312699 - Add feature to allow user to edit their checkout history.

In the checkout history page, a new column and action selector is provided to allow
the paton to indicate items they would just as soon not want to see again in the
history list for whatever reason. NOTE: This is not a PURGE function; it simply
suppresses display of items in the history list (and exported history files).
Internally, the circulations are kept by Evergreen for several reasons which are
not affected by this functionality.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1519055: Stamping upgrade script for electronic resources filter

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Fix to sql to get seed data values and to reingest instruction

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Make electronic search filter optional

Making checkboxes configurable, and off by default. Release notes updated.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Some JS fixes

Adding basic javascript to remove our search filter from the
textbox on an advanced search form. Because of the interplay among
various checkboxes/modifiers/filters, there may be duplicate filters
applied from another function's form submit; this removes all at once.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Add reingest instructions to upgrade script

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Adding Release Notes Entry for Exclude Electronic Resources Limiter

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Adding Electronic to seed values; adding upgrade script.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Fixes

Removing the <br> which moves the search results checkboxes to a new
line. Formatting will be addressed in a separate bug.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Exclude Electronic checkbox on results page updates results.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: more changes

- Add checkbox to search results page
- Adding persistence for checkboxes.
- Sentence Case Fix

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1519055: Simple checkbox to exclude electronic resources from search results

Initial checkbox to exclude electronic resources (types 'o' and 's' for
now).

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

Whitespace cleanup.

Signed-off-by: Jake Litrell <jake@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1506534: Stamping upgrade script for new z3950_attr_type check

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1506534: Fix typo in for z3950_attr_type

In 002.schema.config.sql there was a small typo for "z3950attr_name_is_valid"
where that should be "z3950_attr_name_is_valid" with the underscore between.

Fix to stop breakage on new database installs.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1506534: Improve czifm z3950_attr_type Check

Rather than use a CHECK constraint, this patch
uses a CONSTRAINT TRIGGER, er, constraint to verify
the z3950_attr_type field. This allows the trigger
to be deferred as any other deferrable constraint
and also allows parallel pg_restore jobs to complete
properly.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1491571: Ignore Case when Checking PW Reset email

Emails are not passwords and are not case sensitive;
while it is a good idea to require patrons to prove
they know the address associated with their account
it is not cool to deny them because they don't know
the capitalization of the value in the database.

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1474566 Avoid credit card payment rounding

Calculate total amount for credit payment as integers to avoid rounding
errors w/ large sets of small billings.

E.g. avoid trying to pay a fine of 9.999999999999 for a set of fines
which should add up to 10.00.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1197636 - Email record detail does not check for email

Even though no email was configured, the message shown when requesting
bib information to be emailed indicated success.  This misleading
behavior has been addressed by alerting the patron of the situation
and providing a link to the page where the email address is defined,
after which the action is automatically retried.

The success message has also been altered slightly to provide
confirmation of the generated email.

To test:

[1] Create a patron account that does not have an email address.
[2] In the OPAC, log in as that patron and attempt to email a
    bib record.  A message should display indicating that the
    email can be sent; that message should contain a link to the
    user's account page where they can set their email address.
[3] After setting the email address, you should then be
    redirected back and the email sent.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1539776 Stop wrapping of radio buttons in vol/copy editor

Simple CSS tweak to keep radio buttons and their labels on the same line.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1546125: use correct service for .storePrintTemplate

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1516104: Amending wording in license text to clarify correct license.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1516104: Adding the PNGs generated from mrpeters' SVG files and adjusting the file paths/names.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Removing placeholder icons

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1516104: Create Invoice and Purchase Order Search Icon Vectors

Created SVG vector art derived from existing icon art to accomodate missing
search icons for purchase order and invoices in Acquisitions.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1516104: Adding additional toolbar options for acq.

"Invoices" and "Purchase Orders"

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1422802 Fix javascript validation for visible parts

The previous javascript validation was not working for records with just one
part. This one works better. Many thanks to Dan Wells for identifying the fix.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP#122975 Add year to copyright statement

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

lp122975-add-licensing-text

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP1229757 - Distinct images for holds, reserves, transits

This commit changes the references to turtle.gif to three new images
holdshelf.png, reserve.png, and transit.png. When checking in a copy
that needs to go on the hold shelf, on the reservation shelf, or
in transit, a distinct image will show in the pop-up window.

Signed-off-by: Martha Driscoll <driscoll@noblenet.org>

LP#1548143 Stamping upgrade script for Vandelay parts support

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1548143 Support for parts import in Vandelay

This commit adds support for 'parts' import in Vandelay.  It is
modeled after the existing support for stat cat import.  As such, it:

- Uses '|' characters to separate labels to allow for multiple
  part assignment.
- Adds to (rather than replaces) any existing parts assigned to overlay
  copies.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1468422 Stamping DB upgrade for actor.passwd

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Use auth_internal.validate to shore up AuthProxy

Even if a user has valid credentials in the external system, we should
block them from logging in if their Evergreen account is out of sorts.
Use the API designed for this.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 "Aut" to "Auth" typo fix

Just cosmetic for now, but potentially for future sanity protection.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Make AuthProxy.pm work with new auth

Previously, AuthProxy.pm would simply lookup and use the hashed password
when the external authentication had passed. This simple method no
longer works, since even cstore doesn't have access to the hashed
password.

Instead, take advantage of the new 'auth_internal' service to create the
user session after the user has been externally authenticated.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Tighten AuthProxy argument requirements

Basically, if we aren't given a username, and we can't find a username
by barcode, give up immediately. This helps simplify the rest of the
code a bit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1468422 Release notes example avoid re-migrate

Update the batch password migrate example code in the release notes to
avoid attempts at migrating already migrated passwords.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Manual password migrate does not re-migrate

Avoid migrating already-migrated passwords when actor.migrate_passwd()
is called manually.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Release notes manual pw migration comments

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Drop auth work factor from 14 to 10

Avoid what may be an unacceptible login delay caused by work factor 14
by dropping down to 10. This reduces the CRYPT() time from ~1 second to
~.1 seconds.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Always default to root org unit

If no org unit is passed by the caller, always default to the root org
unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Auth efficiency improvements

1. Adds an oils_utils function for retrieving the ID of the root org
unit.

2. Avoid multiple cstore/db lookups for the root org unit by caching the
ID at the process level.

3. Move permission checks from open-ils.storage to open-ils.cstore.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Login permission checks are global

For backwards compat, perform all login permission checks using the root
org unit as the context org unit.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Return vanilla login failure on nonexistent username/barcode

For backwards compatibility (and security), return the same login
failure for nonexistent usernames/barcodes as for bad passwords, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Report inactive card on password OK

Prevent leaking information from authentication by only reporting that a
card is inactive if the caller provided the correct credentials. This
is consistent with how the code handles inactive patrons.

To avoid a lot of code duplication and to reduce the potential for
leaking memory (C code, amiright?), this commit includes a number of
changes to avoid exiting the API function early and saving the memory
cleanup routines until the end of the API call.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 auth-internal validate API

Adds a new open-ils.auth_internal API
open-ils.auth_internal.user.validate for checking whether a user should
be allowed to login.

It tests user existence, active=true, barred=false, deleted=false.

If a barcode is also provided, it confirms the barcode exists and is
active.

Modifies open-ils.auth.authenticate.complete to use the new API instead
of implementing the logic directly.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Remove deprecated open-ils.storage remote_update

User update in Actor.pm was the only remaining code that leveraged
the open-ils.storage remote_update API. With that code moving to
open-ils.cstore, save some RAM by no longer auto-loading/publishing
remote_update methods.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 SIP password verification

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Implement password reset updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Port user update to cstore

Migrate the user update code from open-ils.storage to open-ils.cstore.
This has several benefits:

1. We can re-use the patron password update code
2. Several actions (bad contacts, invalid address) which previously
resulted in data modifications outside the main transaction now
take place with the main patron update transaction.
3. Bigger, better, faster, stronger.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password verify and password update

These API's now support new-style passwords:

open-ils.actor.verify_user_password
open-ils.actor.user.password.update

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Admin seed data sets new-style passwd

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password storage release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Admin seed data sets new-style passwd

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 New open-ils.auth_internal service

Service is responsible for adding user data to the authentication cache.
Cache times are determined from opensrf.xml/AOUS settings. No
authentication checks are performed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Add libpcre to build for open-ils.auth

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 open-ils.auth API salted pw changes

Added .init.barcode and .init.username methods.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1468422 Password storage/migration SQL getting started

* Backwards compatible salted password storage using pgcrypt
* Adds actor.passwd and actor.passwd_type tables
* Includes pgtap tests
* Includes installation of pgcrypto

Current flow:

1. Application requests a salt to use as the CHAP-style seed
2. If new-style password exists, salt is returned.
3. Else, old password is migrated and the new salt is returned.
4. App finalizes login by checking verify_passwd.

== continued...

Store the iter_count and start using the crypt_algo column.

Make it possible to change the salt, and potentially strengthen
the salt, when changing passwords.

Make is possible to start salt-less passwords, for pw's that are managed
outside of the DB.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

LP#1333254 Improve entry debit maintenance for inv. open/close.

Improve handling of debit->entry links for invoices that cross the
open/close boundary, modifying the number of items invoiced on an entry,
and rolling back invoice entry debits.

Prior to this, some debits would be unnecessarily linked to entries and
fail to clean up properly when rolled back.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1333254 Support closing new invoices

Allow invoices to be closed at create time (as originally intended) by
fixing code thinko.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>