Patron Stat Cat Enhancements: SQL upgrade statements

Add SQL upgrade statements:  new table stat_cat_entry_default,
new columns 'required' and 'allow_freetext' on actor.stat_cat,
and new permissions to create, delete default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Only show default entry for new patrons

Only display the default entry when registering new patrons.
Otherwise, display the saved value for the patron or nothing.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Rearrange stat cat editor screen

Rearrange the statistical categories editor interface to correctly
display the "Archived" radio buttons along side the other radio
buttons.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Fix values stored, then displayed in "Allow freetext" categories

In the patron registration screen:  the widget dijit.form.FilteringSelect
stores the option value, not the displayed value, unlike ComboBox; so store
the FilteringSelect displayedValue, then set the FilteringSelect displayedValue
with the value retrieved from the patron/stat_cat_entry map table.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Enforce stat_cat "allow_freetext" flag in patron registration screen

If a patron statistical category is flagged to disallow user-provided
entries, make the category form field a FilteringSelect box;  otherwise,
make it a ComboBox.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Enforce stat_cat "required" flag in patron registration screen

If a patron statistical category is flagged as required, make
the category form field a required field, and validate it before
submitting the form.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Modify stat cat editor HTML to manipulate patron stat cat default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Modify stat cat editor javascript to manipulate patron stat cat default entries.

Add functions, methods, variables to Statistical Categories Editor
javascript to manage patron stat cat default entries.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add language entities for default stat cat entry labels.

Add label entities for setting a default entry;  rename staff.server.admin.stat_cat.edit_entry_name_submit
to staff.server.admin.stat_cat.edit_entry_submit.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add permissions for manipulating stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add Publisher actor methods for stat_cat_entry_default objects.

Add methods actor_stat_cat_entry_default and actor_stat_cat_entry_default_ancestor
to retrieve and populate stat_cat_entry_default objects.  Modify ranged_actor_stat_cat_entry
and fleshed_actor_stat_cat to also include default entry objects, if present.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add Pg DBI actor::stat_cat_entry_default table and sequence.

Add actor::stat_cat_entry_default->table and
actor::stat_cat_entry_default->sequence.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add CDBI package actor::stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Link CDBI actor::stat_cat_entry_default to parent entities.

Add relations between actor::stat_cat and actor::stat_cat_entry to actor::stat_cat_entry_default.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add OpenSRF CRUD methods for actor statistical category default entries.

Added methods to create, delete, update default entries for patron statistical
categories.  Modified create_stat_cat and create_stat_cat_entry to also create,
update stat_cat_entry_default objects if present in the request.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add OpenSRF methods for retrieving actor stat cat default entries.

Added the methods 'fetch_stat_cat_entry_default' and
'fetch_stat_cat_entry_default_by_stat_cat_and_org' for
fetching stat_cat_entry_default objects.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add event for ACTOR_STAT_CAT_ENTRY_DEFAULT_NOT_FOUND

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add stat_cat_entry_default IDL class

Add stat_cat_entry_default IDL class, and links to actor.stat_cat and
actor.stat_cat_entry

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add default entry table to database

Add actor.stat_cat_entry_default table to Pg database.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Patron Stat Cat Enhancements: Add 'allow free text' and 'required' flags

Add database entities, controller mappings, and HTML/Javascript
widgets to allow administrators to set and persist 'required'
and 'allow free text' boolean flags for patron statistical categories
in the Statistical Categories Editor.

Signed-off-by: Scott Prater <sprater@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Merge branch 'new_toolbar_icons'

Functional, but a bit mismatched with existing icons in my opinion

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Merge branch 'master' of git.evergreen-ils.org:Evergreen

missing comma. tsbere++

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

FlattenerGrid (re)honors IDL column labels as default

Linking the GridColumnPicker to FlattenerGrid killed the ability for the
FlattenerGrid to fall back to the IDL column label when no label was
defined in the markup.  This change adds a reloadStructure operation to
GridColumnPicker.  FlattenerGrid uses this to pass the updated column
labels (and any other changes) to gridcolumnpicker, which then updates
the grid display to match.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for serials holdings display improvements

Signed-off-by: Mike Rylander <mrylander@gmail.com>

holding_type on serial.issuance not quite dead

The holding_type field was removed from the serial control editor
prematurely, and this missing data was a source of mild friction.
We'll put it back for now.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Simplify serial.materialized_holding_code

Attempting to materialize holding_type and ind1/ind2 for less than
perfect data causes problems.  Since we aren't actually using this
data, let's get rid of these fields.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Only load "new" serials display if we have data

If we try to load the "new" serials display template, but have no
data (for instance, if "Use fully compressed serial holdings" is
false), we get a server error.

Rather than wrap the whole template in an 'if', let's just not
load it.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: ROWS 1 not appropriate here.

I must have thrown this in as a misguided afterthought without testing
it.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: follow-up to serials holdings paging fix

Some how I didn't notice it before, but my last commit broke things.
This unbreaks them.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: serials display paging bugfix

In the previous commit, paging at the deepest level of an expanded tree
was broken.  This fixes that, and improves pager labeling a little bit.

This also makes the default page size for holdings 12 instead of 10,
since monthlies are a pretty common case, and why not show them all on
one page.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: Improvement to serials display (under the "issues held" label)

(All the following text assumes you're using "new" 2.0+ serials and that
the org unit setting 'opac.fully_compressed_serial_holdings' is true
in the context where you're browsing.)

Today on the TPAC record detail page under the "issues held" label, you
get a list of serial summary statements, which you can expand to a list of
issuances for which items have been received.  You can place issuance-level
holds on these.

That existing interface just kind of burps up all your holdings within
scope and doesn't show you what holdings belong to what org unit.
Furthermore, it doesn't group your holdings into enumeration or
chronology units, which can matter a lot if you've got 150 years of
some daily newspaper and you're trying to browse through them in the
OPAC.

This new interface presents expanded serials holdings organized into a
tree, with summaries placed under their org units and holdings grouped
under their summaries under either chronology units (default) or
enumeration ones, controlled by a new field on serial.distribution.
There's also a new org unit setting that lets you change the default
value for this new field in the Alternate Serial Control view to
enumeration, if you want.

Like the issues-held interface it's replacing, this knows how to deal
with holdings where you have one unit per received item, or no units per
received item, but its behavior is not yet defined for one unit per many
items (the binding case).  The "regular" Serial Control view doesn't
have a widget to control the new field on serial.distribution yet.
These are the areas where I'd be interested in helping to close the
gaps, before or after this is committed.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Record.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
Open-ILS/web/css/skin/default/opac/style.css

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for Copy Editor Field Hiding

Signed-off-by: Mike Rylander <mrylander@gmail.com>

prevent templates from changing unsafe fields

in the Item Attribute Editor, for any of the fields are hidden via util.hide,
and for statuses which shouldn't be changed (like from Checked Out to something else)

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

wire up util.hide in the item attribute editor

Currently, hidden elements may still be affected through templates.

Thanks goes to MassLNC for this one.  Based on SC-D3 at
http://www.esilibrary.com/esi/docs/?p=841, with some implementation
simplifications.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

util.hide library

Provides util.hide.generate_dialog and util.hide.generate_css.

util.hide.generate_css takes one parameter, an org unit setting name for a
setting of type array. It tests this setting and for every value in the array
it looks for DOM elements with 'hideable' attributes containing those values.
It adds the CSS classname 'hideme' to such elements, and removes 'hideme' from
any non-matched elements that also have 'hideable' attributes.

util.hide.generate_dialog takes the same setting parameter as generate_css, and
an optional context org parameter (defaults to the workstation library). It pops
up a dialog with a checkbox for every 'hideable' DOM element. Clicking 'OK' will
update the org unit setting with every checked element, and it then calls
generate_css to update the interface being affected.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

move .hideme css to global.css

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

liberate this perm-cognizant lib menu generator

for re-use in other interfaces

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

AutoGrid retains external search filters

AutoGrid now caches the search passed to the most recent loadAll call
separately from any filters passed via PCrudFilterDialog.  This allows
AutoGrid to retain externally-supplied (persistent) filters (e.g.
context org unit selector) while being able to easily remove filters
passed via the filter dialog.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

TPAC: Centralized preferred library indicator

Create an explicit "Preferred library: Foobar" entry at the top of the
page (on the same line as pagination information), and include a subtle
checkmark to enable users to quickly jump to their "Search preferences"
settings and change their preferred library.

This enables us to remove the "(Preferred library)" note in the copy
counts for search results.

At the same time, move from a table display (for a single row? what?) to
a simple div/span layout for the search results.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove block on mark-receive from non-PO UI

Allow lineitem mark-received action to take place from lineitem table UI
even when not viewing a PO (e.g. from search results)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

ACQ: allow recv actions on copies from non-PO interface

* Allow PO actions on copies, like recieve, unreceive, and cancel from
  non-PO interfaces like the picklist UI and lineitem search interfaces.
  Instead of relying on whether the user is viewing a PO, use the status
  of each copy to determine which actions are appropriate to display.

* General cleanup and better arrangment of the copy actions hide/display
  logic

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make ACQ Lineitem actions more readily accessible

No longer limit PO-related lineitem actions to the PO view UI.  Instead,
limit lineitem actions on the state of the lineitem.  This allows staff
to perform PO-related (e.g. create invoice) directly from the LI search
interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

ACQ Upload import-copy option

With the addition of the new Vandelay features in ACQ, the "Load bibs
and Items" option was replaced with Vandeley import options.  In the
context of ACQ, however, Vandelay is only concerned with importing bibs
and not copies.  Subsequently, the user lost the ability to both create
catalog records and catalog copies in one step during ACQ upload.

The patch remedies that by providing a new "Load Items for Imported
Records" option within the upload page.  When enabled, all successfully
loaded ACQ copies will also be imported as real/catalog copies.

Note that it's only added to the upload page, because all other ACQ
interfaces assume that both bibs and copies should be created (e.g.
during PO activation).

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Flattened searching: generalized data retrieval via public service

For a better overview of what this feature is about than what I could
write here, see docs/TechRef/Flattener/design.txt in this commit.

This is the first new feature (as far as I know) to take advantage of
PCRUD fleshing. Very briefly, imagine issuing a query to PCRUD with lots
of arbitrarily deep fleshing, and getting back a set of flat rows with
the fields you need for display/editing/whatever all neatly picked out
as if ready to be displayed in a table or grid-based UI.

FlattenerGrid, which knows how to use this, can potentially replace and avoid
lots of relatively complex (AutoGrid + custom middle layer
methods)-powered interfaces.  AutoGrid interfaces that just work with
one fieldmapper class at a time, more or less, can just keep doing what
they're doing. Little or no advantage to switcihing to flattened data
in that case.

FlattenerGrid is CRUD-complete and has lots of the same features as
AutoGrid, where they make sense, such as the line numbers, checkboxes,
the columnpicker, multisort, etc.  Sample instance at
Open-ILS/exmpales/flattener_test.tt2 .

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping default pickup library upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Teach loading of settings inside of patron window

By passing through get_barcode_and_settings (and get_barcode, why not).

Once there we can, on load of place hold screens, load the target user's
preferences instead of having to teach TPac to do so in the background.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPac: Include day phone default_phone backup

Like JSPac.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Hook up default phone/pickup in JSPac

Because why not? Note that you can't set them with JSPac.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPac: Load user's hold prefs

When staff place holds attempt to load the user's hold preferences.

This also hooks up the barcode completion code to the TPac hold placement
interface.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

TPac: Add Default Hold Pickup Location

And add it (plus other user settings) to the patron editor.

And fix a bug where notice prefs were saving without POST.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Minor cleanup of TT2 vs closing tag

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add basic schema.org microdata to record details

It's shocking how little we can easily and reliably extract from MARC to
map to schema.org's metadata structure. However, what I could get shows
up relatively nicely on Google's Rich Snippets testing tool.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

First inklings of schema.org support

Just get the itemscope and very rudimentary mapping for the primary
itemtype into record details.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

New toolbar button icons

Courtesy of NOBLE.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

LP#520632 Fix for-loop over orgArraySearcher to preserve order

Authored by Remington Steed

This commit fixes the sort order in IE, Google Chrome of the
org unit's when choosing a search depth.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for currently unfillable holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add PLACE_UNFILLABLE_HOLD permission

And hook it up in JSPac and TPac.

General idea: If you have the permission you can place holds that will not
fill right now, in general, for any reason.

In TPac, I replaced the previous "check the last failure code" line. The
new permission basically accomplishes the same thing for now, and is less
likely to return different results from placement attempt to placement
attempt. Also, only checking one failure code of potential hundreds didn't
make a lot of sense.

In the event of age protected copies the age protected prompt wins out.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Hold targeter cancellation action/trigger repairs

When a hold/reservation is cancelled via the targeter and passed off to
action/trigger for possible event creation, ensure that all fields on
the hold are in sync w/ the master db before the hand-off.  Otherwise,
critical values, like cancel_time may be null, which can cause A/T
event creation to fail.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

ACQ provider admin page display improvements

1. Sort providers I have permission to edit to the front.

2. Improved support for viewing all providers the user has access to
view.

3. Enable the grid filter

4. Template cleanup to avoid the unnecessary horizontal scroll that
sometimes occurs along the top.

5. Misc code cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>
acq provider layout fixes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

trivial fix for Copy Buckets toolbar button

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add Makefile to rebuild targets for generated files

If you rerun ./configure with a different option (such as
--sysconf=foo), the changed Makefile needs to trigger a rebuild of the
generated files. Otherwise, the first generated version of the file is
always newer than its *.in counterpart and a rebuild won't be triggered
on subsequent ./configure runs.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Move towards build-time configuration of variables

We moved a lot of variable configuration into AC_CONFIG_FILES in
autoconf for the sake of convenience, but that turned out to be
problematic, as James Fournie noted in LP 960552, as the warning in
http://www.gnu.org/software/automake/manual/html_node/Scripts.html
notes: "building scripts this way has one drawback: directory variables
such as $(datadir) are not fully expanded and may refer to other
directory variables".

This was particularly a problem for variables such as @sysconfdir@ in
code that doesn't understand shell syntax - such as Cronscript.pm.

This commit moves towards build-time configuration of those variables.
We still use *.in files, but mark the built versions as dependencies in
build recipes such that we can build and test within the source
directory without having to install the files. We also gain the
advantage of teaching "make clean" to clean up the built versions of the
files.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Stamping No plperl Upgrade Script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

We use plperlu, not plperl. So don't load both!

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

ACQ fund admin UI improvements

* Fund retrieval directly via AutoGrid/pcrud, now that pcrud supports fleshing.
* Sort funds I can edit to the front of the list
* Enable the new improved grid filter dialog
* Leverage onItemReceived for caching funds for balanceInfo getter
* Add some height to the grid to allow more rows to be visible in the page (without scrolling)

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

ACQ Fund retrieval API permission improvements

Allow users with ADMIN_ACQ_FUND (in addition to the deprecated
ADMIN_FUND) permission to retrieve fund year information via
open-ils.acq.fund.org[.years].retrieve

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

ACQ fund summary object fleshing in IDL

Add links for fund summary classes in the IDL to allow for direct
fleshing of summary objects via pcrud.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

AutoGrid onItemReceived support

Adds support for a new call-back, called when a grid row item is
received (via pcrud onresponse).  If defined, The call-back is passed
the received item before the it's added to the data store.  This allows
users to get a direct handle on received objects.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

remove XXXX script

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Stamping upgrade script for custom toolbars

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

fix a Down action bug in Configure Toolbars

where the list selection index could be set to an invalid value, which could
cause errors for actions acting upon that index

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

fix editing of multiple toolbarseparators

and toolbarspacers.  Also beef up the hardcoded toolbar to match the stock circ
toolbar.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

reworked toolbars for dynamism

uses the data from action.toolbar

also a Toolbar Configuration UI

also added more toolbar buttons, though they need icons

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

fix constraint syntax

and add in toolbar related permissions, plus a missing and unrelated perm: IMPORT_AUTHORITY_MARC

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Beginning an unwrapped upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

DB layout for recording custom toolbars

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

utility functions for Javascript Shell

win_list() returns an array of "eg_main" chrome windows

get_tab() takes two forms:

    get_tab(chrome_window,tab_index)
    get_tab(tab_index)

The latter invocation assumes the first chrome window returned by win_list().

get_tab returns an object with the keys 'name' and 'content', pointing to the
tab label and the tab panel -> iframe -> contentWindow, respectively.

So let's say you had a patron account open in tab 1, and the Javascript Shell
open in tab 2.  In the shell, you could do:

    var o = get_tab(1);

o.name might contain something like

    1 Patron: Circulator, Ima

and you could do this to refresh that interface:

    o.content.g.patron.refresh_all()

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Fix ordinal column with multiple lists

Before this fix, if more than one util.list powered list existed within a given
document/window, they would each intefere with the other's ordinal column.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

more workstation related options for ses()

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

TPAC: Suppress copy counts for libraries that own zero copies

Rather than slavishly showing the copy counts for libraries even when
the library has no copies to show, avoid wasting the precious display
space and suppress the output.

This was a problem for both search scope libraries and preferred library
in the search results, and for just preferred library in record details.
This commit makes the behaviour consistent, in favour of suppressing the
display of copy counts when there's nothing to display.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

Fix NULL interval for action_trigger.event_definition.delay

The delay column in action_trigger.event_definition is defined as NOT
NULL, therefore we should not try to push a NULL into it as that makes
PostgreSQL unhappy.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Fix seed data script syntax errors

Commas were missing at the end of some lines. Fix that so that the
database can be created relatively cleanly again.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Template processor always falls back to en_us

When no locales are registered and/or when a given locale is missing
a translation, fall back to en_us as the default locale.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

lp965651: add missing commas

Patch by Jason Stephenson, Comma Hunter

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

lp965637: add missing comma to fix syntax error

Patch from Jason Stephenson

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Add patron prefix upgrade to the version upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping patron prefix upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add a prefix field to patron registration interface

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

version fix for 0692/0693

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add ISSN fix to the version upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for ISSN normalization fix

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP932540: Fix ISSN indexing

The default config.metabib_field_index_norm_map contains a 'replace'
entry for the ISSN identifier field that replaces spaces with "". That
was meant to handle ISSNs that incorrectly contain a space instead of a
hyphen; it normalizes them from: "1234 1234" to "12341234".

However, that breaks indexing ISSNs if there are multiple ISSNs in the
record, or even if there is an extra character in the same subfield as
the primary ISSN, as all spaces are removed.

This commit removes the 'replace' entry for the ISSN identifier field
and reindexes potentially damaged ISSN index entries.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamped upgrade for 'allow fines during closings'

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Allow fines to accrue during closings

Evergreen skips fines during scheduled closings.  With this commit, a new
Org Unit Setting labeled 'Charge fines on overdue circulations when closed'
is available to force fines to accrue during closures.  Logic repiars and
out-of-scope (strict) variable repairs from Bill Erickson.

This work is sponsored by the NC Cardinal consortium in North Carolina.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Alt serials opac reloading cleanup

Removed a call to xulG.reload_opac() that was no longer wanted

More debuggable.  I think it might still be possbile to get to alt
serial control interfaces in contexts where they don't have
xulG.reload_opac(), but I can't think of any way to do it just now.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Alt serials reload opac after changes

Using the new onPostSubmit handler for AutoGrid.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

AutoGrid generic onPostSubmit handler

Called w/ no arguments after any CRUD actions occur.  This includes
EditPane / EditDialog actions as well as deleteSelected.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Followup fix to teaching AutoGrid to reload_opac()

For deleting a list of selected items, only reload_opac() once at the
end, not once for each item deleted.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Alt Serial Control interfaces and Batch Receive reload OPAC when possible

Really, since the Alt Serial Control interfaces are built on AutoGrid,
all we have to do there is teach AutoGrid (and its constituent EditPane)
to try for reload_opac on write operations.

This may cause more reloads of the OPAC than are truly necessary, but
mainly in cases when nobody's looking because the OPAC is hidden away
in another tab.  That's preferable to the alternative of littering the
codebase with dozens of instances of
    try { xulG.reload_opac(); } catch (E) { }
which would just be ugly, bad and unmaintainable.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>