working/Evergreen.git
3 years agoLP1952931 ASN shipment notifiation SQL
Bill Erickson [Wed, 1 Dec 2021 17:55:13 +0000 (12:55 -0500)]
LP1952931 ASN shipment notifiation SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1952931 Parsing DESADV EDI Messages
Bill Erickson [Wed, 1 Dec 2021 17:01:59 +0000 (12:01 -0500)]
LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP1952931 Parsing DESADV EDI Messages
Bill Erickson [Wed, 1 Dec 2021 16:49:23 +0000 (11:49 -0500)]
LP1952931 Parsing DESADV EDI Messages

Signed-off-by: Bill Erickson <berickxx@gmail.com>
3 years agoLP#1942220: add confirmation step to deleting LIs
Galen Charlton [Tue, 7 Dec 2021 19:25:42 +0000 (14:25 -0500)]
LP#1942220: add confirmation step to deleting LIs

- also tidy up when the action is avaialble
- also tidy up handling of selected LIs post-deletion
- also reload the page only once
- add TODO about decreasing parallelism
- TODO: toss up spinner?

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: teach LI title sort to ignore common articles
Galen Charlton [Tue, 7 Dec 2021 17:41:18 +0000 (12:41 -0500)]
LP#1942220: teach LI title sort to ignore common articles

Also move a couple convenience methods related to LI sorting
to LineitemService

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: bump up hardcoded LI retrieval limit back to 10000
Galen Charlton [Tue, 7 Dec 2021 17:08:13 +0000 (12:08 -0500)]
LP#1942220: bump up hardcoded LI retrieval limit back to 10000

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: extend the active LI sort order to PO printing
Galen Charlton [Tue, 7 Dec 2021 16:56:25 +0000 (11:56 -0500)]
LP#1942220: extend the active LI sort order to PO printing

Note that this reimplements the sorting client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: wording tweaks
Galen Charlton [Tue, 30 Nov 2021 22:40:02 +0000 (17:40 -0500)]
LP#1942220: wording tweaks

- "Copy Location" => "Shelving Location"
- "Zero-Copy" => "Zero-Item"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: improvements to cancel dialog
Galen Charlton [Tue, 30 Nov 2021 22:36:26 +0000 (17:36 -0500)]
LP#1942220: improvements to cancel dialog

- add recordType parameter so that wording can be adjusted
  based on what is to be cancelled
- expand the wording to make it (hopefully) crystal clear
  what to do
- show all cancel reasons upon combobox click

TODO: pluralization for the more-than-one-LI case

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: tweak LI actions around viewing/updating items
Galen Charlton [Tue, 30 Nov 2021 16:54:42 +0000 (11:54 -0500)]
LP#1942220: tweak LI actions around viewing/updating items

- Added "Update Barcodes" as a new LI action that opens the
  item attributes editor
- Changed the "Holdings Maintenance" LI action to open the
  record holdings view page rather than spawning the item
  attributes editor, making it match the behavior of the
  "Holdings Maint." LI action in the Dojo interface.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: point to new PO interface if creating a PO
Galen Charlton [Tue, 30 Nov 2021 16:18:12 +0000 (11:18 -0500)]
LP#1929749: point to new PO interface if creating a PO

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: fix lint
Galen Charlton [Tue, 30 Nov 2021 14:59:23 +0000 (09:59 -0500)]
LP#1929749: fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929749 Finetuning LMOR based on LP comments
Tiffany Little [Mon, 20 Sep 2021 14:58:29 +0000 (10:58 -0400)]
LP1929749 Finetuning LMOR based on LP comments

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: Adds support for picking up library settings.
Tiffany Little [Thu, 3 Jun 2021 11:45:33 +0000 (07:45 -0400)]
LP#1929749: Adds support for picking up library settings.

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929749 ACQ Load MARC Order Records port
Tiffany Little [Fri, 28 May 2021 15:29:53 +0000 (11:29 -0400)]
LP1929749 ACQ Load MARC Order Records port

[Note that this includes some work by Galen Charlton to reconcile
 the picklist module with work done by Bill Erickson for LP#1929741]

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: link to the Angular PO interface acq search results
Galen Charlton [Tue, 30 Nov 2021 14:35:00 +0000 (09:35 -0500)]
LP#1942220: link to the Angular PO interface acq search results

Note that this does /not/ follow the setting to display
links to the "experimental" Angular acquisitions interfaces; my
intention is to replace that with a different setting that,
when enabled, provides links to the Dojo interfaces from the
corresponding Angular interfaces.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: start adding filtering to the LI table
Galen Charlton [Mon, 29 Nov 2021 23:18:21 +0000 (18:18 -0500)]
LP#1942220: start adding filtering to the LI table

TODO:

- publication date age filter
- filereader for 'terms from file'
- claim count and item count filters

Note that this is following the acquisitions search form, not the grid
filters

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1357037: seed data - WS for LI sort order
Galen Charlton [Mon, 29 Nov 2021 21:06:18 +0000 (16:06 -0500)]
LP#1357037: seed data - WS for LI sort order

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1357037: add sorting option to Angular line item lists
Galen Charlton [Mon, 29 Nov 2021 21:04:16 +0000 (16:04 -0500)]
LP#1357037: add sorting option to Angular line item lists

This applies to the line item lists in the following new
Angular interfaces:

- purchase order
- selection list
- list of line items related to a bib record

The available sort options are:

- line item ID
- title
- author
- publisher
- order identifier (i.e., ISBN, ISSN, and/or UPC)

The method open-ils.acq.lineitem.unified_search is now used to retrieve
line items to make use of existing sorting functionality.

The last sort order used is persistant via a workstation setting

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929741: repair adding brief record from PL page
Galen Charlton [Mon, 29 Nov 2021 21:00:36 +0000 (16:00 -0500)]
LP#1929741: repair adding brief record from PL page

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement 'Create Invoice from Selected Lineitems' action
Galen Charlton [Mon, 29 Nov 2021 16:31:54 +0000 (11:31 -0500)]
LP#1942220: implement 'Create Invoice from Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: hook up claim policies
Galen Charlton [Mon, 29 Nov 2021 16:11:02 +0000 (11:11 -0500)]
LP#1942220: hook up claim policies

- Display claim policy (if set) in the LI table
- Add the 'Apply Claim Policy to Selected Lineitems' action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741: bump up ID for new config.print_template inserts
Galen Charlton [Mon, 29 Nov 2021 15:03:17 +0000 (10:03 -0500)]
LP1929741: bump up ID for new config.print_template inserts

Resolving a logical merge conflict.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Brief record for PO repair
Bill Erickson [Mon, 26 Jul 2021 15:01:24 +0000 (11:01 -0400)]
LP1929741 Brief record for PO repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Standalone brief record UI
Bill Erickson [Wed, 30 Jun 2021 20:36:20 +0000 (16:36 -0400)]
LP1929741 Standalone brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLPLP1929741 Optional experimental Acq; seed data
Bill Erickson [Wed, 14 Jul 2021 14:52:44 +0000 (10:52 -0400)]
LPLP1929741 Optional experimental Acq; seed data

Adds and org setting and a workstation setting to 1) enable display of
experimental Angular ACQ UI's and 2) enable display of links to the
experimental UI's from search results.

Display a new menu entry "Acquisitions (Experimental)" when the org
setting is enabled.  This menu contains "Create Purchase Order" only for
now.

Copy seed data from upgrade file to seed data file.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Welcome page navigates to staff w/ href
Bill Erickson [Thu, 24 Jun 2021 15:30:24 +0000 (11:30 -0400)]
LP1929741 Welcome page navigates to staff w/ href

When a route failure occurs, etc. and the user is sent back to the
Welcom to Webby page, make the link to the staff page an href instead of
a routerLink, so Angular is forced to load new route data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Change Op displays failed permission
Bill Erickson [Thu, 24 Jun 2021 15:29:54 +0000 (11:29 -0400)]
LP1929741 Change Op displays failed permission

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 cleanup more PO subs
Bill Erickson [Tue, 22 Jun 2021 20:31:10 +0000 (16:31 -0400)]
LP1929741 cleanup more PO subs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Clear previous PO on new PO create
Bill Erickson [Tue, 22 Jun 2021 20:18:18 +0000 (16:18 -0400)]
LP1929741 Clear previous PO on new PO create

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 cleanup PO subscription; improve charges display
Bill Erickson [Tue, 22 Jun 2021 20:02:40 +0000 (16:02 -0400)]
LP1929741 cleanup PO subscription; improve charges display

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Fund limit/sort on new charges
Bill Erickson [Tue, 22 Jun 2021 19:44:08 +0000 (15:44 -0400)]
LP1929741 Fund limit/sort on new charges

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ng lint
Bill Erickson [Tue, 22 Jun 2021 19:39:57 +0000 (15:39 -0400)]
LP1929741 ng lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1928258 Combobox sanity checks
Bill Erickson [Mon, 14 Jun 2021 19:55:29 +0000 (15:55 -0400)]
LP1928258 Combobox sanity checks

Avoid failures caused by calling toLowerCase() on a number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Item location select starts with; hide Unset
Bill Erickson [Tue, 22 Jun 2021 18:47:44 +0000 (14:47 -0400)]
LP1929741 Item location select starts with; hide Unset

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox supports startsWith search (p2)
Bill Erickson [Tue, 22 Jun 2021 18:46:51 +0000 (14:46 -0400)]
LP1929741 Combobox supports startsWith search (p2)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Blanket order finalizing; improved charges handling
Bill Erickson [Tue, 22 Jun 2021 18:06:00 +0000 (14:06 -0400)]
LP1929741 Blanket order finalizing; improved charges handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Sort funds by year desc, then code
Bill Erickson [Tue, 22 Jun 2021 16:19:44 +0000 (12:19 -0400)]
LP1929741 Sort funds by year desc, then code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Batch of PO fixes
Bill Erickson [Tue, 22 Jun 2021 15:43:05 +0000 (11:43 -0400)]
LP1929741 Batch of PO fixes

* Avoid clearing the owning library during batch edit copy operations
* Leverage combobox startsWith for distribution formulas
* Disable the order ident selector so it cannot be modified after a PO
  is activated
* Add some icons to the PO actions for more eye-grabbiness.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox supports startsWith search
Bill Erickson [Tue, 22 Jun 2021 15:42:00 +0000 (11:42 -0400)]
LP1929741 Combobox supports startsWith search

In lieu of the default behavor of the typeahead, which does a 'contains'
search.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ order ident indicate multiples
Bill Erickson [Mon, 14 Jun 2021 21:43:15 +0000 (17:43 -0400)]
LP1929741 ACQ order ident indicate multiples

When multiple order identifer values (e.g. ISBN's) exist on a lineitem,
the number of options is now displayed just to the left of the
identifier selector.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Apply default lineitem order identifers
Bill Erickson [Mon, 14 Jun 2021 21:35:21 +0000 (17:35 -0400)]
LP1929741 Apply default lineitem order identifers

Apply a default order identifier to lineitems instead of leaving the
selector blank.  Ensure the value that will display in the selector
matches what's in the database by setting the value on load when needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Bundle of ACQ bug fixes
Bill Erickson [Fri, 11 Jun 2021 15:29:47 +0000 (11:29 -0400)]
LP1929741 Bundle of ACQ bug fixes

* Distribution formula combobox now displays entries on click
* Ditto Charge Type combobox
* Items now vanish when deleted
* Estimated amount, etc. update when items are added/deleted
* Lineitem action links match order of previous interface.
* PO dry run checks now fire after a brief record is added
* PO activation is blocked if an item has no owning lib.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Delete action trumps ischanged for LID's
Bill Erickson [Fri, 11 Jun 2021 14:28:06 +0000 (10:28 -0400)]
LP1929741 Delete action trumps ischanged for LID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Cache LI after order ident change
Bill Erickson [Wed, 9 Jun 2021 15:16:08 +0000 (11:16 -0400)]
LP1929741 Cache LI after order ident change

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Lineitem delete repairs
Bill Erickson [Mon, 3 May 2021 15:28:09 +0000 (11:28 -0400)]
LP1929741 Lineitem delete repairs

Allow deleting lineitems on PO's for certaian states.

Fix lineitem delete code issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 View/Place orders sorts newest to oldest
Bill Erickson [Tue, 20 Apr 2021 15:15:36 +0000 (11:15 -0400)]
LP1929741 View/Place orders sorts newest to oldest

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Limit to active providers; skip empty name picklist
Bill Erickson [Thu, 8 Apr 2021 14:30:56 +0000 (10:30 -0400)]
LP1929741 Limit to active providers; skip empty name picklist

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 AnJS nav create po goes to new UI
Bill Erickson [Fri, 26 Feb 2021 16:11:19 +0000 (11:11 -0500)]
LP1929741 AnJS nav create po goes to new UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Improve catalog service sanity check
Bill Erickson [Tue, 27 Apr 2021 14:32:05 +0000 (10:32 -0400)]
LP1929741 Improve catalog service sanity check

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Repair 'Create Invoice' link
Bill Erickson [Tue, 2 Feb 2021 18:41:47 +0000 (13:41 -0500)]
LP1929741 Repair 'Create Invoice' link

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Zero-copy and no-assets PO activation
Bill Erickson [Mon, 1 Feb 2021 22:29:26 +0000 (17:29 -0500)]
LP1929741 Zero-copy and no-assets PO activation

And summary layout improvements.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Ensure PO items always display when present
Bill Erickson [Mon, 1 Feb 2021 21:16:07 +0000 (16:16 -0500)]
LP1929741 Ensure PO items always display when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 View/Place Orders UI
Bill Erickson [Tue, 26 Jan 2021 18:26:35 +0000 (13:26 -0500)]
LP1929741 View/Place Orders UI

View/Place orders from a bib record and add/create selection lists or
PO's from the record.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Display copy row number in copy edit grid
Bill Erickson [Wed, 20 Jan 2021 22:02:38 +0000 (17:02 -0500)]
LP1929741 Display copy row number in copy edit grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ caching / batch editing improvements
Bill Erickson [Wed, 20 Jan 2021 20:49:55 +0000 (15:49 -0500)]
LP1929741 ACQ caching / batch editing improvements

Ensure that funds/mods/locations of modified copies are available at
render time after saving changes to copies.

Hide the copy batch update bar when no copies are editable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox additional sanity checks on async/IDL values
Bill Erickson [Wed, 20 Jan 2021 20:47:03 +0000 (15:47 -0500)]
LP1929741 Combobox additional sanity checks on async/IDL values

1. Avoid PCRUD queries where the selected id value is set to null.
2. Avoid attempts to add null entries to the async entry cache.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Sanity check distrib. formula values
Bill Erickson [Wed, 20 Jan 2021 19:14:36 +0000 (14:14 -0500)]
LP1929741 Sanity check distrib. formula values

No fields within a distribution formula are required, so confirm a set
of values exists before calling Object.keys() on an undefined value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Angular Selection List / Po Seed Data
Bill Erickson [Fri, 15 Jan 2021 15:33:55 +0000 (10:33 -0500)]
LP1929741 Angular Selection List / Po Seed Data

PO and lineitem worksheet print templates.

Workstation preferences for grids and lineitem list page size.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 ACQ Selection List & PO Angluar Port
Bill Erickson [Thu, 8 Oct 2020 22:22:12 +0000 (18:22 -0400)]
LP1929741 ACQ Selection List & PO Angluar Port

New selection list UI
New PO UI
New Lineitem worksheet UI with stub print template
New PO print UI with stub print template
New brief record UI

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox idl auto query filter addition
Bill Erickson [Fri, 4 Dec 2020 20:39:33 +0000 (15:39 -0500)]
LP1929741 Combobox idl auto query filter addition

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Combobox asyncSupportsEmptyTermClick fix
Bill Erickson [Fri, 4 Dec 2020 16:17:51 +0000 (11:17 -0500)]
LP1929741 Combobox asyncSupportsEmptyTermClick fix

Fixes situation where combobox would fetch the needed entries in async
mode, but fail to open the drop-down after a click.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP1929741 Net service tidier request logging
Bill Erickson [Wed, 30 Dec 2020 16:43:50 +0000 (11:43 -0500)]
LP1929741 Net service tidier request logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoRevising 'Using the Public Access Catalog' page
gmontimantis [Wed, 26 Jan 2022 17:20:40 +0000 (12:20 -0500)]
Revising 'Using the Public Access Catalog' page

Updating screenshots and information in this doc to match Bootstrap.  Some areas need updating still.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP#1955931 Staff catalog show more details - add due date
Dan Briem [Thu, 30 Dec 2021 14:51:34 +0000 (09:51 -0500)]
LP#1955931 Staff catalog show more details - add due date

Adds a due date column to the show more details view in
the Angular staff catalog.

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoUpdate Test for LP1722827 After LP1482757
Jason Boyer [Tue, 1 Mar 2022 12:55:16 +0000 (07:55 -0500)]
Update Test for LP1722827 After LP1482757

The 4th part of the old test is incorrect as not deleting these is
the point of 1482757. Test has been updated to reflect that.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP#1482757: stamp upgrade script
Michele Morgan [Fri, 25 Feb 2022 20:48:01 +0000 (15:48 -0500)]
LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: stamp upgrade script
Michele Morgan [Fri, 25 Feb 2022 20:17:29 +0000 (15:17 -0500)]
LP#1482757: stamp upgrade script

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: Speed Up the Delete of Orphaned URIs in upgrade script
Jason Stephenson [Thu, 24 Sep 2020 16:31:23 +0000 (12:31 -0400)]
LP#1482757: Speed Up the Delete of Orphaned URIs in upgrade script

Modify the code that deletes orphaned asset.uri table entries in the
upgrade script to use IN logic on the subquery, because IN is much
faster than NOT IN.  Also take into account the link between
serial.item and asset.uri so that we don't accidentally delete URIs
used by serial items.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: Delete URIs and call numbers when all 856 fields are removed
Michele Morgan [Wed, 29 Jul 2020 20:40:06 +0000 (16:40 -0400)]
LP#1482757: Delete URIs and call numbers when all 856 fields are removed

This patch assures that URIs and call numbers are deleted as appropriate
when all 856 fields are removed from the MARC.

Also provides for tracking editor and edit_date when call numbers are
deleted.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: Amend upgrade script to remove existing orphaned URIs
Michele Morgan [Fri, 24 Apr 2020 17:03:23 +0000 (13:03 -0400)]
LP#1482757: Amend upgrade script to remove existing orphaned URIs

Remove orphaned URIs from the database that have accumulated from past
additions, updates and deletions of records with located URIs.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: Remove 'orphaned_uri_list' and 'NOT cn.deleted' criteria
Michele Morgan [Fri, 24 Apr 2020 16:43:39 +0000 (12:43 -0400)]
LP#1482757: Remove 'orphaned_uri_list' and 'NOT cn.deleted' criteria

Per Dan Wells' suggestions.

1) One possible "crack" I see for data to fall through is the dead map
selector. The "AND cn.label = '##URI##' AND NOT cn.deleted" seems overly
restrictive. Now, I realize we *shouldn't* have mappings to deleted or
non-##URI## call numbers, but it isn't impossible, and I don't think we'd
have harm in leaving those restrictions out. If a map isn't used, let's
get rid of it regardless, I think.

2) (side note) orphaned_uri_list doesn't seems to be used any more, so
should be removed.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: Be sure to remove all orphaned URI
Mike Rylander [Fri, 19 May 2017 19:33:03 +0000 (15:33 -0400)]
LP#1482757: Be sure to remove all orphaned URI

As reported by Michele Morgan, URIs can be orphaned in some cases, such
as when a location drops one of several 856 entries.  This commit tracks
objects at the mapping level, to identify disused URIs even where the
call number level is not changed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1482757: More careful Located URI remapping
Mike Rylander [Fri, 5 Aug 2016 12:56:05 +0000 (08:56 -0400)]
LP#1482757: More careful Located URI remapping

Instead of recreating all Located URI mappings, we will add any new
ones and remember all those (existing and new) that are in use. Any
existing maps that we don't see in this record, and whose URI is only
used once previously and therefore about to be orphaned, we remove.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoUpdate to Batch Search page
gmontimantis [Thu, 17 Feb 2022 14:55:10 +0000 (09:55 -0500)]
Update to Batch Search page

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoAvoid fleshing standing penalty org unit children
Jeff Godin [Fri, 28 Jan 2022 22:54:38 +0000 (17:54 -0500)]
Avoid fleshing standing penalty org unit children

When fleshing the org unit on standing penalties, exclude child org
units. We don't need them, and they can cause issues when your
standing penalty has a Depth of "Everywhere": you end up with a full
copy of the org unit tree, and you will include this when editing
and saving the user.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
3 years agoLP1927990 Bootstrap OPAC: Patron messages lose line breaks
Terran McCanna [Mon, 21 Jun 2021 16:55:57 +0000 (12:55 -0400)]
LP1927990 Bootstrap OPAC: Patron messages lose line breaks

Fixes problem where messages added to the Patron Message Center
lose their line breaks in the Bootstrap OPAC and makes them
difficult to read.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP#1949389: reduce number of PCRUD requests by subscription manager
Galen Charlton [Mon, 1 Nov 2021 16:36:31 +0000 (12:36 -0400)]
LP#1949389: reduce number of PCRUD requests by subscription manager

This patch changes how the AngularJS subscription manager fetches
serial item templates. In particular, rather than issuing a PCRUD
request for every org unit in the system, it fetches them in one
fell swoop. This fixes an issue where loading the subscription manager
in a large Evergreen consortium could lead to so many requests that
it drives PCRUD into backlog mode, resulting in higher request
latency across the board.

To test
-------
[1] Apply the patch.
[2] Verify that the subscription manager lets you set the receiving
    template for each distribution and that the drop-down's contents
    changes if the distribution library is changed.
[3] Verify that the Apply Binding Template action works and that
    the binding template drop-down(s) include the relevant copy templates.

Note that if a binding template has been set already, the current
binding template is _not_ displayed as the selected value in the drop-down.
This is existing behavior that this patch does not aim to fix.

Sponsored-by: BC Libraries Cooperative
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
3 years agoLP#1946019: copyloc.js change to clear locations on new branch select.
Steven Callender [Mon, 4 Oct 2021 17:20:56 +0000 (13:20 -0400)]
LP#1946019: copyloc.js change to clear locations on new branch select.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1955927_Barcode_search_fails_in_patron_search_modal
Garry Collum [Wed, 29 Dec 2021 19:29:41 +0000 (14:29 -0500)]
LP1955927_Barcode_search_fails_in_patron_search_modal

Fixes the barcode search in the patron search modal in the holds screen.

To test:
1. Navigate to the 'place a hold' screen in a bib record and open
the patron search modal.
2. Enter a patron barcode.
3. The search for the patron fails.
4. Apply the patch and repeat.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
3 years agoLP1957840 Typo fix in mcrp class in fm_IDL.xml
Terran McCanna [Thu, 13 Jan 2022 22:10:32 +0000 (17:10 -0500)]
LP1957840 Typo fix in mcrp class in fm_IDL.xml

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
3 years agoLP1947595: stamp upgrade script
Jane Sandberg [Fri, 11 Feb 2022 03:30:06 +0000 (19:30 -0800)]
LP1947595: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLp 1947595: Remove the array_accum aggregate function
Jason Stephenson [Wed, 20 Oct 2021 16:38:46 +0000 (12:38 -0400)]
Lp 1947595: Remove the array_accum aggregate function

Remove the array_accum aggregate from Evergreen because it will need
to be dropped and redefined when upgrading to PostgreSQL 14.

Replace any uses of array_accum with array_agg in the code.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP#1951021: account for change in OverDrive checkout response
Galen Charlton [Fri, 7 Jan 2022 23:50:04 +0000 (18:50 -0500)]
LP#1951021: account for change in OverDrive checkout response

The OverDrive circulation API soon will stop providing a direct
download link in favor of displaying a separate fulfillment page
(either as an iframe or a redirect). This patch implements this
change with the redirect option.

Additional information on the API change can be found at

http://developer.overdrive.com/overdrive-api-notices/01-sep-2021-coming-soon-changes-to-overdrive-checkouts-api

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Garry Collum <gcollum@gmail.com>
3 years agoAdding videos from Conferences
Lynn Floyd [Mon, 6 Sep 2021 16:13:13 +0000 (12:13 -0400)]
Adding videos from Conferences

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Updating Opac Lists doc
gmontimantis [Wed, 2 Feb 2022 16:54:44 +0000 (11:54 -0500)]
Docs: Updating Opac Lists doc

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 (follow-up): don't use commonjs in spec tsconfig
Jane Sandberg [Tue, 25 Jan 2022 20:37:10 +0000 (12:37 -0800)]
LP1948035 (follow-up): don't use commonjs in spec tsconfig

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 Angular 12 updates
Bill Erickson [Thu, 21 Oct 2021 15:54:13 +0000 (11:54 -0400)]
LP1948035 Angular 12 updates

Run ng upgrade from 10 -> 11 -> 12.

Updates package.json deps for Angular 12.

Removes deprecated angular/http dependency

Fix a couple of cases where Promise<any> now requires resolve(something)
instead of resolve() (which would be Promise<void>).

Fix some CSS syntax issues.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1948035 Update Node/Angular Deps for Ang 12
Bill Erickson [Thu, 21 Oct 2021 15:03:13 +0000 (11:03 -0400)]
LP1948035 Update Node/Angular Deps for Ang 12

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: use asciidoc ordered list rather than adding numbers manually
Jane Sandberg [Tue, 25 Jan 2022 17:50:47 +0000 (09:50 -0800)]
Docs: use asciidoc ordered list rather than adding numbers manually

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: updating z39.50 overlay doc and images
gmontimantis [Wed, 10 Nov 2021 19:37:40 +0000 (14:37 -0500)]
Docs: updating z39.50 overlay doc and images

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update barcode_completion_grid.jpg
gmontimantis [Mon, 24 Jan 2022 19:04:16 +0000 (14:04 -0500)]
Docs: Update barcode_completion_grid.jpg

Updated barcode grid screenshot; other one was too blurry

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update basic_holds.adoc
gmontimantis [Fri, 30 Jul 2021 14:15:46 +0000 (10:15 -0400)]
Docs: Update basic_holds.adoc

removing Print full pull list alternative reference

https://bugs.launchpad.net/evergreen/+bug/1775402
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: Update basic_holds.adoc to include updated screenshot
gmontimantis [Fri, 30 Jul 2021 14:14:01 +0000 (10:14 -0400)]
Docs: Update basic_holds.adoc to include updated screenshot

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoDocs: add a chapter about the course materials module
Jane Sandberg [Fri, 14 Jan 2022 23:58:02 +0000 (15:58 -0800)]
Docs: add a chapter about the course materials module

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLP1903476 Followup; Remove perl action, limit to docs/
Jason Boyer [Wed, 12 Jan 2022 12:17:19 +0000 (07:17 -0500)]
LP1903476 Followup; Remove perl action, limit to docs/

Since the 'ubuntu-latest' image includes perl 5.30 the
actions-setup-perl step just adds more time to the process.

GitHub Actions can be limited to (or exclude) paths so now
docs will only be built when pushes or PRs happen under docs/.

Also added a couple name tags for the interface.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP1903476: Use Github Actions to build antora documentation
Jane Sandberg [Wed, 27 Oct 2021 17:16:30 +0000 (10:16 -0700)]
LP1903476: Use Github Actions to build antora documentation

This allows documenters to submit a pull request and get a
preview version where they can view their changes.  The goal
is to provide quick feedback to documenters on whether their
changes build correctly and appear as desired, without them
having to have a full docs building setup locally.

To test:
1. Use the Github Web site to fork the Evergreen repository.
2. Take the .github/workflows/docs.yml file from this commit.
Add it to any branch of your fork of the Evergreen repository.
3. Click on the Actions tab of your fork in the Github Web
site.
4. Click on the most recent run (at the top of the list).
5. When the build process is done (should take 3-4 minutes),
download and unzip the artifact that appears at the bottom of
the screen.  Open index.html in your browser.  Confirm that
the docs built properly.
6. On the same branch, make some changes to the documentation
in the docs/modules directory.
7. Repeat steps 3-5.  Confirm that your changes are reflected
in the new artifact.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
3 years agoLP 1942645: stamp upgrade script
Jane Sandberg [Tue, 14 Dec 2021 21:02:15 +0000 (13:02 -0800)]
LP 1942645: stamp upgrade script

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agolp-1942645 term name uniqueness
malexander [Wed, 8 Dec 2021 19:12:23 +0000 (19:12 +0000)]
lp-1942645 term name uniqueness

dropped name uniqueness between orgs, added constraint to owning lib and name

Includes syntax corrections from Martha Driscoll -- thank you, Martha!

Signed-off-by: malexander <malexander@catalyte.io>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
3 years agoLp 1862652: pingest.pl reingest record attributes fix
Jason Stephenson [Mon, 10 Feb 2020 16:09:37 +0000 (11:09 -0500)]
Lp 1862652: pingest.pl reingest record attributes fix

Use the rdeleted parameter when reingesting record attributes in
pingest.pl support script so that passing argument values to the
--attr option makes sense.

Prior to this patch, arguments of the --attr option would be ignored,
and all record attribute fields were reingested for all records,
deleted and not deleted alike.

With this patch, the arguments of the --attr option are respected for
not deleted records.  Deleted records still have all attributes
reingested.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>