forward-port version upgrade scripts

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

fix title of the 3.10 release notes document

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.10.1 release notes - edited

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.9.2 release notes - edited

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update 3.8.3 release notes to include security fix information

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update 3.9.2 release notes to include security fix information

Also fixes a typo

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

update 3.10.1 release notes to include security fix

Also fixes a typo.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.10.1 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.9.2 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.8.3 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1361782: (follow-up) fix the default search limit in seed data

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1361782: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

DoS protection release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1361782: Add DoS protection

This commit adds two types of simple DoS protection:

 * Limit concurrent search requests per client IP address, regardless of
 the searches being performed.  This helps address issues of accidental
 spamming from a malfunctioning OPAC workstation, or crawlers of various
 types.  The limit is controlled by a global flag called
 "opac.max_concurrent_search.ip".

 * Limit the global concurrent search requests for the same query.  This
 helps address both simple and distributed DoS that send the same search
 request over and over.  The limit is controlled by a global flag called
 "opac.max_concurrent_search.query", and defaults to 20.

When the limit is exceeded in either case the client receives an HTTP
429 "Too many requests" response from the web server, and the connection
is ended.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

qtype CGI param protection release notes

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1811685: qtype CGI parameter checking

With this commit we throw away searches with invalid qtype value based
on configured classes and aliases.  Invalid qtype values have been seen
in the wild as part of attempted (but failed) SQL injection attacks, so
we will tighten up what we accept.

As an additional (unrelated) bonus, this commit also avoids prepending
the search class on basic search when the class (from qytpe) is not
exactly "keyword".

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP # 1965447: adjust scoping of item tags Angular Holdings Editor

Scopes to the org unit and ancestors of the signed-in
user's workstation when adding a new item tag.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2012105 - Comment typo in AddedContent.pm

Small tiny comment typo HTPP istead of HTTP

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#2002435 release note

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP2002435: Add optional undelete action to basic admin page

By default, this undelete action is only enabled on the shelving
location editor.

Also, only show admin page delete button if everything
selected is deleteable

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP2002435: Don't allow shelving location fm-editor to change delete flag

To test:
1. Go to the Local Admin > Shelving Locations Editor screen
2. Select a location and edit it.
3. Note that with this patch in place, the Delete checkbox
is no longer editable.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Docs: Update describing_your_organization.adoc

Updated the Create and edit Organization Unit Types section as well as the Organization Units sections to update text and add screenshots. Also added instructions for hours of operation notes (released in 3.10).

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

Updating best practices for web browser to include turning off Google Translate

For the DIG revamp project.  No LP.

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

Docs: removing XUL reference from web staff client intro page

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: LP1863921 max-old-space-size param when building angular

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Sync upgrade_log

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1441750: Stamp Upgrade Script

Also update unapi.mmr and actor.usr_merge to account for drift.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1441750: use string_agg (again and again)

Update the upgrade/fix for name keyword moving in the actor.usr_merge
function.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1441750: use string_agg (again)

Some older style ARRAY_TO_STRING(ARRAY_AGG()) should be replaced to
use the native STRING_AGG() that comes with PG 9+.  This should improve
performance for these functions.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1996908: Expand support for eg.auth.token to other legacy mod_perl handlers (but not the OPAC)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1996908: allow OpenILS::WWW::Proxy::Authen to check eg.auth.token

This patch allows the authentication handler to accept the
'eg.auth.token' cookie coming from the staff client if a 'ses' parameter
or 'ses' cookie has not been set. This allows resources gated by
this handler to be accessed by a staff member who has logged
into the staff client without requiring an additional login.

To test
-------
[1] Create a report and note the URL of one of its
    outputs.
[2] In a completely fresh browser session, log into the
    staff client, then directly load the reporter output.
    You will be prompted to log in again because the 'ses'
    cookie was not set.
[3] Apply the patch and repeat step 2. This time, the reporter
    output should be directly retrieved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1625192 Filtering Grid refreshes to 1st Page

Modify the old DOJO grid so that when you filter the grid it resets
to the first page.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP1998355: Stamp Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#1998355: reduce growth of DYM dictionary

This patch reduces the number of updates to search.sympell_dictionary
rows that would not change the contents of those rows, thereby
reducing the potential for certain record maintenance operations to
significantlly bloat that table.

In particular, it adjust the upsert to update the row for an existing
prefix only if there would be a net change in at least one of the *_count
columns or the list of suggestions. (Note that if a row is the target of
an UPDATE statement, PostgreSQL will _always_ create a row version, even
if there is no change to the contents of the row.)

It should be noted that while this patch is useful in and of itself, there
is a longer-term fix that would have additional benefits: adjust the
overall reingest logic so that it minimizes changes to all large tables
derived from the bib record when a bib gets reingested. A row that never
gets touched because it doesn't have to be can never become bloat.

To test
-------
[1] In a Concerto database, ensure that idempotent updates of the MARC
    in biblio.record_entry will nonetheless force a reingest by running:

    update config.internal_flag set enabled = true where name = 'ingest.reingest.force_on_same_marc';

[2] Note the size of search.symspell_dictionary by running:

    select pg_size_pretty(pg_total_relation_size('search.symspell_dictionary'));

[3] Run a few rounds of the following update that forces a reingest of the bibs:

    update biblio.record_entry set id = id;

[4] For the sake of fairness, run a vacuum on the table:

    VACUUM ANALYZE search.sympsell_dictionary

[5] Run the size measuremeant again and not that it's significantly larger.

[6] Run the following the reset the table size:

    VACUUM FULL search.symspell_dictionary;

[7] Note the size, apply the patch, and repeat step 3.

[8] This time, the table size should be the same (or close to the same) as it
    was at the beginning of step 7.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

LP#2007351: fix the MARC editor heading linker for certain fields

The headings linker in the Angular bib record editor could fail
to retrieve the relevant authority control field metadata to determine
what subfields in the bib record are controlled by a top-level authority
record (as opposed to a subdivision record). This patch fixes this
by adjusting the query for bib-to-authority linking relationships.

This manifiested by the headings linker not consistently bringing
up the headings browse when attemping to link headings in the bib
600, 600, 651, and 655 field.A

To test:

[1] Open a bib record in the Angular MARC editor and create a 650
    field.
[2] Click the button to open the headings linker. Note that no
    browse is performed. (This is not 100%, as the bug is sensitive
    to the exact order that the database happens to return rows
    from the authority.control_set_bib_field table.)
[3] Apply the patch and repeat step 2.
[4] This time, the browse list in the headings linker should show
    results.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Carol Witt <wittc@cwmars.org>

LP#1999401 release note

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1999401: Don't override magic statuses from holdings editor templates

1. Create a new template including a status
2. Check out an item
3. Apply your template to the item
4. Note that the item's status is no longer Checked Out
5. Apply this patch
6. Retry steps 1-3.  Note that the item's status is still Checked Out

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Elizabeth Davis <elizabeth.davis@sparkpa.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1999401: Don't apply magic statuses from holdings editor templates

1. Create a new template in the holdings template editor with a few
different values in various fields.
2. Include a "magic" status in your template (like Lost or In
Transit).  To select it, you can type the first few characters
then press <Tab>.
3. Save your template.
4. Apply your template to an item.
5. Note that the copy status has changed to a magic status.
6. Apply this patch.
7. Try applying your template to another item.
8. Note that the copy status field doesn't change this time,
but other fields from your template should still apply.

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP#1706664 - This adds Mark Item docs

Documentation for marking items of different status including Missing Pieces.

Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
signed-off-by: Debbie Luchenbill <deborah@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2002977 release note

Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2002977 Flip position of LI alert boxes

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1980142: adjust styling of patron message body in Bootstrap OPAC

This patch resolves an issue where the text of the message body
could be rendered very small due to default styles applied to the <pre>
element. In particular, it converts the <pre> to a <p> and restores
a TPAC-era style that ensures that

* long lines in the message wrap
* but line breaks are also preserved (see LP#1927990)

This patch also ensures that the message body is not displayed with
label but no contents if the body is empty.

To test
-------
[1] Create a public patron note that contains line breaks and
    long lines.
[2] Note that in the Bootstrap OPAC message view, the message
    displays with fixed-width text (that may use a smaller font
    than the rest of the page) and has a horizontal scrollbar
    (due to the long line).
[3] Apply the patch and look at the message again in the OPAC.
    This time, the long line should wrap, but line breaks are
    also preserved.

This patch includes a portion of a patch by Garry Collum.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Mary Llewelln <mllewell@biblio.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1989284 Input labels for Manage Authorities

Adds <label> tags for the search term and authority type field inputs in
Cataloging -> Manage Authorities.

To test, run axeDevTools on this screen. The two form label warnings
that previously appeared should now be gone.

LP1989284 Add ID for authority combobox

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1997098 Stamping DB Upgrade: PG 15

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1997098: Add Support for PostgreSQL 15

Add Makefile targets to install the PostgreSQL 15 server
prerequisites.

Make postgresql-client-15 the default client version.

Add full text search configuration for PostgreSQL 15.

Modify config.ccmm_once_per_paramset and config.chmm_once_per_paramset
indexes for the interval casting function change from immutable to
stable.

Add a database upgrade script for the above.

Update the server installation instruction (README) for PostgreSQL 15.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Lp 2008925: Patch Templates Adversely Affected by Lp 1992490

The patch for Lp 1992490 wrapped several text blocks in the l()
translation function.  At least two of these introduced syntax error
in Template Toolkit.  Some of the others could have been done
differntly to fit in better with the general idiom of how we use the
fuction in Evergreen.

This commit modifies those that stood out as the most egregious
examples.

An easy way to test this is to login to the OPAC on an unpatched
system and click to open "Messages."  You will get an Internal Server
Error.  After you apply this commit and install the affected
templates, you will not get an Internal Server Error.

The other modified templates do not seem to crash, but use the
translation funciton in idiosyncratic ways.  This commit attempts to
smooth those out.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1940662: Add a --pipe option to marc_export

Add a --pipe option to marc_export to force reading of record ids from
standard input when one or more of the --library, or --descendants
options are used.  This permits more flexibility when exporting
records with holdings for given libraries or subsets of a collection.

It is an error to specify the --all or --since and --pipe options in
the same command line.

Co-authored-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>

LP1814978 Keyboard support for bib record actions

Adds the ngbDropdownItem directive to dropdown menu items in the staff
catalog bib record actions: Serials, Mark For, and Other Actions. This
adds support for navigating the menus using the up/down arrows on the
keyboard.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP #1998494: Angular Holdings Editor: Cannot create empty call numbers

Returns support for adding empty call numbers when adding holdings.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Mary Llewelln <mllewell@biblio.org>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#2003707: add releases note entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2003707: Add an OpenSRF Core Config Param to autogen.sh

What it says on the tin, if you change the name or location of
opensrf_core.xml now you can still run autogen.sh.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1987910: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1987910: Correcting typo in opac.located_uri.act_as_copy

Includes revisions by Scott Angel.

Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Scott Angel <scottangel@mobiusconsortium.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1987908: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1987908: Fixing typo in seed data for history.money.age_with_circs

Created upgrade sql script to accompany Gina's original commit.

Signed-off-by: Scott Angel <scottangel@mobiusconsortium.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1987908: Fixing typo in seed data for history.money.age_with_circs

Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2007591 Allow Last-Copy Delete to Create Hold Notices

Fixes an issue where attempting to create A/T events for recently
canceled holds fails becuase the cancel_time on the hold is the
pre-insert value of "now" instead of a valid date string.

Resolve the issue by fetching the post-insert copy of the hold, so it has
all of the correct in-database values, before passing the hold to A/T
for processing.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1914625: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1914625: Add Emacs Mode to fm_IDL.xml

Adds the Emacs Local Variables block above the vim modeline at the
bottom of the file.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1991562 Accessible link and button colors in Angular staff interface

Several of the default colors in Bootstrap 4 do not meet WCAG Level AA
accessibility requirements when used for links (#007bff blue) or button
backgrounds with white text (blue/primary, #28a745 green/success, and

Additionally, while the yellow/warning color (#ffc107) does pass the
contrast check with black text, the button itself does not pass the
graphical object contrast check against white or #f7f7f7 page/tab
backgrounds, meaning people with some forms of color blindness can't see
the shape of the button.

This patch updates link and button colors using Bootstrap 5 tints
(https://getbootstrap.com/docs/5.0/customize/color/#all-colors). While
slightly lighter custom colors could be used to pass the contrast
checks, sticking to the Bootstrap 5 color scheme should make it easier
for us to stay consistent as new components are added in the future.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1980874 Limit depth dropdown in patron notes

Adds standard form control styling to the depth select menu in the
Patron > Create Note modal. This limits the width of the closed dropdown
to the width of the form and prevents long labels from overflowing.

This does not prevent the individual options from overflowing the
<select> width due to the limited CSS support for the <option> tag; all
width and text wrap properties are currently unsupported.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999410 Move LI loading progress bar

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1999268 PO Link to invoice should not retrieve closed invoices

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2002920: Angular acq batch updater now updates the circ modifier

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2002337 Pre-Fetch All Holds Checkbox Appears Twice

Removes duplicate Pre-Fetch All Holds checkbox from the Angular
View Holds page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1998969 Make disabled <option>s more obvious

Changes the color of disabled options in <select> dropdowns to 30% gray.

To test, visit the staff catalog. In the search filters, with the search
type set to keyword, notice that the "matches exactly" and "starts with"
options in the "Contains" dropdown are now better distinguished from
valid choices.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1999955 release note

LP1999955 AccessKeys info style updates

Adds styles to the keyboard shortcuts to make them look more like
keys. Also adds striping to each row and makes the headers bold.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1999270: add release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1999270: Bold the Paid indicator on line items

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1916403 Staff catalog search form labels

Provides label tags for staff catalog search form fields.

Most labels in the form are visible. I have used the sr-only class to
make labels available to screen reader users while hiding them from
sight on the publication date range fields, which I think are easy
enough to use without visible labels. However, this combination of year
and operator dropdowns is not well organized for screen reader users,
and we should rethink the order and wording of these fields.

To test, visit staff/catalog/search and inspect each form field. Verify
that each one has a <label> tag where the for attribute matches the ID
of the associated form element. (Checkboxes wrapped in the <label> tag
still need matching ID and for attributes for consistent ARIA support.)

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
fix

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2003947 Add LID count to Acq Search

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2004187 Opens acq provider link in new tab on PO

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2003742 Shelf browse in angular catalog uses deleted call numbers

Fixes the call number browse.  To determine the call number for which
the browse list displays, deleted call numbers are not removed from
the query.

To test in Concerto:
1. Go to a bib and click on the shelf browse tab. Notice where the list
begins.
2. Add a new item with a call number less thatn the starting point of
the browse list.  For example, if the list begins at 780, create
a call number at 100.
3. Refresh the browse screen and notice that the list now begins at
the lower call number.
4. Delete the item and call number that was created, the list still
begins at the lower call number.
5. Apply the patch.
6. The list should now begin at it's original call number.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#2007877: various fixes to Server Admin Print Templates page

This patch fixes a regression introduced by the switch to NgbNav
as well as a number of other issues.

To test
-------
[1] Open the Server Administration -> Print Templates page and select
    a print template. Observe that the template editor is not displayed
    and that there are errors in the browser console.
[2] Apply the patch and repeat step 1. This time, the template is
    displayed along with its previewed.
[3] Switch to the Sample Data tab, then select another template. Observe
    that the template is reloaded and the active tab switched to the template
    editor.
[4] Select a template such as "Checkin" that does not have stock
    sample data. Observe that the Preview and Compiled Content panes on
    the template editor tab are empty and that the Sample Data tab
    has an empty control

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1999282 (follow-up): fix css selector

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2006513 Angular login redirect repair

The routeTo parameter must contain an eg2-based path (/staff/splash)
and not a full path (/eg2/staff/splash) or URL.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1999274: Add Release Note

Add a one line release note to miscellaneous.adoc to indicate that a
search performance issue is resolved.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1999274: Improve Search Performance on Pg 12+

Use OFFSET as an optimization fence to keep newer PGs from trying to
fold the c_attr and b_attr CTEs into the main search query.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1999282 Less intense badges for staff interface

Flips the contrast on badges to make them less intense and comply with
color contrast requirements. In keeping with the less intense alert
styles, the badges have more subtle background colors. I have also
adjusted the spacing and font weight to make the characters larger
without greatly increasing the overall size of the badge.

All of these styles pass WCAG AAA contrast checks. In anticipation of
Bootstrap 5, I have included the new .text-bg-* classes alongside the
current ones.

The access key modal (Control-H) is a good place to observe the overall
effect.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1841871: Add a test for creating authority record from bib field

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2007880: fix open-ils.actor.ou_setting.ancestor_default

This patch fixes a regression introduced by bug 2006749 that
prevented open-ils.actor.ou_setting.ancestor_default from retrieving
the value of a library setting that does not have a view permission
associated with it. It also fixes a similar issue with
open-ils.actor.org_unit.settings.history.retrieve.

To test
-------
[1] Use srfsh to retrieve the value of a library setting
    that does not have a view permission. E.g.,

    request open-ils.actor open-ils.actor.ou_setting.ancestor_default 4, "circ.grace.extend"

    Note that an error is returned.

[2] Apply the patch and repeat step 1. This time, the value of
    the setting should be returned.
[3] Verify that viewing the edit history of a setting in the
    Library Settings admin page works as expected.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1999065: update eg-pbx-mediator.pl to reflect RPC::XML::Server change

RPC::XML::Server switched from add_proc to add_procedure in version 0.75.

This patch fixes the following error:

eg-pbx-mediator.pl will not run and returns an error:
Can't locate object method "add_proc" via package "RPC::XML::Server::new:

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999944: fix bug that can break drawing the folder tree for reports

Specifically, skip drawfolders iteration if parent node cannot be
found and eport invalid parent folder in the browser console.

For example, if a user creates a template folder that is not shared
that has a child folder that _is_ shared, another user at the library
that the folder is shared with would see their report folders be
incompletely rendered.

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1754455: Sanity checking and auto-strip 852s when using --items

If a user passes --strip / inform them that their request to output nothing
but empty records has been denied. Also auto-remove existing 852 fields when
using --items because only actual holdings data should be output in that case.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP 1754455: Update Release Notes for Latest Template

The four year old release notes used an out of date template.  This
commit changes two lines to bring them up to date with the latest
template.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1754455 Add Ability to remove fields or subfields in marc_export

This commit adds a --strip option to marc_export that allows fields
and/or subfields to be removed from MARC records on export.

To test: Try all forms of --strip:
    --strip <tag> e.g. --strip 856
    --strip <tag>/<sub>   e.g.  --strip 856/0
    --strip /<sub>   e.g. --strip /0

Try some regular expressions:
    --strip 8..
    --strip /[ab0]

For all tests, compare the regular output to the stripped otput and
the plain (unstripped) output.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2006749: Fix second call to ou_ancestor_setting_perm_check in AppUtils.pm

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2006749: Fix call to ou_ancestor_setting_perm_check in AppUtils.pm

The $self and $e arguments are missing when the ou_ancestor_setting
subroutine calls ou_ancestor_setting_perm_check in AppUtils.

The $coust argument also need to be $coust->view_perm->code for the
allowed check in ou_ancestor_setting_perm_check.

This commit corrects the call to ou_ancestor_setting_perm_check.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999432: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999432: (follow-up) expand "PubDate" abbreviation

The shelf browse interface has enough space, so this patch
changes the label to "Publication Date" for the sake of translations
and consistency with other places in the interface that use
the full label.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1999432 Add PubDate to shelf browse list.

Adds pubdate to the shelf browse list of the staff client.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1988321: Fix comparison problems to avoid incorrect error

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1999544 Also fixes fund dropdown in PO charges

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1999544_funddropdown Add owners limiter to fund dropdown

Adds a limiter of owners to the acqf idlquery for fund dropdown in line items

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1958258: (follow-up) tag new string for i18n

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1958258 Angular login form shows pending offline xacts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1969641 Show useful lack of staff working location message

When a user logs into the staff client that has STAFF_LOGIN permissions,
but no working locations, show a message to this affect instead of
resulting in a blank page.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: updating PO and SL documentation for 3.10

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: 3.10 updates to Load MARC Order Records

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>