evergreen/bjwebb.git
13 years agoprotect against null orig-location resulting in depth=-1 searches after logout
erickson [Mon, 20 Dec 2010 18:13:44 +0000 (18:13 +0000)]
protect against null orig-location resulting in depth=-1 searches after logout

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19028 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAcq: In fund propagation and rollover, add amounts as numbers, not strings
senator [Mon, 20 Dec 2010 17:37:40 +0000 (17:37 +0000)]
Acq: In fund propagation and rollover, add amounts as numbers, not strings

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19026 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosync naco_normalize versions
gmc [Mon, 20 Dec 2010 16:30:18 +0000 (16:30 +0000)]
sync naco_normalize versions

The copy in FTS.pm now matches the stored procedure, avoiding
a potential bug validating authorized headings that contain
diacritics.

Also added FIXME for the code-duplication.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@19025 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd an "Apply full authority" option to the MARC editor
dbs [Mon, 20 Dec 2010 04:38:35 +0000 (04:38 +0000)]
Add an "Apply full authority" option to the MARC editor

By definition, the only subfields that should be applied from an
authority record to a bibliographic record are the complete set
from the 1XX field of the authority record. So, rather than forcing
the user to select the correct subfields from the chosen authority
record, give them this handy shortcut to do the right thing.

Also, add copyright / licensing header - hopefully accurate.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19023 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoinitial openils python srfsh plugin; adds suport for 'login' (which behaves the same...
erickson [Mon, 20 Dec 2010 02:48:32 +0000 (02:48 +0000)]
initial openils python srfsh plugin; adds suport for 'login' (which behaves the same as srfsh.c), 'org_setting', and 'idl show class' commands, though the latter 2 are largely proofs of concept and are likely to evolve.  TODO: srfsh -> support command help docs during command insert

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19022 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadded a simple stringifierr for IDLClass and IDLField; capture 'class' in links
erickson [Mon, 20 Dec 2010 02:38:45 +0000 (02:38 +0000)]
added a simple stringifierr for IDLClass and IDLField; capture 'class' in links

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19021 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDisplay the tag and indicators for authority records in the merge box
dbs [Sat, 18 Dec 2010 06:25:00 +0000 (06:25 +0000)]
Display the tag and indicators for authority records in the merge box

Also, avoid the risk of creating or stomping on global variables by
using 'var' to declare our variables.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19017 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDisplay the tag of the displayed authority record in MARC Editor context
dbs [Sat, 18 Dec 2010 05:12:50 +0000 (05:12 +0000)]
Display the tag of the displayed authority record in MARC Editor context

We currently display both 1xx and 5xx fields in the authority record,
but do not display the tag. This can lead to some confusion when a 5xx
field is actually present. Ergo, show the tag to disambiguate the fields
in the authority browse selection interface.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19016 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoProvide starting context for authority browse in MARC Editor context menu
dbs [Sat, 18 Dec 2010 04:47:14 +0000 (04:47 +0000)]
Provide starting context for authority browse in MARC Editor context menu

Using the browse interface instead of startwith provides a first page
of results that shows some of the authority entries that precede the
first alphabetical match for the chosen term. Context is good.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19015 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAcq: Tracked down a small but subtle bug with the Holding Subfield tab of
senator [Fri, 17 Dec 2010 19:26:05 +0000 (19:26 +0000)]
Acq: Tracked down a small but subtle bug with the Holding Subfield tab of
the Provider editor interface.

We apparently have a global variable "name" defined somewhere which, when
assigned in place of an overrideWidget for an AutoGrid thanks to some vestigial
code, ultimately causes an error from within AutoFieldWidget, if you're using
the staff client.  That's because name is the string "browser_browser" in the
staff client, but if you access this interface from Firefox, name is apparently
set to some value that evaluates to false in a boolean context, because
AutoFieldWidget doesn't choke on it (the comparison at line 182 of that file
will return false).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19013 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agosome style for this clickable link in Check In
phasefx [Fri, 17 Dec 2010 18:21:11 +0000 (18:21 +0000)]
some style for this clickable link in Check In

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19012 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agouse just one close handler for menu.js; small tweak to support that, and some debug...
phasefx [Fri, 17 Dec 2010 16:41:45 +0000 (16:41 +0000)]
use just one close handler for menu.js; small tweak to support that, and some debug output

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19011 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoDo an equality test, instead of assigning a value
dbs [Fri, 17 Dec 2010 15:17:43 +0000 (15:17 +0000)]
Do an equality test, instead of assigning a value

Thanks to Bill Erickson for catching this; this fixes a bug where
SuperCat requests would end up returning authority records instead of
bibliographic records.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19009 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodump() is a mozilla thing; use console.log instead
erickson [Fri, 17 Dec 2010 15:12:28 +0000 (15:12 +0000)]
dump() is a mozilla thing;  use console.log instead

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19007 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: the circ_lib field on a copy template has no meaning in the only
senator [Thu, 16 Dec 2010 18:35:40 +0000 (18:35 +0000)]
Serials: the circ_lib field on a copy template has no meaning in the only
context where these copy templates are used, which is serials.  Any copy-like
objects that are created in serials have their circ_lib determined by
distribution.holding_lib

So remove the circ_lib from the interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19005 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAddress the call number browsing performance problem raised in LP 690242
dbs [Wed, 15 Dec 2010 20:22:21 +0000 (20:22 +0000)]
Address the call number browsing performance problem raised in LP 690242

The ORDER BY clause currently generated by call number browsing does not
have a sufficient index to use to assist the sorting of the returned rows,
and consequently does a sequential scan of the asset.call_number table.
Which, as you can imagine, is not fast for a system with more than a few
thousand call numbers.

This adds an index specifically to enable the query to go back to an
index scan instead of a sequential scan. We can investigate whether other
indexes should be removed to enable efficient data loading once we've
squashed the sequential scan problem.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19003 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoaugment the useragent for the xulrunner staff client
phasefx [Wed, 15 Dec 2010 20:11:59 +0000 (20:11 +0000)]
augment the useragent for the xulrunner staff client

git-svn-id: svn://svn.open-ils.org/ILS/trunk@19001 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoTwo bug fixes: 1) only allow one fine generator call per circulation during a given...
miker [Wed, 15 Dec 2010 17:11:24 +0000 (17:11 +0000)]
Two bug fixes: 1) only allow one fine generator call per circulation during a given transaction; 2) require that a circulation be open, based on the xact_finish field, in order to be the parent of a renewal (I suspect this used to depend on the open-circ view)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18999 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: simple bug in batch receive. Certain field values got treated
senator [Mon, 13 Dec 2010 21:41:37 +0000 (21:41 +0000)]
Serials: simple bug in batch receive. Certain field values got treated
like strings sometimes when they weren't. No more.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18997 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoregularize spelling of "fulfill"
gmc [Mon, 13 Dec 2010 18:20:43 +0000 (18:20 +0000)]
regularize spelling of "fulfill"

Based on patch by Steve Callender

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18995 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoboolean test for hard due force flag
phasefx [Mon, 13 Dec 2010 17:38:46 +0000 (17:38 +0000)]
boolean test for hard due force flag

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18989 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorepaired order-by in update_hard_due_dates function to prevent sql errors
erickson [Mon, 13 Dec 2010 16:14:08 +0000 (16:14 +0000)]
repaired order-by in update_hard_due_dates function to prevent sql errors

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18985 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from James Fournie to remove a confusing (though strictly correct) comment
miker [Fri, 10 Dec 2010 19:50:17 +0000 (19:50 +0000)]
Patch from James Fournie to remove a confusing (though strictly correct) comment

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18973 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch from James Fournie to address https://bugs.launchpad.net/evergreen/+bug/622908...
miker [Fri, 10 Dec 2010 17:22:47 +0000 (17:22 +0000)]
Patch from James Fournie to address https://bugs.launchpad.net/evergreen/+bug/622908 wherein we learn that related item physical description might be used as the main PD of the main item, if the main item lacks such a field in the MARC

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18969 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoProvide a mechanism to load any random JS file via dojo.require()-ish syntax.
miker [Fri, 10 Dec 2010 16:02:41 +0000 (16:02 +0000)]
Provide a mechanism to load any random JS file via dojo.require()-ish syntax.

Why would we want to do such a thing, you might ask?

Well, the short answer is that Firefox hates pages that have more than one script block (inline is worse than tag) that contains pre-onLoad XHR.  So, this allows us to pull the actual loading of JS from the same domain as the page into an inline block.  This allows us to eliminate the WSOD on FF by pulling all (dangerous) JS into a single, final inline block, after which we don't care if the DOMContentLoaded event fires -- that's when it should fire, structurally -- but in FF it may fire for a different reason (bug) than it should (fell of the end of the page in the rendering engine).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18964 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFix two bugs:
miker [Fri, 10 Dec 2010 05:03:25 +0000 (05:03 +0000)]
Fix two bugs:

 * Wide Character warning in authority.generate_overlay_template due to the generated template not being UTF-8 encoded internally
 * Correctly test the same space-normalization form of the pre- and post-strip records during the application of a replace rule in vandelay.replace_field

NOTE: to be backported to rel_2_0 and rel_1_6

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18957 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobig thinko. Going by the stock receipt template, this should be the workstation...
phasefx [Thu, 9 Dec 2010 18:25:50 +0000 (18:25 +0000)]
big thinko.  Going by the stock receipt template, this should be the workstation lib.  Destination is handled by a different variable

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18950 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotransit isn't in payload first time through with ROUTE_ITEM checkin, fallback on...
phasefx [Thu, 9 Dec 2010 18:12:46 +0000 (18:12 +0000)]
transit isn't in payload first time through with ROUTE_ITEM checkin, fallback on check.org

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18946 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agounsaved data warning for patron editor. some debug output for lock_tab/unlock_tab
phasefx [Thu, 9 Dec 2010 11:09:13 +0000 (11:09 +0000)]
unsaved data warning for patron editor.  some debug output for lock_tab/unlock_tab

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18945 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agounsaved data warning for MARC editor. some debug output for oils_lock_page()
phasefx [Thu, 9 Dec 2010 11:09:11 +0000 (11:09 +0000)]
unsaved data warning for MARC editor.  some debug output for oils_lock_page()

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18944 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomake sure forced closures of locked tabs and windows are correctly changing data...
phasefx [Thu, 9 Dec 2010 11:09:08 +0000 (11:09 +0000)]
make sure forced closures of locked tabs and windows are correctly changing data.unsaved_data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18943 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix copy/paste-o with decrement of unsaved_data semaphore and move functions from...
phasefx [Thu, 9 Dec 2010 11:09:06 +0000 (11:09 +0000)]
fix copy/paste-o with decrement of unsaved_data semaphore and move functions from menu.js to global_util.js.  tie unsaved_data into offline mode to speedbump closure via the login window

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18942 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoReturn authority records for freshmeat when authority records are requested
dbs [Thu, 9 Dec 2010 06:41:38 +0000 (06:41 +0000)]
Return authority records for freshmeat when authority records are requested

Previously, freshmeat was hardcoded to return bibliographic records, even
when authority records were requested.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18941 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoGive the recent_changes list the ability to sort authority records correctly
dbs [Thu, 9 Dec 2010 06:40:26 +0000 (06:40 +0000)]
Give the recent_changes list the ability to sort authority records correctly

We were always sorting by bibliographic record entry, which does not
work all that well for authority records.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18940 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSupport for predicting serials with no chronology caption
dbwells [Wed, 8 Dec 2010 19:59:24 +0000 (19:59 +0000)]
Support for predicting serials with no chronology caption

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18935 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd a simple subfields_list() method to MFHD/Caption.pm to match that in Holding.pm
dbwells [Wed, 8 Dec 2010 19:47:44 +0000 (19:47 +0000)]
Add a simple subfields_list() method to MFHD/Caption.pm to match that in Holding.pm

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18933 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: When the fully compressed serial holdings are active in the OPAC,
senator [Tue, 7 Dec 2010 22:42:03 +0000 (22:42 +0000)]
Serials: When the fully compressed serial holdings are active in the OPAC,
you get this "issues held" display with an expand/compress toggle that will
either show you individual holdings (and allow you to place holds on them)
or compressed holdings statements.

The functionality existed in trunk before this commit, but this cleans it up
and makes it better. It's more consistent with the the result detail table,
it doesn't offer you the change to place holds on issues that don't have
units (copy-equivalent objects), etc etc.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18931 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd unsaved data warning to offline interface. tweak oils_lock_page/oils_unlock_page...
phasefx [Tue, 7 Dec 2010 20:01:09 +0000 (20:01 +0000)]
add unsaved data warning to offline interface.  tweak oils_lock_page/oils_unlock_page to support multiple locks.  Hide Cancel buttons in offline interfaces, which weren't consistently implemented and had no warnings.  TODO: fix it so that closing the login window won't kill offline UI with unsaved data

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18930 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoWire up the Item Attribute Editor with oils_lock_page. Some tweaks needed to global_...
phasefx [Tue, 7 Dec 2010 16:58:24 +0000 (16:58 +0000)]
Wire up the Item Attribute Editor with oils_lock_page.  Some tweaks needed to global_util.js for util.widgets.dispatch('close',window) to work.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18929 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agooils_lock_page() and oils_unlock_page() for xul interfaces that wraps xulG.lock_tab...
phasefx [Tue, 7 Dec 2010 16:58:17 +0000 (16:58 +0000)]
oils_lock_page() and oils_unlock_page() for xul interfaces that wraps xulG.lock_tab/unlock_tab and works for both windowed and tabbed interfaces

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18928 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohave lock_tab cause warning prompts for logoff attempts and application shutdown
phasefx [Tue, 7 Dec 2010 16:58:14 +0000 (16:58 +0000)]
have lock_tab cause warning prompts for logoff attempts and application shutdown

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18927 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoconfirm window closure if tabs within the window are locked
phasefx [Tue, 7 Dec 2010 16:58:10 +0000 (16:58 +0000)]
confirm window closure if tabs within the window are locked

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18926 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotab lock infrastructure. call xulG.lock_tab() and then any attempt to close or repla...
phasefx [Tue, 7 Dec 2010 16:58:06 +0000 (16:58 +0000)]
tab lock infrastructure.  call xulG.lock_tab() and then any attempt to close or replace the tab will give staff a confirmation dialog.  multiple locks may be placed on a given tab, and an identical number of xulG.unlock_tab() invocations will unlock it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18925 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodescribe these variables for staff.circ_modifier.display
phasefx [Mon, 6 Dec 2010 21:16:42 +0000 (21:16 +0000)]
describe these variables for staff.circ_modifier.display

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18924 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorefresh cached user during auth session reset
erickson [Mon, 6 Dec 2010 20:56:14 +0000 (20:56 +0000)]
refresh cached user during auth session reset

Add a boolean (1/0) param to open-ils.auth.session.reset_timeout
that forces open-ils.auth to refresh the cached user object.  Useful if
a column on actor.usr was updated and the client may be pulling the
object from the cache w/ a page reload, etc.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18923 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobe sure skin dir has a js_common.xml file before we try to process it
erickson [Mon, 6 Dec 2010 20:20:48 +0000 (20:20 +0000)]
be sure skin dir has a js_common.xml file before we try to process it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18922 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMoving bits around and protecting against a pre-existing subject|complete index defin...
miker [Fri, 3 Dec 2010 21:35:39 +0000 (21:35 +0000)]
Moving bits around and protecting against a pre-existing subject|complete index definition that some sites have

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18920 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoThe "All Subjects" index never made it into 1.6, so we need it in the upgrade script
miker [Fri, 3 Dec 2010 21:15:32 +0000 (21:15 +0000)]
The "All Subjects" index never made it into 1.6, so we need it in the upgrade script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18919 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoprotect against empty control fields (bad MARC)
miker [Fri, 3 Dec 2010 20:51:46 +0000 (20:51 +0000)]
protect against empty control fields (bad MARC)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18915 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoBibTemplate: textContent()'s problem had already been fixed another way in
senator [Fri, 3 Dec 2010 19:49:44 +0000 (19:49 +0000)]
BibTemplate: textContent()'s problem had already been fixed another way in
rel_2_0, so let's stick with that.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18913 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoBibTemplate: make a couple of IE-friendly changes to BibTemplate.
senator [Fri, 3 Dec 2010 19:40:47 +0000 (19:40 +0000)]
BibTemplate: make a couple of IE-friendly changes to BibTemplate.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18912 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: In Alternate Serial Control interface, under Subscription Details
senator [Fri, 3 Dec 2010 00:18:30 +0000 (00:18 +0000)]
Serials: In Alternate Serial Control interface, under Subscription Details
within the Caption and Patterns tab, provide a new feature to import caption
and pattern data from existing bib records and/or legacy serials data
(serial.record_entry objects)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18906 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoOPAC JS combation and compression enhancements
erickson [Thu, 2 Dec 2010 22:16:24 +0000 (22:16 +0000)]
OPAC JS combation and compression enhancements

Added ability to combine locale-independent common JS files
(opac/common/js/) into a single JS file to reduce http back/forth from
the browser.  In the default skin, this combines 10 scripts into 1.  The
scripts to combine are parsed from js_common.xml (enclosed by START/END
COMPRESSION comments).  The combined file is created by autogen.  Use of
the combined file is enabled via new Apache configuration (off by
default).  When a JS compressor is configured in autogen, the JS file
will be subsequently compressed.

Also includes better IDL2js loader for My Account, which loads
additional fieldmapper classes.

TODO:
Add ./configure param for setting a JS compressor at build time
Options for providing compressed versions of other JS files

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18905 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agocopy/paste-o. Retrieve Patron in the patron log section of the Admin->Local Admin...
phasefx [Thu, 2 Dec 2010 20:54:54 +0000 (20:54 +0000)]
copy/paste-o.  Retrieve Patron in the patron log section of the Admin->Local Admin->Work Log uses the right list now

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18902 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoNormalize spaces in notcontains advance search query terms to address bug https:...
miker [Thu, 2 Dec 2010 19:32:30 +0000 (19:32 +0000)]
Normalize spaces in notcontains advance search query terms to address bug https://bugs.launchpad.net/evergreen/+bug/677122

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18901 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoReturn the copy status name when a copy is not available
dbs [Wed, 1 Dec 2010 19:11:41 +0000 (19:11 +0000)]
Return the copy status name when a copy is not available

It looks like the checkout operation used to return a fleshed
config.copy_status object, but that changed and we now get a
raw ccs ID back.

Retrieve the status name using the ccs ID and present that
to the users. Also, in case problems like this happen in
the future, provide a more specific error message and var
name so that it will be (hopefully!) a little clearer what
payload was expected in the first place :)

Resolves https://bugs.launchpad.net/evergreen/+bug/680575

Thanks to Jason Etheridge for a major assist with this bug.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18897 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAssorted small serials fixes
dbwells [Wed, 1 Dec 2010 13:52:00 +0000 (13:52 +0000)]
Assorted small serials fixes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18895 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotest case for minimum required version of Perl modules
gmc [Tue, 30 Nov 2010 22:32:06 +0000 (22:32 +0000)]
test case for minimum required version of Perl modules

Encode > 2.12 particularly matters, but there are likely
others of significance.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18893 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoMove Google Preview badge below the book cover image, if there is one
dbs [Tue, 30 Nov 2010 21:57:57 +0000 (21:57 +0000)]
Move Google Preview badge below the book cover image, if there is one

There might be a more correct way to do this in CSS, but works++

Also, give a little room between the images.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18891 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoquicker login+ssl-jump handling by showing immediately instaed of waiting on page...
erickson [Tue, 30 Nov 2010 21:00:01 +0000 (21:00 +0000)]
quicker login+ssl-jump handling by showing immediately instaed of waiting on page contents to load

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18889 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoprotect some of the supercat browse interfaces from unboundedness
gmc [Tue, 30 Nov 2010 20:43:55 +0000 (20:43 +0000)]
protect some of the supercat browse interfaces from unboundedness

E.g., browsing from a call number that contains forward slashes, e.g.,

"02/05/2004"

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18884 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoEnable GET params to be added properly in buildOPACLink()
dbs [Tue, 30 Nov 2010 20:12:06 +0000 (20:12 +0000)]
Enable GET params to be added properly in buildOPACLink()

Symptom was that the "?l=#" parameter wasn't being added to the
home screen "Advanced Search" link. Cause was that the
dojo.addOnLoad(init) call was being made after the
dojo.addOnLoad(home_init) call, which depended on globals being
set by init(). This started happening when the JavaScript was
shifted around in an attempt to kill the white screen of death.

There may be other similar issues in other interfaces; keep
your eyes open!

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18882 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodon't want a Refresh to jump back to the default sub-interface
phasefx [Tue, 30 Nov 2010 20:08:06 +0000 (20:08 +0000)]
don't want a Refresh to jump back to the default sub-interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18881 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohave the patron display default to the bills interface if spawned from the red-text...
phasefx [Tue, 30 Nov 2010 19:51:27 +0000 (19:51 +0000)]
have the patron display default to the bills interface if spawned from the red-text label in the Check In UI

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18880 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agospecify default leader for acq brief bibs
gmc [Tue, 30 Nov 2010 19:09:01 +0000 (19:09 +0000)]
specify default leader for acq brief bibs

In particular, avoid fun that could ensue if the
Leader/09 is not set to 'a'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18878 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd click event to red-text label in check-in UI for retrieving a patron when the...
phasefx [Tue, 30 Nov 2010 18:17:47 +0000 (18:17 +0000)]
add click event to red-text label in check-in UI for retrieving a patron when the associated transaction has a balance owed.  Code tweak to reduce the number of getElementById lookups

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18877 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomenu entry for Admin->Server Administration->Acquisitions->Line Item MARC Attribute...
phasefx [Tue, 30 Nov 2010 17:05:51 +0000 (17:05 +0000)]
menu entry for Admin->Server Administration->Acquisitions->Line Item MARC Attribute Definitions

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18875 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agostraighten out triggers that maintain rmsr
gmc [Tue, 30 Nov 2010 13:49:51 +0000 (13:49 +0000)]
straighten out triggers that maintain rmsr

In particular, make sure that the old zzz_
trigger on metabib.real_full_rec is completely removed, as
it needlessly slows down bib ingest.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18869 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoClean up some of the Apache config mod_rewrite rules
dbs [Tue, 30 Nov 2010 05:12:13 +0000 (05:12 +0000)]
Clean up some of the Apache config mod_rewrite rules

Thomas Berezansky suggested some improvements to the mod_rewrite
rules in eg_vhost.conf on the -devel mailing list; this is a stab
at correcting the most egregious problems.

Tested with Zotero and unAPI still works; tested with the staff
client and language-switching still works, as do the Conify and
Vandelay interfaces. Seems reasonably good.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18868 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix failure when attempting to create invoice
gmc [Tue, 30 Nov 2010 00:11:22 +0000 (00:11 +0000)]
fix failure when attempting to create invoice

Occurred for line items that were not part of a selection list

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18866 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agotest cases for the naco_normalize stored function
gmc [Mon, 29 Nov 2010 22:54:30 +0000 (22:54 +0000)]
test cases for the naco_normalize stored function

Note that running the tests would require sticking in
the connection parameters for an Evergreen database; check
comments for some musings on how to do this better.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18865 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agorevised version of naco_normalize
gmc [Mon, 29 Nov 2010 21:44:34 +0000 (21:44 +0000)]
revised version of naco_normalize

This implements the latest version of the NACO
normalization specification found at

http://www.loc.gov/catdir/pcc/naco/SCA_PccNormalization_Final_revised.pdf

This version of the algorithm is more general -- for example,
all combining characters are removed -- so there should be
fewer fiddly edge cases to worry about for most European
languages.

Rebuilding the metabib.*_field_entry tables (e.g., by using
reingest-1.6-2.0.pl) is recommended if there are any bibs that contain
any non-ASCII characters.

Normalized text is now left in the NFKD form, so while this should
be transparent to the search system after reindexing, it does mean
that (for example) Korean text in metabib.*_field_entry may not
be in the same Unicode normalization form as that found in
biblio.record_entry.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18864 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoprevent the allRecordsReceived event from firing multiple times in one page rendering
erickson [Mon, 29 Nov 2010 20:24:48 +0000 (20:24 +0000)]
prevent the allRecordsReceived event from firing multiple times in one page rendering

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18863 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohonor forceLoginSSL for place holds login in OPAC
erickson [Mon, 29 Nov 2010 20:24:47 +0000 (20:24 +0000)]
honor forceLoginSSL for place holds login in OPAC

When forceLoginSSL is enabled and the user clicks on place-hold in
results page or record details page, reload the page as SSL (if it's not
already using SSL) and show the login dialog (if the user is not already
logged in).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18862 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agologic error (inversion) in retargetting of previous copy when no other holds are...
miker [Mon, 29 Nov 2010 19:46:47 +0000 (19:46 +0000)]
logic error (inversion) in retargetting of previous copy when no other holds are looking at it

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18858 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoPatch (trunk-ified) from Jeff Godin:
miker [Mon, 29 Nov 2010 17:42:15 +0000 (17:42 +0000)]
Patch (trunk-ified) from Jeff Godin:

In the staff client, the holds context menu option "Edit PickupLibrary" displays and allows selection of org units that it shouldn't.

Org units whose type has can_have_users = FALSE are not valid pickup locations.

Using the default types as an example, CONS and SYS1 are invalid pickup locations.

The OPAC enforces this when allowing patrons to edit a hold.

The staff client does not enforce this when staff edit a hold.

The can_have_users() method of the au object returns a string 't' or 'f' which is then compared to 0.

The attached patch corrects this issue. ( foo == 0 becomes !isTrue(foo) ).

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18854 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: make some IDL changes and some changes to field order in an AutoGrid
senator [Mon, 29 Nov 2010 16:44:04 +0000 (16:44 +0000)]
Serials: make some IDL changes and some changes to field order in an AutoGrid
to support easier creation of working copy templates with serials.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18852 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: routing list display glitchiness. Previously, the display did not
senator [Mon, 29 Nov 2010 16:25:38 +0000 (16:25 +0000)]
Serials: routing list display glitchiness.  Previously, the display did not
correctly handle a mix of received items with and without routing lists.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18851 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAddress 1.6.1-2.0 upgrade problems reported by Ben Shum
dbs [Sun, 28 Nov 2010 15:11:55 +0000 (15:11 +0000)]
Address 1.6.1-2.0 upgrade problems reported by Ben Shum

1. We were attempting to update the asset.uri ID sequence value
with the wrong syntax; also, adding just 1 would return an error
in the event that only the seed value for asset.uri had been
inserted.

2. Somehow the body of the maintain_control_numbers() function
was pasted twice, resulting in a syntax error.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18850 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd the asset.copy(create_date) index to the 1.6.1-2.0 update script
dbs [Wed, 24 Nov 2010 20:11:05 +0000 (20:11 +0000)]
Add the asset.copy(create_date) index to the 1.6.1-2.0 update script

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18847 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoEverything else in the menu is alphabetized (in English anyway), so Copy
senator [Wed, 24 Nov 2010 16:32:50 +0000 (16:32 +0000)]
Everything else in the menu is alphabetized (in English anyway), so Copy
Template Editor may as well be too.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18845 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoAdd an index on asset.copy(create_date) for item-age browse
dbs [Wed, 24 Nov 2010 03:31:14 +0000 (03:31 +0000)]
Add an index on asset.copy(create_date) for item-age browse

Running an item-age browse against a database with a reasonable
number of entries in asset.copy is dog-slow without an index
like this.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18842 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomove all invocations of Volume/Copy Creator and Spine Label interfaces to tabs to...
phasefx [Tue, 23 Nov 2010 21:52:01 +0000 (21:52 +0000)]
move all invocations of Volume/Copy Creator and Spine Label interfaces to tabs to workaround https://bugs.launchpad.net/evergreen/+bug/677628

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18841 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: add ability to print routing lists from the batch receive interface
senator [Tue, 23 Nov 2010 21:40:36 +0000 (21:40 +0000)]
Serials: add ability to print routing lists from the batch receive interface

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18840 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: Fix error in batch receiving when trying to change the shelving
senator [Tue, 23 Nov 2010 21:38:28 +0000 (21:38 +0000)]
Serials: Fix error in batch receiving when trying to change the shelving
location of the previous item in the stream when there /is/ no previous
item in the stream

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18838 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoFurther fixes for hold-driven recalls
dbs [Tue, 23 Nov 2010 20:58:28 +0000 (20:58 +0000)]
Further fixes for hold-driven recalls

Force a scalar context on the array reference of circs returned
from the search clause to short-circuit the recall processing
if we have no applicable circs to work through.

Also, open-ils.trigger.event.autocreate needs a Fieldmapper object,
not a raw CDBI object, so invoke the to_fieldmapper() method to
convert it accordingly (thanks to miker for the assist!)

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18837 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix broken prefix and namespace URI for the mods32 transform
gmc [Tue, 23 Nov 2010 14:11:51 +0000 (14:11 +0000)]
fix broken prefix and namespace URI for the mods32 transform

This breakage can be found in databases that started out at
version 1.2 or earlier; matters since in-DB ingest is stricter
with its XPATH processing.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18835 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agofix missing dep that prevented acq bib search form from working
gmc [Mon, 22 Nov 2010 22:47:09 +0000 (22:47 +0000)]
fix missing dep that prevented acq bib search form from working

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18831 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoappend to bottom of list for xul-based hold list interfaces. The result of this...
phasefx [Mon, 22 Nov 2010 20:38:28 +0000 (20:38 +0000)]
append to bottom of list for xul-based hold list interfaces.  The result of this is that rows appended off-screen (with just the hold id) will not make a network request for fleshing until they either become visible, or a column sort action is initiated

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18828 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agominor FeedTemplate bug fixes
miker [Mon, 22 Nov 2010 20:33:58 +0000 (20:33 +0000)]
minor FeedTemplate bug fixes

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18827 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobug #680096 - upgrade script to partially reingest bibs after upgrade to 2.0
gmc [Mon, 22 Nov 2010 17:17:59 +0000 (17:17 +0000)]
bug #680096 - upgrade script to partially reingest bibs after upgrade to 2.0

This solves the problem of the new facets sidebar showing up empty in
OPAC search results.  Since the process of populating metabib.facet_entry
and updating metabib.*_field_entry can take a long time on large databases,
the update SQL is generated by a separate script, reingest-1.6-2.0.pl.  Usage
from an example run is:

./reingest-1.6-2.0.pl: generate SQL script to reingest bibs during an upgrade to Evergreen 2.0

By default, the script writes to the file reingest-1.6-2.0.sql.  To modify
this script's behavior, you can supply the following options:

--config /path/to/opensrf_core.xml  used to get connection information to
                                    the Evergreen database
--chunk_size n                      number of bibs to reingest in a chunk;
                                    specify if you don't want all of the
                                    bibs in the database to be reindexes
                                    in a single transaction
--output /path/to/output_file.sql   path of output SQL file

Writing output to file reingest-1.6-2.0.sql

SQL script complete.  To perform the reingest, please run the script using
the psql program, e.g.,

psql {connection parameters}  < reingest-1.6-2.0.sql

If you are running a large Evergreen installation, it is recommend that you
examine the script first; note that a reingest of a large Evergreen database
can take several hours.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18826 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agomore SuperCat XML fixup needed to support serials data -- important for opac customiz...
miker [Mon, 22 Nov 2010 17:04:56 +0000 (17:04 +0000)]
more SuperCat XML fixup needed to support serials data -- important for opac customization though BibTemplate (as in, "do not blow up")

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18823 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd field to IDL needed by, well, a bunch of stuff: sstr-[has_many]->items
miker [Mon, 22 Nov 2010 15:16:42 +0000 (15:16 +0000)]
add field to IDL needed by, well, a bunch of stuff: sstr-[has_many]->items

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18821 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agodocument a potential gotcha for users of open-ils.storage.action.circulation.overdue
gmc [Mon, 22 Nov 2010 13:36:54 +0000 (13:36 +0000)]
document a potential gotcha for users of open-ils.storage.action.circulation.overdue

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18818 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoparallel fine generator
gmc [Mon, 22 Nov 2010 13:17:57 +0000 (13:17 +0000)]
parallel fine generator

The fine generator cronjob can now use multiple
parallel processes by setting fine_generator/parallel
in opensrf.xml to a value greater than 1.  This
can speed up periodic fine generation in a database
containing a large number of overdue loans.

Also added a service to return just the list of
IDs of overdue loans and reservations - fleshing
the entire set of overdue loans when generating fines
has been observed to cause significant swap-thrashing in
at least one large database.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18817 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoThe absence of holds-triggered recall rules should not break hold targeting
dbs [Mon, 22 Nov 2010 04:46:49 +0000 (04:46 +0000)]
The absence of holds-triggered recall rules should not break hold targeting

Thanks to Galen Charlton for pointing out that if rules were not set for
holds-triggered recalls, then all hold targeting would break because of
an assumption the code made that one could invoke the ->{value} member
of the OU settings. But of course the return value for an unset OU setting
is undef, not an object with an undef ->{value} member.

This should unbreak that code path.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18816 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agohold targeter: add option to run parallel targeter processes
gmc [Mon, 22 Nov 2010 04:26:44 +0000 (04:26 +0000)]
hold targeter: add option to run parallel targeter processes

Permit the hold targeter to divvy up the work and run more than one process
at a time by setting the opensrf.xml setting hold_targeter/parallel to a
value greater than one.  Doing so can significantly reduce the
time it takes to (re)target a large number of hold requests, although
only up to a point (in other words, if increasing the number of parallel
targeters beyond one, it is recommended to do so slowly.)

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/trunk@18815 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agobump xulrunner version
phasefx [Sun, 21 Nov 2010 15:38:52 +0000 (15:38 +0000)]
bump xulrunner version

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18814 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoadd xhtml namespace to global.css, though I can't figure out how to style the xhtml...
phasefx [Sun, 21 Nov 2010 10:36:10 +0000 (10:36 +0000)]
add xhtml namespace to global.css, though I can't figure out how to style the xhtml.textarea in the marc editor with font_helper.  Tried .ALL_FONTS_LARGER xhtml.textarea and .ALL_FONTS_LARGER *.textarea to no avail

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18813 dcc99617-32d9-48b4-a31d-7c20da2025e4

13 years agoSerials: a routing list editor for the alternate serials control view
senator [Sat, 20 Nov 2010 22:55:56 +0000 (22:55 +0000)]
Serials: a routing list editor for the alternate serials control view

Now we still need to teach the receive interface to offer to print the list
when there is one, but I think that should be relatively simple.

git-svn-id: svn://svn.open-ils.org/ILS/trunk@18812 dcc99617-32d9-48b4-a31d-7c20da2025e4