Use the staff-wrapped catalog when jumping to a bib record

Signed-off-by: Mike Rylander <mrylander@gmail.com>

For any grid with a persistKey, store the last selected row count as a localStorage value

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add record summary bar to the catalog display, and hide Actions for this Record until usable

Signed-off-by: Mike Rylander <mrylander@gmail.com>

implement "delete all from catalog" for copy buckets

TODO: at present, this is pretty optimistic

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webstaff: add basic copy bucket management functionality

This adds an interface for managing copy buckets, including
adding and removing them, adding items to a pending list and to
copy buckets by barcode, and removing items from a bucket.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

make clearing the record bucket pending list action functional

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

implement Show All in Catalog action for record buckets

Note that this will typically require the brower's pop-up
blocker to be disabled for the webstaff site.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

use staff search for record bucket queries

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Improve styling of retrieve-by pages

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Implement retrieve record by id and tcn

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use egCore.env.basePath to construct the URL for last record

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Implement "Retrieve Last Bib Record" using localStorage record cache

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Save the record we land on from within the staff client as the "last record retrieved"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1402797 browser client noncat circ display

Adds a new tab to the patron items out page for Non-Cataloged
Circulations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 browser client noncat counts in patron summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 browser client interval parser

Adds a new service on the core module for adding date handling
utilities.  Included in this commit is a new function:

egDate.intervalToSeconds(interval);

Includes Gruntfile additions and unit tests.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1402797 PCRUD access for noncat circs in IDL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1402797 patron search form focus repairs cont.

Building on Mike's original work, use Angular ng-mouseover and the
Angular $document built-in.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

use null as default payment amount

This means that operator does not have to select the
previous default of "0" in the control to clear it out.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

webby: catalog record -> view holds org filter repair

Selecting a pickup library from the filter in the Catalog -> View Holds
UI shows holds for the selected org unit and descendant org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Repair browser client dropdown buttons - #2

Repairs egOrgSelector.

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Allow, and use, disabling of button-ish anchors

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Only enable the Apply Payment button when a bill is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>

webby: checkin fine tally patron bills link

Checkin fine tally display now acts as a link which opens a new tab to
the patron bills page for the current checkin patron when fines exist.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Actually do search button, too

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Focus patron search field on search, expand, clear

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Use .finally() instead of hash-y syntax~

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Apply focus in the .finally() in case there was a popup

Signed-off-by: Mike Rylander <mrylander@gmail.com>

fix checkout focus after patron load

Thanks to berick and jcamins, and to eeevil for actually nailing the solution

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Repair browser client dropdown buttons

Angular-ui-bootstrap as of version ~0.11.2 does not want bare
"dropdown-toggle" attributes within action link tags.  When present,
they prevent the dropdown button from opening.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

webby: repair Hatch type=text printing

When printing text, Hatch was receiving no print content due to some
code refactoring.  Repaired.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Avoid org tree retrieval race condition on patron app

Avoid calling egOrg.ancestors() during startup, because the org unit
tree is not guarantee to be available until startup has completed.  This
was causing an occasional JS excpetion in the patron app pages, which
prevented the pages from loading.

The error in question:

 TypeError: Cannot read property 'map' of undefined
    at Object.service.get (https://host/js/ui/default/staff/services/org.js:21:25)
    at Object.service.ancestors (https://host/js/ui/default/staff/services/org.js:34:28)
    at Object.egCore.env.classLoaders.actsc (https://host/js/ui/default/staff/circ/patron/app.js:41:37)
    at https://host/js/ui/default/staff/services/env.js:77:55
    at Object.r [as forEach] (https://host/js/ui/default/staff/build/js/angular.min.js:7:290)
    at Object.service.load (https://host/js/ui/default/staff/services/env.js:76:17)
    at https://host/js/ui/default/staff/services/startup.js:64:23
    at J (https://host/js/ui/default/staff/build/js/angular.min.js:101:96)
    at https://host/js/ui/default/staff/build/js/angular.min.js:102:259
    at h.$eval (https://host/js/ui/default/staff/build/js/angular.min.js:113:32)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Adjust timestamp with local timezone before truncating to the date

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add usr and requestor columns to the hold pull list

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Begin teaching grid about class hierarchies for labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fetch old circ when the user is not the same (API misuse)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Browser client checkout 'Done' clears current user

Clicking the 'Done' button after checkout resets the patron side bar and
action tabs to completely hide the previous patron's data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove useless options in record bucket export

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Allow the status bar to be hidden

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Separate stock and custom penalty type models

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Supply top-level method for uncanceling holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix boolean assumption

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Sort by class, and keep columns from one class together

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Adjust the default for penalty type so it is selected

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add invalid-address alert

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add Check Number input

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add the ability (and action) to uncancel holds

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Ignore the "current_copy" field, we already get that separately

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Teach autogrid how to ignore fields explicitly

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add patron barcode and alias to hold lists where appropriate

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix "scan item for missing pieces" label to say Item instead of Patron

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make "Checkout" the consistent spelling in the IDL

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Comment out Hide/Show All in autogrid

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add label to custom penalty dropdown

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Push explicitly added columns to the top and keep the explicit order, then sort the rest by their labels

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add catalog search to the search menu in the nav bar

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Add checkout/in workstation colums to the available set

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Documentation: LP#1386854 - Locally Hosted Added Content.

Adds documentation that describes how to use the local content bypass
feature of the AddedContent modules.  This allows for local added content like
cover art, reviews, TOC, exerpts or annotations to be shown in bib records.

I also changed the headers in the External Added Content section to use title case.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1390225: Fail to care about errors from auth.session.delete

We're just tossing this call over the wall and moving on.  We don't
care if the session wasn't there to delete or even if we didn't pass
a session to the server.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1390225: redirect to ctx.home_page instead of through ctx.logout_page

This way, we skip the auth.session.delete call that will error out because
we no longer have the authtoken cookie.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP#1248636: Clear session at OPAC logout

When the user explicitly logs out, clear the session on the server side.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

Forward-port 2.6.3 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward-port 2.5.7 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>

Forward port 2.6-2.7 upgrade script

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1366964 Update libdbi connection test error parsing

Modern version of libdbi return a slightly different error message for
queries which fail mid-transaction, causing an C-based DB backends to
exit abruptly unnecessarily.  Update the error message test to include
the new format.

Includes Perl live test for confirming functionality.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>

LP1383697: Long Overdue needs to be a "magical status" for the copy editor

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

lp1383763 - Display OpenURL embargo statement

The ResolverResolver service fetches the embargo statement (such as
"Last year not available") from OpenURL resolvers and stores it in a
target_embargo field. In JSPAC we used to display this along with the
coverage statement, because it is very important that people know that a
resource may be available from 1999 but the last year isn't available
online.

Restore the display of this information to the TPAC.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Docs: Changed 'Importing materials' in the staff client section LP#1371615

Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1384868: limit fund drop-downs on the invoice page to only active funds

This patch fixes the fund selectors for adding extra copies
and charges to invoices to only active funds (in addition
to the existing restriction to funds visible to the user).

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

Docs: add default icon definitions LP#1371598

Documents the default icon definitions that are included with a stock Evergreen install.

Signed-off-by: Yamil Suarez <yamil@yamil.com>

LP#1261486 Action/trigger aggregator script repairs

* If both date filters are selected, apply both instead of replacing the
  first with the second

* Select distinct event output to prevent dupes

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

LP#1379824 Make PermaCrud.js disconnect() actually disconnect

The disconnect() method in PermaCrud.js was meant to wrap the
underlying session disconnect, but it never actually disconnected
the session.  This could lead to problems in long-living PermaCrud
objects, as they may think they are still connected when they are not
(the session remote_id is never cleared).

Also, remove a couple (now redundant) manual session.disconnect() calls.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1305958 Change copy table header atts to scope attributes

Per http://webaim.org/techniques/tables/data, the current best practice for
marking up tables for accessibility is to use the "scope" attribute for
headers, rather than the error-prone and markup-heavy "headers" attribute on
table cells.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1309664: Stamping upgrade script for new seed data for COM and SER

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1309664: Add some fixed field seed data for COM and SER

There are a few useful fixed fields we're missing mapping data for,
so this branch adds three: Freq, Regl, and File. There are certainly
more, but here's a bit that's of use to folks in the wild using the
fixed field editor improvements.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1374551: Stamping upgrade script for new index on money.billing.voider

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1374551: Create index on money.billing.voider to speed user merge.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1368314: Stamping upgrade script for RDA support to reporter.simple_record

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1368314: Add RDA support to reporter.simple_record.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1306814: Make use of patron timeout setting for selfcheck

As described in the bug, the library setting "Self Check: Patron Login Timeout
(in seconds)" does not appear to work with the newer selfcheck interface.

It looks like some of it was already being pulled in, like the variable, but
the interface was not utilizing it.

This commit borrows from the old JS selfcheck and implements a default of
three minutes for selfcheck timeout otherwise handled by the library setting.

Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Translation updates - newpot

Signed-off-by: Ben Shum <bshum@biblio.org>

Translation updates - po files

Signed-off-by: Ben Shum <bshum@biblio.org>

Update script for update_pofiles

We were missing a few of the folders used for i18n purposes from
the update_pofiles script. Added the following entries:

FlattenerGrid.js
match_set.js
PCrudFilterPane.js
serial.js
tpac
URLVerify.js
vandelay.js

Also, change from Acq.js to acq.js.

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1252786: Add Workstation link to Aged and Active Circulations reports source.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1374091: stamping upgrade script for speedier record_attr views

Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1374091: Speed up metarecord version of unAPI mra call

The change to metabib.record_attr_flat in the previous commit caused
a regression in the plan used in unapi.mmr_mra.  This commit addresses
that by unrolling the mra view when used in context with metarecords,
which are shaped differently and require slightly different access
patterns.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1374091: Redefine view to help PG make better plans

The metabib.record_attr_flat view previously pulled its data
through several other intermediate views.  While this improves
maintenance overhead, it ends up being an optimization fence
for certain data sets.  So, we pull the logic from the leaf
views up into the main view.  And, poof, 2 orders of magnitude
speedup on large data sets.

Signed-off-by: Mike Rylander <miker@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1378575: teach action::hold_request about behind_desk

This patch teaches the CDBI class for the action.hold_request
table about the newish behind_desk column, preventing errors
like this from being thrown if a recent OpenSRF version is in
use:

Processing of hold failed:  Can't locate object method "behind_desk"
via package "action::hold_request" at /usr/local/share/perl/5.14.2/OpenILS/Application/Storage/CDBI.pm line 181.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>

LP#1314827: On login, don't allow referer-based redirect to external site

On /eg/opac/login, if no redirect_to param is provided, the TPAC will
attempt to use the referer (if any) as the redirect destination. This
leads to undesirable behavior if the referring URL is from an external
site.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>

Documentation bug: corrected image file

Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>

Whitespace and non-weird emdash in docs

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: Change all internal links to correct format

Resolves LP#1294347

I just deleted one link since I couldn't find any trace of where it was intended to go.

acquisitions/selection_lists_po.txt:
"or use the link:federated.txt[View/Place Orders] menu item in the catalog."

If anyone ever finds where that is supposed to go, let me know and I'll fix it.

Signed-off-by: Josh Stompro <github@stompro.org>
Signed-off-by: Remington Steed <rjs7@calvin.edu>

LP#1347774 CStoreEditor anonymous PCRUD additions

* Exporter repairs : use export_to_level
* pcrud personality call argument mod repair
* log pcrud personality json_query attempts loudly to ease transition
* CStoreEditor anon/pcrud personality live test

* CStoreEditor anon pcrud default to undef authtoken:
The presence of an authtoken ("ANONYMOUS") in the editor can be
misleading at higher levels of the code, since it implies a
presumably functional authtoken has been provided somewhow.
Apply ANONYMOUS only as needed to API calls instead.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <miker@esilibrary.com>

LP#1347774 Anonymous PCRUD mode

Support for anonymous access to public (field_safe=true) IDL data
via PCRUD without requiring an authtoken.  To use, pass an authtoken of
ANONYMOUS.

Includes initial CStoreEditor plugin for anon pcrud.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1373693: Speed up call number browse search at top level org.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>

Docs: Removed redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Updated 2 links that pointed to the old subversion repository

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Docs: Removed a redundant phrase as mentioned in bug #1294299

Signed-off-by: Yamil Suarez <yamil@yamil.com>

Tidy search section of Using the OPAC

Primarily focused on restructuring the information around Boolean
searching, particularly as I find librarians want to know what the
Boolean operators are that they should use. However, cleaned up some
typos and formatting along the way.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Docs: for new "Imported As" column in Vandelay queue results view

Added explanation of the new "Imported As" menu in "MARC Batch Import/Export"
queue results view, also updated screenshots.

Thanks to Joan Kranich of C/W MARS, for helping research were to make these
changes.

Signed-off-by: Yamil Suarez <yamil@yamil.com>