working/Evergreen.git
3 years agoLP#1929749: [seed data] update LI worksheet template
Galen Charlton [Sat, 5 Feb 2022 17:33:30 +0000 (12:33 -0500)]
LP#1929749: [seed data] update LI worksheet template

This commit adds back various elements to better match the
Dojo version of the template.

This commmit also corrects some IDs in the upgrade script.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: tweak LI worksheet code
Galen Charlton [Sat, 5 Feb 2022 17:33:08 +0000 (12:33 -0500)]
LP#1929749: tweak LI worksheet code

- ensure that line item details and formulas are
  correctly fleshed
- add CSS for table styling

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: add two additional fleshing options to LI retrieval
Galen Charlton [Sat, 5 Feb 2022 17:30:45 +0000 (12:30 -0500)]
LP#1929749: add two additional fleshing options to LI retrieval

Specifically, flesh_copy_location and flesh_call_number. These take
effect only when flesh_copies is also true and are used to further
flesh values of items attached to line item details.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: (follow-up) another label tweak
Galen Charlton [Thu, 27 Jan 2022 18:42:36 +0000 (13:42 -0500)]
LP#1929749: (follow-up) another label tweak

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: (follow-up) open a couple links from LI summary in new tab
Galen Charlton [Thu, 27 Jan 2022 15:56:44 +0000 (10:56 -0500)]
LP#1929749: (follow-up) open a couple links from LI summary in new tab

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: (follow-up) fix a link title
Galen Charlton [Thu, 27 Jan 2022 15:54:27 +0000 (10:54 -0500)]
LP#1929749: (follow-up) fix a link title

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: (follow-up) relabel action
Galen Charlton [Thu, 27 Jan 2022 15:34:14 +0000 (10:34 -0500)]
LP#1929749: (follow-up) relabel action

"Holdings Maintenance" -> "Holdings View"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: add mark selector/order ready actions to LI list
Galen Charlton [Wed, 19 Jan 2022 22:54:40 +0000 (17:54 -0500)]
LP#1929749: add mark selector/order ready actions to LI list

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: fund admin debits list now links to Angular PO and LI interfaces
Galen Charlton [Wed, 19 Jan 2022 22:11:35 +0000 (17:11 -0500)]
LP#1929749: fund admin debits list now links to Angular PO and LI interfaces

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: Originating Acquisition from item status now links to Angular interface
Galen Charlton [Wed, 19 Jan 2022 22:06:07 +0000 (17:06 -0500)]
LP#1929749: Originating Acquisition from item status now links to Angular interface

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: catch and report upload errors
Galen Charlton [Thu, 13 Jan 2022 23:27:58 +0000 (18:27 -0500)]
LP#1929749: catch and report upload errors

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: fix handling of match set and fiscal year
Galen Charlton [Thu, 13 Jan 2022 23:02:41 +0000 (18:02 -0500)]
LP#1929749: fix handling of match set and fiscal year

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) tweak asset creation on PO creation
Galen Charlton [Thu, 13 Jan 2022 21:52:21 +0000 (16:52 -0500)]
LP#1942220: (follow-up) tweak asset creation on PO creation

When creating a PO from LIs from a SL or a search, ticking the
checkbox to import bibs and create items will redirect the user
to the asset creation form (after the PO is created)

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: tweak applying upload template
Galen Charlton [Thu, 13 Jan 2022 21:43:00 +0000 (16:43 -0500)]
LP#1929749: tweak applying upload template

When in fetch import parameters mode, don't try to
apply the provider or fiscal year from the template.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) history tables now include times
Galen Charlton [Thu, 13 Jan 2022 21:16:09 +0000 (16:16 -0500)]
LP#1942220: (follow-up) history tables now include times

Also remove a couple superseded TODOs

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: tweak ordering agency selector
Galen Charlton [Thu, 13 Jan 2022 21:08:48 +0000 (16:08 -0500)]
LP#1929749: tweak ordering agency selector

Restrict the OUs to the ones that the user has
permissions to either create POs or SLs at.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) ... restrict even further
Galen Charlton [Thu, 13 Jan 2022 21:06:02 +0000 (16:06 -0500)]
LP#1942220: (follow-up) ... restrict even further

Signek-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) add perm limits to create PO ordering agency selector
Galen Charlton [Thu, 13 Jan 2022 21:03:44 +0000 (16:03 -0500)]
LP#1942220: (follow-up) add perm limits to create PO ordering agency selector

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) display linked PO name in SL LI list
Galen Charlton [Thu, 13 Jan 2022 20:10:54 +0000 (15:10 -0500)]
LP#1942220: (follow-up) display linked PO name in SL LI list

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) tweak PO create form
Galen Charlton [Thu, 13 Jan 2022 20:04:10 +0000 (15:04 -0500)]
LP#1942220: (follow-up) tweak PO create form

Display the checkbox for creating assets only if
the PO is being created from one or more line items

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) have UI allow receiving of delayed LI and LIDs
Galen Charlton [Thu, 13 Jan 2022 19:36:35 +0000 (14:36 -0500)]
LP#1942220: (follow-up) have UI allow receiving of delayed LI and LIDs

(At the level of the individual LI or LID; the menu item to receive
selected line items ignores the cancellation state of LI and LIDs entirely)

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) API: remove cancel reason if last LID of LI is received
Galen Charlton [Thu, 13 Jan 2022 19:35:00 +0000 (14:35 -0500)]
LP#1942220: (follow-up) API: remove cancel reason if last LID of LI is received

Otherwise, a sequence where a line item was cancelled but one of
its items was received would have the LI end up in a received
state but with a cancel reason.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: improvements to provider selector
Galen Charlton [Thu, 13 Jan 2022 15:30:57 +0000 (10:30 -0500)]
LP#1929749: improvements to provider selector

This patch converts the provider combobox to use
the automatic PCRUD data source so that the OU label
shows up by default. This also means that all providers
visible to the user are available, not just the ones
owned by the WS OU or its ancestors.

This patch also tweaks a couple of the selectors so
that they get properly updated when a template is selected.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: combobox: improve idlIncludeLibraryInLabel
Galen Charlton [Thu, 13 Jan 2022 15:29:47 +0000 (10:29 -0500)]
LP#1929749: combobox: improve idlIncludeLibraryInLabel

This option no longer requires that the OU field be
fleshed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) properly style 'delayed' LI dispositions
Galen Charlton [Tue, 11 Jan 2022 22:52:32 +0000 (17:52 -0500)]
LP#1942220: (follow-up) properly style 'delayed' LI dispositions

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) display cancel reason label in LI table
Galen Charlton [Tue, 11 Jan 2022 22:52:08 +0000 (17:52 -0500)]
LP#1942220: (follow-up) display cancel reason label in LI table

(rather than just 'Canceled')

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) add basic event reporting to PO cancelation
Galen Charlton [Tue, 11 Jan 2022 22:51:07 +0000 (17:51 -0500)]
LP#1942220: (follow-up) add basic event reporting to PO cancelation

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) move LI identifier widget
Galen Charlton [Tue, 11 Jan 2022 21:56:26 +0000 (16:56 -0500)]
LP#1942220: (follow-up) move LI identifier widget

This moves the controls for setting the LI identifier
over to the main block of LI details. This address a
UX issue discovered during testing: testers were ending
up entering the LI price in the LI identifier control.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) fix handling of fund balance warning
Galen Charlton [Tue, 11 Jan 2022 21:44:55 +0000 (16:44 -0500)]
LP#1942220: (follow-up) fix handling of fund balance warning

This is now just a warning that requires an extra confirmation
step to activate a PO, not a blocker to activation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) open LI catalog links in new tab
Galen Charlton [Tue, 11 Jan 2022 20:38:01 +0000 (15:38 -0500)]
LP#1942220: (follow-up) open LI catalog links in new tab

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) tweak LI expand/hide behavior
Galen Charlton [Tue, 11 Jan 2022 20:33:17 +0000 (15:33 -0500)]
LP#1942220: (follow-up) tweak LI expand/hide behavior

- Expand/collapse at the individual LI level no longer expands
  only one line item at a time; user can exapnd or collapse as
  many as they see fit
- when navigating between pages of LIs, the current state of
  the expand/collapse all button controls whether the page of
  LIs are show as expanded or collapsed

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) include receiver in select LI details displays
Galen Charlton [Tue, 11 Jan 2022 20:01:34 +0000 (15:01 -0500)]
LP#1942220: (follow-up) include receiver in select LI details displays

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) add flesh_li_details_receiver to LI retrieval
Galen Charlton [Tue, 11 Jan 2022 20:01:11 +0000 (15:01 -0500)]
LP#1942220: (follow-up) add flesh_li_details_receiver to LI retrieval

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) don't allow brief record addition for once-activated POs
Galen Charlton [Tue, 11 Jan 2022 19:24:33 +0000 (14:24 -0500)]
LP#1942220: (follow-up) don't allow brief record addition for once-activated POs

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) show zero-copy activate option only for new/pending orders
Galen Charlton [Tue, 11 Jan 2022 19:20:46 +0000 (14:20 -0500)]
LP#1942220: (follow-up) show zero-copy activate option only for new/pending orders

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) ... and another one
Galen Charlton [Thu, 6 Jan 2022 23:05:56 +0000 (18:05 -0500)]
LP#1942220: (follow-up) ... and another one

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) ... and make following link break out of iframe
Galen Charlton [Thu, 6 Jan 2022 23:01:33 +0000 (18:01 -0500)]
LP#1942220: (follow-up) ... and make following link break out of iframe

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (follow-up) link to Angular PO and SL from Dojo invoice display
Galen Charlton [Thu, 6 Jan 2022 22:56:26 +0000 (17:56 -0500)]
LP#1942220: (follow-up) link to Angular PO and SL from Dojo invoice display

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement add selected to PO action from LI search user/gmcharlt/ang-acq-4-wip
Galen Charlton [Thu, 16 Dec 2021 00:39:19 +0000 (19:39 -0500)]
LP#1942220: implement add selected to PO action from LI search

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement Mark Selector Ready and Mark Order Ready actions
Galen Charlton [Wed, 15 Dec 2021 20:18:49 +0000 (15:18 -0500)]
LP#1942220: implement Mark Selector Ready and Mark Order Ready actions

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: defer implementing the Move to Selection List LI search action
Galen Charlton [Wed, 15 Dec 2021 19:58:46 +0000 (14:58 -0500)]
LP#1942220: defer implementing the Move to Selection List LI search action

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search action Link Invoice
Galen Charlton [Wed, 15 Dec 2021 19:56:58 +0000 (14:56 -0500)]
LP#1942220: implement LI search action Link Invoice

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search action Create Invoice
Galen Charlton [Wed, 15 Dec 2021 19:51:03 +0000 (14:51 -0500)]
LP#1942220: implement LI search action Create Invoice

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search action delete
Galen Charlton [Wed, 15 Dec 2021 00:04:09 +0000 (19:04 -0500)]
LP#1942220: implement LI search action delete

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search action cancel
Galen Charlton [Tue, 14 Dec 2021 23:30:39 +0000 (18:30 -0500)]
LP#1942220: implement LI search action cancel

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search receive and un-receive actions
Galen Charlton [Tue, 14 Dec 2021 23:20:10 +0000 (18:20 -0500)]
LP#1942220: implement LI search receive and un-receive actions

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement LI search action apply claim policy
Galen Charlton [Tue, 14 Dec 2021 22:56:53 +0000 (17:56 -0500)]
LP#1942220: implement LI search action apply claim policy

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: add LI search action to create PO from selected
Galen Charlton [Tue, 14 Dec 2021 22:44:14 +0000 (17:44 -0500)]
LP#1942220: add LI search action to create PO from selected

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement item count and claim count LI filtering
Galen Charlton [Tue, 14 Dec 2021 17:12:12 +0000 (12:12 -0500)]
LP#1942220: implement item count and claim count LI filtering

Noting that this is being done client-side

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: refresh PO upon adding batch-adding copies
Galen Charlton [Tue, 14 Dec 2021 16:23:36 +0000 (11:23 -0500)]
LP#1942220: refresh PO upon adding batch-adding copies

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: make the fund selector support empty term click in charges component
Galen Charlton [Tue, 14 Dec 2021 16:10:33 +0000 (11:10 -0500)]
LP#1942220: make the fund selector support empty term click in charges component

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: fix glitch in direct charges deletion testing
Galen Charlton [Tue, 14 Dec 2021 16:09:29 +0000 (11:09 -0500)]
LP#1942220: fix glitch in direct charges deletion testing

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: tweaks to Link Invoice dialog
Galen Charlton [Tue, 14 Dec 2021 16:07:19 +0000 (11:07 -0500)]
LP#1942220: tweaks to Link Invoice dialog

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: combobox: reset if idlQueryAnd changes
Galen Charlton [Tue, 14 Dec 2021 16:06:52 +0000 (11:06 -0500)]
LP#1942220: combobox: reset if idlQueryAnd changes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement Export Single Attribute List from LI Search
Galen Charlton [Tue, 14 Dec 2021 15:43:09 +0000 (10:43 -0500)]
LP#1942220: implement Export Single Attribute List from LI Search

Also do a bit of refactoring; LineitemService will include more
of the meat of each action, leaving it to the caller to stage
parameters.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: start defining actions on LI search results page
Galen Charlton [Tue, 14 Dec 2021 15:23:38 +0000 (10:23 -0500)]
LP#1942220: start defining actions on LI search results page

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: include owning lib shortname in provider selector
Galen Charlton [Tue, 14 Dec 2021 02:36:25 +0000 (21:36 -0500)]
LP#1942220: include owning lib shortname in provider selector

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: fixes to PO item deletion
Galen Charlton [Tue, 14 Dec 2021 02:15:51 +0000 (21:15 -0500)]
LP#1942220: fixes to PO item deletion

- use an open-ils.acq method rather than PCRUD
- display the delete button under more circumstances

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: add 'Disencumber' action for PO items
Galen Charlton [Tue, 14 Dec 2021 02:01:26 +0000 (21:01 -0500)]
LP#1942220: add 'Disencumber' action for PO items

This adds a button to, upon user confirmation, change the
fund debit for a PO item to a zero-value encumbrance.

This button is available for a charge only if:

- the PO item is attached to a fund debit that has
  no invoice entries or items attached
- the PO is activated but not cancelled
- the fund debit is not an expenditure
- the debit amount is not already zero

The purpose of this button is to clean up encumbrances for
miscellaneous charges on invoiced POs that have not been
linked to invoice items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: fix how the status of a received PO is displayed
Galen Charlton [Tue, 14 Dec 2021 02:00:47 +0000 (21:00 -0500)]
LP#1942220: fix how the status of a received PO is displayed

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: add open-ils.acq.po_item.disencumber method
Galen Charlton [Tue, 14 Dec 2021 01:59:11 +0000 (20:59 -0500)]
LP#1942220: add open-ils.acq.po_item.disencumber method

This method disencumbers a PO item by setting its fund debit's amount
to zero. Note that this can be done only for encumbrances; if the
debit is an expenditure, it cannot be changed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: add flesh_po_items_further option to PO retrieval
Galen Charlton [Tue, 14 Dec 2021 01:36:16 +0000 (20:36 -0500)]
LP#1942220: add flesh_po_items_further option to PO retrieval

This fleshes in any fund debits and debit invoice items associated
with PO direct charges

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: turn on empty-click for fund selectors in items form
Galen Charlton [Mon, 13 Dec 2021 21:55:01 +0000 (16:55 -0500)]
LP#1942220: turn on empty-click for fund selectors in items form

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: do client-side sorting for all attributes
Galen Charlton [Mon, 13 Dec 2021 16:04:46 +0000 (11:04 -0500)]
LP#1942220: do client-side sorting for all attributes

This adds client-side sorting for title, author, and publisher
using Intl.Collator to achieve case-insenstive, punctuation-ignoring,
and numeral-sensitive sorting.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: allow empty-click in create PO's provider selector
Galen Charlton [Mon, 13 Dec 2021 15:29:56 +0000 (10:29 -0500)]
LP#1942220: allow empty-click in create PO's  provider selector

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: fix bug introduced in LI search results
Galen Charlton [Mon, 13 Dec 2021 15:11:48 +0000 (10:11 -0500)]
LP#1942220: fix bug introduced in LI search results

Should display the LI worksheet link only if a PO is
linked to the LI.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: link to new PO interface from provider PO table
Galen Charlton [Thu, 9 Dec 2021 22:53:35 +0000 (17:53 -0500)]
LP#1942220: link to new PO interface from provider PO table

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: oops
Galen Charlton [Thu, 9 Dec 2021 22:42:58 +0000 (17:42 -0500)]
LP#1942220: oops

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: more post-upload link fixes
Galen Charlton [Thu, 9 Dec 2021 22:08:03 +0000 (17:08 -0500)]
LP#1929749: more post-upload link fixes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: fix link to new PO interface after upload
Galen Charlton [Thu, 9 Dec 2021 22:05:46 +0000 (17:05 -0500)]
LP#1929749: fix link to new PO interface after upload

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1929749: route to new picklist interface after upload
Galen Charlton [Thu, 9 Dec 2021 22:01:43 +0000 (17:01 -0500)]
LP#1929749: route to new picklist interface after upload

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: move UploadComponent to a new module
Galen Charlton [Thu, 9 Dec 2021 22:00:24 +0000 (17:00 -0500)]
LP#1942220: move UploadComponent to a new module

Otherwise, making it part of PicklistModule caused
issues with LineitemModule using it as well

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: change how linking to Dojo interfaces is handled
Galen Charlton [Thu, 9 Dec 2021 21:45:24 +0000 (16:45 -0500)]
LP#1942220: change how linking to Dojo interfaces is handled

This patch takes out the notion that the Angular acquisitions
interface is experimental in favor of a different setting that
controls whether or not the Angular PO summary links to the
legacy PO interface.

IOW, this change pushes the user towards using the new interfaces
and dipping into the old ones only one necessary.

Additional links (e.g., to the legacy LI worksheet page) could be
readily added as needed.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: change text from "lineitem" to "line item"
Galen Charlton [Thu, 9 Dec 2021 20:45:17 +0000 (15:45 -0500)]
LP#1942220: change text from "lineitem" to "line item"

"lineitem" and its variants much more commonly split into
two words for human-readable text

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement Link Invoice
Galen Charlton [Thu, 9 Dec 2021 20:33:38 +0000 (15:33 -0500)]
LP#1942220: implement Link Invoice

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: show invoice links only if order was activated
Galen Charlton [Thu, 9 Dec 2021 19:40:59 +0000 (14:40 -0500)]
LP#1942220: show invoice links only if order was activated

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: remove the 'Acquisitions (Experimental)' menu
Galen Charlton [Thu, 9 Dec 2021 19:04:33 +0000 (14:04 -0500)]
LP#1942220: remove the 'Acquisitions (Experimental)' menu

Rather than treating Angular Acquisitions as a purely experimental
interface, treat it as the new default that has an option to
link back to the Dojo interfaces.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: display the select LIs on apply claim policy dialog
Galen Charlton [Thu, 9 Dec 2021 17:04:53 +0000 (12:04 -0500)]
LP#1942220: display the select LIs on apply claim policy dialog

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: add missed files for previous commit
Galen Charlton [Thu, 9 Dec 2021 17:00:27 +0000 (12:00 -0500)]
LP#1942220: add missed files for previous commit

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: implement Export Single Attribute list
Galen Charlton [Thu, 9 Dec 2021 16:59:27 +0000 (11:59 -0500)]
LP#1942220: implement Export Single Attribute list

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: tweaks to order identifer handling
Galen Charlton [Wed, 8 Dec 2021 23:41:04 +0000 (18:41 -0500)]
LP#1942220: tweaks to order identifer handling

- sort order ident types alphabetically
- set 024 ind1 correctly when creating a brief record

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
3 years agoLP#1942220: (perl) set 024 ind1 correctly when applying UPC as order identifier
Galen Charlton [Wed, 8 Dec 2021 23:40:21 +0000 (18:40 -0500)]
LP#1942220: (perl) set 024 ind1 correctly when applying UPC as order identifier

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: changes to direct charge form
Galen Charlton [Wed, 8 Dec 2021 23:01:36 +0000 (18:01 -0500)]
LP#1942220: changes to direct charge form

- can now edit charges on a pending order
- direct charges are now read-only on an activated order

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: implement 'Load Bibs and Items'
Galen Charlton [Wed, 8 Dec 2021 22:41:15 +0000 (17:41 -0500)]
LP#1942220: implement 'Load Bibs and Items'

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: teach the acq MARC import component new tricks
Galen Charlton [Wed, 8 Dec 2021 22:40:07 +0000 (17:40 -0500)]
LP#1942220: teach the acq MARC import component new tricks

Specifically, how to acted in a mode that gathers record
import parameters to drive PO and LI asset creation

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: eg-item-location-select: do more unbreaking of contextOrgId
Galen Charlton [Wed, 8 Dec 2021 21:54:29 +0000 (16:54 -0500)]
LP#1942220: eg-item-location-select: do more unbreaking of contextOrgId

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: default new copy's owning branch to WS OU
Galen Charlton [Wed, 8 Dec 2021 15:59:28 +0000 (10:59 -0500)]
LP#1942220: default new copy's owning branch to WS OU

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: tweaks to the copies inputs
Galen Charlton [Wed, 8 Dec 2021 15:56:14 +0000 (10:56 -0500)]
LP#1942220: tweaks to the copies inputs

- OU selector now limited to locations where user has
  CREATE_PICKLIST or CREATE_PURCHASE_ORDER
- distribution formula combobox now sorts by name
- circ modifier combobox now supports empty click

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: link shelving location selector to OU selector
Galen Charlton [Wed, 8 Dec 2021 15:42:41 +0000 (10:42 -0500)]
LP#1942220: link shelving location selector to OU selector

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: eg-item-location-select: fix use of contextOrgId
Galen Charlton [Wed, 8 Dec 2021 15:42:20 +0000 (10:42 -0500)]
LP#1942220: eg-item-location-select: fix use of contextOrgId

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: implement 'Add Items To Selected Lineitems'
Galen Charlton [Tue, 7 Dec 2021 23:43:18 +0000 (18:43 -0500)]
LP#1942220: implement 'Add Items To Selected Lineitems'

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: format fund labels correctly in the batch copy form
Galen Charlton [Tue, 7 Dec 2021 21:51:09 +0000 (16:51 -0500)]
LP#1942220: format fund labels correctly in the batch copy form

While caching the selected funds is good to reduce unnecessary
pcrud queries, doing so breaks formatting the fund label
in the comboboxes consistently without this patch.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: add confirmation step to deleting LIs
Galen Charlton [Tue, 7 Dec 2021 19:25:42 +0000 (14:25 -0500)]
LP#1942220: add confirmation step to deleting LIs

- also tidy up when the action is avaialble
- also tidy up handling of selected LIs post-deletion
- also reload the page only once
- add TODO about decreasing parallelism
- TODO: toss up spinner?

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: teach LI title sort to ignore common articles
Galen Charlton [Tue, 7 Dec 2021 17:41:18 +0000 (12:41 -0500)]
LP#1942220: teach LI title sort to ignore common articles

Also move a couple convenience methods related to LI sorting
to LineitemService

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: bump up hardcoded LI retrieval limit back to 10000
Galen Charlton [Tue, 7 Dec 2021 17:08:13 +0000 (12:08 -0500)]
LP#1942220: bump up hardcoded LI retrieval limit back to 10000

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: extend the active LI sort order to PO printing
Galen Charlton [Tue, 7 Dec 2021 16:56:25 +0000 (11:56 -0500)]
LP#1942220: extend the active LI sort order to PO printing

Note that this reimplements the sorting client-side.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: wording tweaks
Galen Charlton [Tue, 30 Nov 2021 22:40:02 +0000 (17:40 -0500)]
LP#1942220: wording tweaks

- "Copy Location" => "Shelving Location"
- "Zero-Copy" => "Zero-Item"

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: improvements to cancel dialog
Galen Charlton [Tue, 30 Nov 2021 22:36:26 +0000 (17:36 -0500)]
LP#1942220: improvements to cancel dialog

- add recordType parameter so that wording can be adjusted
  based on what is to be cancelled
- expand the wording to make it (hopefully) crystal clear
  what to do
- show all cancel reasons upon combobox click

TODO: pluralization for the more-than-one-LI case

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1942220: tweak LI actions around viewing/updating items
Galen Charlton [Tue, 30 Nov 2021 16:54:42 +0000 (11:54 -0500)]
LP#1942220: tweak LI actions around viewing/updating items

- Added "Update Barcodes" as a new LI action that opens the
  item attributes editor
- Changed the "Holdings Maintenance" LI action to open the
  record holdings view page rather than spawning the item
  attributes editor, making it match the behavior of the
  "Holdings Maint." LI action in the Dojo interface.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
4 years agoLP#1929749: point to new PO interface if creating a PO
Galen Charlton [Tue, 30 Nov 2021 16:18:12 +0000 (11:18 -0500)]
LP#1929749: point to new PO interface if creating a PO

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>