LP1904036 Verify patron credentials

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 billing statement detail grids

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Grid toolbarLabel option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 billing statement

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 billing statement

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 billing statement

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 adjust to zero, refunds

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 void all billings action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billing and more

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Payment receipts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills, Current admin UI sample data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Option to hide Holds grid popup dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing / payments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 current bills receipt

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron tab counts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 open circ exists dialog; billing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing / payments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing; credit card form

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills wireframing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Update stats after checkout; quite warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 place new hold button/action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron summary pref name; penalties

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 print/copy patron address; summary styling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings and more

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Alert dialog honors dialogTitle when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew with due date

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew all; initial events override dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew; Batch Checkout/Renew; shared circ components

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims never checked out

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned; circ notices

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page; resolver service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Move precat dialog to shared circ service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron noncat count display

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark items lost

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark missing; initial checkin api

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark damaged; canceled holds display repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Edit due date; styling overdues

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out: printing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Noncat batch retrieval API

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular login now handles routeTo

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 checkout continued; grid actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat checkouts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input followup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input; submit on enter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1958573 PMC messages created by action triggers not patron-visible

This adds a missing patron-visibility flag to messages created for
the patron message center by notification action triggers (when
using grouped events).

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Staff banner added to the staff portal local administration page.

Signed-off-by: Shula Link <slink@gchrl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1956790 Support applying item alerts via templates

Fixes an issue where item alerts contained within copy templates failed
to apply when using the new Angular holdings editor.

Testing note: if you add an item alert by applying a template, it currently
will not be displayed in the item alerts dialog until you save the item.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1980257: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1980257: (follow-up) add balance owed to the pending grid as well

Doing this maintains symmetry between the user bucket grid
and the pending user grid and supports workflows where a staff
member may wish to check the patron balance before adding a
user to a bucket.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1980257: Patron bucket money summary

This patch adds the patron's balance owed as a column
in the user bucket grid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1975879 Holdings editor allows owning lib changed

A new edit (pencil) icon appears to the left of the first call number
field in the 'holdings' tab of the copy edit.  When clicked, the user has
a chance to enter a new org unit value to act as the owning lib of the
affected call number.

If the "Change Circ Lib When Owning Lib Changes" preference is set, then
any copies linked to the affected call number within the current edit
session will have their circ libs updated to match the new owning lib of
the call number.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1981095: fix deletion of item tags in Angular item attributes editor

This patch fixes several bugs that prevent item tags from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that tags can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Tags for a single
    selected item.
[5] Verify that tags can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item tag. Verify that tags can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Tags for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1959716 Follow up to allow managing/deleting in-place copies

Fixes a thinko which prevented management / deletion of existing copies
in the copy editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1955065 Item note dialog close value repairs

Handle cases where the copy note dialog is closed via Cancel actions and
emits no data.

Also be sure the dialog emits consistently shaped data when it does emit
data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1955065: fix deletion of item notes in Angular item attributes editor

This patch fixes several bugs that prevent item notes from
being correctly deleted by the Angular item attributes editor.

To test
-------
[1] Apply patch.
[2] Edit a single item in the Angular item attributes editor.
[3] Verify that notes can be added and deleted.
[4] In Holdings View, choose Add/Manage Item Notes for a single
    selected item.
[5] Verify that notes can be added and deleted;
[6] Repeat steps 4 and 5 for a different item after successfully
    deleting an item note. Verify that notes can be added and deleted.
[7] In Holdings View, choose Add/Manage Item Notes for multiple
    selected items.
[8] Verify that ntoes can be added to the selected items.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1965448 Holdings edit enforce required stat cats

Required copy stat cats require a value when creating or editing
copies.

Switching between tabs in the copy editor no longer alert the user when
a change is pending, since it may be necessary to hop between tabs to
resolve issues.  Pending changes alerts will still appear when leaving
the page if needed.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1959716: (follow-up) extend fix to item tags

To test this patch series:

[1] Set the Angular holdings and item attributes editor to
    unified mode.
[2] Create a new call number and item. Note that the buttons
    to create item tags, item alerts, and item notes do not work.
[3] Apply the patch and repeat step 2.
[4] This time, adding tags, alerts, and notes in the course of
    creating a new item should work.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1959716 Volcopy Add Notes/Alert to New Copies

Fixes an issue where creating new copy alerts / notes failed for brand
new copies.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1976557: (follow-up) fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1976557: No Holdings View For the Pre-cat Bib

Don't waste the time or resources to load every pre-cat in the system when
there isn't much you can do with them anyway.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1978839 Holds Pull List - Library Shortnames

Display shortnames instead of IDs for the Requesting Library
and Selection Library columns in the Pull List grid in the
staff client.

Test:
1. Circulation->Pull List for Hold Requests
2. Select OU with holds to pull or place an item hold on an
   available item and select the owning OU
3. Add the Requesting Library and Selection Library columns
   (note IDs are displayed)
5. Apply patch, rebuild Angular, rebuild Perl
6. Refresh and re-add columns (note shortnames are displayed)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

lp1978049: add ng lint to github actions

Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1951642 Self-registration DOB autopopulating date

This removes the autopopulation of the dob date in the OPAC's
self-registration page. Note that the issue applies only to
the Bootstrap OPAC, not TPAC.

To test:

1. In library settings turn on "Allow Patron Self-Registration" and "Show dob
field in patron registration". "Require dob field on patron registration"
can also be turned on to test that option.

2. Go to the "Request Library Card" page of the opac and notice that the
dob field is populated with today's date.

3. Apply the patch.

4. Check the dob field again and notice that it is no longer autopopulated.

5. Create a few registrations with dob dates and with no dob dates to confirm
that the field works.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1950166 TPac: Self-registration form won't submit with blank DOB

Adds a check for a blank value in the DOB validation script. Note
that the issue is present in TPAC, not the Bootsstrap OPAC.

To test:
1. Confirm "Require dob field on patron registration" is not set or set to False.
2. Confirm "Show dob field on patron registration" is true.
3. Confirm "Allow Patron Self-Registration" is set to true.
4. Try to register a patron in the TPAC with DOB blank.
5. Apply patch.
6. Try to register a patron in the TPAC with the DOB blank.
7. Try to register a patron with Invalid DOB input.
8. Try to register a patron with valid DOB input.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1950514: TPac hold groups table displays incorrect column names on small screens.

This fixes the incorrect display of column names in the hold groups table
in the tpac. Previously the table would display names for the hold history
table.

To test:
1. create an opac visible hold group and assign a patron to the group.
2. login to the TPac as the patron assigned to the group.
3. view hold groups and make the browser screen as small as possible.
4. notice on the smallest screen the headers for the table are incorrect.
5. apply the patch and view the headers.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1942647: (follow-up) fix lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1851884: eg-fm-record-editor: avoid fetching all rows from linked table

This patch ensures that Angular FM record editor dialogs do
not attempt to fetch all rows from target table when constructing
a combobox for a linked field.

In particular, it makes the following changes:

* If a custom template for a field is supplied, use that by
  default rather than _also_ creating a data source for
  a combobox.
* Rather than creating its own data source for a linked field,
  the FM record editor now uses the IDL mode of eg-combobox. By doing
  this, we use eg-combobox's default data source, which limits
  record retrievals to 100 rows max. Also, empty-click is now
  enabled by default.
* When attempting to identify a selector for an IDL class, if
  the class doesn't define a selector and doesn't have a field named
  'name', but its primary key is a text field, use the primary
  key as the selector.

To test
-------
[1] Create a few thousand empty bib record buckets in your test database.
[2] Edit a carousel under Local Administration; note that it can
    take some time for the dialog to load.
[3] Apply the patch and repeat step 2. This time, the carousel edit modal
    should open instantly.
[4] Test various Angular record editor modals to confirm that they behave
    as expected. For example:

    * The allocate to fund dialog in Fund Administration, in particular
      to verify that only active funds show up.
    * The assign user to course modal, to verify that searching is done
      by course number, not name.
    * Filter Dialog Set editor under /eg2/en-US/staff/admin/local/config/filter_dialog_filter_set
      to verify that the drop down for the creator doesn't fetch
      all patrons. (Note that this is an artificial example).

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP#1945385: use eg-admin-page for circ limit sets admin UI

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1932203: serialize requests on Edit Due Date in Items Out tab

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1942647 Provide Warning when deleting Term linked to Courses

- Separates out Course Term Grid to its own component
- Adds retrieval service function for Course/Term Maps based on Term ID
- Displays Confirmation dialog when deleting terms on the term grid if term is mapped to a course

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-list.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-reserves.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/course-reserves/course-term-grid.component.ts
modified:   Open-ILS/src/eg2/src/app/staff/share/course.service.ts

Signed-off-by: Beth Willis <willis@noblenet.org>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

Docs: fix display error

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>