Bill Erickson [Tue, 17 Jul 2018 17:06:13 +0000 (13:06 -0400)]
LP#
1779158 Initial match set UI
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 16 Jul 2018 20:28:49 +0000 (16:28 -0400)]
LP#
1779158 Import item views
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 16 Jul 2018 20:26:49 +0000 (16:26 -0400)]
LP#
1779158 Import item views
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 16 Jul 2018 15:01:16 +0000 (11:01 -0400)]
LP#
1779158 Bib trash groups; show error detail
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 16 Jul 2018 14:56:52 +0000 (10:56 -0400)]
LP#
1779158 Vandelay queue filters query repair
Fixes an issue with the queued record filters where filtering on import
errors lead to an invalid query, returning zero results.
Modify code to retain the import-errors portion of the from clause.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 21:53:47 +0000 (17:53 -0400)]
LP#
1779158 Export form focus improvements
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 21:31:30 +0000 (17:31 -0400)]
LP#
1779158 Vandelay export form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 16:44:45 +0000 (12:44 -0400)]
LP#
1779158 Merge/holdings profiles pages
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 16:10:26 +0000 (12:10 -0400)]
LP#
1779158 Display attrs page
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 16:10:17 +0000 (12:10 -0400)]
LP#
1779158 Display attrs page
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 12 Jul 2018 15:05:01 +0000 (11:05 -0400)]
LP#
1779158 Merge target selection improvements
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Wed, 11 Jul 2018 22:01:32 +0000 (18:01 -0400)]
LP#
1779158 Match overlay target support
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Wed, 11 Jul 2018 18:57:12 +0000 (14:57 -0400)]
LP#
1779158 Queue download option; add file-saver dep
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 10 Jul 2018 22:00:15 +0000 (18:00 -0400)]
LP#
1779158 persist keys, misc
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 10 Jul 2018 21:25:14 +0000 (17:25 -0400)]
LP#
1779158 Que rec matches; queue select shows all
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 10 Jul 2018 16:46:53 +0000 (12:46 -0400)]
LP#
1779158 Queued record page / marc html
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 10 Jul 2018 15:24:42 +0000 (11:24 -0400)]
LP#
1779158 Queue delete progress title
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 10 Jul 2018 15:00:05 +0000 (11:00 -0400)]
LP#
1779158 Ang vand add-to-bucket and delete-queue
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 9 Jul 2018 21:52:57 +0000 (17:52 -0400)]
LP#
1779158 Ang vand queue actions (import selected)
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 9 Jul 2018 16:53:35 +0000 (12:53 -0400)]
LP#
1779158 Ang vandelay import UI cont.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Fri, 6 Jul 2018 22:07:29 +0000 (18:07 -0400)]
LP#
1779158 Ang vandelay queue list page cont.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 5 Jul 2018 18:23:38 +0000 (14:23 -0400)]
LP#
1779158 Ang vandelay queue list page
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 5 Jul 2018 18:13:32 +0000 (14:13 -0400)]
LP#
1779158 Vandelay queue list API supports paging
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Tue, 3 Jul 2018 21:38:41 +0000 (17:38 -0400)]
LP#
1779158 Ang vandelay queue view cont.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 2 Jul 2018 22:16:40 +0000 (18:16 -0400)]
LP#
1779158 Ang vandelay starting queue view
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 2 Jul 2018 21:56:03 +0000 (17:56 -0400)]
LP#
1779158 Ang vandelay import / import action
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 2 Jul 2018 20:38:44 +0000 (16:38 -0400)]
LP#
1779158 Ang vandelay import create queue, process spool
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 2 Jul 2018 18:58:44 +0000 (14:58 -0400)]
LP#
1779158 Ang vandelay import form cont.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Mon, 2 Jul 2018 05:16:59 +0000 (01:16 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Sun, 1 Jul 2018 21:01:39 +0000 (17:01 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Sun, 1 Jul 2018 19:36:12 +0000 (15:36 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Sat, 30 Jun 2018 19:47:56 +0000 (15:47 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Sat, 30 Jun 2018 16:08:43 +0000 (12:08 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Sat, 30 Jun 2018 15:28:40 +0000 (11:28 -0400)]
LP#
1779158 Angular vandelay more import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Fri, 29 Jun 2018 22:30:15 +0000 (18:30 -0400)]
LP#
1779158 Angular vandelay starting import form
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Fri, 29 Jun 2018 17:30:18 +0000 (13:30 -0400)]
LP#
1779158 Angular vandelay service / startup data
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Bill Erickson [Thu, 28 Jun 2018 22:23:39 +0000 (18:23 -0400)]
LP#
1779158 Angular vandelay module, routing, stub modules
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jane Sandberg [Thu, 11 Oct 2018 01:37:59 +0000 (18:37 -0700)]
Docs: correcting inaccurate statement in action trigger docs
Remington Steed [Tue, 9 Oct 2018 14:35:00 +0000 (10:35 -0400)]
Docs: Update release notes version in consolidated manual
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Jane Sandberg [Mon, 8 Oct 2018 21:42:30 +0000 (14:42 -0700)]
Docs: adding info about testing action triggers
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Mon, 8 Oct 2018 21:37:30 +0000 (14:37 -0700)]
Docs: adding action/triggers to staff client admin docs
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Mon, 8 Oct 2018 21:36:48 +0000 (14:36 -0700)]
Docs: re-adding missing anchor to install instructions
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Bill Erickson [Mon, 17 Sep 2018 14:18:30 +0000 (10:18 -0400)]
LP#
1792658 Angular Evergreen favicon
Use the Evergreen favicon.ico in the Angular(6) application.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Bill Erickson [Mon, 6 Aug 2018 19:18:35 +0000 (15:18 -0400)]
LP#
1785681 Patron address copy to clipboard
Support copying formatted addresses to the clipboard in the browser
staff client, similar to the XUL client. Action is performed via a new
link in the addresses section (next to "print") in the patron summary
sidebar.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Tue, 11 Sep 2018 18:58:29 +0000 (14:58 -0400)]
LP#
1721139: apply proper date format in certain places
This patch ensures that the correct date format is used
to display dates in certain contexts in the web staff
client:
- patron bucket summary
- record bucket summary
- patron bucket 'View batch edits'
This has the side effect of fixing a problem where the batch
edit timestamps were not wrapped correctly in Firefox.
To test
-------
1. Using user buckets, make some batch changes on some patrons and roll
back some of those changes.
2. Using Firefox, click on the 'View Batch Edits' button.
3. Note that the times dispayed are formatted as raw
database timestamps
4. Note that the summary for the user bucket displays the
create time as a raw database timestamp.
5. Navigate to a record bucket and note that its create
time is displayed as a raw timestamp as well.
3. Apply patch.
4. Repeat steps 2-5; this time, the times should be displayed
using the correct date and time format.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Garry Collum [Thu, 21 Jun 2018 23:41:48 +0000 (19:41 -0400)]
LP#
1778083 Location, Floating, and Age Protect missing from Items Out
Adds columns for Location (Copy), Floating Group, and Age-based Hold
Protection to the items out grid.
To test.
1. View an items out screen to see that the Location, Floating Group,
and Age-based Hold protection columns are not available as options.
2. Apply the patch.
3. Edit some items and add definitions for Floating Group, and
Age-based hold protection.
4. Check out these items and other items that do not have a floating
group or age-based protection.
5. Display the Location, Floating Group, and Age-based Hold Protection
columns.
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Fri, 5 Oct 2018 20:41:04 +0000 (16:41 -0400)]
LP#
1770246: (follow-up) display the open-in-new-window/tab icon
Since the title links added by the previous patch intentionally open
the record in a new tab, display the corresponding icon to be
consistent with other interfaces.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Garry Collum [Fri, 1 Jun 2018 01:22:35 +0000 (21:22 -0400)]
LP#
1770246 Catalog linked title column in query and pending buckets
To mirror the Record Bucket View grid, this patch adds a title column
in the query and pending bucket tabs that links to the catalog record
of the title displayed. The catalog record is opened in a new tab, so
the query and pending data is not lost.
Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Jane Sandberg [Thu, 4 Oct 2018 18:53:59 +0000 (11:53 -0700)]
Docs: adding basic info about printing spine labels
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Tue, 2 Oct 2018 02:48:32 +0000 (19:48 -0700)]
Docs: Adding info about copy number
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Dan Wells [Thu, 27 Sep 2018 21:56:00 +0000 (17:56 -0400)]
Forward-port 3.1.6 upgrade script
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Thu, 27 Sep 2018 21:55:09 +0000 (17:55 -0400)]
Forward-port 3.0.12 upgrade script
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jane Sandberg [Wed, 26 Sep 2018 23:21:07 +0000 (16:21 -0700)]
Docs: adding another fix to the 3.1.6 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 26 Sep 2018 23:20:05 +0000 (16:20 -0700)]
Docs: adding another fix to the 3.0.12 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Mike Rylander [Mon, 27 Aug 2018 16:08:37 +0000 (12:08 -0400)]
LP#
1786987: Locale-less org tree cache object becomes stale
The autogen.sh script calls a function that flushes all org tree objects
cached by locale, but does not flush the one used when the locale is
unkown. This commit forces that flushing to occur.
berick: Definition of my $cache pushed up above first use.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Jane Sandberg [Wed, 26 Sep 2018 16:10:22 +0000 (09:10 -0700)]
Docs: Adding 3.1.6 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jane Sandberg [Wed, 26 Sep 2018 16:05:54 +0000 (09:05 -0700)]
Docs: Adding release notes for 3.0.12
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Remington Steed [Tue, 25 Sep 2018 18:54:20 +0000 (14:54 -0400)]
Docs: Clean up installation docs
- Remove redundant NodeJS section
- Relabel sections to distinguish between AngularJS and Angular steps
- Fix a few typos
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Dan Wells [Tue, 25 Sep 2018 17:04:11 +0000 (13:04 -0400)]
Translation updates - newpot
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Mon, 24 Sep 2018 21:33:12 +0000 (17:33 -0400)]
Translation updates - po files
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Remington Steed [Mon, 24 Sep 2018 21:23:45 +0000 (17:23 -0400)]
Docs: Remove old release notes files
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Remington Steed [Mon, 24 Sep 2018 21:14:39 +0000 (17:14 -0400)]
Docs: Add Upgrade Notes to release notes
This commit copies relevant sections of the release notes into the
Upgrade Notes section.
A few paragraphs are also reformatted into lines of appropriate length.
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Remington Steed [Mon, 24 Sep 2018 19:53:04 +0000 (15:53 -0400)]
Update Release Notes for 3.2-rc
Add new release notes. Also, slight reorganization to the
acknowledgements section (move organizations to appropriate section, fix
sorting of COOL, use consistent name for BC Libraries).
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Remington Steed [Mon, 24 Sep 2018 19:15:46 +0000 (15:15 -0400)]
Docs: Fix two minor errors in docs
- Fix an AsciiDoc heading syntax error
- Fix a grammatical error (repeated "the")
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Bill Erickson [Mon, 24 Sep 2018 20:19:33 +0000 (16:19 -0400)]
LP#
1794176 Avoid capturing grid cell tooltip/display values
Remove the grid-tooltip logic that captured the cell content into a
template-level variable so the content only needed to be generated once
for both the tooltip and cell display. This logic fails to handle cases
where the cell content is dynamic, typically the result of row
attributes being modified via external process.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Galen Charlton [Mon, 24 Sep 2018 17:56:09 +0000 (13:56 -0400)]
LP#
1789442: turn of Perl taint-checking on 14-OpenILS-Utils.t
This works around a bug in DateTime::TimeZone 1.63
<https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=737265> that
causes one of the new tests to spuriously fail on Ubuntu 14.04 LTS.
As the comment indicates, taint checking is not typically enabled
when running Evergreen, but we may want to consider changing
that should tuits arise.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Mon, 24 Sep 2018 17:55:39 +0000 (13:55 -0400)]
LP#
1789442: restore column allocation for barcode input
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 21 Sep 2018 19:23:11 +0000 (15:23 -0400)]
LP#
1789442: fix editing due date of hourly loans in web staff
This patch fixes a bug where editing the due date of an hourly
loan would result in the time portion always getting set to 00:00.
To test
-------
[1] Set up some daily and hourly loans in your database.
[2] Apply the patch.
[3] From the items out page, edit the due date for one or
more hourly loans. Verify that the resulting due date
is set correctly.
[4] From the items out page, edit the due date for some
daily loans and verify correctness. In particular,
verify that the resulting due date is /not/ the
following day if testing in time zones in the Americas.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 21 Sep 2018 18:58:47 +0000 (14:58 -0400)]
LP#
1552778: add timepicker to webstaff checkout page
This patch adds a timepicker to go along with the datepicker
if the operator invokes the option to set a specific due
date.
To test
-------
[1] Arrange circ policies to have both hourly and daily loans.
[2] Apply the patch.
[3] Check out an item for an hourly loan. Verify that the
due date and time is per policy.
[4] Check out an item for a daily loan. Verify that the
due date is per policy.
[5] Check out an item for an hourly loan, but set a specific
due date and time. Verify that the due date and time matches
the selected value.
[6] Check out an item for a daily loan, but set a specific
due date. Verify that the due date matches the selected
value; note that any time component is ignored since
for daily loans the time gets normalized to 23:59.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 21 Sep 2018 18:30:01 +0000 (14:30 -0400)]
LP#
1552778: make clean_ISO8601 recognize 'Z' as a timezone specifier
Prior to this patch, clean_ISO8601 would ignore 'Z' as a timezone
specifier (e.g., '2018-09-21T15:34:21Z') and treat it as if the
timestamp were in the server's time zone, leading to incorrect
results (e.g., '2018-09-21T15:34:21-04:00') unless user, client,
and server all happen to be in UTC+0. In particular, this allows
date strings emitted by the JavaScript Date object's toISOString()
method to be correctly parsed, as those strings invariably use
'Z' as the timezone specifier.
To test
-------
[1] Apply patch.
[2] Verify that regression test in t/14-OpenILS-Utils.t passes.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 21 Sep 2018 18:04:24 +0000 (14:04 -0400)]
LP#
1552778: add perldoc and unit tests for clean_ISO8601
To test
-------
[1] Apply patch.
[2] Verify new tests in t/14-OpenILS-Utils.t pass.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Galen Charlton [Fri, 21 Sep 2018 15:00:25 +0000 (11:00 -0400)]
LP#
1552778: copy some date/time utils from OpenSRF
As preparation for subsequent bugfixes, this patch
copies several date/time routines from OpenSRF::Utils
to a new module, OpenILS::Utils::DateTime. Specifically,
the routines copied over are:
* clean_ISO8601() (renaming of the OpenSRF cleanse_ISO8601)
* gmtime_ISO8601()
* interval_to_seconds()
* seconds_to_interval()
This move will allow us to fix bugs in this core routines
without requiring a mandatory OpenSRF upgrade. Furthermore,
with the exception of interval_to_seconds() (and in only one
place), none of those routines are used by OpenSRF itself.
To test
-------
[1] Apply the patch.
[2] Verify that unit tests pass.
[3] Verify that all Perl services start correctly.
[4] Verify that date/time and interval calculations continue
to work as expected, particularly in circulation.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Sun, 23 Sep 2018 03:08:28 +0000 (23:08 -0400)]
LP#
1793857: Restore Copy Current Row
In our effort to consistently call items/copies items, we accidentally replaced
the action "Copy Current Row" with "Item Current Row." This branch restores
the correct language.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Mike Rylander [Wed, 19 Sep 2018 15:16:39 +0000 (11:16 -0400)]
LP#
1791335: Retain stat cats on item transfer
For some reason, parts were protected during item transfer, but stat cats were
not. This commit protects them by fleshing stat cat entries in the outer
item transfer method.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Galen Charlton [Fri, 21 Sep 2018 20:46:17 +0000 (16:46 -0400)]
LP#
1791340: expand on comment about backdated checkin times
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Dan Wells [Fri, 21 Sep 2018 14:45:59 +0000 (10:45 -0400)]
LP#
1791340 Webstaff: Don't backdate when we're not
There was code in the webstaff checkin interface which attempted to
remove the backdate parameter when it wasn't needed, as its mere
presence has a negative effect on the checkin process. This fail-safe
was not working, however.
Instead, let's build on the same check function used for the display,
so we can be more sure that if the user doesn't see that they are
backdating, the interface will not treat it as a backdate, and
vice-versa.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Galen Charlton [Thu, 20 Sep 2018 22:26:47 +0000 (18:26 -0400)]
LP#
1745427: account for change in prediction patterns
This patch fixes a bug in the web staff client where changing
the active prediction pattern for a subscription would not
reset the base issue when predicting the next run of issues.
To test
-------
1. Set up a subscription in the web staff client with a prediction
pattern (e.g., monthly). Predict some issues.
2. Create/select a new prediction pattern for a new publishing schedule,
e.g., quarterly.
3. Activate the new pattern and deactivate the old pattern.
4. Click Predict New Issues.
5. Enter in the new publication date/enumerations/chronology as needed.
6. Enter a prediction count and select Save. Note that new issues
appear to be based on the previous pattern.
7. Apply the patch, delete the issues created in step 6, then repeat
steps 4-6. This time, new issues should be created using the new
prediction pattern.
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 19 Sep 2018 14:26:04 +0000 (10:26 -0400)]
LP#
1781480: Include group owner ancestor badges
This commit lightly refactors the badge org logic and includes the ancestors
of location group owners in the list of badge orgs, instead of only the direct
owners.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Mike Rylander [Mon, 17 Sep 2018 15:33:29 +0000 (11:33 -0400)]
LP#
1781480: Closures remeber values in subtle ways...
... and we must take care to avoid that. This commit forces a state variable
to be statically assigned an empty list rather than depending on the idiomatic
undef to vivicate an empty list. This is important for all OpenSRF methods,
and manifests here as a search "remembering" a previously chosen location
group. A comment to that point is included for our future selves.
The core probably arises from the fact that, in the end, OpenSRF methods are
generated closures.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jeanette Lundgren <jlundgren@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Mike Rylander [Fri, 3 Aug 2018 21:25:33 +0000 (17:25 -0400)]
LP#
1732761: Chain the promises to avoid races
It looks like there's a race condition gathering locations for larger copy
sets. Here we chain the promises to remove the race by serialization.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Mike Rylander [Mon, 9 Jul 2018 20:31:50 +0000 (16:31 -0400)]
LP#
1732761: Fetch locations immediately for display
This commit closes a race condition where location labels cannot be rendered
for the "multiple locations" widget because fetching them takes longer than
the initial render of the attribute editor.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Mike Rylander [Tue, 3 Jul 2018 20:57:27 +0000 (16:57 -0400)]
LP#
1732761: Batch item edit and multiple values per field
Previous to this commit, the display of multiple different values for a field
in the item attribute editor was simply to display no value. Here we add a UI
component that presents the list of unique values, the number of selected
copies that use each value, and the ability to select just those copies using
a particular value by clicking on the desired value.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/cat/volcopy/index.tt2
Open-ILS/src/templates/staff/cat/volcopy/t_attr_edit.tt2
Jason Boyer [Thu, 13 Sep 2018 11:39:06 +0000 (07:39 -0400)]
LP1792371: Fix De-select Whole Page Action
When using the checkbox to select or de-select the
entire page of results, the de-select action changes
the check and highlight states of the items on page
but doesn't actually remove the records from the
basket. This branch corrects that so that you can
select and de-select the entire page of results
and your basket contents are what you would expect.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Thu, 20 Sep 2018 14:05:28 +0000 (10:05 -0400)]
LP#
1783345: Make one more change in case
One button was missed when normalizing case in the add to bucket modal.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Sam Link [Tue, 31 Jul 2018 14:35:34 +0000 (10:35 -0400)]
Bug #
1783345 - Normalized add to bucket modal
The text cases in the add to bucket modal have been normalized to
sentence case.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Sun, 16 Sep 2018 22:48:59 +0000 (18:48 -0400)]
LP#
1792484 Patron preferred name in hold shelf dialog
Display the patron preferred name in addition to the primary name in the
route-to-holds-shelf dialog. As with primary name, preferred name is
hidden when an alias is applied.
To test
[1] Add a primary first, middle, and/or last name value to a patron.
[2] Place a hold for the patron with the pickup library matching the
login library.
[2] Capgture the hold via the Checkin interface (instead of the hold
capture interface) and note the preferred name display.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Library Tech [Tue, 18 Sep 2018 20:12:57 +0000 (16:12 -0400)]
Translation updates - newpot
Signed-off-by: Library Tech <libsysadmin@calvin.edu>
Kathy Lussier [Wed, 22 Aug 2018 23:46:10 +0000 (19:46 -0400)]
LP#
1538691: Release notes entry for consistent terminology
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kathy Lussier [Wed, 22 Aug 2018 20:48:43 +0000 (16:48 -0400)]
LP#
1538691: More changes to terminology
For more consistency: Changing all staff client instances of Copy Location to
Shelving Location. We also replace Volume with Call Number and use Holdings
for a combination of copies/volumes. Also replacing the 'Add Copies' option
on the bib record page with 'Add Holdings' as was previously discussed on
the open-ils-general list.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Kathy Lussier [Wed, 1 Aug 2018 17:14:32 +0000 (13:14 -0400)]
LP#
1538691: Use items instead of copies
For better consistency for the terms used in the client, let's use items instead
of copies, which was the preference of most people who provided feedback on bug
1538691.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Conflicts:
Open-ILS/src/templates/staff/cat/catalog/t_holds.tt2
Open-ILS/src/templates/staff/cat/item/t_list.tt2
Open-ILS/src/templates/staff/cat/item/t_summary_pane.tt2
Open-ILS/src/templates/staff/circ/holds/t_shelf_list.tt2
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Bill Erickson [Sun, 16 Sep 2018 23:28:11 +0000 (19:28 -0400)]
LP#
1792482 My OPAC settings preferred name field
Adds a new row to the patron account preferences page for Preferred
Name. The field only displays when a preferred first, middle, or last
value is present and follows the same display logic as preferred names
in the staff client, where first and last fall-through to the primary
name.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Sun, 16 Sep 2018 23:25:44 +0000 (19:25 -0400)]
LP#
1792482 Only require first/last in pref name display
When displaying a patrons preferred name, always show a value for first
and last name, starting with the preferred name and defaulting to the
primary name, but only show values for prefix, middle name, and suffix
when a preferred variant is applied.
This avoids scenarios where patrons use their middle name as their first
name, with no preferred middle name applied, resulting duplicate
first/middle names displaying.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Kathy Lussier [Tue, 18 Sep 2018 18:53:47 +0000 (14:53 -0400)]
LP#
1787274: Stamping upgrade script for no dupe transits
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Tue, 18 Sep 2018 15:21:26 +0000 (11:21 -0400)]
LP#
1787274 One active transit pgtap tests
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Mon, 17 Sep 2018 22:16:42 +0000 (18:16 -0400)]
LP#
1787274 Active copy transit unique constraint
Adds constraint triggers to action.*transit_copy tables to prevent
creation of new transits for a copies when an existing transit of any
type exists for the copy with a NULL dest_recv_time and cancel_time
values (i.e. an open transit).
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Mon, 17 Sep 2018 22:16:28 +0000 (18:16 -0400)]
LP#
1787274 Prevent multiple active copy checkins
In the staff client checkin service, track which copies are currently
in-flight to the checkin API call and prevent additional checkin API
calls for any copy that is currently in flight.
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Jane Sandberg [Tue, 18 Sep 2018 18:28:55 +0000 (11:28 -0700)]
Docs: LP1793184 adding to the 3.2 release notes
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Jason Boyer [Thu, 21 Jun 2018 19:57:41 +0000 (15:57 -0400)]
LP1735816: Delete Copy Notes in the Web Client
A combination of calling convention errors and
template picky-ness prevented the deletion of
copy notes in the web client. This patch returns
that ability.
Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Amy Constantino <aconstantino@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Chris Sharp [Thu, 13 Sep 2018 19:26:46 +0000 (15:26 -0400)]
LP#
1745610 - Add release notes for hold targeter script change.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Chris Sharp [Thu, 13 Sep 2018 19:25:21 +0000 (15:25 -0400)]
LP#
1745610 - Update Makefile.am to reflect filename changes.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>