phasefx [Thu, 17 Sep 2009 14:29:45 +0000 (14:29 +0000)]
fix Unset for circ modifier in Item Attribute Editor
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14033
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 17 Sep 2009 01:54:21 +0000 (01:54 +0000)]
use Safe to protect against EVIL evals coming in from the outside world -- we share the environment into the Safe compartment using the name $current_environment
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14032
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 16 Sep 2009 03:38:25 +0000 (03:38 +0000)]
Following r14030, add the Makefile.am that is required for the Web portions.
(Oh, the perils of grepping for "^M" in 'svn stat' output...)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14031
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 16 Sep 2009 03:34:38 +0000 (03:34 +0000)]
Make building & installing the core components of Evergreen optional.
For now, this will be of most interest to those interested in building only
the staff client, say, on platforms where many of the dependencies of the
other components of Evergreen are not readily available. If you disable the
core components using configure, then dependency checking for those core
components is skipped and the staff client will be build and installed to
the desired location.
For example:
./autogen.sh
./configure --prefix=/openils --disable-core --disable-apache-modules
sudo make install
... will result in the Evergreen Web files, reporter, and staff client
being built and their respective server components installed in
/openils/var/web/...
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14030
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 15 Sep 2009 20:24:27 +0000 (20:24 +0000)]
completing previous commit (hold loop calcuation upgrade scripts)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14029
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 15 Sep 2009 20:23:42 +0000 (20:23 +0000)]
moving the the upgrade SQL scripts to an unversioned "upgrade" directory instead of one labeled for 1.6; adding the min-version insert for config.upgrade_log; adding views and an index for hold loop calculation
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14028
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 15 Sep 2009 17:32:10 +0000 (17:32 +0000)]
capturing ISBN value for pre-cat copies. setting checkin_workstation value at circ checkin time
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14027
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 15 Sep 2009 17:22:12 +0000 (17:22 +0000)]
spawn the right (horizontal versus vertical) patron display
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14026
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 15 Sep 2009 16:53:44 +0000 (16:53 +0000)]
Initial stab at modeling database changes as atomic mini-scripts for ease of development and eventual automatic upgrades
Created new upgrade directory for the 1.6 to trunk upgrade path.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14025
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 15 Sep 2009 16:25:41 +0000 (16:25 +0000)]
during inspect, return policy data even if the patron is not allowed to checkout without override
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14023
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 15 Sep 2009 16:12:42 +0000 (16:12 +0000)]
for now, don't allow inspect calls on copies that have not been created in the db, IOW pre-cat copies that have never circulated
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14021
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 15 Sep 2009 15:22:40 +0000 (15:22 +0000)]
Add checkin_workstation column to action.circulation.
For changing an existing table:
ALTER TABLE action.circulation
ADD COLUMN checkin_workstation INT
REFERENCES actor.workstation(id)
ON DELETE SET NULL
DEFERRABLE INITIALLY DEFERRED;
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14020
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Tue, 15 Sep 2009 14:41:28 +0000 (14:41 +0000)]
Add dummy_isbn column to asset.copy.
For changing an existing table:
ALTER TABLE asset.copy
ADD COLUMN dummy_isbn TEXT;
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14019
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 15 Sep 2009 02:48:41 +0000 (02:48 +0000)]
simple auth was buggy; due to chrome/remote restrictions in xulrunner 1.9? made separate chrome and remote versions, which is.. simpler :)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14018
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 14 Sep 2009 03:18:12 +0000 (03:18 +0000)]
fire a command event on checkboxes if persist_helper makes them checked. This handles checkboxes like Stack Subfields and Fast Item Add in the marc editor
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14017
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Sun, 13 Sep 2009 15:08:19 +0000 (15:08 +0000)]
Patch from Warren Layton for asciibetical ordering of services in z39.50 client. Native Catalog always goes to the top. Thanks!
---
The attached patch presents the Z39.50 targets in the Staff Client in
alphabetical order - a problem for us because we're starting to have
quite a few configured.
I'm not sure if this is the most elegant solution so feedback is
definitely welcome.
Cheers,
Warren
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14014
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Sun, 13 Sep 2009 02:26:10 +0000 (02:26 +0000)]
Added the const qualifier to several variables.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14013
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Sun, 13 Sep 2009 02:12:02 +0000 (02:12 +0000)]
In main: add the const qualifier to the classname variable.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14012
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 11 Sep 2009 13:27:20 +0000 (13:27 +0000)]
Patch from Ben Ostrowsky to add some comments to the z39 config table
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14010
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 11 Sep 2009 03:55:49 +0000 (03:55 +0000)]
Catch a few more common problems in settings-tester.pl:
* Check for <database> elements to ensure that Evergreen version of opensrf.xml is in place
* Check for oils_web.xml (required as of Evergreen 1.6)
Also, a bit of clean-up:
* Ensure all output is available to be gathered
* Short-circuit pointless database tests if the database connection fails
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14009
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 10 Sep 2009 18:21:04 +0000 (18:21 +0000)]
Patch from Joe Atzberger to repair fund delete param description
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14006
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 10 Sep 2009 16:21:33 +0000 (16:21 +0000)]
reverse-choro-date1 tiebreaker on search sorts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14005
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 21:15:08 +0000 (21:15 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14004
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:54:15 +0000 (20:54 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14003
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:53:54 +0000 (20:53 +0000)]
Moving styleguide files to the styleguide directory
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14002
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:34:34 +0000 (20:34 +0000)]
Adding first of a series of files to the styleguide section.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14001
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:31:19 +0000 (20:31 +0000)]
Moving styleguide folder into 1.6 docs repository.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@14000
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:29:35 +0000 (20:29 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13999
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:29:22 +0000 (20:29 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13998
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:29:07 +0000 (20:29 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13997
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:28:55 +0000 (20:28 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13996
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:27:56 +0000 (20:27 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13995
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:27:44 +0000 (20:27 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13994
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:27:35 +0000 (20:27 +0000)]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13993
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 20:27:21 +0000 (20:27 +0000)]
Creating parallel structure to website for Evergreen documentation. The next sets of files will reflect this.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13992
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 19:48:18 +0000 (19:48 +0000)]
Deleting unneeded files.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13991
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 19:47:50 +0000 (19:47 +0000)]
Deleting unneeded folder.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13990
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 19:47:37 +0000 (19:47 +0000)]
Deleting unneeded folder.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13989
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 19:47:22 +0000 (19:47 +0000)]
Removing folders so that trunk and the web have parallel structures.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13988
dcc99617-32d9-48b4-a31d-
7c20da2025e4
kgs [Wed, 9 Sep 2009 17:58:19 +0000 (17:58 +0000)]
reorganizing the hierarchy according to newfound wisdom
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13987
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 9 Sep 2009 13:16:52 +0000 (13:16 +0000)]
prevent negative paging display offset. added paginator to event def grids
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13985
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 8 Sep 2009 15:14:45 +0000 (15:14 +0000)]
turn off array expansion in DBD::Pg (new feature)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13983
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 21:21:40 +0000 (21:21 +0000)]
the Perl UUID module is not easily installed nor does it appear to be maintained. use UUID::Tiny instead
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13982
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 20:50:14 +0000 (20:50 +0000)]
there's no valid reason to call ingest from within the bib create/overlay code before the changes have been committed. removed embedded ingest logic and the no-ingest flags passed by everyone that uses them
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13980
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 20:42:18 +0000 (20:42 +0000)]
capture override as a var because using =~ in an arg list is non-good
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13974
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 20:17:14 +0000 (20:17 +0000)]
on marc record import, call ingest after the create xact has been committed
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13968
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 19:58:21 +0000 (19:58 +0000)]
plug baseWidgetValue setting for readOnly widgets back in with try/catch and comment. typo: state -> state()
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13966
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 19:26:08 +0000 (19:26 +0000)]
tighter control over displaying mark-recived and update-barcodes links in lineitem table. showing lineitem and PO state in the UI. Added PO activate routine which effectively marks a PO as 'ready to send to vendor'
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13964
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 17:25:10 +0000 (17:25 +0000)]
Loosened constraint on group penalty thresholds. You can now define threholds for the same group as long as they have a different context org unit
To Update:
ALTER TABLE permission.grp_penalty_threshold DROP CONSTRAINT penalty_grp_once;
ALTER TABLE permission.grp_penalty_threshold ADD CONSTRAINT penalty_grp_once UNIQUE (grp,penalty,org_unit);
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13961
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 15:23:54 +0000 (15:23 +0000)]
expose PO ID and PO name. plugged in option to change the PO name
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13959
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 4 Sep 2009 13:22:42 +0000 (13:22 +0000)]
assume 'yes' to fetching dependencies; reduce the verbosity of package downloads
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13958
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 08:50:22 +0000 (08:50 +0000)]
don't allow cut from or paste into readonly textboxes
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13957
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 08:39:45 +0000 (08:39 +0000)]
remote xul textboxes need context="clipboard" for proper cut/paste context menus
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13956
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 08:31:47 +0000 (08:31 +0000)]
allow us to switch to the alt item status view even with no items selected or scanned. Put focus in scanbox after toggle.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13955
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 08:24:36 +0000 (08:24 +0000)]
Alternate Item Status View
This is a work in process and I expect a lot of churn; I promise to I18N-ize it before it leaves trunk. Some stuff like Rolling Counter is more mock-up than anything; I have no idea what a Rolling Counter is. :D
The main notion here is that we want a quick toggle in Item Status for a denser view of information for a single item. Something less like the current Actions -> Show Item Details and more like the MARC View button in the Z39.50
interface. Note, you can scan in new barcodes while remaining in this view. In general, I want to move away from pop-up dialogs and interfaces in any case, and this sort of deck swapping is probably the future.
Feedback welcome.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13954
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 04:14:48 +0000 (04:14 +0000)]
Replacing persist mechanism with oils_persist.
This changeset isn't as scary as it looks, I promise. :-)
In XUL you can say, <element attribute1="foo" attribute2="bar" persist="attribute1 attribute2" />
and whenever those specified attributes change, the new values will be remembered the next time that element is loaded.
Problems with persist:
* No longer works with remote XUL in Xulrunner 1.9 series, only chrome. Mozilla did this for security reasons.
* Persist was tied to the window.location of each interface, so:
1) Settings would be lost on any "upgrade" that effectively changed the URL. For example, /xul/rel_1_2/server/ versus /xul/rel_1_4/server/
2) Some interfaces still make use of URL params, which effectively breaks persistance (because the URL changes constantly), and allows localstore.rdf to grow without limit (thanks to Jeff for noticing that last bit)
The solution:
* We renamed all occurances of @persist to @oils_persist, in case Mozilla changes the behavior again.
* We created a persist_helper() function and call it alongside font_helper() in the @onload for most windows (all that currently have elements using @oils_persist, at least)
persist_helper grabs all elements that have an @oils_persist, and constructs look-up keys based on the location.hostname, location.path, and element.id, and uses the Mozilla preference system to look for preferences with those
keys. These keys don't include URL parameters. For <checkbox> elements, an event listener is added that will set the preference whenever the element fires a command event (is checked or unchecked).
TODO:
* Tweak the keys further so that they're BUILD_ID (version) agnostic
* Add more event listeners to accomodate @oils_persist on other elements like window, splitter, and grippy.
* Possibly remove persist_helper (and font_helper) from the inline @onload, and load it through a window.addEventListener('load',function(){ persist_helper(); },false); in the global util overlay instead.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13953
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 03:00:39 +0000 (03:00 +0000)]
just another test.. want to see if multiple commits with git-svn come across as multiple changesets when going back to svn later
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13952
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 3 Sep 2009 03:00:37 +0000 (03:00 +0000)]
just a test
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13951
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Sep 2009 14:08:03 +0000 (14:08 +0000)]
leave the accesskey blank for this. R gets grabbed by the top-level search menu, so no need to advertise an accesskey that doesn't work
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13950
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 2 Sep 2009 13:39:27 +0000 (13:39 +0000)]
Simple in-client "activity log" interface (Admin -> Local Administration -> Work Log), and an example of such logging in the Checkout interface.
The log function itself is part of util/error.js. Example:
JSAN.use('util.error'); var logger = new util.error();
logger.work_log(
"Staff member Foo circulated item Bar to patron Baz", // The log message
// Additional Row data to pass to a util.list construct in the work log interface, which can be used in rendering columns, and accessed by actions acting on the list
{
au_id : 1, // Id for patron Baz; needed if you want the Retrieve Patron action to work with this log entry
acp_barcode : 'Bar', // Barcode of the item; needed if you want the Retrieve Item action to work with this log entry
}
);
TODO:
* Add logging statements to the Check In interface (complication there is that we don't have patron data, which would be useful) and Patron Registration
* Possibly add explicit columns for the type of action, the item involved, the patron involved, and the staff involved (to compliment Operator Change), rather than just Message and When.
* Add filtering support for action types
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13949
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 2 Sep 2009 12:53:56 +0000 (12:53 +0000)]
bypass hold fulfillment attempt when checking out pre/non cat items
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13948
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 2 Sep 2009 12:41:21 +0000 (12:41 +0000)]
capture the session handle before calling wait_complete
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13947
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Sep 2009 20:54:29 +0000 (20:54 +0000)]
use a separate pcrud instance for each object deletion so that a single instances isn't trying to create transactions while it's already in the middle of transactions, pending async responses. added some docs
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13945
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Sep 2009 20:34:20 +0000 (20:34 +0000)]
return the status of xact_commit from the commit wrapper
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13944
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Sep 2009 18:40:37 +0000 (18:40 +0000)]
added ability to clone event_def environment when an event_def is cloned
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13941
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Sep 2009 18:39:42 +0000 (18:39 +0000)]
pass the clone object to the postsubmit handler. allow caller to specificy post-clone handler. added some docs
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13940
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 1 Sep 2009 14:18:52 +0000 (14:18 +0000)]
calling widget.attr on readonly objects occaisonally results in errors from (as yet unexplained) dojo race condition. however, basewidgetvalue is not needed for readOnly widgets, since displaystring is used, so bypasss for now; use dojo.create
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13938
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 1 Sep 2009 05:13:24 +0000 (05:13 +0000)]
bury the old Local Admin interface, but don't remove it altogether yet
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13937
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 28 Aug 2009 22:01:42 +0000 (22:01 +0000)]
pass the ID not the bib object to the reporter.simple_rec_update stored proc
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13934
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 28 Aug 2009 15:51:52 +0000 (15:51 +0000)]
add the tsearch2 config tables for pg 8.1 and 8.2
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13933
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 27 Aug 2009 12:51:09 +0000 (12:51 +0000)]
Create tables acq.fiscal_calendar and acq.fiscal_year.
Create function acq.find_bad_fy to perform sanity checks
on acq.fiscal_year.
To add to an existing database:
CREATE TABLE acq.fiscal_calendar (
id SERIAL PRIMARY KEY,
name TEXT NOT NULL
);
CREATE TABLE acq.fiscal_year (
id SERIAL PRIMARY KEY,
calendar INT NOT NULL
REFERENCES acq.fiscal_calendar
ON DELETE CASCADE
DEFERRABLE INITIALLY DEFERRED,
year INT NOT NULL,
year_begin TIMESTAMPTZ NOT NULL,
year_end TIMESTAMPTZ NOT NULL,
CONSTRAINT acq_fy_logical_key UNIQUE ( calendar, year ),
CONSTRAINT acq_fy_physical_key UNIQUE ( calendar, year_begin )
);
CREATE OR REPLACE FUNCTION acq.find_bad_fy()
/*
Examine the acq.fiscal_year table, comparing successive years.
Report any inconsistencies, i.e. years that overlap or have
gaps between them.
*/
RETURNS SETOF RECORD AS $$
DECLARE
first_row BOOLEAN;
curr_year RECORD;
prev_year RECORD;
return_rec RECORD;
BEGIN
first_row := true;
FOR curr_year in
SELECT
id,
calendar,
year,
year_begin,
year_end
FROM
acq.fiscal_year
ORDER BY
calendar,
year_begin
LOOP
--
IF first_row THEN
first_row := FALSE;
ELSIF curr_year.calendar = prev_year.calendar THEN
IF curr_year.year_begin > prev_year.year_end THEN
-- This ugly kludge works around the fact that older
-- versions of PostgreSQL don't support RETURN QUERY SELECT
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Gap between fiscal years'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
ELSIF curr_year.year_begin < prev_year.year_end THEN
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Overlapping fiscal years'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
ELSIF curr_year.year < prev_year.year THEN
FOR return_rec IN SELECT
prev_year.id,
prev_year.year,
'Fiscal years out of order'::TEXT
LOOP
RETURN NEXT return_rec;
END LOOP;
END IF;
END IF;
--
prev_year := curr_year;
END LOOP;
--
RETURN;
END;
$$ LANGUAGE plpgsql;
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13931
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Mon, 24 Aug 2009 21:52:06 +0000 (21:52 +0000)]
misnamed dojo tab
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13928
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 24 Aug 2009 17:49:26 +0000 (17:49 +0000)]
Change constraint on acq.provider. Instead of making code unique
by itself, make code + owner unique.
To change an existing table:
ALTER TABLE acq.provider
DROP CONSTRAINT provider_code_key;
ALTER TABLE acq.provider
ALTER COLUMN code SET NOT NULL;
ALTER TABLE acq.provider
ADD CONSTRAINT code_once_per_owner
UNIQUE (code, owner);
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13926
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Mon, 24 Aug 2009 16:14:36 +0000 (16:14 +0000)]
Add columns to acq.purchase_order: order_date and name.
Name defaults to the id, as text.
Name should be unique for a given ordering_agency and order
date (truncated to midnight), but only where order_date
is not null.
To change an existing table, run the following
through psql:
-- Add new columns; populate name
ALTER TABLE acq.purchase_order
ADD COLUMN order_date TIMESTAMP WITH TIME ZONE;
ALTER TABLE acq.purchase_order
ADD COLUMN name TEXT;
UPDATE acq.purchase_order
SET name = id::TEXT;
ALTER TABLE acq.purchase_order
ALTER COLUMN name SET NOT NULL;
-- Name should default to the id. We can't do that with a DEFAULT
-- clause but we can do it with a trigger.
CREATE OR REPLACE FUNCTION acq.purchase_order_name_default () RETURNS TRIGGER
AS $$
BEGIN
IF NEW.name IS NULL THEN
NEW.name := NEW.id::TEXT;
END IF;
RETURN NEW;
END;
$$ LANGUAGE PLPGSQL;
CREATE TRIGGER po_name_default_trg
BEFORE INSERT OR UPDATE ON acq.purchase_order
FOR EACH ROW EXECUTE PROCEDURE acq.purchase_order_name_default ();
-- Name should be unique for a given ordering_agency and day, where
-- order_date is not null. We can't do that with a check constraint
-- because it would require a subquery, so we use a trigger.
CREATE INDEX acq_po_org_name_order_date_idx
ON acq.purchase_order( ordering_agency, name, order_date );
CREATE OR REPLACE FUNCTION acq.po_org_name_date_unique () RETURNS TRIGGER
AS $$
DECLARE
collision INT;
BEGIN
--
-- If order_date is not null, then make sure we don't have a collision
-- on order_date (truncated to day), org, and name
--
IF NEW.order_date IS NULL THEN
RETURN NEW;
END IF;
--
-- In the WHERE clause, we compare the order_dates without regard to time of day.
-- We use a pair of inequalities instead of comparing truncated dates so that the
-- query can do an indexed range scan.
--
SELECT 1 INTO collision
FROM acq.purchase_order
WHERE
ordering_agency = NEW.ordering_agency
AND name = NEW.name
AND order_date >= date_trunc( 'day', NEW.order_date )
AND order_date < date_trunc( 'day', NEW.order_date ) + '1 day'::INTERVAL
AND id <> NEW.id;
--
IF collision IS NULL THEN
-- okay, no collision
RETURN NEW;
ELSE
-- collision; nip it in the bud
RAISE EXCEPTION 'Colliding purchase orders: ordering_agency %, date %, name ''%''',
NEW.ordering_agency, NEW.order_date, NEW.name;
END IF;
END;
$$ LANGUAGE PLPGSQL;
CREATE TRIGGER po_org_name_date_unique_trg
BEFORE INSERT OR UPDATE ON acq.purchase_order
FOR EACH ROW EXECUTE PROCEDURE acq.po_org_name_date_unique ();
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13924
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 24 Aug 2009 15:23:49 +0000 (15:23 +0000)]
fire the fine generator at checkin time to assess required fines without a "missing fine" window
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13923
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 24 Aug 2009 14:38:46 +0000 (14:38 +0000)]
adjusting indentation for readability
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13921
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 24 Aug 2009 03:04:23 +0000 (03:04 +0000)]
in checkin interface, keep a running tally of fines/bills encountered
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13920
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 21 Aug 2009 18:33:36 +0000 (18:33 +0000)]
typo, reporter.reporter.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13915
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 21 Aug 2009 15:33:02 +0000 (15:33 +0000)]
more work on pcrud filter dialog. added filter option to autogrid. repaired faulty linked object caching in autogrid. with caching repaired, made linked grid cell data fetching synchronous to prevent excessive network requests (1st instance of an object is cached)
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13913
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Fri, 21 Aug 2009 12:38:47 +0000 (12:38 +0000)]
Change uniqueness constraint on acq.fund.code so as to
include org and year
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13912
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 21 Aug 2009 05:14:25 +0000 (05:14 +0000)]
beginnings of database replication helper scripts
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13911
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 20 Aug 2009 20:49:11 +0000 (20:49 +0000)]
set hold.shelf_time when item hits the shelf. updated hold notify event def to use shelf_time as the delay field
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13907
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 20 Aug 2009 20:13:12 +0000 (20:13 +0000)]
Another typo [sigh...]
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13906
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 20 Aug 2009 19:08:19 +0000 (19:08 +0000)]
Correcting a typo...
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13905
dcc99617-32d9-48b4-a31d-
7c20da2025e4
scottmk [Thu, 20 Aug 2009 19:04:18 +0000 (19:04 +0000)]
New column: action.hold_request.shelf_time
For altering an existing table:
ALTER TABLE action.hold_request
ADD COLUMN shelf_time TIMESTAMP WITH TIME ZONE;
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13904
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 20 Aug 2009 16:04:35 +0000 (16:04 +0000)]
beginning of a filter dialog for pcrud requests. users select columns and values from autofieldwidgets. the eventual goal is to provide filter options for autogrid
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13903
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 20 Aug 2009 15:34:25 +0000 (15:34 +0000)]
thinko in recent ingest fix
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13897
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Thu, 20 Aug 2009 15:00:46 +0000 (15:00 +0000)]
moving the simple-rec synchronization out of the DB for insert/update, and as a new trigger for "delete". This should finally address the ingest issues seen at some sites through the 1.4 series
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13894
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 20 Aug 2009 08:01:42 +0000 (08:01 +0000)]
Fix a horrible regression when renewing multiple items at once in Items Out.
Referencing loop variables in Javascript with closures is dangerous, so one strategy is to do something like this:
funcs = [];
for (var i = 0; i < my_array.length; i++ ) {
/* Bad */
// funcs.push( function(){ do_something( my_array[i] ); } );
/* Better */
funcs.push( function(safe_value){ return function(){ do_something( safe_value ); } }( my_array[i] ) );
}
In our case, our generated function accidentally referenced a value dependent on the loop variable instead of the corresponding argument of the function generator.
So we had multiple async renewal calls that depending on the timing, could try to renew the same item. To further add insult to injury, this could potentially put the database in an inconsistent
state wtih duplicate circulations.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13889
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 19 Aug 2009 15:58:51 +0000 (15:58 +0000)]
if the requested hook does not exist, gracefully back out
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13883
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Wed, 19 Aug 2009 14:10:52 +0000 (14:10 +0000)]
add lib shortname to overdue script xml output
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13879
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 19 Aug 2009 03:09:17 +0000 (03:09 +0000)]
use the appropriate label for show hold details in the context menu for the patron holds interface
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13874
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 19 Aug 2009 03:07:41 +0000 (03:07 +0000)]
Have the Place Hold function in the Patron Holds interface update said interface upon successful hold placement.
Also, rework how the Patron Holds interface encourages the summary sidebar (and the label under the Holds button) to refresh itself with regard to holds.
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13873
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 18 Aug 2009 18:57:12 +0000 (18:57 +0000)]
field_type may be null, check it
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13872
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 18 Aug 2009 17:45:49 +0000 (17:45 +0000)]
updated hold queue position code to consider all hold types that share a common potential copy
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13871
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 18 Aug 2009 17:44:22 +0000 (17:44 +0000)]
don't call ->content if there is no response
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13868
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 18 Aug 2009 15:48:39 +0000 (15:48 +0000)]
miscommunication on logic. if user != requestor, it's a staff hold
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13867
dcc99617-32d9-48b4-a31d-
7c20da2025e4
lmcfarland [Tue, 18 Aug 2009 15:32:17 +0000 (15:32 +0000)]
Added strings for staff hold column
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13866
dcc99617-32d9-48b4-a31d-
7c20da2025e4
lmcfarland [Tue, 18 Aug 2009 14:41:05 +0000 (14:41 +0000)]
Added staff hold column to holds table
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13865
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 18 Aug 2009 06:08:27 +0000 (06:08 +0000)]
alternate (and functional) clipboard context menus for fixed fields
git-svn-id: svn://svn.open-ils.org/ILS/trunk@13862
dcc99617-32d9-48b4-a31d-
7c20da2025e4