JBAS-1132 Self-register EGCatLoader API mods

* Upper-case most patron fields before inserting stage users.
* Normalize addresses
* De-duplicate addresses
* Handle KCLS-specific stat cats
* Honor opac.self_register.profile org setting

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Self-register SQL / IDL

* Adds card_style and ident_value2 columns
* Creates org setting opac.self_register.profile
* Sets values for org settings opac.self_register.profile,
  opac.allow_pending_user, and ui.patron.edit.au.ident_value2.show
* Modifies address IDL labels

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Orphan browse entry cleanup repair

Clean up subject entries, not author entries twice.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1264 Highline added sftp agent script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1264 Highline school cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1243 Push user expire_date's to future

Fixes issue where transactions (circs/holds) are not created because all
users are expired.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1243 Remove nested BEGIN/COMMIT on sample data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1243 2.7 SQL upgrade INSERT wrapping

1. Wrap INSERTs in insert_on_deploy() test.
2. Avoid unnecessary inserts, e.g. upgrade log versions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1243 Dev DB exports for 2.7

Updated dev server sample data export for 2.7 series release.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1243 Add export table config.composite_attr_entry_definition

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1185 Patron edit missing 2.7 2ndry grps button

Add the missing button to the KCLS template.  Also, remove the local
copy of the register.tt2 file, since it contained no local
customizations.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater uses --settings-startup-pause 5 (typo)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater uses --settings-startup-pause 5

Avoid rare, but annoying cases of the C services starting before
opensrf-settings as completed its login to ejabberd.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1263 Browse entry cleanup utility SQL

SQL to delete un-referenced (dangling) browse entries.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1284 Strip apostrophes in search normalize

Test case is title search for both forms:

ha-na'arah she-sihkah ba-esh
ha-Naʻarah she-śiḥḳah ba-esh

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1263 'Other Author' index no longer creates browse entries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1185 Picklist fund selector perm repairs

Enusre the fund search filter has a value set for the location org
units, based on picklist access permissions, otherwise zero funds
will be returned.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1246 Call number search configs continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1246 create call_number search config

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1245 2.7 SQL upgrade repair call-number extracts; part 2

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1245 2.7 SQL upgrade repair call-number extracts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1164 apply subject dash fix before auth reingest

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "KMAIN-1510" (excess browse dashes)

This reverts commit 6c9cae946710ed9ed828daf78480c3b3f497c6a5.

JBAS-1164 Subject browse dashes repair

Only add dashes before subject browse subfields v, x, y, and z.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 Student account imports crontab entry

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 Addr normalizer shortens road/avenue

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1161 Tahoma classroom cards address repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 Address normalizer street => st

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Student cards expire age universally 21

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1161 Add district name to classroom card data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 Student importer uses kcls addr normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 KCLS Address normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-984 Student cards automation scripts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1161 Map districts to org units; remove --assume-new

1. District codes are mapped to org unit ID's within the script so the
caller does not have to know the org unit.

2. Remove the --assume-new option, since it serves little purpose.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1161 Tahoma classroom cards data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater defaults to 20 second service start wait time

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 auth-to-auth clear links once

Only delete auth-to-auth links for a given subfield once per record.
Otherwise, we could only create one link per tag.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 local thes. falls back to Other

When a controlled field specifies its source as local (ind2=7), consider
a link to an authority record whose thesaurus value is z=Other as always
valid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 repair ind2=z remapping logic (lcgft)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 Make auth-2-auth more aggressive

Remove all existing links for each processed auth-2-auth field before
rebuilding the links.  This lets us remove bogus links.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 auth linking repairs/consistency

1. Use consistent DB connection logic -- removes a lot of
   unnecessary DB connection settings logic.

2. Set log traces via OSRF_LOG_CLIENT

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 auth2auth link repairs/consistency

1. Use consistent DB connection logic -- removes a lot of
   unnecessary DB connection settings logic.

2. Use existing clean_marc utility function instead of inline version.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 auth batcher DB params consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 throttle_disbatcher.pl time printing fix

Code previously displayed "Time::tm=ARRAY(0xe1e4f8)" instead of a time
string.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 bib/auth batch repairs / consistency

1. Use consistent DB connection logic -- removes a lot of unnecessary
   DB connection settings logic.

2. Repair logic on building batch files to avoid warnings about writing
   to closed file handles.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 Extra del. record sanity check in bib/auth linker

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 authority batch setup uses opensrf

Assign ownership of authority batch files to opensrf instead of making
the directories world-writable.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 bib linking minor repairs and logging updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 bib linking force thesaurus; local thesaurus

Preliminary support for mapping local thesaurus values (ind2=7) to one
of the supported authority leader/11 options.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 readability; remove stale links

If auth record A links to record B, but they use a different thesaurus,
unlink them.

When 2 records use a different thesaurus, exit early to avoid
unnecessary processing.

Various readability and style modifications.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-980 auth-to-auth uses correct leader position

008 indexes are zero-based.  We want index 11, not 10.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN 1911 Auth-to-auth audience linking

Authority Records Now Only Link To Other Authority Records With The Same 008/11 (Audience)

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>

JBAS-980 auth-to-bib linking repairs continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1897 Fix Authority Linking Script

Authority Linking Script Now Recognizes Matches From Bib 65X to Auth 008/11

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>

JBAS-944 2.7 sql upgrade dupe holds cleanup

2.7 adds an index that prevents 2 captured, unfulfilled, uncanceled
holds from targeting the same copy.  Before the index is created,
cancel any such dupe-copy holds that have expired on the shelf and reset
any such holds that are otherwise unfulfilled (i.e. in transit or on the
holds shelf).

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater installs admin scripts to /openils/bin

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater.sh stop/start-util handles reporter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 2.7 auth reingest clear statement timeout

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 2.7 upgrade statement timeout

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1129 Remove KCLS custom language filter SQL

No need to track a separate language_filter table, since we have the
same data available via coded value maps.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 Add extend_reporter changes for 2.7 upgrade

These changes were not included in the version upgrade scripts, since
they were optional.  We need them locally.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 browse entry constraint also checks value

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 Auth changes update browse_entry_* values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 Move auth updates to 2ndry transaction

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 avoid modifying local series index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 update ACQ cancel reason labels

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 remove unneeded PO print template mods

These updates won't apply anyway since we have local changes.  Removing
them to de-clutter the upgrade script some.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 replace ROLLBACK with COMMIT

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 SQL functions comparison tool

Tool to generate diffs for a set of SQL functions.  Useful for analyzing
SQL upgrade scripts.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 biblio.indexing_ingest_or_delete updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 vandelay.overlay_bib_record always set edit_date

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 staged_browse() and reingest_metabib_field_entries

* Avoid replacing staged browse.
* Cross-port local changes from reingest_metabib_field_entries
  into the stock code.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 merging code for authority.indexing_ingest_or_delete

Too many local changes to merge into stock.  Cross-porting
stock changes instead.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 2.5 -> 2.7 SQL recreating dropped views

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-944 2.5 -> 2.7 SQL : getting started

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1038 Refresh notes on print/receive/cancel

Refresh lineitem notes after a PO print, lineitem receive, or lineitem
cancel action occur to pick up the latest lineitem action notes.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1007 ACQ lib selector focus repair

Allow text entry on lib selector focus by focusing the element with the
needed id (the input element) instead of the element with the needed
widgetid (the container element).

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1131 Streaming music mattype TPAC icon

Adds new icon to mattype image set.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1038 Add LI notes on print/invoice

Adds a lineitem note when a lineitem is printed, during a PO print
opereration, and when a lineitem is added to an invoice.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1647 Auto-Inserting action notes on li cancel/receive.

When a lineitem is marked as recieved, add a note to it
in the format of "REC: [username]"

When a lineitem is cancelled, add a note it it in the
format of "cancelled [username]"

Signed-off-by: khuckins <khuckins@catalystdevworks.com>
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/Order.pm
modified:   Open-ILS/web/js/ui/kcls/acq/common/li_table.js

Modified by Bill:

* Support batch lineitem cancel note creation.
* Support all forms of lineitem receiving.
* Make note format consistent with (pending) printed and invoiced notes
* Removed dates from notes, since notes already show their creation date.
* Removed any changes to li_table.js (pending future Perl changes).

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1837 Add PO activation lineitem notes

When a PO is activated, add a note to each lineitem containing the
username of the staff which activated the PO.

Note format is "ORD: <username>"

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1921 Item Status Reset

Move Clearing function call to a check for the
listbox, so box clears regardless of if holds
and transit status aren't valid.

Add caption change so captions are valid when going
from a non-captured/non-transit item to a captured/
in-transit item.

Signed-off-by: khuckins <khuckins@catalystdevworks.com>
modified:   Open-ILS/xul/staff_client/server/circ/alternate_copy_summary.js
modified:   Open-ILS/xul/staff_client/server/locale/en-US/circ.properties

Patch modified by Bill to reset hold patron name display and to
remove changes unrelated to this patch.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-567 Hide and ignore fast-entry checkin option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1007 ACQ focus lib selector on delete

Focus the first library selector after adding new copies and after
removing copies.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1861 Reduce Number Of Copies

Dynamically Grow Or Shrink Number Of Line Items

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

RT86744 Avoid PO refresh in picklist

Avoid calling a PO-only function (refreshPOSummaryAmounts()) in a
picklist-only context.  Otherwise, code dies and leaves the button for
modifying copies disabled.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-920 Port DoB as DATE to KCLS schema

Porting SQL from LP#838525.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Stamping upgrade script and test file

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Conflicts:
Open-ILS/src/sql/Pg/002.schema.config.sql

LP#838525 DoB as date PGTAP test

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#838525 Store date of birth as SQL DATE type

Upgrade script translates DoB ahead 3 hours before translating to DATE
(from TIMESTAMPTZ) to ensure dates stored in alternate daylight savings
TZ (e.g. -05 vs. -04) are translated to the proper date.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

JBAS-673 Create PO from multiple pages of lineitems.

Maintain a list of selected lieitems across multiple pages of lineitems
in a selection list.  When creating a PO from selected lineitems,
include all selected lineitems in the new PO.

See also KMAIN-1865.

Code based on 5f309573.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1007 (KMAIN-1642) ACQ items navigation improvements

This code is based on the original code at e595e444.

1. When drawing the lineitem copies page, select() the value in the Item
    Count Count text input so staff can more quickly modify the value.

2. After adding copies, focus the first owning lib selector.

3. When an owning lib selector is focused, pressing Enter causes focus
  to jump to the next lib selector in the list.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1829 Bib Call Number on Holds

Problem: Call Number wouldn't show up in list view of
patron holds screen when status was "Waiting for Copy."

Solution: Add check to Call Number column for specific
copy, and if nonexistant, pull from MARC info for selected
item.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
---

Modified by berick to avoid bib call number / MARC processing when a
call number is available, since this is already a heavy API call.
Replaced some tabs.  Added some comments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

KMAIN-1830 Backspace clears patron register barcode

Backspace Now Completely Clears Barcode Field When Doing A
Patron Registration.

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>
Modified by Bill E. for style, to avoid unnecessary dojo.attach, and
to add some comments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 Log patron purge count

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 Kent/future expire dates

1. Set the expire age to 21 instead of 18 for Kent SD.
2. Ensure that no expire dates are set to before "now".

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 Log inserted patron count

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 set expire time to 6am to reduce DST issues

Set patron expire time to 6am so that expire dates spanning DST
boundaries don't make it appear as though the date is off by one day for
clients that don't honor timezone data.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 Kent classroom cards data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1037 student importer improved error handling

Includes various small fixes, but mainly the ability to report when a
commit call fails, which is primarily important when processing in
batch.

Signed-off-by: Bill Erickson <berickxx@gmail.com>