SIPServer.git
18 years agoAdd tests for invalid patron and invalid item
djfiander [Thu, 22 Jun 2006 01:00:18 +0000 (01:00 +0000)]
Add tests for invalid patron and invalid item

18 years agoTest for a blocked patron attempting to check out a book
djfiander [Fri, 16 Jun 2006 02:04:50 +0000 (02:04 +0000)]
Test for a blocked patron attempting to check out a book

18 years agoFix ILS::checkout to handle more error conditions properly (but I
djfiander [Fri, 16 Jun 2006 02:04:22 +0000 (02:04 +0000)]
Fix ILS::checkout to handle more error conditions properly (but I
still can't cope with Bob attempting to check out a book that
Alice already has out.

18 years agoTest renewing an item that's identified by title rather than by
djfiander [Thu, 15 Jun 2006 01:29:06 +0000 (01:29 +0000)]
Test renewing an item that's identified by title rather than by
item id.

18 years agoAdd code to renew items that are specified by title, rather than
djfiander [Thu, 15 Jun 2006 01:28:38 +0000 (01:28 +0000)]
Add code to renew items that are specified by title, rather than
by item id.  This is very odd, but the spec seems to allow it.

18 years agoDefine an empty array of fields to be checked in the responses
djfiander [Wed, 14 Jun 2006 02:16:16 +0000 (02:16 +0000)]
Define an empty array of fields to be checked in the responses
for those messages that don't require any field checking.  This
eliminates "TODO" failures from the test harness.

18 years agoTest that when a second hold is placed on an item, the queue
djfiander [Wed, 14 Jun 2006 02:15:05 +0000 (02:15 +0000)]
Test that when a second hold is placed on an item, the queue
position is properly reported.

18 years agoAdd second patron to stub ILS, to test multiple holds on an
djfiander [Wed, 14 Jun 2006 02:14:28 +0000 (02:14 +0000)]
Add second patron to stub ILS, to test multiple holds on an
item.

18 years agoGeneralize configuration of Net::Server::PreFork to allow for
djfiander [Tue, 13 Jun 2006 01:18:44 +0000 (01:18 +0000)]
Generalize configuration of Net::Server::PreFork to allow for
arbitrary configuration parameters.

18 years agoClean up after the test is completed by checking the item back
djfiander [Tue, 13 Jun 2006 01:09:00 +0000 (01:09 +0000)]
Clean up after the test is completed by checking the item back
in.

18 years agoMinor cleanup: be consistent in use of "LOG_" in syslog levels.
djfiander [Mon, 12 Jun 2006 23:49:51 +0000 (23:49 +0000)]
Minor cleanup: be consistent in use of "LOG_" in syslog levels.

18 years agoInitial tests for Item Information message
djfiander [Fri, 9 Jun 2006 02:44:03 +0000 (02:44 +0000)]
Initial tests for Item Information message

18 years agoExtend reporting of circulation status
djfiander [Fri, 9 Jun 2006 02:42:48 +0000 (02:42 +0000)]
Extend reporting of circulation status

18 years agoInitial test for Renew All
djfiander [Tue, 6 Jun 2006 01:22:03 +0000 (01:22 +0000)]
Initial test for Renew All

18 years agotext fields in the response messages may be empty
djfiander [Tue, 6 Jun 2006 01:21:35 +0000 (01:21 +0000)]
text fields in the response messages may be empty

18 years agoAdd support for the configuration parameters
djfiander [Tue, 6 Jun 2006 01:20:01 +0000 (01:20 +0000)]
Add support for the configuration parameters

    <min_servers value="N" />
    <max_servers value="N" />

which parallel the paramters for Net::Server::PreFork.

18 years agowrite_msg() is used by both the server and the test suite. In
djfiander [Tue, 6 Jun 2006 01:18:38 +0000 (01:18 +0000)]
write_msg() is used by both the server and the test suite.  In
the test suite, we don't want to call syslog, so only call syslog
if we're writing the message to stdout (which only happens in the
server).

18 years agoFix check renewal permissions check
djfiander [Fri, 2 Jun 2006 00:51:18 +0000 (00:51 +0000)]
Fix check renewal permissions check

18 years agoInitial set of tests for Renew
djfiander [Wed, 31 May 2006 00:18:44 +0000 (00:18 +0000)]
Initial set of tests for Renew

18 years agoFix minor bugs in error condition for Renew Response
djfiander [Tue, 30 May 2006 01:58:50 +0000 (01:58 +0000)]
Fix minor bugs in error condition for Renew Response

18 years agoInitial test suite for Checkin
djfiander [Tue, 30 May 2006 01:10:35 +0000 (01:10 +0000)]
Initial test suite for Checkin

18 years agoConfirm the actual title of the item being held
djfiander [Tue, 30 May 2006 01:09:46 +0000 (01:09 +0000)]
Confirm the actual title of the item being held

18 years agoOnly attempt to add the Patron ID to the Checkin Response message
djfiander [Tue, 30 May 2006 01:02:12 +0000 (01:02 +0000)]
Only attempt to add the Patron ID to the Checkin Response message
if the ILS actually provides a valid $patron structure

18 years agoAdd a bunch more tests
djfiander [Mon, 29 May 2006 12:16:11 +0000 (12:16 +0000)]
Add a bunch more tests

18 years agominor fixups for hold management
djfiander [Sun, 28 May 2006 12:30:48 +0000 (12:30 +0000)]
minor fixups for hold management

18 years agoHold messages can have a patron password in them
djfiander [Sun, 28 May 2006 12:30:20 +0000 (12:30 +0000)]
Hold messages can have a patron password in them

18 years agoInitial test case
djfiander [Sat, 27 May 2006 13:33:11 +0000 (13:33 +0000)]
Initial test case

18 years agoAdd more tests
djfiander [Sat, 27 May 2006 13:32:45 +0000 (13:32 +0000)]
Add more tests

18 years agoI'm beginning to wonder how many times it'll take me to get the
djfiander [Sat, 27 May 2006 11:50:01 +0000 (11:50 +0000)]
I'm beginning to wonder how many times it'll take me to get the
password check right.  But this time I actually ran it through
the test harness before checking it in.

18 years agoadd missing value to debug message
djfiander [Sat, 27 May 2006 11:30:52 +0000 (11:30 +0000)]
add missing value to debug message

18 years agoGet the test right for checking the patron password in
djfiander [Sat, 27 May 2006 11:30:23 +0000 (11:30 +0000)]
Get the test right for checking the patron password in
handle_patron_enable()

18 years agoInitial set of tests
djfiander [Fri, 26 May 2006 02:12:48 +0000 (02:12 +0000)]
Initial set of tests

18 years agoFix bugs in Patron Enable: A valid patron with an invalid
djfiander [Fri, 26 May 2006 02:12:26 +0000 (02:12 +0000)]
Fix bugs in Patron Enable: A valid patron with an invalid
password should generate a true patron status message, but
shouldn't enable the patron.

Fix language handling in Block Patron: return the patron's
language, rather than sending 'unknown'.

18 years agoInitial set of tests for Checkout Response
djfiander [Sun, 21 May 2006 13:56:40 +0000 (13:56 +0000)]
Initial set of tests for Checkout Response

18 years agoEliminate warning message for uninitialized variable use
djfiander [Sun, 21 May 2006 13:52:51 +0000 (13:52 +0000)]
Eliminate warning message for uninitialized variable use

18 years agoFix spelling mistake
djfiander [Fri, 19 May 2006 02:30:52 +0000 (02:30 +0000)]
Fix spelling mistake

18 years agoFix handling of the "renewal ok" status field in the ILS
djfiander [Fri, 19 May 2006 02:30:21 +0000 (02:30 +0000)]
Fix handling of the "renewal ok" status field in the ILS

18 years agoFinish first pass at ILS::Patron documentation
djfiander [Wed, 17 May 2006 02:50:02 +0000 (02:50 +0000)]
Finish first pass at ILS::Patron documentation

18 years agoInitial, incomplete, documentation for ILS::Patron
djfiander [Tue, 16 May 2006 01:44:00 +0000 (01:44 +0000)]
Initial, incomplete, documentation for ILS::Patron

18 years agoMissed an unused function in the last code cleanup
djfiander [Tue, 16 May 2006 01:40:29 +0000 (01:40 +0000)]
Missed an unused function in the last code cleanup

18 years agoCode cleanups
djfiander [Tue, 16 May 2006 01:37:29 +0000 (01:37 +0000)]
Code cleanups

18 years agoInitial pass at documentation for ILS::Item
djfiander [Mon, 15 May 2006 00:16:42 +0000 (00:16 +0000)]
Initial pass at documentation for ILS::Item

18 years agoDelete unused access method
djfiander [Mon, 15 May 2006 00:15:36 +0000 (00:15 +0000)]
Delete unused access method

18 years agoAdd code to build HTML documentation from the podfiles.
djfiander [Mon, 15 May 2006 00:15:11 +0000 (00:15 +0000)]
Add code to build HTML documentation from the podfiles.

18 years agoFinish first pass at documentation for ILS module
djfiander [Mon, 15 May 2006 00:14:27 +0000 (00:14 +0000)]
Finish first pass at documentation for ILS module

18 years agoMinor code cleanups
djfiander [Sun, 14 May 2006 11:40:39 +0000 (11:40 +0000)]
Minor code cleanups

18 years agoAdjust tests to agree with the code. Since the server reports
djfiander [Thu, 4 May 2006 01:24:52 +0000 (01:24 +0000)]
Adjust tests to agree with the code.  Since the server reports
that a patron is valid, but the password was wrong, we need to
make sure that that's what the tests expect.

18 years agoSequence numbers are a single digit, so when it hits 10, wrap
djfiander [Thu, 4 May 2006 01:24:09 +0000 (01:24 +0000)]
Sequence numbers are a single digit, so when it hits 10, wrap
around to 0.

18 years agoAdjust the test data so that it works with the test cases.
djfiander [Thu, 4 May 2006 01:23:28 +0000 (01:23 +0000)]
Adjust the test data so that it works with the test cases.

18 years agoIf the patron is valid, but the patron password is provided, and
djfiander [Thu, 4 May 2006 01:22:54 +0000 (01:22 +0000)]
If the patron is valid, but the patron password is provided, and
wrong, still report that the patron's good.  This seems to be
what clients are expecting, and since we can "trust" them, we
will give them full disclosure.

18 years ago'0' is a valid sequence number (it comes after '9'), so we have
djfiander [Thu, 4 May 2006 01:21:42 +0000 (01:21 +0000)]
'0' is a valid sequence number (it comes after '9'), so we have
to see if the sequence number is set, not just if it's true.

18 years agominor cleanups
djfiander [Sun, 30 Apr 2006 12:17:18 +0000 (12:17 +0000)]
minor cleanups

18 years agoAdd a bunch of tests, and stock field checks
djfiander [Sun, 30 Apr 2006 01:20:47 +0000 (01:20 +0000)]
Add a bunch of tests, and stock field checks

18 years agoMake sure to set BL: Patron Valid when the patron is, in fact,
djfiander [Sun, 30 Apr 2006 01:20:01 +0000 (01:20 +0000)]
Make sure to set BL: Patron Valid when the patron is, in fact,
valid (uncovered by the tests)

18 years agoFix formatting, export FID_PATRON_BIRTHDATE FID_PATRON_CLASS
djfiander [Sun, 30 Apr 2006 01:19:22 +0000 (01:19 +0000)]
Fix formatting, export FID_PATRON_BIRTHDATE FID_PATRON_CLASS

18 years agoAdd support for FID_PATRON_BIRTHDATE (PB) and FID_PATRON_CLASS
djfiander [Sun, 30 Apr 2006 00:15:04 +0000 (00:15 +0000)]
Add support for FID_PATRON_BIRTHDATE (PB) and FID_PATRON_CLASS
(PC) to Patron Information Response, for Envisionware terminals.

18 years agoAdd stub methods sip_birthdate and ptype, to support Envisionware
djfiander [Sun, 30 Apr 2006 00:13:48 +0000 (00:13 +0000)]
Add stub methods sip_birthdate and ptype, to support Envisionware
terminals (and probably others).

18 years agoChange port for raw socket connection from 5300 (chosen at random
djfiander [Sun, 30 Apr 2006 00:12:59 +0000 (00:12 +0000)]
Change port for raw socket connection from 5300 (chosen at random
by your's truly) to 6001, as per Envisionware email.

18 years agoVery basic tests. This will be a big test case. I suspect that
djfiander [Wed, 26 Apr 2006 14:37:19 +0000 (14:37 +0000)]
Very basic tests.  This will be a big test case.  I suspect that
the test harness will have to be enhanced in a variety of ways,
including some way of indicating fields that SHOULD NOT appear,
as well as just fields that are required.

18 years agoGeneralize handling of tagged fields, so we can reuse field
djfiander [Wed, 26 Apr 2006 14:35:20 +0000 (14:35 +0000)]
Generalize handling of tagged fields, so we can reuse field
specifications between test scenarios.

18 years agoFix Patron Information message handling to parallel the situation
djfiander [Wed, 26 Apr 2006 14:33:39 +0000 (14:33 +0000)]
Fix Patron Information message handling to parallel the situation
in the handling of Patron Status messages: if the password's not
provided by the terminal, then we don't worry about checking the
password, but if the terminal gives us the password, then it has
to match before we say anything about the patron.

18 years agoReplace call to nonexistent method 'hold_items_count' with
djfiander [Wed, 26 Apr 2006 14:19:52 +0000 (14:19 +0000)]
Replace call to nonexistent method 'hold_items_count' with
correct code.

18 years agoReturn an item title, even if the checkout failed (assuming that
djfiander [Wed, 26 Apr 2006 13:34:31 +0000 (13:34 +0000)]
Return an item title, even if the checkout failed (assuming that
the item ID was valid).

18 years agoClean up handling of Patron Status Response messages when there's
djfiander [Wed, 26 Apr 2006 13:31:22 +0000 (13:31 +0000)]
Clean up handling of Patron Status Response messages when there's
no password provided by the terminal.  I have a strong suspicion
that there exist terminals that expect to get patron status or
patron information even if they don't provide a password.

18 years agoCreate code to test tagged field values, create tests for Patron
djfiander [Wed, 26 Apr 2006 01:19:53 +0000 (01:19 +0000)]
Create code to test tagged field values, create tests for Patron
Status message

18 years agoInitial test environment
djfiander [Fri, 21 Apr 2006 02:18:47 +0000 (02:18 +0000)]
Initial test environment

18 years agoClean up handling of SIP boolean flags, and fix interface to
djfiander [Fri, 21 Apr 2006 02:15:43 +0000 (02:15 +0000)]
Clean up handling of SIP boolean flags, and fix interface to
write_msg().  Since it never used the $server parameter, get rid
of it, and add an optional $file parameter, so that write_msg()
can be use by the test harness.

18 years agoRemove hold_items_count method, and move the code to drop a hold
djfiander [Wed, 19 Apr 2006 00:03:55 +0000 (00:03 +0000)]
Remove hold_items_count method, and move the code to drop a hold
into a Patron method, rather than embedding it in the ils
transaction level.

18 years agoImplement code to handle Renew All messages.
djfiander [Sun, 16 Apr 2006 15:50:16 +0000 (15:50 +0000)]
Implement code to handle Renew All messages.

Minor cleanups.

Move add_count() into Sip.pm

Consistently use methods to access fields in Transaction status
objects.

18 years agoMinor cleanups.
djfiander [Sun, 16 Apr 2006 15:47:29 +0000 (15:47 +0000)]
Minor cleanups.

18 years agoMinor cleanups.
djfiander [Sun, 16 Apr 2006 15:47:07 +0000 (15:47 +0000)]
Minor cleanups.

move available() method out of Transaction and into Item.

18 years agoadd messages for Renew, Renew All, and Patron Enable
djfiander [Sun, 16 Apr 2006 15:46:04 +0000 (15:46 +0000)]
add messages for Renew, Renew All, and Patron Enable

18 years agoMove add_count() to Sip.pm from Sip::MsgType.pm
djfiander [Sun, 16 Apr 2006 15:44:56 +0000 (15:44 +0000)]
Move add_count() to Sip.pm from Sip::MsgType.pm

18 years agoImplement stubs necessary for Renew All support.
djfiander [Sun, 16 Apr 2006 15:44:23 +0000 (15:44 +0000)]
Implement stubs necessary for Renew All support.

Consistently use methods to access fields rather than getting
at the fields directly.

18 years agoSwitch to AUTOLOAD-based field access
djfiander [Sun, 16 Apr 2006 15:43:11 +0000 (15:43 +0000)]
Switch to AUTOLOAD-based field access

18 years agoStub code to handle renewals
djfiander [Sun, 16 Apr 2006 01:40:34 +0000 (01:40 +0000)]
Stub code to handle renewals

18 years agoAdd stub code necessary to support item renewal
djfiander [Sun, 16 Apr 2006 01:39:47 +0000 (01:39 +0000)]
Add stub code necessary to support item renewal

18 years agoAdd support for Renew message
djfiander [Sun, 16 Apr 2006 01:39:26 +0000 (01:39 +0000)]
Add support for Renew message

18 years agoChange IP on service so that it will work regardless of the IP of
djfiander [Sat, 15 Apr 2006 21:12:47 +0000 (21:12 +0000)]
Change IP on service so that it will work regardless of the IP of
the host.

18 years agoStub code to handle status returned by a "hold" transaction.
djfiander [Sat, 15 Apr 2006 21:10:37 +0000 (21:10 +0000)]
Stub code to handle status returned by a "hold" transaction.

18 years agoClean up some test messages so they work against the existing
djfiander [Sat, 15 Apr 2006 15:45:07 +0000 (15:45 +0000)]
Clean up some test messages so they work against the existing
test stub.  Add messages for placing and cancelling a hold.

18 years agoAdd support for Hold message
djfiander [Sat, 15 Apr 2006 15:44:12 +0000 (15:44 +0000)]
Add support for Hold message

18 years agoAdd support for placing, altering, and cancelling holds
djfiander [Sat, 15 Apr 2006 15:43:10 +0000 (15:43 +0000)]
Add support for placing, altering, and cancelling holds

18 years agoUse the new $patron->block() method. Implement support for the
djfiander [Sat, 15 Apr 2006 00:45:00 +0000 (00:45 +0000)]
Use the new $patron->block() method.  Implement support for the
Patron Enable message

18 years agoMove block() from the ILS into the ILS::Patron. Create the
djfiander [Sat, 15 Apr 2006 00:44:15 +0000 (00:44 +0000)]
Move block() from the ILS into the ILS::Patron.  Create the
opposite enable() method to support the Patron Enable message

18 years agoGet handling of institution IDs right. Make "block_patron" a
djfiander [Sat, 15 Apr 2006 00:43:20 +0000 (00:43 +0000)]
Get handling of institution IDs right.  Make "block_patron" a
method of the ILS::Patron object, rather than an ILS method

18 years agoAdd support for Status Update message
djfiander [Fri, 14 Apr 2006 23:33:35 +0000 (23:33 +0000)]
Add support for Status Update message

18 years agoAdd stub to handle Status Update message
djfiander [Fri, 14 Apr 2006 23:33:11 +0000 (23:33 +0000)]
Add stub to handle Status Update message

18 years agouse the new ILS::check_inst_id to verify the institution ID that
djfiander [Fri, 14 Apr 2006 20:07:32 +0000 (20:07 +0000)]
use the new ILS::check_inst_id to verify the institution ID that
we receive from the terminal.

Also implement support for Item Information message.

18 years agoAdded stub routines that provide support for the Item Information
djfiander [Fri, 14 Apr 2006 20:06:24 +0000 (20:06 +0000)]
Added stub routines that provide support for the Item Information
Response message.

18 years agoSip::timestamp now takes an optional parameter (seconds since the
djfiander [Fri, 14 Apr 2006 20:05:41 +0000 (20:05 +0000)]
Sip::timestamp now takes an optional parameter (seconds since the
epoch) and generates a timestamp for that time.  Default
continues to be timestamp of 'now'.

18 years agonew ILS takes an institution configuration as input, so the name
djfiander [Fri, 14 Apr 2006 20:04:27 +0000 (20:04 +0000)]
new ILS takes an institution configuration as input, so the name
of the ILS institution is the $institution->{id}

18 years agoAdded code to verify the institution id, and to manage due dates
djfiander [Fri, 14 Apr 2006 19:59:29 +0000 (19:59 +0000)]
Added code to verify the institution id, and to manage due dates
within the stub item db.

18 years agoDelete handling of "FID_FEE_ITEMS", since it doesn't exist (the
djfiander [Fri, 14 Apr 2006 17:14:56 +0000 (17:14 +0000)]
Delete handling of "FID_FEE_ITEMS", since it doesn't exist (the
Patron Information Response message documentation is wrong).
Correct handling of Address, Email, and Home Phone fields in
Patron Information Response in response to corrections from 3M

18 years agoDelete non-existent "FID_FEE_ITEMS", since we heard back from 3M
djfiander [Fri, 14 Apr 2006 17:13:32 +0000 (17:13 +0000)]
Delete non-existent "FID_FEE_ITEMS", since we heard back from 3M
that the documentation about the Patron Information Response
message was incorrect.

18 years agoDon't use "ILS::pay_fee()", use "$ils->pay_fee()"
djfiander [Wed, 12 Apr 2006 15:22:13 +0000 (15:22 +0000)]
Don't use "ILS::pay_fee()", use "$ils->pay_fee()"

18 years agoChange label for tag generation
djfiander [Wed, 12 Apr 2006 15:21:35 +0000 (15:21 +0000)]
Change label for tag generation

18 years agoMore documentation
djfiander [Wed, 12 Apr 2006 15:20:54 +0000 (15:20 +0000)]
More documentation

18 years agoInitial documentation for the ILS.pm portable interface between
djfiander [Wed, 12 Apr 2006 02:00:26 +0000 (02:00 +0000)]
Initial documentation for the ILS.pm portable interface between
the SIP code and the ILS.

18 years agoadding loadable module support
miker-pines [Fri, 7 Apr 2006 02:29:56 +0000 (02:29 +0000)]
adding loadable module support