phasefx [Tue, 26 Apr 2011 14:41:30 +0000 (14:41 +0000)]
fix disappearing cursor/caret for Check In
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20316
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 26 Apr 2011 14:13:55 +0000 (14:13 +0000)]
Make authority_control_fields.pl resistant to database timeouts
LP 771237 describes how on an underpowered system, the work that
authority_control_fields.pl tries to do on a per-record basis may hit the
CStore default timeout of 6 seconds for a transaction and automatically
end the transaction, resulting in no work being committed once the script tries
to update the bibliographic record. Searching each controlled field for a
matching authority record can be costly in a database with millions of
authority records.
To enable the script to accomplish its work on underpowered test systems, use a
regular read-only CStoreEditor session to accomplish the lookups and create a
separate CStoreEditor session to issue the update in a transaction if required.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20313
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 25 Apr 2011 18:24:33 +0000 (18:24 +0000)]
Add a space between TOC part and TOC title in OpenLibrary added content
In trunk/rel_2_1 we switched to layout.css for table of contents
styling. We'll keep it simpler for stable 2.0 and handle this
bugfix completely inline.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20305
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 21:37:12 +0000 (21:37 +0000)]
address the empty-query case
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20297
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 22 Apr 2011 21:13:39 +0000 (21:13 +0000)]
Disable Save Columns in xul holds interface when Hold Details is being viewed. https://bugs.launchpad.net/evergreen/+bug/691599 Not the best fix, but the quickest fix
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20294
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 20:50:29 +0000 (20:50 +0000)]
Address LP#730743, errant parens cause pain
Specifically, we prune subplans that contain no nodes (empty parens), and avoid dropping out of the top level query context when we encounter a close-paren.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20291
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 22 Apr 2011 14:32:12 +0000 (14:32 +0000)]
Turn off non-working print button for holds pull
https://bugs.launchpad.net/evergreen/+bug/727983
Author: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20282
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 22 Apr 2011 00:41:15 +0000 (00:41 +0000)]
Patch from James Fournie to sort statcats in their comboboxes
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20277
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 21 Apr 2011 13:17:10 +0000 (13:17 +0000)]
check user 'active' field in SIP charge_ok (and dependent) calls
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20270
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 20 Apr 2011 20:32:12 +0000 (20:32 +0000)]
Revert r20035 - restore default copy status for Fast Add to "Available"
As noted in https://bugs.launchpad.net/evergreen/+bug/756838, the default
status for "Fast Add" copies has been "Available" since release 1.6.1.0.
Changing the default in the middle of the 2.0 release series would likely
cause more confusion for those sites who appreciate the current Fast Add
behaviour, so this reverts the changes in r20035 and maintains the same
defaults as 1.6.1.0.
Note that in r20264, 2.1.0 will gain two new org unit settings that will
enable sites to control their preferred default copy status for the Fast Add
and Add Volume interfaces.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20265
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 20 Apr 2011 16:11:58 +0000 (16:11 +0000)]
Backport of trunk r20250: Always use BinaryEncodeing => "UTF-8" with MARC::File::XML
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20252
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 20 Apr 2011 15:41:21 +0000 (15:41 +0000)]
Patch from Jeff Davis addressing parameter usage issues
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20246
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 21:05:24 +0000 (21:05 +0000)]
Typo: Propeties/Properties
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20226
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 19 Apr 2011 19:51:26 +0000 (19:51 +0000)]
Use top level join instead of subquery in hold queue position query
This is more readily optimized by the Postgres planer.
Note also, for very large data sets (lots of holds, on the order of 100k+ active), the following is also advised:
ALTER TABLE action.hold_copy_map alter column target_copy SET statistics 500, alter column hold set statistics 500;
ANALYZE action.hold_copy_map;
This gives the planner better data about the hold-copy-map n-distinct.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20219
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Tue, 19 Apr 2011 17:56:49 +0000 (17:56 +0000)]
Fix dump-style printing by ensuring 'params' is defined before accessing it
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20218
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:54 +0000 (14:16 +0000)]
one more fix, for Show in Catalog on issuance holds
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20198
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:51 +0000 (14:16 +0000)]
display issuance label, not subscription label
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20197
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 19 Apr 2011 14:16:48 +0000 (14:16 +0000)]
Add xul support for displaying issuance holds (needs testing)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20196
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 02:54:06 +0000 (02:54 +0000)]
Mark cmc.label for translation, not cmc.name, in seed data
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20194
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 02:20:56 +0000 (02:20 +0000)]
Mark cmf and cmc labels as translatable
We went to the effort of extracting the translatable text from
950.data.seed-values.sql, but had not marked the fields as
translatable in the IDL. Now at least the out-of-the-box
fields and classes will easily be able to have translations.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20191
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 01:49:45 +0000 (01:49 +0000)]
Add openils.widget.Searcher Dojo NLS to the i18n build
Necessary for the "advanced" searchbar on the Evergreen
AjaxPAC.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20187
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 19 Apr 2011 01:08:25 +0000 (01:08 +0000)]
Correct encoding issue with authority_control_fields.pl
Is there ever a time when MARC::File::XML would be invoked with
anything other than BinaryEncoding => 'utf-8'? Not here, at
least. Addresses LP# 764582.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20184
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 18 Apr 2011 15:47:18 +0000 (15:47 +0000)]
improve comments on a couple config tables
Based on suggestions from Mike Rylander and Thomas Berezansky.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20167
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 18 Apr 2011 15:47:16 +0000 (15:47 +0000)]
minor improvements to database object comments
* remove copyright, license verbiage, and C-style comment marking
from the comments; these can live in the SQL scripts
* updated several copyright headers
* minor improvements to documentation of a couple tables
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20166
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 18 Apr 2011 05:30:29 +0000 (05:30 +0000)]
in the MARC Editor, put the callnumber and barcode textboxes for Fast Item Add on a separate row
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20153
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 18 Apr 2011 05:15:34 +0000 (05:15 +0000)]
Enable relative paths in i18n testing scripts
We were 98% of the way there; now we no longer need to
cd into the same directory as the i18n testing scripts
to run them with meaningful output. Should be useful
for adding these to the CI server.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20150
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 18 Apr 2011 04:40:17 +0000 (04:40 +0000)]
Don't check .js files for entities
Must have asked this script to check JS files for valid entities
for a reason at some point in the dark past, but it couldn't have
been a very good reason; we're getting a false positive that needs
to be hushed now. Better to just stop looking for XML entities in
JavaScript.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20147
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 03:28:36 +0000 (03:28 +0000)]
Allow NULL "use restriction" fields for located URIs
The asset.uri.use_restriction field, which is really a sort of public notes
field for 856 fields, was grabbing the $u subfield (URL) as a sort of last-gasp
effort to give it some data. However, the effect was rather odd and led to
workarounds like Conifer's skin to avoid displaying the use restriction field
if its value was identical to the URL, etc.
Instead, stop grabbing $u and handle the case where use_restriction column is
NULL gracefully, just like the schema intended.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20125
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 03:19:49 +0000 (03:19 +0000)]
Do not clear auri links in default skin
The dojo orphan() call which attempted to wipe any non-located 856s
was actually wiping the located 856s in the record detail display.
Removing the extra call makes this work in Firefox and Chromium,
at least.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20122
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Sat, 16 Apr 2011 02:20:06 +0000 (02:20 +0000)]
Delete ##URI## call numbers and uri_call_number_map entries on bib reingest
This approach will lead to some acn/auricnm ID inflation, but it works.
Addresses LP# 761130 (immortal ##URI## entries in asset.call_number) reported
by Ben Shum and LP# 761085 (cannot delete bib with ##URI## volumes) reported
by Jason Etheridge.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20119
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 15 Apr 2011 20:18:05 +0000 (20:18 +0000)]
Protect dumb JavaScript engines from having to deal with actual Unicode
The holdings_xml format did not include an XML declaration, but adding that
as we do here still does not make the Firefox and Chromium JS engines capable
of consuming XML that contains Unicode content outside of the base ASCII
range.
So, we invoke entityize() to convert anything outside of the realm of
ASCII to XML entities. An alternative would be to invoke entityize() in
OpenILS::Application::SuperCat::unAPI::acn but it's not clear if that
would interfere with any other uses.
With this change, library names / copy location names with Unicode content
can be displayed correctly on the search results page.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20114
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 15 Apr 2011 15:46:09 +0000 (15:46 +0000)]
Re-add (from ingest in 1.6) support mulitiple subfield-9 values in a single 856 tag
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20103
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 15 Apr 2011 13:56:45 +0000 (13:56 +0000)]
Protect pcrud-ish retrieve from an empty result set
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20096
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 21:22:33 +0000 (21:22 +0000)]
Restore URIs in marcxml-uris unAPI format
At some point (r16750) we started doing a numeric comparison of
$flesh instead of just checking to see if $flesh was defined; this
returned false when $flesh == 'uris', preventing URIs from being
included in the marcxml-uris unAPI format.
This restores URIs to marcxml-uris and so we can revert the extra
BibTemplate call in rdetail_summary.xml.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20093
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 20:39:07 +0000 (20:39 +0000)]
Specify the holdings_xml unAPI format for URI calls
The unAPI marcxml-uris format is not returning URIs at the moment.
While we're getting that fixed, use the holdings_xml format to
get the URI job done; requires an extra JS call, but that's
better than not working at all.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20090
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Thu, 14 Apr 2011 18:24:42 +0000 (18:24 +0000)]
Escape rather than filter SIMILAR TO metacharacters in patron crazy search
The filtering I introduced in r19983 was overly aggressive, and included
characters that weren't actually SIMILAR TO metacharacters. Instead, escape
each character, carefully going through the list of metacharacters listed at
http://www.postgresql.org/docs/8.4/interactive/functions-matching.html
Works for email addresses like "foo.bar+baz@example.com".
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20087
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Thu, 14 Apr 2011 17:58:52 +0000 (17:58 +0000)]
Backport r20082 from trunk
Address LP #754880, where printing happens before the progress dialog can be
cleared in the alternate holds pull list print interface
Additionally, provide the usual "print page" button so that the list can be
reprinted at will
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20084
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 14 Apr 2011 16:51:55 +0000 (16:51 +0000)]
upgrade script for consistency w/ schema change in r20073
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20081
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Thu, 14 Apr 2011 16:10:09 +0000 (16:10 +0000)]
rely on search_path to locate the extract_marc_field() function which is now installed in the 'evergreen' schema by default
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20078
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 14 Apr 2011 15:49:54 +0000 (15:49 +0000)]
tweaks to quick_metarecord_map.sql
* used version from wiki, which provides same results as the
previous version but performs better on large databases
* now works without editing (a vacuum cannot run inside of a transaction)
* don't do vacuum full, just a regular vacuum analyze
[1] http://evergreen-ils.org/dokuwiki/doku.php?id=scratchpad:random_magic_spells#how_to_generate_metarecords_for_a_newly_loaded_bib_batch
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20077
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 13 Apr 2011 16:13:14 +0000 (16:13 +0000)]
Protect search against all-deleted bibs by pinning the estimation ratios in that case
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20067
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 12 Apr 2011 21:59:44 +0000 (21:59 +0000)]
repaired SQL upgrade syntax error
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20062
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 18:16:46 +0000 (18:16 +0000)]
Add a trigger function to simulate FKEY constraints on inherited tables
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20055
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 17:28:37 +0000 (17:28 +0000)]
Final cleanup for the base schema, re search_path ... I hope
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20050
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 12 Apr 2011 17:24:58 +0000 (17:24 +0000)]
Fix functions stranded in the evergreen schema without a search path reference (ugly but mechanical)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20049
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 12 Apr 2011 16:54:18 +0000 (16:54 +0000)]
add missing upgrade script
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20046
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 11 Apr 2011 16:56:51 +0000 (16:56 +0000)]
Let's not be picky about permissions here; an item needs to go where it needs to go :)
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20042
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Sun, 10 Apr 2011 21:35:46 +0000 (21:35 +0000)]
patch from jamesrf for lp#756880 for Grocery Billing Location in Bill Patron wizard
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20038
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Sun, 10 Apr 2011 20:53:56 +0000 (20:53 +0000)]
for lp bug#756838, consistent copy status for new items. jamesrf++
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20035
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 8 Apr 2011 19:29:16 +0000 (19:29 +0000)]
repaired bug in prepayment_required check. property -> method
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20032
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 8 Apr 2011 18:23:33 +0000 (18:23 +0000)]
For transit_slip template, %item_title%, %item_barcode%, etc. need to be in the Header, not the Line Item
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20029
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 7 Apr 2011 18:41:34 +0000 (18:41 +0000)]
test for pre-cat slightly off in OPAC My Account, spotted by Steve Callender
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20019
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Thu, 7 Apr 2011 16:03:46 +0000 (16:03 +0000)]
further fixes to maintain_901
Now correctly handles &, <, or > appearing in the tcn_value
or tcn_source. Also introduces a trivial utility stored
function, evergreen.xml_escape():
evergreen.xml_escape(TEXT) returns TEXT: converts '&', '<',
and '>' to XML entities
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20016
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 6 Apr 2011 20:53:10 +0000 (20:53 +0000)]
fix crash when importing/saving bib with '&' in TCN value
Also fix similar glitch if ampersand is present in the TCN
source.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20005
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Wed, 6 Apr 2011 18:38:16 +0000 (18:38 +0000)]
Patch from Thomas Berezansky to support patron priv expiration information in SIP2
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@20000
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 6 Apr 2011 18:23:23 +0000 (18:23 +0000)]
backport r18757 for org hiding tweak
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19997
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 5 Apr 2011 03:24:29 +0000 (03:24 +0000)]
Prevent patron search from returning horrible errors on regexian input
Add a utility method, _clean_regex_chars(), to filter common regex
characters out of input values. When these characters are passed to
database SIMILAR searches, strange things (generally ugly errors) can
happen - so filter them out.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19985
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Mon, 4 Apr 2011 19:46:38 +0000 (19:46 +0000)]
More robust fix for edit highlighting in Serial Control View
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19982
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Mon, 4 Apr 2011 18:06:14 +0000 (18:06 +0000)]
Fix edit highlighting in Serial Control View
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19977
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 4 Apr 2011 18:01:44 +0000 (18:01 +0000)]
order line items in PO display by line item ID
Order was effectively random otherwise. Use case from at least
one library indicates this change, but doesn't preclude later work
to make the sort order more flexible.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19972
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 4 Apr 2011 17:36:18 +0000 (17:36 +0000)]
reorder tabindex for horizontal patron search. non-flex the search button. thanks to sylvar and others for poking
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19970
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 4 Apr 2011 17:28:15 +0000 (17:28 +0000)]
2.0.5 upgrade script
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19966
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Mon, 4 Apr 2011 16:37:18 +0000 (16:37 +0000)]
Booking: in support of r19944, backport newer openils.XUL.newTabEasy() from
trunk as well
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19947
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Mon, 4 Apr 2011 16:29:17 +0000 (16:29 +0000)]
Backport r19942 from trunk
Booking: This should a) make booking interfaces behave better when a staff
login session times out and is replaced by use of a re-auth dialog, and b)
wrap booking interfaces in a <browser> element with the attendant
back/forward/reload buttons that most similar interfaces already had.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19944
dcc99617-32d9-48b4-a31d-
7c20da2025e4
senator [Mon, 4 Apr 2011 14:24:17 +0000 (14:24 +0000)]
Backport r19937 from trunk
Ben Ostrowsky pointed out that the alt holds (pull list) printing interface
was trying to include AutoIDL.js from an incorrect path.
I don't believe that file should be included at all, so now I've removed the
broken line.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19939
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Sat, 2 Apr 2011 17:14:00 +0000 (17:14 +0000)]
Adjust upgrade for 2.0
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19933
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Sat, 2 Apr 2011 17:10:21 +0000 (17:10 +0000)]
Add realistic row estimates to tree-ish functions (default is 1000) so that callers can make better plans in complex queries; includes four functions backported from 2.1 for simplicity when it comes to upgrading
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19932
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Fri, 1 Apr 2011 19:33:04 +0000 (19:33 +0000)]
Patch from Thomas Berezansky to address unneccessary fine generation and avoid unchecked division by zero; details and DCO at https://bugs.launchpad.net/evergreen/+bug/747533
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19929
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Fri, 1 Apr 2011 15:18:36 +0000 (15:18 +0000)]
Better search normalization de-duping when 'params' are used
This patch addresses search normalization deduping at two levels. We now verify that both the function and the params are the same before excluding a normalization, both when the normalization is first added to the set and when the SQL is being built (since currently multiple sets may be involved).
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19926
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 1 Apr 2011 15:05:54 +0000 (15:05 +0000)]
reposition these labels to mitigate horizontal scrolling in Holdings Maintenance
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19923
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Thu, 31 Mar 2011 18:13:09 +0000 (18:13 +0000)]
Use identifer indexes for older ISxN API methods (LP Bug #728671)
There are three logic layers involved in the older ISxN 'quick searches': the OPAC, the search API, and the storage API. The approach of this patch is to update the search API (which in turn fixes the OPAC), and ignore/deprecate the storage API for these identifiers.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19922
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Thu, 31 Mar 2011 15:18:06 +0000 (15:18 +0000)]
Logic error trying to merge the date component of one date object with the time component of another. We were trying to use the time object and update it piecemeal, which resulted in non-sensical dates that were forced to wrap. For example, if the date object was to set to March 31, 2011, and we tried .setMonth(3) on it to change it to April, that would result in an April 31st, which doesn't exist, and the date thus moves forward a certain number of days into May.
This affects Check Out, dedicated Renew interface, and the various date picking functions in Items Out and Holds interfaces.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19919
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Wed, 30 Mar 2011 02:24:59 +0000 (02:24 +0000)]
add item columns to xul-based holds lists
Could argue this fixes a regression, since the original pull list from 1.6 showed the circ modifier, and the xul alternative does not. So begging forgiveness :)
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19914
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 30 Mar 2011 01:52:44 +0000 (01:52 +0000)]
Change label to "Reset Password" and get button out of tab ordering
In a keyboard-intensive patron input workflow, pressing tab should
not place focus on the "Reset Password" button; the password is
automatically generated at dialog creation time. Setting tabIndex
to -1 disables tab focus for the button.
Also, the button has been relabeled to "Reset Password" to be
consistent with the previous button.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19911
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Wed, 30 Mar 2011 01:52:12 +0000 (01:52 +0000)]
Restore the Reset Password button on patron editor
Per LP 488243, the Reset Password button that existed on the old
XUL patron editor was lost in the transition to the new Dojo
patron editor. Jason Stephenson stepped up and offered a patch
to restore the functionality.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19910
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Wed, 30 Mar 2011 00:41:09 +0000 (00:41 +0000)]
fix typo in facet_force_nfc definition
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19905
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 29 Mar 2011 18:00:02 +0000 (18:00 +0000)]
Force facet values to Unicode NFC to reduce spurious non-matches
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19902
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Tue, 29 Mar 2011 17:57:25 +0000 (17:57 +0000)]
Inspired by a 1.6 patch from Brandon Uhlman to collect the set of holds not ready for pickup, 2.0+ style
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19901
dcc99617-32d9-48b4-a31d-
7c20da2025e4
erickson [Tue, 29 Mar 2011 16:22:45 +0000 (16:22 +0000)]
in the case of multiple xact event error responses, capture the first for staff client reporting
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19893
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Tue, 29 Mar 2011 02:09:14 +0000 (02:09 +0000)]
bug 744687: fix multi-field MARC expert search
Fixes bug where a bib that has multiple subfields
meeting one condition of a 2+ field MARC expert
search could end up in the results list even if
it didn't meet the other conditions (currently multi-field
MARC expert searches use implicit 'AND').
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19882
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Mon, 28 Mar 2011 22:44:05 +0000 (22:44 +0000)]
Fix call-number sorting for non-generic sort keys (LP Bug #737819)
Selecting on 'label' but sorting on 'label_sortkey' did not work properly. Instead, we will now find the single best call number we can based on the label given, then both select and sort based on that call number's sort key.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19879
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Mon, 28 Mar 2011 18:33:19 +0000 (18:33 +0000)]
MARC View print problem workaround (LP Bug #742033)
Certain printers were failing to print from the MARC View in the staff client. Adding a simple title to the view ended up being a successful workaround, and is unlikely to have negative consequences in any case.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19876
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 28 Mar 2011 17:28:18 +0000 (17:28 +0000)]
Address LP 744393: Arabic text in en-CA offline.properties
A translator appears to have mistakenly added Arabic text to
the en-CA offline.properties file in Launchpad. This commit
corrects those translations and completes the translation of
the file for 2.0.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19871
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 28 Mar 2011 16:38:32 +0000 (16:38 +0000)]
fix up receipt options persistence in billing interface; implement # of receipts option (not perfect if using print dialogs; non-blocking and not necessarily queued up)
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19870
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 25 Mar 2011 18:21:04 +0000 (18:21 +0000)]
fixes things like the stat cat editor, since that extra param now changes the return signature of the method
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19864
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Fri, 25 Mar 2011 17:31:29 +0000 (17:31 +0000)]
data.lookup was broken for cases where data.list[key] didn't exist for a given key
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19862
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Fri, 25 Mar 2011 06:53:43 +0000 (06:53 +0000)]
Avoid Apache warnings resulting from duplicate NameVirtualHost directives
Benjamin Shum reported that the Apache warnings that have been a part
of Evergreen's default configuration on Apache start for ages could
be avoided by commenting out the "NameVirtualHost: *80" line in
eg.conf. Testing confirmed that the directive was not necessary on Ubuntu,
Debian, or Fedora. As this warning has been the cause for unnecessary concern
on the part of many new adopters of Evergreen, getting rid of it appears to
be a nice usability win.
Thanks Ben!
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19859
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Tue, 22 Mar 2011 16:01:04 +0000 (16:01 +0000)]
have checkILSEvent handle events that aren't in ils_events.xml
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19854
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Tue, 22 Mar 2011 14:40:41 +0000 (14:40 +0000)]
Honor the 'active' flag in QueryParser.pm for search.relevance_adjustment entries.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19851
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 22 Mar 2011 01:26:31 +0000 (01:26 +0000)]
Build libjs from source for now until the Perl threading problem can be reliably tested
The previous commit changed JavaScript::SpiderMonkey to be built without
thread safety, but on Fedora we had been installing the js-devel package
(which was threaded). As you can't build a non-threaded
JavaScript::SpiderMonkey on top of a threaded libjs, for now we'll make
Fedora build a non-threaded libjs from source just like the other distros.
Note that the problem with threaded JavaScript::SpiderMonkey surfaced
on Debian Lenny when targeting holds. Lenny has libthreads-perl 1.71, but
a number of fixes have been committed to subsequent versions
(http://cpansearch.perl.org/src/JDHEDDEN/threads-1.82/Changes) - so
threading support might be reliable on more current distros. Once we
have a reliable test, we might be able to go back to the packaged
version of libjs.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19848
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Tue, 22 Mar 2011 00:41:47 +0000 (00:41 +0000)]
Another layer of escaping for the escapes in the DB update script
Apologies for the previous patch that led to breakage; I "tested" in a
script in which I had already hardcoded the answer I wanted after
running into problems with the previous version of the script. Not
good testing practice.
Thanks to Bill Erickson for suggesting the extra escapes. Tested in
a clean environment this time, and it works.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19845
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 21 Mar 2011 22:35:07 +0000 (22:35 +0000)]
Remove thready building -- we do not use threads anyway, and it breaks JS::SM
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19842
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbs [Mon, 21 Mar 2011 20:13:44 +0000 (20:13 +0000)]
Enable update_db.sh to handle upgrading databases with release version
When '0475' is mixed with '1.6.0.4', the latter wins as far as a plain MAX()
operator goes. Ensuring that the version is all digits should help avoid the
release version numbers in the config.upgrade_log table.
Thanks to Thomas Berezansky for suggesting a SIMILAR TO operator variation
that led to this approach.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19839
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Mon, 21 Mar 2011 18:09:41 +0000 (18:09 +0000)]
correcting bad timespecs in the example crontab
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19835
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 21 Mar 2011 16:47:01 +0000 (16:47 +0000)]
no, this was correct. doh :) the list version uses paging, but we're counting the entire set
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19830
dcc99617-32d9-48b4-a31d-
7c20da2025e4
phasefx [Mon, 21 Mar 2011 16:43:47 +0000 (16:43 +0000)]
this "count" method gets the same parameters as the list version
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19829
dcc99617-32d9-48b4-a31d-
7c20da2025e4
gmc [Mon, 21 Mar 2011 15:44:49 +0000 (15:44 +0000)]
trivial grammar fix
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19826
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 18 Mar 2011 19:55:56 +0000 (19:55 +0000)]
Make sure "ol" propagates through BibTemplate subject search links for OPAC range hiding
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19814
dcc99617-32d9-48b4-a31d-
7c20da2025e4
miker [Fri, 18 Mar 2011 14:42:01 +0000 (14:42 +0000)]
Allow the "result_field" to be used as the default alias in the output column of a row or set returning transform
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19801
dcc99617-32d9-48b4-a31d-
7c20da2025e4
dbwells [Thu, 17 Mar 2011 13:30:49 +0000 (13:30 +0000)]
Treat call number fields 090 and 092 as local LC and Dewey (respectively) based on de facto standards.
git-svn-id: svn://svn.open-ils.org/ILS/branches/rel_2_0@19792
dcc99617-32d9-48b4-a31d-
7c20da2025e4