Jason Stephenson [Tue, 11 Jun 2013 17:22:33 +0000 (13:22 -0400)]
Fix Lp bug 965656 WRT back dated checkins with fines.
* Move _check_open_xact from OpenILS::Application::Circ::Money
to OpenILS::Application::AppUtils so it can be called from
wherever.
* Modify OpenILS::Application::Circ::Money to use check_open_xact
from OpenILS::Application::AppUtils.
* Modify finish_fines_and_voiding in OpenILS::Application::Circ::Circulate
to use check_open_xact instead of reopen_xact.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/Application/AppUtils.pm
Dan Scott [Mon, 15 Jul 2013 18:36:30 +0000 (14:36 -0400)]
Improved copy table CSS/markup for conjoined bibs
Let the library name column wrap now that it may potentially contain
stupidly long title/author combos. Also, associate the table cells with
their corresponding headers for improved accessibility.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 15 Jul 2013 15:28:21 +0000 (11:28 -0400)]
Conjoined items / foreign items display in TPAC
Foreign items now appear at the top of the copy table, no matter what
copy page you are on. See "The two violin concertos" in the Concerto
data set for an example; the foreign bib is linked, with a label for the
designated peer type.
The parent bib record displays all of the child records in the copy table
underneath the pertinent copy; each title / author entry links to the
child bib display, naturally. See "Violin concerto no. 2 ; Six duos
(from 44 Duos)" in the Concerto data set for an example.
We escape all of the text retrieved from the database to avoid XSS
(thanks for the heads-up from Pasi Kallinen).
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Now with HTML escaping for safety
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Mon, 15 Jul 2013 13:11:53 +0000 (09:11 -0400)]
Whitespace and timelog entries
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Ott [Thu, 23 May 2013 00:11:07 +0000 (20:11 -0400)]
Expose conjoined bibs in TPAC
This initial work is based on the GRPL need to handle eReader bib/copy display.
The "joined" titles will display a copy record with a call_number link back to
the "master" bib, where the master will display a set of links to individual
titles from each "copy".
TODO: consider peer_type when determining whether or not to display
Signed-off-by: Bill Ott <bott@grpl.org>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Tue, 20 Aug 2013 14:50:43 +0000 (10:50 -0400)]
Stamping upgrade script for dewey sort fix
Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Etheridge [Thu, 7 Mar 2013 16:59:09 +0000 (11:59 -0500)]
LP#
1150939 fix dewey sort
There's a bit in the code where it tries to pad the first digit group,
if it's the only digit group, but it assumed the digit group was the
first token.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Mon, 5 Aug 2013 18:10:56 +0000 (14:10 -0400)]
LP1208572 - Fixes for reporter.classic_item_list
This view was created before the extend_reporter schema and the reporter.
materialized_simple_record existed. Rewriting the view definition to include
those.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Mon, 15 Jul 2013 08:22:57 +0000 (11:22 +0300)]
Fix LP#
1160770 by marking default toolbar names as translatable.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 13 Aug 2013 18:39:00 +0000 (14:39 -0400)]
LP
1084732 TPAC copy location selector
Copy location filter selector for the TPAC advanced search interface.
The behavior is the same as the analogous JSPAC feature. The interface
components are hidden by default, so non-JS browsers will be none the
wiser.
A number of small tweaks to related code were needed and are included in
this commit:
1. Make copy locations field_safe in the IDL so they can be retrieved
and parsed without the IDL
2. Insert a (full) hash-based org unit tree as inline JS at the bottom
of js.tt2 so JS will have access to the whole tree without having to
load the IDL to understand it.
3. Fix a bug in openils.CGI : decodeURIComponent parameter names
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Galen Charlton [Fri, 22 Feb 2013 19:00:55 +0000 (14:00 -0500)]
LP#
1131889: sort TPac copy list by normalized call number
... as opposed to the literal call number label. E.g., this
patch would make LC call number "AE5 .E363 1975 v.10" sort
after "AE5 .E363 1975 v.9" rather than after "AE5 .E363 1975 v.1"
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Stephenson [Tue, 20 Aug 2013 14:03:34 +0000 (10:03 -0400)]
Fix typo in release notes file name for acq-style-cancelled-delayed.
Rename acq-style-cancelled-delayted.txt to acq-style-cancelled-dealyed.txt.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Wed, 26 Dec 2012 21:43:20 +0000 (16:43 -0500)]
ACQ delayed lineitems style release notes
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Bill Erickson [Tue, 11 Dec 2012 15:26:30 +0000 (10:26 -0500)]
Improve styling for 'delayed' lineitems in PO UI
When a lineitem is cancelled, but "keep_debits" is true, the lineitem is
in effect delayed instead of truly cancelled. Make it more obvious in
the UI the difference between delayed and truly cancelled lineitems by
applying a row styling for delayed items (similar to other status row
styling) and always show the cancel reason (label) in the lineitem
display in the PO, next to the non-title attributes.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 14:32:42 +0000 (10:32 -0400)]
DB numbering for patron duplication check depth setting
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Lebbeous Fogle-Weekley [Fri, 16 Aug 2013 13:31:16 +0000 (09:31 -0400)]
Adjust Kyle Tomita's patron dupe check fix to use the depth concept
Addressing these comments:
https://bugs.launchpad.net/evergreen/+bug/
1185524/comments/3
And also renaming the OU setting to better peer with similar settings
affecting staff client (not OPAC) patron registration.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Kyle Tomita [Fri, 31 May 2013 18:33:59 +0000 (11:33 -0700)]
LP1185524 - Duplicate patron checking in the user editor is limited to workstation OU
Added a new library setting opac.duplicate_patron_check_use_consortium.
When true, the duplicate check will use the consortium (1) as the OU.
When false or not set, the duplicate check will use the workstation OU.
The setting is checked in subroutine that creates the search request and
sets the OU accordingly.
[LFW: Signing off but following with material changes next commit.]
Signed-off-by: Kyle Tomita <ktomita@catalystitservices.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Pasi Kallinen [Fri, 28 Jun 2013 06:44:44 +0000 (09:44 +0300)]
Use uri_escape_utf8 instead of uri_escape
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Steven Chan [Mon, 5 Aug 2013 16:13:54 +0000 (12:13 -0400)]
Fix LP985075, cannot save Patron Acquisition Request form
The form is shown using a dojo EditPane attached to an EditDialog,
however, attaching the pane was done manually, resulting in the dialog
acting improperly and the pane positioned improperly.
Instead, we use dojo's attr method to define the content attribute of
the dialog to be the pane.
Signed-off-by: Steven Chan <schan@sitka.bclibraries.ca>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Chris Sharp [Wed, 31 Jul 2013 15:03:25 +0000 (11:03 -0400)]
Fixing LP
1072892 - repeated rows in reporter.classic_item_list view
The view joined the actor.card table in such a way that all library
cards (active or not) were being returned. This commit changes that
behavior so that only the current card (from actor.usr.card) is returned.
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Fri, 7 Jun 2013 16:33:46 +0000 (19:33 +0300)]
Finish i18n support for config.usr_setting_type
Add the missing oils_i18n_gettext markers to config.usr_setting_type
inserts.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Dan Scott [Wed, 20 Feb 2013 02:06:05 +0000 (21:06 -0500)]
Flag cust & oust name/description fields as translatable
Setting type names and descriptions should be translatable, a simple
oils_persist:i18n attribute will do the trick.
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Tue, 13 Aug 2013 14:03:10 +0000 (10:03 -0400)]
LP1211506 fix numeric sorting in staff client grids
To recover numeric (vs. ascii-betical) sorting of number and money
values in grids, cast the cached sort values back into numbers.
This was tested in the billing interface, but should repair numeric
sorting for most grids.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Mon, 22 Jul 2013 07:16:36 +0000 (10:16 +0300)]
Always show grid buttons on My Selection List
Fix LP#
1028601 by showing the selection list creation buttons in the acq
search UI even when there are no search results.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Angela Kilsdonk [Mon, 12 Aug 2013 13:26:21 +0000 (09:26 -0400)]
Z39.50 documentation asciidoc fix and moved Z39.50 Servers to the appropriate location in root.txt.
Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Jason Stephenson [Fri, 9 Aug 2013 20:03:47 +0000 (16:03 -0400)]
Stamping upgrade script for long overdue status -- LP
1169193.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 6 May 2013 15:01:52 +0000 (11:01 -0400)]
LP
1169193 Support L/O xact close on paid
Middle-layer support for the org unit setting "Leave transaction
open when long overdue balance equals zero". It behaves the same
as "Leave transaction open when lost balance equals zero", but for
long-overdue circs.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Fri, 26 Apr 2013 16:59:33 +0000 (12:59 -0400)]
LP
1169193 Bypass longoverdue w/ default A/T runner
Avoid processing LONGOVERDUE circulations in the default
action_trigger_runner.pl filter.
When no custom filters are used, the script will provide it's own
default filter for circulation-based hooks. This change ensure that
when the default filter is in use, the script will not attempt to
process longoverdue circulations, since they have already been processed
(which is how they became longoverdue in the first place).
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Wed, 24 Apr 2013 18:09:12 +0000 (14:09 -0400)]
LP
1169193 long-overdue release notes
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Wed, 24 Apr 2013 15:05:02 +0000 (11:05 -0400)]
LP
1169193 transit_slip macro for copy status
Adds support for a new 'transit_slip' receipt template macro called
"transit_copy_status", which displays the stored status of the
in-transit copy (i.e. the status the copy will be placed in once it
arrives at the transit destination). This is useful, in particular, for
lost or long-overdue items which are not "immediately available" upon
checkin.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 22 Apr 2013 17:05:14 +0000 (13:05 -0400)]
LP
1169193 long-overdue item checkin
Checkin of long-overdue items now goes through a very simimlar process
as check-in of Lost items. Staff can control how long after the due
date (and potentially other date-related fields) the item may be
returned for a configurable set of refunds and/or reinstatement of
overdue fines. All settings are controlled by a series of new org unit
settings specifically related to long-overdue processing.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Wed, 17 Apr 2013 14:31:04 +0000 (10:31 -0400)]
LP
1169193 long-overdue automated processing
Middle layer components for marking circulations long overdue. The
automation is controlled with an Action/Trigger event definition
(sample included in seed data), which uses a new MarkItemLongOverdue
reactor. The reactor makes use of a new util function (AssetCommon.pm)
for doing the actual work and looking up the relevant org unit settings.
Inluded is a new PatronNotInCollections Validator, which can be used to
avoid marking circulations long overdue for patrons that are in
collections processing.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 15 Apr 2013 15:44:26 +0000 (11:44 -0400)]
LP
1169193 long-overdue SQL seed data
Seed data for managing long-overdue circulations.
* new copy status
* new billing types
* new org settings
* new permissions
* sample action/trigger event definitions
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Fri, 9 Aug 2013 19:16:09 +0000 (15:16 -0400)]
Finish stamping for bib record browser
Sorry for the noise...
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Dan Wells [Fri, 9 Aug 2013 19:12:58 +0000 (15:12 -0400)]
Stamping upgrade scripts for bib record browser
LP #
1177810
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Lebbeous Fogle-Weekley [Thu, 8 Aug 2013 14:27:10 +0000 (10:27 -0400)]
Fix problem where basic search bar was flush with left edge of page
Reported by Ben Shum.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Jason Stephenson [Fri, 26 Jul 2013 13:48:59 +0000 (09:48 -0400)]
Fix issues with multiple divs having the search-wrapper id.
Basically, remove the extra <div> from all the files that INCLUDE
searchbar.tt2, and leave the <div> that searchar.tt2 uses alone.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Lebbeous Fogle-Weekley [Mon, 22 Jul 2013 14:14:51 +0000 (10:14 -0400)]
OPAC Browse: bugfixes squashed together from LP #
1177810
In specific:
OPAC Browse: go back from numbered to bulleted results
OPAC Browse: Avoid showing tracing if linked authorities have no bibs
OPAC Browse: Replace English pager with customizable pager
OPAC Browse: Extra small bit of documentation about author headings
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Mike Rylander [Fri, 19 Jul 2013 16:35:31 +0000 (12:35 -0400)]
Break up expensive queries, match index to quals
First, we order browse queries over MBE by (sort_value, value) so we
want to match the unique index to that.
We're only going to use the first few rows of the cursors we build from
the back/forward MBE paging queries, and the embedded GROUP BY defeats
the planners desire to use an index for ordering the rows. So, instead,
we use a simpler core query and gather aggregate data as a secondary,
index-capable query for each MBE row.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Lebbeous Fogle-Weekley [Thu, 13 Jun 2013 20:22:13 +0000 (16:22 -0400)]
OPAC Browse: some squashed commits from LP #
1177810
Namely:
OPAC Browse: Various interface improvements
OPAC Browse: Put best-matched browse entry in middle of result set
OPAC Browse: Don't try to build hyperlinks from 680 ‡a
OPAC Browse: add a CSS class to the best-matching result when not paging
Remove unwanted space before question makr in "Did you mean" message
OPAC Browse: Fix browse interface's use of hits-per-page user setting
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Stephenson [Fri, 7 Jun 2013 14:31:30 +0000 (10:31 -0400)]
Fix problem with YYYY.schema.bib-auth-browse.sql.
Disable ALL triggers on authority.control_set_authority_field before
altering and updating the table to avoid an error related to altering
a table with pending trigger events.
The triggers are enabled again after the updates and alters are done.
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Lebbeous Fogle-Weekley [Wed, 24 Apr 2013 14:46:27 +0000 (10:46 -0400)]
Bib record browser with 'see also', etc from linked authority headings
This feature provides a patron-oriented OPAC interface for browsing
bibliographic records.
Users choose to browse by Author, Title, Subject, or Series. They then
enter a browse term, and the nearest match from a left-anchored search
on the headings extracted for browse purposes will be displayed in a
typical backwards/forwards paging display. Headings link to search
results pages showing the related records. If the browse heading is
linked to any authority records, and if any *other* authority records
point to those with "See also" or other non-main entry headings, those
alternative headings are displayed a linked to a search results page
showing related bib records related to the alternate heading.
The counts of holdings displayed next to headings from bibliographic
records are subject to the same visiibility tests as search. This means
that the org unit (and copy location group) dropdown on the browse
interface affects counds, and it further means that whether or not
you're looking at the browse interface through the staff client makes a
difference.
This builds on the two previous commits that provide inter-authority
linking and the linking of metabib.browse_entry rows to authority
records.
This also contains, in squashed form, these commits that resulted from
collaboration on LP #
1177810:
Two bugfixes to OPAC Browse: non-filing indicators, leading-article warning
Fix paste-o encountered in Bib browse upgrade script
OPAC Browse: fix 0-9 link in paging shortcuts; padding issues
OPAC Browse: Improve authority code to show more headings
OPAC Browse: Fix authority counting
Extensions to our MODS32 stylesheet to capture all possible NFI in fields
OPAC Browse: i18n improvement for short terms
OPAC Browser: Display Public General Notes from authorities when possible
OPAC Browse: Build browse entry sort_value column separately from value
OPAC Browse: We don't want role/relator info in browse headings
OPAC Browse: Better display of tracings from authorities
OPAC Browse: Pick up authority links from 650 fields
OPAC Browse: Show authority tracings only when inter-authority links exist
OPAC Browse: use superpage concept for performance; fix other counting bug
OPAC Browse: Fix broken authority reference link
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Lebbeous Fogle-Weekley [Thu, 28 Mar 2013 22:02:32 +0000 (18:02 -0400)]
Link browse entries to authority record when possible
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Lebbeous Fogle-Weekley [Fri, 22 Mar 2013 21:11:50 +0000 (17:11 -0400)]
Inter-authority linking
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Dan Wells [Tue, 2 Jul 2013 15:55:21 +0000 (11:55 -0400)]
Solidify caption/holding relationship, improve MFHD::Holding comparisons
[This commit has been squashed for merging. LFW]
* This commit:
- Makes sure that holding data is valid for the given caption
for new holding objects
- Teaches field_values() to fall back to '*' (unknown marker)
when a holding is missing data
- Allows the caption() method to be a setter
* This commit:
- Makes the comparison operator consider chron data, not just
enumeration data
- Teaches the comparison operator a way to handle 'unsure' data
(that is, data presented in brackets [])
* The code was assuming the $end_holding param would be uncompressed,
but this was not stated anywhere, nor enforced. Let's allow the
method to take both compressed and uncompressed holdings as the "end"
(and handle it appropriately).
* Add some holdings with missing and unsure data to test the new
comparison operators handling of such data.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Wed, 8 May 2013 19:09:41 +0000 (15:09 -0400)]
Fix logic in get_compressed_holdings()
[This commit has been squashed for merging. LFW]
* This commit rearranges some of the logic branches to protect
against an unusual case of having two holding statements with
the same start value, but one being open-ended and one not.
* The logic in get_combined_holdings() was a little sloppy and
repeated some steps unnecessarily. This cleans things up.
See the test case in the previous commit for more clarity.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Tue, 7 May 2013 22:23:27 +0000 (18:23 -0400)]
Tie in new MFHD method to serials module/MFHD tests for compressing, combining
[This commit has been squashed for merging. LFW]
* Now that we have a potentially better alternative, let's call
get_combined_holdings() in place of get_compressed_holdings() in
Serial.pm.
* First, add a test for the new get_combined_holdings() method.
Second, add a known problem case for get_compressed_holdings().
The fix will come in a subsequent commit.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Wells [Tue, 7 May 2013 22:19:34 +0000 (18:19 -0400)]
Add new get_combined_holdings() method to MFHD.pm
This commit adds a new method to the MFHD module which creates an
array of compressed holdings from all holdings for a given caption,
combining as needed.
NOTE: This method is similar to, but much less aggressive/strict than
get_compressed_holdings(). Ultimately, get_compressed_holdings()
might be deprecated in favor of this.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Angela Kilsdonk [Fri, 9 Aug 2013 14:31:34 +0000 (10:31 -0400)]
Documentation for storing Z39.50 credentials. Added to existing file on Z39.50 permissions.
Signed-off-by: Angela Kilsdonk <akilsdonk@esilibrary.com>
Lebbeous Fogle-Weekley [Mon, 24 Jun 2013 15:47:40 +0000 (11:47 -0400)]
Acq: When processing EDI invoices, skip unknown line item references
See LP #
1172373.
In their electronic invoices, vendors sometimes include a mix of line
items that your ILS knows about, because you ordered them through it,
and line items of which your ILS knows nothing. We should not fail
altogether at processing invoices, but instead process what line items
we can.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Lebbeous Fogle-Weekley [Tue, 16 Apr 2013 19:18:17 +0000 (15:18 -0400)]
Acq: When building invoices from EDI messages, avoid bad data
From some vendors, these EDI messages contain strings (useless ones,
like just the name of the vendor) where we had been expecting numeric
identifiers.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Wed, 17 Jul 2013 17:24:26 +0000 (20:24 +0300)]
Validate date ranges in Close Dates editor
Complain in Closed Dates Editor when ending date is earlier than starting date.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
Jason Etheridge [Mon, 5 Aug 2013 20:40:02 +0000 (16:40 -0400)]
Fix org unit setting names for this example test
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Tue, 23 Jul 2013 07:49:47 +0000 (10:49 +0300)]
Prevent paste from empty clipboard throwing an error
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Tue, 6 Aug 2013 16:20:33 +0000 (12:20 -0400)]
Add release note for checkout trimming whitespaces from beginning and end of barcodes
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Tue, 2 Jul 2013 16:36:53 +0000 (19:36 +0300)]
Trim whitespace from beginning and end of the barcode in checkout.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Ben Shum [Tue, 6 Aug 2013 16:13:15 +0000 (12:13 -0400)]
Stamping upgrade script for "delate" typo
Signed-off-by: Ben Shum <bshum@biblio.org>
Pasi Kallinen [Mon, 15 Jul 2013 07:01:57 +0000 (10:01 +0300)]
Fix typo "delate" in permission descriptions.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Bill Erickson [Fri, 17 May 2013 13:39:26 +0000 (09:39 -0400)]
Upgrade notes for IDL2js locale support
Minor Apache configuration change required.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 6 May 2013 13:59:22 +0000 (09:59 -0400)]
LP1171875 Support locale CGI param for fm_IDL.xml
Adds support for passing the locale string directly to
/reports/fm_IDL.xml via locale= CGI parameter.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Fri, 26 Apr 2013 17:20:24 +0000 (13:20 -0400)]
LP1171875 Add locale support to IDL2js
/IDL2js now reads locale information from either locale= CGI parameter
or Accept-Language HTTP headers. The locale-aware IDL is loaded from
/reports/fm_IDL.xml via Apache subrequest. Each full copy of the IDL is
cached within the Apache processes to avoid the need to re-parse the IDL ad
infinitum for full IDL retrieval. Partial IDL retrieval is also supported
(but not cached).
No attempt is made to cleanse the locale -- invalid locale strings are
discarded -- so it's the callers responsibility to pass a valid locale.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jeff Godin [Tue, 29 May 2012 14:28:50 +0000 (10:28 -0400)]
Fix IDL and OU setting check for staged users
The IDL had references to sequences that do not exist:
staging.usr_stage_row_id_seq -- a typo, fixed
In the case of staging.billing_address_stage_row_id_seq, the
staging.billing_address_stage table is created with LIKE,
and uses the sequence staging.mailing_address_stage_row_id_seq
The OU setting check for the open-ils.actor.user.stage.create API
call was not passing an org unit, and would always fail.
We now pass the home_ou of the user being staged.
At this point, the opac.allow_pending_user OU setting type must
be manually created before its value can be set.
Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Jason Stephenson [Thu, 1 Aug 2013 19:27:18 +0000 (15:27 -0400)]
Stamping upgrade script for LP1204273.
Repair org unit settings for making state not required
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Ben Shum [Mon, 22 Jul 2013 19:10:37 +0000 (15:10 -0400)]
LP1204273 - Repair org unit settings for making state not required
As noted by tsbere in IRC, the org unit settings were using "au" instead of "aua"
which led to issues applying the settings and making the addresses require the
state field.
Also, change the constraint for field_name on actor.org_unit_setting_type_log to
be "DEFERRABLE INITIALLY DEFERRED" to be more flexible and consistent with other
parts of the database relating to org unit setting names.
And, the table auditor.actor_usr_address_history needs to be updated so that
state can be NULL there as well.
Signed-off-by: Ben Shum <bshum@biblio.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Jason Etheridge [Mon, 22 Jul 2013 23:03:24 +0000 (19:03 -0400)]
make-pgtap-tests.pl
For seeding a baseline set of pgTAP tests for Evergreen. By default, assumes
PostgreSQL is running on localhost at port 5432 with a database name of
"evergreen", and with an "evergreen" user configured with password "evergreen".
Command-line options for tweaking these are
-db_name=? -db_host=? -db_port=? -db_user=? -db_pw=?
Make sure to install pgTAP (probably best do it from source for all the
assertion functions we're using) for the database you want to run the tests
against.
I did the following for my test environment:
git clone git://github.com/theory/pgtap.git
cd pgtap
make
make installcheck
sudo make install
Then in my Evergreen database with psql, I did:
CREATE EXTENSION pgtap;
I also installed a CPAN module to get pg_prove:
sudo cpan TAP::Parser::SourceHandler::pgTAP
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Mon, 24 Jun 2013 20:07:44 +0000 (16:07 -0400)]
Use the .pg extension
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 12 Apr 2013 06:41:47 +0000 (02:41 -0400)]
add regression test for LP#
1155329
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Fri, 12 Apr 2013 06:21:09 +0000 (02:21 -0400)]
use .pg extension for pgTAP test cases
That way, pg_prove --recurse t/ will DWIM.
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Galen Charlton [Thu, 11 Apr 2013 00:18:10 +0000 (20:18 -0400)]
start adding pgTAP test cases
pgTAP is a PostgreSQL unit testing framework; about which
more can be found at http://pgtap.org/
This commit introduces the first pgTAP test case, which exercises
the NACO normalization functions.
To run the tests, install pgTAP, create an Evergreen database that
contains (for now) just the seed data, and from the top of the
source tree run
pg_prove -vr -U evergreen Open-ILS/src/sql/Pg/t/*
Replace '-U evergreen' with the psql command-line switches
needed to access your database.
To install pgTAP on a Debian Wheezy system, you can do:
Then, to load the pgTAP extension into the database, run
psql> CREATE EXTENSION pgtap;
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Mon, 24 Jun 2013 19:36:10 +0000 (15:36 -0400)]
pgTAP examples
These specific ones do not assume stock test data such as the concerto bibs, and
I think such tests should go elsewhere. You need to install pgTAP. I did the
following for my test environment:
git clone git://github.com/theory/pgtap.git
cd pgtap
make
make installcheck
sudo make install
Then in my Evergreen database with psql, I did:
CREATE EXTENSION pgtap;
I also installed a CPAN module to get pg_prove:
sudo cpan TAP::Parser::SourceHandler::pgTAP
You can use psql to run a given test like so:
opensrf@dev141:~/git/Evergreen/Open-ILS/src/sql/Pg/t (pgtap)$ psql -d evergreen -f 0799.state_field_required_toggle.s
1..4
ok 1 - actor.usr_address.state does not have the NOT NULL constraint
ok 2 - ui.patron.edit.au.state.require exists
ok 3 - ui.patron.edit.au.state.show exists
ok 4 - ui.patron.edit.au.state.suggest exists
Or you can use pg_prove on all or some of them:
opensrf@dev141:~/git/Evergreen/Open-ILS/src/sql/Pg/t (pgtap)$ pg_prove -d evergreen *.s
0799.state_field_required_toggle.s .. ok
dewey.s ............................. 1/6
# Failed (TODO) test 6: "testing prefix plus decimal"
# 'YR_DVD_800_100000000000000'
# <
# 'YR_000000000000000_DVD_900'
dewey.s ............................. ok
schema.s ............................ ok
versions.s .......................... ok
All tests successful.
Files=4, Tests=39, 0 wallclock secs ( 0.05 usr 0.03 sys + 0.13 cusr 0.07 csys = 0.28 CPU)
Result: PASS
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Tue, 25 Jun 2013 20:54:45 +0000 (16:54 -0400)]
C unit test examples for Evergreen
Building off of Kevin Beswick's work in OpenSRF
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Tue, 25 Jun 2013 21:02:37 +0000 (17:02 -0400)]
The check library for Debian and Fedora
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Thu, 13 Jun 2013 19:45:11 +0000 (15:45 -0400)]
Test for an MFHD warning in 14-OpenILS-Utils.t
Specifically "Cannot compress without pattern data, returning original holdings"
I also added Test::Warn to Makefile.install for Debian and Fedora.
--
Bill moved the @comp_holdings variable declaration outside of the
warning_like block to avoid a new warning:
Name "main::comp_holdings" used only once: possible typo at
t/14-OpenILS-Utils.t line 42.
---
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Jason Etheridge [Thu, 13 Jun 2013 18:40:45 +0000 (14:40 -0400)]
Eliminate a warning in Z3950.pm
Noticed in 06-OpenILS-Application-Search.t:
Odd number of elements in anonymous hash at /usr/local/share/perl/5.10.1/OpenILS/Application/Search/Z3950.pm line 532.
Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Thomas Berezansky [Wed, 24 Jul 2013 14:02:08 +0000 (10:02 -0400)]
Fix error on deleted hold in transit
May be caused by purging holds combined with "Checkout fills related hold"
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Pasi Kallinen [Mon, 17 Jun 2013 10:30:59 +0000 (13:30 +0300)]
Fix transposed acq invoice receive table column titles
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Bill Erickson [Mon, 8 Jul 2013 15:13:23 +0000 (11:13 -0400)]
LP1195150 batch update funds alters debits
When a fund is updated via the ACQ batch update bar (along the top of
the PO interface), ensure that any existing fund debits are updated to
use the new fund. If the selected fund exceeds the balance block
percent, the operation will fail and the user will be notified.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Bill Erickson [Mon, 22 Jul 2013 19:21:15 +0000 (15:21 -0400)]
LP1203753 AuthProxy barcode login support
When users attempt a barcode-based login with AuthProxy, the system will
determine the username of the user (based on the barcode) and use the
username instead of the barcode for all proxied login attempts. This
allows users to use their barcodes (or barcode-looking usernames) to
log in via remote authenticators.
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Lebbeous Fogle-Weekley [Thu, 11 Jul 2013 18:50:49 +0000 (14:50 -0400)]
Link checker: verification review UI needs more columns about redirects
Link checker results can contain information about redirects when URLs
in a bib record happen to point to systems that return 3XX repsonses.
All this is nicely captured in the uvuv and uvu tables, but the
user interface only offers the uvu.redirect_from column, when
uvuv.redirect_to and uvu.id are also necessary to understanding redirect
relationships among the results.
Reported by Erica Rohlfs and Bill Erickson.
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Scott [Mon, 22 Jul 2013 14:55:14 +0000 (10:55 -0400)]
Wrap upgrade script for TPAC library name links
Signed-off-by: Dan Scott <dan@coffeecode.net>
Dan Scott [Mon, 8 Jul 2013 18:06:48 +0000 (14:06 -0400)]
Support linking to library info from copy display
If the "Library information URL" library setting has a value, then the
copy display section of the TPAC and KPAC will turn the library name
for that branch into a link to the given URL. This supports the patron
goal of quickly finding branch information such as hours of operation,
directions, and contact information.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Mike Rylander [Thu, 18 Jul 2013 18:48:36 +0000 (14:48 -0400)]
Point feeds to TPAC instead of slimpac or JSPAC
Where possible, point to TPAC endpoints for HMTL output of supercat feeds.
Also, just use the bookbag (container) name for bookbag feeds, instead of
wrapping them in formatting and context. The description element already
provides that.
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Pasi Kallinen [Fri, 19 Jul 2013 06:04:04 +0000 (09:04 +0300)]
Fix LP#
1187402: Datafield contents turned undefined in Marc Editor after adding 006, 007 or 008
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Mike Rylander [Wed, 17 Jul 2013 21:13:57 +0000 (17:13 -0400)]
Explicit function ownership is not the job of upgrade scripts
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 17 Jul 2013 20:29:36 +0000 (16:29 -0400)]
Pulling in 2.4.1 upgrade script
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Tue, 16 Jul 2013 20:58:57 +0000 (16:58 -0400)]
Optimize away always-true hold count clause
When rendering results in the tpac we request hold counts for each record.
Most of the time (that is, whenever org unit hiding is /not/ in use) we
filter, essentially, on "where pickup_lib is in the org tree". This is
both useless and slow, so this commit will recognize that and optimize the
test away.
[LFW: fixed typo]
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Dan Scott [Mon, 24 Jun 2013 14:12:50 +0000 (10:12 -0400)]
Avoid Z39.50 search warning for uninit var
The debug log blindly attempts to access list members that might not
exist (if, for example, an event code was returned from the attempt to
run do_service_search()), thus generating spurious log warnings.
Instead, move the debug line to only generate output when we have
created the list item in question.
Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 17 Jul 2013 17:29:14 +0000 (13:29 -0400)]
Stamping upgrade script for copy stats SP fix
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Fredrick Parks [Wed, 10 Jul 2013 18:12:17 +0000 (11:12 -0700)]
LP
1103706 Hold ratios in circ policies cause errors when trying to renew items
Changed the function action.copy_related_hold_stats to accept a bigint as the perameter instead of an integer.
Copy_related_hold_stats is only called by the function action.item_user_circ_test which trys to pass a bigint.
Signed-off-by: Fredrick Parks <fparks@catalystitservices.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Wed, 17 Jul 2013 17:25:29 +0000 (13:25 -0400)]
Stamping upgrade script for authority labeling fix
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Lebbeous Fogle-Weekley [Thu, 11 Jul 2013 19:31:37 +0000 (15:31 -0400)]
Authorities: 4XX fields have wrong names
In Evergreen we have authority fields defined in the database that
relate to control sets. These are used somewhere today (I'm fuzzy on
that at the moment; some places once had and may still have hardcoded
labels) but they also will be used by the bib and auth browser
that's not yet merged to master (see LP #
1177810).
The 4XX tags among the set I'm talking about (in
authority.control_set_authority_fields) are mislabled, saying See Also
where they ought to say See From, e.g.
http://www.loc.gov/marc/authority/ad400.html
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Mike Rylander [Fri, 12 Jul 2013 17:11:57 +0000 (13:11 -0400)]
Implement a concurrent-run cache for result rendering a la initial search queue compression
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Pasi Kallinen [Tue, 16 Jul 2013 15:33:32 +0000 (18:33 +0300)]
Fix untranslatable strings in the selfcheck interface.
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Michael Peters [Wed, 22 Aug 2012 12:25:25 +0000 (08:25 -0400)]
Initial selfcheck styling enhancements
* Convert action links to buttons for increased clarity
* Convert dashed fieldsets to gradient backed bubbles for depth
* Color line-item table headers to distinguish from actual line-items
* Color logo background for increased contrast
* Larger input box
* Background on prompts to distinguish from logo background
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Pasi Kallinen <pasi.kallinen@pttk.fi>
Signed-off-by: Ben Shum <bshum@biblio.org>
Conflicts:
Open-ILS/src/templates/circ/selfcheck/main.tt2
Open-ILS/src/templates/circ/selfcheck/summary.tt2
Signed-off-by: Ben Shum <bshum@biblio.org>
Kathy Lussier [Tue, 16 Jul 2013 20:02:31 +0000 (16:02 -0400)]
Merge branch 'master' of git://git.evergreen-ils.org/Evergreen into sticky-acq-fields-docs
Kathy Lussier [Tue, 16 Jul 2013 19:47:28 +0000 (15:47 -0400)]
Documentation for default values in Load Order Record form
Documentation for new default values and sticky fields in the acq Load
MARC Order Records form. I also moved up/modified 2.1 docs for this
interface and integrated them with the 2.2 acq/Vandelay integration docs.
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Dan Wells [Wed, 10 Oct 2012 13:22:33 +0000 (09:22 -0400)]
Capture and log AuthProxy logins with no account
The current AuthProxy.pm code assumes that if the external auth
passes, the Evergreen account will be there. This protects
against cases where a user is in the external auth system but
has no matching account in Evergreen.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Wells [Wed, 10 Oct 2012 13:22:33 +0000 (09:22 -0400)]
Capture and log AuthProxy logins with no account
The current AuthProxy.pm code assumes that if the external auth
passes, the Evergreen account will be there. This protects
against cases where a user is in the external auth system but
has no matching account in Evergreen.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Dan Wells [Thu, 27 Sep 2012 21:35:03 +0000 (17:35 -0400)]
Make AuthProxy LDAP bind code more robust
The existing version of LDAP_Auth.pm assumed that the user's
bind DN could be derived from the base DN, the ID attribute, and
the user's ID. This is frequently the case, but not always,
particularly in Active Directory setups using sAMAccountName. This
commit instead uses the initial LDAP lookup as the authority for
determining the user's DN.
Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Bill Erickson <berick@esilibrary.com>
Liam Whalen [Mon, 15 Jul 2013 04:00:14 +0000 (21:00 -0700)]
Fixes error with generate_fines for overdues returned after closed date
If an overdue is returned after a closed date, the generate_fines code
will not generate fines for those items because the section of code that
checks for closed dates returns from the function if a closed date is
encountered.
For example, if an item is due on June 29th, but is not returned until
after July 1st (Canada Day), then when fines are generated for the item,
generate fines creates a fine for the 30th of June, but when it
gets to the 1st of July it encouters a closed date and executes a
'return' statement which exits the generate_fines code causing the
fine from June 30th to be rolled back as well as preventing
further fines from being generated.
This fix replaces the 'return' statements inside the 'for' loop that is
nested within the eval with 'next' statements.
Signed-off-by: Liam Whalen <whalen.ld@gmail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>
projects / working / Evergreen.git / log