evergreen/pines.git
10 years agoAdding LSTA funding attribution as per Elizabeth's request.
Terran McCanna [Wed, 21 Oct 2015 20:14:04 +0000 (16:14 -0400)]
Adding LSTA funding attribution as per Elizabeth's request.

10 years agoAdding LSTA funding line to KPAC.
Terran McCanna [Wed, 21 Oct 2015 20:40:11 +0000 (16:40 -0400)]
Adding LSTA funding line to KPAC.

10 years agoEnable Halloween holiday feature in KPAC.
Terran McCanna [Thu, 10 Sep 2015 19:43:31 +0000 (15:43 -0400)]
Enable Halloween holiday feature in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:
Open-ILS/examples/kpac.xml

10 years agoChange links old library map to new interactive library locator map.
Terran McCanna [Thu, 10 Sep 2015 19:23:42 +0000 (15:23 -0400)]
Change links old library map to new interactive library locator map.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoUpdated link to old library map to new library locator map in KPAC.
Terran McCanna [Thu, 10 Sep 2015 19:38:44 +0000 (15:38 -0400)]
Updated link to old library map to new library locator map in KPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoAdded PINES Quick Reports icon and link to Evergreen Staff Client
Terran McCanna [Thu, 10 Sep 2015 21:58:15 +0000 (17:58 -0400)]
Added PINES Quick Reports icon and link to Evergreen Staff Client
main page. The link will open in a browser window.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agolp1466201 Disable Google Analytics in the staff client
Kathy Lussier [Fri, 10 Jul 2015 03:23:08 +0000 (23:23 -0400)]
lp1466201 Disable Google Analytics in the staff client

As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics
outright in the staff client; there's far too much potential for leaking patron
information." This branch aims to do so.

Test plan: Enable Google Analytics in config.tt2. Access the catalog in the
staff client. Click Debug to view the source code. Pre-patch, you'll see
the Google Analytics javascript within the head element. Post-patch, that
javascript will be gone. Viewing the source of a catalog page in a browser
should continue to show the Google Analytics javascript within the head element.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoEnabled Google Analytics for OPAC usage tracking.
Terran McCanna [Mon, 31 Aug 2015 18:53:12 +0000 (14:53 -0400)]
Enabled Google Analytics for OPAC usage tracking.

10 years agoLP1402018_Acq_Copy_location_UI_scoped_to_registered_workstation
blake [Mon, 5 Jan 2015 16:38:18 +0000 (10:38 -0600)]
LP1402018_Acq_Copy_location_UI_scoped_to_registered_workstation

This little patch will open up the acq copy location dropdown UI
to include other library's copy locations outside of the workstation
registration. When the user permissions are scoped to more branches.

Signed-off-by: blake <blake@mobiusconsortium.org>
10 years agoAdds B4 Book Log icon to KPAC search results page and
Terran McCanna [Wed, 27 May 2015 16:57:48 +0000 (12:57 -0400)]
Adds B4 Book Log icon to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

10 years agoAdds B4 Book Log icon and link to KPAC search results page and
Terran McCanna [Tue, 26 May 2015 13:09:27 +0000 (09:09 -0400)]
Adds B4 Book Log icon and link to KPAC search results page and
KPAC item details page.

(This is a PINES-only customization.)

Conflicts:
Open-ILS/src/templates/kpac/parts/record_row.tt2
Open-ILS/src/templates/kpac/record.tt2

10 years agoAdding GALILEO in-library link logic to topnav links.
Chris Sharp [Mon, 4 May 2015 20:49:01 +0000 (16:49 -0400)]
Adding GALILEO in-library link logic to topnav links.

10 years agoPINES/GALILEO avoid auth redirect within library
Bill Erickson [Wed, 25 Sep 2013 19:18:35 +0000 (15:18 -0400)]
PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

10 years agoLP#1446860 - Correct mistaken logic in previous fix.
Chris Sharp [Wed, 22 Apr 2015 13:54:11 +0000 (09:54 -0400)]
LP#1446860 - Correct mistaken logic in previous fix.

See https://bugs.launchpad.net/evergreen/+bug/1446860/comments/2
for reference.  The logic was not enforcing the "if the editing
staff member doesn't have permission to edit a user in this
permission group" check.  This corrects that.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
10 years agoLP#1446860 Staff were able to edit their own accounts.
Chris Sharp [Tue, 21 Apr 2015 21:10:49 +0000 (17:10 -0400)]
LP#1446860 Staff were able to edit their own accounts.

This change reverses what appears to be a thinko in the
original programming.  If the editing user is the same
as the user being edited, disable the Save button.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
10 years agoLP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations...
blake [Fri, 10 Apr 2015 19:29:08 +0000 (14:29 -0500)]
LP1424646 Paid-For Long Overdue Items Still Appear in "Other/Special Circulations" Window

Edited the query inside the fm_IDL.xml file

Signed-off-by: blake <blake@mobiusconsortium.org>
10 years agoLP #1406350 Mobile Device Navigation Issue Fix for Shelf Browser
Adam Bowling [Tue, 20 Jan 2015 21:54:11 +0000 (16:54 -0500)]
LP #1406350 Mobile Device Navigation Issue Fix for Shelf Browser

Currently, when a browser window is narrowed too much, whether
in a mobile browser, or on a desktop or laptop machine, the
"Previous Page" and "Next Page" navigation links disappear. The
only solution that seems to solve this is by removing the
"THEAD" element from the shelf browser table.

This patch removes that tag, adds a new row to imitate a new
border as existed before, and modifies the CSS in .../opac/
css/style.css.tt2 to address that difference.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
Signed-off-by: Yamil Suarez <yamil@yamil.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agobranding the built-in selfcheck interface for PINES
Chris Sharp [Wed, 1 Apr 2015 17:16:03 +0000 (13:16 -0400)]
branding the built-in selfcheck interface for PINES

10 years agoLP#1206589: Temporary Fix for Org. Unit Settings History Bug
Jason Stephenson [Tue, 24 Feb 2015 19:05:16 +0000 (14:05 -0500)]
LP#1206589: Temporary Fix for Org. Unit Settings History Bug

This commit makes two changes to the coustl IDL entry.

1. It adds a retrieve permission of STAFF_LOGIN.  This at least
requires someone with staff permission to be able to view settings
history.

2. It fixed the primary key field from date_applied to id.  The
prior setting was just an outright error.

NOTE: This is intended as a short term fix for the Library Settings
Editor history feature.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1424755: Org Unit Setting view permissions can be bypassed
Jason Stephenson [Wed, 18 Feb 2015 21:28:31 +0000 (16:28 -0500)]
LP#1424755: Org Unit Setting view permissions can be bypassed

Fix private org. unit setting leakage by forcing the $auth argument
to true if not passed in when open-ils.actor.ou_setting.ancestor_default
or open-ils.actor.ou_setting.ancestor_default.batch are called.

Other than a change to the desc of the public methods to reflect that
they now check permissions if permissions are required, there are no
required api changes to the back or the front ends.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoSadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who...
Chris Sharp [Sat, 28 Feb 2015 12:54:21 +0000 (07:54 -0500)]
Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

10 years agoLP1194860 You have permission to override some of the failed holds. appearing when...
blake [Mon, 8 Dec 2014 21:52:15 +0000 (15:52 -0600)]
LP1194860 You have permission to override some of the failed holds. appearing when it should not for patrons in the OPAC Edit

A quick value check before assigning the override variable.
This should eliminate the OPAC showing the override option
for those who do not have the permission.

Signed-off-by: blake <blake@mobiusconsortium.org>
10 years agoLP#1414112: Correct usage of WITH clause for UPDATE.
Chris Sharp [Tue, 27 Jan 2015 18:33:39 +0000 (13:33 -0500)]
LP#1414112: Correct usage of WITH clause for UPDATE.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
10 years agoLP#1414112: Seed data and avoid reingest
Mike Rylander [Mon, 26 Jan 2015 16:44:45 +0000 (11:44 -0500)]
LP#1414112: Seed data and avoid reingest

Update search metadata without a reingest by identifying records that
use a space in the audience field, and be sure that the coded value map
has a space for "uncoded" audience.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoLP#1414112: avoid excluding record attribute values that contain only blanks
Galen Charlton [Mon, 26 Jan 2015 16:05:10 +0000 (16:05 +0000)]
LP#1414112: avoid excluding record attribute values that contain only blanks

Certain record attributes, chiefly the ones whose values comes
from MARC fixed fields and which have a coded value map associated
with them, can have a string consisting of one or more blanks as a
valid value.  Consequently, this patch ensures that
reingest_record_attributes() no longer excludes all attributes that
have blank values from the final attribute list.

This fixes a problem where MARC records with the target audience (008/22)
coded as a blank (unknown or not specified) could no longer be retrieved
using an "audience( )" search filter.

After applying this patch, a reingest of record attributes should be
performed, e.g., by doing

  select metabib.reingest_record_attributes(id)
  from biblio.record_entry
  where not deleted;

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
10 years agoMake users_of_interest test for defined actor.usr.card values
Michael Peters [Thu, 20 Nov 2014 22:41:44 +0000 (17:41 -0500)]
Make users_of_interest test for defined actor.usr.card values

If the open-ils.collections.users_of_interest API encounters a patron that
has a null "card" value in actor.usr the API will crash with an error like:

Received Exception:
Name: osrfMethodException
Status:  *** Call to [open-ils.collections.users_of_interest.retrieve] failed for session [1416515351.333446.1416515351406], thread trace [1]:
Can't call method "barcode" on an undefined value at /usr/local/share/perl/5.14.2/OpenILS/Application/Collections.pm line 299.

This patches users_of_interest to be sure that the user has a defined value
for actor.usr.card before proceeding to pull out the barcode for the results
of the API call.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
10 years agoHeader and Footer display changes to improve the way they display
Terran McCanna [Thu, 22 Jan 2015 17:29:09 +0000 (12:29 -0500)]
Header and Footer display changes to improve the way they display
on mobile devices and smaller-width windows.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agorestoring commented out checkbox to allow multiple hold requests on the same title
Chris Sharp [Thu, 22 Jan 2015 16:07:29 +0000 (11:07 -0500)]
restoring commented out checkbox to allow multiple hold requests on the same title

10 years agoTweaks to layout of holdings on item details page.
Terran McCanna [Mon, 19 Jan 2015 23:14:12 +0000 (18:14 -0500)]
Tweaks to layout of holdings on item details page.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoMade table cells in holdings white to temporarily solve CSS display
Terran McCanna [Mon, 19 Jan 2015 19:54:50 +0000 (14:54 -0500)]
Made table cells in holdings white to temporarily solve CSS display
issue in staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoRevert "LP#1406387 Fix for Holds Placement Advanced Options"
Chris Sharp [Mon, 19 Jan 2015 20:13:06 +0000 (15:13 -0500)]
Revert "LP#1406387 Fix for Holds Placement Advanced Options"

Not working for us yet, so reverting.

This reverts commit 2322ee5ae9cbe3caefb6998d62c3716cf40411a3.

10 years agoLP#1406387 Fix for Holds Placement Advanced Options
Adam Bowling [Mon, 19 Jan 2015 17:05:19 +0000 (12:05 -0500)]
LP#1406387 Fix for Holds Placement Advanced Options

In the staff client, when placing a hold and clicking
Advanced Hold Options, the barcode input will populate
with the staff member's barcode if it was previously
empty, regardless of whether the radio input for the
hold was specified for a patron or the staff member.

This patch corrects that behavior, and also populates
the input radio on load after clicking Advanced Hold
Options.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
10 years agoLP#1233853 Potential Matches for Patron Registration
Adam Bowling [Fri, 16 Jan 2015 22:18:24 +0000 (17:18 -0500)]
LP#1233853 Potential Matches for Patron Registration

This patch fixes the error, while registering a new patron
and clicking the link "Found {$0} patron(s) with the same
name" did not previously work in the staff client.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
10 years agoCorrected KPAC hold notification code to allow for text messaging preferences.
Terran McCanna [Thu, 11 Dec 2014 23:38:31 +0000 (18:38 -0500)]
Corrected KPAC hold notification code to allow for text messaging preferences.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoRevert "Revert "Update ContentCafe Added Content Module""
Chris Sharp [Sun, 18 Jan 2015 20:32:37 +0000 (15:32 -0500)]
Revert "Revert "Update ContentCafe Added Content Module""

This reverts commit bd7b7ee5b0b323967cb8fcb22c20c5a405e650bf.

10 years agoRevert "Update ContentCafe Added Content Module"
Chris Sharp [Sun, 18 Jan 2015 20:20:09 +0000 (15:20 -0500)]
Revert "Update ContentCafe Added Content Module"

Experimenting with reverting this commit, which appears to
break Syndetics (and we don't use ContentCafe).

This reverts commit 164c7e7bc4e542af9ada4ea2716cbce784820e6d.

10 years agoFix to Advanced Search 'Clear Form' button not clearing
Terran McCanna [Sun, 18 Jan 2015 18:57:13 +0000 (13:57 -0500)]
Fix to Advanced Search 'Clear Form' button not clearing
previously selected library.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoRevert label change on item detail page from 'Related electronic
Terran McCanna [Sun, 18 Jan 2015 19:05:47 +0000 (14:05 -0500)]
Revert label change on item detail page from 'Related electronic
resources' to 'Electronic resources.'

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoCapitalized 'Closed' on library pages.
Terran McCanna [Sun, 18 Jan 2015 19:01:06 +0000 (14:01 -0500)]
Capitalized 'Closed' on library pages.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoKPAC 2.7 Upgrade Tweaks
Terran McCanna [Tue, 23 Dec 2014 16:20:32 +0000 (11:20 -0500)]
KPAC 2.7 Upgrade Tweaks

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/examples/kpac.xml

10 years agoFix to grouped search result set navigation bar display issue in OPAC.
Terran McCanna [Mon, 12 Jan 2015 21:14:56 +0000 (16:14 -0500)]
Fix to grouped search result set navigation bar display issue in OPAC.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoFixes new row on advanced search by adding a blank input field
Adam Bowling [Thu, 8 Jan 2015 19:13:36 +0000 (14:13 -0500)]
Fixes new row on advanced search by adding a blank input field

Currently, adding a new row on the advanced search page causes
a new type selector and input field to be added, but the input
field is pre-populated with a value from a previous field.
This patch adds the field with a blank value.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
10 years agoremoving reference to dates with slashes / in the example text
Chris Sharp [Mon, 12 Jan 2015 19:51:53 +0000 (14:51 -0500)]
removing reference to dates with slashes / in the example text

10 years agoDisallow patron self-registration form to accept slashes in dob
Terran McCanna [Mon, 12 Jan 2015 19:21:47 +0000 (14:21 -0500)]
Disallow patron self-registration form to accept slashes in dob
(further modification to https://bugs.launchpad.net/evergreen/+bug/1361266)

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoTweaks to OPAC UI - account login page, my account holds page, text call number page
Terran McCanna [Mon, 12 Jan 2015 18:49:06 +0000 (13:49 -0500)]
Tweaks to OPAC UI - account login page, my account holds page, text call number page

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoFix for https://bugs.launchpad.net/evergreen/+bug/1396263
Terran McCanna [Mon, 12 Jan 2015 18:50:27 +0000 (13:50 -0500)]
Fix for https://bugs.launchpad.net/evergreen/+bug/1396263
- return to record link broken after texting call number

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agodisable setting requiring initials for copy notes
Chris Sharp [Fri, 9 Jan 2015 14:32:21 +0000 (09:32 -0500)]
disable setting requiring initials for copy notes

10 years agoreplacing copy_table.tt2 with the correct version
Chris Sharp [Tue, 6 Jan 2015 21:33:18 +0000 (16:33 -0500)]
replacing copy_table.tt2 with the correct version

10 years agoFix for KPAC holdings display issue.
Terran McCanna [Tue, 6 Jan 2015 20:51:54 +0000 (15:51 -0500)]
Fix for KPAC holdings display issue.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoFix for too-large header sizes causing display issues in KPAC
Terran McCanna [Tue, 6 Jan 2015 19:59:43 +0000 (14:59 -0500)]
Fix for too-large header sizes causing display issues in KPAC

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoPreparing kpac.xml for upgrade
Chris Sharp [Tue, 6 Jan 2015 20:04:24 +0000 (15:04 -0500)]
Preparing kpac.xml for upgrade

10 years agobringing in current kpac.xml
Chris Sharp [Tue, 6 Jan 2015 20:01:18 +0000 (15:01 -0500)]
bringing in current kpac.xml

10 years agoStarting the upgraded version with MLK Day
Chris Sharp [Tue, 6 Jan 2015 19:51:48 +0000 (14:51 -0500)]
Starting the upgraded version with MLK Day

10 years agoModified KPAC login code to redirect to KPAC after logging in
Terran McCanna [Tue, 6 Jan 2015 19:24:29 +0000 (14:24 -0500)]
Modified KPAC login code to redirect to KPAC after logging in

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/parts/header.tt2

10 years agoFix for KPAC multi-format items
Terran McCanna [Tue, 6 Jan 2015 18:30:27 +0000 (13:30 -0500)]
Fix for KPAC multi-format items

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Conflicts:

Open-ILS/src/templates/kpac/record.tt2
Open-ILS/web/css/skin/default/kpac/style.css

10 years agoTweak to make library selector box wider in OPAC only.
Terran McCanna [Tue, 6 Jan 2015 18:51:39 +0000 (13:51 -0500)]
Tweak to make library selector box wider in OPAC only.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
10 years agoKPAC Login Redirect Fix
Adam Bowling [Wed, 31 Dec 2014 16:47:01 +0000 (11:47 -0500)]
KPAC Login Redirect Fix

Fixes the redirect from the KPAC login to return back to the
home page of the KPAC from the /opac/login screen, rather
than back to the /opac/home screen, which is the current
behavior, and confuses users of the KPAC when they end
up back in the OPAC after having logged in.

Signed-off-by: Adam Bowling <abowling@emeralddata.net>
10 years agoCorrecting typo that breaks this template.
Chris Sharp [Tue, 6 Jan 2015 13:07:06 +0000 (08:07 -0500)]
Correcting typo that breaks this template.

10 years agoLP#1361266 Patron self-registration form accepts date of birth in wrong format
Michael Peters [Thu, 4 Dec 2014 20:56:53 +0000 (15:56 -0500)]
LP#1361266 Patron self-registration form accepts date of birth in wrong format

This patch applys some basic javascript to validate that a date entered is
at least in ISO 8601 format.  This prevents someone from entering "cupcake"
or 55/66/6666 as a valid date of birth by validating the stgu.dob input
at the time of submission.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
10 years agoLP#1319964 "Summaries & More" displays improperly in TPAC
Michael Peters [Mon, 8 Dec 2014 17:08:21 +0000 (12:08 -0500)]
LP#1319964 "Summaries & More" displays improperly in TPAC

Commit 14eb3d30 added HTML-escaping of OPAC extras display
labels, meaning that if an ampersand in such a label is
desired, it should be entered in the template just as an ampersand.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
[Amended original commit to tweak message and remove unecessary changes
 to .po files, which are rebuilt when a release is rolled.]

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoRestore "Add Search Row" functionality to Advanced Search tab
Michael Peters [Fri, 5 Dec 2014 17:43:18 +0000 (12:43 -0500)]
Restore "Add Search Row" functionality to Advanced Search tab

My new function for Expert Search tab inadvertently broke
the Add Search Row link on the Advanced Search tab.

This restores the addSearchRow() function that was moved inside of
the new function for Expert Search.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
10 years agoModify style.css.tt2 to make sure all new rows have bold labels
Michael Peters [Fri, 5 Dec 2014 16:55:21 +0000 (11:55 -0500)]
Modify style.css.tt2 to make sure all new rows have bold labels

Previously, "Add Search Row" added new rows without the labels
being bold because they have an id=null.  This sets a selector
for the expert_* labels so that the new rows are bolded too.

This makes for better readibility on the page.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
10 years agoLP#1154656 MARC Expert Search "Add Rows" adds duplicate row
Michael Peters [Fri, 5 Dec 2014 16:34:21 +0000 (11:34 -0500)]
LP#1154656 MARC Expert Search "Add Rows" adds duplicate row

This patch changes the behavior of the "Add Search Row" link
(JavaScript function from simple.js "addExpertRow()") so that
we are always cloning the initial "empty" row instead of
potentially cloning a row -- by way of cloneNode() -- with user
input in place, and causing duplicate search rows.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>
10 years agoscripting post-upgrade tasks
Chris Sharp [Mon, 5 Jan 2015 20:23:55 +0000 (15:23 -0500)]
scripting post-upgrade tasks

10 years agoMerge remote-tracking branch 'origin/rel_2_7_1_opac' into rel_2_7_2
Chris Sharp [Mon, 5 Jan 2015 18:59:18 +0000 (13:59 -0500)]
Merge remote-tracking branch 'origin/rel_2_7_1_opac' into rel_2_7_2

Conflicts:
Open-ILS/src/templates/opac/browse.tt2
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/record/summary.tt2

10 years agoMerge remote-tracking branch 'origin/rel_2_7_1_kpac' into rel_2_7_2
Chris Sharp [Mon, 5 Jan 2015 18:56:23 +0000 (13:56 -0500)]
Merge remote-tracking branch 'origin/rel_2_7_1_kpac' into rel_2_7_2

Conflicts:
ChangeLog
Open-ILS/examples/kpac.xml
Open-ILS/src/perlmods/lib/OpenILS.pm
Open-ILS/src/perlmods/lib/OpenILS/Application.pm
Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/action.pm
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
Open-ILS/src/sql/Pg/002.schema.config.sql
Open-ILS/src/sql/Pg/version-upgrade/2.4.3-2.4.4-upgrade-db.sql
Open-ILS/src/sql/Pg/version-upgrade/2.4.3-2.5.0-upgrade-db.sql
Open-ILS/src/templates/kpac/getit.tt2
Open-ILS/src/templates/kpac/homedewey.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/src/templates/opac/css/style.css.tt2
Open-ILS/src/templates/opac/parts/config.tt2
Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/header.tt2
Open-ILS/src/templates/opac/parts/record/authors.tt2
Open-ILS/src/templates/opac/parts/record/awards.tt2
Open-ILS/src/templates/opac/parts/record/copy_table.tt2
Open-ILS/src/templates/opac/parts/record/series.tt2
Open-ILS/src/templates/opac/parts/record/subjects.tt2
Open-ILS/src/templates/opac/parts/result/table.tt2
Open-ILS/src/templates/opac/parts/searchbar.tt2
Open-ILS/src/templates/opac/parts/topnav_links.tt2
Open-ILS/src/templates/opac/results.tt2
Open-ILS/web/css/skin/default/kpac/style.css
Open-ILS/web/js/ui/default/opac/staff.js
Open-ILS/xul/staff_client/chrome/content/main/about.html
Open-ILS/xul/staff_client/defaults/preferences/prefs.js
Open-ILS/xul/staff_client/server/cat/marcedit.js
Open-ILS/xul/staff_client/windowssetup.nsi
README
build/tools/make_release
configure.ac
docs/installation/server_installation.txt
docs/root.txt

10 years agoMerge branch 'tags/rel_2_7_2' of git://git.evergreen-ils.org/Evergreen into rel_2_7_2
Chris Sharp [Mon, 5 Jan 2015 18:21:12 +0000 (13:21 -0500)]
Merge branch 'tags/rel_2_7_2' of git://git.evergreen-ils.org/Evergreen into rel_2_7_2

Conflicts:
ChangeLog
Open-ILS/src/perlmods/lib/OpenILS/Application.pm
Open-ILS/src/sql/Pg/002.schema.config.sql
Open-ILS/src/sql/Pg/version-upgrade/2.7.0-2.7.1-upgrade-db.sql
Open-ILS/xul/staff_client/chrome/content/main/about.html
Open-ILS/xul/staff_client/defaults/preferences/prefs.js
README
configure.ac

10 years agoAdd comment to run 2.6.2-2.6.3 upgrade script if missed during 2.6-2.7 major upgrade
Ben Shum [Wed, 17 Dec 2014 20:38:27 +0000 (15:38 -0500)]
Add comment to run 2.6.2-2.6.3 upgrade script if missed during 2.6-2.7 major upgrade

As discovered by Dan Scott, the 2.7.0 and 2.7.1 shipped with a missing upgrade
script for 2.6.2-2.6.3 and if one upgraded directly from 2.6.2 to 2.7.0, you
would miss out on the fixes contained within.

Add a comment to the end of the 2.7.2 upgrade script to tell folks to go back
and run the 2.6.2-2.6.3 upgrade (which is now included in the tarball and
branches for 2.7 series).

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoBump OpenILS.pm version to 2.7.2
Ben Shum [Wed, 17 Dec 2014 17:00:29 +0000 (12:00 -0500)]
Bump OpenILS.pm version to 2.7.2

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1402905 Use stricter matching for UPC values
Dan Scott [Tue, 16 Dec 2014 04:23:49 +0000 (23:23 -0500)]
LP#1402905 Use stricter matching for UPC values

Per http://www.loc.gov/marc/bibliographic/bd024.html we
should be checking to see if either the ind1 is "1" or
if there's a subfield 2 with a value of "upc" before
assuming that any "Other standard identifier" 024 field
is a UPC value.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor
Mike Rylander [Fri, 18 May 2012 12:30:08 +0000 (08:30 -0400)]
LP#921142: Bring back automatic padding of short fixed fields in the GUI MARC editor

Bring back automatic padding of short fixed fields in the GUI MARC
editor. Also, use onblur instead of oninput, so that we've already lost
focus and don't care if that happens again.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356: Stamping upgrade script for patron purge post code fix
Ben Shum [Tue, 16 Dec 2014 20:15:57 +0000 (15:15 -0500)]
LP#1394356: Stamping upgrade script for patron purge post code fix

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1394356 Patron purge circs retain post code
Bill Erickson [Fri, 28 Nov 2014 21:29:57 +0000 (16:29 -0500)]
LP#1394356 Patron purge circs retain post code

When purging a patron, clear the address data after circulation
anonymization to ensure the usr_post_code is retained.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Stamping upgrade script for fix to metabib.record_attr
Ben Shum [Tue, 16 Dec 2014 20:01:53 +0000 (15:01 -0500)]
LP#1400376: Stamping upgrade script for fix to metabib.record_attr

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400376: Don't allow NULL attrs to polute an HSTORE as a key
Mike Rylander [Tue, 16 Dec 2014 01:32:51 +0000 (20:32 -0500)]
LP#1400376: Don't allow NULL attrs to polute an HSTORE as a key

That causes the HSTORE to blow up, which is bad for circs that
want to succeed.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403: Stamping upgrade script for normalizer detection to call number browse
Ben Shum [Tue, 16 Dec 2014 19:54:28 +0000 (14:54 -0500)]
LP#1389403: Stamping upgrade script for normalizer detection to call number browse

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1389403 Add normalizer detection to call number browse
Dan Wells [Fri, 4 Oct 2013 14:02:39 +0000 (10:02 -0400)]
LP#1389403 Add normalizer detection to call number browse

When finding the pivot for call number browse, we currently rely on
simple label matching (rather than normalized label matching), since
we do not know at the time of the search which normalizer we should
use.

Rather than blindly using the label, let's select the pivot in two
phases.  First, we will do what we do know, getting as close as
possible by label alone.  If we find an exact match, we are done (same
as the current code).  If we don't find an exact match, we take the
normalizer setting from the closest label match, normalize our input,
then search again.

This method *greatly* improves the overall accuracy of call number
searching whenever the call number being browsed for does not exist,
while causing no harm to accuracy when it does exist (since it will
either match the label or normalize to the same call number anyway).

Eventually, we may want to add interface elements for selecting the
call number type, probably defaulting to the default call number type
for the org unit being searched, but even with that in place, this
"auto-detection" logic should still be valuable.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401286: Cleaner display of URIs in search results
Dan Scott [Wed, 10 Dec 2014 22:05:38 +0000 (17:05 -0500)]
LP#1401286: Cleaner display of URIs in search results

Right now a record with an 856 like:

856 40 $zAvailable online $uhttp://publications.gc.ca $9LUSYS

shows up in search results with an HTML display like:

<a href="http://publications.gc.ca">http://publications.gc.ca</a> - Available online

rather than the much cleaner:

<a href="http://publications.gc.ca">Available online</a>

My simplistic approach is to check to see if the link text == the href,
and if so, and we have a note to display, to use the note as the text of
the link instead.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400082 - avoid uninitialized var warning at TPAC login
Dan Scott [Sun, 7 Dec 2014 13:51:33 +0000 (08:51 -0500)]
LP#1400082 - avoid uninitialized var warning at TPAC login

Give username a default value of '', which makes the regex happy (avoiding an
uninit warning in Apache logs if no value was entered) and still counts as de
nada for the purposes of the actual login dance.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401271: Add missing dependency for Date::Manip perl module
Jason Stephenson [Sat, 29 Nov 2014 15:34:53 +0000 (10:34 -0500)]
LP#1401271: Add missing dependency for Date::Manip perl module

This commit adds lines to distro-specific Makefiles to install
Perl Date::Manip packages so that Date::Manip::Date is
avaliable for marc_export. Somehow, this got missed or removed.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1400100 - Avoid extra </div> when OpenURL is enabled
Dan Scott [Sun, 7 Dec 2014 15:17:42 +0000 (10:17 -0500)]
LP#1400100 - Avoid extra </div> when OpenURL is enabled

When the OpenURL resolver is enabled, the record summary.tt2 page always
inserts a </div>, whether or not there actually are any OpenURL results to
point at (which is the condition that triggers the opening <div>).

This has the effect of resulting in the generated RDFa not including anything
below the OpenURL section, effectvely preventing the schema.org/Offer types
from being associated with the record. Which is not good for the semantic web
of library data.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoUpdate 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.
Ben Shum [Fri, 5 Dec 2014 21:02:04 +0000 (16:02 -0500)]
Update 2.6-2.7.0-upgrade-db.sql to reflect that it actually starts from 2.6.3 and up.

So, actually, the 2.7 upgrade path needs to include everything up to 2.6.3 to get all
the fixes.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoRe-order parts of 0887 upgrade script
Ben Shum [Fri, 5 Dec 2014 20:59:40 +0000 (15:59 -0500)]
Re-order parts of 0887 upgrade script

Based on feedback from dbs, in PostgreSQL 9.1, the order to which we
fix up these functions matters.  So drop if exists first, then create
new.

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1401177: Stamping upgrade script of unique_mr_attrs.sql.
Jason Stephenson [Wed, 10 Dec 2014 21:03:11 +0000 (16:03 -0500)]
LP#1401177: Stamping upgrade script of unique_mr_attrs.sql.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoLP#1401177: uniquify attrs across a metarecord
Mike Rylander [Wed, 10 Dec 2014 18:51:51 +0000 (13:51 -0500)]
LP#1401177: uniquify attrs across a metarecord

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
10 years agoMinor fix to web client section headers in root.txt
Kathy Lussier [Fri, 5 Dec 2014 14:03:20 +0000 (09:03 -0500)]
Minor fix to web client section headers in root.txt

I accidentally added the circulation header twice when adding the new
sections for web client docs. This commit removes one of the headers.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoWeb client section headings
Kathy Lussier [Thu, 4 Dec 2014 21:36:08 +0000 (16:36 -0500)]
Web client section headings

Adding section headings for web client documentation, which will be coming
shortly.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
10 years agoDocs: Update to template receipt docs
Lynn Floyd [Wed, 26 Nov 2014 21:37:29 +0000 (16:37 -0500)]
Docs: Update to template receipt docs

Thanks to Lynn Floyd. When adding the new content I ended up splitting new and old content into three files.

Signed-off-by: Yamil Suarez <yamil@yamil.com>
10 years agoLP#1207529: Add /openils assumption note
alzr [Mon, 5 Aug 2013 21:50:09 +0000 (16:50 -0500)]
LP#1207529: Add /openils assumption note

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1207529: Make sure $PATH includes /openils/bin when configuring
alzr [Mon, 5 Aug 2013 19:33:07 +0000 (14:33 -0500)]
LP#1207529: Make sure $PATH includes /openils/bin when configuring

https://bugs.launchpad.net/evergreen/+bug/1207529

Signed-off-by: alzr <aleksey.lazar@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Conflicts:
docs/installation/server_upgrade.txt

10 years agoLP#1384932: document the zips.txt ZIP code database feature
Josh Stompro [Wed, 29 Oct 2014 21:12:08 +0000 (16:12 -0500)]
LP#1384932: document the zips.txt ZIP code database feature

Patron Address City/State/County Pre-Populate by ZIP Code.

Documented the zips.txt feature that auto fills patron address
(City, State, County) information.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
Jason Stephenson [Wed, 30 Oct 2013 15:05:45 +0000 (11:05 -0400)]
LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.

I was trying to delete copies with the record fleshed in the call number
object and got the following error:

Can't use an undefined value as an ARRAY reference at
/usr/local/share/perl/5.14.2/OpenILS/Application/Cat/BibCommon.pm line 399

Having title_is_empty check for a bre object and use its id solved this
problem for me.

Signed-off-by: Jason Stephenson <jstephenson@mvlc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1083639: use "cp -r" instead of "cp -R"
Galen Charlton [Thu, 13 Nov 2014 18:45:14 +0000 (10:45 -0800)]
LP#1083639: use "cp -r" instead of "cp -R"

This change is purely for the sake of consistency; there's
no functional difference.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir
Josh Stompro [Thu, 23 Oct 2014 19:30:05 +0000 (14:30 -0500)]
LP#1083639 - Added command to copy fonts into the KPAC2 / Alternate monster skin dir

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1116387 - adding kpac setup notes.
Josh Stompro [Thu, 23 Oct 2014 18:21:16 +0000 (13:21 -0500)]
LP#1116387 - adding kpac setup notes.

Revised instructions based on my testing.  Swapped around the Monster
and Default skin discriptions since the listed Alternate Skin is the default skin.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoAdd KPAC configuration info to the community docs
Kathy Lussier [Tue, 5 Feb 2013 15:24:17 +0000 (10:24 -0500)]
Add KPAC configuration info to the community docs

Adds the KPAC TechRef docs to root.txt so that this information can be
available via the community docs. Also adds a section to the docs on
configuring the alternate skin and removes a reference to configuration
from the end-user KPAC docs.

Signed-off-by: Kathy Lussier <klussier@masslnc.org>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp
Fredric T Parks [Wed, 6 Nov 2013 23:36:32 +0000 (15:36 -0800)]
LP#1246839: marc_stream_importer.pl no longer crashes with vs 0.23 of File::Temp

updated marc_stream_importer.pl to use the 0.23 API

Signed-off-by: Fredric T Parks <fparks@catalystitservices.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
10 years agoLP#1133158 - Fix typos in action_trigger_runner.pl
Josh Stompro [Mon, 10 Nov 2014 15:29:38 +0000 (09:29 -0600)]
LP#1133158 - Fix typos in action_trigger_runner.pl

Added equals sign to --hooks and added --process-hooks to command so
--hooks=x is actually used.

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1391290: Stamping upgrade script for authority reingest setting
Ben Shum [Tue, 11 Nov 2014 02:00:42 +0000 (21:00 -0500)]
LP#1391290: Stamping upgrade script for authority reingest setting

Signed-off-by: Ben Shum <bshum@biblio.org>
10 years agoLP#1391290: Respect setting to disable authority propagation on reingest
Chris Sharp [Mon, 10 Nov 2014 19:43:22 +0000 (14:43 -0500)]
LP#1391290: Respect setting to disable authority propagation on reingest

In commit a1612cfd6 we lost the ability to disable authority propagation on
record update.  Here, we put it back.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Ben Shum <bshum@biblio.org>