working/Evergreen.git
6 years agoremove deprecated code
Bill Erickson [Wed, 11 Sep 2019 17:02:13 +0000 (13:02 -0400)]
remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoeager global ordinals on facet fields
Bill Erickson [Wed, 11 Sep 2019 16:46:00 +0000 (12:46 -0400)]
eager global ordinals on facet fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoboost and score sorting repairs
Bill Erickson [Wed, 11 Sep 2019 15:58:10 +0000 (11:58 -0400)]
boost and score sorting repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoBetter defined node unique constraint
Bill Erickson [Wed, 11 Sep 2019 15:01:53 +0000 (11:01 -0400)]
Better defined node unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoIdentifier searches / isbn issn normalizers
Bill Erickson [Tue, 10 Sep 2019 20:03:31 +0000 (16:03 -0400)]
Identifier searches / isbn issn normalizers

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agomisc tidying and docs
Bill Erickson [Mon, 9 Sep 2019 21:15:49 +0000 (17:15 -0400)]
misc tidying and docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agomore docs
Bill Erickson [Mon, 9 Sep 2019 20:39:48 +0000 (16:39 -0400)]
more docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agomore docs, query clensing
Bill Erickson [Mon, 9 Sep 2019 20:06:18 +0000 (16:06 -0400)]
more docs, query clensing

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agomove away from mapper to pure client
Bill Erickson [Mon, 9 Sep 2019 19:24:26 +0000 (15:24 -0400)]
move away from mapper to pure client

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoexact/prefix searches continued
Bill Erickson [Mon, 9 Sep 2019 19:01:43 +0000 (15:01 -0400)]
exact/prefix searches continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoelastic service continued
Bill Erickson [Mon, 9 Sep 2019 16:26:27 +0000 (12:26 -0400)]
elastic service continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoelastic-builder / marc search
Bill Erickson [Fri, 6 Sep 2019 22:10:45 +0000 (18:10 -0400)]
elastic-builder / marc search

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoelastic-builder in action
Bill Erickson [Fri, 6 Sep 2019 20:36:38 +0000 (16:36 -0400)]
elastic-builder in action

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoelastic bib field IDL class mod
Bill Erickson [Fri, 6 Sep 2019 18:43:49 +0000 (14:43 -0400)]
elastic bib field IDL class mod

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agomore catalog integration experiements / elastic-builder
Bill Erickson [Fri, 6 Sep 2019 14:37:38 +0000 (10:37 -0400)]
more catalog integration experiements / elastic-builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agotighter catalog integration WIP
Bill Erickson [Tue, 3 Sep 2019 21:29:42 +0000 (17:29 -0400)]
tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agotighter catalog integration WIP
Bill Erickson [Tue, 3 Sep 2019 19:24:05 +0000 (15:24 -0400)]
tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoinitial tighter catalog integration / cat side needs more data
Bill Erickson [Fri, 30 Aug 2019 16:26:04 +0000 (12:26 -0400)]
initial tighter catalog integration / cat side needs more data

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoadd label to bib_fields list
Bill Erickson [Fri, 6 Sep 2019 14:41:29 +0000 (10:41 -0400)]
add label to bib_fields list

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoadditional index tidying
Bill Erickson [Fri, 6 Sep 2019 14:35:40 +0000 (10:35 -0400)]
additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoadditional index tidying
Bill Erickson [Thu, 5 Sep 2019 19:59:18 +0000 (15:59 -0400)]
additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoinitial support multiple lang analyzers; multi_match queries
Bill Erickson [Thu, 5 Sep 2019 16:42:18 +0000 (12:42 -0400)]
initial support multiple lang analyzers; multi_match queries

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoUpdated example search in test script
Bill Erickson [Thu, 5 Sep 2019 15:52:47 +0000 (11:52 -0400)]
Updated example search in test script

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoadd marc data to bib search index
Bill Erickson [Tue, 3 Sep 2019 21:33:19 +0000 (17:33 -0400)]
add marc data to bib search index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoConsolidate some indexing code
Bill Erickson [Fri, 30 Aug 2019 21:08:31 +0000 (17:08 -0400)]
Consolidate some indexing code

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib marc record index / searching
Bill Erickson [Wed, 28 Aug 2019 21:41:39 +0000 (17:41 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib marc record index / searching
Bill Erickson [Wed, 28 Aug 2019 16:16:17 +0000 (12:16 -0400)]
bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib marc record index
Bill Erickson [Tue, 27 Aug 2019 21:50:47 +0000 (17:50 -0400)]
bib marc record index

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agosupport es proxied path; indexes one at a time
Bill Erickson [Thu, 18 Jul 2019 19:20:13 +0000 (15:20 -0400)]
support es proxied path; indexes one at a time

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agodata sync continued / _id fix
Bill Erickson [Tue, 9 Jul 2019 14:31:04 +0000 (10:31 -0400)]
data sync continued / _id fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoworking on data sync
Bill Erickson [Mon, 8 Jul 2019 22:12:16 +0000 (18:12 -0400)]
working on data sync

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agodisabled marc indexer experiment
Bill Erickson [Mon, 8 Jul 2019 14:46:20 +0000 (10:46 -0400)]
disabled marc indexer experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoRemove some TODO comments: done
Bill Erickson [Tue, 2 Jul 2019 20:51:13 +0000 (16:51 -0400)]
Remove some TODO comments: done

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoEL sample config superseded by per-index definitions
Bill Erickson [Fri, 31 May 2019 18:51:50 +0000 (14:51 -0400)]
EL sample config superseded by per-index definitions

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoforce-on ang7 cat for now
Bill Erickson [Tue, 12 Feb 2019 17:40:30 +0000 (17:40 +0000)]
force-on ang7 cat for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoAvoid huge index values
Bill Erickson [Tue, 12 Feb 2019 17:02:36 +0000 (17:02 +0000)]
Avoid huge index values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLog first/last bib ID of each indexed batch
Bill Erickson [Mon, 11 Feb 2019 19:05:01 +0000 (14:05 -0500)]
Log first/last bib ID of each indexed batch

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoIndexer orders by ID for batch consistency
Bill Erickson [Mon, 11 Feb 2019 17:11:10 +0000 (12:11 -0500)]
Indexer orders by ID for batch consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoindexer start-date support
Bill Erickson [Tue, 6 Nov 2018 15:52:59 +0000 (10:52 -0500)]
indexer start-date support

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoES gets child init
Bill Erickson [Tue, 6 Nov 2018 15:20:02 +0000 (10:20 -0500)]
ES gets child init

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agocopy loc/stat filters
Bill Erickson [Tue, 6 Nov 2018 02:21:50 +0000 (21:21 -0500)]
copy loc/stat filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agocopy loc/stat filters wip
Bill Erickson [Mon, 5 Nov 2018 22:21:09 +0000 (17:21 -0500)]
copy loc/stat filters wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoGroup searches OR-based; lower kw normalizer
Bill Erickson [Fri, 2 Nov 2018 20:56:37 +0000 (16:56 -0400)]
Group searches OR-based; lower kw normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoQP comp continued
Bill Erickson [Fri, 2 Nov 2018 18:48:55 +0000 (14:48 -0400)]
QP comp continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoang6 catalog use correct search_format filter
Bill Erickson [Wed, 31 Oct 2018 21:34:07 +0000 (17:34 -0400)]
ang6 catalog use correct search_format filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoQP based query compilation
Bill Erickson [Wed, 31 Oct 2018 21:30:43 +0000 (17:30 -0400)]
QP based query compilation

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agosearch_format filter; logging
Bill Erickson [Tue, 30 Oct 2018 15:07:04 +0000 (11:07 -0400)]
search_format filter; logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agofacets continued
Bill Erickson [Tue, 30 Oct 2018 14:51:46 +0000 (10:51 -0400)]
facets continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:17:01 +0000 (18:17 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:02:32 +0000 (18:02 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib search api wip
Bill Erickson [Mon, 29 Oct 2018 22:01:38 +0000 (18:01 -0400)]
bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoIndexer improvements, docs, and options
Bill Erickson [Mon, 29 Oct 2018 17:58:27 +0000 (13:58 -0400)]
Indexer improvements, docs, and options

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agofacets, etc.
Bill Erickson [Sat, 27 Oct 2018 14:31:46 +0000 (10:31 -0400)]
facets, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoel conf idl fields, etc.
Bill Erickson [Fri, 26 Oct 2018 18:00:25 +0000 (14:00 -0400)]
el conf idl fields, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agouse existing indexed values; refactoring
Bill Erickson [Fri, 26 Oct 2018 15:43:38 +0000 (11:43 -0400)]
use existing indexed values; refactoring

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agouse existing indexed values
Bill Erickson [Fri, 26 Oct 2018 01:17:43 +0000 (21:17 -0400)]
use existing indexed values

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 21:42:28 +0000 (17:42 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 19:20:53 +0000 (15:20 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing; search api wip
Bill Erickson [Wed, 24 Oct 2018 15:37:37 +0000 (11:37 -0400)]
bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Wed, 24 Oct 2018 14:36:56 +0000 (10:36 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 22:18:24 +0000 (18:18 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Tue, 23 Oct 2018 14:57:11 +0000 (10:57 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 23:31:28 +0000 (19:31 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agobib-search indexing wip
Bill Erickson [Mon, 22 Oct 2018 21:09:56 +0000 (17:09 -0400)]
bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agojson config for now; index create/delete
Bill Erickson [Mon, 22 Oct 2018 20:46:04 +0000 (16:46 -0400)]
json config for now; index create/delete

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoES/EG SQL
Bill Erickson [Mon, 22 Oct 2018 16:43:55 +0000 (12:43 -0400)]
ES/EG SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1842763: Vandelay: disable grid row select on queued record matches
Jeff Davis [Thu, 10 Oct 2019 18:04:48 +0000 (11:04 -0700)]
LP#1842763: Vandelay: disable grid row select on queued record matches

Users are on this screen to select a merge target, which they do by
selecting a cell in the Merge Target column.  The grid selector
checkboxes are confusing and useless (they don't support the purpose of
this screen and there are no supported actions for selected rows).

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
6 years agoLP#1841089 Apply button in Patron Bill History screen is in confusing location
Dan Briem [Sat, 24 Aug 2019 18:44:01 +0000 (14:44 -0400)]
LP#1841089 Apply button in Patron Bill History screen is in confusing location

It's possible to miss the apply button for the date range in bill history
because it's located before the datepickers. The interface also allows
invalid date ranges.

This removes the apply button and watches the start and finish dates in the
bill history and payment history controllers. If it's not first init and they
are valid date objects in a valid date range, the grid refreshes with the new
date range query. If start > finish they are set equal to each other to force
a valid range.

To test:

1. Apply patch
2. Bring up a patron with bills and payments (or add bills and payments)
3. Under the Bills tab click History
4. Change the date range and observe that the grid refreshes
5. Try to set the start date past the finish date and vice versa

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1729435: stamp DB update
Galen Charlton [Fri, 4 Oct 2019 14:33:45 +0000 (10:33 -0400)]
LP#1729435: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1729435: Add Seed Data for WS type for Bill Full Details grids
Michele Morgan [Fri, 5 Apr 2019 20:55:19 +0000 (16:55 -0400)]
LP#1729435: Add Seed Data for WS type for Bill Full Details grids

Adds the config.workstation_setting_type values to the seed data and
an upgrade script to allow storing in the database.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1729435: Allow saving Bill Full Details grids
Remington Steed [Mon, 5 Nov 2018 21:11:35 +0000 (16:11 -0500)]
LP#1729435: Allow saving Bill Full Details grids

For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Bills grid and Payments grid on the
patron bills Full Details view (right-click a bill, choose Full Details, then
click the Details tab).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1803790: apply alphabetization fix to Angular admin splash pages
Galen Charlton [Fri, 4 Oct 2019 14:12:49 +0000 (10:12 -0400)]
LP#1803790: apply alphabetization fix to Angular admin splash pages

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1803790 Re-alphabetize Local & Server Administration Links
Terran McCanna [Wed, 6 Mar 2019 21:40:53 +0000 (16:40 -0500)]
LP#1803790 Re-alphabetize Local & Server Administration Links

Small fix that re-orders the links that were out of order due
to link name changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings
Jeff Davis [Tue, 2 Oct 2018 21:28:31 +0000 (14:28 -0700)]
LP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings

To test:

1. Create a bib record.
2. Add an item to the record at BR1. Mark it as not OPAC-visible.
3. Do a CONS-level SRU search for the record, including holdings. The
   record is not included in results because there are no OPAC-visible
   holdings.
4. Add a second item to the same record, this time at BR3. Mark this
   one as OPAC-visible.
5. Repeat the CONS-level SRU search, including holdings. The record
   appears in search results, but holdings information in 852 includes
   *all* copies, including non-OPAC-visible copies.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP 1827250: Fix Last Captured Hold Check for Holds Shelf
Jason Stephenson [Thu, 2 May 2019 12:36:15 +0000 (08:36 -0400)]
LP 1827250: Fix Last Captured Hold Check for Holds Shelf

When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should.  This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.

The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy.  However, the order by
in the query fails to take into account holds with a NULL capture time
on the same copy will sort before the captured holds.  This patch
rectifies this situation by adding "NULLS LAST" to the order by.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agolp1813056 Fixes Current Date in Date Returned in Circ History CSV
Garry Collum [Mon, 20 May 2019 16:48:10 +0000 (12:48 -0400)]
lp1813056 Fixes Current Date in Date Returned in Circ History CSV

The date returned column in the csv file created in the opac for the patron's
Check Out History contains the current date instead of the check-in date. This
patch fixes that issue.

To test:
1. Turn on "Keep history of checked out items" in the patron Search and
History Preferences in the opac, or find a patron that already has this
option turned on.
2. Check-in some items that the patron has checked-out.
3. Wait a day, or if it was an existing history list immediately, go to the patron's Items Checked Out in the opac and look at the Date Returned
column in the Check Out History list.
4. Download the CSV file and note that the date is the current date.
5. Apply the patch.
6. Refresh and download the CSV file again and note that the Date Returned
is now the checkin date.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
6 years agoLP#1836963: reduce the cost of utility functions, speeding up search
Mike Rylander [Wed, 17 Jul 2019 21:14:01 +0000 (17:14 -0400)]
LP#1836963: reduce the cost of utility functions, speeding up search

For large org trees, some several seconds are spent testing org visibility.
The immediate cause is that AppUtils::get_org_tree() does not populate the
process-local cache with a memcache-cached org tree. That only happens when
memcache does not have a copy of the org tree. This is obviously a simple
oversight, which is addressed by making sure any memcache return value
is pushed into the the process local cache.

Additionally, the visibility check is making heavy use of lots of
indirection and delegation to utility code, when some slightly smarter code
could avoid many repeated function calls.  We now supply some local
utility code to flesh and unflesh the parent_ou field of objects in the
org tree, allowing us to avoid using find_org() and instead just calling
parent_ou() when walking "up" the tree.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoDocs: adding basic documentation for new 3.4 features
Jane Sandberg [Thu, 3 Oct 2019 16:41:09 +0000 (09:41 -0700)]
Docs: adding basic documentation for new 3.4 features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoforward-port 3.3.3-3.4.0 schema update
Galen Charlton [Wed, 2 Oct 2019 21:28:11 +0000 (17:28 -0400)]
forward-port 3.3.3-3.4.0 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoforward-port 3.4 release notes
Galen Charlton [Wed, 2 Oct 2019 21:27:16 +0000 (17:27 -0400)]
forward-port 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agonote minimum OpenSRF version in upgrade instructions
Galen Charlton [Wed, 2 Oct 2019 20:08:59 +0000 (16:08 -0400)]
note minimum OpenSRF version in upgrade instructions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1846369: add libhtml-defang-perl to Debian Buster installation
Galen Charlton [Wed, 2 Oct 2019 16:55:28 +0000 (12:55 -0400)]
LP#1846369: add libhtml-defang-perl to Debian Buster installation

This patch fixes an oversight where the HTML::Defang dependency
added in LP#1825851 wasn't installed on Debian Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>
6 years agoLP#1846357: fix circulation and billing aging
Galen Charlton [Wed, 2 Oct 2019 15:31:06 +0000 (11:31 -0400)]
LP#1846357: fix circulation and billing aging

An error merging an update to action.age_circ_on_delete() resulted
in a regression to the aging of billings. This patch fixes it.

To test
-------
[1] Apply the patch, then age circulations. Verify that relevant
    billings are also aged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoTranslation updates - po files
Galen Charlton [Wed, 2 Oct 2019 00:02:33 +0000 (20:02 -0400)]
Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoTranslation updates - newpot
Galen Charlton [Tue, 1 Oct 2019 23:58:33 +0000 (19:58 -0400)]
Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP1842940: stamping and slight tweak to upgrade script
Jane Sandberg [Tue, 1 Oct 2019 21:47:07 +0000 (14:47 -0700)]
LP1842940: stamping and slight tweak to upgrade script

Mike Rylander suggested the INSERT ... SELECT ... WHERE NOT
EXISTS approach, since this fix is being backported to older
releases, and we don't want to cause duplicate entries or
upgrade failures if the perm already exists

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1842940: Improve Alert
Mike Rylander [Tue, 17 Sep 2019 15:07:04 +0000 (11:07 -0400)]
LP#1842940: Improve Alert

Attempt to float the alerts below the sticky bar and above the main
content of the user editor.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1842940: Alert when editing is disallowed
Mike Rylander [Wed, 11 Sep 2019 18:46:44 +0000 (14:46 -0400)]
LP#1842940: Alert when editing is disallowed

Provide functions that checks the permissions required to edit ones
own account, or accounts in groups based on group application
permissions, and alert the user if and why they can't edit an account.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1842940: add perm to permit staff to edit their own accounts in the client
Jeff Davis [Thu, 5 Sep 2019 17:23:55 +0000 (10:23 -0700)]
LP#1842940: add perm to permit staff to edit their own accounts in the client

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1842940: Don't allow self-edit or perm-restricted edit
Mike Rylander [Thu, 5 Sep 2019 15:34:51 +0000 (11:34 -0400)]
LP#1842940: Don't allow self-edit or perm-restricted edit

Pre-webstaff, we disallowed editing of ones own record, an of records
that have a group application permission that the staff do not possess.

This commit brings back those restrictions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
6 years agoLP#1835458: bump up OpenSRF requirement
Galen Charlton [Tue, 1 Oct 2019 21:56:47 +0000 (17:56 -0400)]
LP#1835458: bump up OpenSRF requirement

OpenSRF 3.2.0 or later is now required for Evergreen 3.4+ as
a consequence of the new support for Debian 10 Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoupdates to 3.4 release notes
Galen Charlton [Tue, 1 Oct 2019 21:55:58 +0000 (17:55 -0400)]
updates to 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1835085: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:24:16 +0000 (17:24 -0400)]
LP#1835085: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLp 1835085: Update Item Status templates for auto-renewal
Jason Stephenson [Mon, 9 Sep 2019 12:47:09 +0000 (08:47 -0400)]
Lp 1835085: Update Item Status templates for auto-renewal

Add checks for circ.auto_renewal() == 't' in the circ list and summary
pane views of the web staff client Item Status interface.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLp 1835035: Refactor auto_renewal back end code
Jason Stephenson [Fri, 30 Aug 2019 15:37:24 +0000 (11:37 -0400)]
Lp 1835035: Refactor auto_renewal back end code

Refactor the auto_renewal feature so that it works like other renewal
types: opac_renewal, sip_renewal, etc.  This refactor prevents
desk_renewal from being set when auto_renewal is set.

Deprecate the newly added open-ils.circ.renew.auto API and ensure that
it still works as intended.  Add release note indicating the
deprecation of this API and intent to remove it in Evergreen 3.5.

Modify the AutoRenew action trigger reactor to use the plain
open-ils.circ.renew API with the auto_renewal option set to 1.

Add database update script to cleanup (i.e. set to FALSE) the
desk_renewal field on action.circulation and action.aged_circulation
tables where auto_renewal is TRUE.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1835577: stamp schema updates
Galen Charlton [Tue, 1 Oct 2019 21:19:51 +0000 (17:19 -0400)]
LP#1835577: stamp schema updates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLp 1835577: Add more missing auto_renewal fields
Jason Stephenson [Tue, 10 Sep 2019 15:27:07 +0000 (11:27 -0400)]
Lp 1835577: Add more missing auto_renewal fields

Add missing auto_renewal and auto_renewal_remaining fields to the
following additional IDL classes:

* aacs
* aoc
* circbyyr
* robcirc

Add database updates to add auto_renewal fields to the following
views:

* action.billable_circulations
* action.open_circulation
* reporter.circ_type
* reporter.overdue_circs

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLp 1835577: Add missing Auto Renewal fields to the IDL
Jason Stephenson [Thu, 29 Aug 2019 14:15:33 +0000 (10:15 -0400)]
Lp 1835577: Add missing Auto Renewal fields to the IDL

Add entries for auto_renewal and auto_renewal_remaining fields to the
acirc and combcirc classes in fm_IDL.xml.  They were missing after the
auto-renewal feature was added.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLP#1839002: stamp DB update
Galen Charlton [Tue, 1 Oct 2019 21:15:36 +0000 (17:15 -0400)]
LP#1839002: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
6 years agoLp 1839002: Default circulation auto_renewal field to FALSE
Jason Stephenson [Thu, 29 Aug 2019 15:06:56 +0000 (11:06 -0400)]
Lp 1839002: Default circulation auto_renewal field to FALSE

Change the definition of the action.circulation table so that the
auto_renewal field is not null, default false.

Add an upgrade script to update the field values and alter the field
definition in both the action.circulation and action.aged_circulation
tables.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>