LP#1802952 Check bib visibility for located URI auto suggest

Suggestions from records with only located URIs (no copies) do not
appear in the OPAC search suggestions. This appears to be a cousin of
bug #1773479, but in a neighboring function.

In the case of libraries with LURIs, we need to consider bib visibility
separate from copy visibility in order for both to show up.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1749970 Fix paging of pending patrons

Fix paging of pending patrons by passing a count and offset to the
backend API call.

Signed-off-by: Jeff Godin <jgodin@tadl.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1657171 - Adding upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1657171 - Normalize right and left single and double quotes

Changes search_normalize and naco_normalize to replace right and left
leaning single quotes with U+0027, double quotes with U=0022

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1777698 Duplicate barcode alert appearing on new barcodes

When scanning new copy barcodes, ng-change quickly fires multiple times
and sends promises to check for duplicates. If 1234 exists and you scan
12345, if the 1234 promise resolves after 12345, it will indicate it's a
duplicate. This patch keeps a count of the promises sent and only the
latest promise will set the boolean to indicate if it's a duplicate.

Hard to test because the promises usually resolve in order:
1. Add a new holding with the first few characters of an unused barcode
2. Scan the new barcode multiple times until you see the dup error
3. Apply patch and scan the new barcode multiple times (no error)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP 985957 Prevent hold activation date being in the past

Created a new JS function isValidDate. Checks that the date is in the future, is a valid date within the month/year given. Also makes sure the date is in the proper format D/m/Y.

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1778606 Web Client - Place Hold Requires Two Clicks on Submit

Issue: the barcode lookup runs on the input's onchange, onkeypress (Enter), &
disables the submit button until the patron loads. So, if you type a barcode,
click enter, click the submit button, mousedown fires, if focus was still the
barcode input, its onchange fires, the lookup runs again, the submit button
disables, prevents button mouseup from firing, the click event is disrupted, &
the form doesn't submit. Click again & it works.

Instead of onchange & onkeypress this branch runs the lookup when there's a
500ms pause between onkeydowns. onpaste and enter still run the lookup
immediately. The patron search triggers the input's keydown instead of change.

To test:
1. Search for any holdable item in the catalog and click Place Hold
2. Type in an existing patron barcode and click Enter
3. Before tabbing or clicking off the barcode input, click the Submit button
4. Note it doesn't submit - click again and it submits
5. Apply patch
6. Repeat steps 1-3
7. Note it submits

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1555791: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1555791 - Hide Print List from checkout screen

Hide the print list button from the checkout screen so customers
don't learn to use that instead of logout.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1842763: Vandelay: disable grid row select on queued record matches

Users are on this screen to select a merge target, which they do by
selecting a cell in the Merge Target column.  The grid selector
checkboxes are confusing and useless (they don't support the purpose of
this screen and there are no supported actions for selected rows).

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1841089 Apply button in Patron Bill History screen is in confusing location

It's possible to miss the apply button for the date range in bill history
because it's located before the datepickers. The interface also allows
invalid date ranges.

This removes the apply button and watches the start and finish dates in the
bill history and payment history controllers. If it's not first init and they
are valid date objects in a valid date range, the grid refreshes with the new
date range query. If start > finish they are set equal to each other to force
a valid range.

To test:

1. Apply patch
2. Bring up a patron with bills and payments (or add bills and payments)
3. Under the Bills tab click History
4. Change the date range and observe that the grid refreshes
5. Try to set the start date past the finish date and vice versa

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1729435: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1729435: Add Seed Data for WS type for Bill Full Details grids

Adds the config.workstation_setting_type values to the seed data and
an upgrade script to allow storing in the database.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1729435: Allow saving Bill Full Details grids

For a web staff eg-grid to save and retrieve its settings, it needs a unique
persist-key. This commit adds one for the Bills grid and Payments grid on the
patron bills Full Details view (right-click a bill, choose Full Details, then
click the Details tab).

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1803790: apply alphabetization fix to Angular admin splash pages

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1803790 Re-alphabetize Local & Server Administration Links

Small fix that re-orders the links that were out of order due
to link name changes.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1609556: only include OPAC-visible copies in SRU/Z39.50 holdings

To test:

1. Create a bib record.
2. Add an item to the record at BR1. Mark it as not OPAC-visible.
3. Do a CONS-level SRU search for the record, including holdings. The
   record is not included in results because there are no OPAC-visible
   holdings.
4. Add a second item to the same record, this time at BR3. Mark this
   one as OPAC-visible.
5. Repeat the CONS-level SRU search, including holdings. The record
   appears in search results, but holdings information in 852 includes
   *all* copies, including non-OPAC-visible copies.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP 1827250: Fix Last Captured Hold Check for Holds Shelf

When the current copy on an on shelf hold is the same as that on some
uncaptured holds, the hold fails to appear on the hold shelf when it
should.  This comes down to some SQL in the storage function to
retrieve wide holds: open-ils.storage.action.live_holds.wide_hash.

The intent of the new code is to check that the current hold matches
the most recently captured hold for the copy.  However, the order by
in the query fails to take into account holds with a NULL capture time
on the same copy will sort before the captured holds.  This patch
rectifies this situation by adding "NULLS LAST" to the order by.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1813056 Fixes Current Date in Date Returned in Circ History CSV

The date returned column in the csv file created in the opac for the patron's
Check Out History contains the current date instead of the check-in date. This
patch fixes that issue.

To test:
1. Turn on "Keep history of checked out items" in the patron Search and
History Preferences in the opac, or find a patron that already has this
option turned on.
2. Check-in some items that the patron has checked-out.
3. Wait a day, or if it was an existing history list immediately, go to the patron's Items Checked Out in the opac and look at the Date Returned
column in the Check Out History list.
4. Download the CSV file and note that the date is the current date.
5. Apply the patch.
6. Refresh and download the CSV file again and note that the Date Returned
is now the checkin date.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>

LP#1836963: reduce the cost of utility functions, speeding up search

For large org trees, some several seconds are spent testing org visibility.
The immediate cause is that AppUtils::get_org_tree() does not populate the
process-local cache with a memcache-cached org tree. That only happens when
memcache does not have a copy of the org tree. This is obviously a simple
oversight, which is addressed by making sure any memcache return value
is pushed into the the process local cache.

Additionally, the visibility check is making heavy use of lots of
indirection and delegation to utility code, when some slightly smarter code
could avoid many repeated function calls.  We now supply some local
utility code to flesh and unflesh the parent_ou field of objects in the
org tree, allowing us to avoid using find_org() and instead just calling
parent_ou() when walking "up" the tree.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding basic documentation for new 3.4 features

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

forward-port 3.3.3-3.4.0 schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

forward-port 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

note minimum OpenSRF version in upgrade instructions

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1846369: add libhtml-defang-perl to Debian Buster installation

This patch fixes an oversight where the HTML::Defang dependency
added in LP#1825851 wasn't installed on Debian Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1846357: fix circulation and billing aging

An error merging an update to action.age_circ_on_delete() resulted
in a regression to the aging of billings. This patch fixes it.

To test
-------
[1] Apply the patch, then age circulations. Verify that relevant
    billings are also aged.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1842940: stamping and slight tweak to upgrade script

Mike Rylander suggested the INSERT ... SELECT ... WHERE NOT
EXISTS approach, since this fix is being backported to older
releases, and we don't want to cause duplicate entries or
upgrade failures if the perm already exists

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1842940: Improve Alert

Attempt to float the alerts below the sticky bar and above the main
content of the user editor.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1842940: Alert when editing is disallowed

Provide functions that checks the permissions required to edit ones
own account, or accounts in groups based on group application
permissions, and alert the user if and why they can't edit an account.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1842940: add perm to permit staff to edit their own accounts in the client

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1842940: Don't allow self-edit or perm-restricted edit

Pre-webstaff, we disallowed editing of ones own record, an of records
that have a group application permission that the staff do not possess.

This commit brings back those restrictions.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1835458: bump up OpenSRF requirement

OpenSRF 3.2.0 or later is now required for Evergreen 3.4+ as
a consequence of the new support for Debian 10 Buster.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

updates to 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1835085: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1835085: Update Item Status templates for auto-renewal

Add checks for circ.auto_renewal() == 't' in the circ list and summary
pane views of the web staff client Item Status interface.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1835035: Refactor auto_renewal back end code

Refactor the auto_renewal feature so that it works like other renewal
types: opac_renewal, sip_renewal, etc.  This refactor prevents
desk_renewal from being set when auto_renewal is set.

Deprecate the newly added open-ils.circ.renew.auto API and ensure that
it still works as intended.  Add release note indicating the
deprecation of this API and intent to remove it in Evergreen 3.5.

Modify the AutoRenew action trigger reactor to use the plain
open-ils.circ.renew API with the auto_renewal option set to 1.

Add database update script to cleanup (i.e. set to FALSE) the
desk_renewal field on action.circulation and action.aged_circulation
tables where auto_renewal is TRUE.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1835577: stamp schema updates

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1835577: Add more missing auto_renewal fields

Add missing auto_renewal and auto_renewal_remaining fields to the
following additional IDL classes:

* aacs
* aoc
* circbyyr
* robcirc

Add database updates to add auto_renewal fields to the following
views:

* action.billable_circulations
* action.open_circulation
* reporter.circ_type
* reporter.overdue_circs

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1835577: Add missing Auto Renewal fields to the IDL

Add entries for auto_renewal and auto_renewal_remaining fields to the
acirc and combcirc classes in fm_IDL.xml.  They were missing after the
auto-renewal feature was added.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1839002: stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1839002: Default circulation auto_renewal field to FALSE

Change the definition of the action.circulation table so that the
auto_renewal field is not null, default false.

Add an upgrade script to update the field values and alter the field
definition in both the action.circulation and action.aged_circulation
tables.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1840669: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1840669: Handle autorenewals when aging circulations

Add auto_renewal and auto_renewal_remaining fields to the
action.age_circ_on_delete trigger function.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1845050: fix issue where reports interface was partially loaded

This patch adjusts mod_xmlent to not free its XML parser
prematurely in the face of an EOS bucket received while processing
a sub-request.

To test
-------
[1] Test on a platform that has Apache 2.4.25 or later, such as
    Debian Stretch.
[2] Note that when loading the reports interface that the source
    of the frame containing oils_rpt.xhtml is incomplete and that
    actions like creating a template or folder do not work in the
    interface.
[3] Apply the patch and repeat step 2. This time, oils_rpt.xhtml
    should be fully loaded and the interface fuctional.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1845260: add additional DB update to be sure

... that the function is correct if somebody is upgrading a
beta1 or beta2 database.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1845260: fix error in vandelay.auto_overlay_org_unit_copies db function

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1844812 Combobox avoids processing matching entry lists

Teach the combobox to only process newly provided entry lists if they
are different from the list already on record for the combobox.

The combobox entry list Input() is responsive to changes in data
throughout the life of the combobox.  As a new entry list is provided,
the component will perform various actions on the list.  However, in
many cases the list provided may be identical the list the component
already has, which can lead to a lot of unnecessary processing and in
some case an infinite loop of inputs and outputs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1811442 - Assign copy alert permissions.

VIEW_COPY_ALERTS and ADMIN_COPY_ALERT permissions were added
recently, but not assigned in the default seed data.  This branch
assigns VIEW_COPY_ALERTS to Staff profiles at the Consortium depth
and adds ADMIN_COPY_ALERT to the Cataloging Administrator profile.

Since permissions are set so specifically per-site, this branch does
not contain an upgrade script, but does provide an update to release
notes reminding site admins to manually add them to the appropriate
profiles.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1560805 Webstaff locale picker repair

Make the locale picker less finicky by replacing the search/replace
regex with a simple static URL for applying the locale.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1830642: add tests for authenticating users when password contains percent sign

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1768141: Stamping Upgrade Script

Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1768141: (follow-up) change schema update

Change the update to an "ALTER FUNCTION ... STABLE" both
to make the purpose of the update more clear and to remove
the need to check the rest of the function definition when
backporting.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP#1768141 - Mark permission.grp_descendants STABLE.

Quoting Galen Charlton's comments on the bug report:

The database function permission.grp_descendants should
be marked stable; it qualifies, and doing so should allow
PostgreSQL to improve query plans. One example of a query
that would benefit is searching by patron profile (a la
bug 1497322)

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

LP1739607: Add missing columns to patron record

To test:
1) Open up a patron record with some bills.
2) On the Items Out tab, notice that there is a column named Location
3) On the Bills tab, open up Bill history.
4) In the history transactions grid, note that the column picker is
missing the following columns:
  * Item owning library
  * Checkout/renewal library
  * Due date
  * Fines Stopped Reason
5) In the history payments grid, note that the column picker is missing
the same columns.
6) Apply this commit.
7) Note that the Items Out tab's column is renamed to "Shelving
Location".
8) Notice that both Bill history grids column pickers include the
requested columns.

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

Docs: minor formatting changes to Hide Fields doc

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: adding Hiding Fields in Holdings Editor docs and screenshots

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: added another contributor

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#1843637 MARC View Display Issues

This fixes vertical alignment issues in the MARC View table
by removing the deprecated valign tags and moving the inline
CSS to the cat.css file. The text within each table cell should
now align to the top for better readability.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Docs: Adding contributors and employers; fixing formatting

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: typo corrections and added dev funders

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: rearranging 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

added code formatting to text

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Forward-port 3.3.4 upgrade script

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

update 3.4 release notes for security bugfixes

NOTE: This section can be removed for 3.4-rc.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding release notes for 3.3.4

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding release notes for 3.2.9

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: adding release notes for 3.1.15

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1822630: fix sanitizing CGI params on place_hold_result

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1822630: further sanitizing of CGI params when embedded in HTML

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1822630: sanitize user input before display on browse results

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1559239: use rel="noopener" when opening external URLs in a new tab

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1735847: Remove patron info from default Hold Transit Slip

Removes most patron information from the Hold Transit Slip
in both the web and XUL client default definitions.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <jboyer@equinoxinitiative.org>

Docs: Group similar release notes together

This commit simply moves one release note to be near a group of similar
release notes.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Docs: Make "staff catalog" titles consistent in 3.4 Rel Notes

This commit tries to make the release note titles regarding the angular
staff client both consistent and more readable.

Signed-off-by: Remington Steed <rjs7@calvin.edu>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

prune RELEASE_NOTES_NEXT

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

first rough pass at 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Ensure "Reshelved" copies are still reshelving

Rather than "were reshelving when the query started"

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

LP#1817645: adjust live_t remoteauth checks

Version 6.07 or higher of LWP::Protocol::https is required to
avoid an issue where an SSL certificate check of localhost
cannot be bypassed. We could instead have chosen to install
that Perl module from CPAN rather than packages, but since there's
presently no non-test code that requires that bugfix, I've elected
not to bother installing that module from CPAN for now.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: fix live perl test for basic auth API

The live perl test is failing because we are not passing all
the right parameters for ignoring the SSL certificate verification
checks. Pass another variable to see if this helps.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: (follow-up) avoid hardcoding user ID in a live_t test

This patch is an alternative implementation of an idea from
Ben Shum to avoid assuming that a given username in Concerto
will always be associated with the same patron ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: cleaning up headings in 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1817645: Fix pgtap tests

There was a missing closing parenthesis on the pgtap tests from
this new feature.

Also, one of the comparisons had the wrong value matching and it
failed to pass. Inactive patrons return "not_found" rather than
"blocked" apparently.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1816475: Cleanup 950.data.seed-values.sql

When this branch was committed, some old seed data snuck back into
the file from LP#1759343 cleanup commit (eee5c5948ca).  Remove the
extra code to prevent duplicate INSERT errors.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1068287: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1068287 UI tweak and renewal behavior

Skips the CREATE_PRECAT permission check when renewing pre-cataloged items.

Also disables all the elements except the Cancel button in the Pre-Cat dialog
when the user lacks the CREATE_PRECAT permission, and repositions the explanatory
text.

Also includes release notes.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1068287 - Add CREATE_PRECAT permission

Add this permission to prevent untrained/un-authorized
circ staff from creating pre-cat items due to mis-scanned
barcodes. Added to all profiles by default, so that staff
admins can pinpoint users who may not have it, i.e Volunteers, etc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1823255: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1823255: optionally require ident_value

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mark Bucholtz <mbucholtz@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1811696: Add --rebuild-rmsr option to pingest.pl

Add the option to rebuild the reporter.materialized_simple_record
table to the pingest.pl support script.

Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: release notes

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: fix ITEM_NOT_HOLDABLE event description

The main functionality for this enhancment produces toast messages for success
and failure, and the description for this particular event when testing had me
double-taking :)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: add Title Hold option in various places in staff client

* Adds a Title Hold option to certain invocations of Request Items
(Item Status, Copy Buckets, but not Holdings View)

* Switches count of items to count of titles when Title hold option
is selected

* Adds a checkbox for honoring the preferred notification settings
and default pickup library of the selected patron

* Adds a success/failure toast for Request Items

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1799272: Option to Limit Hold Items in SIP2 msg 64 to Available

This commit adds an implementation option to the oils_sip.xml that,
when enabled, will limit the hold items list and hold items counts in
the patron information response (response 64) to only the holds
available for pickup by the patron.  When the setting is not enabled,
the full list of the patron's holds continues to be used.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1731021 SIP fine detail fee type additions

Adds support for specifying different fee types in the fine/fee response
based on the most recent billing type of each transaction.

Thanks to Jason Stephenson for the initial implementation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1731021 SIP Fine detail repairs / display fields

Resolve commit issues with the second commit from the source branch
working/user/dpearl/LP1731021_fine_item_detail

Migrating circ title/author lookup to use metabib display fields instead
of MVR's.

Minor code refactoring.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1731021: Support fine detail enhancement to SIP.

The particular flavor of fine detail output is manufacturer dependent,
although 3m is popular, and the default.  To configure the selection,
modify the /openils/conf/oils_sip.xml file.

Testing: See the /openils/conf/oils_sip.xml file and test all supported
values for the av_format option.  You should also test the case where
the option is omitted, or a non-supported value.  I am not sure what
happens if you supply more than one option with same or different
values, but this is a non-supported degenerate case.

For each test value, ensure tha the fine item detail is the expected
format.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>