Copy auditor purge runs 30 mins

Avoid triggering Zabbix alerts about backed replication (and, indeed,
limit clogged replication) by running the copy audit purge for 30 mins
total.  This results in ~3.5M rows deleted per night while still within
the cleanup phase.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1590 Northshore school cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1544 Payflow xact balance comparison repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1544 Paypal skip silent post URL option

Org unit setting to avoid sending the Paypal Silent Post URL during
secure token generation.  This is useful if you want to use a specific
server for handling silent posts that may not match the hostname of the
catalog paged accessed by the browser.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1588 CC payment balances match active data

Ensure that the total amount to be tracked as payments in EG after a
successfull PayPal payment match the PP payment amount.  Exit early and
return a non-success to PP when the totals don't match.

This imbalance can occur when a transaction is paid by some other client
(secondary PP instance, staff client) after the PP transaction has been
initiated with the original transaction balance owed amount.

IOW, don't accept payments for transactions that were paid off through
some other mechanism while the PP transaction was in process.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1587 CC always avoids negative transactions

At the middle layer, prevent the credit card transaction retrieval code
from ever accessing negative transactions.  This fixes a bug where
patrons could accidentally attempt to pay against negative transactions
by navigating directly to /eg/opac/biblio/main_payment_form with no
transactions provided in the URL, defaulting to all open (including
negative) transactions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

EDI retrieval sanity check in undef value

Avoid referencing potentially undef value as an array in the EDI
retrieva code.  Otherwise, all EDI retrieval stopped once the undef
value was encountered.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1593 "Book Club" copy location BC SQL mods

Please create a new shelving location named "Book Club" that will be
non-visible to patrons (as discussed at the ILS Team meeting on 9/15/16).

JBAS-1550 Tukwila school/classroom cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1501 Audit purge for CRONTAB; minor rearranging

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1501 Copy audit table maintenance scripts

New DB function for deleting rows from auditor.asset_copy_history plus a
script we can run from CRON for nightly batches.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1497 Remove CC number cleaner from CRONTAB

We no longer accept any credit card data from patrons, so there's no
data to regularly scrub.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Payflow org settings SQL insert-on-deploy wrapper

Avoid inserting payflow settings on new dev DB builds -- the data will
come later from an export.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1472 Vashon student / classroom cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1541 Freegalsip user activity type

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1543, add Lucky Day to list of item circ modifiers and shelving locations that should not show in BC

JBAS-1503 Avoid setting SILENTPOSTURL (TLS issues)

Force PP to use evgmobile via PP manager since it is not requiring
the use of TLS 1.2.  In other words, avoid setting the SILENTPOSTURL
from the apache host.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1503 PP fetch in-db user for last_xact_id

During Silent POST handling, fetch the user from the db to pick up the
most recent last_xact_id value for fines payment.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1503 PayPal Layout-A plus Silent POST

Avoid iframe by sending patrons to PP to pay.  PP posts results back to
EG via Silent POST.  Silent POSTs that fail result in a voided payment
on the PP side.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Revert "JBAS-1503 E-com alert message, stage 1"

This reverts commit 62a68bbfc73c6415f3a975b2bcaabd536754d582.

Revert "JBAS-1503 Hide pay button, update warning"

This reverts commit 6e5f4b39204024e4dc9b16519697254dd6f579a7.

JBAS-1503 Hide pay button, update warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1503 E-com alert message, stage 1

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1494 Updated E-com FAQs link

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1494 PayFlow hosted page comment1=barcode

Send the patron's barcode as the transaction comment1 so it will appear
within the PayPal Manager for the business office.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1494 PayFlow Hosted Pages for CC payments

https://developer.paypal.com/docs/classic/payflow/gs_ppa_hosted_pages/

* Library settings to configure and activate.
* New TPAC templates and WWW perl for processing payments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1413  marc-stream-importer learns authority queue/profile ID's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1390 Connexion authority SQL insert check

Avoid inserts on initial build of sample databases.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Remove browser warning from Ecom payment form

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-546 Patron summary shows 'Primary Phone'

... instead of 'Day Phone'

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-544 Prevent manually setting 'Lost & Paid' status

Disable manual access to the copy Lost & Paid status.  When used, it is
applied by the system, not the staff.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1438 Bib-to-auth linking ignores  (date of work)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1417 Vand. authority import set edit date SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1587639 Vandelay authority update editor/edit_date

Update the editor and edit_date of authority records when modified by
Vandelay merge/overlay.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1417 New authority linker --modified-since

--modified-since implicitly includes --new-since because
edit_date=create_date on new authority records.  However, if both are
specified, the script OR's the queries.

If --modified-since and --new-since are used to gether, it creates an OR
of the 2 clauses.

Added a help() function.  Added CRONTAB entry.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

os-update.sh gets a reboot option

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eg-updater.sh: Apache control repairs/additions

1. If apache is already running when start-apache is called, stop it
first.  This is useful when calling start-apache (or start-all) directly
after a reboot, where Apache may have started automatically at boot.

2. Force a call to 'detach' when stop-apache is called directly as a
safety measure.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Reporter statement timeout 6 hours

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1378 Purge user activity ; apply transience

Remove all but the most recent actor.usr_activity row per etype and per
user, except keep all of the lynda and hoopla SIP login events.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

90c2418 Nightly authority linking CRON entry repair

When running jobs past midnight, be sure to search for records modified
the previous day, not just today, for linking.

Signed-off-by: Your Name <you@example.com>

JBAS-1417 Nightly authority linking CRON entry

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1417 New authority record linking script

Runs auth-to-auth and bib-to-auth linking for authority records created
since a specified date.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1417 Bib linking supports --modified-since

Plus some minor cleanup.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1390 Connexion authority imports

Authority import merge profile and vandelay queue.

Updated marc_stream_importer script to handle authority imports.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-61 MARC Advanced Search Add Row fix

Initialize expert_row_template variable
Refactor code to take into account new variable

Signed-off-by: Billy Horn <bhorn@catalystdevworks.com>
  Changes to be committed:
modified:   Open-ILS/web/js/ui/default/opac/simple.js

CAT-62 Patron Reg. Dupes Sorting

Remove penalties from pre-sort filter

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>

JBAS-953 Add CC number clear to CRONTAB

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-953 Drop CC cols local SQL

Column mods and print/email template updates.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1474051 Stamping upgrade script for drop-cc-data

Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 Release/Upgrade Notes on dropped CC fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

LP#1474051 Drop unneeded CC payment fields

Avoid storing the following credit card fields:

expire month
expire year
first name
last name
credit card type

Print and email receipts for credit card data modified to avoid
referencing these fields.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Kathy Lussier <klussier@masslnc.org>

KMAIN-1919 Copy Quality Labels

Set Possible Values for Copy Quality to
"Standard" and "No Supplemental."

Change dialogue on "Set Copy Quality" to reflect
change from "Good" to "Standard."

Signed-off-by: khuckins <khuckins@catalystdevworks.com>

CAT-58 Bill Interface Print Additions

Add locale settings for Printing selected item.
Add context menu to Bill/Payment History interface.
Add Print Selected Item to Bill/Payment History Context menu.
Change Payment History Interface Print button to print all
items in list.

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
modified:   Open-ILS/web/opac/locale/en-US/lang.dtd
modified:   Open-ILS/xul/staff_client/server/patron/bill2.xul
modified:   Open-ILS/xul/staff_client/server/patron/bill_history.js
modified:   Open-ILS/xul/staff_client/server/patron/bill_history.xul

JBAS-518 (KMAIN-1917) Repairs

1. Set bills printer context to current_bills instead of items_out.
2. Avoid rendering the payment details when clicking Print in the
   payment details UI
3. Style consistency repairs.
4. Remove pesky Windows newlines

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Conflicts:
Open-ILS/xul/staff_client/server/patron/bill2.js

KMAIN-1917 Patron payments print selected items

You can now print selected line items from the Payments window

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>

KMAIN 1917 Patron bills print selected items

Patron Bills Window Now Supports The Option To Print Selected Line Items

Signed-off-by: Nick Duncan <nDuncan@catalystitservices.com>
Conflicts:
Open-ILS/xul/staff_client/server/patron/bill2.js

CAT-51 Patron editor profile group sorting refactor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-51 Patron Reg. Perm Group Ordering

Reordered Permission Group choices in drop down
of Edit screen on Patron Registration page.

Signed-off-by: Victoria Lewis <vlewis@catalystdevworks.com>
 On branch dev/catalyst-vlewis/CAT-51-patron_reg_perm_group_ordering
modified:   Open-ILS/web/js/ui/default/actor/user/register.js

KMAIN 1939 Rename Daytime/Evening Phone

Change instances of "Daytime/Evening Phone" to
"Primary/Secondary Phone."

Signed-off-by: khuckins <khuckins@catalystdevworks.com>

KMAIN-1918 Emphasize PC Only Patrons

Goal: Give PC Only Patron name a yellow border

Solution:
Add new CSS class PATRON_PC_ONLY
Add handling for removing and adding PATRON_PC_ONLY

Signed-off-by: Kyle Huckins <khuckins@catalystdevworks.com>
modified:   Open-ILS/xul/staff_client/server/patron/display.js
modified:   Open-ILS/xul/staff_client/server/patron/util.js
modified:   Open-ILS/xul/staff_client/server/skin/patron_display.css

KMAIN-1830 Backspace clears on barcode only

Only apply backspace-clears-barcode handling to the barcode input.  As
it was, it was defaulting to all text inputs (e.g. stat cat values).

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-533 Org units get their own mailing addresses

Give each org unit currently using address ID 1 as its mailing address a
copy of address ID 1 so that it can be edited w/o modifying the
addresses of other org units.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

CAT-46 Bib Call Number Also Uses 99a; Avoid Undefined

Add option for Bib Call Numbers to be populated from the 099a
subfield, rather than just the 092a subfield.

Avoid returning an 'undef' value fro the bib call number, which results
in 'undefined' labels in Javascript.  Default to empty string.

Signed-off-by: khuckins <khuckins@catalystdevworks.com>

CAT-49  Copy View/Edit Links in Catalog

Add view and edit link next to each copy in the copy gird.
Cross-ported this feature.
https://bugs.launchpad.net/evergreen/+bug/1346421

Signed-off-by: Victoria Lewis <vlewis@catalystitservices.com>
On branch dev/catalyst-vlewis/CAT-49-copy_view_edit_links_in_catalog
modified:   var/templates_kcls/opac/parts/record/summary.tt2

KMAIN 1938 F8 Action on Patron Registration

Modify the Stash on patron registration in uEditFinishSave();
to set the newly created patron as last_patron.

Signed-off-by: khuckins <khuckins@catalystdevworks.com>

KMAIN-1920 Holds Notes print on slip

Change checked="false" to checked="true" in hold_details.js
for the "Print on Slip" checkbox, so hold notes automatically
set to print when you print the holds slip.

Signed-off-by: khuckins <khuckins@catalystdevworks.com>

CAT-48 Deactivate 'Missing' status

Add "Missing" state from config.copy_status to magical_status
constant.

Signed-off-by: khuckins <khuckins@catalystdevworks.com>
 Changes to be committed:
modified:   Open-ILS/xul/staff_client/chrome/content/main/constants.js

Include bib record fingerprint configs in sample DB export

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1466 Host patron card images locally; juggle images

Remove some cards, add some new ones.  Host them all on the EG servers
under web/images/patron_cards/*.png

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1426 Enumclaw classroom cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1426 Classroom cards generator improve error handling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1375 Classroom cards set to juvenile=false

Classroom cards have a DoB of 1900-01-01, which means the juvenile flag
is set to false for all classroom cards after one day of production
deployment.  Avoid the unnecessary update by setting the cards to
juvenile=false on import.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1375 Auburn school/classroom cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1439 Swap Ingram vendcode/vendacct values

Invoicing requires the vendor code and account values on the EDI
messages be in the proper location.  This also rolls back a change to
the EDI order template which swapped them directly within the template.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1379 Card app usability improvements

* Set state field to 'readonly' instead of 'disabled' in patron card form
so that the value will be passed to the server.

* Require phone to have the format /^\d{3}-\d{3}-\d{4}/ if any value is
present.

* Show warning style for missing values on street, city, post code.

* Validate fields onkeyup so it's obvious when a field is newly valid.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1379 Avoid dupe stat cats for stage users (WHD #5007215)

Ensure at most one copy of each stat cat is represented when saving a
staged user.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1379 Stage address uses dynamic virtual ID

Avoid using hard-coded ID for staged user addresses, using the dynamic
ID instead.  This resolves a problem where creating a new address
appeared to clone an existing staged address.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Updated sample data export, dropped to 750 bibs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Convenience script for running OS updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 Minor UI repairs; w3 lang images

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1345 Add Renton/Issaquah to SFTP client script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1345 Renton/Issaquah school cards

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 (etc.) Avoid data inserts on new DB builds

Repair some Sqitch SQL scripts so they don't insert or verify on data
that should not exist yet.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 Typos; image borders

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 Use BCMS link for Privacy Policy

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 PDF links; avoid dupe notice

And move FAQ up to the top.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 Limit state to WA; activation notice

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1324 Patron reg downloadable forms ; tweaks

* Create panel along the right for links to printable forms
* Change page title
* Add note about mailed cards delivery time
* Link to BCMS versions of card images

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1295 EDI invoice LI note requestor repair

Create LI notes using 'admin' as the creator for EDI invoices, since
there is no 'requestor' value in this context, but one is required.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1259 Hoopla/Lynda user login activity types

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1259 SIP test code API updates

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Remove fonts testing block

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Card app success blurb fonts/spacing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Card app submit-another button

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Center form

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Biblio CMS remote header/footer

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Self-contained page / doctype

Avoid using the standard TPAC wrapper so the card app form can define
its own <DOCTYPE> to avoid IE quirks mode.  Also, the wrapper loaded
some stuff the page doesn't need.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 Default to no home library selected

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 TT org_selector onchange / none_label

Signed-off-by: Bill Erickson <berickxx@gmail.com>

JBAS-1132 SQL sequence copy/paste repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>