Fix numeric types

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Remove default align values

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Turn col.align into classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Clean up error in holds table grid

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Clean up class name callback

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Wrapper and outline for keyboard navigation

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

explicit ARIA roles to support responsive tables

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

basic ARIA support

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

More popover repairs; column/row scope

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Repair popovers and context menus

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Add aria-describedby for item table links

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Restore column heading links for sorting

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

move basic classes out of callback

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

Fix <thead> and <colgroup>

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

revised eg-grid cell class callback

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

grid cell classes, first pass

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

table markup and IDL-based classes for eg-grid

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: search form repairs

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Padding adjustments

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Acq receive input cleanup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Align acq search conjunction

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Acq provider search

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Org family select

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Acq search form

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Vandelay recent date form

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Manage Authorities form cleanup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: More utility classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Style input group + label

Bootstrap input groups are not intended to be used with labels, but we
are doing so to provide screen reader support without (yet) redesigning
all our form layouts. This style removes extra padding and borders on
labels inside input groups.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000485 Bootstrap 5: Merge updates from bug squashing

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: search form spacing

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: search results spacing

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: form-select

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: Font styles

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: hold component fixup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: hold component fixup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: form-label class for every <label>

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: left/start, right/end

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Button blocks

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Form select and input group text classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Eliminate jumbotron style

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Modal/dialog close button classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: org-family-select repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Avoid default href links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5 / Recover .badge's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: MARC Editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: MARC Editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: verify credentials

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Silence some page load errors

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Rename some utility classes

See previous commit.  I missed a sub-dir.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Rename some utility classes

find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/font-weight/fw/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/ml-/ms-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/mr-/me-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/pl-/ps-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/pr-/pe-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/badge-/bg-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/badge/rounded-pill/g'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Login Page

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Angular 15; Bootstrap 5; And more\!; WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: search form spacing

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: search results spacing

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP2000482 Bootstrap 5: form-select

Signed-off-by: Stephanie <stephanie.leary@equinoxoli.org>

LP1999955 release note

LP1999955 AccessKeys info style updates

Adds styles to the keyboard shortcuts to make them look more like
keys. Also adds striping to each row and makes the headers bold.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1999270: add release notes

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1999270: Bold the Paid indicator on line items

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Mary Llewellyn <mllewell@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1916403 Staff catalog search form labels

Provides label tags for staff catalog search form fields.

Most labels in the form are visible. I have used the sr-only class to
make labels available to screen reader users while hiding them from
sight on the publication date range fields, which I think are easy
enough to use without visible labels. However, this combination of year
and operator dropdowns is not well organized for screen reader users,
and we should rethink the order and wording of these fields.

To test, visit staff/catalog/search and inspect each form field. Verify
that each one has a <label> tag where the for attribute matches the ID
of the associated form element. (Checkboxes wrapped in the <label> tag
still need matching ID and for attributes for consistent ARIA support.)

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
fix

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Susan Morrison <smorrison@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2003947 Add LID count to Acq Search

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2004187 Opens acq provider link in new tab on PO

Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Christine Morgan <cmorgan@noblenet.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2003742 Shelf browse in angular catalog uses deleted call numbers

Fixes the call number browse.  To determine the call number for which
the browse list displays, deleted call numbers are not removed from
the query.

To test in Concerto:
1. Go to a bib and click on the shelf browse tab. Notice where the list
begins.
2. Add a new item with a call number less thatn the starting point of
the browse list.  For example, if the list begins at 780, create
a call number at 100.
3. Refresh the browse screen and notice that the list now begins at
the lower call number.
4. Delete the item and call number that was created, the list still
begins at the lower call number.
5. Apply the patch.
6. The list should now begin at it's original call number.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#2007877: various fixes to Server Admin Print Templates page

This patch fixes a regression introduced by the switch to NgbNav
as well as a number of other issues.

To test
-------
[1] Open the Server Administration -> Print Templates page and select
    a print template. Observe that the template editor is not displayed
    and that there are errors in the browser console.
[2] Apply the patch and repeat step 1. This time, the template is
    displayed along with its previewed.
[3] Switch to the Sample Data tab, then select another template. Observe
    that the template is reloaded and the active tab switched to the template
    editor.
[4] Select a template such as "Checkin" that does not have stock
    sample data. Observe that the Preview and Compiled Content panes on
    the template editor tab are empty and that the Sample Data tab
    has an empty control

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1999282 (follow-up): fix css selector

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP2000482 Bootstrap 5: Font styles

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: hold component fixup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2006513 Angular login redirect repair

The routeTo parameter must contain an eg2-based path (/staff/splash)
and not a full path (/eg2/staff/splash) or URL.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP2000482 Bootstrap 5: hold component fixup

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: form-label class for every <label>

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: left/start, right/end

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Button blocks

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Form select and input group text classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Eliminate jumbotron style

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Modal/dialog close button classes

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: org-family-select repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Avoid default href links

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5 / Recover .badge's

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: MARC Editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: MARC Editor

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: verify credentials

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Silence some page load errors

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Rename some utility classes

See previous commit.  I missed a sub-dir.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Bootstrap 5: Rename some utility classes

find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/font-weight/fw/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/ml-/ms-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/mr-/me-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/pl-/ps-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/pr-/pe-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/badge-/bg-/g'
find . -type f -name "*.html" -print0 | xargs -0 sed -i '' -e 's/badge/rounded-pill/g'

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>

LP2000482 Bootstrap 5: Login Page

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP2000482 Angular 15; Bootstrap 5; And more\!; WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1999274: Add Release Note

Add a one line release note to miscellaneous.adoc to indicate that a
search performance issue is resolved.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1999274: Improve Search Performance on Pg 12+

Use OFFSET as an optimization fence to keep newer PGs from trying to
fold the c_attr and b_attr CTEs into the main search query.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1999282 Less intense badges for staff interface

Flips the contrast on badges to make them less intense and comply with
color contrast requirements. In keeping with the less intense alert
styles, the badges have more subtle background colors. I have also
adjusted the spacing and font weight to make the characters larger
without greatly increasing the overall size of the badge.

All of these styles pass WCAG AAA contrast checks. In anticipation of
Bootstrap 5, I have included the new .text-bg-* classes alongside the
current ones.

The access key modal (Control-H) is a good place to observe the overall
effect.

Signed-off-by: Stephanie Leary <stephanie.leary@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1841871: Add a test for creating authority record from bib field

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2007880: fix open-ils.actor.ou_setting.ancestor_default

This patch fixes a regression introduced by bug 2006749 that
prevented open-ils.actor.ou_setting.ancestor_default from retrieving
the value of a library setting that does not have a view permission
associated with it. It also fixes a similar issue with
open-ils.actor.org_unit.settings.history.retrieve.

To test
-------
[1] Use srfsh to retrieve the value of a library setting
    that does not have a view permission. E.g.,

    request open-ils.actor open-ils.actor.ou_setting.ancestor_default 4, "circ.grace.extend"

    Note that an error is returned.

[2] Apply the patch and repeat step 1. This time, the value of
    the setting should be returned.
[3] Verify that viewing the edit history of a setting in the
    Library Settings admin page works as expected.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1999065: update eg-pbx-mediator.pl to reflect RPC::XML::Server change

RPC::XML::Server switched from add_proc to add_procedure in version 0.75.

This patch fixes the following error:

eg-pbx-mediator.pl will not run and returns an error:
Can't locate object method "add_proc" via package "RPC::XML::Server::new:

Signed-off-by: Josh Stompro <stomproj@larl.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999944: fix bug that can break drawing the folder tree for reports

Specifically, skip drawfolders iteration if parent node cannot be
found and eport invalid parent folder in the browser console.

For example, if a user creates a template folder that is not shared
that has a child folder that _is_ shared, another user at the library
that the folder is shared with would see their report folders be
incompletely rendered.

Signed-off-by: Llewellyn Marshall <llewellyn.marshall@ncdcr.gov>
Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1754455: Sanity checking and auto-strip 852s when using --items

If a user passes --strip / inform them that their request to output nothing
but empty records has been denied. Also auto-remove existing 852 fields when
using --items because only actual holdings data should be output in that case.

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP 1754455: Update Release Notes for Latest Template

The four year old release notes used an out of date template.  This
commit changes two lines to bring them up to date with the latest
template.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1754455 Add Ability to remove fields or subfields in marc_export

This commit adds a --strip option to marc_export that allows fields
and/or subfields to be removed from MARC records on export.

To test: Try all forms of --strip:
    --strip <tag> e.g. --strip 856
    --strip <tag>/<sub>   e.g.  --strip 856/0
    --strip /<sub>   e.g. --strip /0

Try some regular expressions:
    --strip 8..
    --strip /[ab0]

For all tests, compare the regular output to the stripped otput and
the plain (unstripped) output.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP2006749: Fix second call to ou_ancestor_setting_perm_check in AppUtils.pm

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#2006749: Fix call to ou_ancestor_setting_perm_check in AppUtils.pm

The $self and $e arguments are missing when the ou_ancestor_setting
subroutine calls ou_ancestor_setting_perm_check in AppUtils.

The $coust argument also need to be $coust->view_perm->code for the
allowed check in ou_ancestor_setting_perm_check.

This commit corrects the call to ou_ancestor_setting_perm_check.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999432: add release notes entry

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1999432: (follow-up) expand "PubDate" abbreviation

The shelf browse interface has enough space, so this patch
changes the label to "Publication Date" for the sake of translations
and consistency with other places in the interface that use
the full label.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>