remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

remove deprecated code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

eager global ordinals on facet fields

Signed-off-by: Bill Erickson <berickxx@gmail.com>

boost and score sorting repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Better defined node unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Identifier searches / isbn issn normalizers

Signed-off-by: Bill Erickson <berickxx@gmail.com>

misc tidying and docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more docs, query clensing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

move away from mapper to pure client

Signed-off-by: Bill Erickson <berickxx@gmail.com>

exact/prefix searches continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic service continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder / marc search

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic-builder in action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

elastic bib field IDL class mod

Signed-off-by: Bill Erickson <berickxx@gmail.com>

more catalog integration experiements / elastic-builder

Signed-off-by: Bill Erickson <berickxx@gmail.com>

tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

tighter catalog integration WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>

initial tighter catalog integration / cat side needs more data

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add label to bib_fields list

Signed-off-by: Bill Erickson <berickxx@gmail.com>

additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

additional index tidying

Signed-off-by: Bill Erickson <berickxx@gmail.com>

initial support multiple lang analyzers; multi_match queries

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Updated example search in test script

Signed-off-by: Bill Erickson <berickxx@gmail.com>

add marc data to bib search index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Consolidate some indexing code

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index / searching

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib marc record index

Signed-off-by: Bill Erickson <berickxx@gmail.com>

support es proxied path; indexes one at a time

Signed-off-by: Bill Erickson <berickxx@gmail.com>

data sync continued / _id fix

Signed-off-by: Bill Erickson <berickxx@gmail.com>

working on data sync

Signed-off-by: Bill Erickson <berickxx@gmail.com>

disabled marc indexer experiment

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Remove some TODO comments: done

Signed-off-by: Bill Erickson <berickxx@gmail.com>

EL sample config superseded by per-index definitions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

force-on ang7 cat for now

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Avoid huge index values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Log first/last bib ID of each indexed batch

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Indexer orders by ID for batch consistency

Signed-off-by: Bill Erickson <berickxx@gmail.com>

indexer start-date support

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ES gets child init

Signed-off-by: Bill Erickson <berickxx@gmail.com>

copy loc/stat filters

Signed-off-by: Bill Erickson <berickxx@gmail.com>

copy loc/stat filters wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Group searches OR-based; lower kw normalizer

Signed-off-by: Bill Erickson <berickxx@gmail.com>

QP comp continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ang6 catalog use correct search_format filter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

QP based query compilation

Signed-off-by: Bill Erickson <berickxx@gmail.com>

search_format filter; logging

Signed-off-by: Bill Erickson <berickxx@gmail.com>

facets continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Indexer improvements, docs, and options

Signed-off-by: Bill Erickson <berickxx@gmail.com>

facets, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

el conf idl fields, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

use existing indexed values; refactoring

Signed-off-by: Bill Erickson <berickxx@gmail.com>

use existing indexed values

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing; search api wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

bib-search indexing wip

Signed-off-by: Bill Erickson <berickxx@gmail.com>

json config for now; index create/delete

Signed-off-by: Bill Erickson <berickxx@gmail.com>

ES/EG SQL

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1843599: AngularJS MARC editor once again sets bib source

This patch fixes a regression introduced by the patch for bug 1693580
that prevent changes to the bib source from being made via the AngularJS
MARC editor.

To test
-------
[1] Apply the patch.
[2] Create a new bib record and save it with a non-empty source. Verify
    that the record sets the source as expected.
[3] Edit a bib record and change the source. Verify that the new source
    is retained when the record is saved.
[4] Edit an authority record and save it. Verify that it can be updated
    without error. (Note that authority records do not have sources in
    the same way that bib records do.)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Rogan Hamby <rhamby@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>

LP#1855329: Hold shelf query speed problem

In bug 1827250 I suggested Jason Stephenson look at an alternate SQL
formulation to solve the original problem. He did, and deemed it faster,
so went with that. Unfortunately, on PG 9.6, we're seeing some data sets
that decide on a /very/ poor plan for the wide-hold query with the
solution as implemented, but the original suggestion from Jason works
fine.

In the face of evidence controverting my thought that giving PG more
options for planning is better in this case, this commit moves to his
original query change.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1858138: (follow-up) flesh creator and editor in sandbox's acp grid

Doing so ensures that the usrnames are displayed in the respective
grid columns rather than the au ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1858138: remove remaining uses of showLinkSelector

Now that showLinkSelector is deprecated and does nothing,
remove current uses of it.

To test
-------
[1] Apply the patch.
[2] Visit Angular admin interfaces that have grids that
    refer to linked IDL classes, e.g.,

    - Local Admin -> Carousels (carousel type)
    - Server Admin -> Weights Association (circ weights and hold
                                           weights)
    - Local Admin -> Item Tags (copy tag type)
    - Acq Admin -> EDI Accounts (provider)

[3] Verify that the columns for linked fields display the
    appropriate selector field rather than the numeric ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1858138 Sandbox example of simple grid filtering

Adds a trimmed down grid example demonstrating consistent filtering and
link selector display for auto and manual fields without requiring any
additional grid markup to define basic column behevior.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1858138 Link selector consolidation/repairs

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1858138 Grid IDL field definition repairs and more

* Deprecate showLinkSelectors, since FormatService now performs that
  logic under the covers.  Includes deprecation console warning.

* Fix Grid field IDL class extraction off-by-one error.  The code was
  stamping the source field with the class of the field's link target
  instead of the class the field actually belonged to.

* Allow for IDL field info extraction from the 'name' attribute when no
  'path' attribute is defined.

* Avoid console errors when clearing combobox values in grid filters.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1858138 Link selector consolidation/repairs

Move more of the IDL link class selector extraction logic into the IDL
service.

Avoid using 'name' as a fall-through selector field when no 'name' field
exists on the class.

Teach the idl service to log warnings on invalid class and field name
combinations in selector lookups.

Modify fm-editor and combobox to use the new idl link selector
functions.

While we're in there, avoid unnecessary API calls from the combobox
by preventing async data lookups with a search term of "_CLICK_".

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1858138 Action/Trigger IDL selector additions

Adds selector field entries for Action/Trigger hook, collector,
validator, reactor, and cleanup classes for ease of admin page building.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1857156: handle HHH:MM:SS durations in loans

This patch fixes a problem where loan durations of the form
HHH:MM:SS, where the hours component is longer than 2 digits, could
cause checkouts to fail. This sort of duration has been observed
in cases where a library wanted a long-term reserves loan that
doesn't have the due time bumped up to midnight.

To test
-------
[1] Set up a circulation policy that has a loan duration of 167:59:59.
[2] Attempt a checkout that uses that policy. Note that the checkout
    will fail.
[3] Apply the patch and repeat step 2. This time, the checkout should
    succeed.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>

LP1858118 Hatch enabled check repairs

Teach code asking Hatch whether printing is enabled to properly handle
the asynchronous response of the setting which now exists as a
workstation setting instead of a localStorage setting.

Related, if Hatch is unavailable, use browser printing regardless of the
hatch printing workstation setting.

Additionally update the "reprint last" handling to store the
last_printed value in localStorage instead of attempting to save its
value as a workstation setting.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: Fixing asciidoc syntax so fop doesn't complain about staff client admin manual

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: LP1767378 follow up: adding manual anchor

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Docs: fixed a spacing issue

Signed-off-by: Lynn Floyd <lfloyd@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

DOCS: LP 1767378 Work Log documentation

Updated Work Log documentation with new image.
Deleted old image files, noted which holds log.

Signed-off-by: Lynn Floyd <lfloyd1@library.in.gov>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1855931: (follow-up) make grid filter control cells wrap as well

This patch applies "word-wrap: normal" to filter control cells
as well, making it more likely that they will stay aligned with
the width of their corresponding header cells. This can be tested
by adding visible columns to the "Grid with filtering" table in
the Angular sandbox (/eg2/en-US/staff/sandbox) and verifying that
the column after "Circulating Library" continues to have its
filter widget stay aligned with its label.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1855931 wrap text for wide Angular eg-grid column headers

Make column headers text wrap so that you can fully read the header even if
it's several words long.  This will help when there are multiple headers
that start with the same word and they show up identically.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1857350: (follow-up) fix lint issue

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1857350 Org selector sorts by display value

When displaying the org unit selector, sort each set of children by the
display label (defaults to shortname).

Fixes issues with the org server sortTree function and adds a unit test
to test the repaired sort function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1843640 Standing Penalty Followup
Fix 2 issues:  grid not updating when a new record is created and
double clicking a row doesn't edit it

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/standing-penalty.component.ts

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1848778 Use consistent MARC breaker delimiter

Use the '$' delimiter in the read-only MARC breaker view for
consistency with the flat text MARC editor to easy copy/paste from one
to the other.

To test
-------
[1] Apply the patch.
[2] Set up two records in a record bucket and initiate a merge. Note
    that when you select a lead record and choose to edit it in
    flat text mode, you can copy and paste fields from the subordinate
    record display without having to change the subfield delimiter
    character.
[3] Mark a record for overlay, perform a Z39.50 search, then select
    a hit and choose the overlay action. Note that you can copy and
    paste fields from the record to overlay when editing the incoming
    record using the flat text editor.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1780283 Checking One Bill Checks Them All

Under Patron->Bills->History if Bill # isn't visible for the Transactions
grid or Payment ID isn't visible for Payments grid, rows can't be selected
individually. This adds the required attribute to those field directives.

1. Under a patron account with multiple bills, go to Bills->History
2. Remove Bill # from the Transactions grid
3. Try to select an individual row (note all rows are selected)
4. Apply patch and repeat steps 1-3 (note rows are selected individually)

Signed-off-by: Dan Briem <dbriem@wlsmail.org>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1712644 Prevent check out due date in past

- Prevents selecting past due date when checking out an item
- Prevents saving a due date with hatch when input date is invalid

Signed-off-by: Katlyn Beck <kbeck@catalyte.io>
Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1857710: fix Angular client whitescreen on Firefox

Work done for LP#1830391 added an instance of a Javascript
regexp replace using the dotAll ("/s") flag, but as of the moment
Firefox treats that flag as a fatal syntax error, breaking the
Angular staff client.

To test
-------
[1] Attempt to log in the Angular staff client with Firefox. Note
    that you get a whitescreen with the following in the browser
    console:

    SyntaxError: invalid regular expression flag s
[2] Apply the patch and repeat step 1. This time, the Angular
    staff client should work normally.
[3] Verify that the Angular unit tests pass.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP#1827942: follow-up to fix a couple issues

[1] Sets a default value for the modal options for dialogs such
    as ProgressDialog that do not supply any value for the
    options parameter; otherwise, progress dialogs would not
    appear at all.
[2] Fix lint warnings.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

lp1827942: prevent clicking outside an Angular modal from closing it

I added a new property to the "options" object inside the "open"
function, which resides in the dialog.component.ts. The static string
inside the backdrop property makes the form stay, even if the backdrop
is clicked.

Signed-off-by: Zavier Banks <zbanks@catalyte.io>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Fix doc build for glossary

asciidoctor was throwing the error "invalid part, must have at least one
section (e.g., chapter, appendix, etc.)"; including [appendix] in front
of the include mollified it.

Also we don't need the duplicated Glossary / Glossary headings.

Signed-off-by: Dan Scott <dan@coffeecode.net>

LP1830391 Stamping DB upgrate (hatch omnibus)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1830391 Angular test spec updates for Hatch store updates

The store service now leverages Hatch for workstation storage.  Update
unit tests which load the store service to also load and propagate the
Hatch service.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1830391 Warn on dupe workstation settings

Check for duplication workstations (by name and workstation) before
applying the UNIQUE constraint on actor.workstation_setting.  If found,
raise a notice to the user to provide suggestions.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1830391 Angular Hatch enabled flag lookup repair

Fix the Angular Hatch enabled setting lookup to pull the value from the
workstation setting instead of localStorage.  This required shuffling a
few things around to support the asynchronicity.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1830391 Hatch core mod import/export repairs

No need to import/export HatchService from the base common module since
it's now a core service which is exported automatically to root.

Includes minor lint repair.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1830391 Workstation settings unique constraint

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>