Upgrade script for a patch from Steven Callender addressing payment types in money.materialized_summary_payment

Signed-off-by: Mike Rylander <mrylander@gmail.com>

A fix so that the last payment types will be cash_payment and check_payment rather than bnm_payment for cash and check payments.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Remove craftsman skin.

Signed-off-by: Joseph Lewis <joehms22@gmail.com>
Via LP:
https://bugs.launchpad.net/evergreen/+bug/820010

And this email thread:
http://libmail.georgialibraries.org/pipermail/open-ils-dev/2010-August/006269.html

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Format an unordered list appropriately

The list of developer prereqs was munged inline rather than as a list.

Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Provide Fedora-friendly instructions for the DBD libraries

We had only provided the Debian / Ubuntu location of the libdbi-libdbd
libraries, so add the Fedora location as well.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Bring more of the wiki docs over to the README

Document Perl prerequisites for a standalone PostgreSQL server.
Include a section on starting Evergreen and basic troubleshooting.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Update the README to include database installation instructions

A long time ago, the database server was installed by default.
Nowadays, installing the database server is a separate step
reserved for whatever machine you want to devote to PostgreSQL.
Not that you can't put it on the same machine as the rest of
Evergreen and OpenSRF...

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Correct varname for PostgreSQL RPMs

On Fedora, Red Hat, and CentOS, we were still trying to install
the set of PostgreSQL RPMs for PostgreSQL 8.4 using PGSQL_84_RPMS.
This had been updated to PGSQL_90_RPMS to match the updated
database version - using the right varname resolves the problem
(at least on Fedora).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

Stamped upgrade script for user/miker/replace_field_fix

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Have replace_field return input XML when no replace rule is provided

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Avoid xml_transform retrieval in record attr def editor

config.xml_transform stores large chunks of XML.  Fetching it angers
Ejabberd on my test system.  All we need is the name, so use the new
AutoFieldWidget.searchOptions param to do just that.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

AutoFieldWidget support for augmenting pcrud search options

Adds a new searchOptions attribute to AutoFieldWidget for specifying
additional parameters to pcrud when retrieving linked objects.  The
initial use case is for supporting a "select" list to allow
AutoFieldWidget to retrieve only the display column of a linked object
and not the whole object.

Example:

 // fetch 'remote_field_name' on the remote objects instead of
 // fetching the entire object

 myGrid.overrideWidgetArgs.some_field = {searchOptions :
 {"select":{"some_hint":["remote_field_name"]}}};

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

calculate penalties when letting Mark Item Damaged add bills

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Fix oils_i18n_gettext id numbers

config.metabib_field ids 29/30 had 28 for translation id.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

use isNaN here, since NaN == NaN => false

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Correctly populate certain columns in the patron Messages interface

When applying penalties, the csp's referenced by the ausp's are fleshed.

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Fix broken builds due to test that can't find its data

LP 817699 reports a problem that began with commit
e9cd992fa4dbf1013346336193cb7469ecee10a8, reintroducing a problem that
had previously been resolved with commit
f017d1261c369b9b5cc3c9cfc4f50d3cdf12a445. In short, tests can and are
run from different directories, but a new test opened a file without
making any allowance that the test might be run from anything other than
the /test/ directory.

This fix uses the dirname(__FILE__) approach to provide the appropriate
relative directory for the test data, and enables the tests to be
processed without dying.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Make users confirm they really want to delete lineitems from POs...

... when they've already been ordered. There's really no reason to ever
make such a deletion this that I can think of, but I use a confirm()
instead of stricter measures in case I'm missing something.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Stamped upgrade for user/dbs/oclcnumbers

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Prevent control numbers from duplicating

In maintain_control_numbers(), if you have more than one 001 or
003, and at least one is the correct one, you will end up
duplicating the correct number every time the record is saved.

For example, if the incoming record was record ID # 12345, and
the record contained:

001: 12345
001: ocm10202

... then after maintain_control_numbers() ran, the record would
contain:

001: 12345
001: 12345

Also, clean up some leftovers from the refactor I suggested in the
previous commit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Add an unwrapped upgrade script for OCLC-aware control numbers

The upgrade script creates the SCN and LCCN search indexes and
populates them using metabib.full_rec as a source; cheating, but
the normalized values will work for non-exact search purposes. Sites can
reingest all of their bibs if they want exact search to work.

Also, refactor maintain_control_numbers() using a suggestion by
Dan Wells to eliminate some duplicate code.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Treat OCLC numbers specially in maintain_control_numbers

For some reason, many records that come with OCLC numbers in the 001
field are not populated with a 003 field. This resulted in the OCLC
number being thrown away entirely, rather than being moved into the 035,
as there was no corresponding control number identifier field.

However, given that we know that control numbers starting with "ocm" or
"ocn" are special OCLC numbers, we can generate the 035 accordingly even
in the absence of a 003. This update to maintain_control_numbers()
teaches it to do the right thing for OCLC numbers.

In addition, add an identifier search index so we can easily find
records by their system control numbers (035 $a subfields).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Ubuntu Lucid needs MARC::Record from CPAN

As Ubuntu Lucid ships with MARC::Record 2.0.0, and Serials requires
2.0.1 or greater, we must install MARC::Record from CPAN or face failing
open-ils.search requests.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

LP#813151 Copy Location sort order in Advanced Search

This patch addresses the unintuitive copy location sort order in
Advanced Search when searching at a specific branch. Thanks to
Dan Wells for the code suggestion which changes the order in the listbox
to alphabetical sort by asset.copy_location.name.
Tested, and confirmed working in 2.0.4 test and production environments.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

NOVELIST/CHILIFRESH include statements missing a hash which was causing (none) errors.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

adjust legacy xul column definitions for dates/timestamps to ensure correct  sorting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

remove circ.util.std_map_row_to_columns; default to the one provided by list.js

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Better sort support for xul lists (see launchpad bug ://bugs.launchpad.net/evergreen/+bug/751745)
Example of supplying a sort_value function for item Create Date, and automatic sort_value for fm_columns-generated timestamp and money column definitions.
Need to provide more such functions, and eventually move everything over to fm_columns

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Manage parts holds warning (and removal) w/ CSS

Use add/removeCSSClass to apply and remove holds parts selector
warning instead of inline style.border management, which (when using
'auto') causes problems in IE.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

sort hold Queue Position column correctly in xul lists

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Comment out line that breaks holds placement in IE

auto is not a valid option for a border, and IE faults on it.
Other browsers seem to ignore it, as far as I can tell.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

LP#647121 Event handling on override abort

Discussed on IRC, phasefx discovered that several events were not being properly
handled when they were empty strings.  Tested and working on Evergreen 2.0.4.

Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

MFHD compressed holding fixes

1. Add new utility method to MFHD.pm:
    holdings_by_caption(): return all holdings attached to a
    given caption

2. Add 'passthru_open_ended' option to get_decompressed_holdings()
    Previously, attempts to decompress an open-ended holding
    would error out.  Now, in the absence of this option,
    open-ended holdings are discarded and you get a warning
    (since they cannot logically be decompressed), while if
    this option is 'true' they are passed back unaffected

3. compressed_to_last() on an open-ended holding now more
   correctly returns 'undef' rather than the unaltered holding

4. get_compressed_holdings() will now honor an open-ended holding
   by treating it as "infinite", and thus absorbing any holdings
   which would follow

5. Overloaded comparison operator now correctly detects "swap"
   cases (where only the second operand is a holding)

6. Overloaded comparison operator now consistently treats
   open-ended holdings as "greater-than" a single or closed
   holding which has the same starting point

7. Fix 2 thinkos in comparison operator for overlapping
   compressed holdings

8. Add new compressed_end() method to Holding.pm which can add
   or set a new ending to a holding, making compressed if needed

9. Correctly recognize partially compressed holdings
    If a holding is defined as:
        863 40 $81.1 $a1 $b2-10
    this actually means:
        863 40 $81.1 $a1-1 $b2-10
    so let's make sure to treat it that way.

9. Expand the MFHD test suite to better cover the improvements
   in this commit

There is also the beginnings of a _get_truncated_holdings()
method for handling odd cases where an open-ended holding is
followed by a single/closed holding, but it is currently
commented out, pending further design consideration.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

rerun DB update 0582 to avoid upgrade problem

This implements the same update as 0582.schema.aging_circ_view.sql,
and exists purely the the sake of avoid a potential upgrade
glitch for somebody who's upgrading from 2.0.8+ that includes
a version of this fix that's not compatible with with 2.1+.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

lp#812550: Removed nulls from showing for patron penalties when no note attached to penalty.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Michael Peters <mrpeters@library.in.gov>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

Address minor code formatting consistency

The rest of the code has spaces around the conditional clause in an if()
statement, so do likewise here.

Signed-off-by: Dan Scott <dan@coffeecode.net>

Spine label editor assumes LC as reported in LP #780665.

This patch encapsulates the LC-assuming code in an IF block which
considers the asset.call_number.volume.label_class.  If that is equal to
3, it will use the LC formatting.

Signed-off-by: James Fournie <jfournie@sitka.bclibraries.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>

fix bill ui display update bug where total owed and total checked were not updated if the total owed as paid off in full

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Bad join condition all_circulation view"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Bad join condition in secondary (physical) address lookup, causing terrible performance of circ aging

Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP795032 Fix cursor rendering and dropdown position in holdings maintenance OU dropdown
Signed-off-by: mrpeters-isl <mrpeters@library.in.gov>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Opac Renewal at original circ library"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Default to existing behaviour for the new circ-behaviour global flag

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Cache global flag at first use

This way only the first opac renewal per backend has to ask the database for the global flag.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Opac Renewal at original circ library

Fixes multiple potential issues:
1 - Bad home ou on patron breaks circ rules
    Ex. Patron edited while editor would let you pick bad home ou
2 - Item not allowed to circ at patron home ou
    Ex. Patron went to where they were allowed to pick it up
3 - Fines change to patron home ou fine rules
    Ex. Patron's home ou doesn't charge fines but circ lib does
    Ex. Circ lib doesn't charge fines but Patron's home ou does

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Prevent OU loops at DB level"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for ou loop protect

May need to be split into "create function" and "add trigger" pieces.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Prevent OU loops at DB level

Database trigger to prevent actor.org_unit from being parent of self

Actually detects any loops, even those above the current point

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Make spell-checking case insensitive

As it stands, if you search for a proper noun using
lower case, but manage to trigger the "did you mean"
functionality, all the words are 'corrected' even if
just the case is wrong.  However, we are stripping
out the best correction precisely because it is the
same word, different case.  It is a bit confusing to
explain, but here is an example:

daniel potatoe

gets corrected to:

Daniela potato

This happens because the current spell check is case
sensitive, so 'daniel' is spelled wrong, but then we
remove 'Daniel' from the list of corrections
(presumably to avoid possibly suggesting terms which
would yield the same exact result set).

So, we either need to make the spell-check itself case
insensitive, or stop removing the re-cased corrections.
Since the catalog search itself is already
case-insensitive, I think it makes sense that the spell
check should follow suit.

Signed-off-by: Dan Wells <dbw2@calvin.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "INDB Circ Matrix + Checkout Overrides Fix"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script for checkout overrides

Replace the function.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

INDB Circ Matrix + Checkout Overrides Fix

Move most failures to after matchpoint lookup.
This prevents "no duration rule" errors on overridable errors.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stamping upgrade script for "Fix part holds in reporter.hold_request_record"

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix part holds in reporter.hold_request_record

Specifically, make them show a bib id, instead of null.

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Corrected the logic of format string building for metarecord holds and...

made hold possiblity checking for metarecord holds respect the format
string (so you can't place holds on formats for which there will never
be anything targetable)

Made possible by much concerted effort from Mike Rylander

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Stamped upgrade script for collections_exempt_perm

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Un-stamped upgrade script for collection exempt perm

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Permission to control patron-collections-exempt

Adds a new permission 'UPDATE_PATRON_COLLECTIONS_EXEMPT' which controls
who can toggle the circ.collections.exempt user setting in the patron
registration interface.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Correct CDBI thinko -- search_where is smart about wantarray, search is not

Signed-off-by: Mike Rylander <mrylander@gmail.com>

for realz, this time

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

fix backporting thinko

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

pin an upgrade version for fix_maintain_901_quoting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>

upgrade script for bugfix for lp#809540

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

lp#809540: quote replacement values properly in maintain_901()

Prevents a failure if, for example, the tcn_value of a bib to be
added or updated contains the string '\1'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

alert the user when the OPAC's Quick Search->Item Barcode function returns a pre-cataloged item

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>

append line items to table in specified order

Prior to this patch, the order that line items were displayed
in (e.g.) a purchase order view was effetively randomized based
on the amount of time it would take for async calls to fetch
additional line item details to return.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Correct CDBI field name on biblio::peer_bib_copy_map

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Ignore part-mapped copies for mr/title/volume holds

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Add Class::DBI linking for monograph parts (and some for conjoined items AKA peer bibs)

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Correct a documentation comment

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Filter out copies that have a monograph part designator when the hold is a non-P hold

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Suggest parts selection on failed parts-capable hold

When a title has copy parts and the user does not select a specific part
for the hold, treat it as a regular title hold.  If the title hold
fails, suggest to the user that he/she should select a specific part,
since that opens the door to a new set of potentially capturable copies,
which allow the hold to be successfully placed.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Signed-off-by: Jason Etheridge <jason@esilibrary.com>

Stamping upgrade version number for staff_search_find_no_copies branch (backport)

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Allow staff search to find bibs sans copies

AKA, no call number OR no call numbers with copies

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Unwrapped upgrade script

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

in unified vol/copy editor disallow editing of item attributes when no copies except via templates

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Delete protection - Ensure you can touch group

Same protection editing a user seems to get:
If you don't have the right group_application.user perm, reject

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Dan Wells <dbw2@calvin.edu>

Can't use 0 in true/false, use defined instead

This allows for setting renewals/grace period to 0 by force

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix checkout on alternate patron barcode

Specifically, when a non-primary patron barcode is used.
Such as via SIP2.

NOTE: This does not change the behavior of inactive cards, nor
will stock Evergreen usage produce a situation where this fix
comes into play. --miker

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP805971: Specify UTF8 encoding in password reset templates

As reported by Liam Whalen in Launchpad bug 805971: "The file
/openils/var/template/password-reset/reset-form.tt2 does not display
utf-8 characters.  I modified it to include '<meta
http-equiv="Content-Type" content="text/html; charset=UTF-8" />' inside
the <head> tag, and the fr-CA version of the page now displays
correctly."

I duplicated the problem in Firefox 5 and confirmed that the addition of
the META tag corrects the problem.

Signed-off-by: Dan Scott <dscott@laurentian.ca>

Normalize facet values

Spotted by Lebbeous Fogle-Weekley, facet values were not being normalized.  This is due to changes in how facets are stored in 2.1+.  This alternate implementation mirrors the way search_field index definitions work, which is a bit cleaner than inserting normalization into the field extraction process.

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Stampping upgrade for authorsort fix from Lebbeous

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Fix the SVF authorsort field (metabib.record_attr->'authorsort')

It's important not to include things like $0 that we wouldn't want in
there.

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Merge branch 'rel_2_1' of git.evergreen-ils.org:Evergreen into rel_2_1

when using params.data keys as print macros, render bare numbers correctly, and treat nulls as empty strings

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

when using params.data keys as print macros, render bare numbers correctly, and treat nulls as empty strings

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Correct copy-paste-o spotted by Dan Scott

Signed-off-by: Mike Rylander <mrylander@gmail.com>

Michael Peters provided a patch to add some missing labels...

... to a key acquisitions interface.  It works.  Also fixed
some unclosed tags while I was at it.

Wasn't sure whether to copy and paste Michael's sign-off or what, but
here's the link to his original patch for purists:
https://launchpadlibrarian.net/74191964/0001-LP802578-Acquisitions-Batch-copy-update-missing-head.patch

Signed-off-by: Lebbeous Fogle-Weekley <lebbeous@esilibrary.com>

Fix broken images for items without ISBNs in search results

The search results code happily sets the src attribute of the cover
image to an empty string (as returned by cleanISBN()) if currentISBN has
not been defined (which is generally the case if an item doesn't have an
ISBN, such as a DVD or a thesis or an old book).

Protect against the empty string and set the src attribute to
'/opac/images/blank.png' to avoid broken image indicators in search
results.

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

Saner behavior for Actions for Selected Holds -> Transfer to Marked Title

* Transfer the actual selected title holds, rather than all title holds for
the bibs referenced by those selected.
* middle layer method for changing the target and resetting specified holds
* label change for clarity, Transfer All Title Holds

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Cleanup of missed commit from the original topic branch

Signed-off-by: Mike Rylander <mrylander@gmail.com>
(cherry picked from commit b22d801e97565fc64205bf67e5a55d44090e1408)

Backport of cache visbility trigger speedup

Backporting:
 cdcbbbbc520e91f003b68d716dcd0d75a2b68971
 27bed378975a1164232d0b922cd03ce7493dee82
 f762b75ac430ed70365ebc0385d2c9d0da04ab26

from master

Signed-off-by: Mike Rylander <mrylander@gmail.com>

with scan missing pieces, retarget affected holds prior to recirculating to previous patron, lest the checkout reset the holds for us without retargeting

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

retarget title holds after transfering to a new bib

Signed-off-by: Jason Etheridge <jason@esilibrary.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>

Support Fedora 15 as a target in Makefile.install

Add Fedora 15 to the Makefile.install as a simple clone of the Fedora 14
target for now. Correct Makefile.install target names in README, and
point out that nothing special is required for Fedora 15 for PostgreSQL
9 support.

While we're in the README, rip out the Dojo toolkit install info as
packaged releases include Dojo now (we retain the developer instructions
for installing Dojo manually for git users, of course).

Signed-off-by: Dan Scott <dscott@laurentian.ca>
Signed-off-by: Dan Scott <dan@coffeecode.net>

Respect DESTDIR during the build process

Add $(DESTDIR) to paths it is currently missing from
Manually specify the apxs2 install location so that DESTDIR can be prepended
Attempt to create the apache directory if it does not exist

Signed-off-by: Ben Webb <bjwebb67@googlemail.com>
Signed-off-by: Dan Scott <dscott@laurentian.ca>

Stamped DB upgrade script for for XMLAGG cleanup

Signed-off-by: Bill Erickson <berick@esilibrary.com>

Upgrade script for the XMLAGG cleanup

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Bill Erickson <berick@esilibrary.com>