LP1904036 patron tab counts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 open circ exists dialog; billing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing / payments

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing; credit card form

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Billing continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Bills wireframing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Update stats after checkout; quite warning

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 place new hold button/action

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron summary pref name; penalties

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 print/copy patron address; summary styling

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 lint

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 add billings and more

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Alert dialog honors dialogTitle when present

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 events and overrides

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew with due date

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew all; initial events override dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Renew; Batch Checkout/Renew; shared circ components

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims never checked out

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Claims returned; circ notices

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron alerts page; resolver service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Move precat dialog to shared circ service

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron noncat count display

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark items lost

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark missing; initial checkin api

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Mark damaged; canceled holds display repair

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Edit due date; styling overdues

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out: printing

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Noncat batch retrieval API

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron items out grid; shared circ grid

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular login now handles routeTo

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion continued

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Barcode completion dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 checkout continued; grid actions

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat checkouts

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 precat dialog

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input followup

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog focus input; submit on enter

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron ui checkout tab; noncats

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Prompt dialog gets input type and min/max

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI lint repairs; sanity checks

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; search persistence

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron UI; canceled holds

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron Ui holds tabs

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron UI noncat/holds summary

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 patron expire check

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Angular Patron UI initial structures

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Grid rowSelectionChange Output

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron search form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1904036 Patron sesarch form improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Hold Management page update

Boopac screenshots

OPAC update

Boopac screenshots for hold notifications

Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP1950345-Format the Current Hold Groups table in bootstrap opac

This patch styles the Current Hold Groups table in bootstrap to be consistent
with other tables in the bootstrap catalog.  It fixes overlappling text
in cells.  It also fixes the column headings for small screens.  Previously
the headings on small screens were pulling from the css rules for the
holds history table.

To test:
1. create a couple of hold groups and add a patron to each group.  Make the
groups opac visible.
2. login to the opac as the patron to view the holds groups to which the
patron belongs.  Notice the table style with not margins or padding.
3. make your browser as small as possible to see the incorrect headings.
4. apply the patch.
5. repeat 2 and 3 to view the fix.

Signed-off-by: Garry Collum <gcollum@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

LP#1930617: reduce parallel requests initiated by AngularJS holdings editor

This patch decreases the number of parallel requests spawned by the
AngularJS holdings editor. This can reduce load on open-ils.pcrud when
the editor is used to handle a large number of items in one batch.

This patch takes the following approaches:

- the fetching of call number affixes now only makes one request
  per relevant org unit
- item alerts are now retrieved via fleshing when the batch of items
  is requested (as opposed to doing a PCRUD request for each copy)
- fetching monograph parts is now done serially

To test
-------
[1] Apply the patch.
[2] Create a bucket with a few hundred items and edit all of them
    in the AngularJS holdings editor (which is what you get when
    you edit items from the bucket interface).
[3] Verify that the editing loads itself without causing errors
    or PCRUD drone spikes.
[4] Verify that item alerts and monograph parts are loaded
[5] Verify that the call number prefix and suffix drop-downs
    are correctly populated.
[6] Verify that copy alerts can be attached to newly-created items
    and saved.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

Docs: Alternate Notice Templates documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: Cover Image Upload documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#1974195: fix memory leak when performing fleshed Fieldmapper search

This patch fixes a memory leak that occurs when performing
a fleshed search of an IDL class via open-ils.cstore, open-ils.pcrud,
or open-ils.rstore. It removes a debug-level log entry that didn't
free a temporary string.

To test
-------
[1] Perform a PCRUD search that includes fleshing and retrieves
    a large responses. One example is a search on bre that fleshes
    call numbers and copies and returns a few hundred bibs.
[2] Observe that the PCRUD drone that serviced the request has
    increased its memory usage significantly.
[3] Apply the patch and repeat step 1. This time, the drone's memory
    usage should not (persistently) increase as much.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: correction to Staff Portal Page docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: Staff Portal Page documentation

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

fix typo in 3.8.1 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Forward Port 3.8.1 Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Forward Port 3.7.3 Upgrade Script

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Update 3.8 Point Release Notes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Update 3.7 Point Release Notes

Signed-off-by: Jason Boyer <JBoyer@equinoxOLI.org>

Docs: 3.8.1 Release Notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: 3.7.3 Release Notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP#1857910: (follow-up) fix styling of mandatory class and field comboboxes

This patch uses the 'mandatory' synonym of 'required' in the custom comboboxes
for the IDL class and field.

There remains an issue: the fact that those fields are mandatory does
not propagate to the overall form validation.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1857910: (follow-up) enhance IDL for field doc

This patch adds human-readable labels to the IDL for
field doc. It also marks required fields in the IDL, removing
the need for the Angular code to explicitly specify
the set of required fields.

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1857910: (follow-up) stamp DB update

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1857910: (follow-up) clean up lint

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP1857910 release note blurb for field doc port

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1857910 add org family selector to field doc UI

If we want this to default to workstation org or something, we can do that, though I was having trouble
getting that to work.  Right now it'll include all orgs in its default unselected state.  I'm also not
sure about i18n-labelText and whether that works with eg-org-family-select.

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1857910 make field doc grid sortable/pageable

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1857910 ws setting type for field doc grid

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP1857910 Field doc UI Angular 10 updates

Modify the lazy loader to use the new Ang10 style loading syntax.

Avoid using template variables as output variables for other components,
since template variables (those declared with let-foo="bar" in
<ng-template/>) are read-only, possibly as of Ang 10, so the page was
not loading at first.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

lp1857910 Field Documentation Port

- Port grid UI allowing the creation and editing of Field
Documentation from DOJO to Angular

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/field-documentation.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/field-documentation/routing.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1946531: (follow-up) show progress bar when adding users to bucket

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1946531: use batch method to add users to bucket via User Buckets UI

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

lp1950507 Providers Admin Screenreader form fix

- Move Search and Reset Form buttons to bottom of form when expanded.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>

LP#1968082: (follow-up) show progress bar when adding/removing items from bucket

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1968082: (follow-up) tidy up whitespace

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1968082: Use the batch API call to add and remove items from item buckets.

In particular, when adding/removing items while on the item
bucket interface itself.

Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <js7389@princeton.edu>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

fix a syntax warning in the 3.9 release notes

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Docs: further updates to 3.9 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: OAI-PMH data provider support

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: adding rel_3_9 menu item

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: Simple Reports docs

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

Docs: updates to 3.9 release notes

Signed-off-by: Andrea Buntz Neiman <abneiman@equinoxinitiative.org>

LP1930740 EDI order writer attribute check repair

Repairs mistaken references to $self->{compiled}->{edi_attr}...  The
hash key we need is {edi_attrs}.

This issue prevented these attribute types from getting applied:

LINEITEM_IDENT_VENDOR_NUMBER
COPY_SPEC_CODES
INCLUDE_EMPTY_LI_NOTE

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <sandbergja@gmail.com>

clear miscellaneous.adoc for next release

Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

LP#1965579: stop gap for negative bills in OPAC

(and zero bills).

If a patron has zero-dollar or negative bills present, the OPAC will
disallow payment and point the patron to their library to resolve.

Cribbed from Terran's rel_3_8_0_temp_fix_for_stripe_negative_bill_bug @ evergreen/pines.git

Signed-off-by: Jason Etheridge <jason@EquinoxOLI.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxOLI.org>

Forward port 3.9 upgrade script

Signed-off-by: Mike Rylander <mrylander@gmail.com>