LP#1865533: save changes on Edit Hold in My Account

When editing a hold in the OPAC, changes are not saved if the SMS field
is blank.  The sms_notify value is being passed as an empty string, and
this non-null value violates the "sms_check" constraint on
action.hold_request.  Replacing the empty string with undef allows the
hold update to succeed.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1787636: Sort Libraries without Holdings In Holdings View

Empty libraries in holdings view are listed at the end of the library
list instead of integrated within the list.  This patch sorts them
within the list.

Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1787636: Remove right justification in grid view

Align all owning libraries to the left as requested in the bug
description and comments.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1813088: Coerce Values to String in egGridValueFilter

Coerce values to string in the switch for Boolean columns in the main
egGridValueFilter function.  This came about after an IRC conversation
with Mike Rylander who suggested this as a possible fix.  It should
when field values are strings, integers, or Booleans.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1869906 Angular staff cat browse links

Use routerLinks instead of click-handlers for browse results links so
users have the option to control-click and open individual results in a
new tab.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1876163 - Fix Angular Test Failure

ERROR in app/core/format.spec.ts -  TS2554: Expected 4 arguments,
but got 3.

orgService = new OrgService(netService, authService, pcrudService);

Commit 9e8d662f418 added a new first argument to the OrgService
constructor and two files needed updates:

* app/core/format.spec.ts
* src/app/core/org.spec.ts

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1869794: Stamping upgrade script

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1869794 new best hold sort order

owning lib to requestee home lib proximity

implementation, release notes and TechRef tweak

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Lindsay Stratton <lstratton@wlsmail.org>
Signed-off-by: Ben Shum <ben@evergreener.net>

LP1858448 Aged money pgtap test repair

Enable the "age money with circulations" setting in the original aged
money pgtap test so the aged money it seeks may be created and found.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1873286 - Add release notes entry

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1873286: Fix Bad End Tags

Fix self-closing tags used in non-void HTML and non-empty XHTML tags.
These tags now cause errors with jQuery version 3.5.0 and were
technically wrong from the start.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1375296 - Quiet deprecation warnings in autoreconf -i step.

Thanks to Warren Layton for suggesting this fix to the community!

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1848550 / LP1835128 Redirect to AngJS splash page

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1848550 Cache org settings in IndexedDB (Angular)

Teach the org settings lookup code to store cacheable settings (those
for "here") in IndexedDB to reduce the number of repetitive network
calls for org unit settings.

Settings cached in IndexedDB are cleared upon successful login to avoid
stale values.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1854850 Angular IndexedDB Shared Worker Communication

Implements the client side of the communication to the Evergreen
IndexedDB shared worker for Angular.

From this may be built caching mechanisms, offline transaction
handling, etc.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1848550: client-side caching of org settings for AngularJS

The web client almost always does live lookups any time it needs to
check an org setting.  But these settings rarely change, so it would
make sense to cache them.  They're already cached using Lovefield in
order to support offline; this commit checks the cache first, and only
does a live lookup if the setting is uncached.

The settings cache is cleared on login to ensure stale values don't
stick around forever.  To refresh the cache, simply logout and then
login; cached values will be deleted and the latest values will be
retrieved from the server when they are needed.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

Lp 1858448: Fix version number in upgrade script

Change "TODO" to "1202" in versioned upgrade script.  I'm not sure how
that didn't happen unless I forgot to save the file or doing an
--amend before pushing changed things.

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP 1858448: Stamping Upgrade Script

Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 Disable inititial aged money migration

Modify the existing SQL upgrade scripts to prevent the automatic
migration of billings/payments to the new aged money tables.  This is
done to prevent data loss for sites which have not yet upgraded to the
affected versions.

The schema changes are kept so both pre- and post-upgrade sites can
follow the same schema update path.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 Upgrade instructions WIP

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 Money aging srfsh script function repair

Fixes a copy pasto in the money aging script, teaching it call the
correct money aging function.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 More IDL fixups

Make IDL fixes as recommended in the Launchpad bug discussion.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1858448 Aged money control flags

Adds 2 global flags for controling if/when billings and payments are
aged.

history.money.age_with_circs
history.money.retention_age

Adds a srfsh script for manually aging money based on the
'history.money.retention_age' setting value.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 Aged payment fields release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP1858448 Additional aged_payment fields

Adds accepting_usr, cash_drawer, and billing columns to the
money.aged_payment table.

Modifies the existing "xact" column for aged payments and billings in
the IDL to link to "mbt" instead of "acirc", since not all
payments/billings are linked to aged circs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

LP#1772053 - Fix minor typos

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP 1772053: Cleanup Dan's code.

Mostly whitespace cleanup, but I did restore a line or two that appear
to have been accidentally deleted.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP 1772053: Add Missing Fields to Print Templates

Almost complete implementation for LP1772053.  To be done: items
relating to call numbers, prefixes and suffixes for Hold Pull Lists
and Transit Slips.

Signed-off-by: Daniel Pearl <dpearl@cwmars.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1781274 Fix floating point issue preventing transactions from closing

Paying multiple bills with a single payment can lead to some
transactions not closing because of floating point math inaccuracies.
This branch resolves the issue by limiting pending payment amounts to
2 decimal places.

The bug can be reproduced using grocery bills as follows.

Retrieve a patron that owes no money.

Add a billing of $.90
Add a billing of $.10
Select both billings
Enter $1 in payment received and Apply the payment

Click on History in the billings screen. Turn on the Total Billed and
Transaction Finish Time column and note that the $.10 bill has zero
balance owed, but does not have a transaction finish time.

To test:

Use the steps above to reproduce, noting the lack of Transaction
Finish Time.  Apply the patch.

Use the same steps above and note that the post patch payments
resulted in both transactions getting a Transaction Finish Time.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

Docs: additions to 3.5 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1868354 Angular catalog item/call number transfer

Add support for 3 varieties of items and call number transfer in the
Angular staff catalog.

1. Transfer selected items to selected call number.

2. Transfer selected call numbers and attached items to selected bib
record.

3. Transfer selelected items to selected bib record and org unit ID
(owning library) creating new call numbers as needed.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1819540 - Change expire list to match what the hold expire function

Updated to use 'today'::timestamptz as suggested by Mike Rylander.

Testing:

1. Update a few holds that show up on the hold shelf so their shelf time
is set to now.

2. Confirm that you see them on the holds shelf.

3. Show clearable holds, holds are on the list.

4. Check in one of the items, and see that it goes back on the hold shelf.

After Fix Applies.

1. Update a few holds that show up on the hold shelf so their shelf time
is set to now.

2. Confirm that you see them on the holds shelf.

3. Show clearable holds, holds are no longer on the list.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: John Amundson <jamundson@cwmars.org>
Signed-off-by: Jason Stephenson <jason@sigio.com>

lp1801137 Item Status Precat Information

- Display precat title, author, and isbn in place of
regular title, author, and isbn fields in Item Status
list view when working with precat items.
- Add Dummy Title and Dummy Author fields to Item Status
Detail view when looking at a precat item.

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
Signed-off-by: Jennifer Pringle <jennifer.pringle@bc.libraries.coop>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1774268: Tidy up hold notification testing

Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP#1774268: handle opac.hold_notify empty string in AngJS patron editor

If a patron does not want either phone or email hold notifications,
their opac.hold_notify user setting will be an empty string.  Let's
ensure that the hold notify checkboxes remain unchecked in the patron
editor when that is the case.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP 1774268: Default Hold Notification checkboxes

On patron edit screen set the email and phone notification
to true when patron doesn't have any prefernces. This mimics
the behavior in the xul client.

Signed-off-by: Michele Morgan <mmorgan@noblenet.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1849683: Stamp upgrade script

Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1849683: i18n and space supplement

Minor changes to realign inserts and permission assignment
with those surrounding, and remove a bit of EOL whitespace
in the release note.

Signed-off-by: Jason Boyer <JBoyer@eoli.info>

LP1849683: Permission for custom css setting

Add a permission to restrict who has access to
the Custom CSS for the OPAC setting.

Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>

lp1834251: I18Nize these alt tags

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Bug 1834251: adding alt attributes to Open-ILS\src\templates\kpac\parts\paginate.tt2.

Signed-off-by: Sam Link <slink@LIBPC002>
Signed-off-by: Llewellyn Marshall <lbmarshallv.ncdcr@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1865951: Fixes to consistency in two files, creating uniform capitalization and use of ellipses

Signed-off-by: Sam Link <slink@gchrl.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

Translation updates - po files (3.5.beta)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

Translation updates - newpot

Signed-off-by: Bill Erickson <berickxx@gmail.com>

First pass at release notes for 3.5

This commit consolidates all the release notes in RELEASE_NOTES_NEXT,
and does a few minor edits to formatting, layout, and text for improved
flow of the content.

Filling out of acknowledgements remains a TODO.

Signed-off-by: Dan Wells <dbw2@calvin.edu>

lp1789491 visited link color

Some interfaces use a red or dark red background color for certain rows
and the visited link color makes it hard to read.  Adjust this color
so there is more contrast against the red background.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1811132 Debit payment SQL upgrade fix

Repair a copy/paste thinko in the upgrade script for debit card
payments.

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1853363: add SIP2 option patron_status_always_permit_loans

This patch adds a new oils_sip.xml login attribute called
patron_status_always_permit_loans that specifies whether
the charge privileges denied, renewal privilges denied, and
card reported lost flags in the patron status block should be
coerced to permissive values regardless of the actual state
of the patron record. Turning this on works around an issue
where a 2019-12 change by the Hoopla SIP2 client takes those flag
fields into account, but some libraries may not wish those
to block a patron's access to online resources that use
SIP2 to authenticate. This setting can also be set as
an implementation_config option; note that if it is set to
'true' or 'false' as a login attribute, the login attribute will
override whatever is set in the implementation_config.

To test
-------
[1] Set up a test system that has SIPServer running. Also set
    up a patron that either has a standing penalty blocking CIRC
    or renewals, expired privileges, and/or a lost primary card.
[2] Perform a SIP2 patron information request (message 63) for
    the patron created in step 1. Note that the charge, renewal,
    and card lost flag fields in the SIP2 response should be set
    to indicated that privileges are denied.
[3] Apply the patch and enable patron_status_always_permit_loans
    either as a login attribute or a implementation_config option;
    oils_sip.xml.example in this patch contains examples.
[4] Repeat step 2; this time, the three flag fields should have
    permissive values (i.e., they will be set to the space character)
    regardless of the state of the patron record.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Jason Boyer <JBoyer@eoli.info>
Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>

LP#1811132 - Stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1811132: add Debit Card payment type

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1846484 - Add BETWEEN SYMMETRIC to reporter SQL builder

Let's give end users a break and forgive them when they mix
up the order of a date range.  BETWEEN SYMMETRIC allows users
to enter a date range in any order rather than strictly
enforcing "oldest date first" and returning an empty result
set.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Rogan Hamby <rogan.hamby@gmail.com>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

lp1845240 port of Surveys UI from DOJO to Angular

idlClass asv holds the surveys, asvq holds their questions, and
asva holds the answers to those questions. The surveys are in
their own module and are lazy loaded

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Modernize the survey create API by migrating it to cstore.
Additionally, make it possible to modify an existing survey top-level
object by setting 'ischanged' to the inbound survey.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1845240 Migrate survey create API to cstore

Modernize the survey create API by migrating it to cstore.
New API supports full range of isnew / ischanged / isdeleted actions on
the survey, questions, and answers.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
LP1845240 Survey API returns updated fleshed survey

Signed-off-by: Bill Erickson <berickxx@gmail.com>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/admin-local-splash.component.html
modified:   Open-ILS/src/eg2/src/app/staff/admin/local/routing.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-edit.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-edit.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey-routing.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/local/survey/survey.module.ts
modified:   Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Survey.pm
modified:   Open-ILS/tests/datasets/sql/surveys.sql

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#1863929 - Fix sample survey data.

Since we enter the surveys, questions, and answers with specified ID values
but don't set the values to one higher, testers were unable to enter survey
data.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP#850160 - Event Def Environment Fleshing Might Have Issue

When the action trigger environment gets fleshed out, there is a bug
with how might_have relations are fleshed ever other time they are
evaluated.

The first time they are correctly evaluated, but then the next time the
same path gets evaluated, the object gets reset to the first value in
the object.

See https://bugs.launchpad.net/evergreen/+bug/850160 for testing notes.

The fix is to add an extra check to only grab the first element if the object is
an array.  If it isn't an array it means it has already been fleshed.

Testing notes:

One way to test this bug is by looking at the self check
receipt, hours of operations bug.
https://bugs.launchpad.net/evergreen/+bug/793627

By default, the self check receipt will fail for even numbers of items checked
out because the hours of operation doesn't get fleshed correctly.

With this change, the receipt should print for even and odd numbers of items.

Another test is to add user.money_summary to a lost/bill action trigger
event notification.  Before the fix, if you have an even number of items billec, the
user.money_summary gets set to the first object in that table, and for odd
numbers of items, user.money_summary.balanced_owed gets set correctly.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1840332 Item Status Input Field Acessibility

This adds an accessible label (aria-label) to the Item Status input field
of the web staff client.

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Llewellyn Marshall <lbmarshallv.ncdr@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1570072: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1570072: update hold notification methods upon preference changes

This patch adds a feature where if a patron's hold notification
preferences are changed, they are given an opportunity to have
notfication methods for their pending hold requests updated to
reflect their new prefernces.

This feature affects both the public catalog My Account interface
and the staff patron registration form. In both cases, the user
is presented with a modal (staff-side) or interstitial page (public
catalog) asking them whether to update current hold requests.

Sponsored-by: MassLNC
Additional-work-by: Mike Rylander <mrylander@gmail.com>
Additional-work-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>

LP#1849736: remove testing upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849736: Stamping upgrade script

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1774285 (follow-up): Make page title consistent with heading

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1774285 - Change Pull list page title from Holds Shelf title.

Add a string for 'Pull List' and set the page title to that string
when the pull list interface is loaded.  Allows staff to tell which
tab has the Holds Shelf open and which tab has the Pull List open.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1860460 Copy delete override repairs, perm failed handler

* Teach the Angular holdings module vol/copy delete dialog to correctly
  report failure events to the user and handle permission overrides.

* Add support for automatically launching the op-change dialog when a
  permission failed event is returned by an API call for any /eg2/staff/
  interface.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1668352 Add barcode to patron neg balance grid

Add a barcode column to the existing Patron Negative Balance Grid.
It should be hyperlinked and link to the relevant patron.

Signed-off-by: Mike Risher <mrisher@catalyte.io>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1840287: Add a return to list button for floating group edit page

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1840287 Floating group admin minor code tweaks

* Added grid sorting to both group and group member grids.

* Avoid using the defaultNewRecord in fm-editor directly, by cloning it
  as needed, so that subsequent new records (within a single parent
  component instance) do not pick up values from the previously created
  record.

* Renamed the eg-admin-page @Input() 'hideFields' to 'hideGridFields'
  to better explain how the value will be passed along.

* Replace access of fieldmapper innards (thing.a[0]) with field names
  (thing.id())

* Remove unused <eg-string /> entries.

* Avoid unnecessary newlines in translatable strings.

* Remove unused @Inputs() and unnecessary functions

* Remove unneccessary TreeModule import

* Removed a redundant <eg-title /> -- <eg-staff-banner /> will set the
  title when present.

* Various 'ng lint' repairs.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1840287 Floating group IDL required fields

Indicate require Floating Group and Floating Group Member fields in the
IDL to support UI form validation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

lp1840287 Edit Floating Group Members

Add functionality so that when editing a floating group, one
is taken to a page where one can edit a given floating group as
well as all its linked members. New functionality:
- eg-admin-page can hide grid fields
- fm-editor can create a record with fields defaulting to values

Signed-off-by: Mike Risher <mrisher@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/eg2/src/app/share/fm-editor/fm-editor.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/edit-floating-group.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group-routing.module.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.html
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.component.ts
new file:   Open-ILS/src/eg2/src/app/staff/admin/server/floating-group/floating-group.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/admin/server/routing.module.ts
modified:   Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.html
modified:   Open-ILS/src/eg2/src/app/staff/share/admin-page/admin-page.component.ts

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1845706 (follow-up): Fix callback

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1845706: Missing/Damaged from Items Out

Marking items Missing or Damaged from the patron Items Out interface
is sometimes necessary.  This commit adds that ability.

Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>
Signed-off-by: Dawn Dale <ddale@georgialibraries.org>

LP#1863386: link ADMIN_CAROUSEL permission to appropriate OU context

This patch restricts prcrud retrieval and modification of templates
to users who have ADMIN_CAROUSEL in the relevant carousel owner OU
rather than requiring global_required.

To test
-------
[1] Apply the patch.
[2] Ensure that a user with ADMIN_CAROUSEL privileges at a depth
    lower than "Consortium" can only view and edit carousel
    definitions at OUs applicable to their working libraries.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Jennifer Weston <jennifer.weston@equinoxinitiative.org>

LP#1839684: avoid repeating qtype prefix in query

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mike Rylander <mrylander@gmail.com>
Signed-off-by: Gina Monti <gmonti@biblio.org>

LP1854197 Add Vols and Copies honors owning lib

Fixes a bug in the Add Volumes and Copies action where there vol/copy
editor was unable to extract the owning library of the selected volumes,
thus leading to no differentation between owning libraries in the editor
and having all of the new volumes/copies linked (by default) to the
first owning library in the list.

To test:

1. Navigate to Item Status UI
2. Scan multiple (say, 3) barcodes, each with a different owning lib.
3. Select all 3 items and chose "Add Callnumbers and Items"
4. The holdings edit page that results should show one volume and copy
   row per owning library instead of all rows linked to the first owning
   library in the set.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jessica Woolford <jwoolford@biblio.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849736 Add action trigger for email/sms for patron self registration

Removed double blank lines at the top of the stock AT Email template.

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1849736 Add action trigger for email/sms for patron self registration

Setup a new A/T Hook.

Includes:
1. New row in action_trigger.hook
2. New row in action_trigger.event_definition
3. New clause in action_trigger_filters.json.example
4. Link XML clause for oils_obj:fieldmapper="staging::user_stage" on fm_IDL.xml
4. pgTAP Test
5. Release Documentation

Signed-off-by: blake <blake@mobiusconsortium.org>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Replace bib "quality" with item "mint_condition"

I originally misunderstood the XUL item field labeled "quality" and
pulled in the bib record "overall quality" score. But upon checking the
XUL holdings maintenance screen again, we clearly want the item's
"mint_condition" field instead. This commit makes that correction and
converts the 't' or 'f' values into "Good" or "Damaged", to match the
item editor labels.

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1761222 Holdings batch circ retrieval

Fetch non-checked-in circulations for copies in the Holdings
maintenance grid (for due date display) in batch instead firing a
potentially vary large parallel batch of pcrud API calls.

This also limits due date display to items that have open circulations,
consistent with the XUL client.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Add four columns available in XUL client

The XUL client had these columns but they hadn't been added to the web client
yet. This commit adds them:

  - Classification
  - Due Date
  - OPAC visible?
  - Quality

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP#1761222: Add Fine Level, Loan Duration to Holdings View grid

Signed-off-by: Remington Steed <rjs7@calvin.edu>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1760193 - Action Rewording

- Rename "Add Items to Bucket/Record Bucket" and
"Add Items/Item Records to Bucket" to "Add to Item/Record
Bucket"

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
modified:   Open-ILS/src/templates/staff/cat/item/index.tt2
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

lp1760193 Add to Record Bucket from Item Status

- Add "Add Items to Record Bucket" option in Item Status
UI
- Refactor Add Copy to Bucket functionality to support
adding to Copy Buckets or to Record Buckets depending
on optional bucket_type parameter

Signed-off-by: Kyle Huckins <khuckins@catalyte.io>
 Changes to be committed:
modified:   Open-ILS/src/templates/staff/cat/item/index.tt2
modified:   Open-ILS/src/templates/staff/cat/item/t_list.tt2
modified:   Open-ILS/web/js/ui/default/staff/cat/item/app.js
modified:   Open-ILS/web/js/ui/default/staff/circ/services/item.js

Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

LP1850546 Record detail shelf browse

Adds support for browsing call numbers directly from a record detail
page, similar to the TPAC's 'Shelf Browser' tab in its detail page.

Add support for jumping to a record detail page or a new author search
from each shelf browse entry.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1850546 Call number browse grid

Return to grid-shaped call number browse with denser data display for
main CN browse UI.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1859241 Relase Notes (Angular Patron Search)

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1859241 Angular holds patron search dialog

Implements a patron search dialog which may be instantiated directly
from the staff catalog holds placement interface.

Includes:

1. New patron module (which absorbs the existing PatronService)
2. New patron search component
3. Patron search component dialog wrapper.
4. Patron profile selector component which understands custom group
   display trees.
4. Fixes an issue with the grid where the 'datatype' was not always
   propagated to IDL fields.
5. Modifies the combobox to allow the caller to clear the value by
   passing a null value for the selectedId.

To Test:

[1] Navigate to the Angular staff catalog
[2] Perform a bib search
[3] Click 'Place Hold' next to a title.
[4] Click the 'Patron Search' button.
[5] Search for patrons and either double-click a search result row or
    single click then chose the 'Select' button.
[6] Confirm the selected patron is now chosen for holds placement.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860044 Release Notes for Ang Cat Highlights

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860044 Angular catalog search result highlights

Support search field highlighting in the Angular staff catalog
search result and record detail pages.

Adds a new <eg-bib-display-field /> component for rendering the
highlighted content.

Move the catalog-common module import into the staff common module so
the bib-summary component has access to the new display-field component.

Drop the default search result page size to 10 for consistency with
other catalogs (and to speed up rendering).  Note users can still set
the page size of their choice via user settings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1841823 Marc flat editor repair slashes (AngJS)

Replace all control field spaces with backslashes in MARC Flat text
editor (AngJS edition).

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>

LP1841823 Marc flat editor repair slashes (Angular)

Replace all control field spaces with backslashes in MARC Flat text
editor, Anglular edition.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Elaine Hardy <ehardy@georgialibraries.org>

LP1859706 Map Angular cat "Patron View" to AngJS "OPAC View"

The Angular catalog now treats the "Patron View" tab as the same as
the "OPAC View" tab in the AngJS catalog for the purposes of saving a
preferred default tab.

Similarly, the Angular catalog-only "Item Table" tab maps to the AngJS
"OPAC View" tab, since it's the closest analog.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1819236 Ang cat prevent keyword starts/exact searches

Prevent users from attempting Keyword starts-with or matches-exactly
searches since these are nonsensical.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Ruth Frasur <rfrasur@gmail.com>

LP1860275 Staff catalog add mono part repair

Fixes a bug in the New Monograph Part dialog which prevented passing the
bib record ID during the creation process, which resulted in a database
error and faulure to create the part.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Tiffany Little <tlittle@georgialibraries.org>

LP1850938 Stamping DB upgrade (Ang Cat Prefs)

Signed-off-by: Bill Erickson <berickxx@gmail.com>

LP1850938 Angular Catalog Prefs Release Notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1850938 Angular Catalog Preferences Page

Adds a new "Catalog Preferences" interface, accessible directly from the
catalog.  The UI houses the search preferences (default search lib,
preferred library, default search tab), a new staff-specific
hits-per-page setting.  Other preferences may be added later.

Adds support for selecting a default search tab using the existing
'eg.search.adv_pane' setting.

Reduce API call count by loading more of the catalog preference settings
in the main batch invoked by the page resolver.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Terran McCanna <tmccanna@georgialibraries.org>

LP1852782 Improve MARC edit save/delete button placement

Move the Save Record button to the left of the Delete Record, which is
more consistent with other yes/no button combinations in the client.
Also adds additional spacing and a faint border between the two buttons.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Fix Firefox contenteditable tabbing

Use tabindex="0" instead of tabindex="" to indicate focusable content.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Angular MARC record update API repairs

Use the correct API when updating authority records.

Also use the correct bib record update API per LP 1859191.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Linker links to auth record editor

Adds a new UI at /staff/cat/authority/edit/ for finding authority
records by ID and editing authority records via the Angular MARC editor.

Modifies the "Cataloging" => "Retrieve Authority Record By ID" nav menu
entry to point to the Angular version of the interface.

Augments the MARC edit authority linking dialog to turn authority ID's
into links which open the authority record in its own MARC editor in a
new tab.

Misc. MARC editor repairs related to loading authority records by ID.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 Main entry link sets subfield 0

In the MARC editor, when applying a main entry heading, set the subfield
0 of the modified bib field to link to the authority record in question.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP1852782 More title attributes for action buttons

Adds title attributes to the Phys Char wizard and authority linking
buttons, which contain no text within the button proper.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>