Corrected version of kpac.xml with properly nested preset searches

This commit removes confirmation boxes popping up when a hyperlink is clicked

In PINES, we expect the behavior we've always had, so we revert the change.

Revert "Sort of in line with 949322 but not absolutely necessary"

This reverts commit e1a7501799119e0f305616af5bf97149d9bdf4c0.

Adding fix for KPAC hold placement.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

temporary workaround for holds error when user isn't logged in and doesn't select a pickup location

Conflicts:
Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm

fixed problem with referencing wrong org selector

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Attempt to fix default pickup location bug when user is not logged in.

Conflicts:
Open-ILS/src/templates/kpac/getit.tt2

Modified style guide to emphasize call numbers in search results and item display.

Temporarily hid Add to List functionality until it can be further developed.

Adding KPAC link to header and footer.

PINES KPAC landing page doesn't include the Print button.

Correcting file path for PINES logo on KPAC.

Removing "Bib Call Number" from the advanced numeric search options.

Commenting out Bib Call Number and uncommenting Call Number Browse.

Conflicts:
Open-ILS/src/templates/opac/parts/advanced/numeric.tt2

Allowing unfillable hold placement in the staff client, not the OPAC

In PINES, we do not allow patrons to override hold policies, but staff
may in certain circumstances.  This change makes the option visible in
the staff client, but not the OPAC.

Small changes to Search Limit names and Category names.

Further tweaks to search limits and modifications to book bag links.

Testing modifications to navigation.

Modifications to quick search functions and stylesheet.

Conflicts:

Open-ILS/web/css/skin/default/kpac/style.css

Image handling has changed in the new version...

Removing PINES-customized code that referred to a now-missing image.

Typo in footer.tt2 causing a server error.

Removing "kpac-original" directory in order to keep a clean source directory.

PINES customization of KPAC - beta ready for testing

Updated dewey.tt2

Initial commit of PINES KPAC customizations.

Conflicts:

Open-ILS/src/templates/kpac/home.tt2
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/src/templates/kpac/parts/header.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Conflicts:
Open-ILS/src/templates/kpac/parts/copy_table.tt2
Open-ILS/web/css/skin/default/kpac/style.css

Removing "You have permission to override some of the failed holds." OPAC message

Changing the default hold message for when an item is age protected.

PINES Survey Link - TPAC Edition

PINES does an online survey that runs for a week every Spring. These
changes create a red link to the survey above the search bar on the
OPAC home page.

Remove "Claims Never Checked Out" in Items Out summary

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>

adding in gmcharlt's fix for trailing TCN spaces

Conflicts:

Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm

adding new macros to listed ones

Adding GPLS Helpdesk link to Staff Client portal page and correcting a small typo

Conflicts:

Open-ILS/web/opac/locale/en-US/lang.dtd

Conflicts:
Open-ILS/xul/staff_client/server/index.xhtml

Revert "Use my_asv here.. surveys pertinent to the workstation library.. in case survey usage ever takes off.  Should probably move some of this to the middle layer"

This reverts commit 54d45c37d91c78cffa00ca3ff0f6298261d548b2.

adding file that returns circ mod view to normal

adding mrpeters' awesome favicon

adding PINES help links

Conflicts:

Open-ILS/src/templates/opac/parts/login/help.tt2

updating the username/password hints for the opac

Conflicts:

Open-ILS/src/templates/opac/parts/login/form.tt2
Open-ILS/src/templates/opac/parts/login/password_hint.tt2

improving the default hold message for range-protected items

Enabling the display of 856 field URLs for related resources

Password Length Helpers

This branch provides length helpers when patrons are setting or resetting
passwords.

This assumes the default 7 characters, 1 number requirement that comes stock.
You would need to change the hard coded strings if you use a different password
requirement regex in Library Settings Editor.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

Remove the hardcoded width of locg dropdown

The hard coded 12em width causes longer library names to be cut
off.  This removes that restriction.

Signed-off-by: Michael Peters <mpeters@emeralddata.net>

removing journal title and bib call number from query type selector dropdown

Conflicts:

Open-ILS/src/templates/opac/parts/qtype_selector.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/qtype_selector.tt2

adding newly designed PINES logos

removing bib level advanced search filter

Conflicts:

Open-ILS/src/templates/opac/parts/config.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/config.tt2

adding footer and topnav links and logo

Conflicts:

Open-ILS/src/templates/opac/parts/footer.tt2
Open-ILS/src/templates/opac/parts/topnav_logo.tt2

Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES GALILEO TPAC link and auth redirector

* adds a GALILEO link in the footer template
* adds a new TPAC URL target for /eg/opac/galileo, which redirects the
  user to the GALILEO URL, ensuring the user is first logged in.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

PINES/GALILEO avoid auth redirect within library

If the physical_loc is set, indicating the patron is physically at a
branch (via IP redirect), link directly to the GALILEO site with no
authentication pass-through.  GALILEO does not requires PINES auth
if the client is coming from a known IP address.

Signed-off-by: Bill Erickson <berick@esilibrary.com>
Conflicts:
Open-ILS/src/templates/opac/parts/footer.tt2

Sadly, GALILEO/EBSCO does not use HTTPS, so this will create errors for patrons who authenticate via PINES.  Reverting to HTTP.

Bumping version numbers, adding Upgrade Script and Changelog

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

bump up Perl version string

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - po files

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Translation updates - newpot

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

prune RELEASE_NOTES_NEXT

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

first rough pass at 3.4 release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Ensure "Reshelved" copies are still reshelving

Rather than "were reshelving when the query started"

Signed-off-by: Thomas Berezansky <tsbere@mvlc.org>

LP#1817645: adjust live_t remoteauth checks

Version 6.07 or higher of LWP::Protocol::https is required to
avoid an issue where an SSL certificate check of localhost
cannot be bypassed. We could instead have chosen to install
that Perl module from CPAN rather than packages, but since there's
presently no non-test code that requires that bugfix, I've elected
not to bother installing that module from CPAN for now.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: fix live perl test for basic auth API

The live perl test is failing because we are not passing all
the right parameters for ignoring the SSL certificate verification
checks. Pass another variable to see if this helps.

Signed-off-by: Ben Shum <ben@evergreener.net>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: (follow-up) avoid hardcoding user ID in a live_t test

This patch is an alternative implementation of an idea from
Ben Shum to avoid assuming that a given username in Concerto
will always be associated with the same patron ID.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Docs: cleaning up headings in 3.4 release notes

Signed-off-by: Jane Sandberg <sandbej@linnbenton.edu>

LP#1817645: Fix pgtap tests

There was a missing closing parenthesis on the pgtap tests from
this new feature.

Also, one of the comparisons had the wrong value matching and it
failed to pass. Inactive patrons return "not_found" rather than
"blocked" apparently.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1816475: Cleanup 950.data.seed-values.sql

When this branch was committed, some old seed data snuck back into
the file from LP#1759343 cleanup commit (eee5c5948ca).  Remove the
extra code to prevent duplicate INSERT errors.

Signed-off-by: Ben Shum <ben@evergreener.net>

LP#1068287: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1068287 UI tweak and renewal behavior

Skips the CREATE_PRECAT permission check when renewing pre-cataloged items.

Also disables all the elements except the Cancel button in the Pre-Cat dialog
when the user lacks the CREATE_PRECAT permission, and repositions the explanatory
text.

Also includes release notes.

Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1068287 - Add CREATE_PRECAT permission

Add this permission to prevent untrained/un-authorized
circ staff from creating pre-cat items due to mis-scanned
barcodes. Added to all profiles by default, so that staff
admins can pinpoint users who may not have it, i.e Volunteers, etc.

Signed-off by: Cesar Velez <cesar.velez@equinoxinitiative.org>
Signed-off-by: Jason Etheridge <jason@equinoxinitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1823255: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1823255: optionally require ident_value

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Mark Bucholtz <mbucholtz@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1811696: Add --rebuild-rmsr option to pingest.pl

Add the option to rebuild the reporter.materialized_simple_record
table to the pingest.pl support script.

Add release notes.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: release notes

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: fix ITEM_NOT_HOLDABLE event description

The main functionality for this enhancment produces toast messages for success
and failure, and the description for this particular event when testing had me
double-taking :)

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1841270: add Title Hold option in various places in staff client

* Adds a Title Hold option to certain invocations of Request Items
(Item Status, Copy Buckets, but not Holdings View)

* Switches count of items to count of titles when Title hold option
is selected

* Adds a checkbox for honoring the preferred notification settings
and default pickup library of the selected patron

* Adds a success/failure toast for Request Items

Signed-off-by: Jason Etheridge <jason@EquinoxInitiative.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

Lp 1799272: Option to Limit Hold Items in SIP2 msg 64 to Available

This commit adds an implementation option to the oils_sip.xml that,
when enabled, will limit the hold items list and hold items counts in
the patron information response (response 64) to only the holds
available for pickup by the patron.  When the setting is not enabled,
the full list of the patron's holds continues to be used.

Signed-off-by: Jason Stephenson <jason@sigio.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1731021 SIP fine detail fee type additions

Adds support for specifying different fee types in the fine/fee response
based on the most recent billing type of each transaction.

Thanks to Jason Stephenson for the initial implementation.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1731021 SIP Fine detail repairs / display fields

Resolve commit issues with the second commit from the source branch
working/user/dpearl/LP1731021_fine_item_detail

Migrating circ title/author lookup to use metabib display fields instead
of MVR's.

Minor code refactoring.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1731021: Support fine detail enhancement to SIP.

The particular flavor of fine detail output is manufacturer dependent,
although 3m is popular, and the default.  To configure the selection,
modify the /openils/conf/oils_sip.xml file.

Testing: See the /openils/conf/oils_sip.xml file and test all supported
values for the av_format option.  You should also test the case where
the option is omitted, or a non-supported value.  I am not sure what
happens if you supply more than one option with same or different
values, but this is a non-supported degenerate case.

For each test value, ensure tha the fine item detail is the expected
format.

Signed-off-by: Dan Pearl <dpearl@cwmars.org>
Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1444644: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1444644 Copy Import Development Work

Two new options for importing holdings have been added to MARC Batch
Import/Export:

1) Auto-overlay On-order Cataloguing Copies

This is similar to "Auto-overlay In-process Acquisitions Copies," but
for copies that were not created from an acquisitions workflow.
Holdings information in the incoming record will be used to overlay any
existing On Order copies for the matching record which belong to the
owning library defined in the Holdings Import Profile.  The Holdings
Import Profile is also used to match incoming to existing copies, if
possible; otherwise, On Order copies are overlaid in the order they were
created.  The call number will also be overlaid if the incoming record
provides one.

2) Use Org Unit Matching in Copy to Determine Best Match

When there are multiple potential matching records, this feature allows
the user to automatically select the record which has the most copies at
libraries near the importing library in the org tree.  That is, starting
at the importing library, it climbs the org tree, gradually expanding
the scope at which it checks for holdings on matching records; once
holdings are found, the record with the most holdings at that scope is
selected for overlay.  If there are no matching records with holdings,
then the default best match overlay is attempted.

Two new permissions are added to control the use of these new features.

Signed-off-by: Liam Whalen <liam.whalen@bc.libraries.coop>
Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1728331 - Action Trigger Aggregator Date Parameter

- Added release notes.
- Added note about script to support scripts doc.
- Added script to makefile for confile processing and installation.
- Added processed version of the script to .gitignore

I tested out the script with our production data and it worked as described.

Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP1728331: A/T Aggregator Date Parameter

Adds a --date parameter to action_trigger_aggregator.pl
to make it simpler to pull events for a single day when
that day isn't "today."

Signed-off-by: Jason Boyer <jboyer@library.in.gov>
Signed-off-by: Josh Stompro <stompro@stompro.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1786552: AuthProxy: release note for LDAP bind_user and restrict_by_home_ou

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1786552: AuthProxy: restrict_by_home_ou based on authenticator org_units

It makes more sense to check the patron's home library against the org
units to which the authenticator applies, rather than the login org
param.

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1786552: optionally restrict auth_proxy login by home OU

This adds a new restrict_by_home_ou setting to auth_proxy authenticator
config.  When enabled, if the login request includes an org param, the
authenticator will refuse to authenticate a user unless their home OU
matches or is a descendant of that org; login fails and auth_proxy
proceeds to the next configured authenticator.

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1786552: LDAP bind user option

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802: stamp database update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 - Add new aged/all billing/payment sources to aged/all circ sources.

The new aged/all billing/payment sources need to be included
in the aged/all circulations reporting sources.

Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Age circ ages payments before billings

When aging a circulation, payments must be deleted before billings,
since account_adjustements (payment) reference billings.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Billing/payment purge improvements

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Aged billings/payments release notes

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Aged billings/payments PGTAP tests

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Add money.all_[payments|billings] views

Similar to money.all_circulation_slim, add views to collect data from
both active and aged versions of the payment and billing tables.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1793802 Aged billings and payments

Creates tables money.aged_billing and money.aged_payment.  When a
circulation is aged, billings/payments linked to the circ are migrated
to the aged_* table.

Upgrade script includes a migration script for migrating existing
billings and payments.

Includes IDL entries for reporting and pcrud access just in case it's
needed.  Note the 'xact' column on these new tables links directly to
the aged circulation instead of the non-existent money.billable_xact.

Signed-off-by: Bill Erickson <berickxx@gmail.com>
Signed-off-by: Chris Sharp <csharp@georgialibraries.org>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: add release notes

These are taken from the introduction of the technical reference
docs written by Jeff Davis.

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: stamp schema update

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: (follow-up) sync schema update script

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: use label as reporter:selector for user activity type

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: add RemoteAuth profiles to Angular server admin

Signed-off-by: Jeff Davis <jdavis@sitka.bclibraries.ca>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: track RemoteAuth user activity

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: RemoteAuth documentation

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: RemoteAuth Perl live test for basic HTTP authentication (RFC 7617)

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: RemoteAuth pgTAP test

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: sample data for testing remote patron auth

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: RemoteAuth handler for basic HTTP authentication (RFC 7617)

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1817645: configurable HTTP API for patron auth/retrieval

Signed-off-by: Jeff Davis <jeff.davis@bc.libraries.coop>
Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1840327: add release notes

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>

LP#1840327: (follow-up) various fixes and improvements

* Fixed inabiilty to set the name for a new standing penalty
* Fixed the 'Delete Selected' action
* adjust for recId => recordId change to FM record editor
* remove a bit of copy-and-paste-itis
* Lint repairs

Signed-off-by: Galen Charlton <gmc@equinoxinitiative.org>